Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
QPointer
to trackplaylistItem
lifetime inviewStateHandler
. This removes the need for theitemAboutToBeDeleted
signal and the slot.Hold a few other members either by value or by owning smart pointers.
Hold other weak
QObject
pointers usingQPointer
. AQPointer
tracks the underlying object's lifetime and automatically resets itself to nullptr when the object is destroyed. This prevents dereferencing dangling pointers.Please test the functionality related to Ctrl-1...8 view state saving. I'm not sure how it's supposed to work and don't want to miss anything important there.