Safety 3 #51
Merged
Safety 3 #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you very much for contributing. Seems stable on Arch Linux / Gnome , but after opening a yuv-file the window scales to a size which is larger than the screen size and maximizing is not possible. Please report whether that is also the case on windows or OS X. |
|
No I can't reproduce that on windows. This also sounds strange to me becuase I think I removed all the code that actively changes the size of the main window. |
KubaO
added a commit
to KubaO/YUView
that referenced
this pull request
Nov 13, 2016
This merges pull request IENT#51 from KubaO/safety-3 1. Hold playlistItem::propertiesWidget and playlistItemRawFile::video via smart pointer. 2. Hold viewStateHandler's weak QObject pointers in QPointers. 3. Hold other weak QObject pointers in QPointers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
QPointerto trackplaylistItemlifetime inviewStateHandler. This removes the need for theitemAboutToBeDeletedsignal and the slot.Hold a few other members either by value or by owning smart pointers.
Hold other weak
QObjectpointers usingQPointer. AQPointertracks the underlying object's lifetime and automatically resets itself to nullptr when the object is destroyed. This prevents dereferencing dangling pointers.Please test the functionality related to Ctrl-1...8 view state saving. I'm not sure how it's supposed to work and don't want to miss anything important there.