Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a file with laravel valet notes #187

Merged
merged 12 commits into from
May 25, 2018
Merged

add a file with laravel valet notes #187

merged 12 commits into from
May 25, 2018

Conversation

benlk
Copy link
Collaborator

@benlk benlk commented Feb 15, 2018

This is a WIP

Questions yet to be resolved:

  • where should the contents of this file be added?
  • what else needs to be updated to reference the valet setup process?
  • what should we do with pre-valet docs, other than cutting them out into a separate file for historical reference?
  • what non-inn/docs docs need to be updated to match?
    • INN/umbrella-boilerplate needs to have install/config instructions simplified, pointing to this repo's documentation for getting set up with Valet or Vagrant

@benlk
Copy link
Collaborator Author

benlk commented Feb 27, 2018

Things that need to be updated to reference the Valet setup process:

I'm in favor of cutting the pre-valet docs out into a separate file for historical purposes, in a directory off of docs/projects/largo that contains:

  • Readme.md linking to historical vvv docs and modern valet docs
  • historical vvv docs, with suitable "this is old and has problems" preface
  • valet docs, with references to yo wordpress replaced by the suitable wp-cli commands, because hooray standardization!

As part of updating every single umbrella, we should pare the setup docs in those umbrellas down to the bits that are specific to moving files around, and then link out to the appropriate parts of INN/docs/projects/largo/umbrella-setup/readme.md for the database setup and configuration. This way, someone coming across an umbrella repo won't get stuck with instructions from 2016, like just happened in Helpscout conversation 1794.

@tylermachado
Copy link
Contributor

two ideas while running through these on the FactTrack install:

  1. does the git submodule update... part need to be in there twice?
  2. is it too overbearing to mention valet park and valet secure as a step?

@benlk
Copy link
Collaborator Author

benlk commented Apr 5, 2018

Good ideas.

  • removed the second git submodule update --init --recursive
  • added valet park and valet secure
  • added advice for finding your valet sites directory

@benlk benlk merged commit 700ef0d into master May 25, 2018
@benlk benlk deleted the benlk-setup-notes-update branch August 31, 2018 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants