Update CreateDataset use case to allow non-default dataset types #373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g-saracca
approved these changes
Sep 24, 2025
github-project-automation
bot
moved this from In Review 🔎
to Ready for QA ⏩
in IQSS Dataverse Project
|
looks good - merging |
github-project-automation
bot
moved this from Ready for QA ⏩
to Merged 🚀
in IQSS Dataverse Project
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The CreateDataset use case already implicitly persists datasets with the default dataset type "dataset".
This pull request updates this use case to allow non-default dataset types to be persisted, such as "software", "workflow", or "review".
Which issue(s) this PR closes:
Related Dataverse PRs:
Special notes for your reviewer:
Note the PR above that should be merged first. I'm targeting its branch so the diff is clearer. When the PR above is merged, this PR should target develop automatically.
Suggestions on how to test this:
Is there a release notes or changelog update needed for this change?:
Yes, I'll add something. I'm waiting for the changelog PR to make it into the PR above and then this one.
Additional documentation:
None.