Skip to content

Conversation

pdurbin
Copy link
Member

@pdurbin pdurbin commented Sep 23, 2025

What this PR does / why we need it:

The promise of a dataset type has been that if you link a metadata block with it (e.g. linking CodeMeta to a software type), those extra fields will be available to you (displayed on create) when you create a dataset.

Which issue(s) this PR closes:

Related Dataverse PRs:

Special notes for your reviewer:

The existing code doesn't have any tests that I could find. yolo!

If you point me to the tests I'm happy to edit them.

If you want me to write tests from scratch, I'm happy to do that too. 😄

Suggestions on how to test this:

First, add a dataset type called "foobar" that's associated with a non-citation metadata block like geospatial.

Then, try something like this:

const getBlocks = await getCollectionMetadataBlocks.execute(':root', true, 'foobar')
console.log(getBlocks);

Is there a release notes or changelog update needed for this change?:

Yes, coming.

Additional documentation:

None.

@pdurbin pdurbin added the GREI Re-arch GREI re-architecture-related label Sep 23, 2025
@pdurbin pdurbin moved this to Ready for Review ⏩ in IQSS Dataverse Project Sep 23, 2025
@cmbz cmbz added the FY26 Sprint 6 FY26 Sprint 6 (2025-09-10 - 2025-09-24) label Sep 24, 2025
Base automatically changed from 359-create-dataset-datasettype to develop September 24, 2025 21:23
@cmbz cmbz added the FY26 Sprint 7 FY26 Sprint 7 (2025-09-24 - 2025-10-08) label Sep 24, 2025
@github-project-automation github-project-automation bot moved this from Ready for Review ⏩ to Ready for QA ⏩ in IQSS Dataverse Project Sep 25, 2025
@ofahimIQSS
Copy link
Contributor

tests passing - merging PR

@ofahimIQSS ofahimIQSS merged commit 351424d into develop Sep 26, 2025
6 checks passed
@github-project-automation github-project-automation bot moved this from Ready for QA ⏩ to Merged 🚀 in IQSS Dataverse Project Sep 26, 2025
@ofahimIQSS ofahimIQSS deleted the 210-get-blocks-datasettype branch September 26, 2025 16:25
@pdurbin pdurbin moved this from Merged 🚀 to Done 🧹 in IQSS Dataverse Project Sep 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FY26 Sprint 6 FY26 Sprint 6 (2025-09-10 - 2025-09-24) FY26 Sprint 7 FY26 Sprint 7 (2025-09-24 - 2025-10-08) GREI Re-arch GREI re-architecture-related

Projects

Status: Done 🧹

Development

Successfully merging this pull request may close these issues.

extend the getCollectionMetadataBlocks use case to allow passing datasetType

4 participants