Typos #200

kinow · 2018-09-17T11:53:39Z

Hi,

We found a few typos in opengeospatial/geoapi that can probably be ported back to this repository.

I am not sure if I haven't changed one too many files. If so, please let me know and I will edit the commit.

Thanks!
Bruno

desruisseaux

Thank you very much! But I suggest to split in different pull requests based not on the modified words, but rather on the modified files and modified elements inside the files:

All <xs:documentation> or <documentation> elements in XSD files: in my understanding, those ones can be safely changed since they are not programmatic elements.
All <gco:CharacterString> elements in codelists.xml file (I think).
Any elements incodelists.html file.
Maybe *.sch file, but I'm not sure what those files are (but the changes look like in documentation).
README.md file.

In particular, I think that the <element> and <identifier> elements in XSD files need to stay unchanged because they are supposed to reflect the ISO 19115 standards. In my understanding, changing those elements would require to change ISO 19115 first.

standards.iso.org.annotated/iso/19115/-3/mac/1.0/acquisitionInformationImagery.xsd

desruisseaux · 2018-09-17T12:08:11Z

standards.iso.org.annotated/iso/19115/resources/Codelist/gml/MD_CoverageContentTypeCode.xml

@@ -22,7 +22,7 @@
  <dictionaryEntry>
    <Definition gml:id="_12506_19361">
      <description>data, usually a physical measurement, used to support the calculation of the primary physicalMeasurement coverages in the dataset (e.g. grid of aerosol optical thickness used in the calculation of a sea surface temperature product).</description>
-      <identifier codeSpace="http://www.isotc211.org/2014/mrc/1.0/2014-07-11/MD_CoverageContentTypeCode">auxilliaryInformation</identifier>
+      <identifier codeSpace="http://www.isotc211.org/2014/mrc/1.0/2014-07-11/MD_CoverageContentTypeCode">auxiliaryInformation</identifier>


The typo is in ISO 19115-1 standard, so we may not be able to change it in the XSD (I guess we would need the standard to be changed first).

desruisseaux · 2018-09-17T12:09:18Z

standards.iso.org.annotated/iso/19115/resources/transforms/ISO19139/mapping/core.xsl

@@ -433,9 +433,9 @@
      </xsl:element>
    </xsl:element>
  </xsl:template>
-  <xsl:template match="gmi:objectiveOccurance" mode="from19139to19115-3">
+  <xsl:template match="gmi:objectiveOccurrence" mode="from19139to19115-3">


We need to preserve the typo since the intend is to map elements from the old XSD, which used that spelling.

in the UML , the property name is 'objectiveOccurence', so gmi:objectiveOccurance should actually be updated to gmi:objectiveOccurence

desruisseaux · 2018-09-17T12:09:28Z

standards.iso.org.annotated/iso/19115/resources/transforms/ISO19139/mapping/core.xsl

    <!-- This element is mis-spelled in the 19115-2 schema -->
-    <xsl:element name="mac:objectiveOccurence">
+    <xsl:element name="mac:objectiveOccurrence">


We need to preserve the typo since the intend is to map elements from the old XSD, which used that spelling.

desruisseaux · 2018-09-17T12:10:33Z

standards.iso.org/iso/19115/-3/mac/1.0/acquisitionInformationImagery.xsd

@@ -235,7 +235,7 @@ shortName: trgtExtent</documentation>
          </element>
          <element maxOccurs="unbounded" minOccurs="0" name="sensingInstrument" type="mac:MI_Instrument_PropertyType"/>
          <element maxOccurs="unbounded" minOccurs="0" name="pass" type="mac:MI_PlatformPass_PropertyType"/>
-          <element maxOccurs="unbounded" name="objectiveOccurence" type="mac:MI_Event_PropertyType"/>
+          <element maxOccurs="unbounded" name="objectiveOccurrence" type="mac:MI_Event_PropertyType"/>


The typo is in the ISO 19115 specification.

desruisseaux · 2018-09-17T12:11:00Z

standards.iso.org/iso/19115/-3/mac/2.0/acquisitionInformationImagery.xsd

@@ -241,7 +241,7 @@
          </element>
          <element maxOccurs="unbounded" minOccurs="0" name="sensingInstrument" type="mac:MI_Instrument_PropertyType"/>
          <element maxOccurs="unbounded" minOccurs="0" name="pass" type="mac:MI_PlatformPass_PropertyType"/>
-          <element maxOccurs="unbounded" name="objectiveOccurence" type="mac:MI_Event_PropertyType"/>
+          <element maxOccurs="unbounded" name="objectiveOccurrence" type="mac:MI_Event_PropertyType"/>


The typo is in ISO 19115 specification.

desruisseaux · 2018-09-17T12:12:15Z

standards.iso.org/iso/19115/resources/Codelists/gml/MD_CoverageContentTypeCode.xml

@@ -22,7 +22,7 @@
  <dictionaryEntry>
    <Definition gml:id="_12506_19361">
      <description>data, usually a physical measurement, used to support the calculation of the primary physicalMeasurement coverages in the dataset (e.g. grid of aerosol optical thickness used in the calculation of a sea surface temperature product).</description>
-      <identifier codeSpace="http://standards.iso.org/iso/19115/-3/mrc/1.0">auxilliaryInformation</identifier>
+      <identifier codeSpace="http://standards.iso.org/iso/19115/-3/mrc/1.0">auxiliaryInformation</identifier>


The typo is in ISO 19115 specification.

desruisseaux · 2018-09-17T12:13:03Z

standards.iso.org/iso/19115/resources/transforms/ISO19139/mapping/core.xsl

    <!-- This element is mis-spelled in the 19115-2 schema -->
-    <xsl:element name="mac:objectiveOccurence">
+    <xsl:element name="mac:objectiveOccurrence">


We need to preserve the spelling used by XML elements, even if this is a typo.

In the UML for ISO19115-2 Edition 1 and Edition 2, and in ISO19115-3 Acquisition information - Imagery package, the association from MI_Objective to MI_Event is named 'objectiveOccurence', but in the XML implementation at http://standards.iso.org/iso/19115/-2/gmi/1.0/acquisitionInformation.xsd, it's spelled 'objectiveOccurance'. The spelling 'gmi:objectiveOccurance' must be used in the xsl file, since that's what's in the xml schema. Correcting the typo to match what's in the UML requires an amendment to the spec.
The ISO19115-3 xml implementation (http://standards.iso.org/iso/19115/-3/mac/1.0/acquisitionInformationImagery.xsd) has the typo from the UML (mac:objectiveOccurence)
The xsl has the correct (mis)spellings, don't change

Hello all, sorry for delay getting back on this... just too busy these days.

In general the discussion is correct - we can change annotations but not mis-spelled elements (we could do a corrigendum, but may be too late)...

Also wanted to make sure that everyone understands that the annotated schema is not the official schema and is not supported in any way by ISO TC211. It was a project a few people started with the hope that it would be useful and that the community would help support it. Thanks so much for help with the spelling...

Another note - the new and complete schemas have now been uploaded to standards.iso.org. There are a number of new namespaces that have Version 2 directories. I will update those in the annotated schemas soon. We may need a mechanism for transferring annotations across to the new namespace versions... Will also think about that...

kinow · 2018-09-17T12:28:12Z

Thanks for the quick reply @desruisseaux ! Will leave as-is for a couple of days to see what others think, then will start updating as you suggested 🕺

kinow · 2018-09-19T09:03:33Z

Updated the commit to reflect the comments, but will revisit it later to follow @desruisseaux 's first message, and see if there are still files that need to be reverted. Or maybe start separate pull requests...

Thanks everybody for the review!

desruisseaux

Thanks for the new changes, they looks good. Attached comments on two elements.

desruisseaux · 2018-09-19T10:47:35Z

standards.iso.org.annotated/iso/19115/resources/transforms/ISO19139/mapping/core.xsl

@@ -435,7 +435,7 @@
  </xsl:template>
  <xsl:template match="gmi:objectiveOccurance" mode="from19139to19115-3">
    <!-- This element is mis-spelled in the 19115-2 schema -->
-    <xsl:element name="mac:objectiveOccurence">
+    <xsl:element name="objectiveOccurence">


Should we keep the "mac" prefix?

Oh, my mistake, didn't mean to remove the prefix. Fixing now.

desruisseaux · 2018-09-19T10:50:16Z

standards.iso.org/iso/19115/resources/transforms/ISO19139/mapping/core.xsl

@@ -433,7 +433,7 @@
      </xsl:element>
    </xsl:element>
  </xsl:template>
-  <xsl:template match="gmi:objectiveOccurance" mode="from19139to19115-3">
+  <xsl:template match="gmi:objectiveOccurrence" mode="from19139to19115-3">


While objectiveOccurrence is the correct spelling, I think that the spelling used in ISO 19115-3 was objectiveOccurence with only one "r". So this fix would need to only replace the "a" into "e" without adding "r".

Reverted to gmi:objectiveOccurence. Thanks @desruisseaux !!!

kinow added 7 commits September 17, 2018 23:21

s/occured/occurred

c534ad6

s/identifer/identifier

4243b43

s/avaialble/available

5fd4773

s/desimination/dissemination

e38298f

s/occurence/occurrence and s/occurance/occurrence

07d1a68

s/temportal/temporal

a643f6e

s/recieve/receive

65b04c9

kinow mentioned this pull request Sep 17, 2018

Minor fixes and typos opengeospatial/geoapi#41

Merged

desruisseaux reviewed Sep 17, 2018

View reviewed changes

kinow force-pushed the typos branch from 3282906 to f0e9fe3 Compare September 19, 2018 09:00

desruisseaux added a commit to opengeospatial/geoapi that referenced this pull request Sep 19, 2018

Add more spelling corrections identified as part of ISO-TC211/XML#200

6204c4f

desruisseaux reviewed Sep 19, 2018

View reviewed changes

s/auxilliary/auxiliary

8319853

kinow force-pushed the typos branch from f0e9fe3 to 8319853 Compare September 19, 2018 11:18

ejbleys closed this Oct 31, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Typos #200

Typos #200

kinow commented Sep 17, 2018

desruisseaux left a comment

desruisseaux Sep 17, 2018

desruisseaux Sep 17, 2018

smrgeoinfo Sep 17, 2018

desruisseaux Sep 17, 2018

desruisseaux Sep 17, 2018

smrgeoinfo Sep 17, 2018

desruisseaux Sep 17, 2018

desruisseaux Sep 17, 2018

desruisseaux Sep 17, 2018

smrgeoinfo Sep 17, 2018 •

edited

Loading

tedhabermann Sep 18, 2018

kinow commented Sep 17, 2018

kinow commented Sep 19, 2018

desruisseaux left a comment

desruisseaux Sep 19, 2018

kinow Sep 19, 2018

desruisseaux Sep 19, 2018

kinow Sep 19, 2018

Typos #200

Typos #200

Conversation

kinow commented Sep 17, 2018

desruisseaux left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

smrgeoinfo Sep 17, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kinow commented Sep 17, 2018

kinow commented Sep 19, 2018

desruisseaux left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

smrgeoinfo Sep 17, 2018 •

edited

Loading