Fix for POST requests failing with 500 #144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohe
pushed a commit
that referenced
this pull request
Sep 29, 2014
Fix for POST requests failing with 500
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seems to be a problem with the _get_post() method in the SAML2Plugin for repoze.who. When used with pyramid and repoze.who, all POST requests fail with code 500 as soon as pysaml2 is set as a repoze.who identifier plugin. This is because at the time pyramid is reading the environ dict, CONTENT_LENGTH is set to the size of the POST request, but environ[wsgi.input] is empty. My guess is that the restoring of environ['wsgi.input'] via
is ineffective because environ['wsgi.input'] is emptied/read again afterwards by cgi.FieldStorage().
I replaced _get_post() with a simplier method using parse_qs to get a dict of the POST parameters and removed the now unneeded cgi_field_storage method. environ['wsgi.input'] is restored immediately after reading it and is never touched again.