Add support for SingleSignOnService/prepare_for_authentication with HTTP-POST binding #181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we should keep backwards compatibility and therefor make it a separate method. |
|
@rohe: Hello there. Do you have a suggestion for what to name this other method? How does |
|
@rohe: I pushed up a new version that adds |
Warning, this changes the return type of `prepare_for_authentication` by including the chosen binding, and opens the door for supporting other SingleSignOnService bindings.
|
@rohe: I've updated the patch so it merges again. Does it look good to merge? |
|
@rohe: Just checking in if you've had a chance to look it over :) |
rohe
pushed a commit
that referenced
this pull request
Apr 24, 2015
Add support for SingleSignOnService/prepare_for_authentication with HTTP-POST binding
|
Thanks @rohe! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning, this changes the return type of
prepare_for_authenticationby including the chosen binding, and opens the door for supporting other SingleSignOnService bindings. If we want to maintain backwards compatibility though we could make a different function.