Fix timestamp validation error message #312
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes 2 things: 1.) First, the values were exchanged according to the comparison order 2.) Second, the slack was not included in the messages, leaving the possibility of printing confusing message. I decided to add or substract (respectively) the slack from "now" instead of nooa/nbefore, since "now" is more volatile and there's a better chance that people could try to search for the nooa/nbefore numbers in the dumps (encapsulated in SAML messages) rather then for the ever-changing value of "now".
rohe
pushed a commit
that referenced
this pull request
Feb 11, 2016
…message Fix timestamp validation error message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes 2 things:
1.) First, the values were exchanged according to the comparison order
2.) Second, the slack was not included in the messages, leaving the possibility of printing
confusing message. I decided to add or substract (respectively) the slack from "now" instead
of nooa/nbefore, since "now" is more volatile and there's a better chance that people could
try to search for the nooa/nbefore numbers in the dumps (encapsulated in SAML messages) rather
then for the ever-changing value of "now".