Skip to content

Support session not on or after #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 22, 2016
Merged

Support session not on or after #351

merged 2 commits into from
Sep 22, 2016

Conversation

ashimaathri
Copy link
Contributor

@ashimaathri ashimaathri commented Aug 18, 2016 •
edited
Loading

Hi,

The samlp.AuthnResponse class allows setting the session_not_on_or_after attribute. However, none of the methods that create an AuthnResponse actually allow passing this parameter in. So, this change adds session_not_on_on_after a parameter to all the ancestor methods of the method authn_response.

Please let me know if there's something that needs to be changed/improved.

Thanks!
Ashima

@jaustinpage
Copy link

Looks good to me, 👍

@rohe rohe merged commit 4769e53 into IdentityPython:master Sep 22, 2016
@jaustinpage jaustinpage mentioned this pull request Sep 27, 2016
Closed
@ashimaathri ashimaathri deleted the support-session-not-on-or-after branch October 19, 2016 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ashimaathri @jaustinpage @rohe