Correctly pull the SAMLRequest from Redirect LogoutRequests #394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c00kiemon5ter
force-pushed
the
redirect-logout-requests
branch
from
c0a7cfb to
6f1d6f5
Compare
Codecov Report
@@ Coverage Diff @@
## master #394 +/- ##
==========================================
- Coverage 65.47% 65.46% -0.01%
==========================================
Files 103 103
Lines 25681 25684 +3
==========================================
Hits 16815 16815
- Misses 8866 8869 +3
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where SAMLRequest is a key within
postwith a string value, thereforesaml_request = post["SAMLRequest"][0]returned just the first letter of the SAMLRequest query string parameter. I am assuming thatpostis structured differently because the LogoutRequest uses a Redirect binding and there are different methods for parsing the request.