initial support for single logout in s2repoze #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a new repoze config option path_logout to the challenge decider plugin. When a request is received on this url a global logout request is initiated. Responses to this request is received on the single_logout_service endpoint of the sp as configured in saml config of the sp. Tested with only on IdP and only using HTTP_REDIRECT bindings TODO: handle receiving logout requests on the single_logout_service endpoint
If for some reason the session cookie outlives the saml clients cache, for instance if the webservice is restarted there could be an inconsistent state where the user is authenticated but saml attributes are missing and saml logout requests will fail. By using only saml2sp as authenticator plugin and repoze.who 2.0 this little check will work around that and require a new login in this case
rohe
pushed a commit
that referenced
this pull request
Jun 22, 2013
initial support for single logout in s2repoze
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.