Skip to content

Add attribute map for Microsoft ADFS integration #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 29, 2013
Merged

Add attribute map for Microsoft ADFS integration #52

merged 2 commits into from
Jul 29, 2013

Conversation

ccooper21
Copy link
Contributor

No description provided.

@ccooper21
Copy link
Contributor Author

I submitted a pull request containing the attribute maps for integrating with Microsoft ADFS v1.x and v2.0. I put the new files in the example/attributemaps directory, but maybe they would better be located elsewhere.

See http://technet.microsoft.com/en-us/library/cc733065(v=ws.10).aspx and http://technet.microsoft.com/en-us/library/ee913589(v=ws.10).aspx for information regarding the default claim types supported by Microsoft ADFS v1.x and v2.0 respectively.

@ccooper21
Copy link
Contributor Author

One slightly odd thing I encountered is that the Microsoft documentation uses mixed case in some of the attribute URIs. However, my customer's live IdP system against which I am testing always returns the URIs in lower case. I don't really know why this discrepancy exists, but if the case is different between what is in the attribute map and the IdP actually returns no mapping occurs. As such, I made the URIs in the attribute map lowercase to get everything working. Are URIs inherently case insensitive?

rohe pushed a commit that referenced this pull request Jul 29, 2013
Add attribute map for Microsoft ADFS integration
@rohe rohe merged commit 553d0e8 into IdentityPython:master Jul 29, 2013
@rohe
Copy link
Contributor

rohe commented Jul 29, 2013

26 jul 2013 kl. 18:12 skrev Christopher Cooper notifications@github.com:

One slightly odd thing I encountered is that the Microsoft documentation uses mixed case in some of the attribute URIs. However, my customer's live IdP system against which I am testing always returns the URIs in lower case. I don't really know why this discrepancy exists, but if the case is different between what is in the attribute map and the IdP actually returns no mapping occurs. As such, I made the URIs in the attribute map lowercase to get everything working. Are URIs inherently case insensitive?

No, it's actually up to the ones who define the URI schemas do define that.
All the schemas I know about are case insensitive.

-- Roland
"Education is the path from cocky ignorance to miserable uncertainty.” - Mark Twain

@ccooper21
Copy link
Contributor Author

All the schemas I know about are case insensitive.

Would it make sense for "pysaml2" to support an option associated with each attribute map indicating whether a case sensitive or insensitive match should be used?

@rohe
Copy link
Contributor

rohe commented Jul 29, 2013

29 jul 2013 kl. 18:29 skrev Christopher Cooper notifications@github.com:

All the schemas I know about are case insensitive.

Would it make sense for "pysaml2" to have an option associated with each attribute map indicating whether a case sensitive or insensitive match should be used?

I think not, I think using case insensitive match should always be used.
Saying that I have to make sure it is actually done that way.

-- Roland
"Education is the path from cocky ignorance to miserable uncertainty.” - Mark Twain

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants