Skip to content

Fix return format of Response._response #561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 19, 2018

Conversation

erakli
Copy link

@erakli erakli commented Nov 19, 2018

This change needed for python3 code to work. Need help from more experienced folks to correctly test this.

All Submissions:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what problem you are trying to solve with this PR?
  • Have you added information on what your changes do and why you chose this as your solution?
  • Have you written new tests for your changes?
  • Does your submission pass tests?
  • This project follows PEP8 style guide. Have you run your code against the 'flake8' linter?

@codecov-io
Copy link

codecov-io commented Nov 19, 2018

Codecov Report

Merging #561 into master will increase coverage by 0.04%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #561      +/-   ##
==========================================
+ Coverage   65.53%   65.57%   +0.04%     
==========================================
  Files         103      103              
  Lines       25568    25568              
==========================================
+ Hits        16755    16767      +12     
+ Misses       8813     8801      -12
Impacted Files Coverage Δ
src/saml2/httputil.py 0% <0%> (ø) ⬆️
src/saml2/__init__.py 86.52% <0%> (+0.18%) ⬆️
src/saml2/validate.py 79.21% <0%> (+4.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef65dbf...aeff86b. Read the comment docs.

Signed-off-by: Ivan Kanakarakis <ivan.kanak@gmail.com>
@c00kiemon5ter c00kiemon5ter merged commit 303e6ad into IdentityPython:master Nov 19, 2018
@erakli erakli deleted the fix_response_encoding branch November 19, 2018 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants