Skip to content

Conversation

skanct
Copy link
Contributor

@skanct skanct commented Nov 28, 2018

This pull request adds support for the metadata attribute http://macedir.org/entity-category-support. This is required (at least) for the IdPs expressing support for entity categories like the research and scholarship and code of conduct

Submission checklist:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what problem you are trying to solve with this PR?
  • Have you added information on what your changes do and why you chose this as your solution?
  • Have you written new tests for your changes?
  • Does your submission pass tests?
  • This project follows PEP8 style guide. Have you run your code against the 'flake8' linter?

@c00kiemon5ter c00kiemon5ter merged commit 6b24eb2 into IdentityPython:master Nov 28, 2018
@codecov-io
Copy link

Codecov Report

Merging #573 into master will decrease coverage by 0.04%.
The diff coverage is 28.57%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #573      +/-   ##
=========================================
- Coverage   65.64%   65.6%   -0.05%     
=========================================
  Files         103     103              
  Lines       25594   25601       +7     
=========================================
- Hits        16801   16795       -6     
- Misses       8793    8806      +13
Impacted Files Coverage Δ
src/saml2/config.py 84.52% <100%> (+0.04%) ⬆️
src/saml2/metadata.py 45.17% <16.66%> (-0.34%) ⬇️
src/saml2/validate.py 74.9% <0%> (-3.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c1e26a...925fd0d. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants