Skip to content

Conversation

rectalogic
Copy link
Contributor

This test passes in v4.6.3 but is failing in v4.6.4 due to #571

All Submissions:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what problem you are trying to solve with this PR?
  • Have you added information on what your changes do and why you chose this as your solution?
  • Have you written new tests for your changes?
  • Does your submission pass tests?
  • This project follows PEP8 style guide. Have you run your code against the 'flake8' linter?

@codecov-io
Copy link

codecov-io commented Nov 28, 2018

Codecov Report

Merging #574 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #574      +/-   ##
==========================================
+ Coverage   65.62%   65.67%   +0.05%     
==========================================
  Files         103      103              
  Lines       25601    25599       -2     
==========================================
+ Hits        16801    16813      +12     
+ Misses       8800     8786      -14
Impacted Files Coverage Δ
src/saml2/entity.py 85.49% <ø> (+0.26%) ⬆️
src/saml2/validate.py 77.64% <0%> (+0.39%) ⬆️
src/saml2/client_base.py 77.34% <0%> (+0.48%) ⬆️
src/saml2/time_util.py 87.42% <0%> (+0.59%) ⬆️
src/saml2/response.py 73.79% <0%> (+1.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b24eb2...6a179ff. Read the comment docs.

@c00kiemon5ter c00kiemon5ter merged commit 12a01b6 into IdentityPython:master Dec 4, 2018
@c00kiemon5ter
Copy link
Member

Thank you, both for the catch and the complete PR with the test. I'm preparing a new release with this fix now.

@c00kiemon5ter
Copy link
Member

v4.6.5 is out with this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants