Skip to content

Set the default attribute NameFormat to NAME_FORMAT_UNSPECIFIED #704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from Sep 29, 2020
Merged

Set the default attribute NameFormat to NAME_FORMAT_UNSPECIFIED #704

merged 3 commits into from Sep 29, 2020

Conversation

ghost
Copy link

@ghost ghost commented Jul 24, 2020

All Submissions:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what problem you are trying to solve with this PR?
  • Have you added information on what your changes do and why you chose this as your solution?
  • Have you written new tests for your changes? (tests written by @c00kiemon5ter)
  • Does your submission pass tests?
  • This project follows PEP8 style guide. Have you run your code against the 'flake8' linter?

Explanation:

Section 2.7.3.1 of the spec states that:

If no NameFormat value is provided,the identifier urn:oasis:names:tc:SAML:2.0:attrname-format:unspecified (see Section8.2.1) is in effect.

However currently pysaml2 is interpreting such attributes as urn:oasis:names:tc:SAML:2.0:attrname-format:uri. This simply sets the default to NAME_FORMAT_UNSPECIFIED and in doing so addresses #601

@ghost
Copy link
Author

ghost commented Aug 11, 2020

Updated to use and pass tests written by @c00kiemon5ter. Had to update the validUntil year in the test XML files as anything later than 3001 wasn't recognized as a valid parameter on Windows.

Sorry for the delay, it took me a while to be able to get my Windows environment set up to be able to run the tests without tempfile errors.

@c00kiemon5ter
Copy link
Member

Thanks @Canderson90

@ghost ghost deleted the fix-601-default-nameformat branch October 5, 2020 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant