Treat requested subject id as requested attribute #888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| if "urn:oasis:names:tc:SAML:profiles:subject-id:req" in entity_attributes: | ||
| subject_id_req = entity_attributes["urn:oasis:names:tc:SAML:profiles:subject-id:req"][0] | ||
| if subject_id_req == "any" or subject_id_req == "pairwise-id": |
There was a problem hiding this comment.
This means that "any" results to a pairwise identifier. I don't mind this, but it is also good to mention that this choice was made here. This should be mentioned in the changelog.
|
Updated by a9fe345 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If an SP requests a subject id using SAML V2.0 Subject Identifier Attributes Profile Version we should not require the SP to also add the request to requested attributes.
The feature or problem addressed by this PR
When using entity categories that specifies attributes that should only be released when required an SP needs to request subject id in both entity attributes and in requested attributes. With this PR the SP only needs to request the subject id in entity attributes as defined by the committee specification.
What your changes do and why you chose this solution
I found that this way play nice with entity category filtering.
Checklist