Fix bug #3547 #3548
Closed
Fix bug #3547 #3548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your suspicions about the comment are correct. Basically clippings should be able to be specified in two ways: either by an existing IFC entity, or by a regular Python dictionary with parameters about operand type and matrix. Currently, we only support the latter. In your fix, you've made it only support the former. Can you make it support both via an isinstance(foo, dict) or isinstance(foo, ifcopenshell.entity_instance) check? |
…_instance clippings
|
All right, i've done it and thanks for the explanation :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to resolve the bug #3547 and actually this works but i'm not sure if this solution covers all cases...
Also, the comment here looks suspicious ...