Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make basic keyboard input work #26

Closed
tonikitoo opened this issue Apr 4, 2017 · 1 comment
Closed

make basic keyboard input work #26

tonikitoo opened this issue Apr 4, 2017 · 1 comment
Assignees
@tonikitoo

Comments

@tonikitoo
Copy link
Member

Even after maksim's fix to the focus issue (pull #20), keyboard events are still not possible. Lets fix it..
@tonikitoo tonikitoo self-assigned this Apr 4, 2017
tonikitoo pushed a commit to tonikitoo/chromium that referenced this issue Apr 5, 2017
Revert of Copy based on coded size in VideoTrackRecorder::VEAEncoder …
87a9033 
…(patchset Igalia#2 id:40001 of https://codereview.chromium.org/2790443004/ )

Reason for revert:
Fails on msan.

https://build.chromium.org/p/chromium.memory.full/builders/Linux%20MSan%20Tests/builds/6793

==25314==WARNING: MemorySanitizer: use-of-uninitialized-value
    #0 0x173e79ea in vp8_intra4x4_predict third_party/libvpx/source/libvpx/vp8/common/reconintra4x4.c:64:3
    Igalia#1 0x17411f49 in vp8_encode_intra4x4block third_party/libvpx/source/libvpx/vp8/encoder/encodeintra.c:55:3
    Igalia#2 0x17080455 in pick_intra4x4block third_party/libvpx/source/libvpx/vp8/encoder/pickinter.c:283:3
    Igalia#3 0x17080455 in pick_intra4x4mby_modes third_party/libvpx/source/libvpx/vp8/encoder/pickinter.c:313:0
    Igalia#4 0x17083a01 in vp8_pick_intra_mode third_party/libvpx/source/libvpx/vp8/encoder/pickinter.c:1425:14
    Igalia#5 0x1740e0b4 in vp8cx_encode_intra_macroblock third_party/libvpx/source/libvpx/vp8/encoder/encodeframe.c:1089:5
    Igalia#6 0x1740b8f7 in encode_mb_row third_party/libvpx/source/libvpx/vp8/encoder/encodeframe.c:458:21
    Igalia#7 0x17406d89 in vp8_encode_frame third_party/libvpx/source/libvpx/vp8/encoder/encodeframe.c:777:9
    Igalia#8 0x17063469 in encode_frame_to_data_rate third_party/libvpx/source/libvpx/vp8/encoder/onyx_if.c:3987:5
    Igalia#9 0x17063469 in vp8_get_compressed_data third_party/libvpx/source/libvpx/vp8/encoder/onyx_if.c:5098:0
    Igalia#10 0x170280a7 in vp8e_encode third_party/libvpx/source/libvpx/vp8/vp8_cx_iface.c:879:25
    Igalia#11 0x1704d1cc in vpx_codec_encode third_party/libvpx/source/libvpx/vpx/src/vpx_encoder.c:209:13
    Igalia#12 0x16c10f29 in content::(anonymous namespace)::VpxEncoder::DoEncode(vpx_codec_ctx*, gfx::Size const&, unsigned char*, unsigned char*, int, unsigned char*, int, unsigned char*, int, base::TimeDelta const&, bool, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >*, bool*) content/renderer/media_recorder/video_track_recorder.cc:932:7
    Igalia#13 0x16c0da73 in content::(anonymous namespace)::VpxEncoder::EncodeOnEncodingTaskRunner(scoped_refptr<media::VideoFrame>, base::TimeTicks) content/renderer/media_recorder/video_track_recorder.cc:871:3
    Igalia#14 0x16c12113 in Invoke<const scoped_refptr<content::VideoTrackRecorder::Encoder> &, const scoped_refptr<media::VideoFrame> &, const base::TimeTicks &> base/bind_internal.h:214:12
    Igalia#15 0x16c12113 in MakeItSo<void (content::VideoTrackRecorder::Encoder::*const &)(scoped_refptr<media::VideoFrame>, base::TimeTicks), const scoped_refptr<content::VideoTrackRecorder::Encoder> &, const scoped_refptr<media::VideoFrame> &, const base::TimeTicks &> base/bind_internal.h:285:0
    Igalia#16 0x16c12113 in RunImpl<void (content::VideoTrackRecorder::Encoder::*const &)(scoped_refptr<media::VideoFrame>, base::TimeTicks), const std::__1::tuple<scoped_refptr<content::VideoTrackRecorder::Encoder>, scoped_refptr<media::VideoFrame>, base::TimeTicks> &, 0, 1, 2> base/bind_internal.h:361:0
    Igalia#17 0x16c12113 in base::internal::Invoker<base::internal::BindState<void (content::VideoTrackRecorder::Encoder::*)(scoped_refptr<media::VideoFrame>, base::TimeTicks), scoped_refptr<content::VideoTrackRecorder::Encoder>, scoped_refptr<media::VideoFrame>, base::TimeTicks>, void ()>::Run(base::internal::BindStateBase*) base/bind_internal.h:339:0
    Igalia#18 0xe0651e5 in Run base/callback.h:91:12
    Igalia#19 0xe0651e5 in base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) base/debug/task_annotator.cc:59:0
    Igalia#20 0xde5cbc3 in base::MessageLoop::RunTask(base::PendingTask*) base/message_loop/message_loop.cc:423:19
    Igalia#21 0xde5e5b1 in base::MessageLoop::DeferOrRunPendingTask(base::PendingTask) base/message_loop/message_loop.cc:434:5
    Igalia#22 0xde6015e in base::MessageLoop::DoWork() base/message_loop/message_loop.cc:527:13
    Igalia#23 0xde6d8d0 in base::MessagePumpDefault::Run(base::MessagePump::Delegate*) base/message_loop/message_pump_default.cc:33:31
    Igalia#24 0xde5bc46 in base::MessageLoop::RunHandler() base/message_loop/message_loop.cc:387:10
    Igalia#25 0xdede3fc in base::RunLoop::Run() base/run_loop.cc:37:10
    Igalia#26 0xdf87aef in base::Thread::ThreadMain() base/threading/thread.cc:333:3
    Igalia#27 0xdf70fb5 in base::(anonymous namespace)::ThreadFunc(void*) base/threading/platform_thread_posix.cc:71:13
    Igalia#28 0x7f49dc121183 in start_thread /build/eglibc-oGUzwX/eglibc-2.19/nptl/pthread_create.c:312:0
    Igalia#29 0x7f49dbc3837c in clone /build/eglibc-oGUzwX/eglibc-2.19/misc/../sysdeps/unix/sysv/linux/x86_64/clone.S:111:0

  Uninitialized value was stored to memory at
    #0 0x1707f3e6 in pick_intra4x4block third_party/libvpx/source/libvpx/vp8/encoder/pickinter.c:282:18
    Igalia#1 0x1707f3e6 in pick_intra4x4mby_modes third_party/libvpx/source/libvpx/vp8/encoder/pickinter.c:313:0
    Igalia#2 0x17083a01 in vp8_pick_intra_mode third_party/libvpx/source/libvpx/vp8/encoder/pickinter.c:1425:14
    Igalia#3 0x1740e0b4 in vp8cx_encode_intra_macroblock third_party/libvpx/source/libvpx/vp8/encoder/encodeframe.c:1089:5
    Igalia#4 0x1740b8f7 in encode_mb_row third_party/libvpx/source/libvpx/vp8/encoder/encodeframe.c:458:21
    Igalia#5 0x17406d89 in vp8_encode_frame third_party/libvpx/source/libvpx/vp8/encoder/encodeframe.c:777:9
    Igalia#6 0x17063469 in encode_frame_to_data_rate third_party/libvpx/source/libvpx/vp8/encoder/onyx_if.c:3987:5
    Igalia#7 0x17063469 in vp8_get_compressed_data third_party/libvpx/source/libvpx/vp8/encoder/onyx_if.c:5098:0
    Igalia#8 0x170280a7 in vp8e_encode third_party/libvpx/source/libvpx/vp8/vp8_cx_iface.c:879:25
    Igalia#9 0x1704d1cc in vpx_codec_encode third_party/libvpx/source/libvpx/vpx/src/vpx_encoder.c:209:13
    Igalia#10 0x16c10f29 in content::(anonymous namespace)::VpxEncoder::DoEncode(vpx_codec_ctx*, gfx::Size const&, unsigned char*, unsigned char*, int, unsigned char*, int, unsigned char*, int, base::TimeDelta const&, bool, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >*, bool*) content/renderer/media_recorder/video_track_recorder.cc:932:7
    Igalia#11 0x16c0da73 in content::(anonymous namespace)::VpxEncoder::EncodeOnEncodingTaskRunner(scoped_refptr<media::VideoFrame>, base::TimeTicks) content/renderer/media_recorder/video_track_recorder.cc:871:3
    Igalia#12 0x16c12113 in Invoke<const scoped_refptr<content::VideoTrackRecorder::Encoder> &, const scoped_refptr<media::VideoFrame> &, const base::TimeTicks &> base/bind_internal.h:214:12
    Igalia#13 0x16c12113 in MakeItSo<void (content::VideoTrackRecorder::Encoder::*const &)(scoped_refptr<media::VideoFrame>, base::TimeTicks), const scoped_refptr<content::VideoTrackRecorder::Encoder> &, const scoped_refptr<media::VideoFrame> &, const base::TimeTicks &> base/bind_internal.h:285:0
    Igalia#14 0x16c12113 in RunImpl<void (content::VideoTrackRecorder::Encoder::*const &)(scoped_refptr<media::VideoFrame>, base::TimeTicks), const std::__1::tuple<scoped_refptr<content::VideoTrackRecorder::Encoder>, scoped_refptr<media::VideoFrame>, base::TimeTicks> &, 0, 1, 2> base/bind_internal.h:361:0
    Igalia#15 0x16c12113 in base::internal::Invoker<base::internal::BindState<void (content::VideoTrackRecorder::Encoder::*)(scoped_refptr<media::VideoFrame>, base::TimeTicks), scoped_refptr<content::VideoTrackRecorder::Encoder>, scoped_refptr<media::VideoFrame>, base::TimeTicks>, void ()>::Run(base::internal::BindStateBase*) base/bind_internal.h:339:0
    Igalia#16 0xe0651e5 in Run base/callback.h:91:12
    Igalia#17 0xe0651e5 in base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) base/debug/task_annotator.cc:59:0
    Igalia#18 0xde5cbc3 in base::MessageLoop::RunTask(base::PendingTask*) base/message_loop/message_loop.cc:423:19
    Igalia#19 0xde5e5b1 in base::MessageLoop::DeferOrRunPendingTask(base::PendingTask) base/message_loop/message_loop.cc:434:5
    Igalia#20 0xde6015e in base::MessageLoop::DoWork() base/message_loop/message_loop.cc:527:13
    Igalia#21 0xde6d8d0 in base::MessagePumpDefault::Run(base::MessagePump::Delegate*) base/message_loop/message_pump_default.cc:33:31
    Igalia#22 0xde5bc46 in base::MessageLoop::RunHandler() base/message_loop/message_loop.cc:387:10
    Igalia#23 0xdede3fc in base::RunLoop::Run() base/run_loop.cc:37:10
    Igalia#24 0xdf87aef in base::Thread::ThreadMain() base/threading/thread.cc:333:3
    Igalia#25 0xdf70fb5 in base::(anonymous namespace)::ThreadFunc(void*) base/threading/platform_thread_posix.cc:71:13

  Uninitialized value was stored to memory at
    #0 0x6c3fcb in __msan_memcpy ??:0:0
    Igalia#1 0x173dba76 in vp8_copy_mem16x16_c third_party/libvpx/source/libvpx/vp8/common/reconinter.c:28:5
    Igalia#2 0x1740b0f7 in encode_mb_row third_party/libvpx/source/libvpx/vp8/encoder/encodeframe.c:418:5
    Igalia#3 0x17406d89 in vp8_encode_frame third_party/libvpx/source/libvpx/vp8/encoder/encodeframe.c:777:9
    Igalia#4 0x17063469 in encode_frame_to_data_rate third_party/libvpx/source/libvpx/vp8/encoder/onyx_if.c:3987:5
    Igalia#5 0x17063469 in vp8_get_compressed_data third_party/libvpx/source/libvpx/vp8/encoder/onyx_if.c:5098:0
    Igalia#6 0x170280a7 in vp8e_encode third_party/libvpx/source/libvpx/vp8/vp8_cx_iface.c:879:25
    Igalia#7 0x1704d1cc in vpx_codec_encode third_party/libvpx/source/libvpx/vpx/src/vpx_encoder.c:209:13
    Igalia#8 0x16c10f29 in content::(anonymous namespace)::VpxEncoder::DoEncode(vpx_codec_ctx*, gfx::Size const&, unsigned char*, unsigned char*, int, unsigned char*, int, unsigned char*, int, base::TimeDelta const&, bool, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >*, bool*) content/renderer/media_recorder/video_track_recorder.cc:932:7
    Igalia#9 0x16c0da73 in content::(anonymous namespace)::VpxEncoder::EncodeOnEncodingTaskRunner(scoped_refptr<media::VideoFrame>, base::TimeTicks) content/renderer/media_recorder/video_track_recorder.cc:871:3
    Igalia#10 0x16c12113 in Invoke<const scoped_refptr<content::VideoTrackRecorder::Encoder> &, const scoped_refptr<media::VideoFrame> &, const base::TimeTicks &> base/bind_internal.h:214:12
    Igalia#11 0x16c12113 in MakeItSo<void (content::VideoTrackRecorder::Encoder::*const &)(scoped_refptr<media::VideoFrame>, base::TimeTicks), const scoped_refptr<content::VideoTrackRecorder::Encoder> &, const scoped_refptr<media::VideoFrame> &, const base::TimeTicks &> base/bind_internal.h:285:0
    Igalia#12 0x16c12113 in RunImpl<void (content::VideoTrackRecorder::Encoder::*const &)(scoped_refptr<media::VideoFrame>, base::TimeTicks), const std::__1::tuple<scoped_refptr<content::VideoTrackRecorder::Encoder>, scoped_refptr<media::VideoFrame>, base::TimeTicks> &, 0, 1, 2> base/bind_internal.h:361:0
    Igalia#13 0x16c12113 in base::internal::Invoker<base::internal::BindState<void (content::VideoTrackRecorder::Encoder::*)(scoped_refptr<media::VideoFrame>, base::TimeTicks), scoped_refptr<content::VideoTrackRecorder::Encoder>, scoped_refptr<media::VideoFrame>, base::TimeTicks>, void ()>::Run(base::internal::BindStateBase*) base/bind_internal.h:339:0
    Igalia#14 0xe0651e5 in Run base/callback.h:91:12
    Igalia#15 0xe0651e5 in base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) base/debug/task_annotator.cc:59:0
    Igalia#16 0xde5cbc3 in base::MessageLoop::RunTask(base::PendingTask*) base/message_loop/message_loop.cc:423:19
    Igalia#17 0xde5e5b1 in base::MessageLoop::DeferOrRunPendingTask(base::PendingTask) base/message_loop/message_loop.cc:434:5
    Igalia#18 0xde6015e in base::MessageLoop::DoWork() base/message_loop/message_loop.cc:527:13
    Igalia#19 0xde6d8d0 in base::MessagePumpDefault::Run(base::MessagePump::Delegate*) base/message_loop/message_pump_default.cc:33:31
    Igalia#20 0xde5bc46 in base::MessageLoop::RunHandler() base/message_loop/message_loop.cc:387:10
    Igalia#21 0xdede3fc in base::RunLoop::Run() base/run_loop.cc:37:10
    Igalia#22 0xdf87aef in base::Thread::ThreadMain() base/threading/thread.cc:333:3
    Igalia#23 0xdf70fb5 in base::(anonymous namespace)::ThreadFunc(void*) base/threading/platform_thread_posix.cc:71:13
    Igalia#24 0x7f49dc121183 in start_thread /build/eglibc-oGUzwX/eglibc-2.19/nptl/pthread_create.c:312:0

  Uninitialized value was stored to memory at
    #0 0x6c3fcb in __msan_memcpy ??:0:0
    Igalia#1 0x176380f4 in copy_and_extend_plane third_party/libvpx/source/libvpx/vp8/common/extend.c:38:5
    Igalia#2 0x176380f4 in vp8_copy_and_extend_frame third_party/libvpx/source/libvpx/vp8/common/extend.c:73:0
    Igalia#3 0x174262e5 in vp8_lookahead_push third_party/libvpx/source/libvpx/vp8/encoder/lookahead.c:139:5
    Igalia#4 0x1705ceba in vp8_receive_raw_frame third_party/libvpx/source/libvpx/vp8/encoder/onyx_if.c:4817:7
    Igalia#5 0x1702745a in vp8e_encode third_party/libvpx/source/libvpx/vp8/vp8_cx_iface.c:863:11
    Igalia#6 0x1704d1cc in vpx_codec_encode third_party/libvpx/source/libvpx/vpx/src/vpx_encoder.c:209:13
    Igalia#7 0x16c10f29 in content::(anonymous namespace)::VpxEncoder::DoEncode(vpx_codec_ctx*, gfx::Size const&, unsigned char*, unsigned char*, int, unsigned char*, int, unsigned char*, int, base::TimeDelta const&, bool, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >*, bool*) content/renderer/media_recorder/video_track_recorder.cc:932:7
    Igalia#8 0x16c0da73 in content::(anonymous namespace)::VpxEncoder::EncodeOnEncodingTaskRunner(scoped_refptr<media::VideoFrame>, base::TimeTicks) content/renderer/media_recorder/video_track_recorder.cc:871:3
    Igalia#9 0x16c12113 in Invoke<const scoped_refptr<content::VideoTrackRecorder::Encoder> &, const scoped_refptr<media::VideoFrame> &, const base::TimeTicks &> base/bind_internal.h:214:12
    Igalia#10 0x16c12113 in MakeItSo<void (content::VideoTrackRecorder::Encoder::*const &)(scoped_refptr<media::VideoFrame>, base::TimeTicks), const scoped_refptr<content::VideoTrackRecorder::Encoder> &, const scoped_refptr<media::VideoFrame> &, const base::TimeTicks &> base/bind_internal.h:285:0
    Igalia#11 0x16c12113 in RunImpl<void (content::VideoTrackRecorder::Encoder::*const &)(scoped_refptr<media::VideoFrame>, base::TimeTicks), const std::__1::tuple<scoped_refptr<content::VideoTrackRecorder::Encoder>, scoped_refptr<media::VideoFrame>, base::TimeTicks> &, 0, 1, 2> base/bind_internal.h:361:0
    Igalia#12 0x16c12113 in base::internal::Invoker<base::internal::BindState<void (content::VideoTrackRecorder::Encoder::*)(scoped_refptr<media::VideoFrame>, base::TimeTicks), scoped_refptr<content::VideoTrackRecorder::Encoder>, scoped_refptr<media::VideoFrame>, base::TimeTicks>, void ()>::Run(base::internal::BindStateBase*) base/bind_internal.h:339:0
    Igalia#13 0xe0651e5 in Run base/callback.h:91:12
    Igalia#14 0xe0651e5 in base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) base/debug/task_annotator.cc:59:0
    Igalia#15 0xde5cbc3 in base::MessageLoop::RunTask(base::PendingTask*) base/message_loop/message_loop.cc:423:19
    Igalia#16 0xde5e5b1 in base::MessageLoop::DeferOrRunPendingTask(base::PendingTask) base/message_loop/message_loop.cc:434:5
    Igalia#17 0xde6015e in base::MessageLoop::DoWork() base/message_loop/message_loop.cc:527:13
    Igalia#18 0xde6d8d0 in base::MessagePumpDefault::Run(base::MessagePump::Delegate*) base/message_loop/message_pump_default.cc:33:31
    Igalia#19 0xde5bc46 in base::MessageLoop::RunHandler() base/message_loop/message_loop.cc:387:10
    Igalia#20 0xdede3fc in base::RunLoop::Run() base/run_loop.cc:37:10
    Igalia#21 0xdf87aef in base::Thread::ThreadMain() base/threading/thread.cc:333:3
    Igalia#22 0xdf70fb5 in base::(anonymous namespace)::ThreadFunc(void*) base/threading/platform_thread_posix.cc:71:13
    Igalia#23 0x7f49dc121183 in start_thread /build/eglibc-oGUzwX/eglibc-2.19/nptl/pthread_create.c:312:0

  Uninitialized value was created by a heap allocation
    #0 0x6c4363 in __interceptor_posix_memalign ??:0:0
    Igalia#1 0xde417c9 in base::AlignedAlloc(unsigned long, unsigned long) base/memory/aligned_memory.cc:31:7
    Igalia#2 0xfb569fd in media::VideoFrame::AllocateYUV(bool) media/base/video_frame.cc:1205:7
    Igalia#3 0xfb4a6ef in media::VideoFrame::CreateFrameInternal(media::VideoPixelFormat, gfx::Size const&, gfx::Rect const&, gfx::Size const&, base::TimeDelta, bool) media/base/video_frame.cc:1064:10
    Igalia#4 0xfb49db0 in media::VideoFrame::CreateFrame(media::VideoPixelFormat, gfx::Size const&, gfx::Rect const&, gfx::Size const&, base::TimeDelta) media/base/video_frame.cc:180:10
    Igalia#5 0x5865ddd in content::VideoTrackRecorderTest_EncodeFrameWithPaddedCodedSize_Test::TestBody() content/renderer/media_recorder/video_track_recorder_unittest.cc:235:49
    Igalia#6 0xd7f73cc in HandleExceptionsInMethodIfSupported<testing::Test, void> testing/gtest/src/gtest.cc:2458:12
    Igalia#7 0xd7f73cc in testing::Test::Run() testing/gtest/src/gtest.cc:2474:0
    Igalia#8 0xd7f9cbb in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2656:11
    Igalia#9 0xd7fb259 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2774:28
    Igalia#10 0xd81aefd in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4647:43
    Igalia#11 0xd819d8e in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2458:12
    Igalia#12 0xd819d8e in testing::UnitTest::Run() testing/gtest/src/gtest.cc:4255:0
    Igalia#13 0xb826860 in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2237:46
    Igalia#14 0xb826860 in base::TestSuite::Run() base/test/test_suite.cc:271:0
    Igalia#15 0xb848b7c in Run base/callback.h:80:12
    Igalia#16 0xb848b7c in base::(anonymous namespace)::LaunchUnitTestsInternal(base::Callback<int (), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&, int, int, bool, base::Callback<void (), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&) base/test/launcher/unit_test_launcher.cc:211:0
    Igalia#17 0xb8483a6 in base::LaunchUnitTests(int, char**, base::Callback<int (), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&) base/test/launcher/unit_test_launcher.cc:453:10
    Igalia#18 0x4f826f6 in main content/test/run_all_unittests.cc:20:10
    Igalia#19 0x7f49dbb5ff44 in __libc_start_main /build/eglibc-oGUzwX/eglibc-2.19/csu/libc-start.c:287:0

Original issue's description:
> Copy based on coded size in VideoTrackRecorder::VEAEncoder
>
> This Cl addresses the below bug making sure that input frame's
> coded size is compared to VEA's requested and frame is copied
> when necessary.
>
> BUG=705273
> TEST=The given bug is fixed and added unittests.
>
> Review-Url: https://codereview.chromium.org/2790443004
> Cr-Commit-Position: refs/heads/master@{#460897}
> Committed: https://chromium.googlesource.com/chromium/src/+/68c20537e9ecd5715ffe280091c37fc6aa0a70f6

TBR=mcasas@chromium.org,emircan@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=705273

Review-Url: https://codereview.chromium.org/2785393002
Cr-Commit-Position: refs/heads/master@{#460975}
@tonikitoo tonikitoo mentioned this issue Apr 10, 2017
Closed
tonikitoo pushed a commit that referenced this issue Apr 10, 2017
@tim-loh
Revert of Make GeometryMapper fully static (patchset #1 id:1 of https…
e2f3b5f 
…://codereview.chromium.org/2793993003/ )

Reason for revert:
Broke blink_platform_unittests on WebKit Linux Trusty (dbg)

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty%20%28dbg%29

failed 20
Run on OS: 'Ubuntu-14.04'
failures:
GeometryMapperTest.FilterWithClipsAndTransforms
GeometryMapperTest.RoundedClip
GeometryMapperTest.TwoClipsWithTransformBetween
GeometryMapperTest.Root
GeometryMapperTest.ClipAfterTransform
GeometryMapperTest.TwoClipsTransformAbove
GeometryMapperTest.ReflectionWithPaintOffset
GeometryMapperTest.SimpleClip
GeometryMapperTest.SiblingTransforms
GeometryMapperTest.RotationAndScaleTransform
GeometryMapperTest.NestedTransformsScaleAndTranslation
GeometryMapperTest.TranslationTransform
GeometryMapperTest.NestedTransformsIntermediateDestination
GeometryMapperTest.SiblingTransformsWithClip
GeometryMapperTest.NestedTransformsFlattening
GeometryMapperTest.RotationAndScaleTransformWithTransformOrigin
GeometryMapperTest.TwoClips
GeometryMapperTest.IdentityTransform
GeometryMapperTest.NestedTransforms
GeometryMapperTest.ClipBeforeTransform

Sample stack trace:

[ RUN      ] GeometryMapperTest.ClipAfterTransform
../../build/linux/debian_jessie_amd64-sysroot/usr/lib/gcc/x86_64-linux-gnu/4.8/../../../../include/c++/4.8/bits/unique_ptr.h:228: std::unique_ptr::pointer std::unique_ptr<blink::GeometryMapper, std::default_delete<blink::GeometryMapper> >::operator->() const [_Tp = blink::GeometryMapper, _Dp = std::default_delete<blink::GeometryMapper>]: Assertion 'get() != pointer()' failed.
Received signal 6
#0 0x7fe3a88626bb base::debug::StackTrace::StackTrace()
#1 0x7fe3a88613bc base::debug::StackTrace::StackTrace()
#2 0x7fe3a88621cf base::debug::(anonymous namespace)::StackDumpSignalHandler()
#3 0x7fe3a9d72330 <unknown>
#4 0x7fe3a42cbc37 gsignal
#5 0x7fe3a42cf028 abort
#6 0x000000566ccf std::__replacement_assert()
#7 0x0000007706d6 std::unique_ptr<>::operator->()
#8 0x00000075a4b0 blink::GeometryMapperTest_ClipAfterTransform_Test::TestBody()
#9 0x000000eee60e testing::internal::HandleSehExceptionsInMethodIfSupported<>()
#10 0x000000ede742 testing::internal::HandleExceptionsInMethodIfSupported<>()
#11 0x000000ed3216 testing::Test::Run()
#12 0x000000ed39cd testing::TestInfo::Run()
#13 0x000000ed3f6f testing::TestCase::Run()
#14 0x000000ed92dc testing::internal::UnitTestImpl::RunAllTests()
#15 0x000000ef259e testing::internal::HandleSehExceptionsInMethodIfSupported<>()
#16 0x000000edffd2 testing::internal::HandleExceptionsInMethodIfSupported<>()
#17 0x000000ed8f7f testing::UnitTest::Run()
#18 0x000000e2c431 RUN_ALL_TESTS()
#19 0x000000e2b2d2 base::TestSuite::Run()
#20 0x000000a36565 (anonymous namespace)::runTestSuite()
#21 0x0000005e3a6a _ZN4base8internal13FunctorTraitsIPFvPiEvE6InvokeIJS2_EEEvS4_DpOT_
#22 0x000000a36858 _ZN4base8internal12InvokeHelperILb0EiE8MakeItSoIRKPFiPNS_9TestSuiteEEJS5_EEEiOT_DpOT0_
#23 0x000000a36817 _ZN4base8internal7InvokerINS0_9BindStateIPFiPNS_9TestSuiteEEJNS0_17UnretainedWrapperIS3_EEEEEFivEE7RunImplIRKS6_RKSt5tupleIJS8_EEJLm0EEEEiOT_OT0_NS_13IndexSequenceIJXspT1_EEEE
#24 0x000000a3675c _ZN4base8internal7InvokerINS0_9BindStateIPFiPNS_9TestSuiteEEJNS0_17UnretainedWrapperIS3_EEEEEFivEE3RunEPNS0_13BindStateBaseE
#25 0x00000082056d _ZNKR4base8CallbackIFvvELNS_8internal8CopyModeE1ELNS2_10RepeatModeE1EE3RunEv
#26 0x000000e50a16 base::(anonymous namespace)::LaunchUnitTestsInternal()
#27 0x000000e50884 base::LaunchUnitTests()
#28 0x000000a364c1 main
#29 0x7fe3a42b6f45 __libc_start_main
#30 0x00000052eb84 <unknown>
  r8: 29287265746e696f  r9: 696c623c6574656c r10: 0000000000000008 r11: 0000000000000206
 r12: 000000000052eb5b r13: 00007ffd79a846a0 r14: 0000000000000000 r15: 0000000000000000
  di: 0000000000006c05  si: 0000000000006c05  bp: 00007ffd79a82540  bx: 0000000000000000
  dx: 0000000000000006  ax: 0000000000000000  cx: ffffffffffffffff  sp: 00007ffd79a823d8
  ip: 00007fe3a42cbc37 efl: 0000000000000206 cgf: 0000000000000033 erf: 0000000000000000
 trp: 0000000000000000 msk: 0000000000000000 cr2: 0000000000000000
[end of stack trace]
Calling _exit(1). Core file will not be generated.

Original issue's description:
> Make GeometryMapper fully static.
>
> Now that the cache for GeometryMapper is not stored on that object,
> we don't really need to allocate GeometryMapper objects at all. This
> change lets us avoid the cost and plumbing complexity of such objects.
>
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
>
> Review-Url: https://codereview.chromium.org/2793993003
> Cr-Commit-Position: refs/heads/master@{#461510}
> Committed: https://chromium.googlesource.com/chromium/src/+/0be71969c80ff018be92afb6bba2076bf3c1f55f

TBR=haraken@chromium.org,pdr@chromium.org,wangxianzhu@chromium.org,keishi@chromium.org,chrishtr@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review-Url: https://codereview.chromium.org/2798513002
Cr-Commit-Position: refs/heads/master@{#461620}
@tonikitoo tonikitoo mentioned this issue Apr 11, 2017
Closed
tonikitoo added a commit to tonikitoo/chromium that referenced this issue Apr 12, 2017
@tonikitoo
Make keyboard minimal functional
b370108 
CL passes a TextInputClientPtr mojo handle to SimpleInputMethod
and uses it to forward handling of basic key events.

Note that we should discuss with @moshayedi what the best way
is to handle non-chromeos mus. Email thread started offline.

TEST=Basic input works, as well as modifiers, and overall keystrokes
(home, end, enter, delete, backspace, etc).

Issue Igalia#26
tonikitoo added a commit to tonikitoo/chromium that referenced this issue Apr 12, 2017
@tonikitoo
Make keyboard minimally functional for non-chrome chrome/mus
b62dc59 
CL passes a TextInputClientPtr mojo handle to SimpleInputMethod
and uses it to forward handling of basic key events.

Note that we should discuss with @moshayedi what the best way
is to handle non-chromeos mus. Email thread started offline.

TEST=Basic input works, as well as modifiers, and overall keystrokes
(home, end, enter, delete, backspace, etc).

Issue Igalia#26
@tonikitoo tonikitoo mentioned this issue Apr 12, 2017
Merged
tonikitoo added a commit to tonikitoo/chromium that referenced this issue Apr 16, 2017
@tonikitoo
Make keyboard minimally functional for non-chrome chrome/mus
6d26097 
CL passes a TextInputClientPtr mojo handle to SimpleInputMethod
and uses it to forward handling of basic key events.

Note that we should discuss with @moshayedi what the best way
is to handle non-chromeos mus. Email thread started offline.

TEST=Basic input works, as well as modifiers, and overall keystrokes
(home, end, enter, delete, backspace, etc).

Issue Igalia#26
@tonikitoo tonikitoo mentioned this issue Apr 21, 2017
Closed
msisov pushed a commit to msisov/chromium that referenced this issue Apr 24, 2017
Revert of Use flat_set in SurfaceAggregator. (patchset Igalia#3 id:40…
96a94ba 
…001 of https://codereview.chromium.org/2823043002/ )

Reason for revert:
Seems to be causing several tests to fail:
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/24975

Failure output:
../../build/linux/debian_jessie_amd64-sysroot/usr/lib/gcc/x86_64-linux-gnu/4.8/../../../../include/c++/4.8/debug/safe_iterator.210:
    error: attempt to construct a constant iterator from a singular mutable
    iterator.

Objects involved in the operation:
iterator "this" @ 0x0x7fff97b205a0 {
  state = dereferenceable;
  references sequence @ 0x0x7fff97b205a0
}
iterator "other" @ 0x0x7fff97b20878 {
  state = singular;
  references sequence @ 0x0x7fff97b20878
}
Received signal 6
#0 0x7f0cbdddb56b base::debug::StackTrace::StackTrace()
Igalia#1 0x7f0cbddda2ac base::debug::StackTrace::StackTrace()
Igalia#2 0x7f0cbdddb07f base::debug::(anonymous namespace)::StackDumpSignalHandler()
Igalia#3 0x7f0cbe22f330 <unknown>
Igalia#4 0x7f0ca248ac37 gsignal
Igalia#5 0x7f0ca248e028 abort
Igalia#6 0x7f0ca2adffe5 __gnu_debug::_Error_formatter::_M_error()
Igalia#7 0x7f0cb26be3ad _ZN11__gnu_debug14_Safe_iteratorIN9__gnu_cxx17__normal_iteratorIPKN2cc9SurfaceIdENSt9__cxx19986vectorIS4_SaIS4_EEEEENSt7__debug6vectorIS4_S9_EEEC2INS2_IPS4_SA_EEEERKNS0_IT_NS1_11__enable_ifIXsr3std10__are_sameISJ_SI_EE7__valueESE_E6__typeEEE
Igalia#8 0x7f0cb26ce1de cc::SurfaceAggregator::HandleSurfaceQuad()
Igalia#9 0x7f0cb26ce94f cc::SurfaceAggregator::CopyQuadsToPass()
Igalia#10 0x7f0cb26cf76e cc::SurfaceAggregator::CopyPasses()
Igalia#11 0x7f0cb26d1df6 cc::SurfaceAggregator::Aggregate()
Igalia#12 0x7f0cb268aacc cc::Display::DrawAndSwap()
Igalia#13 0x7f0cb269c3ab cc::DisplayScheduler::DrawAndSwap()
Igalia#14 0x7f0cb269baf6 cc::DisplayScheduler::AttemptDrawAndSwap()
Igalia#15 0x7f0cb269b3ef cc::DisplayScheduler::OnBeginFrameDeadline()
Igalia#16 0x7f0cb269c92b cc::DisplayScheduler::OnBeginFrameDerivedImpl()
Igalia#17 0x7f0cb2f1b179 cc::BeginFrameObserverBase::OnBeginFrame()
Igalia#18 0x7f0cb2f1cd96 cc::DelayBasedBeginFrameSource::OnTimerTick()
Igalia#19 0x7f0cb2f34d1a cc::DelayBasedTimeSource::OnTimerTick()
Igalia#20 0x7f0cb2d90107 _ZN4base8internal13FunctorTraitsIMN2cc28ScrollbarAnimationControllerEFvvEvE6InvokeIRKNS_7WeakPtrIS3_EEJEEEvS5_OT_DpOT0_
Igalia#21 0x7f0cb2f354da _ZN4base8internal12InvokeHelperILb1EvE8MakeItSoIRKMN2cc20DelayBasedTimeSourceEFvvERKNS_7WeakPtrIS5_EEJEEEvOT_OT0_DpOT1_
Igalia#22 0x7f0cb2f35462 _ZN4base8internal7InvokerINS0_9BindStateIMN2cc20DelayBasedTimeSourceEFvvEJNS_7WeakPtrIS4_EEEEEFvvEE7RunImplIRKS6_RKSt5tupleIJS8_EEJLm0EEEEvOT_OT0_NS_13IndexSequenceIJXspT1_EEEE
Igalia#23 0x7f0cb2f353ac _ZN4base8internal7InvokerINS0_9BindStateIMN2cc20DelayBasedTimeSourceEFvvEJNS_7WeakPtrIS4_EEEEEFvvEE3RunEPNS0_13BindStateBaseE
Igalia#24 0x7f0cb2d9044d _ZNKR4base8CallbackIFvvELNS_8internal8CopyModeE1ELNS2_10RepeatModeE1EE3RunEv
Igalia#25 0x7f0cb2d8fe29 base::CancelableCallback<>::Forward()
Igalia#26 0x7f0cb2d90107 _ZN4base8internal13FunctorTraitsIMN2cc28ScrollbarAnimationControllerEFvvEvE6InvokeIRKNS_7WeakPtrIS3_EEJEEEvS5_OT_DpOT0_
Igalia#27 0x7f0cb2d9005a _ZN4base8internal12InvokeHelperILb1EvE8MakeItSoIRKMNS_18CancelableCallbackIFvvEEEKFvvERKNS_7WeakPtrIS6_EEJEEEvOT_OT0_DpOT1_
Igalia#28 0x7f0cb2d8ffe2 _ZN4base8internal7InvokerINS0_9BindStateIMNS_18CancelableCallbackIFvvEEEKFvvEJNS_7WeakPtrIS5_EEEEES4_E7RunImplIRKS7_RKSt5tupleIJS9_EEJLm0EEEEvOT_OT0_NS_13IndexSequenceIJXspT1_EEEE
Igalia#29 0x7f0cb2d8ff2c _ZN4base8internal7InvokerINS0_9BindStateIMNS_18CancelableCallbackIFvvEEEKFvvEJNS_7WeakPtrIS5_EEEEES4_E3RunEPNS0_13BindStateBaseE
Igalia#30 0x7f0cbdde126e _ZNO4base8CallbackIFvvELNS_8internal8CopyModeE0ELNS2_10RepeatModeE0EE3RunEv
Igalia#31 0x7f0cbdde0a61 base::debug::TaskAnnotator::RunTask()
Igalia#32 0x7f0cbde68f1e base::MessageLoop::RunTask()
Igalia#33 0x7f0cbde69184 base::MessageLoop::DeferOrRunPendingTask()
Igalia#34 0x7f0cbde6970c base::MessageLoop::DoDelayedWork()
Igalia#35 0x7f0cbde7ee68 base::MessagePumpGlib::Run()
Igalia#36 0x7f0cbde68b02 base::MessageLoop::RunHandler()
Igalia#37 0x7f0cbdf02a64 base::RunLoop::Run()
Igalia#38 0x000004f3de76 content::RunThisRunLoop()
Igalia#39 0x0000089f1d0e extensions::ResultCatcher::GetNextResult()
Igalia#40 0x000001657c6c ExtensionApiTest::RunExtensionTestImpl()
Igalia#41 0x000001657685 ExtensionApiTest::RunExtensionTest()
Igalia#42 0x000000d8d146 extensions::ContentScriptApiTest_ContentScriptExtensionIframe_Test::RunTestOnMainThread()
Igalia#43 0x000003db23d5 InProcessBrowserTest::RunTestOnMainThreadLoop()
Igalia#44 0x000004eb9764 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop()
Igalia#45 0x00000093c845 _ZN4base8internal13FunctorTraitsIM25RenderViewContextMenuBaseFvvEvE6InvokeIP21RenderViewContextMenuJEEEvS4_OT_DpOT0_
Igalia#46 0x00000093c761 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIRKM25RenderViewContextMenuBaseFvvEJP21RenderViewContextMenuEEEvOT_DpOT0_
Igalia#47 0x000004eba6a7 _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserTestBaseEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE7RunImplIRKS6_RKSt5tupleIJS8_EEJLm0EEEEvOT_OT0_NS_13IndexSequenceIJXspT1_EEEE
Igalia#48 0x000004eba5ec _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserTestBaseEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE3RunEPNS0_13BindStateBaseE
Igalia#49 0x00000092405d _ZNKR4base8CallbackIFvvELNS_8internal8CopyModeE1ELNS2_10RepeatModeE1EE3RunEv
Igalia#50 0x000003e5880e ChromeBrowserMainParts::PreMainMessageLoopRunImpl()
Igalia#51 0x000003e57450 ChromeBrowserMainParts::PreMainMessageLoopRun()
Igalia#52 0x000001e20bab chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun()
Igalia#53 0x7f0cb55d2931 content::BrowserMainLoop::PreMainMessageLoopRun()
Igalia#54 0x7f0cb48e4af5 _ZN4base8internal13FunctorTraitsIMN7content13URLLoaderImplEFvvEvE6InvokeIPS3_JEEEvS5_OT_DpOT0_
Igalia#55 0x7f0cb55dbae1 _ZN4base8internal12InvokeHelperILb0EiE8MakeItSoIRKMN7content15BrowserMainLoopEFivEJPS5_EEEiOT_DpOT0_
Igalia#56 0x7f0cb55dba87 _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserMainLoopEFivEJNS0_17UnretainedWrapperIS4_EEEEEFivEE7RunImplIRKS6_RKSt5tupleIJS8_EEJLm0EEEEiOT_OT0_NS_13IndexSequenceIJXspT1_EEEE
Igalia#57 0x7f0cb55db9cc _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserMainLoopEFivEJNS0_17UnretainedWrapperIS4_EEEEEFivEE3RunEPNS0_13BindStateBaseE
Igalia#58 0x7f0cb48cb4bd _ZNKR4base8CallbackIFvvELNS_8internal8CopyModeE1ELNS2_10RepeatModeE1EE3RunEv
Igalia#59 0x7f0cb60e53cb content::StartupTaskRunner::RunAllTasksNow()
Igalia#60 0x7f0cb55d0530 content::BrowserMainLoop::CreateStartupTasks()
Igalia#61 0x7f0cb55ded17 content::BrowserMainRunnerImpl::Initialize()
  r8: 00007f0ca28149d0  r9: 00007fff97b1ff98 r10: 0000000000000008 r11: 0000000000000202
 r12: 0000000000000002 r13: 00007fff97b28ea0 r14: 0000000000000000 r15: 0000000000000000
  di: 000000000000266d  si: 000000000000266d  bp: 00007fff97b20278  bx: 00007fff97b201f8
  dx: 0000000000000006  ax: 0000000000000000  cx: ffffffffffffffff  sp: 00007fff97b1ffe8
  ip: 00007f0ca248ac37 efl: 0000000000000202 cgf: 0000000000000033 erf: 0000000000000000
 trp: 0000000000000000 msk: 0000000000000000 cr2: 0000000000000000
[end of stack trace]

Original issue's description:
> Use flat_set in SurfaceAggregator.
>
> The sets and maks are typically small or empty and created once. flat_set and
> flat_map will have better performance for these workloads.
>
> See the bug for histograms of sizes.
>
> BUG=712295
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
>
> Review-Url: https://codereview.chromium.org/2823043002
> Cr-Commit-Position: refs/heads/master@{#465040}
> Committed: https://chromium.googlesource.com/chromium/src/+/95286bcd87997785c90c4194d65a430d082bc784

TBR=jbauman@chromium.org,brettw@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=712295

Review-Url: https://codereview.chromium.org/2824953002
Cr-Commit-Position: refs/heads/master@{#465068}
msisov pushed a commit to msisov/chromium that referenced this issue Apr 24, 2017
@tonikitoo @msisov
Make keyboard minimally functional for non-chrome chrome/mus
34c6c12 
CL passes a TextInputClientPtr mojo handle to SimpleInputMethod
and uses it to forward handling of basic key events.

Note that we should discuss with @moshayedi what the best way
is to handle non-chromeos mus. Email thread started offline.

TEST=Basic input works, as well as modifiers, and overall keystrokes
(home, end, enter, delete, backspace, etc).

Issue Igalia#26
@tonikitoo tonikitoo mentioned this issue Apr 3, 2017
Closed
@tonikitoo tonikitoo changed the title make keyboard work make basic keyboard input work May 12, 2017
@tonikitoo
Copy link
Member Author

This works. Lets file follow up issues for other specific tasks.

tonikitoo added a commit to tonikitoo/chromium that referenced this issue May 15, 2017
@tonikitoo
Make keyboard minimally functional for non-chrome chrome/mus
b65e5c1 
CL passes a TextInputClientPtr mojo handle to SimpleInputMethod
and uses it to forward handling of basic key events.

Note that we should discuss with @moshayedi what the best way
is to handle non-chromeos mus. Email thread started offline.

TEST=Basic input works, as well as modifiers, and overall keystrokes
(home, end, enter, delete, backspace, etc).

Issue Igalia#26
tonikitoo added a commit to tonikitoo/chromium that referenced this issue May 15, 2017
@tonikitoo
Make keyboard minimally functional for non-chrome chrome/mus
00ef9f7 
CL passes a TextInputClientPtr mojo handle to SimpleInputMethod
and uses it to forward handling of basic key events.

Note that we should discuss with @moshayedi what the best way
is to handle non-chromeos mus. Email thread started offline.

TEST=Basic input works, as well as modifiers, and overall keystrokes
(home, end, enter, delete, backspace, etc).

Issue Igalia#26
tonikitoo added a commit to tonikitoo/chromium that referenced this issue May 22, 2017
@tonikitoo
Make keyboard minimally functional for non-chrome chrome/mus
ac586ed 
CL passes a TextInputClientPtr mojo handle to SimpleInputMethod
and uses it to forward handling of basic key events.

Note that we should discuss with @moshayedi what the best way
is to handle non-chromeos mus. Email thread started offline.

TEST=Basic input works, as well as modifiers, and overall keystrokes
(home, end, enter, delete, backspace, etc).

Issue Igalia#26
tonikitoo added a commit that referenced this issue May 22, 2017
@tonikitoo
Make keyboard minimally functional for non-chrome chrome/mus
e73715f 
CL passes a TextInputClientPtr mojo handle to SimpleInputMethod
and uses it to forward handling of basic key events.

Note that we should discuss with @moshayedi what the best way
is to handle non-chromeos mus. Email thread started offline.

TEST=Basic input works, as well as modifiers, and overall keystrokes
(home, end, enter, delete, backspace, etc).

Issue #26
msisov pushed a commit that referenced this issue Jun 5, 2017
@tonikitoo @msisov
Make keyboard minimally functional for non-chrome chrome/mus
8eae7cf 
CL passes a TextInputClientPtr mojo handle to SimpleInputMethod
and uses it to forward handling of basic key events.

Note that we should discuss with @moshayedi what the best way
is to handle non-chromeos mus. Email thread started offline.

TEST=Basic input works, as well as modifiers, and overall keystrokes
(home, end, enter, delete, backspace, etc).

Issue #26
tonikitoo added a commit to tonikitoo/chromium that referenced this issue Jun 5, 2017
@tonikitoo
Make keyboard minimally functional for non-chrome chrome/mus
b471548 
CL passes a TextInputClientPtr mojo handle to SimpleInputMethod
and uses it to forward handling of basic key events.

Note that we should discuss with @moshayedi what the best way
is to handle non-chromeos mus. Email thread started offline.

TEST=Basic input works, as well as modifiers, and overall keystrokes
(home, end, enter, delete, backspace, etc).

Issue Igalia#26
@tonikitoo tonikitoo mentioned this issue Jun 7, 2017
Closed
tonikitoo added a commit that referenced this issue Jun 7, 2017
@tonikitoo
Make keyboard minimally functional for non-chrome chrome/mus
1d96b77 
CL passes a TextInputClientPtr mojo handle to SimpleInputMethod
and uses it to forward handling of basic key events.

Note that we should discuss with @moshayedi what the best way
is to handle non-chromeos mus. Email thread started offline.

TEST=Basic input works, as well as modifiers, and overall keystrokes
(home, end, enter, delete, backspace, etc).

Issue #26
@tonikitoo tonikitoo mentioned this issue Jun 12, 2017
Closed
tonikitoo added a commit that referenced this issue Jun 12, 2017
@tonikitoo
Make keyboard minimally functional for non-chrome chrome/mus
5a1c393 
CL passes a TextInputClientPtr mojo handle to SimpleInputMethod
and uses it to forward handling of basic key events.

Note that we should discuss with @moshayedi what the best way
is to handle non-chromeos mus. Email thread started offline.

TEST=Basic input works, as well as modifiers, and overall keystrokes
(home, end, enter, delete, backspace, etc).

Issue #26
msisov pushed a commit that referenced this issue Jun 19, 2017
@TakayoshiKochi
Revert of [Android] Adding Smart GO/NEXT feature in Chrome (patchset #26
76fc114 
 id:500001 of https://codereview.chromium.org/2839993002/ )

Reason for revert:
This caused several clusterfuzz bugs
(733197, 733218, 733282) - let me revert for
investigation on those.

Original issue's description:
> [Android] Adding Smart GO/NEXT feature in Chrome
>
> Smart Go/Next brings better user experience to the user during form submitting applications.
> For navigating between form elements, user can use NEXT/PREVIOUS button from IME
> without touching on individual fields. This will avoid unnecessary form submissions before
> filling or visiting all fields in the form.
>
> Additionally it will save user time and avoid redundant network requests before actually
> filling/attending entire fields in the form
>
> Design Document: https://docs.google.com/document/d/1h0diigZ8LUi7A3UKJ_zwNUbvNQoe-Nwr55_p6ivSPNg/edit?usp=sharing
>
> BUG=410785,648986
>
> Review-Url: https://codereview.chromium.org/2839993002
> Cr-Commit-Position: refs/heads/master@{#479126}
> Committed: https://chromium.googlesource.com/chromium/src/+/8d80ad1410dcb23f55c323a97e57eed750a611dc

TBR=tkent@chromium.org,changwan@chromium.org,dcheng@chromium.org,ekaramad@chromium.org,nasko@chromium.org,yosin@chromium.org,aelias@chromium.org,ajith.v@samsung.com
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=410785,648986

Review-Url: https://codereview.chromium.org/2938123002
Cr-Commit-Position: refs/heads/master@{#479601}
msisov pushed a commit that referenced this issue Jun 19, 2017
@tonikitoo @msisov
Make keyboard minimally functional for non-chrome chrome/mus
ac12dd4 
CL passes a TextInputClientPtr mojo handle to SimpleInputMethod
and uses it to forward handling of basic key events.

Note that we should discuss with @moshayedi what the best way
is to handle non-chromeos mus. Email thread started offline.

TEST=Basic input works, as well as modifiers, and overall keystrokes
(home, end, enter, delete, backspace, etc).

Issue #26
tonikitoo added a commit that referenced this issue Jun 26, 2017
@tonikitoo
Make keyboard minimally functional for non-chrome chrome/mus
4522564 
CL passes a TextInputClientPtr mojo handle to SimpleInputMethod
and uses it to forward handling of basic key events.

Note that we should discuss with @moshayedi what the best way
is to handle non-chromeos mus. Email thread started offline.

TEST=Basic input works, as well as modifiers, and overall keystrokes
(home, end, enter, delete, backspace, etc).

Issue #26
msisov pushed a commit to msisov/chromium that referenced this issue Jul 3, 2017
@tonikitoo @msisov
Make keyboard minimally functional for non-chrome chrome/mus
9657f17 
CL passes a TextInputClientPtr mojo handle to SimpleInputMethod
and uses it to forward handling of basic key events.

Note that we should discuss with @moshayedi what the best way
is to handle non-chromeos mus. Email thread started offline.

TEST=Basic input works, as well as modifiers, and overall keystrokes
(home, end, enter, delete, backspace, etc).

Issue Igalia#26
tonikitoo added a commit that referenced this issue Mar 12, 2018
@tonikitoo
Make keyboard minimally functional for non-chrome chrome/mus
b8acb10 
CL passes a TextInputClientPtr mojo handle to SimpleInputMethod
and uses it to forward handling of basic key events.

Note that we should discuss with @moshayedi what the best way
is to handle non-chromeos mus. Email thread started offline.

TEST=Basic input works, as well as modifiers, and overall keystrokes
(home, end, enter, delete, backspace, etc).

Issue #26
jkim-julie pushed a commit that referenced this issue Mar 19, 2018
@tonikitoo @jkim-julie
Make keyboard minimally functional for non-chrome chrome/mus
b38d30a 
CL passes a TextInputClientPtr mojo handle to SimpleInputMethod
and uses it to forward handling of basic key events.

Note that we should discuss with @moshayedi what the best way
is to handle non-chromeos mus. Email thread started offline.

TEST=Basic input works, as well as modifiers, and overall keystrokes
(home, end, enter, delete, backspace, etc).

Issue #26
tonikitoo added a commit to tonikitoo/chromium that referenced this issue Mar 27, 2018
@tonikitoo
Make keyboard minimally functional for non-chrome chrome/mus
da28b0c 
CL passes a TextInputClientPtr mojo handle to SimpleInputMethod
and uses it to forward handling of basic key events.

Note that we should discuss with @moshayedi what the best way
is to handle non-chromeos mus. Email thread started offline.

TEST=Basic input works, as well as modifiers, and overall keystrokes
(home, end, enter, delete, backspace, etc).

Issue Igalia#26
msisov pushed a commit that referenced this issue Apr 2, 2018
@tonikitoo @msisov
Make keyboard minimally functional for non-chrome chrome/mus
32596e5 
CL passes a TextInputClientPtr mojo handle to SimpleInputMethod
and uses it to forward handling of basic key events.

Note that we should discuss with @moshayedi what the best way
is to handle non-chromeos mus. Email thread started offline.

TEST=Basic input works, as well as modifiers, and overall keystrokes
(home, end, enter, delete, backspace, etc).

Issue #26
jkim-julie pushed a commit to jkim-julie/chromium that referenced this issue Apr 9, 2018
@cmumford
Revert "Changing CupsPrintersManager to use Enterprise Printing Policy"
11df451 
This reverts commit c7ab577.

Reason for revert: Failing Linux ASan/LSan tests:

Indirect leak of 8 byte(s) in 1 object(s) allocated from:
    #0 0xb77492 in operator new(unsigned long) /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/asan/asan_new_delete.cc:92:3
    Igalia#1 0xa3bea84 in __allocate buildtools/third_party/libc++/trunk/include/new:228:10
    Igalia#2 0xa3bea84 in allocate buildtools/third_party/libc++/trunk/include/memory:1793
    Igalia#3 0xa3bea84 in allocate buildtools/third_party/libc++/trunk/include/memory:1547
    Igalia#4 0xa3bea84 in __split_buffer buildtools/third_party/libc++/trunk/include/__split_buffer:311
    Igalia#5 0xa3bea84 in void std::__1::vector<PrefStore::Observer*, std::__1::allocator<PrefStore::Observer*> >::__push_back_slow_path<PrefStore::Observer* const&>(PrefStore::Observer* const&&&) buildtools/third_party/libc++/trunk/include/vector:1578
    Igalia#6 0xa3b5797 in push_back buildtools/third_party/libc++/trunk/include/vector:1599:9
    Igalia#7 0xa3b5797 in base::ObserverList<PrefStore::Observer, true, true>::AddObserver(PrefStore::Observer*) base/observer_list.h:246
    Igalia#8 0x162f16a5 in PrefValueStore::PrefStoreKeeper::Initialize(PrefValueStore*, PrefStore*, PrefValueStore::PrefStoreType) components/prefs/pref_value_store.cc:36:18
    Igalia#9 0x162f1e2a in InitPrefStore components/prefs/pref_value_store.cc:295:22
    Igalia#10 0x162f1e2a in PrefValueStore::PrefValueStore(PrefStore*, PrefStore*, PrefStore*, PrefStore*, PrefStore*, PrefStore*, PrefStore*, PrefNotifier*, std::__1::unique_ptr<PrefValueStore::Delegate, std::__1::default_delete<PrefValueStore::Delegate> >) components/prefs/pref_value_store.cc:61
    Igalia#11 0x24a286b6 in make_unique<PrefValueStore, TestingPrefStore *&, nullptr_t, TestingPrefStore *&, nullptr_t, TestingPrefStore *&, TestingPrefStore *&, PrefStore *, PrefNotifierImpl *&> buildtools/third_party/libc++/trunk/include/memory:3079:32
    Igalia#12 0x24a286b6 in TestingPrefServiceBase<sync_preferences::PrefServiceSyncable, user_prefs::PrefRegistrySyncable>::TestingPrefServiceBase(TestingPrefStore*, TestingPrefStore*, TestingPrefStore*, TestingPrefStore*, user_prefs::PrefRegistrySyncable*, PrefNotifierImpl*) components/sync_preferences/testing_pref_service_syncable.cc:24
    Igalia#13 0x24a28d10 in sync_preferences::TestingPrefServiceSyncable::TestingPrefServiceSyncable() components/sync_preferences/testing_pref_service_syncable.cc:47:7
    Igalia#14 0x7195215 in chromeos::(anonymous namespace)::CupsPrintersManagerTest::CupsPrintersManagerTest() chrome/browser/chromeos/printing/cups_printers_manager_unittest.cc:256:27
    Igalia#15 0x71ac20e in CupsPrintersManagerTest_GetPrinter_Test chrome/browser/chromeos/printing/cups_printers_manager_unittest.cc:477:1
    Igalia#16 0x71ac20e in testing::internal::TestFactoryImpl<chromeos::(anonymous namespace)::CupsPrintersManagerTest_GetPrinter_Test>::CreateTest() third_party/googletest/src/googletest/include/gtest/internal/gtest-internal.h:466
    Igalia#17 0x7a50817 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest-internal-inl.h
    Igalia#18 0x7a51c56 in testing::TestCase::Run() third_party/googletest/src/googletest/src/gtest.cc:2779:28
    Igalia#19 0x7a77366 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5036:43
    Igalia#20 0x7a765d6 in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc
    Igalia#21 0x116d296b in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2314:46
    Igalia#22 0x116d296b in base::TestSuite::Run() base/test/test_suite.cc:275
    Igalia#23 0x116d8c84 in Run base/callback.h:95:12
    Igalia#24 0x116d8c84 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) base/test/launcher/unit_test_launcher.cc:225
    Igalia#25 0x116d874d in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) base/test/launcher/unit_test_launcher.cc:576:10
    Igalia#26 0x116b4b87 in main chrome/test/base/run_all_unittests.cc:30:10
    Igalia#27 0x7eff3bb53f44 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287

Original change's description:
> Changing CupsPrintersManager to use Enterprise Printing Policy
> 
> Hooked up CupsPrintersManager to receive update callbacks whenever the
> value of the UserPrintersAllowed pref is changed. If the pref is set to
> false then CupsPrintersManager will disallow any changes made to
> non-enterprise printers.
> 
> R=​skau@chromium.org
> 
> CQ-DEPEND=CL:972627
> 
> Bug: 827016
> Change-Id: Id35de08fee33106f0122af07eea572757aae9c5f
> Reviewed-on: https://chromium-review.googlesource.com/982273
> Commit-Queue: David Valleau <valleau@chromium.org>
> Reviewed-by: Drew Wilson <atwilson@chromium.org>
> Reviewed-by: Sean Kau <skau@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#547243}

TBR=atwilson@chromium.org,skau@chromium.org,valleau@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 827016
Change-Id: I641993fa4ca9e35901a6c95a9312ec802220eef4
Reviewed-on: https://chromium-review.googlesource.com/990313
Reviewed-by: Chris Mumford <cmumford@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>
Commit-Queue: Sean Kau <skau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547475}
jkim-julie pushed a commit to jkim-julie/chromium that referenced this issue Apr 9, 2018
@tonikitoo @jkim-julie
Make keyboard minimally functional for non-chrome chrome/mus
17c363a 
CL passes a TextInputClientPtr mojo handle to SimpleInputMethod
and uses it to forward handling of basic key events.

Note that we should discuss with @moshayedi what the best way
is to handle non-chromeos mus. Email thread started offline.

TEST=Basic input works, as well as modifiers, and overall keystrokes
(home, end, enter, delete, backspace, etc).

Issue Igalia#26
msisov pushed a commit to msisov/chromium that referenced this issue Apr 16, 2018
@alancutter
Revert "Add MTP Mojo interfaces for talking to MediaTransferProtocolM…
f7fd252 
…anager."

This reverts commit 9e82c21.

Reason for revert: This change causes target_os="chromeos" to crash on start up:
[82494:82494:0411/194350.042525:FATAL:media_transfer_protocol_manager.cc(704)] Check failed: g_media_transfer_protocol_manager.                                             
#0 0x7f8751f192ac base::debug::StackTrace::StackTrace()
Igalia#1 0x7f8751f402eb logging::LogMessage::~LogMessage()                 
Igalia#2 0x7f87500945b9 device::MediaTransferProtocolManager::GetInstance()      
Igalia#3 0x7f87500936a5 device::MtpDeviceManager::EnumerateStoragesAndSetClient()   
Igalia#4 0x7f874efb5c3a device::mojom::MtpManagerStubDispatch::AcceptWithResponder()
Igalia#5 0x7f87500941b6 device::mojom::MtpManagerStub<>::AcceptWithResponder()  
Igalia#6 0x7f87511c5a77 mojo::InterfaceEndpointClient::HandleValidatedMessage()
Igalia#7 0x7f87511c53e6 mojo::FilterChain::Accept()                            
Igalia#8 0x7f87511c6dd5 mojo::InterfaceEndpointClient::HandleIncomingMessage()    
Igalia#9 0x7f87511cd53c mojo::internal::MultiplexRouter::ProcessIncomingMessage()
Igalia#10 0x7f87511cc940 mojo::internal::MultiplexRouter::Accept()
Igalia#11 0x7f87511c53e6 mojo::FilterChain::Accept()         
Igalia#12 0x7f87511c05c3 mojo::Connector::ReadSingleMessage()                           
Igalia#13 0x7f87511c0ff1 mojo::Connector::ReadAllAvailableMessages()
Igalia#14 0x7f87511c0e99 mojo::Connector::OnHandleReadyInternal()
Igalia#15 0x7f87511c1727 mojo::SimpleWatcher::DiscardReadyState()                                               
Igalia#16 0x7f8751187e86 mojo::SimpleWatcher::OnHandleReady()                                                              
Igalia#17 0x7f8751188391 _ZN4base8internal7InvokerINS0_9BindStateIMN4mojo13SimpleWatcherEFvijRKNS3_18HandleSignalsStateEEJN
S_7WeakPtrIS4_EEijS5_EEEFvvEE7RunImplIRKS9_RKNSt3__15tupleIJSB_ijS5_EEEJLm0ELm1ELm2ELm3EEEEvOT_OT0_NSI_16integer_sequ
enceImJXspT1_EEEE                                                   
Igalia#18 0x7f8751f19c45 base::debug::TaskAnnotator::RunTask()        
Igalia#19 0x7f8751f4c559 base::internal::IncomingTaskQueue::RunTask()                  
Igalia#20 0x7f8751f5009b base::MessageLoop::RunTask()                                 
Igalia#21 0x7f8751f5042a base::MessageLoop::DeferOrRunPendingTask()     
Igalia#22 0x7f8751f5068c base::MessageLoop::DoWork()     
Igalia#23 0x7f8751f52b29 base::MessagePumpLibevent::Run()
Igalia#24 0x7f8751f4f9c9 base::MessageLoop::Run()
Igalia#25 0x7f8751f86709 base::RunLoop::Run()                        
Igalia#26 0x55ecab42c14a ChromeBrowserMainParts::MainMessageLoopRun()       
Igalia#27 0x7f874f125a37 content::BrowserMainLoop::RunMainMessageLoopParts()
Igalia#28 0x7f874f128b36 content::BrowserMainRunnerImpl::Run()
Igalia#29 0x7f874f121cc9 content::BrowserMain()
Igalia#30 0x7f874fb09c8d content::ContentMainRunnerImpl::Run()
Igalia#31 0x7f875245e292 service_manager::Main()
Igalia#32 0x7f874fb08304 content::ContentMain()
Igalia#33 0x55ecaa89c263 ChromeMain
Igalia#34 0x7f87449822b1 __libc_start_main
Igalia#35 0x55ecaa89c0da _start


Original change's description:
> Add MTP Mojo interfaces for talking to MediaTransferProtocolManager.
> 
> This CL:
> 1) Introduces 2 Mojo interfaces: device::mojom::MtpManager and
>    device::mojom::MtpManagerClient. The current implementation just
>    forwards MTP device access requests to the existing
>    MediaTransferProtocolManager..
> 2) Makes Device Service expose the above 2 Mojo interfaces.
> 3) Create stubs to connect these 2 interfaces with the main user,
>    storage_monitor::StorageMonitor.
> 
> More Mojo methods will be added to MtpManager and all users will be
> converted to use Mojo interfaces in subsequent CLs.
> 
> BUG=769630
> 
> Change-Id: Ibfffb2a45d13014ec3984ae9e242f49492e8b16a
> Reviewed-on: https://chromium-review.googlesource.com/972668
> Commit-Queue: Donna Wu <donna.wu@intel.com>
> Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: Tom Sepez <tsepez@chromium.org>
> Reviewed-by: Lei Zhang <thestig@chromium.org>
> Reviewed-by: Colin Blundell <blundell@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#549814}

TBR=sky@chromium.org,thestig@chromium.org,blundell@chromium.org,rdevlin.cronin@chromium.org,tsepez@chromium.org,donna.wu@intel.com,leon.han@intel.com,ke.he@intel.com

Change-Id: I9417d3d4be8952819faf638007b3efb21c8eb618
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 769630
Reviewed-on: https://chromium-review.googlesource.com/1006774
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549842}
msisov pushed a commit to msisov/chromium that referenced this issue Apr 16, 2018
@tonikitoo @msisov
Make keyboard minimally functional for non-chrome chrome/mus
37f8e12 
CL passes a TextInputClientPtr mojo handle to SimpleInputMethod
and uses it to forward handling of basic key events.

Note that we should discuss with @moshayedi what the best way
is to handle non-chromeos mus. Email thread started offline.

TEST=Basic input works, as well as modifiers, and overall keystrokes
(home, end, enter, delete, backspace, etc).

Issue Igalia#26
jkim-julie pushed a commit to jkim-julie/chromium that referenced this issue Apr 23, 2018
@tonikitoo @jkim-julie
Make keyboard minimally functional for non-chrome chrome/mus
e1dedc0 
CL passes a TextInputClientPtr mojo handle to SimpleInputMethod
and uses it to forward handling of basic key events.

Note that we should discuss with @moshayedi what the best way
is to handle non-chromeos mus. Email thread started offline.

TEST=Basic input works, as well as modifiers, and overall keystrokes
(home, end, enter, delete, backspace, etc).

Issue Igalia#26
jkim-julie pushed a commit to jkim-julie/chromium that referenced this issue Apr 23, 2018
@tonikitoo @jkim-julie
Make keyboard minimally functional for non-chrome chrome/mus
bae1692 
CL passes a TextInputClientPtr mojo handle to SimpleInputMethod
and uses it to forward handling of basic key events.

Note that we should discuss with @moshayedi what the best way
is to handle non-chromeos mus. Email thread started offline.

TEST=Basic input works, as well as modifiers, and overall keystrokes
(home, end, enter, delete, backspace, etc).

Issue Igalia#26
jkim-julie pushed a commit that referenced this issue Jun 4, 2018
@thiemonagel
Revert "shared worker: Add tests for Chrome extensions."
4796a2a 
This reverts commit 62628bf.

Reason for revert: Speculative revert due to Linux ChromiumOS MSan Tests failures:

https://ci.chromium.org/buildbot/chromium.memory/Linux%20ChromiumOS%20MSan%20Tests/7363

 [ RUN      ] ExtensionWebRequestApiTest.WebRequestAuthRequired
[14149:14149:0529/223016.256914:WARNING:user_session_manager.cc(1091)] Attempting to save user password for non enterprise user.
ALSA lib confmisc.c:768:(parse_card) cannot find card '0'
ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_card_driver returned error: No such file or directory
ALSA lib confmisc.c:392:(snd_func_concat) error evaluating strings
ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_concat returned error: No such file or directory
ALSA lib confmisc.c:1251:(snd_func_refer) error evaluating name
ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory
ALSA lib conf.c:4727:(snd_config_expand) Evaluate error: No such file or directory
ALSA lib pcm.c:2239:(snd_pcm_open_noupdate) Unknown PCM default
[14149:14299:0529/223016.655436:WARNING:alsa_util.cc(24)] PcmOpen: default,No such file or directory
ALSA lib confmisc.c:768:(parse_card) cannot find card '0'
ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_card_driver returned error: No such file or directory
ALSA lib confmisc.c:392:(snd_func_concat) error evaluating strings
ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_concat returned error: No such file or directory
ALSA lib confmisc.c:1251:(snd_func_refer) error evaluating name
ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory
ALSA lib conf.c:4727:(snd_config_expand) Evaluate error: No such file or directory
ALSA lib pcm.c:2239:(snd_pcm_open_noupdate) Unknown PCM default
[14149:14299:0529/223016.656150:WARNING:alsa_util.cc(24)] PcmOpen: plug:default,No such file or directory
[14149:14149:0529/223023.245267:ERROR:textfield.cc(1754)] Not implemented reached in virtual bool views::Textfield::ShouldDoLearning()
[14149:14372:0529/223023.626405:WARNING:embedded_test_server.cc(229)] Request not handled. Returning 404: /favicon.ico
[14149:14149:0529/223024.849020:INFO:CONSOLE(0)] "[SUCCESS] authRequiredNonBlocking", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0)
[14149:14149:0529/223027.955574:INFO:CONSOLE(0)] "[SUCCESS] authRequiredSyncNoAction", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0)
[14149:14149:0529/223031.378924:INFO:CONSOLE(0)] "[SUCCESS] authRequiredSyncCancelAuth", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0)
[14149:14149:0529/223034.498789:INFO:CONSOLE(0)] "[SUCCESS] authRequiredSyncSetAuth", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0)
[14149:14149:0529/223216.859287:INFO:CONSOLE(0)] "[SUCCESS] authRequiredAsyncNoAction", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0)
BrowserTestBase received signal: Terminated. Backtrace:
    #0 0x000000a8dfe1 in __interceptor_backtrace /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/msan/../sanitizer_common/sanitizer_common_interceptors.inc:3980:13
    #1 0x00001350f30f in base::debug::StackTrace::StackTrace(unsigned long) ./../../base/debug/stack_trace_posix.cc:808:41
    #2 0x000014f9f062 in content::(anonymous namespace)::DumpStackTraceSignalHandler(int) ./../../content/public/test/browser_test_base.cc:87:5
    #3 0x000000ab5989 in SignalHandler(int) /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/msan/msan_interceptors.cc:995:3
    #4 0x7fe3e82dacb0 in killpg ??:?
    #5 0x7fe3e82dacb0 in ?? ??:0
    #6 0x7fe3e83a26d3 in epoll_wait /build/eglibc-ripdx6/eglibc-2.19/misc/../sysdeps/unix/syscall-template.S:81:0
    #7 0x000000a770a4 in __interceptor_epoll_wait /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/msan/msan_interceptors.cc:862:13
    #8 0x00001704b89b in epoll_dispatch ./../../base/third_party/libevent/epoll.c:198:8
    #9 0x00001703ec8b in event_base_loop ./../../base/third_party/libevent/event.c:512:9
    #10 0x00001355a138 in base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) ./../../base/message_loop/message_pump_libevent.cc:247:9
    #11 0x00001336b330 in base::RunLoop::Run() ./../../base/run_loop.cc:102:14
    #12 0x000015058275 in content::RunThisRunLoop(base::RunLoop*) ./../../content/public/test/test_utils.cc:128:13
    #13 0x00002b95647d in extensions::ResultCatcher::GetNextResult() ./../../extensions/test/result_catcher.cc:35:5
    #14 0x000004dfa6f2 in extensions::ExtensionApiTest::RunExtensionTestImpl(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, char const*, int) ./../../chrome/browser/extensions/extension_apitest.cc:392:16
    #15 0x0000049ace7e in extensions::ExtensionWebRequestApiTest_WebRequestAuthRequired_Test::RunTestOnMainThread() ./../../chrome/browser/extensions/api/web_request/web_request_apitest.cc:445:3
    #16 0x000014f9e3f2 in content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() ./../../content/public/test/browser_test_base.cc:385:5
    #17 0x00001387fbe5 in Run ./../../base/callback.h:125:12
    #18 0x00001387fbe5 in ChromeBrowserMainParts::PreMainMessageLoopRunImpl() ./../../chrome/browser/chrome_browser_main.cc:2098:0
    #19 0x00001387b5c0 in ChromeBrowserMainParts::PreMainMessageLoopRun() ./../../chrome/browser/chrome_browser_main.cc:1492:18
    #20 0x000007604b81 in chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() ./../../chrome/browser/chromeos/chrome_browser_main_chromeos.cc:684:32
    #21 0x00000bd8f78b in content::BrowserMainLoop::PreMainMessageLoopRun() ./../../content/browser/browser_main_loop.cc:962:13
    #22 0x00000d34ab21 in Run ./../../base/callback.h:125:12
    #23 0x00000d34ab21 in content::StartupTaskRunner::RunAllTasksNow() ./../../content/browser/startup_task_runner.cc:44:0
    #24 0x00000bd875e8 in content::BrowserMainLoop::CreateStartupTasks() ./../../content/browser/browser_main_loop.cc:873:25
    #25 0x00000bd9b176 in content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&, std::__1::unique_ptr<content::BrowserProcessSubThread, std::__1::default_delete<content::BrowserProcessSubThread> >) ./../../content/browser/browser_main_runner_impl.cc:148:15
    #26 0x00000bd7c28c in content::BrowserMain(content::MainFunctionParams const&, std::__1::unique_ptr<content::BrowserProcessSubThread, std::__1::default_delete<content::BrowserProcessSubThread> >) ./../../content/browser/browser_main.cc:47:20
    #27 0x000012ff6795 in content::RunBrowserProcessMain(content::MainFunctionParams const&, content::ContentMainDelegate*, std::__1::unique_ptr<content::BrowserProcessSubThread, std::__1::default_delete<content::BrowserProcessSubThread> >) ./../../content/app/content_main_runner_impl.cc:620:10
    #28 0x000012ffa9aa in content::ContentMainRunnerImpl::Run() ./../../content/app/content_main_runner_impl.cc:964:12
    #29 0x00001c607013 in service_manager::Main(service_manager::MainParams const&) ./../../services/service_manager/embedder/main.cc:459:29
    #30 0x000012ff0d18 in content::ContentMain(content::ContentMainParams const&) ./../../content/app/content_main.cc:19:10
    #31 0x000014f9c8c0 in content::BrowserTestBase::SetUp() ./../../content/public/test/browser_test_base.cc:323:3
    #32 0x00001372d0cf in InProcessBrowserTest::SetUp() ./../../chrome/test/base/in_process_browser_test.cc:244:20
    #33 0x000008b46826 in testing::Test::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0
    #34 0x000008b4a8bc in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2667:11
    #35 0x000008b4c34a in testing::TestCase::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2785:28
    #36 0x000008b82a55 in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5047:43
    #37 0x000008b81328 in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0
    #38 0x0000137959f1 in RUN_ALL_TESTS ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:2329:46
    #39 0x0000137959f1 in base::TestSuite::Run() ./../../base/test/test_suite.cc:275:0
    #40 0x0000131f45a4 in ChromeTestSuiteRunner::RunTestSuite(int, char**) ./../../chrome/test/base/chrome_test_launcher.cc:65:38
    #41 0x000015048025 in content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) ./../../content/public/test/test_launcher.cc:625:31
    #42 0x0000131f5d07 in LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) ./../../chrome/test/base/chrome_test_launcher.cc:170:10
    #43 0x0000131f4390 in main ./../../chrome/test/base/browser_tests_main_chromeos.cc:21:10
    #44 0x7fe3e82c5f45 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287:0
    #45 0x000000a511ba in _start ??:0:0
[ RUN      ] ExtensionWebRequestApiTest.WebRequestAuthRequired
[9681:9681:0529/225648.292655:WARNING:user_session_manager.cc(1091)] Attempting to save user password for non enterprise user.
ALSA lib confmisc.c:768:(parse_card) cannot find card '0'
ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_card_driver returned error: No such file or directory
ALSA lib confmisc.c:392:(snd_func_concat) error evaluating strings
ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_concat returned error: No such file or directory
ALSA lib confmisc.c:1251:(snd_func_refer) error evaluating name
ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory
ALSA lib conf.c:4727:(snd_config_expand) Evaluate error: No such file or directory
ALSA lib pcm.c:2239:(snd_pcm_open_noupdate) Unknown PCM default
[9681:9709:0529/225648.491081:WARNING:alsa_util.cc(24)] PcmOpen: default,No such file or directory
ALSA lib confmisc.c:768:(parse_card) cannot find card '0'
ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_card_driver returned error: No such file or directory
ALSA lib confmisc.c:392:(snd_func_concat) error evaluating strings
ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_concat returned error: No such file or directory
ALSA lib confmisc.c:1251:(snd_func_refer) error evaluating name
ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory
ALSA lib conf.c:4727:(snd_config_expand) Evaluate error: No such file or directory
ALSA lib pcm.c:2239:(snd_pcm_open_noupdate) Unknown PCM default
[9681:9709:0529/225648.491704:WARNING:alsa_util.cc(24)] PcmOpen: plug:default,No such file or directory
[9681:9681:0529/225653.563139:ERROR:textfield.cc(1754)] Not implemented reached in virtual bool views::Textfield::ShouldDoLearning()
[9681:9764:0529/225653.719267:WARNING:embedded_test_server.cc(229)] Request not handled. Returning 404: /favicon.ico
[9681:9681:0529/225654.670750:INFO:CONSOLE(0)] "[SUCCESS] authRequiredNonBlocking", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0)
[9681:9681:0529/225657.293016:INFO:CONSOLE(0)] "[SUCCESS] authRequiredSyncNoAction", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0)
[9681:9681:0529/225700.335612:INFO:CONSOLE(0)] "[SUCCESS] authRequiredSyncCancelAuth", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0)
[9681:9681:0529/225703.324806:INFO:CONSOLE(0)] "[SUCCESS] authRequiredSyncSetAuth", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0)
[9681:9681:0529/225804.664156:INFO:CONSOLE(0)] "[SUCCESS] authRequiredAsyncNoAction", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0)
[9681:9681:0529/225928.685288:INFO:CONSOLE(0)] "[SUCCESS] authRequiredAsyncCancelAuth", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0)
BrowserTestBase received signal: Terminated. Backtrace:
    #0 0x000000a8dfe1 in __interceptor_backtrace /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/msan/../sanitizer_common/sanitizer_common_interceptors.inc:3980:13
    #1 0x00001350f30f in base::debug::StackTrace::StackTrace(unsigned long) ./../../base/debug/stack_trace_posix.cc:808:41
    #2 0x000014f9f062 in content::(anonymous namespace)::DumpStackTraceSignalHandler(int) ./../../content/public/test/browser_test_base.cc:87:5
    #3 0x000000ab5989 in SignalHandler(int) /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/msan/msan_interceptors.cc:995:3
    #4 0x7f6d3333fcb0 in killpg ??:?
    #5 0x7f6d3333fcb0 in ?? ??:0
    #6 0x7f6d334076d3 in epoll_wait /build/eglibc-ripdx6/eglibc-2.19/misc/../sysdeps/unix/syscall-template.S:81:0
    #7 0x000000a770a4 in __interceptor_epoll_wait /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/msan/msan_interceptors.cc:862:13
    #8 0x00001704b89b in epoll_dispatch ./../../base/third_party/libevent/epoll.c:198:8
    #9 0x00001703ec8b in event_base_loop ./../../base/third_party/libevent/event.c:512:9
    #10 0x00001355a138 in base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) ./../../base/message_loop/message_pump_libevent.cc:247:9
    #11 0x00001336b330 in base::RunLoop::Run() ./../../base/run_loop.cc:102:14
    #12 0x000015058275 in content::RunThisRunLoop(base::RunLoop*) ./../../content/public/test/test_utils.cc:128:13
    #13 0x00002b95647d in extensions::ResultCatcher::GetNextResult() ./../../extensions/test/result_catcher.cc:35:5
    #14 0x000004dfa6f2 in extensions::ExtensionApiTest::RunExtensionTestImpl(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, char const*, int) ./../../chrome/browser/extensions/extension_apitest.cc:392:16
    #15 0x0000049ace7e in extensions::ExtensionWebRequestApiTest_WebRequestAuthRequired_Test::RunTestOnMainThread() ./../../chrome/browser/extensions/api/web_request/web_request_apitest.cc:445:3
    #16 0x000014f9e3f2 in content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() ./../../content/public/test/browser_test_base.cc:385:5
    #17 0x00001387fbe5 in Run ./../../base/callback.h:125:12
    #18 0x00001387fbe5 in ChromeBrowserMainParts::PreMainMessageLoopRunImpl() ./../../chrome/browser/chrome_browser_main.cc:2098:0
    #19 0x00001387b5c0 in ChromeBrowserMainParts::PreMainMessageLoopRun() ./../../chrome/browser/chrome_browser_main.cc:1492:18
    #20 0x000007604b81 in chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() ./../../chrome/browser/chromeos/chrome_browser_main_chromeos.cc:684:32
    #21 0x00000bd8f78b in content::BrowserMainLoop::PreMainMessageLoopRun() ./../../content/browser/browser_main_loop.cc:962:13
    #22 0x00000d34ab21 in Run ./../../base/callback.h:125:12
    #23 0x00000d34ab21 in content::StartupTaskRunner::RunAllTasksNow() ./../../content/browser/startup_task_runner.cc:44:0
    #24 0x00000bd875e8 in content::BrowserMainLoop::CreateStartupTasks() ./../../content/browser/browser_main_loop.cc:873:25
    #25 0x00000bd9b176 in content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&, std::__1::unique_ptr<content::BrowserProcessSubThread, std::__1::default_delete<content::BrowserProcessSubThread> >) ./../../content/browser/browser_main_runner_impl.cc:148:15
    #26 0x00000bd7c28c in content::BrowserMain(content::MainFunctionParams const&, std::__1::unique_ptr<content::BrowserProcessSubThread, std::__1::default_delete<content::BrowserProcessSubThread> >) ./../../content/browser/browser_main.cc:47:20
    #27 0x000012ff6795 in content::RunBrowserProcessMain(content::MainFunctionParams const&, content::ContentMainDelegate*, std::__1::unique_ptr<content::BrowserProcessSubThread, std::__1::default_delete<content::BrowserProcessSubThread> >) ./../../content/app/content_main_runner_impl.cc:620:10
    #28 0x000012ffa9aa in content::ContentMainRunnerImpl::Run() ./../../content/app/content_main_runner_impl.cc:964:12
    #29 0x00001c607013 in service_manager::Main(service_manager::MainParams const&) ./../../services/service_manager/embedder/main.cc:459:29
    #30 0x000012ff0d18 in content::ContentMain(content::ContentMainParams const&) ./../../content/app/content_main.cc:19:10
    #31 0x000014f9c8c0 in content::BrowserTestBase::SetUp() ./../../content/public/test/browser_test_base.cc:323:3
    #32 0x00001372d0cf in InProcessBrowserTest::SetUp() ./../../chrome/test/base/in_process_browser_test.cc:244:20
    #33 0x000008b46826 in testing::Test::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0
    #34 0x000008b4a8bc in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2667:11
    #35 0x000008b4c34a in testing::TestCase::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2785:28
    #36 0x000008b82a55 in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5047:43
    #37 0x000008b81328 in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0
    #38 0x0000137959f1 in RUN_ALL_TESTS ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:2329:46
    #39 0x0000137959f1 in base::TestSuite::Run() ./../../base/test/test_suite.cc:275:0
    #40 0x0000131f45a4 in ChromeTestSuiteRunner::RunTestSuite(int, char**) ./../../chrome/test/base/chrome_test_launcher.cc:65:38
    #41 0x000015048025 in content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) ./../../content/public/test/test_launcher.cc:625:31
    #42 0x0000131f5d07 in LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) ./../../chrome/test/base/chrome_test_launcher.cc:170:10
    #43 0x0000131f4390 in main ./../../chrome/test/base/browser_tests_main_chromeos.cc:21:10
    #44 0x7f6d3332af45 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287:0
    #45 0x000000a511ba in _start ??:0:0
[ RUN      ] ExtensionWebRequestApiTest.WebRequestAuthRequired
[9971:9971:0529/225953.241021:WARNING:user_session_manager.cc(1091)] Attempting to save user password for non enterprise user.
ALSA lib confmisc.c:768:(parse_card) cannot find card '0'
ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_card_driver returned error: No such file or directory
ALSA lib confmisc.c:392:(snd_func_concat) error evaluating strings
ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_concat returned error: No such file or directory
ALSA lib confmisc.c:1251:(snd_func_refer) error evaluating name
ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory
ALSA lib conf.c:4727:(snd_config_expand) Evaluate error: No such file or directory
ALSA lib pcm.c:2239:(snd_pcm_open_noupdate) Unknown PCM default
[9971:9999:0529/225953.449328:WARNING:alsa_util.cc(24)] PcmOpen: default,No such file or directory
ALSA lib confmisc.c:768:(parse_card) cannot find card '0'
ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_card_driver returned error: No such file or directory
ALSA lib confmisc.c:392:(snd_func_concat) error evaluating strings
ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_concat returned error: No such file or directory
ALSA lib confmisc.c:1251:(snd_func_refer) error evaluating name
ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory
ALSA lib conf.c:4727:(snd_config_expand) Evaluate error: No such file or directory
ALSA lib pcm.c:2239:(snd_pcm_open_noupdate) Unknown PCM default
[9971:9999:0529/225953.449892:WARNING:alsa_util.cc(24)] PcmOpen: plug:default,No such file or directory
[9971:9971:0529/225958.400556:ERROR:textfield.cc(1754)] Not implemented reached in virtual bool views::Textfield::ShouldDoLearning()
[9971:10053:0529/225958.532493:WARNING:embedded_test_server.cc(229)] Request not handled. Returning 404: /favicon.ico
[9971:9971:0529/225959.377349:INFO:CONSOLE(0)] "[SUCCESS] authRequiredNonBlocking", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0)
[9971:9971:0529/230002.227064:INFO:CONSOLE(0)] "[SUCCESS] authRequiredSyncNoAction", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0)
[9971:9971:0529/230005.286414:INFO:CONSOLE(0)] "[SUCCESS] authRequiredSyncCancelAuth", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0)
[9971:9971:0529/230008.209328:INFO:CONSOLE(0)] "[SUCCESS] authRequiredSyncSetAuth", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0)
[9971:9971:0529/230103.646916:INFO:CONSOLE(0)] "[SUCCESS] authRequiredAsyncNoAction", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0)
[9971:9971:0529/230224.632095:INFO:CONSOLE(0)] "[SUCCESS] authRequiredAsyncCancelAuth", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0)
BrowserTestBase received signal: Terminated. Backtrace:
    #0 0x000000a8dfe1 in __interceptor_backtrace /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/msan/../sanitizer_common/sanitizer_common_interceptors.inc:3980:13
    #1 0x00001350f30f in base::debug::StackTrace::StackTrace(unsigned long) ./../../base/debug/stack_trace_posix.cc:808:41
    #2 0x000014f9f062 in content::(anonymous namespace)::DumpStackTraceSignalHandler(int) ./../../content/public/test/browser_test_base.cc:87:5
    #3 0x000000ab5989 in SignalHandler(int) /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/msan/msan_interceptors.cc:995:3
    #4 0x7f12d1488cb0 in killpg ??:?
    #5 0x7f12d1488cb0 in ?? ??:0
    #6 0x7f12d15506d3 in epoll_wait /build/eglibc-ripdx6/eglibc-2.19/misc/../sysdeps/unix/syscall-template.S:81:0
    #7 0x000000a770a4 in __interceptor_epoll_wait /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/msan/msan_interceptors.cc:862:13
    #8 0x00001704b89b in epoll_dispatch ./../../base/third_party/libevent/epoll.c:198:8
    #9 0x00001703ec8b in event_base_loop ./../../base/third_party/libevent/event.c:512:9
    #10 0x00001355a138 in base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) ./../../base/message_loop/message_pump_libevent.cc:247:9
    #11 0x00001336b330 in base::RunLoop::Run() ./../../base/run_loop.cc:102:14
    #12 0x000015058275 in content::RunThisRunLoop(base::RunLoop*) ./../../content/public/test/test_utils.cc:128:13
    #13 0x00002b95647d in extensions::ResultCatcher::GetNextResult() ./../../extensions/test/result_catcher.cc:35:5
    #14 0x000004dfa6f2 in extensions::ExtensionApiTest::RunExtensionTestImpl(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, char const*, int) ./../../chrome/browser/extensions/extension_apitest.cc:392:16
    #15 0x0000049ace7e in extensions::ExtensionWebRequestApiTest_WebRequestAuthRequired_Test::RunTestOnMainThread() ./../../chrome/browser/extensions/api/web_request/web_request_apitest.cc:445:3
    #16 0x000014f9e3f2 in content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() ./../../content/public/test/browser_test_base.cc:385:5
    #17 0x00001387fbe5 in Run ./../../base/callback.h:125:12
    #18 0x00001387fbe5 in ChromeBrowserMainParts::PreMainMessageLoopRunImpl() ./../../chrome/browser/chrome_browser_main.cc:2098:0
    #19 0x00001387b5c0 in ChromeBrowserMainParts::PreMainMessageLoopRun() ./../../chrome/browser/chrome_browser_main.cc:1492:18
    #20 0x000007604b81 in chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() ./../../chrome/browser/chromeos/chrome_browser_main_chromeos.cc:684:32
    #21 0x00000bd8f78b in content::BrowserMainLoop::PreMainMessageLoopRun() ./../../content/browser/browser_main_loop.cc:962:13
    #22 0x00000d34ab21 in Run ./../../base/callback.h:125:12
    #23 0x00000d34ab21 in content::StartupTaskRunner::RunAllTasksNow() ./../../content/browser/startup_task_runner.cc:44:0
    #24 0x00000bd875e8 in content::BrowserMainLoop::CreateStartupTasks() ./../../content/browser/browser_main_loop.cc:873:25
    #25 0x00000bd9b176 in content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&, std::__1::unique_ptr<content::BrowserProcessSubThread, std::__1::default_delete<content::BrowserProcessSubThread> >) ./../../content/browser/browser_main_runner_impl.cc:148:15
    #26 0x00000bd7c28c in content::BrowserMain(content::MainFunctionParams const&, std::__1::unique_ptr<content::BrowserProcessSubThread, std::__1::default_delete<content::BrowserProcessSubThread> >) ./../../content/browser/browser_main.cc:47:20
    #27 0x000012ff6795 in content::RunBrowserProcessMain(content::MainFunctionParams const&, content::ContentMainDelegate*, std::__1::unique_ptr<content::BrowserProcessSubThread, std::__1::default_delete<content::BrowserProcessSubThread> >) ./../../content/app/content_main_runner_impl.cc:620:10
    #28 0x000012ffa9aa in content::ContentMainRunnerImpl::Run() ./../../content/app/content_main_runner_impl.cc:964:12
    #29 0x00001c607013 in service_manager::Main(service_manager::MainParams const&) ./../../services/service_manager/embedder/main.cc:459:29
    #30 0x000012ff0d18 in content::ContentMain(content::ContentMainParams const&) ./../../content/app/content_main.cc:19:10
    #31 0x000014f9c8c0 in content::BrowserTestBase::SetUp() ./../../content/public/test/browser_test_base.cc:323:3
    #32 0x00001372d0cf in InProcessBrowserTest::SetUp() ./../../chrome/test/base/in_process_browser_test.cc:244:20
    #33 0x000008b46826 in testing::Test::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0
    #34 0x000008b4a8bc in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2667:11
    #35 0x000008b4c34a in testing::TestCase::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2785:28
    #36 0x000008b82a55 in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5047:43
    #37 0x000008b81328 in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0
    #38 0x0000137959f1 in RUN_ALL_TESTS ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:2329:46
    #39 0x0000137959f1 in base::TestSuite::Run() ./../../base/test/test_suite.cc:275:0
    #40 0x0000131f45a4 in ChromeTestSuiteRunner::RunTestSuite(int, char**) ./../../chrome/test/base/chrome_test_launcher.cc:65:38
    #41 0x000015048025 in content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) ./../../content/public/test/test_launcher.cc:625:31
    #42 0x0000131f5d07 in LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) ./../../chrome/test/base/chrome_test_launcher.cc:170:10
    #43 0x0000131f4390 in main ./../../chrome/test/base/browser_tests_main_chromeos.cc:21:10
    #44 0x7f12d1473f45 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287:0
    #45 0x000000a511ba in _start ??:0:0
[ RUN      ] ExtensionWebRequestApiTest.WebRequestAuthRequired
[10186:10186:0529/230253.379633:WARNING:user_session_manager.cc(1091)] Attempting to save user password for non enterprise user.
ALSA lib confmisc.c:768:(parse_card) cannot find card '0'
ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_card_driver returned error: No such file or directory
ALSA lib confmisc.c:392:(snd_func_concat) error evaluating strings
ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_concat returned error: No such file or directory
ALSA lib confmisc.c:1251:(snd_func_refer) error evaluating name
ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory
ALSA lib conf.c:4727:(snd_config_expand) Evaluate error: No such file or directory
ALSA lib pcm.c:2239:(snd_pcm_open_noupdate) Unknown PCM default
[10186:10214:0529/230253.588059:WARNING:alsa_util.cc(24)] PcmOpen: default,No such file or directory
ALSA lib confmisc.c:768:(parse_card) cannot find card '0'
ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_card_driver returned error: No such file or directory
ALSA lib confmisc.c:392:(snd_func_concat) error evaluating strings
ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_concat returned error: No such file or directory
ALSA lib confmisc.c:1251:(snd_func_refer) error evaluating name
ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory
ALSA lib conf.c:4727:(snd_config_expand) Evaluate error: No such file or directory
ALSA lib pcm.c:2239:(snd_pcm_open_noupdate) Unknown PCM default
[10186:10214:0529/230253.589228:WARNING:alsa_util.cc(24)] PcmOpen: plug:default,No such file or directory
[10186:10186:0529/230258.651324:ERROR:textfield.cc(1754)] Not implemented reached in virtual bool views::Textfield::ShouldDoLearning()
[10186:10267:0529/230258.790038:WARNING:embedded_test_server.cc(229)] Request not handled. Returning 404: /favicon.ico
[10186:10186:0529/230259.634483:INFO:CONSOLE(0)] "[SUCCESS] authRequiredNonBlocking", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0)
[10186:10186:0529/230302.223698:INFO:CONSOLE(0)] "[SUCCESS] authRequiredSyncNoAction", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0)
[10186:10186:0529/230305.265591:INFO:CONSOLE(0)] "[SUCCESS] authRequiredSyncCancelAuth", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0)
[10186:10186:0529/230308.238544:INFO:CONSOLE(0)] "[SUCCESS] authRequiredSyncSetAuth", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0)
[10186:10186:0529/230402.646445:INFO:CONSOLE(0)] "[SUCCESS] authRequiredAsyncNoAction", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0)
[10186:10186:0529/230525.634213:INFO:CONSOLE(0)] "[SUCCESS] authRequiredAsyncCancelAuth", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0)
BrowserTestBase received signal: Terminated. Backtrace:
    #0 0x000000a8dfe1 in __interceptor_backtrace /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/msan/../sanitizer_common/sanitizer_common_interceptors.inc:3980:13
    #1 0x00001350f30f in base::debug::StackTrace::StackTrace(unsigned long) ./../../base/debug/stack_trace_posix.cc:808:41
    #2 0x000014f9f062 in content::(anonymous namespace)::DumpStackTraceSignalHandler(int) ./../../content/public/test/browser_test_base.cc:87:5
    #3 0x000000ab5989 in SignalHandler(int) /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/msan/msan_interceptors.cc:995:3
    #4 0x7f0a55d86cb0 in killpg ??:?
    #5 0x7f0a55d86cb0 in ?? ??:0
    #6 0x000000a6d2d4 in __msan_set_alloca_origin4 /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/msan/msan.cc:558:12
    #7 0x00001b72c053 in std::__1::enable_if<(__is_forward_iterator<std::__1::__wrap_iter<cc::DrawImage*> >::value) && (is_constructible<cc::DrawImage, std::__1::iterator_traits<std::__1::__wrap_iter<cc::DrawImage*> >::reference>::value), std::__1::__wrap_iter<cc::DrawImage*> >::type std::__1::vector<cc::DrawImage, std::__1::allocator<cc::DrawImage> >::insert<std::__1::__wrap_iter<cc::DrawImage*> >(std::__1::__wrap_iter<cc::DrawImage const*>, std::__1::__wrap_iter<cc::DrawImage*>, std::__1::__wrap_iter<cc::DrawImage*>) ./../../buildtools/third_party/libc++/trunk/include/vector:1959:0
    #8 0x00001b71d05d in cc::TileManager::ScheduleTasks(cc::TileManager::PrioritizedWorkToSchedule) ./../../cc/tiles/tile_manager.cc:1021:21
    #9 0x00001b716797 in cc::TileManager::PrepareTiles(cc::GlobalStateThatImpactsTilePriority const&) ./../../cc/tiles/tile_manager.cc:520:3
    #10 0x00001b4bb195 in cc::LayerTreeHostImpl::PrepareTiles() ./../../cc/trees/layer_tree_host_impl.cc:607:42
    #11 0x00001b7ebfac in cc::SingleThreadProxy::ScheduledActionPrepareTiles() ./../../cc/trees/single_thread_proxy.cc:834:15
    #12 0x00001b83107b in cc::Scheduler::ProcessScheduledActions() ./../../cc/scheduler/scheduler.cc:0:20
    #13 0x00001b82fe9f in cc::Scheduler::OnBeginImplFrameDeadline() ./../../cc/scheduler/scheduler.cc:642:3
    #14 0x00001322a1d2 in Run ./../../base/callback.h:96:12
    #15 0x00001322a1d2 in base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) ./../../base/debug/task_annotator.cc:101:0
    #16 0x0000132ab7a5 in base::MessageLoop::RunTask(base::PendingTask*) ./../../base/message_loop/message_loop.cc:319:25
    #17 0x0000132adb1b in DeferOrRunPendingTask ./../../base/message_loop/message_loop.cc:329:5
    #18 0x0000132adb1b in base::MessageLoop::DoDelayedWork(base::TimeTicks*) ./../../base/message_loop/message_loop.cc:413:0
    #19 0x000013559d67 in base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) ./../../base/message_loop/message_pump_libevent.cc:220:27
    #20 0x00001336b330 in base::RunLoop::Run() ./../../base/run_loop.cc:102:14
    #21 0x000015058275 in content::RunThisRunLoop(base::RunLoop*) ./../../content/public/test/test_utils.cc:128:13
    #22 0x00002b95647d in extensions::ResultCatcher::GetNextResult() ./../../extensions/test/result_catcher.cc:35:5
    #23 0x000004dfa6f2 in extensions::ExtensionApiTest::RunExtensionTestImpl(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, char const*, int) ./../../chrome/browser/extensions/extension_apitest.cc:392:16
    #24 0x0000049ace7e in extensions::ExtensionWebRequestApiTest_WebRequestAuthRequired_Test::RunTestOnMainThread() ./../../chrome/browser/extensions/api/web_request/web_request_apitest.cc:445:3
    #25 0x000014f9e3f2 in content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() ./../../content/public/test/browser_test_base.cc:385:5
    #26 0x00001387fbe5 in Run ./../../base/callback.h:125:12
    #27 0x00001387fbe5 in ChromeBrowserMainParts::PreMainMessageLoopRunImpl() ./../../chrome/browser/chrome_browser_main.cc:2098:0
    #28 0x00001387b5c0 in ChromeBrowserMainParts::PreMainMessageLoopRun() ./../../chrome/browser/chrome_browser_main.cc:1492:18
    #29 0x000007604b81 in chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() ./../../chrome/browser/chromeos/chrome_browser_main_chromeos.cc:684:32
    #30 0x00000bd8f78b in content::BrowserMainLoop::PreMainMessageLoopRun() ./../../content/browser/browser_main_loop.cc:962:13
    #31 0x00000d34ab21 in Run ./../../base/callback.h:125:12
    #32 0x00000d34ab21 in content::StartupTaskRunner::RunAllTasksNow() ./../../content/browser/startup_task_runner.cc:44:0
    #33 0x00000bd875e8 in content::BrowserMainLoop::CreateStartupTasks() ./../../content/browser/browser_main_loop.cc:873:25
    #34 0x00000bd9b176 in content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&, std::__1::unique_ptr<content::BrowserProcessSubThread, std::__1::default_delete<content::BrowserProcessSubThread> >) ./../../content/browser/browser_main_runner_impl.cc:148:15
    #35 0x00000bd7c28c in content::BrowserMain(content::MainFunctionParams const&, std::__1::unique_ptr<content::BrowserProcessSubThread, std::__1::default_delete<content::BrowserProcessSubThread> >) ./../../content/browser/browser_main.cc:47:20
    #36 0x000012ff6795 in content::RunBrowserProcessMain(content::MainFunctionParams const&, content::ContentMainDelegate*, std::__1::unique_ptr<content::BrowserProcessSubThread, std::__1::default_delete<content::BrowserProcessSubThread> >) ./../../content/app/content_main_runner_impl.cc:620:10
    #37 0x000012ffa9aa in content::ContentMainRunnerImpl::Run() ./../../content/app/content_main_runner_impl.cc:964:12
    #38 0x00001c607013 in service_manager::Main(service_manager::MainParams const&) ./../../services/service_manager/embedder/main.cc:459:29
    #39 0x000012ff0d18 in content::ContentMain(content::ContentMainParams const&) ./../../content/app/content_main.cc:19:10
    #40 0x000014f9c8c0 in content::BrowserTestBase::SetUp() ./../../content/public/test/browser_test_base.cc:323:3
    #41 0x00001372d0cf in InProcessBrowserTest::SetUp() ./../../chrome/test/base/in_process_browser_test.cc:244:20
    #42 0x000008b46826 in testing::Test::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0
    #43 0x000008b4a8bc in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2667:11
    #44 0x000008b4c34a in testing::TestCase::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2785:28
    #45 0x000008b82a55 in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5047:43
    #46 0x000008b81328 in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0
    #47 0x0000137959f1 in RUN_ALL_TESTS ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:2329:46
    #48 0x0000137959f1 in base::TestSuite::Run() ./../../base/test/test_suite.cc:275:0
    #49 0x0000131f45a4 in ChromeTestSuiteRunner::RunTestSuite(int, char**) ./../../chrome/test/base/chrome_test_launcher.cc:65:38
    #50 0x000015048025 in content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) ./../../content/public/test/test_launcher.cc:625:31
    #51 0x0000131f5d07 in LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) ./../../chrome/test/base/chrome_test_launcher.cc:170:10
    #52 0x0000131f4390 in main ./../../chrome/test/base/browser_tests_main_chromeos.cc:21:10
    #53 0x7f0a55d71f45 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287:0
    #54 0x000000a511ba in _start ??:0:0


Original change's description:
> shared worker: Add tests for Chrome extensions.
> 
> We didn't have specific test coverage for shared worker from Chrome
> extensions, just incidental ones via the ExtensionApiTest.Debugger and
> ExtensionApiTestWithSwitch.ExtensionDebugger.
> 
> Shared workers go through a very different loading path than other
> resources, so it's useful to have tests for them especially
> including interaction with service workers.
> 
> This adds tests that currently fail with NetworkService, a next
> patch will have a fix.
> 
> Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
> Change-Id: Ifa6bb3dec8bdea34c3fbefbaeab324fadcb5c929
> Bug: 839982
> Reviewed-on: https://chromium-review.googlesource.com/1074848
> Commit-Queue: Matt Falkenhagen <falken@chromium.org>
> Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#562700}

TBR=falken@chromium.org,lazyboy@chromium.org

Change-Id: I880c6e859c9414070ad4783dc9e703f4324ecf29
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 839982
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Reviewed-on: https://chromium-review.googlesource.com/1078367
Reviewed-by: Thiemo Nagel <tnagel@chromium.org>
Commit-Queue: Thiemo Nagel <tnagel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562766}
jkim-julie pushed a commit that referenced this issue Jun 4, 2018
@thiemonagel
Reland "shared worker: Add tests for Chrome extensions."
610eddf 
This reverts commit 4796a2a.

Reason for revert: The test failure is a flake. I should have checked before. :(

Original change's description:
> Revert "shared worker: Add tests for Chrome extensions."
> 
> This reverts commit 62628bf.
> 
> Reason for revert: Speculative revert due to Linux ChromiumOS MSan Tests failures:
> 
> https://ci.chromium.org/buildbot/chromium.memory/Linux%20ChromiumOS%20MSan%20Tests/7363
> 
>  [ RUN      ] ExtensionWebRequestApiTest.WebRequestAuthRequired
> [14149:14149:0529/223016.256914:WARNING:user_session_manager.cc(1091)] Attempting to save user password for non enterprise user.
> ALSA lib confmisc.c:768:(parse_card) cannot find card '0'
> ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_card_driver returned error: No such file or directory
> ALSA lib confmisc.c:392:(snd_func_concat) error evaluating strings
> ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_concat returned error: No such file or directory
> ALSA lib confmisc.c:1251:(snd_func_refer) error evaluating name
> ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory
> ALSA lib conf.c:4727:(snd_config_expand) Evaluate error: No such file or directory
> ALSA lib pcm.c:2239:(snd_pcm_open_noupdate) Unknown PCM default
> [14149:14299:0529/223016.655436:WARNING:alsa_util.cc(24)] PcmOpen: default,No such file or directory
> ALSA lib confmisc.c:768:(parse_card) cannot find card '0'
> ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_card_driver returned error: No such file or directory
> ALSA lib confmisc.c:392:(snd_func_concat) error evaluating strings
> ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_concat returned error: No such file or directory
> ALSA lib confmisc.c:1251:(snd_func_refer) error evaluating name
> ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory
> ALSA lib conf.c:4727:(snd_config_expand) Evaluate error: No such file or directory
> ALSA lib pcm.c:2239:(snd_pcm_open_noupdate) Unknown PCM default
> [14149:14299:0529/223016.656150:WARNING:alsa_util.cc(24)] PcmOpen: plug:default,No such file or directory
> [14149:14149:0529/223023.245267:ERROR:textfield.cc(1754)] Not implemented reached in virtual bool views::Textfield::ShouldDoLearning()
> [14149:14372:0529/223023.626405:WARNING:embedded_test_server.cc(229)] Request not handled. Returning 404: /favicon.ico
> [14149:14149:0529/223024.849020:INFO:CONSOLE(0)] "[SUCCESS] authRequiredNonBlocking", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0)
> [14149:14149:0529/223027.955574:INFO:CONSOLE(0)] "[SUCCESS] authRequiredSyncNoAction", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0)
> [14149:14149:0529/223031.378924:INFO:CONSOLE(0)] "[SUCCESS] authRequiredSyncCancelAuth", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0)
> [14149:14149:0529/223034.498789:INFO:CONSOLE(0)] "[SUCCESS] authRequiredSyncSetAuth", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0)
> [14149:14149:0529/223216.859287:INFO:CONSOLE(0)] "[SUCCESS] authRequiredAsyncNoAction", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0)
> BrowserTestBase received signal: Terminated. Backtrace:
>     #0 0x000000a8dfe1 in __interceptor_backtrace /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/msan/../sanitizer_common/sanitizer_common_interceptors.inc:3980:13
>     #1 0x00001350f30f in base::debug::StackTrace::StackTrace(unsigned long) ./../../base/debug/stack_trace_posix.cc:808:41
>     #2 0x000014f9f062 in content::(anonymous namespace)::DumpStackTraceSignalHandler(int) ./../../content/public/test/browser_test_base.cc:87:5
>     #3 0x000000ab5989 in SignalHandler(int) /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/msan/msan_interceptors.cc:995:3
>     #4 0x7fe3e82dacb0 in killpg ??:?
>     #5 0x7fe3e82dacb0 in ?? ??:0
>     #6 0x7fe3e83a26d3 in epoll_wait /build/eglibc-ripdx6/eglibc-2.19/misc/../sysdeps/unix/syscall-template.S:81:0
>     #7 0x000000a770a4 in __interceptor_epoll_wait /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/msan/msan_interceptors.cc:862:13
>     #8 0x00001704b89b in epoll_dispatch ./../../base/third_party/libevent/epoll.c:198:8
>     #9 0x00001703ec8b in event_base_loop ./../../base/third_party/libevent/event.c:512:9
>     #10 0x00001355a138 in base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) ./../../base/message_loop/message_pump_libevent.cc:247:9
>     #11 0x00001336b330 in base::RunLoop::Run() ./../../base/run_loop.cc:102:14
>     #12 0x000015058275 in content::RunThisRunLoop(base::RunLoop*) ./../../content/public/test/test_utils.cc:128:13
>     #13 0x00002b95647d in extensions::ResultCatcher::GetNextResult() ./../../extensions/test/result_catcher.cc:35:5
>     #14 0x000004dfa6f2 in extensions::ExtensionApiTest::RunExtensionTestImpl(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, char const*, int) ./../../chrome/browser/extensions/extension_apitest.cc:392:16
>     #15 0x0000049ace7e in extensions::ExtensionWebRequestApiTest_WebRequestAuthRequired_Test::RunTestOnMainThread() ./../../chrome/browser/extensions/api/web_request/web_request_apitest.cc:445:3
>     #16 0x000014f9e3f2 in content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() ./../../content/public/test/browser_test_base.cc:385:5
>     #17 0x00001387fbe5 in Run ./../../base/callback.h:125:12
>     #18 0x00001387fbe5 in ChromeBrowserMainParts::PreMainMessageLoopRunImpl() ./../../chrome/browser/chrome_browser_main.cc:2098:0
>     #19 0x00001387b5c0 in ChromeBrowserMainParts::PreMainMessageLoopRun() ./../../chrome/browser/chrome_browser_main.cc:1492:18
>     #20 0x000007604b81 in chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() ./../../chrome/browser/chromeos/chrome_browser_main_chromeos.cc:684:32
>     #21 0x00000bd8f78b in content::BrowserMainLoop::PreMainMessageLoopRun() ./../../content/browser/browser_main_loop.cc:962:13
>     #22 0x00000d34ab21 in Run ./../../base/callback.h:125:12
>     #23 0x00000d34ab21 in content::StartupTaskRunner::RunAllTasksNow() ./../../content/browser/startup_task_runner.cc:44:0
>     #24 0x00000bd875e8 in content::BrowserMainLoop::CreateStartupTasks() ./../../content/browser/browser_main_loop.cc:873:25
>     #25 0x00000bd9b176 in content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&, std::__1::unique_ptr<content::BrowserProcessSubThread, std::__1::default_delete<content::BrowserProcessSubThread> >) ./../../content/browser/browser_main_runner_impl.cc:148:15
>     #26 0x00000bd7c28c in content::BrowserMain(content::MainFunctionParams const&, std::__1::unique_ptr<content::BrowserProcessSubThread, std::__1::default_delete<content::BrowserProcessSubThread> >) ./../../content/browser/browser_main.cc:47:20
>     #27 0x000012ff6795 in content::RunBrowserProcessMain(content::MainFunctionParams const&, content::ContentMainDelegate*, std::__1::unique_ptr<content::BrowserProcessSubThread, std::__1::default_delete<content::BrowserProcessSubThread> >) ./../../content/app/content_main_runner_impl.cc:620:10
>     #28 0x000012ffa9aa in content::ContentMainRunnerImpl::Run() ./../../content/app/content_main_runner_impl.cc:964:12
>     #29 0x00001c607013 in service_manager::Main(service_manager::MainParams const&) ./../../services/service_manager/embedder/main.cc:459:29
>     #30 0x000012ff0d18 in content::ContentMain(content::ContentMainParams const&) ./../../content/app/content_main.cc:19:10
>     #31 0x000014f9c8c0 in content::BrowserTestBase::SetUp() ./../../content/public/test/browser_test_base.cc:323:3
>     #32 0x00001372d0cf in InProcessBrowserTest::SetUp() ./../../chrome/test/base/in_process_browser_test.cc:244:20
>     #33 0x000008b46826 in testing::Test::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0
>     #34 0x000008b4a8bc in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2667:11
>     #35 0x000008b4c34a in testing::TestCase::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2785:28
>     #36 0x000008b82a55 in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5047:43
>     #37 0x000008b81328 in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0
>     #38 0x0000137959f1 in RUN_ALL_TESTS ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:2329:46
>     #39 0x0000137959f1 in base::TestSuite::Run() ./../../base/test/test_suite.cc:275:0
>     #40 0x0000131f45a4 in ChromeTestSuiteRunner::RunTestSuite(int, char**) ./../../chrome/test/base/chrome_test_launcher.cc:65:38
>     #41 0x000015048025 in content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) ./../../content/public/test/test_launcher.cc:625:31
>     #42 0x0000131f5d07 in LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) ./../../chrome/test/base/chrome_test_launcher.cc:170:10
>     #43 0x0000131f4390 in main ./../../chrome/test/base/browser_tests_main_chromeos.cc:21:10
>     #44 0x7fe3e82c5f45 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287:0
>     #45 0x000000a511ba in _start ??:0:0
> [ RUN      ] ExtensionWebRequestApiTest.WebRequestAuthRequired
> [9681:9681:0529/225648.292655:WARNING:user_session_manager.cc(1091)] Attempting to save user password for non enterprise user.
> ALSA lib confmisc.c:768:(parse_card) cannot find card '0'
> ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_card_driver returned error: No such file or directory
> ALSA lib confmisc.c:392:(snd_func_concat) error evaluating strings
> ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_concat returned error: No such file or directory
> ALSA lib confmisc.c:1251:(snd_func_refer) error evaluating name
> ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory
> ALSA lib conf.c:4727:(snd_config_expand) Evaluate error: No such file or directory
> ALSA lib pcm.c:2239:(snd_pcm_open_noupdate) Unknown PCM default
> [9681:9709:0529/225648.491081:WARNING:alsa_util.cc(24)] PcmOpen: default,No such file or directory
> ALSA lib confmisc.c:768:(parse_card) cannot find card '0'
> ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_card_driver returned error: No such file or directory
> ALSA lib confmisc.c:392:(snd_func_concat) error evaluating strings
> ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_concat returned error: No such file or directory
> ALSA lib confmisc.c:1251:(snd_func_refer) error evaluating name
> ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory
> ALSA lib conf.c:4727:(snd_config_expand) Evaluate error: No such file or directory
> ALSA lib pcm.c:2239:(snd_pcm_open_noupdate) Unknown PCM default
> [9681:9709:0529/225648.491704:WARNING:alsa_util.cc(24)] PcmOpen: plug:default,No such file or directory
> [9681:9681:0529/225653.563139:ERROR:textfield.cc(1754)] Not implemented reached in virtual bool views::Textfield::ShouldDoLearning()
> [9681:9764:0529/225653.719267:WARNING:embedded_test_server.cc(229)] Request not handled. Returning 404: /favicon.ico
> [9681:9681:0529/225654.670750:INFO:CONSOLE(0)] "[SUCCESS] authRequiredNonBlocking", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0)
> [9681:9681:0529/225657.293016:INFO:CONSOLE(0)] "[SUCCESS] authRequiredSyncNoAction", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0)
> [9681:9681:0529/225700.335612:INFO:CONSOLE(0)] "[SUCCESS] authRequiredSyncCancelAuth", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0)
> [9681:9681:0529/225703.324806:INFO:CONSOLE(0)] "[SUCCESS] authRequiredSyncSetAuth", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0)
> [9681:9681:0529/225804.664156:INFO:CONSOLE(0)] "[SUCCESS] authRequiredAsyncNoAction", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0)
> [9681:9681:0529/225928.685288:INFO:CONSOLE(0)] "[SUCCESS] authRequiredAsyncCancelAuth", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0)
> BrowserTestBase received signal: Terminated. Backtrace:
>     #0 0x000000a8dfe1 in __interceptor_backtrace /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/msan/../sanitizer_common/sanitizer_common_interceptors.inc:3980:13
>     #1 0x00001350f30f in base::debug::StackTrace::StackTrace(unsigned long) ./../../base/debug/stack_trace_posix.cc:808:41
>     #2 0x000014f9f062 in content::(anonymous namespace)::DumpStackTraceSignalHandler(int) ./../../content/public/test/browser_test_base.cc:87:5
>     #3 0x000000ab5989 in SignalHandler(int) /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/msan/msan_interceptors.cc:995:3
>     #4 0x7f6d3333fcb0 in killpg ??:?
>     #5 0x7f6d3333fcb0 in ?? ??:0
>     #6 0x7f6d334076d3 in epoll_wait /build/eglibc-ripdx6/eglibc-2.19/misc/../sysdeps/unix/syscall-template.S:81:0
>     #7 0x000000a770a4 in __interceptor_epoll_wait /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/msan/msan_interceptors.cc:862:13
>     #8 0x00001704b89b in epoll_dispatch ./../../base/third_party/libevent/epoll.c:198:8
>     #9 0x00001703ec8b in event_base_loop ./../../base/third_party/libevent/event.c:512:9
>     #10 0x00001355a138 in base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) ./../../base/message_loop/message_pump_libevent.cc:247:9
>     #11 0x00001336b330 in base::RunLoop::Run() ./../../base/run_loop.cc:102:14
>     #12 0x000015058275 in content::RunThisRunLoop(base::RunLoop*) ./../../content/public/test/test_utils.cc:128:13
>     #13 0x00002b95647d in extensions::ResultCatcher::GetNextResult() ./../../extensions/test/result_catcher.cc:35:5
>     #14 0x000004dfa6f2 in extensions::ExtensionApiTest::RunExtensionTestImpl(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, char const*, int) ./../../chrome/browser/extensions/extension_apitest.cc:392:16
>     #15 0x0000049ace7e in extensions::ExtensionWebRequestApiTest_WebRequestAuthRequired_Test::RunTestOnMainThread() ./../../chrome/browser/extensions/api/web_request/web_request_apitest.cc:445:3
>     #16 0x000014f9e3f2 in content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() ./../../content/public/test/browser_test_base.cc:385:5
>     #17 0x00001387fbe5 in Run ./../../base/callback.h:125:12
>     #18 0x00001387fbe5 in ChromeBrowserMainParts::PreMainMessageLoopRunImpl() ./../../chrome/browser/chrome_browser_main.cc:2098:0
>     #19 0x00001387b5c0 in ChromeBrowserMainParts::PreMainMessageLoopRun() ./../../chrome/browser/chrome_browser_main.cc:1492:18
>     #20 0x000007604b81 in chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() ./../../chrome/browser/chromeos/chrome_browser_main_chromeos.cc:684:32
>     #21 0x00000bd8f78b in content::BrowserMainLoop::PreMainMessageLoopRun() ./../../content/browser/browser_main_loop.cc:962:13
>     #22 0x00000d34ab21 in Run ./../../base/callback.h:125:12
>     #23 0x00000d34ab21 in content::StartupTaskRunner::RunAllTasksNow() ./../../content/browser/startup_task_runner.cc:44:0
>     #24 0x00000bd875e8 in content::BrowserMainLoop::CreateStartupTasks() ./../../content/browser/browser_main_loop.cc:873:25
>     #25 0x00000bd9b176 in content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&, std::__1::unique_ptr<content::BrowserProcessSubThread, std::__1::default_delete<content::BrowserProcessSubThread> >) ./../../content/browser/browser_main_runner_impl.cc:148:15
>     #26 0x00000bd7c28c in content::BrowserMain(content::MainFunctionParams const&, std::__1::unique_ptr<content::BrowserProcessSubThread, std::__1::default_delete<content::BrowserProcessSubThread> >) ./../../content/browser/browser_main.cc:47:20
>     #27 0x000012ff6795 in content::RunBrowserProcessMain(content::MainFunctionParams const&, content::ContentMainDelegate*, std::__1::unique_ptr<content::BrowserProcessSubThread, std::__1::default_delete<content::BrowserProcessSubThread> >) ./../../content/app/content_main_runner_impl.cc:620:10
>     #28 0x000012ffa9aa in content::ContentMainRunnerImpl::Run() ./../../content/app/content_main_runner_impl.cc:964:12
>     #29 0x00001c607013 in service_manager::Main(service_manager::MainParams const&) ./../../services/service_manager/embedder/main.cc:459:29
>     #30 0x000012ff0d18 in content::ContentMain(content::ContentMainParams const&) ./../../content/app/content_main.cc:19:10
>     #31 0x000014f9c8c0 in content::BrowserTestBase::SetUp() ./../../content/public/test/browser_test_base.cc:323:3
>     #32 0x00001372d0cf in InProcessBrowserTest::SetUp() ./../../chrome/test/base/in_process_browser_test.cc:244:20
>     #33 0x000008b46826 in testing::Test::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0
>     #34 0x000008b4a8bc in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2667:11
>     #35 0x000008b4c34a in testing::TestCase::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2785:28
>     #36 0x000008b82a55 in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5047:43
>     #37 0x000008b81328 in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0
>     #38 0x0000137959f1 in RUN_ALL_TESTS ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:2329:46
>     #39 0x0000137959f1 in base::TestSuite::Run() ./../../base/test/test_suite.cc:275:0
>     #40 0x0000131f45a4 in ChromeTestSuiteRunner::RunTestSuite(int, char**) ./../../chrome/test/base/chrome_test_launcher.cc:65:38
>     #41 0x000015048025 in content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) ./../../content/public/test/test_launcher.cc:625:31
>     #42 0x0000131f5d07 in LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) ./../../chrome/test/base/chrome_test_launcher.cc:170:10
>     #43 0x0000131f4390 in main ./../../chrome/test/base/browser_tests_main_chromeos.cc:21:10
>     #44 0x7f6d3332af45 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287:0
>     #45 0x000000a511ba in _start ??:0:0
> [ RUN      ] ExtensionWebRequestApiTest.WebRequestAuthRequired
> [9971:9971:0529/225953.241021:WARNING:user_session_manager.cc(1091)] Attempting to save user password for non enterprise user.
> ALSA lib confmisc.c:768:(parse_card) cannot find card '0'
> ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_card_driver returned error: No such file or directory
> ALSA lib confmisc.c:392:(snd_func_concat) error evaluating strings
> ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_concat returned error: No such file or directory
> ALSA lib confmisc.c:1251:(snd_func_refer) error evaluating name
> ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory
> ALSA lib conf.c:4727:(snd_config_expand) Evaluate error: No such file or directory
> ALSA lib pcm.c:2239:(snd_pcm_open_noupdate) Unknown PCM default
> [9971:9999:0529/225953.449328:WARNING:alsa_util.cc(24)] PcmOpen: default,No such file or directory
> ALSA lib confmisc.c:768:(parse_card) cannot find card '0'
> ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_card_driver returned error: No such file or directory
> ALSA lib confmisc.c:392:(snd_func_concat) error evaluating strings
> ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_concat returned error: No such file or directory
> ALSA lib confmisc.c:1251:(snd_func_refer) error evaluating name
> ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory
> ALSA lib conf.c:4727:(snd_config_expand) Evaluate error: No such file or directory
> ALSA lib pcm.c:2239:(snd_pcm_open_noupdate) Unknown PCM default
> [9971:9999:0529/225953.449892:WARNING:alsa_util.cc(24)] PcmOpen: plug:default,No such file or directory
> [9971:9971:0529/225958.400556:ERROR:textfield.cc(1754)] Not implemented reached in virtual bool views::Textfield::ShouldDoLearning()
> [9971:10053:0529/225958.532493:WARNING:embedded_test_server.cc(229)] Request not handled. Returning 404: /favicon.ico
> [9971:9971:0529/225959.377349:INFO:CONSOLE(0)] "[SUCCESS] authRequiredNonBlocking", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0)
> [9971:9971:0529/230002.227064:INFO:CONSOLE(0)] "[SUCCESS] authRequiredSyncNoAction", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0)
> [9971:9971:0529/230005.286414:INFO:CONSOLE(0)] "[SUCCESS] authRequiredSyncCancelAuth", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0)
> [9971:9971:0529/230008.209328:INFO:CONSOLE(0)] "[SUCCESS] authRequiredSyncSetAuth", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0)
> [9971:9971:0529/230103.646916:INFO:CONSOLE(0)] "[SUCCESS] authRequiredAsyncNoAction", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0)
> [9971:9971:0529/230224.632095:INFO:CONSOLE(0)] "[SUCCESS] authRequiredAsyncCancelAuth", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0)
> BrowserTestBase received signal: Terminated. Backtrace:
>     #0 0x000000a8dfe1 in __interceptor_backtrace /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/msan/../sanitizer_common/sanitizer_common_interceptors.inc:3980:13
>     #1 0x00001350f30f in base::debug::StackTrace::StackTrace(unsigned long) ./../../base/debug/stack_trace_posix.cc:808:41
>     #2 0x000014f9f062 in content::(anonymous namespace)::DumpStackTraceSignalHandler(int) ./../../content/public/test/browser_test_base.cc:87:5
>     #3 0x000000ab5989 in SignalHandler(int) /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/msan/msan_interceptors.cc:995:3
>     #4 0x7f12d1488cb0 in killpg ??:?
>     #5 0x7f12d1488cb0 in ?? ??:0
>     #6 0x7f12d15506d3 in epoll_wait /build/eglibc-ripdx6/eglibc-2.19/misc/../sysdeps/unix/syscall-template.S:81:0
>     #7 0x000000a770a4 in __interceptor_epoll_wait /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/msan/msan_interceptors.cc:862:13
>     #8 0x00001704b89b in epoll_dispatch ./../../base/third_party/libevent/epoll.c:198:8
>     #9 0x00001703ec8b in event_base_loop ./../../base/third_party/libevent/event.c:512:9
>     #10 0x00001355a138 in base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) ./../../base/message_loop/message_pump_libevent.cc:247:9
>     #11 0x00001336b330 in base::RunLoop::Run() ./../../base/run_loop.cc:102:14
>     #12 0x000015058275 in content::RunThisRunLoop(base::RunLoop*) ./../../content/public/test/test_utils.cc:128:13
>     #13 0x00002b95647d in extensions::ResultCatcher::GetNextResult() ./../../extensions/test/result_catcher.cc:35:5
>     #14 0x000004dfa6f2 in extensions::ExtensionApiTest::RunExtensionTestImpl(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, char const*, int) ./../../chrome/browser/extensions/extension_apitest.cc:392:16
>     #15 0x0000049ace7e in extensions::ExtensionWebRequestApiTest_WebRequestAuthRequired_Test::RunTestOnMainThread() ./../../chrome/browser/extensions/api/web_request/web_request_apitest.cc:445:3
>     #16 0x000014f9e3f2 in content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() ./../../content/public/test/browser_test_base.cc:385:5
>     #17 0x00001387fbe5 in Run ./../../base/callback.h:125:12
>     #18 0x00001387fbe5 in ChromeBrowserMainParts::PreMainMessageLoopRunImpl() ./../../chrome/browser/chrome_browser_main.cc:2098:0
>     #19 0x00001387b5c0 in ChromeBrowserMainParts::PreMainMessageLoopRun() ./../../chrome/browser/chrome_browser_main.cc:1492:18
>     #20 0x000007604b81 in chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() ./../../chrome/browser/chromeos/chrome_browser_main_chromeos.cc:684:32
>     #21 0x00000bd8f78b in content::BrowserMainLoop::PreMainMessageLoopRun() ./../../content/browser/browser_main_loop.cc:962:13
>     #22 0x00000d34ab21 in Run ./../../base/callback.h:125:12
>     #23 0x00000d34ab21 in content::StartupTaskRunner::RunAllTasksNow() ./../../content/browser/startup_task_runner.cc:44:0
>     #24 0x00000bd875e8 in content::BrowserMainLoop::CreateStartupTasks() ./../../content/browser/browser_main_loop.cc:873:25
>     #25 0x00000bd9b176 in content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&, std::__1::unique_ptr<content::BrowserProcessSubThread, std::__1::default_delete<content::BrowserProcessSubThread> >) ./../../content/browser/browser_main_runner_impl.cc:148:15
>     #26 0x00000bd7c28c in content::BrowserMain(content::MainFunctionParams const&, std::__1::unique_ptr<content::BrowserProcessSubThread, std::__1::default_delete<content::BrowserProcessSubThread> >) ./../../content/browser/browser_main.cc:47:20
>     #27 0x000012ff6795 in content::RunBrowserProcessMain(content::MainFunctionParams const&, content::ContentMainDelegate*, std::__1::unique_ptr<content::BrowserProcessSubThread, std::__1::default_delete<content::BrowserProcessSubThread> >) ./../../content/app/content_main_runner_impl.cc:620:10
>     #28 0x000012ffa9aa in content::ContentMainRunnerImpl::Run() ./../../content/app/content_main_runner_impl.cc:964:12
>     #29 0x00001c607013 in service_manager::Main(service_manager::MainParams const&) ./../../services/service_manager/embedder/main.cc:459:29
>     #30 0x000012ff0d18 in content::ContentMain(content::ContentMainParams const&) ./../../content/app/content_main.cc:19:10
>     #31 0x000014f9c8c0 in content::BrowserTestBase::SetUp() ./../../content/public/test/browser_test_base.cc:323:3
>     #32 0x00001372d0cf in InProcessBrowserTest::SetUp() ./../../chrome/test/base/in_process_browser_test.cc:244:20
>     #33 0x000008b46826 in testing::Test::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0
>     #34 0x000008b4a8bc in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2667:11
>     #35 0x000008b4c34a in testing::TestCase::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2785:28
>     #36 0x000008b82a55 in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5047:43
>     #37 0x000008b81328 in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0
>     #38 0x0000137959f1 in RUN_ALL_TESTS ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:2329:46
>     #39 0x0000137959f1 in base::TestSuite::Run() ./../../base/test/test_suite.cc:275:0
>     #40 0x0000131f45a4 in ChromeTestSuiteRunner::RunTestSuite(int, char**) ./../../chrome/test/base/chrome_test_launcher.cc:65:38
>     #41 0x000015048025 in content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) ./../../content/public/test/test_launcher.cc:625:31
>     #42 0x0000131f5d07 in LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) ./../../chrome/test/base/chrome_test_launcher.cc:170:10
>     #43 0x0000131f4390 in main ./../../chrome/test/base/browser_tests_main_chromeos.cc:21:10
>     #44 0x7f12d1473f45 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287:0
>     #45 0x000000a511ba in _start ??:0:0
> [ RUN      ] ExtensionWebRequestApiTest.WebRequestAuthRequired
> [10186:10186:0529/230253.379633:WARNING:user_session_manager.cc(1091)] Attempting to save user password for non enterprise user.
> ALSA lib confmisc.c:768:(parse_card) cannot find card '0'
> ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_card_driver returned error: No such file or directory
> ALSA lib confmisc.c:392:(snd_func_concat) error evaluating strings
> ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_concat returned error: No such file or directory
> ALSA lib confmisc.c:1251:(snd_func_refer) error evaluating name
> ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory
> ALSA lib conf.c:4727:(snd_config_expand) Evaluate error: No such file or directory
> ALSA lib pcm.c:2239:(snd_pcm_open_noupdate) Unknown PCM default
> [10186:10214:0529/230253.588059:WARNING:alsa_util.cc(24)] PcmOpen: default,No such file or directory
> ALSA lib confmisc.c:768:(parse_card) cannot find card '0'
> ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_card_driver returned error: No such file or directory
> ALSA lib confmisc.c:392:(snd_func_concat) error evaluating strings
> ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_concat returned error: No such file or directory
> ALSA lib confmisc.c:1251:(snd_func_refer) error evaluating name
> ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory
> ALSA lib conf.c:4727:(snd_config_expand) Evaluate error: No such file or directory
> ALSA lib pcm.c:2239:(snd_pcm_open_noupdate) Unknown PCM default
> [10186:10214:0529/230253.589228:WARNING:alsa_util.cc(24)] PcmOpen: plug:default,No such file or directory
> [10186:10186:0529/230258.651324:ERROR:textfield.cc(1754)] Not implemented reached in virtual bool views::Textfield::ShouldDoLearning()
> [10186:10267:0529/230258.790038:WARNING:embedded_test_server.cc(229)] Request not handled. Returning 404: /favicon.ico
> [10186:10186:0529/230259.634483:INFO:CONSOLE(0)] "[SUCCESS] authRequiredNonBlocking", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0)
> [10186:10186:0529/230302.223698:INFO:CONSOLE(0)] "[SUCCESS] authRequiredSyncNoAction", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0)
> [10186:10186:0529/230305.265591:INFO:CONSOLE(0)] "[SUCCESS] authRequiredSyncCancelAuth", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0)
> [10186:10186:0529/230308.238544:INFO:CONSOLE(0)] "[SUCCESS] authRequiredSyncSetAuth", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0)
> [10186:10186:0529/230402.646445:INFO:CONSOLE(0)] "[SUCCESS] authRequiredAsyncNoAction", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0)
> [10186:10186:0529/230525.634213:INFO:CONSOLE(0)] "[SUCCESS] authRequiredAsyncCancelAuth", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0)
> BrowserTestBase received signal: Terminated. Backtrace:
>     #0 0x000000a8dfe1 in __interceptor_backtrace /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/msan/../sanitizer_common/sanitizer_common_interceptors.inc:3980:13
>     #1 0x00001350f30f in base::debug::StackTrace::StackTrace(unsigned long) ./../../base/debug/stack_trace_posix.cc:808:41
>     #2 0x000014f9f062 in content::(anonymous namespace)::DumpStackTraceSignalHandler(int) ./../../content/public/test/browser_test_base.cc:87:5
>     #3 0x000000ab5989 in SignalHandler(int) /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/msan/msan_interceptors.cc:995:3
>     #4 0x7f0a55d86cb0 in killpg ??:?
>     #5 0x7f0a55d86cb0 in ?? ??:0
>     #6 0x000000a6d2d4 in __msan_set_alloca_origin4 /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/msan/msan.cc:558:12
>     #7 0x00001b72c053 in std::__1::enable_if<(__is_forward_iterator<std::__1::__wrap_iter<cc::DrawImage*> >::value) && (is_constructible<cc::DrawImage, std::__1::iterator_traits<std::__1::__wrap_iter<cc::DrawImage*> >::reference>::value), std::__1::__wrap_iter<cc::DrawImage*> >::type std::__1::vector<cc::DrawImage, std::__1::allocator<cc::DrawImage> >::insert<std::__1::__wrap_iter<cc::DrawImage*> >(std::__1::__wrap_iter<cc::DrawImage const*>, std::__1::__wrap_iter<cc::DrawImage*>, std::__1::__wrap_iter<cc::DrawImage*>) ./../../buildtools/third_party/libc++/trunk/include/vector:1959:0
>     #8 0x00001b71d05d in cc::TileManager::ScheduleTasks(cc::TileManager::PrioritizedWorkToSchedule) ./../../cc/tiles/tile_manager.cc:1021:21
>     #9 0x00001b716797 in cc::TileManager::PrepareTiles(cc::GlobalStateThatImpactsTilePriority const&) ./../../cc/tiles/tile_manager.cc:520:3
>     #10 0x00001b4bb195 in cc::LayerTreeHostImpl::PrepareTiles() ./../../cc/trees/layer_tree_host_impl.cc:607:42
>     #11 0x00001b7ebfac in cc::SingleThreadProxy::ScheduledActionPrepareTiles() ./../../cc/trees/single_thread_proxy.cc:834:15
>     #12 0x00001b83107b in cc::Scheduler::ProcessScheduledActions() ./../../cc/scheduler/scheduler.cc:0:20
>     #13 0x00001b82fe9f in cc::Scheduler::OnBeginImplFrameDeadline() ./../../cc/scheduler/scheduler.cc:642:3
>     #14 0x00001322a1d2 in Run ./../../base/callback.h:96:12
>     #15 0x00001322a1d2 in base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) ./../../base/debug/task_annotator.cc:101:0
>     #16 0x0000132ab7a5 in base::MessageLoop::RunTask(base::PendingTask*) ./../../base/message_loop/message_loop.cc:319:25
>     #17 0x0000132adb1b in DeferOrRunPendingTask ./../../base/message_loop/message_loop.cc:329:5
>     #18 0x0000132adb1b in base::MessageLoop::DoDelayedWork(base::TimeTicks*) ./../../base/message_loop/message_loop.cc:413:0
>     #19 0x000013559d67 in base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) ./../../base/message_loop/message_pump_libevent.cc:220:27
>     #20 0x00001336b330 in base::RunLoop::Run() ./../../base/run_loop.cc:102:14
>     #21 0x000015058275 in content::RunThisRunLoop(base::RunLoop*) ./../../content/public/test/test_utils.cc:128:13
>     #22 0x00002b95647d in extensions::ResultCatcher::GetNextResult() ./../../extensions/test/result_catcher.cc:35:5
>     #23 0x000004dfa6f2 in extensions::ExtensionApiTest::RunExtensionTestImpl(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, char const*, int) ./../../chrome/browser/extensions/extension_apitest.cc:392:16
>     #24 0x0000049ace7e in extensions::ExtensionWebRequestApiTest_WebRequestAuthRequired_Test::RunTestOnMainThread() ./../../chrome/browser/extensions/api/web_request/web_request_apitest.cc:445:3
>     #25 0x000014f9e3f2 in content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() ./../../content/public/test/browser_test_base.cc:385:5
>     #26 0x00001387fbe5 in Run ./../../base/callback.h:125:12
>     #27 0x00001387fbe5 in ChromeBrowserMainParts::PreMainMessageLoopRunImpl() ./../../chrome/browser/chrome_browser_main.cc:2098:0
>     #28 0x00001387b5c0 in ChromeBrowserMainParts::PreMainMessageLoopRun() ./../../chrome/browser/chrome_browser_main.cc:1492:18
>     #29 0x000007604b81 in chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() ./../../chrome/browser/chromeos/chrome_browser_main_chromeos.cc:684:32
>     #30 0x00000bd8f78b in content::BrowserMainLoop::PreMainMessageLoopRun() ./../../content/browser/browser_main_loop.cc:962:13
>     #31 0x00000d34ab21 in Run ./../../base/callback.h:125:12
>     #32 0x00000d34ab21 in content::StartupTaskRunner::RunAllTasksNow() ./../../content/browser/startup_task_runner.cc:44:0
>     #33 0x00000bd875e8 in content::BrowserMainLoop::CreateStartupTasks() ./../../content/browser/browser_main_loop.cc:873:25
>     #34 0x00000bd9b176 in content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&, std::__1::unique_ptr<content::BrowserProcessSubThread, std::__1::default_delete<content::BrowserProcessSubThread> >) ./../../content/browser/browser_main_runner_impl.cc:148:15
>     #35 0x00000bd7c28c in content::BrowserMain(content::MainFunctionParams const&, std::__1::unique_ptr<content::BrowserProcessSubThread, std::__1::default_delete<content::BrowserProcessSubThread> >) ./../../content/browser/browser_main.cc:47:20
>     #36 0x000012ff6795 in content::RunBrowserProcessMain(content::MainFunctionParams const&, content::ContentMainDelegate*, std::__1::unique_ptr<content::BrowserProcessSubThread, std::__1::default_delete<content::BrowserProcessSubThread> >) ./../../content/app/content_main_runner_impl.cc:620:10
>     #37 0x000012ffa9aa in content::ContentMainRunnerImpl::Run() ./../../content/app/content_main_runner_impl.cc:964:12
>     #38 0x00001c607013 in service_manager::Main(service_manager::MainParams const&) ./../../services/service_manager/embedder/main.cc:459:29
>     #39 0x000012ff0d18 in content::ContentMain(content::ContentMainParams const&) ./../../content/app/content_main.cc:19:10
>     #40 0x000014f9c8c0 in content::BrowserTestBase::SetUp() ./../../content/public/test/browser_test_base.cc:323:3
>     #41 0x00001372d0cf in InProcessBrowserTest::SetUp() ./../../chrome/test/base/in_process_browser_test.cc:244:20
>     #42 0x000008b46826 in testing::Test::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0
>     #43 0x000008b4a8bc in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2667:11
>     #44 0x000008b4c34a in testing::TestCase::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2785:28
>     #45 0x000008b82a55 in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5047:43
>     #46 0x000008b81328 in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0
>     #47 0x0000137959f1 in RUN_ALL_TESTS ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:2329:46
>     #48 0x0000137959f1 in base::TestSuite::Run() ./../../base/test/test_suite.cc:275:0
>     #49 0x0000131f45a4 in ChromeTestSuiteRunner::RunTestSuite(int, char**) ./../../chrome/test/base/chrome_test_launcher.cc:65:38
>     #50 0x000015048025 in content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) ./../../content/public/test/test_launcher.cc:625:31
>     #51 0x0000131f5d07 in LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) ./../../chrome/test/base/chrome_test_launcher.cc:170:10
>     #52 0x0000131f4390 in main ./../../chrome/test/base/browser_tests_main_chromeos.cc:21:10
>     #53 0x7f0a55d71f45 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287:0
>     #54 0x000000a511ba in _start ??:0:0
> 
> 
> Original change's description:
> > shared worker: Add tests for Chrome extensions.
> > 
> > We didn't have specific test coverage for shared worker from Chrome
> > extensions, just incidental ones via the ExtensionApiTest.Debugger and
> > ExtensionApiTestWithSwitch.ExtensionDebugger.
> > 
> > Shared workers go through a very different loading path than other
> > resources, so it's useful to have tests for them especially
> > including interaction with service workers.
> > 
> > This adds tests that currently fail with NetworkService, a next
> > patch will have a fix.
> > 
> > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
> > Change-Id: Ifa6bb3dec8bdea34c3fbefbaeab324fadcb5c929
> > Bug: 839982
> > Reviewed-on: https://chromium-review.googlesource.com/1074848
> > Commit-Queue: Matt Falkenhagen <falken@chromium.org>
> > Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#562700}
> 
> TBR=falken@chromium.org,lazyboy@chromium.org
> 
> Change-Id: I880c6e859c9414070ad4783dc9e703f4324ecf29
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 839982
> Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
> Reviewed-on: https://chromium-review.googlesource.com/1078367
> Reviewed-by: Thiemo Nagel <tnagel@chromium.org>
> Commit-Queue: Thiemo Nagel <tnagel@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#562766}

TBR=falken@chromium.org,lazyboy@chromium.org,tnagel@chromium.org

Change-Id: I991a94e747d633670cf7fa886c177626d553f690
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 839982
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Reviewed-on: https://chromium-review.googlesource.com/1078387
Reviewed-by: Thiemo Nagel <tnagel@chromium.org>
Commit-Queue: Thiemo Nagel <tnagel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562770}
jkim-julie pushed a commit that referenced this issue Jun 4, 2018
@thiemonagel
Revert "Re-enable WebRequestAuthRequired test."
f4dd430 
This reverts commit 74b9888.

Reason for revert: Flaking on Linux ChromiumOS MSan Tests

https://ci.chromium.org/buildbot/chromium.memory/Linux%20ChromiumOS%20MSan%20Tests/7361
https://ci.chromium.org/buildbot/chromium.memory/Linux%20ChromiumOS%20MSan%20Tests/7363
https://ci.chromium.org/buildbot/chromium.memory/Linux%20ChromiumOS%20MSan%20Tests/7364

[ RUN      ] ExtensionWebRequestApiTest.WebRequestAuthRequired
[14149:14149:0529/223016.256914:WARNING:user_session_manager.cc(1091)] Attempting to save user password for non enterprise user.
ALSA lib confmisc.c:768:(parse_card) cannot find card '0'
ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_card_driver returned error: No such file or directory
ALSA lib confmisc.c:392:(snd_func_concat) error evaluating strings
ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_concat returned error: No such file or directory
ALSA lib confmisc.c:1251:(snd_func_refer) error evaluating name
ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory
ALSA lib conf.c:4727:(snd_config_expand) Evaluate error: No such file or directory
ALSA lib pcm.c:2239:(snd_pcm_open_noupdate) Unknown PCM default
[14149:14299:0529/223016.655436:WARNING:alsa_util.cc(24)] PcmOpen: default,No such file or directory
ALSA lib confmisc.c:768:(parse_card) cannot find card '0'
ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_card_driver returned error: No such file or directory
ALSA lib confmisc.c:392:(snd_func_concat) error evaluating strings
ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_concat returned error: No such file or directory
ALSA lib confmisc.c:1251:(snd_func_refer) error evaluating name
ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory
ALSA lib conf.c:4727:(snd_config_expand) Evaluate error: No such file or directory
ALSA lib pcm.c:2239:(snd_pcm_open_noupdate) Unknown PCM default
[14149:14299:0529/223016.656150:WARNING:alsa_util.cc(24)] PcmOpen: plug:default,No such file or directory
[14149:14149:0529/223023.245267:ERROR:textfield.cc(1754)] Not implemented reached in virtual bool views::Textfield::ShouldDoLearning()
[14149:14372:0529/223023.626405:WARNING:embedded_test_server.cc(229)] Request not handled. Returning 404: /favicon.ico
[14149:14149:0529/223024.849020:INFO:CONSOLE(0)] "[SUCCESS] authRequiredNonBlocking", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0)
[14149:14149:0529/223027.955574:INFO:CONSOLE(0)] "[SUCCESS] authRequiredSyncNoAction", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0)
[14149:14149:0529/223031.378924:INFO:CONSOLE(0)] "[SUCCESS] authRequiredSyncCancelAuth", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0)
[14149:14149:0529/223034.498789:INFO:CONSOLE(0)] "[SUCCESS] authRequiredSyncSetAuth", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0)
[14149:14149:0529/223216.859287:INFO:CONSOLE(0)] "[SUCCESS] authRequiredAsyncNoAction", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0)
BrowserTestBase received signal: Terminated. Backtrace:
    #0 0x000000a8dfe1 in __interceptor_backtrace /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/msan/../sanitizer_common/sanitizer_common_interceptors.inc:3980:13
    #1 0x00001350f30f in base::debug::StackTrace::StackTrace(unsigned long) ./../../base/debug/stack_trace_posix.cc:808:41
    #2 0x000014f9f062 in content::(anonymous namespace)::DumpStackTraceSignalHandler(int) ./../../content/public/test/browser_test_base.cc:87:5
    #3 0x000000ab5989 in SignalHandler(int) /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/msan/msan_interceptors.cc:995:3
    #4 0x7fe3e82dacb0 in killpg ??:?
    #5 0x7fe3e82dacb0 in ?? ??:0
    #6 0x7fe3e83a26d3 in epoll_wait /build/eglibc-ripdx6/eglibc-2.19/misc/../sysdeps/unix/syscall-template.S:81:0
    #7 0x000000a770a4 in __interceptor_epoll_wait /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/msan/msan_interceptors.cc:862:13
    #8 0x00001704b89b in epoll_dispatch ./../../base/third_party/libevent/epoll.c:198:8
    #9 0x00001703ec8b in event_base_loop ./../../base/third_party/libevent/event.c:512:9
    #10 0x00001355a138 in base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) ./../../base/message_loop/message_pump_libevent.cc:247:9
    #11 0x00001336b330 in base::RunLoop::Run() ./../../base/run_loop.cc:102:14
    #12 0x000015058275 in content::RunThisRunLoop(base::RunLoop*) ./../../content/public/test/test_utils.cc:128:13
    #13 0x00002b95647d in extensions::ResultCatcher::GetNextResult() ./../../extensions/test/result_catcher.cc:35:5
    #14 0x000004dfa6f2 in extensions::ExtensionApiTest::RunExtensionTestImpl(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, char const*, int) ./../../chrome/browser/extensions/extension_apitest.cc:392:16
    #15 0x0000049ace7e in extensions::ExtensionWebRequestApiTest_WebRequestAuthRequired_Test::RunTestOnMainThread() ./../../chrome/browser/extensions/api/web_request/web_request_apitest.cc:445:3
    #16 0x000014f9e3f2 in content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() ./../../content/public/test/browser_test_base.cc:385:5
    #17 0x00001387fbe5 in Run ./../../base/callback.h:125:12
    #18 0x00001387fbe5 in ChromeBrowserMainParts::PreMainMessageLoopRunImpl() ./../../chrome/browser/chrome_browser_main.cc:2098:0
    #19 0x00001387b5c0 in ChromeBrowserMainParts::PreMainMessageLoopRun() ./../../chrome/browser/chrome_browser_main.cc:1492:18
    #20 0x000007604b81 in chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() ./../../chrome/browser/chromeos/chrome_browser_main_chromeos.cc:684:32
    #21 0x00000bd8f78b in content::BrowserMainLoop::PreMainMessageLoopRun() ./../../content/browser/browser_main_loop.cc:962:13
    #22 0x00000d34ab21 in Run ./../../base/callback.h:125:12
    #23 0x00000d34ab21 in content::StartupTaskRunner::RunAllTasksNow() ./../../content/browser/startup_task_runner.cc:44:0
    #24 0x00000bd875e8 in content::BrowserMainLoop::CreateStartupTasks() ./../../content/browser/browser_main_loop.cc:873:25
    #25 0x00000bd9b176 in content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&, std::__1::unique_ptr<content::BrowserProcessSubThread, std::__1::default_delete<content::BrowserProcessSubThread> >) ./../../content/browser/browser_main_runner_impl.cc:148:15
    #26 0x00000bd7c28c in content::BrowserMain(content::MainFunctionParams const&, std::__1::unique_ptr<content::BrowserProcessSubThread, std::__1::default_delete<content::BrowserProcessSubThread> >) ./../../content/browser/browser_main.cc:47:20
    #27 0x000012ff6795 in content::RunBrowserProcessMain(content::MainFunctionParams const&, content::ContentMainDelegate*, std::__1::unique_ptr<content::BrowserProcessSubThread, std::__1::default_delete<content::BrowserProcessSubThread> >) ./../../content/app/content_main_runner_impl.cc:620:10
    #28 0x000012ffa9aa in content::ContentMainRunnerImpl::Run() ./../../content/app/content_main_runner_impl.cc:964:12
    #29 0x00001c607013 in service_manager::Main(service_manager::MainParams const&) ./../../services/service_manager/embedder/main.cc:459:29
    #30 0x000012ff0d18 in content::ContentMain(content::ContentMainParams const&) ./../../content/app/content_main.cc:19:10
    #31 0x000014f9c8c0 in content::BrowserTestBase::SetUp() ./../../content/public/test/browser_test_base.cc:323:3
    #32 0x00001372d0cf in InProcessBrowserTest::SetUp() ./../../chrome/test/base/in_process_browser_test.cc:244:20
    #33 0x000008b46826 in testing::Test::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0
    #34 0x000008b4a8bc in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2667:11
    #35 0x000008b4c34a in testing::TestCase::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2785:28
    #36 0x000008b82a55 in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5047:43
    #37 0x000008b81328 in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0
    #38 0x0000137959f1 in RUN_ALL_TESTS ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:2329:46
    #39 0x0000137959f1 in base::TestSuite::Run() ./../../base/test/test_suite.cc:275:0
    #40 0x0000131f45a4 in ChromeTestSuiteRunner::RunTestSuite(int, char**) ./../../chrome/test/base/chrome_test_launcher.cc:65:38
    #41 0x000015048025 in content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) ./../../content/public/test/test_launcher.cc:625:31
    #42 0x0000131f5d07 in LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) ./../../chrome/test/base/chrome_test_launcher.cc:170:10
    #43 0x0000131f4390 in main ./../../chrome/test/base/browser_tests_main_chromeos.cc:21:10
    #44 0x7fe3e82c5f45 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287:0
    #45 0x000000a511ba in _start ??:0:0


Original change's description:
> Re-enable WebRequestAuthRequired test.
> 
> ExtensionWebRequestApiTest.WebRequestAuthRequired has been disabled
> forever. It was originally disabled for flakiness, but neither the
> flaky crashes nor the code which was crashing appear to exist anymore.
> 
> This CL makes some minor updates to the test expectations and re-enables
> the test.
> 
> Bug: 140976,841827
> Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
> Change-Id: I97879b51e600cff684defcbef37fcfbae3dfda62
> Reviewed-on: https://chromium-review.googlesource.com/1076683
> Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
> Commit-Queue: Ken Rockot <rockot@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#562546}

TBR=rockot@chromium.org,karandeepb@chromium.org

Change-Id: I31e6774d763450d791f05397214a355e77419e44
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 140976, 841827
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Reviewed-on: https://chromium-review.googlesource.com/1078487
Reviewed-by: Thiemo Nagel <tnagel@chromium.org>
Commit-Queue: Thiemo Nagel <tnagel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562773}
jkim-julie pushed a commit that referenced this issue Jun 4, 2018
@sebsg
Revert "WebUI[MD-refresh]: Add [type="password"] and ["readonly"] to …
f1503be 
…cr-input"

This reverts commit b829c17.

Reason for revert:
SettingsPasswordSectionBrowserTest.uiTests has been failing consistently since this CL landed.

On Linux and CrOS

Stacktrace:
[28290:28290:0531/210110.220114:ERROR:web_ui_browser_test.cc(478)] JS call assumed failed, because JS console error(s) found.
gen/chrome/test/data/webui/settings/settings_passwords_section_browsertest-gen.cc:41: Failure
Value of: RunJavascriptTestF( true, "SettingsPasswordSectionBrowserTest", "uiTests")
  Actual: false
Expected: true
Stack trace:
#0 0x000003df7e60 StackTraceGetter::CurrentStackTrace()
#1 0x000003e18927 testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop()
#2 0x000003e17d8d testing::internal::AssertHelper::operator=()
#3 0x000002f69fe7 SettingsPasswordSectionBrowserTest_uiTests_Test::RunTestOnMainThread()
#4 0x0000075a5ece content::BrowserTestBase::ProxyRunTestOnMainThreadLoop()
#5 0x0000009a452d _ZN4base8internal13FunctorTraitsIM25RenderViewContextMenuBaseFvvEvE6InvokeIS4_P21RenderViewContextMenuJEEEvT_OT0_DpOT1_
#6 0x0000009a4474 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIM25RenderViewContextMenuBaseFvvEJP21RenderViewContextMenuEEEvOT_DpOT0_
#7 0x0000075a7eb5 _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserTestBaseEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE7RunImplIRKS6_RKNSt3__15tupleIJS8_EEEJLm0EEEEvOT_OT0_NSF_16integer_sequenceImJXspT1_EEEE
#8 0x0000075a7dfc _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserTestBaseEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE3RunEPNS0_13BindStateBaseE
#9 0x0000009966ed _ZNKR4base17RepeatingCallbackIFvvEE3RunEv
#10 0x000006519af7 ChromeBrowserMainParts::PreMainMessageLoopRunImpl()
#11 0x000006517cde ChromeBrowserMainParts::PreMainMessageLoopRun()
#12 0x000003290375 chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun()
#13 0x7fd41048cb4c content::BrowserMainLoop::PreMainMessageLoopRun()
#14 0x7fd40f27ea0d _ZN4base8internal13FunctorTraitsIMN7content12ChildProcessEFvvEvE6InvokeIS5_PS3_JEEEvT_OT0_DpOT1_
#15 0x7fd40f27e954 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIMN7content12ChildProcessEFvvEJPS5_EEEvOT_DpOT0_
#16 0x7fd4104928e5 _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserMainLoopEFivEJNS0_17UnretainedWrapperIS4_EEEEEFivEE7RunImplIRKS6_RKNSt3__15tupleIJS8_EEEJLm0EEEEiOT_OT0_NSF_16integer_sequenceImJXspT1_EEEE
#17 0x7fd41049282c _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserMainLoopEFivEJNS0_17UnretainedWrapperIS4_EEEEEFivEE3RunEPNS0_13BindStateBaseE
#18 0x7fd40f18c70d _ZNKR4base17RepeatingCallbackIFvvEE3RunEv
#19 0x7fd4112d797d content::StartupTaskRunner::RunAllTasksNow()
#20 0x7fd410488230 content::BrowserMainLoop::CreateStartupTasks()
#21 0x7fd410494fc7 content::BrowserMainRunnerImpl::Initialize()
#22 0x7fd410480729 content::BrowserMain()
#23 0x7fd41254804b content::RunBrowserProcessMain()
#24 0x7fd41254a055 content::ContentMainRunnerImpl::Run()
#25 0x7fd41253ed55 content::ContentServiceManagerMainDelegate::RunEmbedderProcess()
#26 0x7fd40b7add1b service_manager::Main()
#27 0x7fd412544ef5 content::ContentMain()
#28 0x0000075a5478 content::BrowserTestBase::SetUp()
#29 0x00000641cabb InProcessBrowserTest::SetUp()
#30 0x00000091fc3e _ZN7testing8internal12InvokeHelperIRKNSt3__16vectorIPN12user_manager4UserENS2_9allocatorIS6_EEEENS2_5tupleIJEEEE12InvokeMethodIN8chromeos15MockUserManagerEMSH_KFSB_vEEESB_PT_T0_RKSD_


Original change's description:
> WebUI[MD-refresh]: Add [type="password"] and ["readonly"] to cr-input
> 
> Bug: 832177
> Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
> Change-Id: If05ffdfc80374c79dec5bbb1422ff44a4489818d
> Reviewed-on: https://chromium-review.googlesource.com/1070861
> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
> Commit-Queue: Scott Chen <scottchen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#563488}

TBR=dpapad@chromium.org,scottchen@chromium.org

Change-Id: I48576bfdebf17815a26e48301ae8463452b3e63f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 832177
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Reviewed-on: https://chromium-review.googlesource.com/1082453
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563605}
@jkim-julie jkim-julie mentioned this issue Jun 21, 2018
Merged
jkim-julie pushed a commit that referenced this issue Jul 16, 2018
@sammiequon71
Reland "overview: Hide title bars before animating into overview mode."
f00acd8 
This is a reland of a663e7f

The original cl causes some flaky tests with stack trace:

[16202:16202:0709/211202.910243:FATAL:single_thread_proxy.cc(237)] Check failed: task_runner_provider_->IsMainThread().
#0 0x7f9b36f8672d base::debug::StackTrace::StackTrace()
#1 0x7f9b36c9d3fc base::debug::StackTrace::StackTrace()
#2 0x7f9b36d06dfd logging::LogMessage::~LogMessage()
#3 0x7f9b2b5692e8 cc::SingleThreadProxy::SetNeedsCommit()
#4 0x7f9b2b45ecef cc::LayerTreeHost::SetNeedsCommit()
#5 0x7f9b2b467426 cc::LayerTreeHost::SetMutatorsNeedCommit()
#6 0x7f9b0fd29981 cc::AnimationHost::SetNeedsCommit()
#7 0x7f9b0fd1962d cc::Animation::SetNeedsCommit()
#8 0x7f9b0fd41151 cc::KeyframeEffect::KeyframeModelAdded()
#9 0x7f9b0fd44e6c cc::KeyframeEffect::AddKeyframeModel()
#10 0x7f9b0fd17fbc cc::Animation::AddKeyframeModelForKeyframeEffect()
#11 0x7f9b0fd71a6d cc::SingleKeyframeEffectAnimation::AddKeyframeModel()
#12 0x7f9b28c83a95 ui::LayerAnimator::AddThreadedAnimation()
#13 0x7f9b28c7498e ui::(anonymous namespace)::ThreadedLayerAnimationElement::RequestEffectiveStart()
#14 0x7f9b28c71113 ui::LayerAnimationElement::Start()
#15 0x7f9b28c7cbe3 ui::LayerAnimationSequence::Start()
#16 0x7f9b28c84287 ui::LayerAnimator::StartSequenceImmediately()
#17 0x7f9b28c81251 ui::LayerAnimator::StartAnimation()
#18 0x7f9b28c80eb6 ui::LayerAnimator::SetTransform()
#19 0x7f9b28c6122e ui::Layer::SetTransform()
#20 0x7f9b28ded831 aura::Window::SetTransform()
#21 0x7f9b22b732df ash::ScopedTransformOverviewWindow::SetTransform()
#22 0x7f9b22b73f69 ash::ScopedTransformOverviewWindow::OnCompositingStarted()
#23 0x7f9b28c4d734 ui::Compositor::DidSubmitCompositorFrame()
#24 0x7f9b2b56cd05 cc::SingleThreadProxy::DoComposite()
#25 0x7f9b2b56e835 cc::SingleThreadProxy::ScheduledActionDrawIfPossible()
#26 0x7f9b2b3736fd cc::Scheduler::DrawIfPossible()
#27 0x7f9b2b36dbdc cc::Scheduler::ProcessScheduledActions()
#28 0x7f9b2b36d5fd cc::Scheduler::OnBeginImplFrameDeadline()

This cl makes that test skip waiting for composit when entering overview, like the tests
in ash.

Original change's description:
> overview: Hide title bars before animating into overview mode.
>
> The title bars should not visible while animating overview mode. This cl
> hides the title bar if needed and waits until the next paint before
> animating the windows. This will hide the title bar as expected while
> keeping the benefits of DeferPaint.
>
> Test: manual
> Bug: 843851
> Change-Id: I99cf7ca39fd1ae14314ac406abd0fec999e2c024
> Reviewed-on: https://chromium-review.googlesource.com/1112774
> Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
> Reviewed-by: Tao Wu <wutao@chromium.org>
> Commit-Queue: Sammie Quon <sammiequon@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#573552}

TBR=oshima@chromium.org

Bug: 843851
Change-Id: I3a538250d5f6d42d6c73e218445080af533b54dc
Reviewed-on: https://chromium-review.googlesource.com/1131874
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574209}
msisov pushed a commit to msisov/chromium that referenced this issue Jul 27, 2018
Revert "Reland "[scheduler] Refactor FrameSchedulerImpl to use FrameT…
b2b4036 
…askQueueController""

This reverts commit fa8e920.

Reason for revert: Broke https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/6992


[ RUN      ] MainThreadSchedulerImplTest.Tracing
Received signal 11 <unknown> 000000000000
#0 0x7fb8aa445edd base::debug::StackTrace::StackTrace()
Igalia#1 0x7fb8aa15949c base::debug::StackTrace::StackTrace()
Igalia#2 0x7fb8aa445968 base::debug::(anonymous namespace)::StackDumpSignalHandler()
Igalia#3 0x7fb89dd8a330 <unknown>
Igalia#4 0x7fb8aa3eb77e logging::CheckEQImpl<>()
Igalia#5 0x7fb8aa3e531c base::trace_event::TracedValue::EndDictionary()
Igalia#6 0x7fb8aaf41afe blink::scheduler::MainThreadSchedulerImpl::AsValueLocked()
Igalia#7 0x7fb8aaf40792 blink::scheduler::MainThreadSchedulerImpl::AsValue()
Igalia#8 0x00000181a3aa blink::scheduler::main_thread_scheduler_impl_unittest::MainThreadSchedulerImplTest_Tracing_Test::TestBody()
Igalia#9 0x000000c4452e testing::internal::HandleSehExceptionsInMethodIfSupported<>()
Igalia#10 0x000000c38192 testing::internal::HandleExceptionsInMethodIfSupported<>()
Igalia#11 0x000000c1bd06 testing::Test::Run()
Igalia#12 0x000000c1c6f0 testing::TestInfo::Run()
Igalia#13 0x000000c1d19f testing::TestCase::Run()
Igalia#14 0x000000c2f348 testing::internal::UnitTestImpl::RunAllTests()
Igalia#15 0x000000c445be testing::internal::HandleSehExceptionsInMethodIfSupported<>()
Igalia#16 0x000000c39942 testing::internal::HandleExceptionsInMethodIfSupported<>()
Igalia#17 0x000000c2efa7 testing::UnitTest::Run()
Igalia#18 0x000001a62ac1 RUN_ALL_TESTS()
Igalia#19 0x000001a5f48b base::TestSuite::Run()
Igalia#20 0x000000bd1d45 (anonymous namespace)::runTestSuite()
Igalia#21 0x000000a3e560 _ZN4base8internal13FunctorTraitsIPFvPbEvE6InvokeIRKS4_JRKS2_EEEvOT_DpOT0_
Igalia#22 0x000000a3e51d _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIPFvPbEJS4_EEEvOT_DpOT0_
Igalia#23 0x000000bd1f75 _ZN4base8internal7InvokerINS0_9BindStateIPFiPNS_9TestSuiteEEJNS0_17UnretainedWrapperIS3_EEEEEFivEE7RunImplIS6_NSt3__15tupleIJS8_EEEJLm0EEEEiOT_OT0_NSD_16integer_sequenceImJXspT1_EEEE
Igalia#24 0x000000bd1ec9 _ZN4base8internal7InvokerINS0_9BindStateIPFiPNS_9TestSuiteEEJNS0_17UnretainedWrapperIS3_EEEEEFivEE7RunOnceEPNS0_13BindStateBaseE
Igalia#25 0x000001a708fe _ZNO4base12OnceCallbackIFivEE3RunEv
Igalia#26 0x000001a697d0 base::(anonymous namespace)::LaunchUnitTestsInternal()
Igalia#27 0x000001a69645 base::LaunchUnitTests()
Igalia#28 0x000000bd1cd6 main
Igalia#29 0x7fb89d4c3f45 __libc_start_main
Igalia#30 0x000000552d1a _start
  r8: 0000000000000001  r9: 00007fff6f9d4b30 r10: 0000000000000000 r11: 0000000000000000
 r12: 0000000000552cf0 r13: 00007fff6f9d6af0 r14: 0000000000000000 r15: 0000000000000000
  di: 00007fb8aa50a878  si: 200031ca83cdc758  bp: 00007fff6f9d4990  bx: 0000000000000000
  dx: 00007fff6f9d4ae8  ax: 00007fb8aa50a800  cx: 0000000000000000  sp: 00007fff6f9d4960
  ip: 00007fb8aa3eb77e efl: 0000000000010246 cgf: 0000000000000033 erf: 0000000000000000
 trp: 000000000000000d msk: 0000000000000000 cr2: 0000000000000000
[end of stack trace]
Calling _exit(1). Core file will not be generated.


Original change's description:
> Reland "[scheduler] Refactor FrameSchedulerImpl to use FrameTaskQueueController"
> 
> This is a reland of e2d8996
> 
> Original change's description:
> > [scheduler] Refactor FrameSchedulerImpl to use FrameTaskQueueController
> >
> > This CL moves all task queue management and creation to
> > FrameTaskQueueController and adds the appropriate interface for
> > accessing queues in FrameTaskQueueController. TaskType to QueueTraits
> > management is handled by FrameSchedulerImpl since it embeds policy, and
> > FrameTaskQueueController exposes an interface to get non-loading task
> > queues by QueueTraits, as well as accessing loading and loading
> > control task queues.
> >
> > Bug: 859963
> > Change-Id: I7db5aaaa148d0dc4f3f70e517e088a205e502db8
> > Reviewed-on: https://chromium-review.googlesource.com/1142390
> > Commit-Queue: Scott Haseley <shaseley@google.com>
> > Reviewed-by: Alexander Timin <altimin@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#576619}
> 
> Bug: 859963
> Change-Id: Id2c9179b580759b815602d61b98c99d1f3f5253d
> Reviewed-on: https://chromium-review.googlesource.com/1144608
> Commit-Queue: Scott Haseley <shaseley@google.com>
> Reviewed-by: Alexander Timin <altimin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#578008}

TBR=altimin@chromium.org,panicker@chromium.org,shaseley@google.com

Change-Id: Ia71d2641655c8100b82a8ce7e4a11009d19b5e9a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 859963
Reviewed-on: https://chromium-review.googlesource.com/1150585
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Commit-Queue: Derek Cheng <imcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578067}
@jkim-julie jkim-julie mentioned this issue Aug 9, 2018
Closed
msisov pushed a commit to msisov/chromium that referenced this issue Aug 16, 2018
Reland "cros: Enable touchable app context menus by default."
e2c5501 
This reverts commit 32cd8fc.

Reason for revert: Reverting the revert because this change was proven to not have caused the issue.

Original change's description:
> Revert "cros: Enable touchable app context menus by default."
> 
> This reverts commit b58ccf6.
> 
> Reason for revert: Possibly introduced a use-after-free bug.
> 
> This is a speculative fix for a use-after-free bug in two ash_unittests:
> 
> 1. OverflowButtonInkDropTest.MouseContextMenu
> 2. OverflowButtonActiveInkDropTest.MouseContextMenu
> 
> [ RUN      ] OverflowButtonInkDropTest.MouseContextMenu
> =================================================================
> ==28149==ERROR: AddressSanitizer: heap-use-after-free on address 0x613000031f68 at pc 0x000008c82106 bp 0x7ffea3cd7190 sp 0x7ffea3cd7188
> READ of size 8 at 0x613000031f68 thread T0
>     #0 0x8c82105 in begin buildtools/third_party/libc++/trunk/include/vector:1479:30
>     Igalia#1 0x8c82105 in begin<std::__1::vector<aura::WindowObserver *, std::__1::allocator<aura::WindowObserver *> > > buildtools/third_party/libc++/trunk/include/iterator:1670
>     Igalia#2 0x8c82105 in ContainsValue<std::__1::vector<aura::WindowObserver *, std::__1::allocator<aura::WindowObserver *> >, const aura::WindowObserver *, 0> base/stl_util.h:168
>     Igalia#3 0x8c82105 in HasObserver base/observer_list.h:267
>     Igalia#4 0x8c82105 in aura::Window::HasObserver(aura::WindowObserver const*) const ui/aura/window.cc:543
>     Igalia#5 0x8c9d363 in aura::WindowObserver::OnUnobservingWindow(aura::Window*) ui/aura/window_observer.cc:25:15
>     Igalia#6 0x8c799d7 in aura::Window::RemoveObserver(aura::WindowObserver*) ui/aura/window.cc:538:13
>     Igalia#7 0xc2f40e in RemoveAll ui/base/window_tracker_template.h:49:15
>     Igalia#8 0xc2f40e in ui::WindowTrackerTemplate<aura::Window, aura::WindowObserver>::~WindowTrackerTemplate() ui/base/window_tracker_template.h:33
>     Igalia#9 0x9225f3b in ~CompoundEventFilter ui/wm/core/compound_event_filter.cc:49:1
>     Igalia#10 0x9225f3b in wm::CompoundEventFilter::~CompoundEventFilter() ui/wm/core/compound_event_filter.cc:45
>     Igalia#11 0x6b0ae30 in operator() buildtools/third_party/libc++/trunk/include/memory:2321:5
>     Igalia#12 0x6b0ae30 in reset buildtools/third_party/libc++/trunk/include/memory:2634
>     Igalia#13 0x6b0ae30 in ~unique_ptr buildtools/third_party/libc++/trunk/include/memory:2588
>     Igalia#14 0x6b0ae30 in ash::Shell::~Shell() ash/shell.cc:969
>     Igalia#15 0x6b0c81d in ash::Shell::~Shell() ash/shell.cc:737:17
>     Igalia#16 0xc26b344 in ash::AshTestHelper::TearDown() ash/test/ash_test_helper.cc:294:3
>     Igalia#17 0xc26444c in ash::AshTestBase::TearDown() ash/test/ash_test_base.cc:192:21
>     Igalia#18 0x4724c64 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2682:11
>     Igalia#19 0x4726036 in testing::TestCase::Run() third_party/googletest/src/googletest/src/gtest.cc:2800:28
>     Igalia#20 0x474b566 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5124:43
>     Igalia#21 0x474a7b5 in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc
>     Igalia#22 0x72b431a in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2331:46
>     Igalia#23 0x72b431a in base::TestSuite::Run() base/test/test_suite.cc:277
>     Igalia#24 0x72b9892 in Run base/callback.h:99:12
>     Igalia#25 0x72b9892 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) base/test/launcher/unit_test_launcher.cc:224
>     Igalia#26 0x72b9330 in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) base/test/launcher/unit_test_launcher.cc:575:10
>     Igalia#27 0x178df94 in main ash/test/ash_unittests.cc:37:10
>     Igalia#28 0x7f78e2b62f44 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287
> 
> 0x613000031f68 is located 296 bytes inside of 328-byte region [0x613000031e40,0x613000031f88)
> freed by thread T0 here:
>     #0 0x6b9062 in operator delete(void*) /b/swarming/w/ir/kitchen-workdir/src/third_party/llvm/compiler-rt/lib/asan/asan_new_delete.cc:167:3
>     Igalia#1 0x6a547a0 in ash::RootWindowController::CloseChildWindows() ash/root_window_controller.cc:498:7
>     Igalia#2 0x6b0c5cf in ash::Shell::CloseAllRootWindowChildWindows() ash/shell.cc:1387:19
>     Igalia#3 0x6b06637 in ash::Shell::~Shell() ash/shell.cc:837:3
>     Igalia#4 0x6b0c81d in ash::Shell::~Shell() ash/shell.cc:737:17
>     Igalia#5 0xc26b344 in ash::AshTestHelper::TearDown() ash/test/ash_test_helper.cc:294:3
>     Igalia#6 0xc26444c in ash::AshTestBase::TearDown() ash/test/ash_test_base.cc:192:21
>     Igalia#7 0x4724c64 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2682:11
>     Igalia#8 0x4726036 in testing::TestCase::Run() third_party/googletest/src/googletest/src/gtest.cc:2800:28
>     Igalia#9 0x474b566 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5124:43
>     Igalia#10 0x474a7b5 in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc
>     Igalia#11 0x72b431a in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2331:46
>     Igalia#12 0x72b431a in base::TestSuite::Run() base/test/test_suite.cc:277
>     Igalia#13 0x72b9892 in Run base/callback.h:99:12
>     Igalia#14 0x72b9892 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) base/test/launcher/unit_test_launcher.cc:224
>     Igalia#15 0x72b9330 in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) base/test/launcher/unit_test_launcher.cc:575:10
>     Igalia#16 0x178df94 in main ash/test/ash_unittests.cc:37:10
>     Igalia#17 0x7f78e2b62f44 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287
> 
> previously allocated by thread T0 here:
>     #0 0x6b8422 in operator new(unsigned long) /b/swarming/w/ir/kitchen-workdir/src/third_party/llvm/compiler-rt/lib/asan/asan_new_delete.cc:106:3
>     Igalia#1 0x91cb856 in views::NativeWidgetAura::NativeWidgetAura(views::internal::NativeWidgetDelegate*, bool, aura::Env*) ui/views/widget/native_widget_aura.cc:109:15
>     Igalia#2 0x91d615d in views::internal::NativeWidgetPrivate::CreateNativeWidget(views::Widget::InitParams const&, views::internal::NativeWidgetDelegate*) ui/views/widget/native_widget_aura.cc:1113:14
>     Igalia#3 0x917dabd in CreateNativeWidget ui/views/widget/widget.cc:73:10
>     Igalia#4 0x917dabd in views::Widget::Init(views::Widget::InitParams const&) ui/views/widget/widget.cc:334
>     Igalia#5 0x6af249a in ash::ShelfWidget::ShelfWidget(aura::Window*, ash::Shelf*) ash/shelf/shelf_widget.cc:216:3
>     Igalia#6 0x6a96eaa in ash::Shelf::CreateShelfWidget(aura::Window*) ash/shelf/shelf.cc:73:27
>     Igalia#7 0x6a5847a in ash::RootWindowController::InitLayoutManagers() ash/root_window_controller.cc:699:11
>     Igalia#8 0x6a52166 in ash::RootWindowController::Init(ash::RootWindowController::RootWindowType) ash/root_window_controller.cc:663:3
>     Igalia#9 0x68ef135 in ash::WindowTreeHostManager::InitHosts() ash/display/window_tree_host_manager.cc:238:3
>     Igalia#10 0x6afadce in ash::Shell::Init(ui::ContextFactory*, ui::ContextFactoryPrivate*, std::__1::unique_ptr<base::Value, std::__1::default_delete<base::Value> >, std::__1::unique_ptr<ui::ws2::GpuInterfaceProvider, std::__1::default_delete<ui::ws2::GpuInterfaceProvider> >) ash/shell.cc:1250:30
>     Igalia#11 0x6af7163 in ash::Shell::CreateInstance(ash::ShellInitParams) ash/shell.cc:276:14
>     Igalia#12 0xc26ac31 in ash::AshTestHelper::CreateShell() ash/test/ash_test_helper.cc:390:3
>     Igalia#13 0xc26a2a0 in ash::AshTestHelper::SetUp(bool, bool) ash/test/ash_test_helper.cc:245:3
>     Igalia#14 0xc263f8d in ash::AshTestBase::SetUp() ash/test/ash_test_base.cc:159:21
>     Igalia#15 0x1322b16 in ash::ShelfViewTest::SetUp() ash/shelf/shelf_view_unittest.cc:262:18
>     Igalia#16 0x1326366 in SetUp ash/shelf/shelf_view_unittest.cc:2369:20
>     Igalia#17 0x1326366 in ash::OverflowButtonInkDropTest::SetUp() ash/shelf/shelf_view_unittest.cc:2778
>     Igalia#18 0x4722b42 in testing::Test::Run() third_party/googletest/src/googletest/src/gtest.cc
>     Igalia#19 0x4724c64 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2682:11
>     Igalia#20 0x4726036 in testing::TestCase::Run() third_party/googletest/src/googletest/src/gtest.cc:2800:28
>     Igalia#21 0x474b566 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5124:43
>     Igalia#22 0x474a7b5 in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc
>     Igalia#23 0x72b431a in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2331:46
>     Igalia#24 0x72b431a in base::TestSuite::Run() base/test/test_suite.cc:277
>     Igalia#25 0x72b9892 in Run base/callback.h:99:12
>     Igalia#26 0x72b9892 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) base/test/launcher/unit_test_launcher.cc:224
>     Igalia#27 0x72b9330 in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) base/test/launcher/unit_test_launcher.cc:575:10
>     Igalia#28 0x178df94 in main ash/test/ash_unittests.cc:37:10
>     Igalia#29 0x7f78e2b62f44 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287
> 
> SUMMARY: AddressSanitizer: heap-use-after-free buildtools/third_party/libc++/trunk/include/vector:1479:30 in begin
> Shadow bytes around the buggy address:
>   0x0c267fffe390: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
>   0x0c267fffe3a0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
>   0x0c267fffe3b0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 fa
>   0x0c267fffe3c0: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
>   0x0c267fffe3d0: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd
> =>0x0c267fffe3e0: fd fd fd fd fd fd fd fd fd fd fd fd fd[fd]fd fd
>   0x0c267fffe3f0: fd fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
>   0x0c267fffe400: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd
>   0x0c267fffe410: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd
>   0x0c267fffe420: fd fd fd fd fd fd fd fd fd fd fd fd fa fa fa fa
>   0x0c267fffe430: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
> Shadow byte legend (one shadow byte represents 8 application bytes):
>   Addressable:           00
>   Partially addressable: 01 02 03 04 05 06 07 
>   Heap left redzone:       fa
>   Freed heap region:       fd
>   Stack left redzone:      f1
>   Stack mid redzone:       f2
>   Stack right redzone:     f3
>   Stack after return:      f5
>   Stack use after scope:   f8
>   Global redzone:          f9
>   Global init order:       f6
>   Poisoned by user:        f7
>   Container overflow:      fc
>   Array cookie:            ac
>   Intra object redzone:    bb
>   ASan internal:           fe
>   Left alloca redzone:     ca
>   Right alloca redzone:    cb
>   Shadow gap:              cc
> ==28149==ABORTING
> 
> Original change's description:
> > cros: Enable touchable app context menus by default.
> > 
> > This will enable:
> >  - New context menu UI for:
> >   - Application icons
> >   - Shelf context menus
> >   - Desktop context menus
> > 
> > Note:
> >  - Removed tests whose functionality were already being tested.
> >    - MouseContextMenu already tests whether the ink drop is being
> >      shown, so there is no need for
> >      ShelfButtonShowsInkDropHighlightOnMenuShow.
> > 
> > Bug: 871843
> > Change-Id: I4c92ae52f75b25bc9edd1dd67778c4785d8f4058
> > Reviewed-on: https://chromium-review.googlesource.com/1170985
> > Reviewed-by: Scott Violet <sky@chromium.org>
> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> > Commit-Queue: Alex Newcomer <newcomer@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#582978}
> 
> TBR=xiyuan@chromium.org,sky@chromium.org,newcomer@chromium.org
> 
> Change-Id: Ib85676861251f41c84f48f956d36c01edb353266
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 871843
> Reviewed-on: https://chromium-review.googlesource.com/1174641
> Reviewed-by: Chris Mumford <cmumford@chromium.org>
> Commit-Queue: Chris Mumford <cmumford@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#583088}

TBR=xiyuan@chromium.org,sky@chromium.org,cmumford@chromium.org,newcomer@chromium.org

Change-Id: I4edeef479d40e1e591ac906aa89ede363668b6a3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 871843
Reviewed-on: https://chromium-review.googlesource.com/1174777
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583310}
jkim-julie pushed a commit to jkim-julie/chromium that referenced this issue Aug 20, 2018
@cmumford
Revert "cros: Enable touchable app context menus by default."
32cd8fc 
This reverts commit b58ccf6.

Reason for revert: Possibly introduced a use-after-free bug.

This is a speculative fix for a use-after-free bug in two ash_unittests:

1. OverflowButtonInkDropTest.MouseContextMenu
2. OverflowButtonActiveInkDropTest.MouseContextMenu

[ RUN      ] OverflowButtonInkDropTest.MouseContextMenu
=================================================================
==28149==ERROR: AddressSanitizer: heap-use-after-free on address 0x613000031f68 at pc 0x000008c82106 bp 0x7ffea3cd7190 sp 0x7ffea3cd7188
READ of size 8 at 0x613000031f68 thread T0
    #0 0x8c82105 in begin buildtools/third_party/libc++/trunk/include/vector:1479:30
    Igalia#1 0x8c82105 in begin<std::__1::vector<aura::WindowObserver *, std::__1::allocator<aura::WindowObserver *> > > buildtools/third_party/libc++/trunk/include/iterator:1670
    Igalia#2 0x8c82105 in ContainsValue<std::__1::vector<aura::WindowObserver *, std::__1::allocator<aura::WindowObserver *> >, const aura::WindowObserver *, 0> base/stl_util.h:168
    Igalia#3 0x8c82105 in HasObserver base/observer_list.h:267
    Igalia#4 0x8c82105 in aura::Window::HasObserver(aura::WindowObserver const*) const ui/aura/window.cc:543
    Igalia#5 0x8c9d363 in aura::WindowObserver::OnUnobservingWindow(aura::Window*) ui/aura/window_observer.cc:25:15
    Igalia#6 0x8c799d7 in aura::Window::RemoveObserver(aura::WindowObserver*) ui/aura/window.cc:538:13
    Igalia#7 0xc2f40e in RemoveAll ui/base/window_tracker_template.h:49:15
    Igalia#8 0xc2f40e in ui::WindowTrackerTemplate<aura::Window, aura::WindowObserver>::~WindowTrackerTemplate() ui/base/window_tracker_template.h:33
    Igalia#9 0x9225f3b in ~CompoundEventFilter ui/wm/core/compound_event_filter.cc:49:1
    Igalia#10 0x9225f3b in wm::CompoundEventFilter::~CompoundEventFilter() ui/wm/core/compound_event_filter.cc:45
    Igalia#11 0x6b0ae30 in operator() buildtools/third_party/libc++/trunk/include/memory:2321:5
    Igalia#12 0x6b0ae30 in reset buildtools/third_party/libc++/trunk/include/memory:2634
    Igalia#13 0x6b0ae30 in ~unique_ptr buildtools/third_party/libc++/trunk/include/memory:2588
    Igalia#14 0x6b0ae30 in ash::Shell::~Shell() ash/shell.cc:969
    Igalia#15 0x6b0c81d in ash::Shell::~Shell() ash/shell.cc:737:17
    Igalia#16 0xc26b344 in ash::AshTestHelper::TearDown() ash/test/ash_test_helper.cc:294:3
    Igalia#17 0xc26444c in ash::AshTestBase::TearDown() ash/test/ash_test_base.cc:192:21
    Igalia#18 0x4724c64 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2682:11
    Igalia#19 0x4726036 in testing::TestCase::Run() third_party/googletest/src/googletest/src/gtest.cc:2800:28
    Igalia#20 0x474b566 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5124:43
    Igalia#21 0x474a7b5 in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc
    Igalia#22 0x72b431a in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2331:46
    Igalia#23 0x72b431a in base::TestSuite::Run() base/test/test_suite.cc:277
    Igalia#24 0x72b9892 in Run base/callback.h:99:12
    Igalia#25 0x72b9892 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) base/test/launcher/unit_test_launcher.cc:224
    Igalia#26 0x72b9330 in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) base/test/launcher/unit_test_launcher.cc:575:10
    Igalia#27 0x178df94 in main ash/test/ash_unittests.cc:37:10
    Igalia#28 0x7f78e2b62f44 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287

0x613000031f68 is located 296 bytes inside of 328-byte region [0x613000031e40,0x613000031f88)
freed by thread T0 here:
    #0 0x6b9062 in operator delete(void*) /b/swarming/w/ir/kitchen-workdir/src/third_party/llvm/compiler-rt/lib/asan/asan_new_delete.cc:167:3
    Igalia#1 0x6a547a0 in ash::RootWindowController::CloseChildWindows() ash/root_window_controller.cc:498:7
    Igalia#2 0x6b0c5cf in ash::Shell::CloseAllRootWindowChildWindows() ash/shell.cc:1387:19
    Igalia#3 0x6b06637 in ash::Shell::~Shell() ash/shell.cc:837:3
    Igalia#4 0x6b0c81d in ash::Shell::~Shell() ash/shell.cc:737:17
    Igalia#5 0xc26b344 in ash::AshTestHelper::TearDown() ash/test/ash_test_helper.cc:294:3
    Igalia#6 0xc26444c in ash::AshTestBase::TearDown() ash/test/ash_test_base.cc:192:21
    Igalia#7 0x4724c64 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2682:11
    Igalia#8 0x4726036 in testing::TestCase::Run() third_party/googletest/src/googletest/src/gtest.cc:2800:28
    Igalia#9 0x474b566 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5124:43
    Igalia#10 0x474a7b5 in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc
    Igalia#11 0x72b431a in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2331:46
    Igalia#12 0x72b431a in base::TestSuite::Run() base/test/test_suite.cc:277
    Igalia#13 0x72b9892 in Run base/callback.h:99:12
    Igalia#14 0x72b9892 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) base/test/launcher/unit_test_launcher.cc:224
    Igalia#15 0x72b9330 in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) base/test/launcher/unit_test_launcher.cc:575:10
    Igalia#16 0x178df94 in main ash/test/ash_unittests.cc:37:10
    Igalia#17 0x7f78e2b62f44 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287

previously allocated by thread T0 here:
    #0 0x6b8422 in operator new(unsigned long) /b/swarming/w/ir/kitchen-workdir/src/third_party/llvm/compiler-rt/lib/asan/asan_new_delete.cc:106:3
    Igalia#1 0x91cb856 in views::NativeWidgetAura::NativeWidgetAura(views::internal::NativeWidgetDelegate*, bool, aura::Env*) ui/views/widget/native_widget_aura.cc:109:15
    Igalia#2 0x91d615d in views::internal::NativeWidgetPrivate::CreateNativeWidget(views::Widget::InitParams const&, views::internal::NativeWidgetDelegate*) ui/views/widget/native_widget_aura.cc:1113:14
    Igalia#3 0x917dabd in CreateNativeWidget ui/views/widget/widget.cc:73:10
    Igalia#4 0x917dabd in views::Widget::Init(views::Widget::InitParams const&) ui/views/widget/widget.cc:334
    Igalia#5 0x6af249a in ash::ShelfWidget::ShelfWidget(aura::Window*, ash::Shelf*) ash/shelf/shelf_widget.cc:216:3
    Igalia#6 0x6a96eaa in ash::Shelf::CreateShelfWidget(aura::Window*) ash/shelf/shelf.cc:73:27
    Igalia#7 0x6a5847a in ash::RootWindowController::InitLayoutManagers() ash/root_window_controller.cc:699:11
    Igalia#8 0x6a52166 in ash::RootWindowController::Init(ash::RootWindowController::RootWindowType) ash/root_window_controller.cc:663:3
    Igalia#9 0x68ef135 in ash::WindowTreeHostManager::InitHosts() ash/display/window_tree_host_manager.cc:238:3
    Igalia#10 0x6afadce in ash::Shell::Init(ui::ContextFactory*, ui::ContextFactoryPrivate*, std::__1::unique_ptr<base::Value, std::__1::default_delete<base::Value> >, std::__1::unique_ptr<ui::ws2::GpuInterfaceProvider, std::__1::default_delete<ui::ws2::GpuInterfaceProvider> >) ash/shell.cc:1250:30
    Igalia#11 0x6af7163 in ash::Shell::CreateInstance(ash::ShellInitParams) ash/shell.cc:276:14
    Igalia#12 0xc26ac31 in ash::AshTestHelper::CreateShell() ash/test/ash_test_helper.cc:390:3
    Igalia#13 0xc26a2a0 in ash::AshTestHelper::SetUp(bool, bool) ash/test/ash_test_helper.cc:245:3
    Igalia#14 0xc263f8d in ash::AshTestBase::SetUp() ash/test/ash_test_base.cc:159:21
    Igalia#15 0x1322b16 in ash::ShelfViewTest::SetUp() ash/shelf/shelf_view_unittest.cc:262:18
    Igalia#16 0x1326366 in SetUp ash/shelf/shelf_view_unittest.cc:2369:20
    Igalia#17 0x1326366 in ash::OverflowButtonInkDropTest::SetUp() ash/shelf/shelf_view_unittest.cc:2778
    Igalia#18 0x4722b42 in testing::Test::Run() third_party/googletest/src/googletest/src/gtest.cc
    Igalia#19 0x4724c64 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2682:11
    Igalia#20 0x4726036 in testing::TestCase::Run() third_party/googletest/src/googletest/src/gtest.cc:2800:28
    Igalia#21 0x474b566 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5124:43
    Igalia#22 0x474a7b5 in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc
    Igalia#23 0x72b431a in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2331:46
    Igalia#24 0x72b431a in base::TestSuite::Run() base/test/test_suite.cc:277
    Igalia#25 0x72b9892 in Run base/callback.h:99:12
    Igalia#26 0x72b9892 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) base/test/launcher/unit_test_launcher.cc:224
    Igalia#27 0x72b9330 in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) base/test/launcher/unit_test_launcher.cc:575:10
    Igalia#28 0x178df94 in main ash/test/ash_unittests.cc:37:10
    Igalia#29 0x7f78e2b62f44 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287

SUMMARY: AddressSanitizer: heap-use-after-free buildtools/third_party/libc++/trunk/include/vector:1479:30 in begin
Shadow bytes around the buggy address:
  0x0c267fffe390: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x0c267fffe3a0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x0c267fffe3b0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 fa
  0x0c267fffe3c0: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
  0x0c267fffe3d0: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd
=>0x0c267fffe3e0: fd fd fd fd fd fd fd fd fd fd fd fd fd[fd]fd fd
  0x0c267fffe3f0: fd fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0c267fffe400: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd
  0x0c267fffe410: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd
  0x0c267fffe420: fd fd fd fd fd fd fd fd fd fd fd fd fa fa fa fa
  0x0c267fffe430: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
Shadow byte legend (one shadow byte represents 8 application bytes):
  Addressable:           00
  Partially addressable: 01 02 03 04 05 06 07 
  Heap left redzone:       fa
  Freed heap region:       fd
  Stack left redzone:      f1
  Stack mid redzone:       f2
  Stack right redzone:     f3
  Stack after return:      f5
  Stack use after scope:   f8
  Global redzone:          f9
  Global init order:       f6
  Poisoned by user:        f7
  Container overflow:      fc
  Array cookie:            ac
  Intra object redzone:    bb
  ASan internal:           fe
  Left alloca redzone:     ca
  Right alloca redzone:    cb
  Shadow gap:              cc
==28149==ABORTING

Original change's description:
> cros: Enable touchable app context menus by default.
> 
> This will enable:
>  - New context menu UI for:
>   - Application icons
>   - Shelf context menus
>   - Desktop context menus
> 
> Note:
>  - Removed tests whose functionality were already being tested.
>    - MouseContextMenu already tests whether the ink drop is being
>      shown, so there is no need for
>      ShelfButtonShowsInkDropHighlightOnMenuShow.
> 
> Bug: 871843
> Change-Id: I4c92ae52f75b25bc9edd1dd67778c4785d8f4058
> Reviewed-on: https://chromium-review.googlesource.com/1170985
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Commit-Queue: Alex Newcomer <newcomer@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#582978}

TBR=xiyuan@chromium.org,sky@chromium.org,newcomer@chromium.org

Change-Id: Ib85676861251f41c84f48f956d36c01edb353266
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 871843
Reviewed-on: https://chromium-review.googlesource.com/1174641
Reviewed-by: Chris Mumford <cmumford@chromium.org>
Commit-Queue: Chris Mumford <cmumford@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583088}
jkim-julie pushed a commit to jkim-julie/chromium that referenced this issue Aug 20, 2018
@mstensho
Revert "Reland "cros: Enable touchable app context menus by default.""
e44d17b 
This reverts commit e2c5501.

Reason for revert: Causes ash_unittests regressions. This is NOT
a speculative revert, as I've bisected to this commit and reproduced
it locally. Please do not reland as is.
Failing build: 
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/28629

Original change's description:
> Reland "cros: Enable touchable app context menus by default."
> 
> This reverts commit 32cd8fc.
> 
> Reason for revert: Reverting the revert because this change was proven to not have caused the issue.
> 
> Original change's description:
> > Revert "cros: Enable touchable app context menus by default."
> > 
> > This reverts commit b58ccf6.
> > 
> > Reason for revert: Possibly introduced a use-after-free bug.
> > 
> > This is a speculative fix for a use-after-free bug in two ash_unittests:
> > 
> > 1. OverflowButtonInkDropTest.MouseContextMenu
> > 2. OverflowButtonActiveInkDropTest.MouseContextMenu
> > 
> > [ RUN      ] OverflowButtonInkDropTest.MouseContextMenu
> > =================================================================
> > ==28149==ERROR: AddressSanitizer: heap-use-after-free on address 0x613000031f68 at pc 0x000008c82106 bp 0x7ffea3cd7190 sp 0x7ffea3cd7188
> > READ of size 8 at 0x613000031f68 thread T0
> >     #0 0x8c82105 in begin buildtools/third_party/libc++/trunk/include/vector:1479:30
> >     Igalia#1 0x8c82105 in begin<std::__1::vector<aura::WindowObserver *, std::__1::allocator<aura::WindowObserver *> > > buildtools/third_party/libc++/trunk/include/iterator:1670
> >     Igalia#2 0x8c82105 in ContainsValue<std::__1::vector<aura::WindowObserver *, std::__1::allocator<aura::WindowObserver *> >, const aura::WindowObserver *, 0> base/stl_util.h:168
> >     Igalia#3 0x8c82105 in HasObserver base/observer_list.h:267
> >     Igalia#4 0x8c82105 in aura::Window::HasObserver(aura::WindowObserver const*) const ui/aura/window.cc:543
> >     Igalia#5 0x8c9d363 in aura::WindowObserver::OnUnobservingWindow(aura::Window*) ui/aura/window_observer.cc:25:15
> >     Igalia#6 0x8c799d7 in aura::Window::RemoveObserver(aura::WindowObserver*) ui/aura/window.cc:538:13
> >     Igalia#7 0xc2f40e in RemoveAll ui/base/window_tracker_template.h:49:15
> >     Igalia#8 0xc2f40e in ui::WindowTrackerTemplate<aura::Window, aura::WindowObserver>::~WindowTrackerTemplate() ui/base/window_tracker_template.h:33
> >     Igalia#9 0x9225f3b in ~CompoundEventFilter ui/wm/core/compound_event_filter.cc:49:1
> >     Igalia#10 0x9225f3b in wm::CompoundEventFilter::~CompoundEventFilter() ui/wm/core/compound_event_filter.cc:45
> >     Igalia#11 0x6b0ae30 in operator() buildtools/third_party/libc++/trunk/include/memory:2321:5
> >     Igalia#12 0x6b0ae30 in reset buildtools/third_party/libc++/trunk/include/memory:2634
> >     Igalia#13 0x6b0ae30 in ~unique_ptr buildtools/third_party/libc++/trunk/include/memory:2588
> >     Igalia#14 0x6b0ae30 in ash::Shell::~Shell() ash/shell.cc:969
> >     Igalia#15 0x6b0c81d in ash::Shell::~Shell() ash/shell.cc:737:17
> >     Igalia#16 0xc26b344 in ash::AshTestHelper::TearDown() ash/test/ash_test_helper.cc:294:3
> >     Igalia#17 0xc26444c in ash::AshTestBase::TearDown() ash/test/ash_test_base.cc:192:21
> >     Igalia#18 0x4724c64 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2682:11
> >     Igalia#19 0x4726036 in testing::TestCase::Run() third_party/googletest/src/googletest/src/gtest.cc:2800:28
> >     Igalia#20 0x474b566 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5124:43
> >     Igalia#21 0x474a7b5 in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc
> >     Igalia#22 0x72b431a in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2331:46
> >     Igalia#23 0x72b431a in base::TestSuite::Run() base/test/test_suite.cc:277
> >     Igalia#24 0x72b9892 in Run base/callback.h:99:12
> >     Igalia#25 0x72b9892 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) base/test/launcher/unit_test_launcher.cc:224
> >     Igalia#26 0x72b9330 in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) base/test/launcher/unit_test_launcher.cc:575:10
> >     Igalia#27 0x178df94 in main ash/test/ash_unittests.cc:37:10
> >     Igalia#28 0x7f78e2b62f44 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287
> > 
> > 0x613000031f68 is located 296 bytes inside of 328-byte region [0x613000031e40,0x613000031f88)
> > freed by thread T0 here:
> >     #0 0x6b9062 in operator delete(void*) /b/swarming/w/ir/kitchen-workdir/src/third_party/llvm/compiler-rt/lib/asan/asan_new_delete.cc:167:3
> >     Igalia#1 0x6a547a0 in ash::RootWindowController::CloseChildWindows() ash/root_window_controller.cc:498:7
> >     Igalia#2 0x6b0c5cf in ash::Shell::CloseAllRootWindowChildWindows() ash/shell.cc:1387:19
> >     Igalia#3 0x6b06637 in ash::Shell::~Shell() ash/shell.cc:837:3
> >     Igalia#4 0x6b0c81d in ash::Shell::~Shell() ash/shell.cc:737:17
> >     Igalia#5 0xc26b344 in ash::AshTestHelper::TearDown() ash/test/ash_test_helper.cc:294:3
> >     Igalia#6 0xc26444c in ash::AshTestBase::TearDown() ash/test/ash_test_base.cc:192:21
> >     Igalia#7 0x4724c64 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2682:11
> >     Igalia#8 0x4726036 in testing::TestCase::Run() third_party/googletest/src/googletest/src/gtest.cc:2800:28
> >     Igalia#9 0x474b566 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5124:43
> >     Igalia#10 0x474a7b5 in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc
> >     Igalia#11 0x72b431a in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2331:46
> >     Igalia#12 0x72b431a in base::TestSuite::Run() base/test/test_suite.cc:277
> >     Igalia#13 0x72b9892 in Run base/callback.h:99:12
> >     Igalia#14 0x72b9892 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) base/test/launcher/unit_test_launcher.cc:224
> >     Igalia#15 0x72b9330 in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) base/test/launcher/unit_test_launcher.cc:575:10
> >     Igalia#16 0x178df94 in main ash/test/ash_unittests.cc:37:10
> >     Igalia#17 0x7f78e2b62f44 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287
> > 
> > previously allocated by thread T0 here:
> >     #0 0x6b8422 in operator new(unsigned long) /b/swarming/w/ir/kitchen-workdir/src/third_party/llvm/compiler-rt/lib/asan/asan_new_delete.cc:106:3
> >     Igalia#1 0x91cb856 in views::NativeWidgetAura::NativeWidgetAura(views::internal::NativeWidgetDelegate*, bool, aura::Env*) ui/views/widget/native_widget_aura.cc:109:15
> >     Igalia#2 0x91d615d in views::internal::NativeWidgetPrivate::CreateNativeWidget(views::Widget::InitParams const&, views::internal::NativeWidgetDelegate*) ui/views/widget/native_widget_aura.cc:1113:14
> >     Igalia#3 0x917dabd in CreateNativeWidget ui/views/widget/widget.cc:73:10
> >     Igalia#4 0x917dabd in views::Widget::Init(views::Widget::InitParams const&) ui/views/widget/widget.cc:334
> >     Igalia#5 0x6af249a in ash::ShelfWidget::ShelfWidget(aura::Window*, ash::Shelf*) ash/shelf/shelf_widget.cc:216:3
> >     Igalia#6 0x6a96eaa in ash::Shelf::CreateShelfWidget(aura::Window*) ash/shelf/shelf.cc:73:27
> >     Igalia#7 0x6a5847a in ash::RootWindowController::InitLayoutManagers() ash/root_window_controller.cc:699:11
> >     Igalia#8 0x6a52166 in ash::RootWindowController::Init(ash::RootWindowController::RootWindowType) ash/root_window_controller.cc:663:3
> >     Igalia#9 0x68ef135 in ash::WindowTreeHostManager::InitHosts() ash/display/window_tree_host_manager.cc:238:3
> >     Igalia#10 0x6afadce in ash::Shell::Init(ui::ContextFactory*, ui::ContextFactoryPrivate*, std::__1::unique_ptr<base::Value, std::__1::default_delete<base::Value> >, std::__1::unique_ptr<ui::ws2::GpuInterfaceProvider, std::__1::default_delete<ui::ws2::GpuInterfaceProvider> >) ash/shell.cc:1250:30
> >     Igalia#11 0x6af7163 in ash::Shell::CreateInstance(ash::ShellInitParams) ash/shell.cc:276:14
> >     Igalia#12 0xc26ac31 in ash::AshTestHelper::CreateShell() ash/test/ash_test_helper.cc:390:3
> >     Igalia#13 0xc26a2a0 in ash::AshTestHelper::SetUp(bool, bool) ash/test/ash_test_helper.cc:245:3
> >     Igalia#14 0xc263f8d in ash::AshTestBase::SetUp() ash/test/ash_test_base.cc:159:21
> >     Igalia#15 0x1322b16 in ash::ShelfViewTest::SetUp() ash/shelf/shelf_view_unittest.cc:262:18
> >     Igalia#16 0x1326366 in SetUp ash/shelf/shelf_view_unittest.cc:2369:20
> >     Igalia#17 0x1326366 in ash::OverflowButtonInkDropTest::SetUp() ash/shelf/shelf_view_unittest.cc:2778
> >     Igalia#18 0x4722b42 in testing::Test::Run() third_party/googletest/src/googletest/src/gtest.cc
> >     Igalia#19 0x4724c64 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2682:11
> >     Igalia#20 0x4726036 in testing::TestCase::Run() third_party/googletest/src/googletest/src/gtest.cc:2800:28
> >     Igalia#21 0x474b566 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5124:43
> >     Igalia#22 0x474a7b5 in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc
> >     Igalia#23 0x72b431a in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2331:46
> >     Igalia#24 0x72b431a in base::TestSuite::Run() base/test/test_suite.cc:277
> >     Igalia#25 0x72b9892 in Run base/callback.h:99:12
> >     Igalia#26 0x72b9892 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) base/test/launcher/unit_test_launcher.cc:224
> >     Igalia#27 0x72b9330 in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) base/test/launcher/unit_test_launcher.cc:575:10
> >     Igalia#28 0x178df94 in main ash/test/ash_unittests.cc:37:10
> >     Igalia#29 0x7f78e2b62f44 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287
> > 
> > SUMMARY: AddressSanitizer: heap-use-after-free buildtools/third_party/libc++/trunk/include/vector:1479:30 in begin
> > Shadow bytes around the buggy address:
> >   0x0c267fffe390: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> >   0x0c267fffe3a0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> >   0x0c267fffe3b0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 fa
> >   0x0c267fffe3c0: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
> >   0x0c267fffe3d0: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd
> > =>0x0c267fffe3e0: fd fd fd fd fd fd fd fd fd fd fd fd fd[fd]fd fd
> >   0x0c267fffe3f0: fd fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
> >   0x0c267fffe400: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd
> >   0x0c267fffe410: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd
> >   0x0c267fffe420: fd fd fd fd fd fd fd fd fd fd fd fd fa fa fa fa
> >   0x0c267fffe430: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
> > Shadow byte legend (one shadow byte represents 8 application bytes):
> >   Addressable:           00
> >   Partially addressable: 01 02 03 04 05 06 07 
> >   Heap left redzone:       fa
> >   Freed heap region:       fd
> >   Stack left redzone:      f1
> >   Stack mid redzone:       f2
> >   Stack right redzone:     f3
> >   Stack after return:      f5
> >   Stack use after scope:   f8
> >   Global redzone:          f9
> >   Global init order:       f6
> >   Poisoned by user:        f7
> >   Container overflow:      fc
> >   Array cookie:            ac
> >   Intra object redzone:    bb
> >   ASan internal:           fe
> >   Left alloca redzone:     ca
> >   Right alloca redzone:    cb
> >   Shadow gap:              cc
> > ==28149==ABORTING
> > 
> > Original change's description:
> > > cros: Enable touchable app context menus by default.
> > > 
> > > This will enable:
> > >  - New context menu UI for:
> > >   - Application icons
> > >   - Shelf context menus
> > >   - Desktop context menus
> > > 
> > > Note:
> > >  - Removed tests whose functionality were already being tested.
> > >    - MouseContextMenu already tests whether the ink drop is being
> > >      shown, so there is no need for
> > >      ShelfButtonShowsInkDropHighlightOnMenuShow.
> > > 
> > > Bug: 871843
> > > Change-Id: I4c92ae52f75b25bc9edd1dd67778c4785d8f4058
> > > Reviewed-on: https://chromium-review.googlesource.com/1170985
> > > Reviewed-by: Scott Violet <sky@chromium.org>
> > > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> > > Commit-Queue: Alex Newcomer <newcomer@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#582978}
> > 
> > TBR=xiyuan@chromium.org,sky@chromium.org,newcomer@chromium.org
> > 
> > Change-Id: Ib85676861251f41c84f48f956d36c01edb353266
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: 871843
> > Reviewed-on: https://chromium-review.googlesource.com/1174641
> > Reviewed-by: Chris Mumford <cmumford@chromium.org>
> > Commit-Queue: Chris Mumford <cmumford@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#583088}
> 
> TBR=xiyuan@chromium.org,sky@chromium.org,cmumford@chromium.org,newcomer@chromium.org
> 
> Change-Id: I4edeef479d40e1e591ac906aa89ede363668b6a3
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 871843
> Reviewed-on: https://chromium-review.googlesource.com/1174777
> Reviewed-by: Alex Newcomer <newcomer@chromium.org>
> Commit-Queue: Alex Newcomer <newcomer@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#583310}

TBR=xiyuan@chromium.org,sky@chromium.org,cmumford@chromium.org,newcomer@chromium.org

Change-Id: I8398745c9037fb5be605069646b3a655519d023e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 871843
Reviewed-on: https://chromium-review.googlesource.com/1177482
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583619}
jkim-julie pushed a commit that referenced this issue Oct 29, 2018
@mfreed7
PostTask back to main thread in viz::HostFrameSinkManager::OnFrameTok…
a161c6a 
…enChanged()

When running in single threaded mode, calls from
OnBeginImplFrameDeadline() can make their way from the main thread to
the impl thread, and then (erroneously) directly back to the main
thread, causing a crash. See the stack trace below. With this CL, the
call from viz::HostFrameSinkManager::OnFrameTokenChanged() is proxied
back to the main thread for the call to
content::DelegatedFrameHost::OnFrameTokenChanged().

A number of tests also call FrameSinkManagerImpl::SetLocalClient and/or
surface_utils::ConnectWithLocalFrameSinkManager, and I did not want
to change their existing behavior. So the additional task_runner
parameter is defaulted to nullptr, and in that case the old behavior
still applies - the call is not PostTasked.

Example crash:
[243567:243567:1023/120428.757147:FATAL:single_thread_proxy.cc(239)] Check failed: task_runner_provider_->IsMainThread().
#0 0x7f4d3b3bbccd base::debug::StackTrace::StackTrace()
#1 0x7f4d3b0b8a2a base::debug::StackTrace::StackTrace()
#2 0x7f4d3b12a59b logging::LogMessage::~LogMessage()
#3 0x7f4d315b4e9b cc::SingleThreadProxy::SetNeedsCommit()
#4 0x7f4d3149b8ef cc::LayerTreeHost::SetNeedsCommit()
#5 0x7f4d312b28f1 cc::Layer::SetNeedsCommit()
#6 0x7f4d312b8205 cc::Layer::SetBackgroundColor()
#7 0x7f4d2cb5fd54 ui::Layer::SetColorFromAnimation()
#8 0x7f4d2cb79024 ui::LayerAnimator::SetColor()
#9 0x7f4d2cb56a5c ui::Layer::SetColor()
#10 0x7f4d37f1b8a1 content::RenderWidgetHostViewAura::UpdateBackgroundColor()
#11 0x7f4d37f2851e content::RenderWidgetHostViewBase::SetContentBackgroundColor()
#12 0x7f4d37f222cb content::RenderWidgetHostViewAura::OnRenderFrameMetadataChangedAfterActivation()
#13 0x7f4d37e81d5c content::RenderFrameMetadataProviderImpl::OnRenderFrameMetadataChangedAfterActivation()
#14 0x7f4d37e8391f _ZN4base8internal13FunctorTraitsIMN7content31RenderFrameMetadataProviderImplEFvN2cc19RenderFrameMetadataEEvE6InvokeIS7_NS_7WeakPtrIS3_EEJS5_EEEvT_OT0_DpOT1_
#15 0x7f4d37e83805 _ZN4base8internal12InvokeHelperILb1EvE8MakeItSoIMN7content31RenderFrameMetadataProviderImplEFvN2cc19RenderFrameMetadataEENS_7WeakPtrIS5_EEJS7_EEEvOT_OT0_DpOT1_
#16 0x7f4d37e8377d _ZN4base8internal7InvokerINS0_9BindStateIMN7content31RenderFrameMetadataProviderImplEFvN2cc19RenderFrameMetadataEEJNS_7WeakPtrIS4_EES6_EEEFvvEE7RunImplIS8_NSt3__15tupleIJSA_S6_EEEJLm0ELm1EEEEvOT_OT0_NSF_16integer_sequenceImJXspT1_EEEE
#17 0x7f4d37e836f9 _ZN4base8internal7InvokerINS0_9BindStateIMN7content31RenderFrameMetadataProviderImplEFvN2cc19RenderFrameMetadataEEJNS_7WeakPtrIS4_EES6_EEEFvvEE7RunOnceEPNS0_13BindStateBaseE
#18 0x7f4d35ecd92e _ZNO4base12OnceCallbackIFvvEE3RunEv
#19 0x7f4d37d2d8a3 content::FrameTokenMessageQueue::DidProcessFrame()
#20 0x7f4d37ef17cd content::RenderWidgetHostImpl::DidProcessFrame()
#21 0x7f4d37f2aeaa content::RenderWidgetHostViewBase::OnFrameTokenChangedForView()
#22 0x7f4d3845b99f content::DelegatedFrameHostClientAura::OnFrameTokenChanged()
#23 0x7f4d38483f90 content::DelegatedFrameHost::OnFrameTokenChanged()
#24 0x7f4d1aaa7e8c viz::HostFrameSinkManager::OnFrameTokenChanged()
#25 0x7f4d1b5b41dc viz::FrameSinkManagerImpl::OnFrameTokenChanged()
#26 0x7f4d1b59594e viz::CompositorFrameSinkSupport::OnFrameTokenChanged()
#27 0x7f4d1b61ab83 viz::Surface::ActivateFrame()
#28 0x7f4d1b61920f viz::Surface::ActivatePendingFrame()
#29 0x7f4d1b618f2a viz::Surface::OnSurfaceDependencyAdded()
#30 0x7f4d1b62e241 viz::SurfaceDependencyTracker::OnSurfaceDependencyAdded()
#31 0x7f4d1b6432ac viz::SurfaceManager::SurfaceDependencyAdded()
#32 0x7f4d1b619b7f viz::Surface::UpdateActivationDependencies()
#33 0x7f4d1b6194f3 viz::Surface::QueueFrame()
#34 0x7f4d1b59a155 viz::CompositorFrameSinkSupport::MaybeSubmitCompositorFrameInternal()
#35 0x7f4d1b598206 viz::CompositorFrameSinkSupport::MaybeSubmitCompositorFrame()
#36 0x7f4d1b59801a viz::CompositorFrameSinkSupport::SubmitCompositorFrame()
#37 0x7f4d1b5a4b08 viz::DirectLayerTreeFrameSink::SubmitCompositorFrame()
#38 0x7f4d314d8e24 cc::LayerTreeHostImpl::DrawLayers()
#39 0x7f4d315b8ee8 cc::SingleThreadProxy::DoComposite()
#40 0x7f4d315bb087 cc::SingleThreadProxy::ScheduledActionDrawIfPossible()
#41 0x7f4d3139c9b8 cc::Scheduler::DrawIfPossible()
#42 0x7f4d31396581 cc::Scheduler::ProcessScheduledActions()
#43 0x7f4d3139c7da cc::Scheduler::OnBeginImplFrameDeadline()
#44 0x7f4d313a024d _ZN4base8internal13FunctorTraitsIMN2cc9SchedulerEFvvEvE6InvokeIS5_PS3_JEEEvT_OT0_DpOT1_
#45 0x7f4d313a0194 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIMN2cc9SchedulerEFvvEJPS5_EEEvOT_DpOT0_
#46 0x7f4d313a0145 _ZN4base8internal7InvokerINS0_9BindStateIMN2cc9SchedulerEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE7RunImplIS6_NSt3__15tupleIJS8_EEEJLm0EEEEvOT_OT0_NSD_16integer_sequenceImJXspT1_EEEE
#47 0x7f4d313a0089 _ZN4base8internal7InvokerINS0_9BindStateIMN2cc9SchedulerEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE7RunOnceEPNS0_13BindStateBaseE
#48 0x7f4d313a059e _ZNO4base12OnceCallbackIFvvEE3RunEv
#49 0x7f4d313a0544 _ZN4base8internal22CancelableCallbackImplINS_12OnceCallbackIFvvEEEE11ForwardOnceIJEEEvDpT_
#50 0x7f4d3129de9f _ZN4base8internal13FunctorTraitsIMN2cc28ScrollbarAnimationControllerEFvvEvE6InvokeIS5_RKNS_7WeakPtrIS3_EEJEEEvT_OT0_DpOT1_
#51 0x7f4d3129de1a _ZN4base8internal12InvokeHelperILb1EvE8MakeItSoIRKMN2cc28ScrollbarAnimationControllerEFvvERKNS_7WeakPtrIS5_EEJEEEvOT_OT0_DpOT1_
#52 0x7f4d3129ddb0 _ZN4base8internal7InvokerINS0_9BindStateIMN2cc28ScrollbarAnimationControllerEFvvEJNS_7WeakPtrIS4_EEEEEFvvEE7RunImplIRKS6_RKNSt3__15tupleIJS8_EEEJLm0EEEEvOT_OT0_NSF_16integer_sequenceImJXspT1_EEEE
#53 0x7f4d3137d0d9 _ZN4base8internal7InvokerINS0_9BindStateIMN2cc12ResourcePoolEFvvEJNS_7WeakPtrIS4_EEEEEFvvEE7RunOnceEPNS0_13BindStateBaseE
#54 0x7f4d3b0683ee _ZNO4base12OnceCallbackIFvvEE3RunEv
#55 0x7f4d3b0ba072 base::debug::TaskAnnotator::RunTask()
#56 0x7f4d3b14f466 base::MessageLoop::RunTask()
#57 0x7f4d3b14f7ee base::MessageLoop::DeferOrRunPendingTask()
#58 0x7f4d3b14fc79 base::MessageLoop::DoWork()
#59 0x7f4d3b1572b6 base::MessagePumpGlib::Run()
#60 0x7f4d3b14eb5b base::MessageLoop::Run()
#61 0x7f4d3b1fac6d base::RunLoop::Run()
#62 0x7f4d372f8dfc content::BrowserMainLoop::MainMessageLoopRun()
#63 0x7f4d372f8a52 content::BrowserMainLoop::RunMainMessageLoopParts()
#64 0x7f4d37301050 content::BrowserMainRunnerImpl::Run()
#65 0x0000018caad1 (anonymous namespace)::RunOneTest()
#66 0x0000018ca696 (anonymous namespace)::RunTests()
#67 0x0000018ca11d LayoutTestBrowserMain()
#68 0x0000018c82c0 content::ShellMainDelegate::RunProcess()
#69 0x7f4d39305d5a content::RunBrowserProcessMain()
#70 0x7f4d39308bc7 content::ContentMainRunnerImpl::Run()
#71 0x7f4d392feabc content::ContentServiceManagerMainDelegate::RunEmbedderProcess()
#72 0x7f4d13359c2a service_manager::Main()
#73 0x7f4d393034b3 content::ContentMain()
#74 0x00000075e165 main
#75 0x7f4d13dcd2b1 __libc_start_main
#76 0x00000075e02a _start


Bug: 667551
Change-Id: Iab72ad842b4672f7c3e37060bd2085b2d8ce0803
Reviewed-on: https://chromium-review.googlesource.com/c/1297477
Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602912}
jkim-julie pushed a commit that referenced this issue Dec 10, 2018
Revert "Add util method to update ArchiveAnalyzerResults for a single…
98e5304 
… file"

This reverts commit aa21b3f.

Reason for revert: Suspect of introducing consistent failure on Mac ASAN 64 tests.

First failed run: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac%20ASan%2064%20Tests%20%281%29/46988

Sample logs:
unit_tests Run on OS: 'Mac-10.13'
Shard duration: 0:07:56.378119
failures:
FileAnalyzerTest.ArchivedArchiveSetForZipNoArchive
FileAnalyzerTest.ArchivedExecutableFalseForZipNoExecutable
DownloadProtectionServiceTest.CheckClientDownloadZip
SandboxedZipAnalyzerTest.ZippedAppWithUnsignedAndSignedExecutable
SandboxedZipAnalyzerTest.NoBinaries
FileAnalyzerTest.ArchivedBinariesSkipsSafeFiles

==34531==ERROR: AddressSanitizer: stack-buffer-overflow on address 0x700015467c14 at pc 0x00013e99c44d bp 0x700015467950 sp 0x7000154670f8
READ of size 5 at 0x700015467c14 thread T16
    #0 0x13e99c44c in __asan_after_dynamic_init ??:0:0
    #1 0x10e3ac931 in safe_browsing::UpdateArchiveAnalyzerResultsWithFile(base::FilePath, base::File*, bool, safe_browsing::ArchiveAnalyzerResults*) ??:0:0
    #2 0x10e3a6707 in safe_browsing::zip_analyzer::AnalyzeZipFile(base::File, base::File, safe_browsing::ArchiveAnalyzerResults*) ??:0:0
    #3 0x115236586 in SafeArchiveAnalyzer::AnalyzeZipFile(base::File, base::File, base::OnceCallback<void (safe_browsing::ArchiveAnalyzerResults const&)>) ??:0:0
    #4 0x10bc0b332 in chrome::mojom::SafeArchiveAnalyzerStubDispatch::AcceptWithResponder(chrome::mojom::SafeArchiveAnalyzer*, mojo::Message*, std::__1::unique_ptr<mojo::MessageReceiverWithStatus, std::__1::default_delete<mojo::MessageReceiverWithStatus> >) ??:0:0
    #5 0x115234a40 in chrome::mojom::SafeArchiveAnalyzerStub<mojo::RawPtrImplRefTraits<chrome::mojom::SafeArchiveAnalyzer> >::AcceptWithResponder(mojo::Message*, std::__1::unique_ptr<mojo::MessageReceiverWithStatus, std::__1::default_delete<mojo::MessageReceiverWithStatus> >) ??:0:0
    #6 0x1165eeb32 in mojo::InterfaceEndpointClient::HandleValidatedMessage(mojo::Message*) ??:0:0
    #7 0x1165ed1e0 in mojo::FilterChain::Accept(mojo::Message*) ??:0:0
    #8 0x1165f278b in mojo::InterfaceEndpointClient::HandleIncomingMessage(mojo::Message*) ??:0:0
    #9 0x116605686 in mojo::internal::MultiplexRouter::ProcessIncomingMessage(mojo::internal::MultiplexRouter::MessageWrapper*, mojo::internal::MultiplexRouter::ClientCallBehavior, base::SequencedTaskRunner*) ??:0:0
    #10 0x11660372b in mojo::internal::MultiplexRouter::Accept(mojo::Message*) ??:0:0
    #11 0x1165ed1e0 in mojo::FilterChain::Accept(mojo::Message*) ??:0:0
    #12 0x1165dcea8 in mojo::Connector::ReadSingleMessage(unsigned int*) ??:0:0
    #13 0x1165df32a in mojo::Connector::ReadAllAvailableMessages() ??:0:0
    #14 0x1165deda1 in mojo::Connector::OnHandleReadyInternal(unsigned int) ??:0:0
    #15 0x10d429d44 in mojo::SimpleWatcher::DiscardReadyState(base::RepeatingCallback<void (unsigned int)> const&, unsigned int, mojo::HandleSignalsState const&) ??:0:0
    #16 0x11a802cf5 in mojo::SimpleWatcher::OnHandleReady(int, unsigned int, mojo::HandleSignalsState const&) ??:0:0
    #17 0x11a803cbd in void base::internal::Invoker<base::internal::BindState<void (mojo::SimpleWatcher::*)(int, unsigned int, mojo::HandleSignalsState const&), base::WeakPtr<mojo::SimpleWatcher>, int, unsigned int, mojo::HandleSignalsState>, void ()>::RunImpl<void (mojo::SimpleWatcher::* const&)(int, unsigned int, mojo::HandleSignalsState const&), std::__1::tuple<base::WeakPtr<mojo::SimpleWatcher>, int, unsigned int, mojo::HandleSignalsState> const&, 0ul, 1ul, 2ul, 3ul>(void (mojo::SimpleWatcher::* const&)(int, unsigned int, mojo::HandleSignalsState const&), std::__1::tuple<base::WeakPtr<mojo::SimpleWatcher>, int, unsigned int, mojo::HandleSignalsState> const&, std::__1::integer_sequence<unsigned long, 0ul, 1ul, 2ul, 3ul>) ??:0:0
    #18 0x11890131c in base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) ??:0:0
    #19 0x118995271 in base::MessageLoopImpl::RunTask(base::PendingTask*) ??:0:0
    #20 0x11899691f in base::MessageLoopImpl::DoWork() ??:0:0
    #21 0x118999eb3 in base::MessagePumpDefault::Run(base::MessagePump::Delegate*) ??:0:0
    #22 0x118994259 in base::MessageLoopImpl::Run(bool) ??:0:0
    #23 0x118a49a1c in base::RunLoop::Run() ??:0:0
    #24 0x118b962e2 in base::Thread::Run(base::RunLoop*) ??:0:0
    #25 0x118b96e9d in base::Thread::ThreadMain() ??:0:0
    #26 0x118c72a0d in base::(anonymous namespace)::ThreadFunc(void*) ??:0:0
    #27 0x7fff74564660 in _pthread_body ??:0:0
    #28 0x7fff7456450c in _pthread_start ??:0:0


Original change's description:
> Add util method to update ArchiveAnalyzerResults for a single file
> 
> This CL breaks out the code that inspects an individual file within a
> ZIP archive. This will be shared between the ZIP and RAR inspection,
> when RAR files begin doing content inspection.
> 
> Bug: 909778
> Change-Id: I7acf1cabd472f112f2ed7c31735688cae7a6d122
> Reviewed-on: https://chromium-review.googlesource.com/c/1354103
> Commit-Queue: Daniel Rubery <drubery@chromium.org>
> Reviewed-by: Brian White <bcwhite@chromium.org>
> Reviewed-by: Jay Civelli <jcivelli@chromium.org>
> Reviewed-by: Varun Khaneja <vakh@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#612799}

TBR=jcivelli@chromium.org,bcwhite@chromium.org,vakh@chromium.org,drubery@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 909778
Change-Id: I92e193707da4a28cee94aa1277a6ca567650760f
Reviewed-on: https://chromium-review.googlesource.com/c/1358491
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613073}
jkim-julie pushed a commit that referenced this issue Dec 10, 2018
Revert "Move AXTreeSourceAura tests into AXTreeSourceViews tests"
100ecc7 
This reverts commit 3bb44fe.

Reason for revert: Suspect of introducing consistent failure on 
 Linux Chromium OS ASan LSan Tests (1) bot.

First failure:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/30399

Sample logs:
views_mus_unittests Run on OS: 'Ubuntu-14.04'
Shard duration: 0:01:41.022687
failures:
AXTreeSourceViewsRootTest.Serialize
AXTreeSourceViewsRootTest.Focus
AXTreeSourceViewsRootTest.Accessors
AXTreeSourceViewsRootTest.SerializeWindowSetsClipsChildren
AXTreeSourceViewsRootTest.DoDefault

  ==7985==ERROR: LeakSanitizer: detected memory leaks
  Direct leak of 56 byte(s) in 1 object(s) allocated from:
      #0 0x55ec150a7ed2 in operator new(unsigned long) /b/swarming/w/ir/kitchen-workdir/src/third_party/llvm/compiler-rt/lib/asan/asan_new_delete.cc:106:3
      #1 0x55ec158f3f9e in ui::AXTreeSerializer<views::AXAuraObjWrapper*, ui::AXNodeData, ui::AXTreeData>::SerializeChangedNodes(views::AXAuraObjWrapper*, ui::AXTreeUpdateBase<ui::AXNodeData, ui::AXTreeData>*) ui/accessibility/ax_tree_serializer.h:598:35
      #2 0x55ec158f41c2 in ui::AXTreeSerializer<views::AXAuraObjWrapper*, ui::AXNodeData, ui::AXTreeData>::SerializeChangedNodes(views::AXAuraObjWrapper*, ui::AXTreeUpdateBase<ui::AXNodeData, ui::AXTreeData>*) ui/accessibility/ax_tree_serializer.h:604:12
      #3 0x55ec158f41c2 in ui::AXTreeSerializer<views::AXAuraObjWrapper*, ui::AXNodeData, ui::AXTreeData>::SerializeChangedNodes(views::AXAuraObjWrapper*, ui::AXTreeUpdateBase<ui::AXNodeData, ui::AXTreeData>*) ui/accessibility/ax_tree_serializer.h:604:12
      #4 0x55ec158f09de in ui::AXTreeSerializer<views::AXAuraObjWrapper*, ui::AXNodeData, ui::AXTreeData>::SerializeChanges(views::AXAuraObjWrapper*, ui::AXTreeUpdateBase<ui::AXNodeData, ui::AXTreeData>*) ui/accessibility/ax_tree_serializer.h:422:8
      #5 0x55ec158ee9d9 in views::(anonymous namespace)::AXTreeSourceViewsRootTest_Serialize_Test::TestBody() ui/views/accessibility/ax_tree_source_views_unittest.cc:318:17
      #6 0x55ec17bdd342 in HandleExceptionsInMethodIfSupported<testing::Test, void> third_party/googletest/src/googletest/src/gtest.cc
      #7 0x55ec17bdd342 in testing::Test::Run() third_party/googletest/src/googletest/src/gtest.cc:2522
      #8 0x55ec17bdf428 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2703:11
      #9 0x55ec17be08e6 in testing::TestCase::Run() third_party/googletest/src/googletest/src/gtest.cc:2825:28
      #10 0x55ec17c08f46 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5227:43
      #11 0x55ec17c082c5 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> third_party/googletest/src/googletest/src/gtest.cc
      #12 0x55ec17c082c5 in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc:4835
      #13 0x55ec180eb7da in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2369:46
      #14 0x55ec180eb7da in base::TestSuite::Run() base/test/test_suite.cc:294
      #15 0x55ec180f1a34 in Run base/callback.h:99:12
      #16 0x55ec180f1a34 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) base/test/launcher/unit_test_launcher.cc:225
      #17 0x55ec180f1500 in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) base/test/launcher/unit_test_launcher.cc:575:10
      #18 0x55ec15220e7e in views::ViewsTestSuite::RunTests() ui/views/views_test_suite.cc:33:10
      #19 0x55ec150f46a3 in main ui/views/mus/run_all_unittests_mus.cc:8:47
      #20 0x7fd6ce976f44 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21f44)
  Indirect leak of 8 byte(s) in 1 object(s) allocated from:
      #0 0x55ec150a7ed2 in operator new(unsigned long) /b/swarming/w/ir/kitchen-workdir/src/third_party/llvm/compiler-rt/lib/asan/asan_new_delete.cc:106:3
      #1 0x55ec158f6f15 in __libcpp_allocate buildtools/third_party/libc++/trunk/include/new:254:10
      #2 0x55ec158f6f15 in allocate buildtools/third_party/libc++/trunk/include/memory:1800
      #3 0x55ec158f6f15 in allocate buildtools/third_party/libc++/trunk/include/memory:1549
      #4 0x55ec158f6f15 in __split_buffer buildtools/third_party/libc++/trunk/include/__split_buffer:311
      #5 0x55ec158f6f15 in std::__1::vector<ui::ClientTreeNode*, std::__1::allocator<ui::ClientTreeNode*> >::reserve(unsigned long) buildtools/third_party/libc++/trunk/include/vector:1576
      #6 0x55ec158f3a1b in ui::AXTreeSerializer<views::AXAuraObjWrapper*, ui::AXNodeData, ui::AXTreeData>::SerializeChangedNodes(views::AXAuraObjWrapper*, ui::AXTreeUpdateBase<ui::AXNodeData, ui::AXTreeData>*) ui/accessibility/ax_tree_serializer.h:573:25
      #7 0x55ec158f41c2 in ui::AXTreeSerializer<views::AXAuraObjWrapper*, ui::AXNodeData, ui::AXTreeData>::SerializeChangedNodes(views::AXAuraObjWrapper*, ui::AXTreeUpdateBase<ui::AXNodeData, ui::AXTreeData>*) ui/accessibility/ax_tree_serializer.h:604:12
      #8 0x55ec158f41c2 in ui::AXTreeSerializer<views::AXAuraObjWrapper*, ui::AXNodeData, ui::AXTreeData>::SerializeChangedNodes(views::AXAuraObjWrapper*, ui::AXTreeUpdateBase<ui::AXNodeData, ui::AXTreeData>*) ui/accessibility/ax_tree_serializer.h:604:12
      #9 0x55ec158f41c2 in ui::AXTreeSerializer<views::AXAuraObjWrapper*, ui::AXNodeData, ui::AXTreeData>::SerializeChangedNodes(views::AXAuraObjWrapper*, ui::AXTreeUpdateBase<ui::AXNodeData, ui::AXTreeData>*) ui/accessibility/ax_tree_serializer.h:604:12
      #10 0x55ec158f09de in ui::AXTreeSerializer<views::AXAuraObjWrapper*, ui::AXNodeData, ui::AXTreeData>::SerializeChanges(views::AXAuraObjWrapper*, ui::AXTreeUpdateBase<ui::AXNodeData, ui::AXTreeData>*) ui/accessibility/ax_tree_serializer.h:422:8
      #11 0x55ec158ee9d9 in views::(anonymous namespace)::AXTreeSourceViewsRootTest_Serialize_Test::TestBody() ui/views/accessibility/ax_tree_source_views_unittest.cc:318:17
      #12 0x55ec17bdd342 in HandleExceptionsInMethodIfSupported<testing::Test, void> third_party/googletest/src/googletest/src/gtest.cc
      #13 0x55ec17bdd342 in testing::Test::Run() third_party/googletest/src/googletest/src/gtest.cc:2522
      #14 0x55ec17bdf428 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2703:11
      #15 0x55ec17be08e6 in testing::TestCase::Run() third_party/googletest/src/googletest/src/gtest.cc:2825:28
      #16 0x55ec17c08f46 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5227:43
      #17 0x55ec17c082c5 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> third_party/googletest/src/googletest/src/gtest.cc
      #18 0x55ec17c082c5 in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc:4835
      #19 0x55ec180eb7da in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2369:46
      #20 0x55ec180eb7da in base::TestSuite::Run() base/test/test_suite.cc:294
      #21 0x55ec180f1a34 in Run base/callback.h:99:12
      #22 0x55ec180f1a34 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) base/test/launcher/unit_test_launcher.cc:225
      #23 0x55ec180f1500 in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) base/test/launcher/unit_test_launcher.cc:575:10
      #24 0x55ec15220e7e in views::ViewsTestSuite::RunTests() ui/views/views_test_suite.cc:33:10
      #25 0x55ec150f46a3 in main ui/views/mus/run_all_unittests_mus.cc:8:47
      #26 0x7fd6ce976f44 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21f44)



Original change's description:
> Move AXTreeSourceAura tests into AXTreeSourceViews tests
> 
> AXTreeSourceAura doesn't exist any more. The tests exercise the
> integration of AXRootObjWrapper with AXTreeSourceViews, so rename the
> tests ot AXTreeSourceViewsRootTest.
> 
> Note that the tests lived in //chrome/browser/ui/ash. If we need an
> ash-specific tree source we could introduce an AXTreeSourceAsh either
> in //ash (for mash) or //chrome/browser/ui/ash (for SingleProcessMash).
> 
> Bug: 910672
> Test: views_unittests
> Change-Id: I79438345e3ad9bd1aa69d74b3c34cc35efe87142
> Reviewed-on: https://chromium-review.googlesource.com/c/1358972
> Reviewed-by: David Tseng <dtseng@chromium.org>
> Commit-Queue: James Cook <jamescook@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#613308}

TBR=jamescook@chromium.org,dtseng@chromium.org

Change-Id: If77dfe8f468d8f5e8514e2dbe57c9aff3cbf5a3e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 910672
Reviewed-on: https://chromium-review.googlesource.com/c/1360591
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613487}
jkim-julie pushed a commit that referenced this issue Dec 10, 2018
Avoid data race in CaptivePortalBrowserTest::OnIntercept
2efdf18 
Data race happens between SetBehindCaptivePortal on BrowserThread::IO
and CaptivePortalBrowserTest::OnIntercept line 981 on main thread

Change-Id: I58163d96f66f8ca3b2d257d1481b0d12f980c679

ThreadSanitizer Report

WARNING: ThreadSanitizer: data race (pid=37545)
  Read of size 1 at 0x7b44000004d8 by main thread:
    #0 CaptivePortalBrowserTest::OnIntercept(content::URLLoaderInterceptor::RequestParams*) /src/chrome/browser/captive_portal/captive_portal_browsertest.cc:984:9 (browser_tests+0x4ea3f84)
    #1 Invoke<bool (CaptivePortalBrowserTest::*)(content::URLLoaderInterceptor::RequestParams *), CaptivePortalBrowserTest *, content::URLLoaderInterceptor::RequestParams *> /src/base/bind_internal.h:507:12 (browser_tests+0x4ed3a2f)
    #2 MakeItSo<bool (CaptivePortalBrowserTest::*const &)(content::URLLoaderInterceptor::RequestParams *), CaptivePortalBrowserTest *, content::URLLoaderInterceptor::RequestParams *> /src/base/bind_internal.h:607 (browser_tests+0x4ed3a2f)
    #3 RunImpl<bool (CaptivePortalBrowserTest::*const &)(content::URLLoaderInterceptor::RequestParams *), const std::__1::tuple<base::internal::UnretainedWrapper<CaptivePortalBrowserTest> > &, 0> /src/base/bind_internal.h:680 (browser_tests+0x4ed3a2f)
    #4 base::internal::Invoker<base::internal::BindState<bool (CaptivePortalBrowserTest::*)(content::URLLoaderInterceptor::RequestParams*), base::internal::UnretainedWrapper<CaptivePortalBrowserTest> >, bool (content::URLLoaderInterceptor::RequestParams*)>::Run(base::internal::BindStateBase*, content::URLLoaderInterceptor::RequestParams*) /src/base/bind_internal.h:662 (browser_tests+0x4ed3a2f)
    #5 Run /src/base/callback.h:129:12 (browser_tests+0xa8cbbcc)
    #6 content::URLLoaderInterceptor::Intercept(content::URLLoaderInterceptor::RequestParams*) /src/content/public/test/url_loader_interceptor.cc:377 (browser_tests+0xa8cbbcc)
    #7 content::URLLoaderInterceptor::Interceptor::CreateLoaderAndStart(mojo::InterfaceRequest<network::mojom::URLLoader>, int, int, unsigned int, network::ResourceRequest const&, mojo::InterfacePtr<network::mojom::URLLoaderClient>, net::MutableNetworkTrafficAnnotationTag const&) /src/content/public/test/url_loader_interceptor.cc:92:18 (browser_tests+0xa8cd294)
    #8 network::mojom::URLLoaderFactoryProxy_CreateLoaderAndStart_Message::Dispatch(network::mojom::URLLoaderFactory*) /src/out/Default/gen/services/network/public/mojom/url_loader_factory.mojom.cc:145:11 (browser_tests+0x581c781)
    #9 network::mojom::URLLoaderFactoryStubDispatch::Accept(network::mojom::URLLoaderFactory*, mojo::Message*) /src/out/Default/gen/services/network/public/mojom/url_loader_factory.mojom.cc:353:20 (browser_tests+0x581c626)
    #10 network::mojom::URLLoaderFactoryStub<mojo::RawPtrImplRefTraits<network::mojom::URLLoaderFactory> >::Accept(mojo::Message*) /src/out/Default/gen/services/network/public/mojom/url_loader_factory.mojom.h:155:12 (browser_tests+0x69ccb3f)
    #11 mojo::InterfaceEndpointClient::HandleValidatedMessage(mojo::Message*) /src/mojo/public/cpp/bindings/lib/interface_endpoint_client.cc:423:32 (browser_tests+0xb97e563)
    #12 mojo::InterfaceEndpointClient::HandleIncomingMessageThunk::Accept(mojo::Message*) /src/mojo/public/cpp/bindings/lib/interface_endpoint_client.cc:133:18 (browser_tests+0xb97df6a)
    #13 mojo::FilterChain::Accept(mojo::Message*) /src/mojo/public/cpp/bindings/lib/filter_chain.cc:40:17 (browser_tests+0xb9823ba)
    #14 mojo::InterfaceEndpointClient::HandleIncomingMessage(mojo::Message*) /src/mojo/public/cpp/bindings/lib/interface_endpoint_client.cc:306:19 (browser_tests+0xb9801ba)
    #15 mojo::internal::MultiplexRouter::ProcessIncomingMessage(mojo::internal::MultiplexRouter::MessageWrapper*, mojo::internal::MultiplexRouter::ClientCallBehavior, base::SequencedTaskRunner*) /src/mojo/public/cpp/bindings/lib/multiplex_router.cc:869:42 (browser_tests+0xb98ba4b)
    #16 mojo::internal::MultiplexRouter::Accept(mojo::Message*) /src/mojo/public/cpp/bindings/lib/multiplex_router.cc:590:38 (browser_tests+0xb98a86a)
    #17 mojo::FilterChain::Accept(mojo::Message*) /src/mojo/public/cpp/bindings/lib/filter_chain.cc:40:17 (browser_tests+0xb9823ba)
    #18 mojo::Connector::ReadSingleMessage(unsigned int*) /src/mojo/public/cpp/bindings/lib/connector.cc:457:51 (browser_tests+0xb97a2be)
    #19 mojo::Connector::ReadAllAvailableMessages() /src/mojo/public/cpp/bindings/lib/connector.cc:486:10 (browser_tests+0xb97b0e7)
    #20 mojo::Connector::OnHandleReadyInternal(unsigned int) /src/mojo/public/cpp/bindings/lib/connector.cc:387:3 (browser_tests+0xb97ae8e)
    #21 mojo::Connector::OnWatcherHandleReady(unsigned int) /src/mojo/public/cpp/bindings/lib/connector.cc:364:3 (browser_tests+0xb97ade0)
    #22 Invoke<void (mojo::Connector::*)(unsigned int), mojo::Connector *, unsigned int> /src/base/bind_internal.h:507:12 (browser_tests+0xb97bbcf)
    #23 MakeItSo<void (mojo::Connector::*const &)(unsigned int), mojo::Connector *, unsigned int> /src/base/bind_internal.h:607 (browser_tests+0xb97bbcf)
    #24 RunImpl<void (mojo::Connector::*const &)(unsigned int), const std::__1::tuple<base::internal::UnretainedWrapper<mojo::Connector> > &, 0> /src/base/bind_internal.h:680 (browser_tests+0xb97bbcf)
    #25 base::internal::Invoker<base::internal::BindState<void (mojo::Connector::*)(unsigned int), base::internal::UnretainedWrapper<mojo::Connector> >, void (unsigned int)>::Run(base::internal::BindStateBase*, unsigned int) /src/base/bind_internal.h:662 (browser_tests+0xb97bbcf)
    #26 Run /src/base/callback.h:129:12 (browser_tests+0x66996b8)
    #27 mojo::SimpleWatcher::DiscardReadyState(base::RepeatingCallback<void (unsigned int)> const&, unsigned int, mojo::HandleSignalsState const&) /src/mojo/public/cpp/system/simple_watcher.h:194 (browser_tests+0x66996b8)
    #28 Invoke<void (*const &)(const base::RepeatingCallback<void (unsigned int)> &, unsigned int, const mojo::HandleSignalsState &), const base::RepeatingCallback<void (unsigned int)> &, unsigned int, const mojo::HandleSignalsState &> /src/base/bind_internal.h:407:12 (browser_tests+0x6699715)
    #29 MakeItSo<void (*const &)(const base::RepeatingCallback<void (unsigned int)> &, unsigned int, const mojo::HandleSignalsState &), const base::RepeatingCallback<void (unsigned int)> &, unsigned int, const mojo::HandleSignalsState &> /src/base/bind_internal.h:607 (browser_tests+0x6699715)
    #30 RunImpl<void (*const &)(const base::RepeatingCallback<void (unsigned int)> &, unsigned int, const mojo::HandleSignalsState &), const std::__1::tuple<base::RepeatingCallback<void (unsigned int)> > &, 0> /src/base/bind_internal.h:680 (browser_tests+0x6699715)
    #31 base::internal::Invoker<base::internal::BindState<void (*)(base::RepeatingCallback<void (unsigned int)> const&, unsigned int, mojo::HandleSignalsState const&), base::RepeatingCallback<void (unsigned int)> >, void (unsigned int, mojo::HandleSignalsState const&)>::Run(base::internal::BindStateBase*, unsigned int, mojo::HandleSignalsState const&) /src/base/bind_internal.h:662 (browser_tests+0x6699715)
    #32 Run /src/base/callback.h:129:12 (browser_tests+0xa96dece)
    #33 mojo::SimpleWatcher::OnHandleReady(int, unsigned int, mojo::HandleSignalsState const&) /src/mojo/public/cpp/system/simple_watcher.cc:273 (browser_tests+0xa96dece)
    #34 Invoke<void (mojo::SimpleWatcher::*)(int, unsigned int, const mojo::HandleSignalsState &), const base::WeakPtr<mojo::SimpleWatcher> &, const int &, const unsigned int &, const mojo::HandleSignalsState &> /src/base/bind_internal.h:507:12 (browser_tests+0xa96e625)
    #35 MakeItSo<void (mojo::SimpleWatcher::*const &)(int, unsigned int, const mojo::HandleSignalsState &), const base::WeakPtr<mojo::SimpleWatcher> &, const int &, const unsigned int &, const mojo::HandleSignalsState &> /src/base/bind_internal.h:627 (browser_tests+0xa96e625)
    #36 void base::internal::Invoker<base::internal::BindState<void (mojo::SimpleWatcher::*)(int, unsigned int, mojo::HandleSignalsState const&), base::WeakPtr<mojo::SimpleWatcher>, int, unsigned int, mojo::HandleSignalsState>, void ()>::RunImpl<void (mojo::SimpleWatcher::* const&)(int, unsigned int, mojo::HandleSignalsState const&), std::__1::tuple<base::WeakPtr<mojo::SimpleWatcher>, int, unsigned int, mojo::HandleSignalsState> const&, 0ul, 1ul, 2ul, 3ul>(void (mojo::SimpleWatcher::* const&&&)(int, unsigned int, mojo::HandleSignalsState const&), std::__1::tuple<base::WeakPtr<mojo::SimpleWatcher>, int, unsigned int, mojo::HandleSignalsState> const&&&, std::__1::integer_sequence<unsigned long, 0ul, 1ul, 2ul, 3ul>) /src/base/bind_internal.h:680 (browser_tests+0xa96e625)
    #37 base::internal::Invoker<base::internal::BindState<void (mojo::SimpleWatcher::*)(int, unsigned int, mojo::HandleSignalsState const&), base::WeakPtr<mojo::SimpleWatcher>, int, unsigned int, mojo::HandleSignalsState>, void ()>::Run(base::internal::BindStateBase*) /src/base/bind_internal.h:662:12 (browser_tests+0xa96e4ce)
    #38 Run /src/base/callback.h:99:12 (browser_tests+0x9a92ee8)
    #39 base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) /src/base/debug/task_annotator.cc:101 (browser_tests+0x9a92ee8)
    #40 base::MessageLoop::RunTask(base::PendingTask*) /src/base/message_loop/message_loop.cc:432:46 (browser_tests+0x55f355a)
    #41 base::MessageLoop::DeferOrRunPendingTask(base::PendingTask) /src/base/message_loop/message_loop.cc:443:5 (browser_tests+0x55f3e7c)
    #42 base::MessageLoop::DoWork() /src/base/message_loop/message_loop.cc:487:16 (browser_tests+0x55f41c5)
    #43 base::MessagePumpGlib::Run(base::MessagePump::Delegate*) /src/base/message_loop/message_pump_glib.cc:309:49 (browser_tests+0x9ad27bb)
    #44 base::MessageLoop::Run(bool) /src/base/message_loop/message_loop.cc:374:12 (browser_tests+0x55f2c67)
    #45 non-virtual thunk to base::MessageLoop::Run(bool) /src/base/message_loop/message_loop.cc (browser_tests+0x55f2d54)
    #46 base::RunLoop::Run() /src/base/run_loop.cc:102:14 (browser_tests+0x55f6adf)
    #47 RunThisRunLoop /src/content/public/test/test_utils.cc:132:13 (browser_tests+0xa8c5bf8)
    #48 content::RunMessageLoop() /src/content/public/test/test_utils.cc:127 (browser_tests+0xa8c5bf8)
    #49 (anonymous namespace)::CaptivePortalObserver::WaitForResults(int) /src/chrome/browser/captive_portal/captive_portal_browsertest.cc:432:5 (browser_tests+0x4ea7325)
    #50 CaptivePortalBrowserTest_ShowCaptivePortalInterstitialOnCertError_Test::RunTestOnMainThread() /src/chrome/browser/captive_portal/captive_portal_browsertest.cc:1891:25 (browser_tests+0x4eb9cc3)
    #51 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() /src/content/public/test/browser_test_base.cc:406:5 (browser_tests+0xa863ddd)
    #52 Invoke<void (content::BrowserTestBase::*)(), content::BrowserTestBase *> /src/base/bind_internal.h:507:12 (browser_tests+0xa864f28)
    #53 MakeItSo<void (content::BrowserTestBase::*const &)(), content::BrowserTestBase *> /src/base/bind_internal.h:607 (browser_tests+0xa864f28)
    #54 RunImpl<void (content::BrowserTestBase::*const &)(), const std::__1::tuple<base::internal::UnretainedWrapper<content::BrowserTestBase> > &, 0> /src/base/bind_internal.h:680 (browser_tests+0xa864f28)
    #55 base::internal::Invoker<base::internal::BindState<void (content::BrowserTestBase::*)(), base::internal::UnretainedWrapper<content::BrowserTestBase> >, void ()>::Run(base::internal::BindStateBase*) /src/base/bind_internal.h:662 (browser_tests+0xa864f28)
    #56 Run /src/base/callback.h:129:12 (browser_tests+0x9ce722d)
    #57 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() /src/chrome/browser/chrome_browser_main.cc:3181 (browser_tests+0x9ce722d)
    #58 ChromeBrowserMainParts::PreMainMessageLoopRun() /src/chrome/browser/chrome_browser_main.cc:2259:18 (browser_tests+0x9ce52eb)
    #59 content::BrowserMainLoop::PreMainMessageLoopRun() /src/content/browser/browser_main_loop.cc:1021:13 (browser_tests+0x6a854c0)
    #60 Invoke<int (content::BrowserMainLoop::*)(), content::BrowserMainLoop *> /src/base/bind_internal.h:507:12 (browser_tests+0x6a88df8)
    #61 MakeItSo<int (content::BrowserMainLoop::*const &)(), content::BrowserMainLoop *> /src/base/bind_internal.h:607 (browser_tests+0x6a88df8)
    #62 RunImpl<int (content::BrowserMainLoop::*const &)(), const std::__1::tuple<base::internal::UnretainedWrapper<content::BrowserMainLoop> > &, 0> /src/base/bind_internal.h:680 (browser_tests+0x6a88df8)
    #63 base::internal::Invoker<base::internal::BindState<int (content::BrowserMainLoop::*)(), base::internal::UnretainedWrapper<content::BrowserMainLoop> >, int ()>::Run(base::internal::BindStateBase*) /src/base/bind_internal.h:662 (browser_tests+0x6a88df8)
    #64 Run /src/base/callback.h:129:12 (browser_tests+0x726d05a)
    #65 content::StartupTaskRunner::RunAllTasksNow() /src/content/browser/startup_task_runner.cc:43 (browser_tests+0x726d05a)
    #66 content::BrowserMainLoop::CreateStartupTasks() /src/content/browser/browser_main_loop.cc:932:25 (browser_tests+0x6a8379a)
    #67 content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) /src/content/browser/browser_main_runner_impl.cc:143:15 (browser_tests+0x6a893ea)
    #68 content::BrowserMain(content::MainFunctionParams const&) /src/content/browser/browser_main.cc:45:32 (browser_tests+0x6a80539)
    #69 RunBrowserProcessMain /src/content/app/content_main_runner_impl.cc:613:10 (browser_tests+0x99a6eeb)
    #70 content::ContentMainRunnerImpl::Run(bool) /src/content/app/content_main_runner_impl.cc:973 (browser_tests+0x99a6eeb)
    #71 content::ContentServiceManagerMainDelegate::RunEmbedderProcess() /src/content/app/content_service_manager_main_delegate.cc:53:32 (browser_tests+0x99a414f)
    #72 service_manager::Main(service_manager::MainParams const&) /src/services/service_manager/embedder/main.cc:472:29 (browser_tests+0xd205c76)
    #73 content::ContentMain(content::ContentMainParams const&) /src/content/app/content_main.cc:19:10 (browser_tests+0x99a494b)
    #74 content::BrowserTestBase::SetUp() /src/content/public/test/browser_test_base.cc:322:3 (browser_tests+0xa863831)
    #75 InProcessBrowserTest::SetUp() /src/chrome/test/base/in_process_browser_test.cc:272:20 (browser_tests+0x9c3a89d)
    #76 testing::Test::Run() /src/googletest (browser_tests+0x562b70b)
    #77 testing::TestInfo::Run() /src/googletest (browser_tests+0x562c96c)
    #78 testing::TestCase::Run() /src/googletest (browser_tests+0x562d1f6)
    #79 testing::internal::UnitTestImpl::RunAllTests() /src/googletest (browser_tests+0x563d796)
    #80 testing::UnitTest::Run() /src/googletest (browser_tests+0x563d07a)
    #81 RUN_ALL_TESTS /src/googletest/include/gtest/gtest.h:2329:46 (browser_tests+0x9c5d7f5)
    #82 base::TestSuite::Run() /src/base/test/test_suite.cc:277 (browser_tests+0x9c5d7f5)
    #83 ChromeTestSuiteRunner::RunTestSuite(int, char**) /src/chrome/test/base/chrome_test_launcher.cc:65:38 (browser_tests+0x9a490f6)
    #84 ChromeTestLauncherDelegate::RunTestSuite(int, char**) /src/chrome/test/base/chrome_test_launcher.cc:74:19 (browser_tests+0x9a491ff)
    #85 content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) /src/content/public/test/test_launcher.cc:650:31 (browser_tests+0xa8c08de)
    #86 LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) /src/chrome/test/base/chrome_test_launcher.cc:170:10 (browser_tests+0x9a49784)
    #87 main /src/chrome/test/base/browser_tests_main.cc:36:10 (browser_tests+0x9a48fdc)

  Previous write of size 1 at 0x7b44000004d8 by thread T2:
    #0 CaptivePortalBrowserTest::SetBehindCaptivePortal(bool) /src/chrome/browser/captive_portal/captive_portal_browsertest.cc:745:28 (browser_tests+0x4eb12d8)
    #1 Invoke<void (CaptivePortalBrowserTest::*)(bool), CaptivePortalBrowserTest *, bool> /src/base/bind_internal.h:507:12 (browser_tests+0x4ed0549)
    #2 MakeItSo<void (CaptivePortalBrowserTest::*)(bool), CaptivePortalBrowserTest *, bool> /src/base/bind_internal.h:607 (browser_tests+0x4ed0549)
    #3 RunImpl<void (CaptivePortalBrowserTest::*)(bool), std::__1::tuple<base::internal::UnretainedWrapper<CaptivePortalBrowserTest>, bool>, 0, 1> /src/base/bind_internal.h:680 (browser_tests+0x4ed0549)
    #4 base::internal::Invoker<base::internal::BindState<void (CaptivePortalBrowserTest::*)(bool), base::internal::UnretainedWrapper<CaptivePortalBrowserTest>, bool>, void ()>::RunOnce(base::internal::BindStateBase*) /src/base/bind_internal.h:649 (browser_tests+0x4ed0549)
    #5 Run /src/base/callback.h:99:12 (browser_tests+0x9a92ee8)
    #6 base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) /src/base/debug/task_annotator.cc:101 (browser_tests+0x9a92ee8)
    #7 base::MessageLoop::RunTask(base::PendingTask*) /src/base/message_loop/message_loop.cc:432:46 (browser_tests+0x55f355a)
    #8 base::MessageLoop::DeferOrRunPendingTask(base::PendingTask) /src/base/message_loop/message_loop.cc:443:5 (browser_tests+0x55f3e7c)
    #9 base::MessageLoop::DoWork() /src/base/message_loop/message_loop.cc:487:16 (browser_tests+0x55f41c5)
    #10 base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) /src/base/message_loop/message_pump_libevent.cc:210:31 (browser_tests+0x9bfd9b4)
    #11 base::MessageLoop::Run(bool) /src/base/message_loop/message_loop.cc:374:12 (browser_tests+0x55f2c67)
    #12 non-virtual thunk to base::MessageLoop::Run(bool) /src/base/message_loop/message_loop.cc (browser_tests+0x55f2d54)
    #13 base::RunLoop::Run() /src/base/run_loop.cc:102:14 (browser_tests+0x55f6adf)
    #14 base::Thread::Run(base::RunLoop*) /src/base/threading/thread.cc:255:13 (browser_tests+0x9b8d22b)
    #15 content::BrowserProcessSubThread::IOThreadRun(base::RunLoop*) /src/content/browser/browser_process_sub_thread.cc:184:11 (browser_tests+0x6a95a06)
    #16 content::BrowserProcessSubThread::Run(base::RunLoop*) /src/content/browser/browser_process_sub_thread.cc:134:7 (browser_tests+0x6a95913)
    #17 base::Thread::ThreadMain() /src/base/threading/thread.cc:337:3 (browser_tests+0x9b8d80b)
    #18 base::(anonymous namespace)::ThreadFunc(void*) /src/base/threading/platform_thread_posix.cc:76:13 (browser_tests+0x9bf6458)

  Location is heap block of size 288 at 0x7b44000003c0 allocated by main thread:
    #0 operator new(unsigned long) /src/third_party/llvm/compiler-rt/lib/tsan/rtl/tsan_new_delete.cc:65:3 (browser_tests+0x330871d)
    #1 testing::internal::TestFactoryImpl<CaptivePortalBrowserTest_ShowCaptivePortalInterstitialOnCertError_Test>::CreateTest() /src/googletest/include/gtest/internal/gtest-internal.h:466:39 (browser_tests+0x4ed1d69)
    #2 testing::TestInfo::Run() /src/googletest (browser_tests+0x562c8ae)
    #3 testing::TestCase::Run() /src/googletest (browser_tests+0x562d1f6)
    #4 testing::internal::UnitTestImpl::RunAllTests() /src/googletest (browser_tests+0x563d796)
    #5 testing::UnitTest::Run() /src/googletest (browser_tests+0x563d07a)
    #6 RUN_ALL_TESTS /src/googletest/include/gtest/gtest.h:2329:46 (browser_tests+0x9c5d7f5)
    #7 base::TestSuite::Run() /src/base/test/test_suite.cc:277 (browser_tests+0x9c5d7f5)
    #8 ChromeTestSuiteRunner::RunTestSuite(int, char**) /src/chrome/test/base/chrome_test_launcher.cc:65:38 (browser_tests+0x9a490f6)
    #9 ChromeTestLauncherDelegate::RunTestSuite(int, char**) /src/chrome/test/base/chrome_test_launcher.cc:74:19 (browser_tests+0x9a491ff)
    #10 content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) /src/content/public/test/test_launcher.cc:650:31 (browser_tests+0xa8c08de)
    #11 LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) /src/chrome/test/base/chrome_test_launcher.cc:170:10 (browser_tests+0x9a49784)
    #12 main /src/chrome/test/base/browser_tests_main.cc:36:10 (browser_tests+0x9a48fdc)

  Thread T2 'Chrome_IOThread' (tid=37629, running) created by main thread at:
    #0 pthread_create /src/third_party/llvm/compiler-rt/lib/tsan/rtl/tsan_interceptors.cc:965:3 (browser_tests+0x329e755)
    #1 base::(anonymous namespace)::CreateThread(unsigned long, bool, base::PlatformThread::Delegate*, base::PlatformThreadHandle*, base::ThreadPriority) /src/base/threading/platform_thread_posix.cc:115:13 (browser_tests+0x9bf5d96)
    #2 base::PlatformThread::CreateWithPriority(unsigned long, base::PlatformThread::Delegate*, base::PlatformThreadHandle*, base::ThreadPriority) /src/base/threading/platform_thread_posix.cc:200:10 (browser_tests+0x9bf5c55)
    #3 base::Thread::StartWithOptions(base::Thread::Options const&) /src/base/threading/thread.cc:112:15 (browser_tests+0x9b8c8c5)
    #4 content::BrowserProcessSubThread::CreateIOThread() /src/content/browser/browser_process_sub_thread.cc:97:19 (browser_tests+0x6a9560e)
    #5 content::ContentMainRunnerImpl::Run(bool) /src/content/app/content_main_runner_impl.cc:953:29 (browser_tests+0x99a6cc8)
    #6 content::ContentServiceManagerMainDelegate::RunEmbedderProcess() /src/content/app/content_service_manager_main_delegate.cc:53:32 (browser_tests+0x99a414f)
    #7 service_manager::Main(service_manager::MainParams const&) /src/services/service_manager/embedder/main.cc:472:29 (browser_tests+0xd205c76)
    #8 content::ContentMain(content::ContentMainParams const&) /src/content/app/content_main.cc:19:10 (browser_tests+0x99a494b)
    #9 content::BrowserTestBase::SetUp() /src/content/public/test/browser_test_base.cc:322:3 (browser_tests+0xa863831)
    #10 InProcessBrowserTest::SetUp() /src/chrome/test/base/in_process_browser_test.cc:272:20 (browser_tests+0x9c3a89d)
    #11 testing::Test::Run() /src/googletest (browser_tests+0x562b70b)
    #12 testing::TestInfo::Run() /src/googletest (browser_tests+0x562c96c)
    #13 testing::TestCase::Run() /src/googletest (browser_tests+0x562d1f6)
    #14 testing::internal::UnitTestImpl::RunAllTests() /src/googletest (browser_tests+0x563d796)
    #15 testing::UnitTest::Run() /src/googletest (browser_tests+0x563d07a)
    #16 RUN_ALL_TESTS /src/googletest/include/gtest/gtest.h:2329:46 (browser_tests+0x9c5d7f5)
    #17 base::TestSuite::Run() /src/base/test/test_suite.cc:277 (browser_tests+0x9c5d7f5)
    #18 ChromeTestSuiteRunner::RunTestSuite(int, char**) /src/chrome/test/base/chrome_test_launcher.cc:65:38 (browser_tests+0x9a490f6)
    #19 ChromeTestLauncherDelegate::RunTestSuite(int, char**) /src/chrome/test/base/chrome_test_launcher.cc:74:19 (browser_tests+0x9a491ff)
    #20 content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) /src/content/public/test/test_launcher.cc:650:31 (browser_tests+0xa8c08de)
    #21 LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) /src/chrome/test/base/chrome_test_launcher.cc:170:10 (browser_tests+0x9a49784)
    #22 main /src/chrome/test/base/browser_tests_main.cc:36:10 (browser_tests+0x9a48fdc)

SUMMARY: ThreadSanitizer: data race chrome/browser/captive_portal/captive_portal_browsertest.cc:984:9 in CaptivePortalBrowserTest::OnIntercept(content::URLLoaderInterceptor::RequestParams*)
Change-Id: I58163d96f66f8ca3b2d257d1481b0d12f980c679
Reviewed-on: https://chromium-review.googlesource.com/c/1356582
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613677}
jkim-julie pushed a commit that referenced this issue Dec 10, 2018
Offer users an option to delete card from local if uploading failed
26874dc 
If uploading of a card failed, in the feedback dialog, we will show
a string 'invalid' and a trash can button. If the user clicks the button,
that card will be deleted from browser and will disappear in the
feedback dialog. If all invalid cards are deleted in the dialog, the
dialog will be updated to the 'finished' state.

If all cards failed, we will not show the "View cards button".

Uploaded screenshots in the bug (comment #10 and comment #26).

Bug: 897998
Change-Id: Iae7780027932ac530bcb2f0c643be1ec94d1f334
Reviewed-on: https://chromium-review.googlesource.com/c/1314129
Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Commit-Queue: Siyu An <siyua@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614193}
msisov pushed a commit that referenced this issue Dec 23, 2018
Chrome OS: allow scrolling on the Error screen.
3e47f6b 
TBR=alemate@chromium.org

(cherry picked from commit e33d6c0)

Bug: 895000
Change-Id: I2a561a784e013e7d175ba31c5415b82c67d1bb59
Reviewed-on: https://chromium-review.googlesource.com/c/1279385
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#599470}
Reviewed-on: https://chromium-review.googlesource.com/c/1281173
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#26}
Cr-Branched-From: 4226ddf-refs/heads/master@{#599034}
msisov pushed a commit that referenced this issue Jan 31, 2019
Reland "[unified-consent] Fix official browser tests"
89972ed 
This is a reland of 44c85b6

Original change's description:
> [unified-consent] Fix official browser tests
> 
> The unified consent feature was not enabled in
> UnifiedConsentBrowserTest for official tests.
> This is fixed now.
> 
> Bug: 910523, 888527
> Change-Id: Ied1223b008f83c8c92cf471f90e8021606e25fda
> Reviewed-on: https://chromium-review.googlesource.com/c/1356960
> Commit-Queue: Thomas Tangl <tangltom@chromium.org>
> Reviewed-by: David Roger <droger@chromium.org>
> Cr-Original-Commit-Position: refs/heads/master@{#612678}(cherry picked from commit 3763198)
> Reviewed-on: https://chromium-review.googlesource.com/c/1358449
> Reviewed-by: Thomas Tangl <tangltom@chromium.org>
> Cr-Commit-Position: refs/branch-heads/3626@{#9}
> Cr-Branched-From: d897fb1-refs/heads/master@{#612437}

Bug: 910523, 888527
Change-Id: I653b0faf8b59e64020b91a5bab3ab565588a3214
Reviewed-on: https://chromium-review.googlesource.com/c/1361221
Reviewed-by: Thomas Tangl <tangltom@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#26}
Cr-Branched-From: d897fb1-refs/heads/master@{#612437}
msisov pushed a commit that referenced this issue Jan 31, 2019
Offer users an option to delete card from local if uploading failed
bbb07a2 
If uploading of a card failed, in the feedback dialog, we will show
a string 'invalid' and a trash can button. If the user clicks the button,
that card will be deleted from browser and will disappear in the
feedback dialog. If all invalid cards are deleted in the dialog, the
dialog will be updated to the 'finished' state.

If all cards failed, we will not show the "View cards button".

Uploaded screenshots in the bug (comment #10 and comment #26).

Using TBR because this merge had a conflict and needed to fix manually:
TBR=estade@chromium.org,tobiasjs@chromium.org,bsep@chromium.org,mahmadi@chromium.org

(cherry picked from commit 26874dc)

Bug: 913150
Change-Id: Iae7780027932ac530bcb2f0c643be1ec94d1f334
Reviewed-on: https://chromium-review.googlesource.com/c/1314129
Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Commit-Queue: Siyu An <siyua@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#614193}
Reviewed-on: https://chromium-review.googlesource.com/c/1369941
Cr-Commit-Position: refs/branch-heads/3626@{#234}
Cr-Branched-From: d897fb1-refs/heads/master@{#612437}
msisov pushed a commit that referenced this issue Mar 14, 2019
@toji
Removed XRDevice interface
b593337 
This changes the entry point into the WebXR APIs, as described
by the latest spec changes. It makes the concept of which physical
piece of hardware is being used implicit. The CL is unfortunately
large, but that's almost entirely due to the number of tests that the
change affects.

Bug: 916299
Change-Id: I32f2acec810761bbddd1f6df6e8ca91673dd381e
Reviewed-on: https://chromium-review.googlesource.com/c/1383393
Commit-Queue: Brandon Jones <bajones@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#626199}(cherry picked from commit 94e08cd)
Reviewed-on: https://chromium-review.googlesource.com/c/1440907
Reviewed-by: Brandon Jones <bajones@chromium.org>
Cr-Commit-Position: refs/branch-heads/3683@{#26}
Cr-Branched-From: e510299-refs/heads/master@{#625896}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tonikitoo tonikitoo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tonikitoo