Warning fix (issue #15) #25

tonikitoo · 2017-04-04T16:06:36Z

//services/ui/ws/window_tree.h:623:36: warning:
[chromium-style] WeakPtrFactory members which refer to
their outer class must be the last member in the outer class definition.
base::WeakPtrFactory<WindowTree> drag_weak_factory_;

//services/ui/ws/window_tree.h:623:36: warning: [chromium-style] WeakPtrFactory members which refer to their outer class must be the last member in the outer class definition. base::WeakPtrFactory<WindowTree> drag_weak_factory_;

fred-wang

lgtm

fred-wang · 2017-04-05T11:53:45Z

This can land in ozone-wayland-dev I guess.

…(patchset Igalia#2 id:40001 of https://codereview.chromium.org/2790443004/ ) Reason for revert: Fails on msan. https://build.chromium.org/p/chromium.memory.full/builders/Linux%20MSan%20Tests/builds/6793 ==25314==WARNING: MemorySanitizer: use-of-uninitialized-value #0 0x173e79ea in vp8_intra4x4_predict third_party/libvpx/source/libvpx/vp8/common/reconintra4x4.c:64:3 Igalia#1 0x17411f49 in vp8_encode_intra4x4block third_party/libvpx/source/libvpx/vp8/encoder/encodeintra.c:55:3 Igalia#2 0x17080455 in pick_intra4x4block third_party/libvpx/source/libvpx/vp8/encoder/pickinter.c:283:3 Igalia#3 0x17080455 in pick_intra4x4mby_modes third_party/libvpx/source/libvpx/vp8/encoder/pickinter.c:313:0 Igalia#4 0x17083a01 in vp8_pick_intra_mode third_party/libvpx/source/libvpx/vp8/encoder/pickinter.c:1425:14 Igalia#5 0x1740e0b4 in vp8cx_encode_intra_macroblock third_party/libvpx/source/libvpx/vp8/encoder/encodeframe.c:1089:5 Igalia#6 0x1740b8f7 in encode_mb_row third_party/libvpx/source/libvpx/vp8/encoder/encodeframe.c:458:21 Igalia#7 0x17406d89 in vp8_encode_frame third_party/libvpx/source/libvpx/vp8/encoder/encodeframe.c:777:9 Igalia#8 0x17063469 in encode_frame_to_data_rate third_party/libvpx/source/libvpx/vp8/encoder/onyx_if.c:3987:5 Igalia#9 0x17063469 in vp8_get_compressed_data third_party/libvpx/source/libvpx/vp8/encoder/onyx_if.c:5098:0 Igalia#10 0x170280a7 in vp8e_encode third_party/libvpx/source/libvpx/vp8/vp8_cx_iface.c:879:25 Igalia#11 0x1704d1cc in vpx_codec_encode third_party/libvpx/source/libvpx/vpx/src/vpx_encoder.c:209:13 Igalia#12 0x16c10f29 in content::(anonymous namespace)::VpxEncoder::DoEncode(vpx_codec_ctx*, gfx::Size const&, unsigned char*, unsigned char*, int, unsigned char*, int, unsigned char*, int, base::TimeDelta const&, bool, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >*, bool*) content/renderer/media_recorder/video_track_recorder.cc:932:7 Igalia#13 0x16c0da73 in content::(anonymous namespace)::VpxEncoder::EncodeOnEncodingTaskRunner(scoped_refptr<media::VideoFrame>, base::TimeTicks) content/renderer/media_recorder/video_track_recorder.cc:871:3 Igalia#14 0x16c12113 in Invoke<const scoped_refptr<content::VideoTrackRecorder::Encoder> &, const scoped_refptr<media::VideoFrame> &, const base::TimeTicks &> base/bind_internal.h:214:12 Igalia#15 0x16c12113 in MakeItSo<void (content::VideoTrackRecorder::Encoder::*const &)(scoped_refptr<media::VideoFrame>, base::TimeTicks), const scoped_refptr<content::VideoTrackRecorder::Encoder> &, const scoped_refptr<media::VideoFrame> &, const base::TimeTicks &> base/bind_internal.h:285:0 Igalia#16 0x16c12113 in RunImpl<void (content::VideoTrackRecorder::Encoder::*const &)(scoped_refptr<media::VideoFrame>, base::TimeTicks), const std::__1::tuple<scoped_refptr<content::VideoTrackRecorder::Encoder>, scoped_refptr<media::VideoFrame>, base::TimeTicks> &, 0, 1, 2> base/bind_internal.h:361:0 Igalia#17 0x16c12113 in base::internal::Invoker<base::internal::BindState<void (content::VideoTrackRecorder::Encoder::*)(scoped_refptr<media::VideoFrame>, base::TimeTicks), scoped_refptr<content::VideoTrackRecorder::Encoder>, scoped_refptr<media::VideoFrame>, base::TimeTicks>, void ()>::Run(base::internal::BindStateBase*) base/bind_internal.h:339:0 Igalia#18 0xe0651e5 in Run base/callback.h:91:12 Igalia#19 0xe0651e5 in base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) base/debug/task_annotator.cc:59:0 Igalia#20 0xde5cbc3 in base::MessageLoop::RunTask(base::PendingTask*) base/message_loop/message_loop.cc:423:19 Igalia#21 0xde5e5b1 in base::MessageLoop::DeferOrRunPendingTask(base::PendingTask) base/message_loop/message_loop.cc:434:5 Igalia#22 0xde6015e in base::MessageLoop::DoWork() base/message_loop/message_loop.cc:527:13 Igalia#23 0xde6d8d0 in base::MessagePumpDefault::Run(base::MessagePump::Delegate*) base/message_loop/message_pump_default.cc:33:31 Igalia#24 0xde5bc46 in base::MessageLoop::RunHandler() base/message_loop/message_loop.cc:387:10 Igalia#25 0xdede3fc in base::RunLoop::Run() base/run_loop.cc:37:10 Igalia#26 0xdf87aef in base::Thread::ThreadMain() base/threading/thread.cc:333:3 Igalia#27 0xdf70fb5 in base::(anonymous namespace)::ThreadFunc(void*) base/threading/platform_thread_posix.cc:71:13 Igalia#28 0x7f49dc121183 in start_thread /build/eglibc-oGUzwX/eglibc-2.19/nptl/pthread_create.c:312:0 Igalia#29 0x7f49dbc3837c in clone /build/eglibc-oGUzwX/eglibc-2.19/misc/../sysdeps/unix/sysv/linux/x86_64/clone.S:111:0 Uninitialized value was stored to memory at #0 0x1707f3e6 in pick_intra4x4block third_party/libvpx/source/libvpx/vp8/encoder/pickinter.c:282:18 Igalia#1 0x1707f3e6 in pick_intra4x4mby_modes third_party/libvpx/source/libvpx/vp8/encoder/pickinter.c:313:0 Igalia#2 0x17083a01 in vp8_pick_intra_mode third_party/libvpx/source/libvpx/vp8/encoder/pickinter.c:1425:14 Igalia#3 0x1740e0b4 in vp8cx_encode_intra_macroblock third_party/libvpx/source/libvpx/vp8/encoder/encodeframe.c:1089:5 Igalia#4 0x1740b8f7 in encode_mb_row third_party/libvpx/source/libvpx/vp8/encoder/encodeframe.c:458:21 Igalia#5 0x17406d89 in vp8_encode_frame third_party/libvpx/source/libvpx/vp8/encoder/encodeframe.c:777:9 Igalia#6 0x17063469 in encode_frame_to_data_rate third_party/libvpx/source/libvpx/vp8/encoder/onyx_if.c:3987:5 Igalia#7 0x17063469 in vp8_get_compressed_data third_party/libvpx/source/libvpx/vp8/encoder/onyx_if.c:5098:0 Igalia#8 0x170280a7 in vp8e_encode third_party/libvpx/source/libvpx/vp8/vp8_cx_iface.c:879:25 Igalia#9 0x1704d1cc in vpx_codec_encode third_party/libvpx/source/libvpx/vpx/src/vpx_encoder.c:209:13 Igalia#10 0x16c10f29 in content::(anonymous namespace)::VpxEncoder::DoEncode(vpx_codec_ctx*, gfx::Size const&, unsigned char*, unsigned char*, int, unsigned char*, int, unsigned char*, int, base::TimeDelta const&, bool, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >*, bool*) content/renderer/media_recorder/video_track_recorder.cc:932:7 Igalia#11 0x16c0da73 in content::(anonymous namespace)::VpxEncoder::EncodeOnEncodingTaskRunner(scoped_refptr<media::VideoFrame>, base::TimeTicks) content/renderer/media_recorder/video_track_recorder.cc:871:3 Igalia#12 0x16c12113 in Invoke<const scoped_refptr<content::VideoTrackRecorder::Encoder> &, const scoped_refptr<media::VideoFrame> &, const base::TimeTicks &> base/bind_internal.h:214:12 Igalia#13 0x16c12113 in MakeItSo<void (content::VideoTrackRecorder::Encoder::*const &)(scoped_refptr<media::VideoFrame>, base::TimeTicks), const scoped_refptr<content::VideoTrackRecorder::Encoder> &, const scoped_refptr<media::VideoFrame> &, const base::TimeTicks &> base/bind_internal.h:285:0 Igalia#14 0x16c12113 in RunImpl<void (content::VideoTrackRecorder::Encoder::*const &)(scoped_refptr<media::VideoFrame>, base::TimeTicks), const std::__1::tuple<scoped_refptr<content::VideoTrackRecorder::Encoder>, scoped_refptr<media::VideoFrame>, base::TimeTicks> &, 0, 1, 2> base/bind_internal.h:361:0 Igalia#15 0x16c12113 in base::internal::Invoker<base::internal::BindState<void (content::VideoTrackRecorder::Encoder::*)(scoped_refptr<media::VideoFrame>, base::TimeTicks), scoped_refptr<content::VideoTrackRecorder::Encoder>, scoped_refptr<media::VideoFrame>, base::TimeTicks>, void ()>::Run(base::internal::BindStateBase*) base/bind_internal.h:339:0 Igalia#16 0xe0651e5 in Run base/callback.h:91:12 Igalia#17 0xe0651e5 in base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) base/debug/task_annotator.cc:59:0 Igalia#18 0xde5cbc3 in base::MessageLoop::RunTask(base::PendingTask*) base/message_loop/message_loop.cc:423:19 Igalia#19 0xde5e5b1 in base::MessageLoop::DeferOrRunPendingTask(base::PendingTask) base/message_loop/message_loop.cc:434:5 Igalia#20 0xde6015e in base::MessageLoop::DoWork() base/message_loop/message_loop.cc:527:13 Igalia#21 0xde6d8d0 in base::MessagePumpDefault::Run(base::MessagePump::Delegate*) base/message_loop/message_pump_default.cc:33:31 Igalia#22 0xde5bc46 in base::MessageLoop::RunHandler() base/message_loop/message_loop.cc:387:10 Igalia#23 0xdede3fc in base::RunLoop::Run() base/run_loop.cc:37:10 Igalia#24 0xdf87aef in base::Thread::ThreadMain() base/threading/thread.cc:333:3 Igalia#25 0xdf70fb5 in base::(anonymous namespace)::ThreadFunc(void*) base/threading/platform_thread_posix.cc:71:13 Uninitialized value was stored to memory at #0 0x6c3fcb in __msan_memcpy ??:0:0 Igalia#1 0x173dba76 in vp8_copy_mem16x16_c third_party/libvpx/source/libvpx/vp8/common/reconinter.c:28:5 Igalia#2 0x1740b0f7 in encode_mb_row third_party/libvpx/source/libvpx/vp8/encoder/encodeframe.c:418:5 Igalia#3 0x17406d89 in vp8_encode_frame third_party/libvpx/source/libvpx/vp8/encoder/encodeframe.c:777:9 Igalia#4 0x17063469 in encode_frame_to_data_rate third_party/libvpx/source/libvpx/vp8/encoder/onyx_if.c:3987:5 Igalia#5 0x17063469 in vp8_get_compressed_data third_party/libvpx/source/libvpx/vp8/encoder/onyx_if.c:5098:0 Igalia#6 0x170280a7 in vp8e_encode third_party/libvpx/source/libvpx/vp8/vp8_cx_iface.c:879:25 Igalia#7 0x1704d1cc in vpx_codec_encode third_party/libvpx/source/libvpx/vpx/src/vpx_encoder.c:209:13 Igalia#8 0x16c10f29 in content::(anonymous namespace)::VpxEncoder::DoEncode(vpx_codec_ctx*, gfx::Size const&, unsigned char*, unsigned char*, int, unsigned char*, int, unsigned char*, int, base::TimeDelta const&, bool, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >*, bool*) content/renderer/media_recorder/video_track_recorder.cc:932:7 Igalia#9 0x16c0da73 in content::(anonymous namespace)::VpxEncoder::EncodeOnEncodingTaskRunner(scoped_refptr<media::VideoFrame>, base::TimeTicks) content/renderer/media_recorder/video_track_recorder.cc:871:3 Igalia#10 0x16c12113 in Invoke<const scoped_refptr<content::VideoTrackRecorder::Encoder> &, const scoped_refptr<media::VideoFrame> &, const base::TimeTicks &> base/bind_internal.h:214:12 Igalia#11 0x16c12113 in MakeItSo<void (content::VideoTrackRecorder::Encoder::*const &)(scoped_refptr<media::VideoFrame>, base::TimeTicks), const scoped_refptr<content::VideoTrackRecorder::Encoder> &, const scoped_refptr<media::VideoFrame> &, const base::TimeTicks &> base/bind_internal.h:285:0 Igalia#12 0x16c12113 in RunImpl<void (content::VideoTrackRecorder::Encoder::*const &)(scoped_refptr<media::VideoFrame>, base::TimeTicks), const std::__1::tuple<scoped_refptr<content::VideoTrackRecorder::Encoder>, scoped_refptr<media::VideoFrame>, base::TimeTicks> &, 0, 1, 2> base/bind_internal.h:361:0 Igalia#13 0x16c12113 in base::internal::Invoker<base::internal::BindState<void (content::VideoTrackRecorder::Encoder::*)(scoped_refptr<media::VideoFrame>, base::TimeTicks), scoped_refptr<content::VideoTrackRecorder::Encoder>, scoped_refptr<media::VideoFrame>, base::TimeTicks>, void ()>::Run(base::internal::BindStateBase*) base/bind_internal.h:339:0 Igalia#14 0xe0651e5 in Run base/callback.h:91:12 Igalia#15 0xe0651e5 in base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) base/debug/task_annotator.cc:59:0 Igalia#16 0xde5cbc3 in base::MessageLoop::RunTask(base::PendingTask*) base/message_loop/message_loop.cc:423:19 Igalia#17 0xde5e5b1 in base::MessageLoop::DeferOrRunPendingTask(base::PendingTask) base/message_loop/message_loop.cc:434:5 Igalia#18 0xde6015e in base::MessageLoop::DoWork() base/message_loop/message_loop.cc:527:13 Igalia#19 0xde6d8d0 in base::MessagePumpDefault::Run(base::MessagePump::Delegate*) base/message_loop/message_pump_default.cc:33:31 Igalia#20 0xde5bc46 in base::MessageLoop::RunHandler() base/message_loop/message_loop.cc:387:10 Igalia#21 0xdede3fc in base::RunLoop::Run() base/run_loop.cc:37:10 Igalia#22 0xdf87aef in base::Thread::ThreadMain() base/threading/thread.cc:333:3 Igalia#23 0xdf70fb5 in base::(anonymous namespace)::ThreadFunc(void*) base/threading/platform_thread_posix.cc:71:13 Igalia#24 0x7f49dc121183 in start_thread /build/eglibc-oGUzwX/eglibc-2.19/nptl/pthread_create.c:312:0 Uninitialized value was stored to memory at #0 0x6c3fcb in __msan_memcpy ??:0:0 Igalia#1 0x176380f4 in copy_and_extend_plane third_party/libvpx/source/libvpx/vp8/common/extend.c:38:5 Igalia#2 0x176380f4 in vp8_copy_and_extend_frame third_party/libvpx/source/libvpx/vp8/common/extend.c:73:0 Igalia#3 0x174262e5 in vp8_lookahead_push third_party/libvpx/source/libvpx/vp8/encoder/lookahead.c:139:5 Igalia#4 0x1705ceba in vp8_receive_raw_frame third_party/libvpx/source/libvpx/vp8/encoder/onyx_if.c:4817:7 Igalia#5 0x1702745a in vp8e_encode third_party/libvpx/source/libvpx/vp8/vp8_cx_iface.c:863:11 Igalia#6 0x1704d1cc in vpx_codec_encode third_party/libvpx/source/libvpx/vpx/src/vpx_encoder.c:209:13 Igalia#7 0x16c10f29 in content::(anonymous namespace)::VpxEncoder::DoEncode(vpx_codec_ctx*, gfx::Size const&, unsigned char*, unsigned char*, int, unsigned char*, int, unsigned char*, int, base::TimeDelta const&, bool, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >*, bool*) content/renderer/media_recorder/video_track_recorder.cc:932:7 Igalia#8 0x16c0da73 in content::(anonymous namespace)::VpxEncoder::EncodeOnEncodingTaskRunner(scoped_refptr<media::VideoFrame>, base::TimeTicks) content/renderer/media_recorder/video_track_recorder.cc:871:3 Igalia#9 0x16c12113 in Invoke<const scoped_refptr<content::VideoTrackRecorder::Encoder> &, const scoped_refptr<media::VideoFrame> &, const base::TimeTicks &> base/bind_internal.h:214:12 Igalia#10 0x16c12113 in MakeItSo<void (content::VideoTrackRecorder::Encoder::*const &)(scoped_refptr<media::VideoFrame>, base::TimeTicks), const scoped_refptr<content::VideoTrackRecorder::Encoder> &, const scoped_refptr<media::VideoFrame> &, const base::TimeTicks &> base/bind_internal.h:285:0 Igalia#11 0x16c12113 in RunImpl<void (content::VideoTrackRecorder::Encoder::*const &)(scoped_refptr<media::VideoFrame>, base::TimeTicks), const std::__1::tuple<scoped_refptr<content::VideoTrackRecorder::Encoder>, scoped_refptr<media::VideoFrame>, base::TimeTicks> &, 0, 1, 2> base/bind_internal.h:361:0 Igalia#12 0x16c12113 in base::internal::Invoker<base::internal::BindState<void (content::VideoTrackRecorder::Encoder::*)(scoped_refptr<media::VideoFrame>, base::TimeTicks), scoped_refptr<content::VideoTrackRecorder::Encoder>, scoped_refptr<media::VideoFrame>, base::TimeTicks>, void ()>::Run(base::internal::BindStateBase*) base/bind_internal.h:339:0 Igalia#13 0xe0651e5 in Run base/callback.h:91:12 Igalia#14 0xe0651e5 in base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) base/debug/task_annotator.cc:59:0 Igalia#15 0xde5cbc3 in base::MessageLoop::RunTask(base::PendingTask*) base/message_loop/message_loop.cc:423:19 Igalia#16 0xde5e5b1 in base::MessageLoop::DeferOrRunPendingTask(base::PendingTask) base/message_loop/message_loop.cc:434:5 Igalia#17 0xde6015e in base::MessageLoop::DoWork() base/message_loop/message_loop.cc:527:13 Igalia#18 0xde6d8d0 in base::MessagePumpDefault::Run(base::MessagePump::Delegate*) base/message_loop/message_pump_default.cc:33:31 Igalia#19 0xde5bc46 in base::MessageLoop::RunHandler() base/message_loop/message_loop.cc:387:10 Igalia#20 0xdede3fc in base::RunLoop::Run() base/run_loop.cc:37:10 Igalia#21 0xdf87aef in base::Thread::ThreadMain() base/threading/thread.cc:333:3 Igalia#22 0xdf70fb5 in base::(anonymous namespace)::ThreadFunc(void*) base/threading/platform_thread_posix.cc:71:13 Igalia#23 0x7f49dc121183 in start_thread /build/eglibc-oGUzwX/eglibc-2.19/nptl/pthread_create.c:312:0 Uninitialized value was created by a heap allocation #0 0x6c4363 in __interceptor_posix_memalign ??:0:0 Igalia#1 0xde417c9 in base::AlignedAlloc(unsigned long, unsigned long) base/memory/aligned_memory.cc:31:7 Igalia#2 0xfb569fd in media::VideoFrame::AllocateYUV(bool) media/base/video_frame.cc:1205:7 Igalia#3 0xfb4a6ef in media::VideoFrame::CreateFrameInternal(media::VideoPixelFormat, gfx::Size const&, gfx::Rect const&, gfx::Size const&, base::TimeDelta, bool) media/base/video_frame.cc:1064:10 Igalia#4 0xfb49db0 in media::VideoFrame::CreateFrame(media::VideoPixelFormat, gfx::Size const&, gfx::Rect const&, gfx::Size const&, base::TimeDelta) media/base/video_frame.cc:180:10 Igalia#5 0x5865ddd in content::VideoTrackRecorderTest_EncodeFrameWithPaddedCodedSize_Test::TestBody() content/renderer/media_recorder/video_track_recorder_unittest.cc:235:49 Igalia#6 0xd7f73cc in HandleExceptionsInMethodIfSupported<testing::Test, void> testing/gtest/src/gtest.cc:2458:12 Igalia#7 0xd7f73cc in testing::Test::Run() testing/gtest/src/gtest.cc:2474:0 Igalia#8 0xd7f9cbb in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2656:11 Igalia#9 0xd7fb259 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2774:28 Igalia#10 0xd81aefd in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4647:43 Igalia#11 0xd819d8e in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2458:12 Igalia#12 0xd819d8e in testing::UnitTest::Run() testing/gtest/src/gtest.cc:4255:0 Igalia#13 0xb826860 in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2237:46 Igalia#14 0xb826860 in base::TestSuite::Run() base/test/test_suite.cc:271:0 Igalia#15 0xb848b7c in Run base/callback.h:80:12 Igalia#16 0xb848b7c in base::(anonymous namespace)::LaunchUnitTestsInternal(base::Callback<int (), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&, int, int, bool, base::Callback<void (), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&) base/test/launcher/unit_test_launcher.cc:211:0 Igalia#17 0xb8483a6 in base::LaunchUnitTests(int, char**, base::Callback<int (), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&) base/test/launcher/unit_test_launcher.cc:453:10 Igalia#18 0x4f826f6 in main content/test/run_all_unittests.cc:20:10 Igalia#19 0x7f49dbb5ff44 in __libc_start_main /build/eglibc-oGUzwX/eglibc-2.19/csu/libc-start.c:287:0 Original issue's description: > Copy based on coded size in VideoTrackRecorder::VEAEncoder > > This Cl addresses the below bug making sure that input frame's > coded size is compared to VEA's requested and frame is copied > when necessary. > > BUG=705273 > TEST=The given bug is fixed and added unittests. > > Review-Url: https://codereview.chromium.org/2790443004 > Cr-Commit-Position: refs/heads/master@{#460897} > Committed: https://chromium.googlesource.com/chromium/src/+/68c20537e9ecd5715ffe280091c37fc6aa0a70f6 TBR=mcasas@chromium.org,emircan@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=705273 Review-Url: https://codereview.chromium.org/2785393002 Cr-Commit-Position: refs/heads/master@{#460975}

…metry change (patchset #25 id:480001 of https://codereview.chromium.org/2732573003/ ) Reason for revert: Looks like this is making tests fail on most builders, e.g. https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty/builds/25101 Original issue's description: > Skip paint property update and visual rect update if no geometry change > > This avoids unnecessary visual rect computation and update of paint > offset related paint properties. > > BUG=697081,685179 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > > Review-Url: https://codereview.chromium.org/2732573003 > Cr-Commit-Position: refs/heads/master@{#461348} > Committed: https://chromium.googlesource.com/chromium/src/+/81f28ed19f771fe93406496d1d23da137abcd602 TBR=pdr@chromium.org,chrishtr@chromium.org,wangxianzhu@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=697081,685179 Review-Url: https://codereview.chromium.org/2792863002 Cr-Commit-Position: refs/heads/master@{#461357}

…://codereview.chromium.org/2793993003/ ) Reason for revert: Broke blink_platform_unittests on WebKit Linux Trusty (dbg) https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty%20%28dbg%29 failed 20 Run on OS: 'Ubuntu-14.04' failures: GeometryMapperTest.FilterWithClipsAndTransforms GeometryMapperTest.RoundedClip GeometryMapperTest.TwoClipsWithTransformBetween GeometryMapperTest.Root GeometryMapperTest.ClipAfterTransform GeometryMapperTest.TwoClipsTransformAbove GeometryMapperTest.ReflectionWithPaintOffset GeometryMapperTest.SimpleClip GeometryMapperTest.SiblingTransforms GeometryMapperTest.RotationAndScaleTransform GeometryMapperTest.NestedTransformsScaleAndTranslation GeometryMapperTest.TranslationTransform GeometryMapperTest.NestedTransformsIntermediateDestination GeometryMapperTest.SiblingTransformsWithClip GeometryMapperTest.NestedTransformsFlattening GeometryMapperTest.RotationAndScaleTransformWithTransformOrigin GeometryMapperTest.TwoClips GeometryMapperTest.IdentityTransform GeometryMapperTest.NestedTransforms GeometryMapperTest.ClipBeforeTransform Sample stack trace: [ RUN ] GeometryMapperTest.ClipAfterTransform ../../build/linux/debian_jessie_amd64-sysroot/usr/lib/gcc/x86_64-linux-gnu/4.8/../../../../include/c++/4.8/bits/unique_ptr.h:228: std::unique_ptr::pointer std::unique_ptr<blink::GeometryMapper, std::default_delete<blink::GeometryMapper> >::operator->() const [_Tp = blink::GeometryMapper, _Dp = std::default_delete<blink::GeometryMapper>]: Assertion 'get() != pointer()' failed. Received signal 6 #0 0x7fe3a88626bb base::debug::StackTrace::StackTrace() #1 0x7fe3a88613bc base::debug::StackTrace::StackTrace() #2 0x7fe3a88621cf base::debug::(anonymous namespace)::StackDumpSignalHandler() #3 0x7fe3a9d72330 <unknown> #4 0x7fe3a42cbc37 gsignal #5 0x7fe3a42cf028 abort #6 0x000000566ccf std::__replacement_assert() #7 0x0000007706d6 std::unique_ptr<>::operator->() #8 0x00000075a4b0 blink::GeometryMapperTest_ClipAfterTransform_Test::TestBody() #9 0x000000eee60e testing::internal::HandleSehExceptionsInMethodIfSupported<>() #10 0x000000ede742 testing::internal::HandleExceptionsInMethodIfSupported<>() #11 0x000000ed3216 testing::Test::Run() #12 0x000000ed39cd testing::TestInfo::Run() #13 0x000000ed3f6f testing::TestCase::Run() #14 0x000000ed92dc testing::internal::UnitTestImpl::RunAllTests() #15 0x000000ef259e testing::internal::HandleSehExceptionsInMethodIfSupported<>() #16 0x000000edffd2 testing::internal::HandleExceptionsInMethodIfSupported<>() #17 0x000000ed8f7f testing::UnitTest::Run() #18 0x000000e2c431 RUN_ALL_TESTS() #19 0x000000e2b2d2 base::TestSuite::Run() #20 0x000000a36565 (anonymous namespace)::runTestSuite() #21 0x0000005e3a6a _ZN4base8internal13FunctorTraitsIPFvPiEvE6InvokeIJS2_EEEvS4_DpOT_ #22 0x000000a36858 _ZN4base8internal12InvokeHelperILb0EiE8MakeItSoIRKPFiPNS_9TestSuiteEEJS5_EEEiOT_DpOT0_ #23 0x000000a36817 _ZN4base8internal7InvokerINS0_9BindStateIPFiPNS_9TestSuiteEEJNS0_17UnretainedWrapperIS3_EEEEEFivEE7RunImplIRKS6_RKSt5tupleIJS8_EEJLm0EEEEiOT_OT0_NS_13IndexSequenceIJXspT1_EEEE #24 0x000000a3675c _ZN4base8internal7InvokerINS0_9BindStateIPFiPNS_9TestSuiteEEJNS0_17UnretainedWrapperIS3_EEEEEFivEE3RunEPNS0_13BindStateBaseE #25 0x00000082056d _ZNKR4base8CallbackIFvvELNS_8internal8CopyModeE1ELNS2_10RepeatModeE1EE3RunEv #26 0x000000e50a16 base::(anonymous namespace)::LaunchUnitTestsInternal() #27 0x000000e50884 base::LaunchUnitTests() #28 0x000000a364c1 main #29 0x7fe3a42b6f45 __libc_start_main #30 0x00000052eb84 <unknown> r8: 29287265746e696f r9: 696c623c6574656c r10: 0000000000000008 r11: 0000000000000206 r12: 000000000052eb5b r13: 00007ffd79a846a0 r14: 0000000000000000 r15: 0000000000000000 di: 0000000000006c05 si: 0000000000006c05 bp: 00007ffd79a82540 bx: 0000000000000000 dx: 0000000000000006 ax: 0000000000000000 cx: ffffffffffffffff sp: 00007ffd79a823d8 ip: 00007fe3a42cbc37 efl: 0000000000000206 cgf: 0000000000000033 erf: 0000000000000000 trp: 0000000000000000 msk: 0000000000000000 cr2: 0000000000000000 [end of stack trace] Calling _exit(1). Core file will not be generated. Original issue's description: > Make GeometryMapper fully static. > > Now that the cache for GeometryMapper is not stored on that object, > we don't really need to allocate GeometryMapper objects at all. This > change lets us avoid the cost and plumbing complexity of such objects. > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > > Review-Url: https://codereview.chromium.org/2793993003 > Cr-Commit-Position: refs/heads/master@{#461510} > Committed: https://chromium.googlesource.com/chromium/src/+/0be71969c80ff018be92afb6bba2076bf3c1f55f TBR=haraken@chromium.org,pdr@chromium.org,wangxianzhu@chromium.org,keishi@chromium.org,chrishtr@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2798513002 Cr-Commit-Position: refs/heads/master@{#461620}

…metry change (patchset #1 id:1 of https://codereview.chromium.org/2792863002/ ) Reland after https://codereview.chromium.org/2791933003/ which fixed the layout test failures (about overflow recalc). Also fixed a bug of false-negative of visual rect change in FindPaintOffsetAndVisualRectNeedingUpdate.h. Original issue's description: > Revert of Skip paint property update and visual rect update if no geometry change (patchset #25 id:480001 of https://codereview.chromium.org/2732573003/ ) > > Reason for revert: > Looks like this is making tests fail on most builders, e.g. > > https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty/builds/25101 > > Original issue's description: > > Skip paint property update and visual rect update if no geometry change > > > > This avoids unnecessary visual rect computation and update of paint > > offset related paint properties. > > > > BUG=697081,685179 > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > > > > Review-Url: https://codereview.chromium.org/2732573003 > > Cr-Commit-Position: refs/heads/master@{#461348} > > Committed: https://chromium.googlesource.com/chromium/src/+/81f28ed19f771fe93406496d1d23da137abcd602 > > TBR=pdr@chromium.org,chrishtr@chromium.org,wangxianzhu@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=697081,685179 > > Review-Url: https://codereview.chromium.org/2792863002 > Cr-Commit-Position: refs/heads/master@{#461357} > Committed: https://chromium.googlesource.com/chromium/src/+/6d954094c746673d37970ab1321e810622c8fd49 TBR=pdr@chromium.org BUG=697081,685179 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2792063002 Cr-Commit-Position: refs/heads/master@{#461885}

…001 of https://codereview.chromium.org/2823043002/ ) Reason for revert: Seems to be causing several tests to fail: https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/24975 Failure output: ../../build/linux/debian_jessie_amd64-sysroot/usr/lib/gcc/x86_64-linux-gnu/4.8/../../../../include/c++/4.8/debug/safe_iterator.210: error: attempt to construct a constant iterator from a singular mutable iterator. Objects involved in the operation: iterator "this" @ 0x0x7fff97b205a0 { state = dereferenceable; references sequence @ 0x0x7fff97b205a0 } iterator "other" @ 0x0x7fff97b20878 { state = singular; references sequence @ 0x0x7fff97b20878 } Received signal 6 #0 0x7f0cbdddb56b base::debug::StackTrace::StackTrace() Igalia#1 0x7f0cbddda2ac base::debug::StackTrace::StackTrace() Igalia#2 0x7f0cbdddb07f base::debug::(anonymous namespace)::StackDumpSignalHandler() Igalia#3 0x7f0cbe22f330 <unknown> Igalia#4 0x7f0ca248ac37 gsignal Igalia#5 0x7f0ca248e028 abort Igalia#6 0x7f0ca2adffe5 __gnu_debug::_Error_formatter::_M_error() Igalia#7 0x7f0cb26be3ad _ZN11__gnu_debug14_Safe_iteratorIN9__gnu_cxx17__normal_iteratorIPKN2cc9SurfaceIdENSt9__cxx19986vectorIS4_SaIS4_EEEEENSt7__debug6vectorIS4_S9_EEEC2INS2_IPS4_SA_EEEERKNS0_IT_NS1_11__enable_ifIXsr3std10__are_sameISJ_SI_EE7__valueESE_E6__typeEEE Igalia#8 0x7f0cb26ce1de cc::SurfaceAggregator::HandleSurfaceQuad() Igalia#9 0x7f0cb26ce94f cc::SurfaceAggregator::CopyQuadsToPass() Igalia#10 0x7f0cb26cf76e cc::SurfaceAggregator::CopyPasses() Igalia#11 0x7f0cb26d1df6 cc::SurfaceAggregator::Aggregate() Igalia#12 0x7f0cb268aacc cc::Display::DrawAndSwap() Igalia#13 0x7f0cb269c3ab cc::DisplayScheduler::DrawAndSwap() Igalia#14 0x7f0cb269baf6 cc::DisplayScheduler::AttemptDrawAndSwap() Igalia#15 0x7f0cb269b3ef cc::DisplayScheduler::OnBeginFrameDeadline() Igalia#16 0x7f0cb269c92b cc::DisplayScheduler::OnBeginFrameDerivedImpl() Igalia#17 0x7f0cb2f1b179 cc::BeginFrameObserverBase::OnBeginFrame() Igalia#18 0x7f0cb2f1cd96 cc::DelayBasedBeginFrameSource::OnTimerTick() Igalia#19 0x7f0cb2f34d1a cc::DelayBasedTimeSource::OnTimerTick() Igalia#20 0x7f0cb2d90107 _ZN4base8internal13FunctorTraitsIMN2cc28ScrollbarAnimationControllerEFvvEvE6InvokeIRKNS_7WeakPtrIS3_EEJEEEvS5_OT_DpOT0_ Igalia#21 0x7f0cb2f354da _ZN4base8internal12InvokeHelperILb1EvE8MakeItSoIRKMN2cc20DelayBasedTimeSourceEFvvERKNS_7WeakPtrIS5_EEJEEEvOT_OT0_DpOT1_ Igalia#22 0x7f0cb2f35462 _ZN4base8internal7InvokerINS0_9BindStateIMN2cc20DelayBasedTimeSourceEFvvEJNS_7WeakPtrIS4_EEEEEFvvEE7RunImplIRKS6_RKSt5tupleIJS8_EEJLm0EEEEvOT_OT0_NS_13IndexSequenceIJXspT1_EEEE Igalia#23 0x7f0cb2f353ac _ZN4base8internal7InvokerINS0_9BindStateIMN2cc20DelayBasedTimeSourceEFvvEJNS_7WeakPtrIS4_EEEEEFvvEE3RunEPNS0_13BindStateBaseE Igalia#24 0x7f0cb2d9044d _ZNKR4base8CallbackIFvvELNS_8internal8CopyModeE1ELNS2_10RepeatModeE1EE3RunEv Igalia#25 0x7f0cb2d8fe29 base::CancelableCallback<>::Forward() Igalia#26 0x7f0cb2d90107 _ZN4base8internal13FunctorTraitsIMN2cc28ScrollbarAnimationControllerEFvvEvE6InvokeIRKNS_7WeakPtrIS3_EEJEEEvS5_OT_DpOT0_ Igalia#27 0x7f0cb2d9005a _ZN4base8internal12InvokeHelperILb1EvE8MakeItSoIRKMNS_18CancelableCallbackIFvvEEEKFvvERKNS_7WeakPtrIS6_EEJEEEvOT_OT0_DpOT1_ Igalia#28 0x7f0cb2d8ffe2 _ZN4base8internal7InvokerINS0_9BindStateIMNS_18CancelableCallbackIFvvEEEKFvvEJNS_7WeakPtrIS5_EEEEES4_E7RunImplIRKS7_RKSt5tupleIJS9_EEJLm0EEEEvOT_OT0_NS_13IndexSequenceIJXspT1_EEEE Igalia#29 0x7f0cb2d8ff2c _ZN4base8internal7InvokerINS0_9BindStateIMNS_18CancelableCallbackIFvvEEEKFvvEJNS_7WeakPtrIS5_EEEEES4_E3RunEPNS0_13BindStateBaseE Igalia#30 0x7f0cbdde126e _ZNO4base8CallbackIFvvELNS_8internal8CopyModeE0ELNS2_10RepeatModeE0EE3RunEv Igalia#31 0x7f0cbdde0a61 base::debug::TaskAnnotator::RunTask() Igalia#32 0x7f0cbde68f1e base::MessageLoop::RunTask() Igalia#33 0x7f0cbde69184 base::MessageLoop::DeferOrRunPendingTask() Igalia#34 0x7f0cbde6970c base::MessageLoop::DoDelayedWork() Igalia#35 0x7f0cbde7ee68 base::MessagePumpGlib::Run() Igalia#36 0x7f0cbde68b02 base::MessageLoop::RunHandler() Igalia#37 0x7f0cbdf02a64 base::RunLoop::Run() Igalia#38 0x000004f3de76 content::RunThisRunLoop() Igalia#39 0x0000089f1d0e extensions::ResultCatcher::GetNextResult() Igalia#40 0x000001657c6c ExtensionApiTest::RunExtensionTestImpl() Igalia#41 0x000001657685 ExtensionApiTest::RunExtensionTest() Igalia#42 0x000000d8d146 extensions::ContentScriptApiTest_ContentScriptExtensionIframe_Test::RunTestOnMainThread() Igalia#43 0x000003db23d5 InProcessBrowserTest::RunTestOnMainThreadLoop() Igalia#44 0x000004eb9764 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() Igalia#45 0x00000093c845 _ZN4base8internal13FunctorTraitsIM25RenderViewContextMenuBaseFvvEvE6InvokeIP21RenderViewContextMenuJEEEvS4_OT_DpOT0_ Igalia#46 0x00000093c761 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIRKM25RenderViewContextMenuBaseFvvEJP21RenderViewContextMenuEEEvOT_DpOT0_ Igalia#47 0x000004eba6a7 _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserTestBaseEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE7RunImplIRKS6_RKSt5tupleIJS8_EEJLm0EEEEvOT_OT0_NS_13IndexSequenceIJXspT1_EEEE Igalia#48 0x000004eba5ec _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserTestBaseEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE3RunEPNS0_13BindStateBaseE Igalia#49 0x00000092405d _ZNKR4base8CallbackIFvvELNS_8internal8CopyModeE1ELNS2_10RepeatModeE1EE3RunEv Igalia#50 0x000003e5880e ChromeBrowserMainParts::PreMainMessageLoopRunImpl() Igalia#51 0x000003e57450 ChromeBrowserMainParts::PreMainMessageLoopRun() Igalia#52 0x000001e20bab chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() Igalia#53 0x7f0cb55d2931 content::BrowserMainLoop::PreMainMessageLoopRun() Igalia#54 0x7f0cb48e4af5 _ZN4base8internal13FunctorTraitsIMN7content13URLLoaderImplEFvvEvE6InvokeIPS3_JEEEvS5_OT_DpOT0_ Igalia#55 0x7f0cb55dbae1 _ZN4base8internal12InvokeHelperILb0EiE8MakeItSoIRKMN7content15BrowserMainLoopEFivEJPS5_EEEiOT_DpOT0_ Igalia#56 0x7f0cb55dba87 _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserMainLoopEFivEJNS0_17UnretainedWrapperIS4_EEEEEFivEE7RunImplIRKS6_RKSt5tupleIJS8_EEJLm0EEEEiOT_OT0_NS_13IndexSequenceIJXspT1_EEEE Igalia#57 0x7f0cb55db9cc _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserMainLoopEFivEJNS0_17UnretainedWrapperIS4_EEEEEFivEE3RunEPNS0_13BindStateBaseE Igalia#58 0x7f0cb48cb4bd _ZNKR4base8CallbackIFvvELNS_8internal8CopyModeE1ELNS2_10RepeatModeE1EE3RunEv Igalia#59 0x7f0cb60e53cb content::StartupTaskRunner::RunAllTasksNow() Igalia#60 0x7f0cb55d0530 content::BrowserMainLoop::CreateStartupTasks() Igalia#61 0x7f0cb55ded17 content::BrowserMainRunnerImpl::Initialize() r8: 00007f0ca28149d0 r9: 00007fff97b1ff98 r10: 0000000000000008 r11: 0000000000000202 r12: 0000000000000002 r13: 00007fff97b28ea0 r14: 0000000000000000 r15: 0000000000000000 di: 000000000000266d si: 000000000000266d bp: 00007fff97b20278 bx: 00007fff97b201f8 dx: 0000000000000006 ax: 0000000000000000 cx: ffffffffffffffff sp: 00007fff97b1ffe8 ip: 00007f0ca248ac37 efl: 0000000000000202 cgf: 0000000000000033 erf: 0000000000000000 trp: 0000000000000000 msk: 0000000000000000 cr2: 0000000000000000 [end of stack trace] Original issue's description: > Use flat_set in SurfaceAggregator. > > The sets and maks are typically small or empty and created once. flat_set and > flat_map will have better performance for these workloads. > > See the bug for histograms of sizes. > > BUG=712295 > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel > > Review-Url: https://codereview.chromium.org/2823043002 > Cr-Commit-Position: refs/heads/master@{#465040} > Committed: https://chromium.googlesource.com/chromium/src/+/95286bcd87997785c90c4194d65a430d082bc784 TBR=jbauman@chromium.org,brettw@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=712295 Review-Url: https://codereview.chromium.org/2824953002 Cr-Commit-Position: refs/heads/master@{#465068}

This reverts commit d09047b. Reason for revert: This CL breaks Linux Trusty MSAN bot. See https://luci-milo.appspot.com/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20MSAN/2350 and successive builds. Sample logs: 17:44:44.594 32438 ==1:1==WARNING: MemorySanitizer: use-of-uninitialized-value 17:44:44.594 32438 #0 0xf548000 in blink::LayoutTableCell::ShouldClipOverflow() const third_party/WebKit/Source/core/layout/LayoutTableCell.cpp:459:35 17:44:44.594 32438 Igalia#1 0xfdd1161 in NeedsOverflowClip third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp:803:48 17:44:44.594 32438 Igalia#2 0xfdd1161 in UpdatePaintProperties third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp:1208:0 17:44:44.594 32438 Igalia#3 0xfdd1161 in blink::PaintPropertyTreeBuilder::UpdatePropertiesForSelf(blink::LayoutObject const&, blink::PaintPropertyTreeBuilderContext&) third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp:1244:0 17:44:44.594 32438 Igalia#4 0xfd6963c in blink::PrePaintTreeWalk::Walk(blink::LayoutObject const&, blink::PrePaintTreeWalkContext const&) third_party/WebKit/Source/core/paint/PrePaintTreeWalk.cpp:190:28 17:44:44.594 32438 Igalia#5 0xfd6a1bb in blink::PrePaintTreeWalk::Walk(blink::LayoutObject const&, blink::PrePaintTreeWalkContext const&) third_party/WebKit/Source/core/paint/PrePaintTreeWalk.cpp:215:5 17:44:44.594 32438 Igalia#6 0xfd6a1bb in blink::PrePaintTreeWalk::Walk(blink::LayoutObject const&, blink::PrePaintTreeWalkContext const&) third_party/WebKit/Source/core/paint/PrePaintTreeWalk.cpp:215:5 17:44:44.594 32438 Igalia#7 0xfd6a1bb in blink::PrePaintTreeWalk::Walk(blink::LayoutObject const&, blink::PrePaintTreeWalkContext const&) third_party/WebKit/Source/core/paint/PrePaintTreeWalk.cpp:215:5 17:44:44.594 32438 Igalia#8 0xfd6a1bb in blink::PrePaintTreeWalk::Walk(blink::LayoutObject const&, blink::PrePaintTreeWalkContext const&) third_party/WebKit/Source/core/paint/PrePaintTreeWalk.cpp:215:5 17:44:44.594 32438 Igalia#9 0xfd68046 in blink::PrePaintTreeWalk::Walk(blink::LocalFrameView&, blink::PrePaintTreeWalkContext const&) third_party/WebKit/Source/core/paint/PrePaintTreeWalk.cpp:92:5 17:44:44.594 32438 Igalia#10 0xfd674b4 in blink::PrePaintTreeWalk::Walk(blink::LocalFrameView&) third_party/WebKit/Source/core/paint/PrePaintTreeWalk.cpp:66:3 17:44:44.594 32438 Igalia#11 0xe513327 in blink::LocalFrameView::PrePaint() third_party/WebKit/Source/core/frame/LocalFrameView.cpp:3255:24 17:44:44.594 32438 Igalia#12 0xe50d013 in blink::LocalFrameView::UpdateLifecyclePhasesInternal(blink::DocumentLifecycle::LifecycleState) third_party/WebKit/Source/core/frame/LocalFrameView.cpp:3186:9 17:44:44.594 32438 Igalia#13 0xfb2ff7c in blink::PageAnimator::UpdateAllLifecyclePhases(blink::LocalFrame&) third_party/WebKit/Source/core/page/PageAnimator.cpp:100:9 17:44:44.594 32438 Igalia#14 0x1451947d in blink::WebViewImpl::UpdateAllLifecyclePhases() third_party/WebKit/Source/core/exported/WebViewImpl.cpp:1984:3 17:44:44.594 32438 Igalia#15 0x6b9e8bb in content::BlinkTestRunner::TestFinished() content/shell/renderer/layout_test/blink_test_runner.cc:606:11 17:44:44.594 32438 Igalia#16 0x11d957ed in test_runner::TestRunner::WorkQueue::ProcessWorkSoon() content/shell/test_runner/test_runner.cc:1572:29 17:44:44.595 32438 Igalia#17 0x11d9db51 in LocationChangeDone content/shell/test_runner/test_runner.cc:2819:17 17:44:44.595 32438 Igalia#18 0x11d9db51 in test_runner::TestRunner::tryToClearTopLoadingFrame(blink::WebFrame*) content/shell/test_runner/test_runner.cc:1951:0 17:44:44.595 32438 Igalia#19 0xf9a560e in blink::ProgressTracker::ProgressCompleted() third_party/WebKit/Source/core/loader/ProgressTracker.cpp:122:26 17:44:44.595 32438 Igalia#20 0xf94bfe5 in blink::FrameLoader::DidFinishNavigation() third_party/WebKit/Source/core/loader/FrameLoader.cpp:478:24 17:44:44.595 32438 Igalia#21 0xdbf17f7 in blink::Document::CheckCompleted() third_party/WebKit/Source/core/dom/Document.cpp:3234:20 17:44:44.595 32438 Igalia#22 0xf94b490 in blink::FrameLoader::FinishedParsing() third_party/WebKit/Source/core/loader/FrameLoader.cpp:448:26 17:44:44.595 32438 Igalia#23 0xdc2c180 in blink::Document::FinishedParsing() third_party/WebKit/Source/core/dom/Document.cpp:5636:21 17:44:44.595 32438 Igalia#24 0x10359be3 in blink::XMLDocumentParser::end() third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp:413:18 17:44:44.595 32438 Igalia#25 0xf9134e4 in blink::DocumentWriter::end() third_party/WebKit/Source/core/loader/DocumentWriter.cpp:109:12 17:44:44.595 32438 Igalia#26 0xf8f9e7f in EndWriting third_party/WebKit/Source/core/loader/DocumentLoader.cpp:896:12 17:44:44.595 32438 Igalia#27 0xf8f9e7f in blink::DocumentLoader::FinishedLoading(double) third_party/WebKit/Source/core/loader/DocumentLoader.cpp:455:0 17:44:44.595 32438 Igalia#28 0x45cfb05 in blink::Resource::CheckNotify() third_party/WebKit/Source/platform/loader/fetch/Resource.cpp:336:8 17:44:44.595 32438 Igalia#29 0x46125d0 in blink::ResourceFetcher::HandleLoaderFinish(blink::Resource*, double, blink::ResourceFetcher::LoaderFinishType) third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp:1333:15 17:44:44.595 32438 Igalia#30 0x1375febb in content::WebURLLoaderImpl::Context::OnCompletedRequest(int, bool, bool, base::TimeTicks const&, long, long, long) content/child/web_url_loader_impl.cc:904:16 17:44:44.595 32438 Igalia#31 0xc0c93f5 in content::ResourceDispatcher::OnRequestComplete(int, content::ResourceRequestCompletionStatus const&) content/child/resource_dispatcher.cc:374:9 17:44:44.595 32438 Igalia#32 0xc0d0e07 in DispatchToMethodImpl<content::ResourceDispatcher *, void (content::ResourceDispatcher::*)(int, const content::ResourceRequestCompletionStatus &), const std::__1::tuple<int, content::ResourceRequestCompletionStatus> &, 0, 1> base/tuple.h:77:3 17:44:44.595 32438 Igalia#33 0xc0d0e07 in DispatchToMethod<content::ResourceDispatcher *, void (content::ResourceDispatcher::*)(int, const content::ResourceRequestCompletionStatus &), const std::__1::tuple<int, content::ResourceRequestCompletionStatus> &> base/tuple.h:84:0 17:44:44.595 32438 Igalia#34 0xc0d0e07 in DispatchToMethod<content::ResourceDispatcher, void (content::ResourceDispatcher::*)(int, const content::ResourceRequestCompletionStatus &), void, std::__1::tuple<int, content::ResourceRequestCompletionStatus> > ipc/ipc_message_templates.h:26:0 17:44:44.595 32438 Igalia#35 0xc0d0e07 in bool IPC::MessageT<ResourceMsg_RequestComplete_Meta, std::__1::tuple<int, content::ResourceRequestCompletionStatus>, void>::Dispatch<content::ResourceDispatcher, content::ResourceDispatcher, void, void (content::ResourceDispatcher::*)(int, content::ResourceRequestCompletionStatus const&)>(IPC::Message const*, content::ResourceDispatcher*, content::ResourceDispatcher*, void*, void (content::ResourceDispatcher::*)(int, content::ResourceRequestCompletionStatus const&)) ipc/ipc_message_templates.h:121:0 17:44:44.595 32438 Igalia#36 0xc0bfe8a in content::ResourceDispatcher::DispatchMessage(IPC::Message const&) content/child/resource_dispatcher.cc:535:5 17:44:44.595 32438 Igalia#37 0xc0bd497 in content::ResourceDispatcher::OnMessageReceived(IPC::Message const&) content/child/resource_dispatcher.cc:136:3 17:44:44.595 32438 Igalia#38 0xc0d86f9 in content::ResourceSchedulingFilter::DispatchMessage(IPC::Message const&) content/child/resource_scheduling_filter.cc:74:27 17:44:44.595 32438 Igalia#39 0x6c8e490 in Run base/callback.h:91:12 17:44:44.595 32438 Igalia#40 0x6c8e490 in base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) base/debug/task_annotator.cc:59:0 17:44:44.595 32438 Igalia#41 0x46c2540 in blink::scheduler::TaskQueueManager::ProcessTaskFromWorkQueue(blink::scheduler::internal::WorkQueue*, bool, blink::scheduler::LazyNow, base::TimeTicks*) third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.cc:532:19 17:44:44.595 32438 Igalia#42 0x46b600a in blink::scheduler::TaskQueueManager::DoWork(bool) third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.cc:330:13 17:44:44.595 32438 Igalia#43 0x6c8e490 in Run base/callback.h:91:12 17:44:44.595 32438 Igalia#44 0x6c8e490 in base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) base/debug/task_annotator.cc:59:0 17:44:44.595 32438 Igalia#45 0x6d1f88e in base::MessageLoop::RunTask(base::PendingTask*) base/message_loop/message_loop.cc:404:19 17:44:44.595 32438 Igalia#46 0x6d22ad9 in base::MessageLoop::DeferOrRunPendingTask(base::PendingTask) base/message_loop/message_loop.cc:415:5 17:44:44.595 32438 Igalia#47 0x6d23ad6 in base::MessageLoop::DoWork() base/message_loop/message_loop.cc:522:13 17:44:44.595 32438 Igalia#48 0x6d3023a in base::MessagePumpDefault::Run(base::MessagePump::Delegate*) base/message_loop/message_pump_default.cc:33:31 17:44:44.595 32438 Igalia#49 0x6dbef5b in base::RunLoop::Run() base/run_loop.cc:112:14 17:44:44.595 32438 Igalia#50 0x113da4bf in content::RendererMain(content::MainFunctionParams const&) content/renderer/renderer_main.cc:219:23 17:44:44.595 32438 Igalia#51 0x4821509 in content::RunZygote(content::MainFunctionParams const&, content::ContentMainDelegate*) content/app/content_main_runner.cc:337:14 17:44:44.595 32438 Igalia#52 0x48240fa in content::RunNamedProcessTypeMain(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, content::MainFunctionParams const&, content::ContentMainDelegate*) content/app/content_main_runner.cc:416:12 17:44:44.595 32438 Igalia#53 0x4826d77 in content::ContentMainRunnerImpl::Run() content/app/content_main_runner.cc:687:12 17:44:44.595 32438 Igalia#54 0xbfb00ba in service_manager::Main(service_manager::MainParams const&) services/service_manager/embedder/main.cc:469:29 17:44:44.595 32438 Igalia#55 0x16265ee in content::ContentMain(content::ContentMainParams const&) content/app/content_main.cc:19:10 17:44:44.595 32438 Igalia#56 0x4a904f in main content/shell/app/shell_main.cc:48:10 17:44:44.595 32438 Igalia#57 0x7fa0d53baf44 in __libc_start_main /build/eglibc-SvCtMH/eglibc-2.19/csu/libc-start.c:287:0 17:44:44.595 32438 Igalia#58 0x43cf9a in _start ??:0:0 17:44:44.595 32438 17:44:44.595 32438 Uninitialized value was stored to memory at 17:44:44.596 32438 #0 0xf5430fb in SetCellWidthChanged third_party/WebKit/Source/core/layout/LayoutTableCell.h:235:65 17:44:44.596 32438 Igalia#1 0xf5430fb in blink::LayoutTableCell::UpdateLayout() third_party/WebKit/Source/core/layout/LayoutTableCell.cpp:327:0 17:44:44.596 32438 Igalia#2 0xf59d164 in LayoutIfNeeded third_party/WebKit/Source/core/layout/LayoutObject.h:1110:7 17:44:44.596 32438 Igalia#3 0xf59d164 in blink::LayoutTableSection::LayoutRows() third_party/WebKit/Source/core/layout/LayoutTableSection.cpp:1252:0 17:44:44.596 32438 Igalia#4 0xf524b1c in blink::LayoutTable::UpdateLayout() third_party/WebKit/Source/core/layout/LayoutTable.cpp:717:16 17:44:44.596 32438 Igalia#5 0xf185d49 in LayoutIfNeeded third_party/WebKit/Source/core/layout/LayoutObject.h:1110:7 17:44:44.596 32438 Igalia#6 0xf185d49 in blink::LayoutBlock::LayoutPositionedObject(blink::LayoutBox*, bool, blink::LayoutBlock::PositionedLayoutBehavior) third_party/WebKit/Source/core/layout/LayoutBlock.cpp:828:0 17:44:44.596 32438 Igalia#7 0xf184ef7 in blink::LayoutBlock::LayoutPositionedObjects(bool, blink::LayoutBlock::PositionedLayoutBehavior) third_party/WebKit/Source/core/layout/LayoutBlock.cpp:773:5 17:44:44.596 32438 Igalia#8 0xf1b1e0e in blink::LayoutBlockFlow::UpdateBlockLayout(bool) third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp:485:3 17:44:44.596 32438 Igalia#9 0xf17eb46 in blink::LayoutBlock::UpdateLayout() third_party/WebKit/Source/core/layout/LayoutBlock.cpp:427:3 17:44:44.596 32438 Igalia#10 0xf645987 in LayoutContent third_party/WebKit/Source/core/layout/LayoutView.cpp:224:20 17:44:44.596 32438 Igalia#11 0xf645987 in blink::LayoutView::UpdateLayout() third_party/WebKit/Source/core/layout/LayoutView.cpp:316:0 17:44:44.596 32438 Igalia#12 0xe4eadff in blink::LocalFrameView::PerformLayout(bool) third_party/WebKit/Source/core/frame/LocalFrameView.cpp:1082:22 17:44:44.596 32438 Igalia#13 0xe4dee95 in blink::LocalFrameView::UpdateLayout() third_party/WebKit/Source/core/frame/LocalFrameView.cpp:1265:10 17:44:44.596 32438 Igalia#14 0xdbf2315 in blink::Document::ImplicitClose() third_party/WebKit/Source/core/dom/Document.cpp:3155:15 17:44:44.596 32438 Igalia#15 0xdbf1070 in blink::Document::CheckCompleted() third_party/WebKit/Source/core/dom/Document.cpp:3212:5 17:44:44.596 32438 Igalia#16 0xf94b490 in blink::FrameLoader::FinishedParsing() third_party/WebKit/Source/core/loader/FrameLoader.cpp:448:26 17:44:44.596 32438 Igalia#17 0xdc2c180 in blink::Document::FinishedParsing() third_party/WebKit/Source/core/dom/Document.cpp:5636:21 17:44:44.596 32438 Igalia#18 0x10359be3 in blink::XMLDocumentParser::end() third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp:413:18 17:44:44.596 32438 Igalia#19 0xf9134e4 in blink::DocumentWriter::end() third_party/WebKit/Source/core/loader/DocumentWriter.cpp:109:12 17:44:44.596 32438 Igalia#20 0xf8f9e7f in EndWriting third_party/WebKit/Source/core/loader/DocumentLoader.cpp:896:12 17:44:44.596 32438 Igalia#21 0xf8f9e7f in blink::DocumentLoader::FinishedLoading(double) third_party/WebKit/Source/core/loader/DocumentLoader.cpp:455:0 17:44:44.596 32438 Igalia#22 0x45cfb05 in blink::Resource::CheckNotify() third_party/WebKit/Source/platform/loader/fetch/Resource.cpp:336:8 17:44:44.596 32438 Igalia#23 0x46125d0 in blink::ResourceFetcher::HandleLoaderFinish(blink::Resource*, double, blink::ResourceFetcher::LoaderFinishType) third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp:1333:15 17:44:44.596 32438 Igalia#24 0x1375febb in content::WebURLLoaderImpl::Context::OnCompletedRequest(int, bool, bool, base::TimeTicks const&, long, long, long) content/child/web_url_loader_impl.cc:904:16 17:44:44.596 32438 Original change's description: > Fix Heap-use-after-free Bug > > Add a new member variable LayoutTableCell::is_spanning_collapsed_row_ so that > there is no need to access LayoutTableSection::RowHasVisibilityCollapse > in LayoutTableCell. This avoids using the memory that has already been > freed. > > Bug: 750016 > Change-Id: I1838a775f3b45315b2dee3e15942af0dff0c5955 > Reviewed-on: https://chromium-review.googlesource.com/594935 > Reviewed-by: Morten Stenshorne <mstensho@opera.com> > Commit-Queue: Joy Yu <joysyu@google.com> > Cr-Commit-Position: refs/heads/master@{#491139} TBR=dgrogan@chromium.org,mstensho@opera.com,joysyu@google.com Change-Id: Idaad8aba8647775eb2387688919c25b6ad4a8eda No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 750016 Reviewed-on: https://chromium-review.googlesource.com/597667 Reviewed-by: Guido Urdaneta <guidou@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#491315}

This reverts commit 0814d71. Reason for revert: A fix is ready, but requires this reland. Original change's description: > Revert "Fix Heap-use-after-free Bug" > > This reverts commit d09047b. > > Reason for revert: > This CL breaks Linux Trusty MSAN bot. > See > https://luci-milo.appspot.com/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20MSAN/2350 > and successive builds. > > Sample logs: > 17:44:44.594 32438 ==1:1==WARNING: MemorySanitizer: use-of-uninitialized-value > 17:44:44.594 32438 #0 0xf548000 in blink::LayoutTableCell::ShouldClipOverflow() const third_party/WebKit/Source/core/layout/LayoutTableCell.cpp:459:35 > 17:44:44.594 32438 Igalia#1 0xfdd1161 in NeedsOverflowClip third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp:803:48 > 17:44:44.594 32438 Igalia#2 0xfdd1161 in UpdatePaintProperties third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp:1208:0 > 17:44:44.594 32438 Igalia#3 0xfdd1161 in blink::PaintPropertyTreeBuilder::UpdatePropertiesForSelf(blink::LayoutObject const&, blink::PaintPropertyTreeBuilderContext&) third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp:1244:0 > 17:44:44.594 32438 Igalia#4 0xfd6963c in blink::PrePaintTreeWalk::Walk(blink::LayoutObject const&, blink::PrePaintTreeWalkContext const&) third_party/WebKit/Source/core/paint/PrePaintTreeWalk.cpp:190:28 > 17:44:44.594 32438 Igalia#5 0xfd6a1bb in blink::PrePaintTreeWalk::Walk(blink::LayoutObject const&, blink::PrePaintTreeWalkContext const&) third_party/WebKit/Source/core/paint/PrePaintTreeWalk.cpp:215:5 > 17:44:44.594 32438 Igalia#6 0xfd6a1bb in blink::PrePaintTreeWalk::Walk(blink::LayoutObject const&, blink::PrePaintTreeWalkContext const&) third_party/WebKit/Source/core/paint/PrePaintTreeWalk.cpp:215:5 > 17:44:44.594 32438 Igalia#7 0xfd6a1bb in blink::PrePaintTreeWalk::Walk(blink::LayoutObject const&, blink::PrePaintTreeWalkContext const&) third_party/WebKit/Source/core/paint/PrePaintTreeWalk.cpp:215:5 > 17:44:44.594 32438 Igalia#8 0xfd6a1bb in blink::PrePaintTreeWalk::Walk(blink::LayoutObject const&, blink::PrePaintTreeWalkContext const&) third_party/WebKit/Source/core/paint/PrePaintTreeWalk.cpp:215:5 > 17:44:44.594 32438 Igalia#9 0xfd68046 in blink::PrePaintTreeWalk::Walk(blink::LocalFrameView&, blink::PrePaintTreeWalkContext const&) third_party/WebKit/Source/core/paint/PrePaintTreeWalk.cpp:92:5 > 17:44:44.594 32438 Igalia#10 0xfd674b4 in blink::PrePaintTreeWalk::Walk(blink::LocalFrameView&) third_party/WebKit/Source/core/paint/PrePaintTreeWalk.cpp:66:3 > 17:44:44.594 32438 Igalia#11 0xe513327 in blink::LocalFrameView::PrePaint() third_party/WebKit/Source/core/frame/LocalFrameView.cpp:3255:24 > 17:44:44.594 32438 Igalia#12 0xe50d013 in blink::LocalFrameView::UpdateLifecyclePhasesInternal(blink::DocumentLifecycle::LifecycleState) third_party/WebKit/Source/core/frame/LocalFrameView.cpp:3186:9 > 17:44:44.594 32438 Igalia#13 0xfb2ff7c in blink::PageAnimator::UpdateAllLifecyclePhases(blink::LocalFrame&) third_party/WebKit/Source/core/page/PageAnimator.cpp:100:9 > 17:44:44.594 32438 Igalia#14 0x1451947d in blink::WebViewImpl::UpdateAllLifecyclePhases() third_party/WebKit/Source/core/exported/WebViewImpl.cpp:1984:3 > 17:44:44.594 32438 Igalia#15 0x6b9e8bb in content::BlinkTestRunner::TestFinished() content/shell/renderer/layout_test/blink_test_runner.cc:606:11 > 17:44:44.594 32438 Igalia#16 0x11d957ed in test_runner::TestRunner::WorkQueue::ProcessWorkSoon() content/shell/test_runner/test_runner.cc:1572:29 > 17:44:44.595 32438 Igalia#17 0x11d9db51 in LocationChangeDone content/shell/test_runner/test_runner.cc:2819:17 > 17:44:44.595 32438 Igalia#18 0x11d9db51 in test_runner::TestRunner::tryToClearTopLoadingFrame(blink::WebFrame*) content/shell/test_runner/test_runner.cc:1951:0 > 17:44:44.595 32438 Igalia#19 0xf9a560e in blink::ProgressTracker::ProgressCompleted() third_party/WebKit/Source/core/loader/ProgressTracker.cpp:122:26 > 17:44:44.595 32438 Igalia#20 0xf94bfe5 in blink::FrameLoader::DidFinishNavigation() third_party/WebKit/Source/core/loader/FrameLoader.cpp:478:24 > 17:44:44.595 32438 Igalia#21 0xdbf17f7 in blink::Document::CheckCompleted() third_party/WebKit/Source/core/dom/Document.cpp:3234:20 > 17:44:44.595 32438 Igalia#22 0xf94b490 in blink::FrameLoader::FinishedParsing() third_party/WebKit/Source/core/loader/FrameLoader.cpp:448:26 > 17:44:44.595 32438 Igalia#23 0xdc2c180 in blink::Document::FinishedParsing() third_party/WebKit/Source/core/dom/Document.cpp:5636:21 > 17:44:44.595 32438 Igalia#24 0x10359be3 in blink::XMLDocumentParser::end() third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp:413:18 > 17:44:44.595 32438 Igalia#25 0xf9134e4 in blink::DocumentWriter::end() third_party/WebKit/Source/core/loader/DocumentWriter.cpp:109:12 > 17:44:44.595 32438 Igalia#26 0xf8f9e7f in EndWriting third_party/WebKit/Source/core/loader/DocumentLoader.cpp:896:12 > 17:44:44.595 32438 Igalia#27 0xf8f9e7f in blink::DocumentLoader::FinishedLoading(double) third_party/WebKit/Source/core/loader/DocumentLoader.cpp:455:0 > 17:44:44.595 32438 Igalia#28 0x45cfb05 in blink::Resource::CheckNotify() third_party/WebKit/Source/platform/loader/fetch/Resource.cpp:336:8 > 17:44:44.595 32438 Igalia#29 0x46125d0 in blink::ResourceFetcher::HandleLoaderFinish(blink::Resource*, double, blink::ResourceFetcher::LoaderFinishType) third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp:1333:15 > 17:44:44.595 32438 Igalia#30 0x1375febb in content::WebURLLoaderImpl::Context::OnCompletedRequest(int, bool, bool, base::TimeTicks const&, long, long, long) content/child/web_url_loader_impl.cc:904:16 > 17:44:44.595 32438 Igalia#31 0xc0c93f5 in content::ResourceDispatcher::OnRequestComplete(int, content::ResourceRequestCompletionStatus const&) content/child/resource_dispatcher.cc:374:9 > 17:44:44.595 32438 Igalia#32 0xc0d0e07 in DispatchToMethodImpl<content::ResourceDispatcher *, void (content::ResourceDispatcher::*)(int, const content::ResourceRequestCompletionStatus &), const std::__1::tuple<int, content::ResourceRequestCompletionStatus> &, 0, 1> base/tuple.h:77:3 > 17:44:44.595 32438 Igalia#33 0xc0d0e07 in DispatchToMethod<content::ResourceDispatcher *, void (content::ResourceDispatcher::*)(int, const content::ResourceRequestCompletionStatus &), const std::__1::tuple<int, content::ResourceRequestCompletionStatus> &> base/tuple.h:84:0 > 17:44:44.595 32438 Igalia#34 0xc0d0e07 in DispatchToMethod<content::ResourceDispatcher, void (content::ResourceDispatcher::*)(int, const content::ResourceRequestCompletionStatus &), void, std::__1::tuple<int, content::ResourceRequestCompletionStatus> > ipc/ipc_message_templates.h:26:0 > 17:44:44.595 32438 Igalia#35 0xc0d0e07 in bool IPC::MessageT<ResourceMsg_RequestComplete_Meta, std::__1::tuple<int, content::ResourceRequestCompletionStatus>, void>::Dispatch<content::ResourceDispatcher, content::ResourceDispatcher, void, void (content::ResourceDispatcher::*)(int, content::ResourceRequestCompletionStatus const&)>(IPC::Message const*, content::ResourceDispatcher*, content::ResourceDispatcher*, void*, void (content::ResourceDispatcher::*)(int, content::ResourceRequestCompletionStatus const&)) ipc/ipc_message_templates.h:121:0 > 17:44:44.595 32438 Igalia#36 0xc0bfe8a in content::ResourceDispatcher::DispatchMessage(IPC::Message const&) content/child/resource_dispatcher.cc:535:5 > 17:44:44.595 32438 Igalia#37 0xc0bd497 in content::ResourceDispatcher::OnMessageReceived(IPC::Message const&) content/child/resource_dispatcher.cc:136:3 > 17:44:44.595 32438 Igalia#38 0xc0d86f9 in content::ResourceSchedulingFilter::DispatchMessage(IPC::Message const&) content/child/resource_scheduling_filter.cc:74:27 > 17:44:44.595 32438 Igalia#39 0x6c8e490 in Run base/callback.h:91:12 > 17:44:44.595 32438 Igalia#40 0x6c8e490 in base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) base/debug/task_annotator.cc:59:0 > 17:44:44.595 32438 Igalia#41 0x46c2540 in blink::scheduler::TaskQueueManager::ProcessTaskFromWorkQueue(blink::scheduler::internal::WorkQueue*, bool, blink::scheduler::LazyNow, base::TimeTicks*) third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.cc:532:19 > 17:44:44.595 32438 Igalia#42 0x46b600a in blink::scheduler::TaskQueueManager::DoWork(bool) third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.cc:330:13 > 17:44:44.595 32438 Igalia#43 0x6c8e490 in Run base/callback.h:91:12 > 17:44:44.595 32438 Igalia#44 0x6c8e490 in base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) base/debug/task_annotator.cc:59:0 > 17:44:44.595 32438 Igalia#45 0x6d1f88e in base::MessageLoop::RunTask(base::PendingTask*) base/message_loop/message_loop.cc:404:19 > 17:44:44.595 32438 Igalia#46 0x6d22ad9 in base::MessageLoop::DeferOrRunPendingTask(base::PendingTask) base/message_loop/message_loop.cc:415:5 > 17:44:44.595 32438 Igalia#47 0x6d23ad6 in base::MessageLoop::DoWork() base/message_loop/message_loop.cc:522:13 > 17:44:44.595 32438 Igalia#48 0x6d3023a in base::MessagePumpDefault::Run(base::MessagePump::Delegate*) base/message_loop/message_pump_default.cc:33:31 > 17:44:44.595 32438 Igalia#49 0x6dbef5b in base::RunLoop::Run() base/run_loop.cc:112:14 > 17:44:44.595 32438 Igalia#50 0x113da4bf in content::RendererMain(content::MainFunctionParams const&) content/renderer/renderer_main.cc:219:23 > 17:44:44.595 32438 Igalia#51 0x4821509 in content::RunZygote(content::MainFunctionParams const&, content::ContentMainDelegate*) content/app/content_main_runner.cc:337:14 > 17:44:44.595 32438 Igalia#52 0x48240fa in content::RunNamedProcessTypeMain(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, content::MainFunctionParams const&, content::ContentMainDelegate*) content/app/content_main_runner.cc:416:12 > 17:44:44.595 32438 Igalia#53 0x4826d77 in content::ContentMainRunnerImpl::Run() content/app/content_main_runner.cc:687:12 > 17:44:44.595 32438 Igalia#54 0xbfb00ba in service_manager::Main(service_manager::MainParams const&) services/service_manager/embedder/main.cc:469:29 > 17:44:44.595 32438 Igalia#55 0x16265ee in content::ContentMain(content::ContentMainParams const&) content/app/content_main.cc:19:10 > 17:44:44.595 32438 Igalia#56 0x4a904f in main content/shell/app/shell_main.cc:48:10 > 17:44:44.595 32438 Igalia#57 0x7fa0d53baf44 in __libc_start_main /build/eglibc-SvCtMH/eglibc-2.19/csu/libc-start.c:287:0 > 17:44:44.595 32438 Igalia#58 0x43cf9a in _start ??:0:0 > 17:44:44.595 32438 > 17:44:44.595 32438 Uninitialized value was stored to memory at > 17:44:44.596 32438 #0 0xf5430fb in SetCellWidthChanged third_party/WebKit/Source/core/layout/LayoutTableCell.h:235:65 > 17:44:44.596 32438 Igalia#1 0xf5430fb in blink::LayoutTableCell::UpdateLayout() third_party/WebKit/Source/core/layout/LayoutTableCell.cpp:327:0 > 17:44:44.596 32438 Igalia#2 0xf59d164 in LayoutIfNeeded third_party/WebKit/Source/core/layout/LayoutObject.h:1110:7 > 17:44:44.596 32438 Igalia#3 0xf59d164 in blink::LayoutTableSection::LayoutRows() third_party/WebKit/Source/core/layout/LayoutTableSection.cpp:1252:0 > 17:44:44.596 32438 Igalia#4 0xf524b1c in blink::LayoutTable::UpdateLayout() third_party/WebKit/Source/core/layout/LayoutTable.cpp:717:16 > 17:44:44.596 32438 Igalia#5 0xf185d49 in LayoutIfNeeded third_party/WebKit/Source/core/layout/LayoutObject.h:1110:7 > 17:44:44.596 32438 Igalia#6 0xf185d49 in blink::LayoutBlock::LayoutPositionedObject(blink::LayoutBox*, bool, blink::LayoutBlock::PositionedLayoutBehavior) third_party/WebKit/Source/core/layout/LayoutBlock.cpp:828:0 > 17:44:44.596 32438 Igalia#7 0xf184ef7 in blink::LayoutBlock::LayoutPositionedObjects(bool, blink::LayoutBlock::PositionedLayoutBehavior) third_party/WebKit/Source/core/layout/LayoutBlock.cpp:773:5 > 17:44:44.596 32438 Igalia#8 0xf1b1e0e in blink::LayoutBlockFlow::UpdateBlockLayout(bool) third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp:485:3 > 17:44:44.596 32438 Igalia#9 0xf17eb46 in blink::LayoutBlock::UpdateLayout() third_party/WebKit/Source/core/layout/LayoutBlock.cpp:427:3 > 17:44:44.596 32438 Igalia#10 0xf645987 in LayoutContent third_party/WebKit/Source/core/layout/LayoutView.cpp:224:20 > 17:44:44.596 32438 Igalia#11 0xf645987 in blink::LayoutView::UpdateLayout() third_party/WebKit/Source/core/layout/LayoutView.cpp:316:0 > 17:44:44.596 32438 Igalia#12 0xe4eadff in blink::LocalFrameView::PerformLayout(bool) third_party/WebKit/Source/core/frame/LocalFrameView.cpp:1082:22 > 17:44:44.596 32438 Igalia#13 0xe4dee95 in blink::LocalFrameView::UpdateLayout() third_party/WebKit/Source/core/frame/LocalFrameView.cpp:1265:10 > 17:44:44.596 32438 Igalia#14 0xdbf2315 in blink::Document::ImplicitClose() third_party/WebKit/Source/core/dom/Document.cpp:3155:15 > 17:44:44.596 32438 Igalia#15 0xdbf1070 in blink::Document::CheckCompleted() third_party/WebKit/Source/core/dom/Document.cpp:3212:5 > 17:44:44.596 32438 Igalia#16 0xf94b490 in blink::FrameLoader::FinishedParsing() third_party/WebKit/Source/core/loader/FrameLoader.cpp:448:26 > 17:44:44.596 32438 Igalia#17 0xdc2c180 in blink::Document::FinishedParsing() third_party/WebKit/Source/core/dom/Document.cpp:5636:21 > 17:44:44.596 32438 Igalia#18 0x10359be3 in blink::XMLDocumentParser::end() third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp:413:18 > 17:44:44.596 32438 Igalia#19 0xf9134e4 in blink::DocumentWriter::end() third_party/WebKit/Source/core/loader/DocumentWriter.cpp:109:12 > 17:44:44.596 32438 Igalia#20 0xf8f9e7f in EndWriting third_party/WebKit/Source/core/loader/DocumentLoader.cpp:896:12 > 17:44:44.596 32438 Igalia#21 0xf8f9e7f in blink::DocumentLoader::FinishedLoading(double) third_party/WebKit/Source/core/loader/DocumentLoader.cpp:455:0 > 17:44:44.596 32438 Igalia#22 0x45cfb05 in blink::Resource::CheckNotify() third_party/WebKit/Source/platform/loader/fetch/Resource.cpp:336:8 > 17:44:44.596 32438 Igalia#23 0x46125d0 in blink::ResourceFetcher::HandleLoaderFinish(blink::Resource*, double, blink::ResourceFetcher::LoaderFinishType) third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp:1333:15 > 17:44:44.596 32438 Igalia#24 0x1375febb in content::WebURLLoaderImpl::Context::OnCompletedRequest(int, bool, bool, base::TimeTicks const&, long, long, long) content/child/web_url_loader_impl.cc:904:16 > 17:44:44.596 32438 > > > Original change's description: > > Fix Heap-use-after-free Bug > > > > Add a new member variable LayoutTableCell::is_spanning_collapsed_row_ so that > > there is no need to access LayoutTableSection::RowHasVisibilityCollapse > > in LayoutTableCell. This avoids using the memory that has already been > > freed. > > > > Bug: 750016 > > Change-Id: I1838a775f3b45315b2dee3e15942af0dff0c5955 > > Reviewed-on: https://chromium-review.googlesource.com/594935 > > Reviewed-by: Morten Stenshorne <mstensho@opera.com> > > Commit-Queue: Joy Yu <joysyu@google.com> > > Cr-Commit-Position: refs/heads/master@{#491139} > > TBR=dgrogan@chromium.org,mstensho@opera.com,joysyu@google.com > > Change-Id: Idaad8aba8647775eb2387688919c25b6ad4a8eda > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 750016 > Reviewed-on: https://chromium-review.googlesource.com/597667 > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Commit-Queue: Guido Urdaneta <guidou@chromium.org> > Cr-Commit-Position: refs/heads/master@{#491315} TBR=dgrogan@chromium.org,mstensho@opera.com,guidou@chromium.org,joysyu@google.com Change-Id: I4e1b4c59275699a5aa610d9ff338c062d8982268 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 750016 Reviewed-on: https://chromium-review.googlesource.com/597687 Reviewed-by: Guido Urdaneta <guidou@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#491322}

…oading_tab_count_ (0 vs. 0) SessionRestoreImpl::ShowBrowser is called by the time the last active tab is being restored. If this tab isn't the first one, there will be WebContentsViewAura/WebContents instances created for the (inactive) tabs previously handled. Each WebContentsViewAura instance installs itself as a observer of DesktopWindowTreeHostMus' window. SessionRestoreImpl::ShowBrowser end up calling DesktopWindowTreeHostMus::ShowWindowWithState which in turn calls Window::Show, and it triggers a Window::Show call. The visibility change on it (due to Window::Show) will trigger notification to all observers (including WebContentsViewAura instances), and this can trigger unexpected loads. Igalia#1 0x562d73b6043e content::WebContentsImpl::DidStartLoading() Igalia#2 0x562d738355bb content::FrameTreeNode::DidStartLoading() Igalia#3 0x562d73864977 content::RenderFrameHostImpl::OnDidStartLoading() Igalia#4 0x562d7386dd14 content::RenderFrameHostImpl::Navigate() Igalia#5 0x562d73853678 content::NavigatorImpl::NavigateToEntry() Igalia#6 0x562d73853de5 content::NavigatorImpl::NavigateToPendingEntry() Igalia#7 0x562d73841c37 content::NavigationControllerImpl::NavigateToPendingEntryInternal() Igalia#8 0x562d7383c384 content::NavigationControllerImpl::NavigateToPendingEntry() Igalia#9 0x562d7386dd14 content NavigationControllerImpl::LoadIfNecessary() Igalia#10 0x562d76d34846content::NavigationControllerImpl::SetActive(bool is_active) Igalia#11 0x562d73b545cd content::WebContentsImpl::WasShown() Igalia#12 0x562d78b247d8 content::WebContentsImpl::UpdateWebContentsVisibility(bool visible) Igalia#13 0x562d75ff1796 content::WebContentsViewAura::OnWindowVisibilityChanged Igalia#14 0x562d75ff4586 aura::Window::NotifyWindowVisibilityChangedAtReceiver() Igalia#15 0x562d75ff430e aura::Window::NotifyWindowVisibilityChangedDown() Igalia#16 0x562d75ff4428 aura::Window::NotifyWindowVisibilityChangedDown() Igalia#17 0x562d75ff1baf aura::Window::SetVisible() Igalia#18 0x562d75ff1796 aura::Window::Show() Igalia#19 0x562d76f4c328 views::DesktopWindowTreeHostMus::ShowWindowWithState() Igalia#20 0x562d78b247d8 views::DesktopNativeWidgetAura::ShowWithWindowState() Igalia#21 0x562d764008c0 views::Widget::Show() Igalia#22 0x562d76d34846 BrowserView::Show() Igalia#23 0x562d74bed220 SessionRestoreImpl::ShowBrowser() Igalia#24 0x562d74becf95 SessionRestoreImpl::RestoreTab() Igalia#25 0x562d74beba71 SessionRestoreImpl::RestoreTabsToBrowser() Igalia#26 0x562d74beb0db SessionRestoreImpl::ProcessSessionWindows() Igalia#27 0x562d74be9b92 SessionRestoreImpl::Restore() Igalia#28 0x562d74be9617 SessionRestore::RestoreSession() Igalia#29 0x562d76cad8f5 StartupBrowserCreatorImpl::RestoreOrCreateBrowser() SessionRestoreStatsCollector is not expecting tabs other than the last active one to be loaded, when it is instantiated, causing the assert. Patch fixes the issue by disallowing reactions to window visibility changes while calling ::ShowBrowser, restoring from a previous session. Issue Igalia#152

…oading_tab_count_ (0 vs. 0) SessionRestoreImpl::ShowBrowser is called by the time the last active tab is being restored. If this tab isn't the first one, there will be WebContentsViewAura/WebContents instances created for the (inactive) tabs previously handled. Each WebContentsViewAura instance installs itself as a observer of DesktopWindowTreeHostMus' window. SessionRestoreImpl::ShowBrowser end up calling DesktopWindowTreeHostMus::ShowWindowWithState which in turn calls Window::Show, and it triggers a Window::Show call. The visibility change on it (due to Window::Show) will trigger notification to all observers (including WebContentsViewAura instances), and this can trigger unexpected loads. Igalia#1 0x562d73b6043e content::WebContentsImpl::DidStartLoading() Igalia#2 0x562d738355bb content::FrameTreeNode::DidStartLoading() Igalia#3 0x562d73864977 content::RenderFrameHostImpl::OnDidStartLoading() Igalia#4 0x562d7386dd14 content::RenderFrameHostImpl::Navigate() Igalia#5 0x562d73853678 content::NavigatorImpl::NavigateToEntry() Igalia#6 0x562d73853de5 content::NavigatorImpl::NavigateToPendingEntry() Igalia#7 0x562d73841c37 content::NavigationControllerImpl::NavigateToPendingEntryInternal() Igalia#8 0x562d7383c384 content::NavigationControllerImpl::NavigateToPendingEntry() Igalia#9 0x562d7386dd14 content NavigationControllerImpl::LoadIfNecessary() Igalia#10 0x562d76d34846content::NavigationControllerImpl::SetActive(bool is_active) Igalia#11 0x562d73b545cd content::WebContentsImpl::WasShown() Igalia#12 0x562d78b247d8 content::WebContentsImpl::UpdateWebContentsVisibility(bool visible) Igalia#13 0x562d75ff1796 content::WebContentsViewAura::OnWindowVisibilityChanged Igalia#14 0x562d75ff4586 aura::Window::NotifyWindowVisibilityChangedAtReceiver() Igalia#15 0x562d75ff430e aura::Window::NotifyWindowVisibilityChangedDown() Igalia#16 0x562d75ff4428 aura::Window::NotifyWindowVisibilityChangedDown() Igalia#17 0x562d75ff1baf aura::Window::SetVisible() Igalia#18 0x562d75ff1796 aura::Window::Show() Igalia#19 0x562d76f4c328 views::DesktopWindowTreeHostMus::ShowWindowWithState() Igalia#20 0x562d78b247d8 views::DesktopNativeWidgetAura::ShowWithWindowState() Igalia#21 0x562d764008c0 views::Widget::Show() Igalia#22 0x562d76d34846 BrowserView::Show() Igalia#23 0x562d74bed220 SessionRestoreImpl::ShowBrowser() Igalia#24 0x562d74becf95 SessionRestoreImpl::RestoreTab() Igalia#25 0x562d74beba71 SessionRestoreImpl::RestoreTabsToBrowser() Igalia#26 0x562d74beb0db SessionRestoreImpl::ProcessSessionWindows() Igalia#27 0x562d74be9b92 SessionRestoreImpl::Restore() Igalia#28 0x562d74be9617 SessionRestore::RestoreSession() Igalia#29 0x562d76cad8f5 StartupBrowserCreatorImpl::RestoreOrCreateBrowser() SessionRestoreStatsCollector is not expecting tabs other than the last active one to be loaded, when it is instantiated, causing the assert. Patch fixes the issue by disallowing reactions to window visibility changes while calling ::ShowBrowser, restoring from a previous session. Issue Igalia#152 Issue Igalia#181

…oading_tab_count_ (0 vs. 0) SessionRestoreImpl::ShowBrowser is called by the time the last active tab is being restored. If this tab isn't the first one, there will be WebContentsViewAura/WebContents instances created for the (inactive) tabs previously handled. Each WebContentsViewAura instance installs itself as a observer of DesktopWindowTreeHostMus' window. SessionRestoreImpl::ShowBrowser end up calling DesktopWindowTreeHostMus::ShowWindowWithState which in turn calls Window::Show, and it triggers a Window::Show call. The visibility change on it (due to Window::Show) will trigger notification to all observers (including WebContentsViewAura instances), and this can trigger unexpected loads. #1 0x562d73b6043e content::WebContentsImpl::DidStartLoading() #2 0x562d738355bb content::FrameTreeNode::DidStartLoading() #3 0x562d73864977 content::RenderFrameHostImpl::OnDidStartLoading() #4 0x562d7386dd14 content::RenderFrameHostImpl::Navigate() #5 0x562d73853678 content::NavigatorImpl::NavigateToEntry() #6 0x562d73853de5 content::NavigatorImpl::NavigateToPendingEntry() #7 0x562d73841c37 content::NavigationControllerImpl::NavigateToPendingEntryInternal() #8 0x562d7383c384 content::NavigationControllerImpl::NavigateToPendingEntry() #9 0x562d7386dd14 content NavigationControllerImpl::LoadIfNecessary() #10 0x562d76d34846content::NavigationControllerImpl::SetActive(bool is_active) #11 0x562d73b545cd content::WebContentsImpl::WasShown() #12 0x562d78b247d8 content::WebContentsImpl::UpdateWebContentsVisibility(bool visible) #13 0x562d75ff1796 content::WebContentsViewAura::OnWindowVisibilityChanged #14 0x562d75ff4586 aura::Window::NotifyWindowVisibilityChangedAtReceiver() #15 0x562d75ff430e aura::Window::NotifyWindowVisibilityChangedDown() #16 0x562d75ff4428 aura::Window::NotifyWindowVisibilityChangedDown() #17 0x562d75ff1baf aura::Window::SetVisible() #18 0x562d75ff1796 aura::Window::Show() #19 0x562d76f4c328 views::DesktopWindowTreeHostMus::ShowWindowWithState() #20 0x562d78b247d8 views::DesktopNativeWidgetAura::ShowWithWindowState() #21 0x562d764008c0 views::Widget::Show() #22 0x562d76d34846 BrowserView::Show() #23 0x562d74bed220 SessionRestoreImpl::ShowBrowser() #24 0x562d74becf95 SessionRestoreImpl::RestoreTab() #25 0x562d74beba71 SessionRestoreImpl::RestoreTabsToBrowser() #26 0x562d74beb0db SessionRestoreImpl::ProcessSessionWindows() #27 0x562d74be9b92 SessionRestoreImpl::Restore() #28 0x562d74be9617 SessionRestore::RestoreSession() #29 0x562d76cad8f5 StartupBrowserCreatorImpl::RestoreOrCreateBrowser() SessionRestoreStatsCollector is not expecting tabs other than the last active one to be loaded, when it is instantiated, causing the assert. Patch fixes the issue by disallowing reactions to window visibility changes while calling ::ShowBrowser, restoring from a previous session. Issue #152 Issue #181

…pletes" This reverts commit 9525c34. Reason for revert: Looks like this broke interactive_ui_tests on Linux Chromium OS ASan LSan Tests (1): https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/22950 ================================================================= ==27422==ERROR: AddressSanitizer: heap-use-after-free on address 0x6110001fbb88 at pc 0x0000113dc8f8 bp 0x7ffce4666c90 sp 0x7ffce4666c88 READ of size 8 at 0x6110001fbb88 thread T0 (interactive_ui_) #0 0x113dc8f7 in begin buildtools/third_party/libc++/trunk/include/vector:1465:30 #1 0x113dc8f7 in base::ObserverListBase<chromeos::OobeUI::Observer>::RemoveObserver(chromeos::OobeUI::Observer*) base/observer_list.h:286 #2 0x11ba806a in chromeos::ArcTermsOfServiceScreenHandler::~ArcTermsOfServiceScreenHandler() chrome/browser/ui/webui/chromeos/login/arc_terms_of_service_screen_handler.cc:40:11 #3 0x11ba8edd in chromeos::ArcTermsOfServiceScreenHandler::~ArcTermsOfServiceScreenHandler() chrome/browser/ui/webui/chromeos/login/arc_terms_of_service_screen_handler.cc:39:67 #4 0x3b94103 in operator() buildtools/third_party/libc++/trunk/include/memory:2272:5 #5 0x3b94103 in reset buildtools/third_party/libc++/trunk/include/memory:2585 #6 0x3b94103 in ~unique_ptr buildtools/third_party/libc++/trunk/include/memory:2539 #7 0x3b94103 in destroy buildtools/third_party/libc++/trunk/include/memory:1853 #8 0x3b94103 in __destroy<std::__1::unique_ptr<content::WebUIMessageHandler, std::__1::default_delete<content::WebUIMessageHandler> > > buildtools/third_party/libc++/trunk/include/memory:1721 #9 0x3b94103 in destroy<std::__1::unique_ptr<content::WebUIMessageHandler, std::__1::default_delete<content::WebUIMessageHandler> > > buildtools/third_party/libc++/trunk/include/memory:1589 #10 0x3b94103 in __destruct_at_end buildtools/third_party/libc++/trunk/include/vector:418 #11 0x3b94103 in clear buildtools/third_party/libc++/trunk/include/vector:361 #12 0x3b94103 in ~__vector_base buildtools/third_party/libc++/trunk/include/vector:446 #13 0x3b94103 in content::WebUIImpl::~WebUIImpl() content/browser/webui/web_ui_impl.cc:91 #14 0x3b9428d in content::WebUIImpl::~WebUIImpl() content/browser/webui/web_ui_impl.cc:87:25 #15 0x303a2c5 in content::RenderFrameHostManager::ClearWebUIInstances() content/browser/frame_host/render_frame_host_manager.cc:679:25 #16 0x3aee854 in content::WebContentsImpl::~WebContentsImpl() content/browser/web_contents/web_contents_impl.cc:600:29 #17 0x3af1b8d in content::WebContentsImpl::~WebContentsImpl() content/browser/web_contents/web_contents_impl.cc:571:37 #18 0x12091e89 in operator() buildtools/third_party/libc++/trunk/include/memory:2272:5 #19 0x12091e89 in reset buildtools/third_party/libc++/trunk/include/memory:2585 #20 0x12091e89 in views::WebView::SetWebContents(content::WebContents*) ui/views/controls/webview/webview.cc:73 #21 0x120932f1 in ~WebView ui/views/controls/webview/webview.cc:44:3 #22 0x120932f1 in views::WebView::~WebView() ui/views/controls/webview/webview.cc:43 #23 0x520969f in operator() buildtools/third_party/libc++/trunk/include/memory:2272:5 #24 0x520969f in reset buildtools/third_party/libc++/trunk/include/memory:2585 #25 0x520969f in ~unique_ptr buildtools/third_party/libc++/trunk/include/memory:2539 #26 0x520969f in chromeos::WebUILoginView::~WebUILoginView() chrome/browser/chromeos/login/ui/webui_login_view.cc:224 #27 0x520a07d in chromeos::WebUILoginView::~WebUILoginView() chrome/browser/chromeos/login/ui/webui_login_view.cc:199:35 #28 0xad7565b in operator() buildtools/third_party/libc++/trunk/include/memory:2272:5 #29 0xad7565b in reset buildtools/third_party/libc++/trunk/include/memory:2585 #30 0xad7565b in ~unique_ptr buildtools/third_party/libc++/trunk/include/memory:2539 #31 0xad7565b in views::View::DoRemoveChildView(views::View*, bool, bool, bool, views::View*) ui/views/view.cc:2136 #32 0xad77048 in views::View::RemoveAllChildViews(bool) ui/views/view.cc:302:5 #33 0xad9b615 in views::internal::RootView::~RootView() ui/views/widget/root_view.cc:181:5 #34 0xad9b7cd in views::internal::RootView::~RootView() ui/views/widget/root_view.cc:177:23 #35 0xada5ac1 in operator() buildtools/third_party/libc++/trunk/include/memory:2272:5 #36 0xada5ac1 in reset buildtools/third_party/libc++/trunk/include/memory:2585 #37 0xada5ac1 in DestroyRootView ui/views/widget/widget.cc:1434 #38 0xada5ac1 in views::Widget::~Widget() ui/views/widget/widget.cc:180 #39 0xada61ad in views::Widget::~Widget() ui/views/widget/widget.cc:179:19 #40 0xade9e6f in views::NativeWidgetAura::~NativeWidgetAura() ui/views/widget/native_widget_aura.cc #41 0xadea10d in views::NativeWidgetAura::~NativeWidgetAura() ui/views/widget/native_widget_aura.cc:986:39 #42 0xe11b498 in aura::Window::~Window() ui/aura/window.cc:123:16 #43 0xe11c90d in aura::Window::~Window() ui/aura/window.cc:77:19 #44 0xadeb043 in Invoke<const base::WeakPtr<views::NativeWidgetAura> &> base/bind_internal.h:196:12 #45 0xadeb043 in MakeItSo<void (views::NativeWidgetAura::*const &)(), const base::WeakPtr<views::NativeWidgetAura> &> base/bind_internal.h:285 #46 0xadeb043 in RunImpl<void (views::NativeWidgetAura::*const &)(), const std::__1::tuple<base::WeakPtr<views::NativeWidgetAura> > &, 0> base/bind_internal.h:340 #47 0xadeb043 in base::internal::Invoker<base::internal::BindState<void (views::NativeWidgetAura::*)(), base::WeakPtr<views::NativeWidgetAura> >, void ()>::Run(base::internal::BindStateBase*) base/bind_internal.h:319 #48 0xb35e805 in Run base/callback.h:91:12 #49 0xb35e805 in base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) base/debug/task_annotator.cc:59 #50 0xb3d46da in base::MessageLoop::RunTask(base::PendingTask*) base/message_loop/message_loop.cc:410:19 #51 0xb3d5040 in base::MessageLoop::DeferOrRunPendingTask(base::PendingTask) base/message_loop/message_loop.cc:421:5 #52 0xb3d5d81 in base::MessageLoop::DoWork() base/message_loop/message_loop.cc:528:13 #53 0xb3e0820 in base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) base/message_loop/message_pump_libevent.cc:220:31 #54 0xb3d3535 in base::MessageLoop::Run() base/message_loop/message_loop.cc:350:10 #55 0xb472370 in base::RunLoop::Run() base/run_loop.cc:123:14 #56 0x9304487 in RunThisRunLoop content/public/test/test_utils.cc:125:13 #57 0x9304487 in content::RunAllPendingInMessageLoop() content/public/test/test_utils.cc:133 #58 0x82fe2ba in InProcessBrowserTest::PostRunTestOnMainThread() chrome/test/base/in_process_browser_test.cc:607:3 #59 0x92d79f8 in content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() content/public/test/browser_test_base.cc:319:5 #60 0x83331b2 in Run base/callback.h:80:12 #61 0x83331b2 in ChromeBrowserMainParts::PreMainMessageLoopRunImpl() chrome/browser/chrome_browser_main.cc:1857 #62 0x83304b3 in ChromeBrowserMainParts::PreMainMessageLoopRun() chrome/browser/chrome_browser_main.cc:1210:18 #63 0x4dff120 in chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() chrome/browser/chromeos/chrome_browser_main_chromeos.cc:655:32 #64 0x2b32584 in content::BrowserMainLoop::PreMainMessageLoopRun() content/browser/browser_main_loop.cc:1151:13 #65 0x3a66b08 in Run base/callback.h:80:12 #66 0x3a66b08 in content::StartupTaskRunner::RunAllTasksNow() content/browser/startup_task_runner.cc:45 #67 0x2b2d47f in content::BrowserMainLoop::CreateStartupTasks() content/browser/browser_main_loop.cc:935:25 #68 0x2b3b21d in content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) content/browser/browser_main_runner.cc:131:17 #69 0x2b252a6 in content::BrowserMain(content::MainFunctionParams const&) content/browser/browser_main.cc:42:32 #70 0x8013aae in content::RunNamedProcessTypeMain(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, content::MainFunctionParams const&, content::ContentMainDelegate*) content/app/content_main_runner.cc:408:14 #71 0x8015aa9 in content::ContentMainRunnerImpl::Run() content/app/content_main_runner.cc:690:12 #72 0xe62b2ec in service_manager::Main(service_manager::MainParams const&) services/service_manager/embedder/main.cc:469:29 #73 0x8011e73 in content::ContentMain(content::ContentMainParams const&) content/app/content_main.cc:19:10 Original change's description: > Makes EmbeddedServiceRunner block until background thread completes > > Prior to this when EmbeddedServiceRunner was destroyed the background > thread would most likely still be running. Worse yet it was entirely > possible for ~InstanceManager to run on the same thread as the > service was running on, which attempts to destroy thread_ (because it > assumes thread_ was destroyed already). When this happens you hit a > CHECK in thread_ because you can't join with a thread while you are on > the thread. > > By making Shutdown() block until the background thread has said it's > ready to be shutdown, and then destroy the thread from the initiating > thread we never hit this situation. > > BUG=none > TEST=covered by test > > Change-Id: I09ebc5167247e2e8a1b15b625fdff8dc8b8d2e8f > Reviewed-on: https://chromium-review.googlesource.com/611392 > Commit-Queue: Scott Violet <sky@chromium.org> > Reviewed-by: Ken Rockot <rockot@chromium.org> > Cr-Commit-Position: refs/heads/master@{#493878} TBR=sky@chromium.org,rockot@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: none Change-Id: Ib5a4bdf57e78f5ecb61983c6c29ca8f80d6da04f Reviewed-on: https://chromium-review.googlesource.com/612810 Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#494001}

…read completes"" This reverts commit cb78bb6. Reason for revert: The original patch was not the culprit of the breakage. Relanding. Original change's description: > Revert "Makes EmbeddedServiceRunner block until background thread completes" > > This reverts commit 9525c34. > > Reason for revert: Looks like this broke interactive_ui_tests on Linux Chromium OS ASan LSan Tests (1): > https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/22950 > ================================================================= > ==27422==ERROR: AddressSanitizer: heap-use-after-free on address 0x6110001fbb88 at pc 0x0000113dc8f8 bp 0x7ffce4666c90 sp 0x7ffce4666c88 > READ of size 8 at 0x6110001fbb88 thread T0 (interactive_ui_) > #0 0x113dc8f7 in begin buildtools/third_party/libc++/trunk/include/vector:1465:30 > #1 0x113dc8f7 in base::ObserverListBase<chromeos::OobeUI::Observer>::RemoveObserver(chromeos::OobeUI::Observer*) base/observer_list.h:286 > #2 0x11ba806a in chromeos::ArcTermsOfServiceScreenHandler::~ArcTermsOfServiceScreenHandler() chrome/browser/ui/webui/chromeos/login/arc_terms_of_service_screen_handler.cc:40:11 > #3 0x11ba8edd in chromeos::ArcTermsOfServiceScreenHandler::~ArcTermsOfServiceScreenHandler() chrome/browser/ui/webui/chromeos/login/arc_terms_of_service_screen_handler.cc:39:67 > #4 0x3b94103 in operator() buildtools/third_party/libc++/trunk/include/memory:2272:5 > #5 0x3b94103 in reset buildtools/third_party/libc++/trunk/include/memory:2585 > #6 0x3b94103 in ~unique_ptr buildtools/third_party/libc++/trunk/include/memory:2539 > #7 0x3b94103 in destroy buildtools/third_party/libc++/trunk/include/memory:1853 > #8 0x3b94103 in __destroy<std::__1::unique_ptr<content::WebUIMessageHandler, std::__1::default_delete<content::WebUIMessageHandler> > > buildtools/third_party/libc++/trunk/include/memory:1721 > #9 0x3b94103 in destroy<std::__1::unique_ptr<content::WebUIMessageHandler, std::__1::default_delete<content::WebUIMessageHandler> > > buildtools/third_party/libc++/trunk/include/memory:1589 > #10 0x3b94103 in __destruct_at_end buildtools/third_party/libc++/trunk/include/vector:418 > #11 0x3b94103 in clear buildtools/third_party/libc++/trunk/include/vector:361 > #12 0x3b94103 in ~__vector_base buildtools/third_party/libc++/trunk/include/vector:446 > #13 0x3b94103 in content::WebUIImpl::~WebUIImpl() content/browser/webui/web_ui_impl.cc:91 > #14 0x3b9428d in content::WebUIImpl::~WebUIImpl() content/browser/webui/web_ui_impl.cc:87:25 > #15 0x303a2c5 in content::RenderFrameHostManager::ClearWebUIInstances() content/browser/frame_host/render_frame_host_manager.cc:679:25 > #16 0x3aee854 in content::WebContentsImpl::~WebContentsImpl() content/browser/web_contents/web_contents_impl.cc:600:29 > #17 0x3af1b8d in content::WebContentsImpl::~WebContentsImpl() content/browser/web_contents/web_contents_impl.cc:571:37 > #18 0x12091e89 in operator() buildtools/third_party/libc++/trunk/include/memory:2272:5 > #19 0x12091e89 in reset buildtools/third_party/libc++/trunk/include/memory:2585 > #20 0x12091e89 in views::WebView::SetWebContents(content::WebContents*) ui/views/controls/webview/webview.cc:73 > #21 0x120932f1 in ~WebView ui/views/controls/webview/webview.cc:44:3 > #22 0x120932f1 in views::WebView::~WebView() ui/views/controls/webview/webview.cc:43 > #23 0x520969f in operator() buildtools/third_party/libc++/trunk/include/memory:2272:5 > #24 0x520969f in reset buildtools/third_party/libc++/trunk/include/memory:2585 > #25 0x520969f in ~unique_ptr buildtools/third_party/libc++/trunk/include/memory:2539 > #26 0x520969f in chromeos::WebUILoginView::~WebUILoginView() chrome/browser/chromeos/login/ui/webui_login_view.cc:224 > #27 0x520a07d in chromeos::WebUILoginView::~WebUILoginView() chrome/browser/chromeos/login/ui/webui_login_view.cc:199:35 > #28 0xad7565b in operator() buildtools/third_party/libc++/trunk/include/memory:2272:5 > #29 0xad7565b in reset buildtools/third_party/libc++/trunk/include/memory:2585 > #30 0xad7565b in ~unique_ptr buildtools/third_party/libc++/trunk/include/memory:2539 > #31 0xad7565b in views::View::DoRemoveChildView(views::View*, bool, bool, bool, views::View*) ui/views/view.cc:2136 > #32 0xad77048 in views::View::RemoveAllChildViews(bool) ui/views/view.cc:302:5 > #33 0xad9b615 in views::internal::RootView::~RootView() ui/views/widget/root_view.cc:181:5 > #34 0xad9b7cd in views::internal::RootView::~RootView() ui/views/widget/root_view.cc:177:23 > #35 0xada5ac1 in operator() buildtools/third_party/libc++/trunk/include/memory:2272:5 > #36 0xada5ac1 in reset buildtools/third_party/libc++/trunk/include/memory:2585 > #37 0xada5ac1 in DestroyRootView ui/views/widget/widget.cc:1434 > #38 0xada5ac1 in views::Widget::~Widget() ui/views/widget/widget.cc:180 > #39 0xada61ad in views::Widget::~Widget() ui/views/widget/widget.cc:179:19 > #40 0xade9e6f in views::NativeWidgetAura::~NativeWidgetAura() ui/views/widget/native_widget_aura.cc > #41 0xadea10d in views::NativeWidgetAura::~NativeWidgetAura() ui/views/widget/native_widget_aura.cc:986:39 > #42 0xe11b498 in aura::Window::~Window() ui/aura/window.cc:123:16 > #43 0xe11c90d in aura::Window::~Window() ui/aura/window.cc:77:19 > #44 0xadeb043 in Invoke<const base::WeakPtr<views::NativeWidgetAura> &> base/bind_internal.h:196:12 > #45 0xadeb043 in MakeItSo<void (views::NativeWidgetAura::*const &)(), const base::WeakPtr<views::NativeWidgetAura> &> base/bind_internal.h:285 > #46 0xadeb043 in RunImpl<void (views::NativeWidgetAura::*const &)(), const std::__1::tuple<base::WeakPtr<views::NativeWidgetAura> > &, 0> base/bind_internal.h:340 > #47 0xadeb043 in base::internal::Invoker<base::internal::BindState<void (views::NativeWidgetAura::*)(), base::WeakPtr<views::NativeWidgetAura> >, void ()>::Run(base::internal::BindStateBase*) base/bind_internal.h:319 > #48 0xb35e805 in Run base/callback.h:91:12 > #49 0xb35e805 in base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) base/debug/task_annotator.cc:59 > #50 0xb3d46da in base::MessageLoop::RunTask(base::PendingTask*) base/message_loop/message_loop.cc:410:19 > #51 0xb3d5040 in base::MessageLoop::DeferOrRunPendingTask(base::PendingTask) base/message_loop/message_loop.cc:421:5 > #52 0xb3d5d81 in base::MessageLoop::DoWork() base/message_loop/message_loop.cc:528:13 > #53 0xb3e0820 in base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) base/message_loop/message_pump_libevent.cc:220:31 > #54 0xb3d3535 in base::MessageLoop::Run() base/message_loop/message_loop.cc:350:10 > #55 0xb472370 in base::RunLoop::Run() base/run_loop.cc:123:14 > #56 0x9304487 in RunThisRunLoop content/public/test/test_utils.cc:125:13 > #57 0x9304487 in content::RunAllPendingInMessageLoop() content/public/test/test_utils.cc:133 > #58 0x82fe2ba in InProcessBrowserTest::PostRunTestOnMainThread() chrome/test/base/in_process_browser_test.cc:607:3 > #59 0x92d79f8 in content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() content/public/test/browser_test_base.cc:319:5 > #60 0x83331b2 in Run base/callback.h:80:12 > #61 0x83331b2 in ChromeBrowserMainParts::PreMainMessageLoopRunImpl() chrome/browser/chrome_browser_main.cc:1857 > #62 0x83304b3 in ChromeBrowserMainParts::PreMainMessageLoopRun() chrome/browser/chrome_browser_main.cc:1210:18 > #63 0x4dff120 in chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() chrome/browser/chromeos/chrome_browser_main_chromeos.cc:655:32 > #64 0x2b32584 in content::BrowserMainLoop::PreMainMessageLoopRun() content/browser/browser_main_loop.cc:1151:13 > #65 0x3a66b08 in Run base/callback.h:80:12 > #66 0x3a66b08 in content::StartupTaskRunner::RunAllTasksNow() content/browser/startup_task_runner.cc:45 > #67 0x2b2d47f in content::BrowserMainLoop::CreateStartupTasks() content/browser/browser_main_loop.cc:935:25 > #68 0x2b3b21d in content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) content/browser/browser_main_runner.cc:131:17 > #69 0x2b252a6 in content::BrowserMain(content::MainFunctionParams const&) content/browser/browser_main.cc:42:32 > #70 0x8013aae in content::RunNamedProcessTypeMain(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, content::MainFunctionParams const&, content::ContentMainDelegate*) content/app/content_main_runner.cc:408:14 > #71 0x8015aa9 in content::ContentMainRunnerImpl::Run() content/app/content_main_runner.cc:690:12 > #72 0xe62b2ec in service_manager::Main(service_manager::MainParams const&) services/service_manager/embedder/main.cc:469:29 > #73 0x8011e73 in content::ContentMain(content::ContentMainParams const&) content/app/content_main.cc:19:10 > > Original change's description: > > Makes EmbeddedServiceRunner block until background thread completes > > > > Prior to this when EmbeddedServiceRunner was destroyed the background > > thread would most likely still be running. Worse yet it was entirely > > possible for ~InstanceManager to run on the same thread as the > > service was running on, which attempts to destroy thread_ (because it > > assumes thread_ was destroyed already). When this happens you hit a > > CHECK in thread_ because you can't join with a thread while you are on > > the thread. > > > > By making Shutdown() block until the background thread has said it's > > ready to be shutdown, and then destroy the thread from the initiating > > thread we never hit this situation. > > > > BUG=none > > TEST=covered by test > > > > Change-Id: I09ebc5167247e2e8a1b15b625fdff8dc8b8d2e8f > > Reviewed-on: https://chromium-review.googlesource.com/611392 > > Commit-Queue: Scott Violet <sky@chromium.org> > > Reviewed-by: Ken Rockot <rockot@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#493878} > > TBR=sky@chromium.org,rockot@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: none > Change-Id: Ib5a4bdf57e78f5ecb61983c6c29ca8f80d6da04f > Reviewed-on: https://chromium-review.googlesource.com/612810 > Reviewed-by: Nico Weber <thakis@chromium.org> > Commit-Queue: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#494001} TBR=sky@chromium.org,thakis@chromium.org,rockot@chromium.org Change-Id: I76836f34228a851b6c121a40ab57553ed3946f5f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: none Reviewed-on: https://chromium-review.googlesource.com/613641 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#494074}

This reverts commit 12d3ac7. Reason for revert: Some DemoAppLauncherTest.* and ChromeLauncherController.* tests failing on Linux ChromiumOS MSan Tests. https://build.chromium.org/p/chromium.memory/builders/Linux%20ChromiumOS%20MSan%20Tests/builds/2997 Example logs: [ RUN ] DemoAppLauncherTest.NoNetwork [13368:13368:0915/161331.895126:ERROR:input_method_manager_impl.cc(1028)] IMEEngine for "fgoepimhcoialccpbmpnnblemnepkkao" is not registered [13368:13443:0915/161332.029936:WARNING:freezer_cgroup_process_manager.cc(62)] Cgroup freezer does not exist or is not writable. Unable to freeze renderer processes. [13368:13368:0915/161332.155113:ERROR:touch_devices_controller.cc(22)] Failed to set touchpad enabled state. [13368:13368:0915/161334.670608:WARNING:CONSOLE(0)] "Styling master document from stylesheets defined in HTML Imports is deprecated, and is planned to be removed in M65, around March 2018. Please refer to https://goo.gl/EGXzpw for possible migration paths.", source: (0) [13368:13368:0915/161419.402418:ERROR:device_event_log_impl.cc(156)] [16:14:19.402] Network: network_state_handler.cc:185 SetTechnologyEnabled() called for the Tether DeviceState, but the current state was: 0 [13368:13368:0915/161419.456610:INFO:CONSOLE(9476)] "Loading asset bundle oauth-enrollment", source: chrome://oobe/oobe.js (9476) [13368:13368:0915/161419.495392:ERROR:kiosk_profile_loader.cc(113)] Cryptohome is mounted before launching kiosk app. [13368:13368:0915/161419.683256:ERROR:input_method_manager_impl.cc(1028)] IMEEngine for "fgoepimhcoialccpbmpnnblemnepkkao" is not registered [13368:13368:0915/161419.786358:ERROR:profile_helper.cc(344)] ProfileHelper::GetProfileByUserUnsafe is called when |user|'s profile is not created. It probably means that something is wrong with a calling code. Please report in http://crbug.com/361528 if you see this message. [13368:13368:0915/161419.786447:ERROR:profile_helper.cc(344)] ProfileHelper::GetProfileByUserUnsafe is called when |user|'s profile is not created. It probably means that something is wrong with a calling code. Please report in http://crbug.com/361528 if you see this message. [13368:13368:0915/161419.786529:ERROR:profile_helper.cc(344)] ProfileHelper::GetProfileByUserUnsafe is called when |user|'s profile is not created. It probably means that something is wrong with a calling code. Please report in http://crbug.com/361528 if you see this message. [13368:13368:0915/161419.791385:WARNING:demo_app_launcher.cc(91)] Disabling network before launching demo app.. [13368:13368:0915/161419.791569:ERROR:device_event_log_impl.cc(156)] [16:14:19.791] Network: network_state_handler.cc:185 SetTechnologyEnabled() called for the Tether DeviceState, but the current state was: 0 [13368:13368:0915/161419.823204:ERROR:profile_helper.cc(344)] ProfileHelper::GetProfileByUserUnsafe is called when |user|'s profile is not created. It probably means that something is wrong with a calling code. Please report in http://crbug.com/361528 if you see this message. [13368:13368:0915/161419.908166:ERROR:multi_user_window_manager_stub.cc(60)] Not implemented reached in virtual void chrome::MultiUserWindowManagerStub::RemoveObserver(chrome::MultiUserWindowManager::Observer *) [13368:13368:0915/161420.126551:ERROR:touch_devices_controller.cc(22)] Failed to set touchpad enabled state. [13368:13368:0915/161421.334333:ERROR:device_event_log_impl.cc(156)] [16:14:21.334] Network: network_state_handler.cc:185 SetTechnologyEnabled() called for the Tether DeviceState, but the current state was: 0 ==13368==WARNING: MemorySanitizer: use-of-uninitialized-value #0 0x174c40a2 in HasObserver base/observer_list.h:299:3 #1 0x174c40a2 in aura::Window::HasObserver(aura::WindowObserver const*) const ui/aura/window.cc:488:0 #2 0x174e2185 in aura::WindowObserver::OnUnobservingWindow(aura::Window*) ui/aura/window_observer.cc:25:15 #3 0x174b9b34 in aura::Window::RemoveObserver(aura::WindowObserver*) ui/aura/window.cc:483:13 #4 0x1ca8ce6d in RemoveAll base/scoped_observer.h:45:20 #5 0x1ca8ce6d in ~ScopedObserver base/scoped_observer.h:26:0 #6 0x1ca8ce6d in AppWindowLauncherItemController::~AppWindowLauncherItemController() chrome/browser/ui/ash/launcher/app_window_launcher_item_controller.cc:25:0 #7 0x1c27609c in ~ExtensionAppWindowLauncherItemController chrome/browser/ui/ash/launcher/extension_app_window_launcher_item_controller.cc:23:50 #8 0x1c27609c in ExtensionAppWindowLauncherItemController::~ExtensionAppWindowLauncherItemController() chrome/browser/ui/ash/launcher/extension_app_window_launcher_item_controller.cc:23:0 #9 0x1b242b8e in operator() buildtools/third_party/libc++/trunk/include/memory:2272:5 #10 0x1b242b8e in reset buildtools/third_party/libc++/trunk/include/memory:2585:0 #11 0x1b242b8e in ~unique_ptr buildtools/third_party/libc++/trunk/include/memory:2539:0 #12 0x1b242b8e in ~pair buildtools/third_party/libc++/trunk/include/utility:312:0 #13 0x1b242b8e in __destroy<std::__1::pair<const ash::ShelfID, std::__1::unique_ptr<ash::ShelfItemDelegate, std::__1::default_delete<ash::ShelfItemDelegate> > > > buildtools/third_party/libc++/trunk/include/memory:1726:0 #14 0x1b242b8e in destroy<std::__1::pair<const ash::ShelfID, std::__1::unique_ptr<ash::ShelfItemDelegate, std::__1::default_delete<ash::ShelfItemDelegate> > > > buildtools/third_party/libc++/trunk/include/memory:1589:0 #15 0x1b242b8e in std::__1::__tree<std::__1::__value_type<ash::ShelfID, std::__1::unique_ptr<ash::ShelfItemDelegate, std::__1::default_delete<ash::ShelfItemDelegate> > >, std::__1::__map_value_compare<ash::ShelfID, std::__1::__value_type<ash::ShelfID, std::__1::unique_ptr<ash::ShelfItemDelegate, std::__1::default_delete<ash::ShelfItemDelegate> > >, std::__1::less<ash::ShelfID>, true>, std::__1::allocator<std::__1::__value_type<ash::ShelfID, std::__1::unique_ptr<ash::ShelfItemDelegate, std::__1::default_delete<ash::ShelfItemDelegate> > > > >::destroy(std::__1::__tree_node<std::__1::__value_type<ash::ShelfID, std::__1::unique_ptr<ash::ShelfItemDelegate, std::__1::default_delete<ash::ShelfItemDelegate> > >, void*>*) buildtools/third_party/libc++/trunk/include/__tree:1831:0 #16 0x1b23d0cc in clear buildtools/third_party/libc++/trunk/include/__tree:1868:5 #17 0x1b23d0cc in clear buildtools/third_party/libc++/trunk/include/map:1202:0 #18 0x1b23d0cc in ash::ShelfModel::DestroyItemDelegates() ash/public/cpp/shelf_model.cc:118:0 #19 0x1b405026 in ash::Shell::~Shell() ash/shell.cc:787:18 #20 0x1b40bacc in ash::Shell::~Shell() ash/shell.cc:645:17 #21 0x1ca7ba24 in AshInit::~AshInit() chrome/browser/ui/ash/ash_init.cc:143:5 #22 0x1c2ba774 in operator() buildtools/third_party/libc++/trunk/include/memory:2272:5 #23 0x1c2ba774 in reset buildtools/third_party/libc++/trunk/include/memory:2585:0 #24 0x1c2ba774 in ChromeBrowserMainExtraPartsAsh::PostMainMessageLoopRun() chrome/browser/ui/views/ash/chrome_browser_main_extra_parts_ash.cc:167:0 #25 0xf69ca8d in ChromeBrowserMainParts::PostMainMessageLoopRun() chrome/browser/chrome_browser_main.cc:1948:29 #26 0x6047fc8 in chromeos::ChromeBrowserMainPartsChromeos::PostMainMessageLoopRun() chrome/browser/chromeos/chrome_browser_main_chromeos.cc:1132:32 #27 0x8e976d2 in content::BrowserMainLoop::ShutdownThreadsAndCleanUp() content/browser/browser_main_loop.cc:1221:13 #28 0x8ea2b09 in content::BrowserMainRunnerImpl::Shutdown() content/browser/browser_main_runner.cc:208:19 #29 0x8e812fa in content::BrowserMain(content::MainFunctionParams const&) content/browser/browser_main.cc:48:16 #30 0xef181a0 in content::RunNamedProcessTypeMain(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, content::MainFunctionParams const&, content::ContentMainDelegate*) content/app/content_main_runner.cc:425:14 #31 0xef1b0bf in content::ContentMainRunnerImpl::Run() content/app/content_main_runner.cc:703:12 #32 0x17b48a92 in service_manager::Main(service_manager::MainParams const&) services/service_manager/embedder/main.cc:469:29 #33 0xef14897 in content::ContentMain(content::ContentMainParams const&) content/app/content_main.cc:19:10 #34 0x10cc6dd9 in content::BrowserTestBase::SetUp() content/public/test/browser_test_base.cc:272:3 #35 0xf55dd6e in InProcessBrowserTest::SetUp() chrome/test/base/in_process_browser_test.cc:267:20 #36 0x4db800a in chromeos::DemoAppLauncherTest::SetUp() chrome/browser/chromeos/login/demo_mode/demo_app_launcher_browsertest.cc:82:27 #37 0x6d99a6b in HandleExceptionsInMethodIfSupported<testing::Test, void> third_party/googletest/src/googletest/src/gtest.cc:2456:12 #38 0x6d99a6b in testing::Test::Run() third_party/googletest/src/googletest/src/gtest.cc:2468:0 #39 0x6d9d617 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2654:11 #40 0x6d9eff9 in testing::TestCase::Run() third_party/googletest/src/googletest/src/gtest.cc:2772:28 #41 0x6dc00b4 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:4677:43 #42 0x6dbef29 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> third_party/googletest/src/googletest/src/gtest.cc:2456:12 #43 0x6dbef29 in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc:4285:0 #44 0xf5cbe63 in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2237:46 #45 0xf5cbe63 in base::TestSuite::Run() base/test/test_suite.cc:270:0 #46 0xf08e61d in ChromeTestSuiteRunner::RunTestSuite(int, char**) chrome/test/base/chrome_test_launcher.cc:70:38 #47 0x10e110fe in content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) content/public/test/test_launcher.cc:520:31 #48 0xf08f6f3 in LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) chrome/test/base/chrome_test_launcher.cc:160:10 #49 0xf0837d1 in main chrome/test/base/browser_tests_main_chromeos.cc:26:10 #50 0x7f354fa64f44 in __libc_start_main /build/eglibc-SvCtMH/eglibc-2.19/csu/libc-start.c:287:0 #51 0x915d0f in _start ??:0:0 Uninitialized value was created by a heap deallocation #0 0x983709 in operator delete(void*) ??:0:0 #1 0x1b36ccdc in ash::RootWindowController::CloseChildWindows() ash/root_window_controller.cc:536:7 #2 0x1b40b74a in ash::Shell::CloseAllRootWindowChildWindows() ash/shell.cc:1183:19 #3 0x1b404248 in ash::Shell::~Shell() ash/shell.cc:732:3 #4 0x1b40bacc in ash::Shell::~Shell() ash/shell.cc:645:17 #5 0x1ca7ba24 in AshInit::~AshInit() chrome/browser/ui/ash/ash_init.cc:143:5 #6 0x1c2ba774 in operator() buildtools/third_party/libc++/trunk/include/memory:2272:5 #7 0x1c2ba774 in reset buildtools/third_party/libc++/trunk/include/memory:2585:0 #8 0x1c2ba774 in ChromeBrowserMainExtraPartsAsh::PostMainMessageLoopRun() chrome/browser/ui/views/ash/chrome_browser_main_extra_parts_ash.cc:167:0 #9 0xf69ca8d in ChromeBrowserMainParts::PostMainMessageLoopRun() chrome/browser/chrome_browser_main.cc:1948:29 #10 0x6047fc8 in chromeos::ChromeBrowserMainPartsChromeos::PostMainMessageLoopRun() chrome/browser/chromeos/chrome_browser_main_chromeos.cc:1132:32 #11 0x8e976d2 in content::BrowserMainLoop::ShutdownThreadsAndCleanUp() content/browser/browser_main_loop.cc:1221:13 #12 0x8ea2b09 in content::BrowserMainRunnerImpl::Shutdown() content/browser/browser_main_runner.cc:208:19 #13 0x8e812fa in content::BrowserMain(content::MainFunctionParams const&) content/browser/browser_main.cc:48:16 #14 0xef181a0 in content::RunNamedProcessTypeMain(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, content::MainFunctionParams const&, content::ContentMainDelegate*) content/app/content_main_runner.cc:425:14 #15 0xef1b0bf in content::ContentMainRunnerImpl::Run() content/app/content_main_runner.cc:703:12 #16 0x17b48a92 in service_manager::Main(service_manager::MainParams const&) services/service_manager/embedder/main.cc:469:29 #17 0xef14897 in content::ContentMain(content::ContentMainParams const&) content/app/content_main.cc:19:10 #18 0x10cc6dd9 in content::BrowserTestBase::SetUp() content/public/test/browser_test_base.cc:272:3 #19 0xf55dd6e in InProcessBrowserTest::SetUp() chrome/test/base/in_process_browser_test.cc:267:20 #20 0x4db800a in chromeos::DemoAppLauncherTest::SetUp() chrome/browser/chromeos/login/demo_mode/demo_app_launcher_browsertest.cc:82:27 #21 0x6d99a6b in HandleExceptionsInMethodIfSupported<testing::Test, void> third_party/googletest/src/googletest/src/gtest.cc:2456:12 #22 0x6d99a6b in testing::Test::Run() third_party/googletest/src/googletest/src/gtest.cc:2468:0 SUMMARY: MemorySanitizer: use-of-uninitialized-value (/b/s/w/ir/out/Release/browser_tests+0x174c40a2) Exiting [1:10:0100/000000.399335:ERROR:broker_posix.cc(40)] Recvmsg error: Connection reset by peer (104) Original change's description: > cros: Unify cash and mash ChromeLauncherController management. > > Refine ChromeLauncherController lifetime management. > (always use the new ChromeLauncherControllerInitializer) > > Remove ShellDelegate::ShelfInit and ShelfShutdown. > Remove ShelfInitializer (tests/shell init via default prefs). > Cleanup (std::make_unique, TestShellDelegate usage, etc) > Reorder display update test expectations (unclear what changed...) > > Bug: 557406, 681072 > Change-Id: I5cd35b711c1d96761ac2204f7ba738eef58829ab > Reviewed-on: https://chromium-review.googlesource.com/667838 > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Reviewed-by: James Cook <jamescook@chromium.org> > Commit-Queue: Michael Wasserman <msw@chromium.org> > Cr-Commit-Position: refs/heads/master@{#502376} TBR=jamescook@chromium.org,msw@chromium.org,oshima@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 557406, 681072 Change-Id: Ib4c82e867423df08a2fa4218788bd6316ef29284 Reviewed-on: https://chromium-review.googlesource.com/670684 Commit-Queue: Max Morin <maxmorin@chromium.org> Reviewed-by: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#502538}

Both MediaControlsOrientationLockDelegate and MediaControlsRotateToFullscreenDelegate would incorrectly call ToDeviceOrientationEvent on synthetic events created by the webpage whose type name was "deviceorientation", even if they weren't instances of DeviceOrientationEvent. This patch fixes that. It also checks that the events are trusted, to avoid using deviceorientation values synthesized by the webpage (other event listeners in these classes don't use values from the event object, so it's less important for them to be trusted). TBR=johnme@chromium.org (cherry picked from commit cd76873) Bug: 761613,760737 Change-Id: I318d10e3b6dd84277a47b06546fd4c3ebcdb03cb Reviewed-on: https://chromium-review.googlesource.com/647929 Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: John Mellor <johnme@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#499515} Reviewed-on: https://chromium-review.googlesource.com/650728 Reviewed-by: John Mellor <johnme@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{Igalia#25} Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}

This reverts commit 4b214c7. Reason for revert: Breaks WebRTC Chromium Linux Tester bot See https://build.chromium.org/p/chromium.webrtc/builders/Linux%20Tester/builds/32384 Sample crash logs: BrowserTestBase received signal: Terminated. Backtrace: #0 0x00000460fa17 base::debug::StackTrace::StackTrace() #1 0x000004ab4b81 content::(anonymous namespace)::DumpStackTraceSignalHandler() #2 0x7f4401164d40 <unknown> #3 0x7f440121b12d __poll #4 0x7f44066e8fe4 <unknown> #5 0x7f44066e90ec g_main_context_iteration #6 0x00000462c603 base::MessagePumpGlib::Run() #7 0x00000464c285 base::RunLoop::Run() #8 0x000004ae51d1 content::MessageLoopRunner::Run() #9 0x000004ab8a28 content::DOMMessageQueue::WaitForMessage() #10 0x000004ab78e9 content::(anonymous namespace)::ExecuteScriptHelper() #11 0x000004ab751e content::ExecuteScriptAndExtractString() #12 0x000002375eb5 test::SleepInJavascript() #13 0x000002376300 test::PollingWaitUntil() #14 0x00000236242f WebRtcApprtcBrowserTest_MANUAL_FirefoxApprtcInteropTest_Test::RunTestOnMainThread() #15 0x000004ab48ef content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #16 0x000004702d7c ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #17 0x000004701bba ChromeBrowserMainParts::PreMainMessageLoopRun() #18 0x0000036b9d9d content::BrowserMainLoop::PreMainMessageLoopRun() #19 0x0000039d72e7 content::StartupTaskRunner::RunAllTasksNow() #20 0x0000036b816d content::BrowserMainLoop::CreateStartupTasks() #21 0x0000036bc5d1 content::BrowserMainRunnerImpl::Initialize() #22 0x0000036b57c2 content::BrowserMain() #23 0x0000045f9f11 content::ContentMainRunnerImpl::Run() #24 0x000005f8797d service_manager::Main() #25 0x0000045f8a52 content::ContentMain() #26 0x000004ab45c5 content::BrowserTestBase::SetUp() #27 0x0000046b2fdb InProcessBrowserTest::SetUp() #28 0x00000310c34e testing::Test::Run() #29 0x00000310ce80 testing::TestInfo::Run() #30 0x00000310d367 testing::TestCase::Run() #31 0x000003113857 testing::internal::UnitTestImpl::RunAllTests() #32 0x0000031134e3 testing::UnitTest::Run() #33 0x0000046c5558 base::TestSuite::Run() #34 0x00000460515a ChromeTestSuiteRunner::RunTestSuite() #35 0x000004adf183 content::LaunchTests() #36 0x00000460551e LaunchChromeTests() #37 0x0000046050c7 main #38 0x7f440114fec5 __libc_start_main Original change's description: > Re-enabling Firefox interop test. > > The fix is now in the Firefox nightly; verified the test passes > locally. > > I will land https://webrtc-review.googlesource.com/c/webrtc.DEPS/+/6820 > in case the bot still has a problem with ff sandboxing, and then > try to turn that off. If that fails, the test is at least running > again and we can follow up more with mozilla why the bot fails to > play audio but not my workstation. > > Bug: 751211 > Change-Id: I34f7293a123424c9077f12559713597bba294c01 > Reviewed-on: https://chromium-review.googlesource.com/702240 > Reviewed-by: Henrik Kjellander <kjellander@chromium.org> > Commit-Queue: Patrik Höglund <phoglund@chromium.org> > Cr-Commit-Position: refs/heads/master@{#507367} TBR=kjellander@chromium.org,phoglund@chromium.org Change-Id: I1df253a052610b89fc27e8045005252165fb5be3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 751211 Reviewed-on: https://chromium-review.googlesource.com/707274 Reviewed-by: Guido Urdaneta <guidou@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#507391}

This reverts commit c31e389. Reason for revert: Breaks WebRTC Linux Tester bot. See https://build.chromium.org/p/chromium.webrtc/builders/Linux%20Tester/builds/32405 Sample error logs: [32472:32472:1010/094403.887663:INFO:CONSOLE(38)] "5.152: Remote candidate added successfully.", source: http://localhost:9999/js/apprtc.debug.js (38) BrowserTestBase received signal: Terminated. Backtrace: #0 0x0000046c1737 base::debug::StackTrace::StackTrace() #1 0x000004b58761 content::(anonymous namespace)::DumpStackTraceSignalHandler() #2 0x7f9988abdd40 <unknown> #3 0x7f9988b7412d __poll #4 0x7f998e041fe4 <unknown> #5 0x7f998e0420ec g_main_context_iteration #6 0x0000046de263 base::MessagePumpGlib::Run() #7 0x0000046fdee5 base::RunLoop::Run() #8 0x000004b88da1 content::MessageLoopRunner::Run() #9 0x000004b5c5f8 content::DOMMessageQueue::WaitForMessage() #10 0x000004b5b4c9 content::(anonymous namespace)::ExecuteScriptHelper() #11 0x000004b5b0fe content::ExecuteScriptAndExtractString() #12 0x00000237c1a5 test::SleepInJavascript() #13 0x00000237c5f0 test::PollingWaitUntil() #14 0x00000236871f WebRtcApprtcBrowserTest_MANUAL_FirefoxApprtcInteropTest_Test::RunTestOnMainThread() #15 0x000004b584cf content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #16 0x0000047ac9dc ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #17 0x0000047ab81a ChromeBrowserMainParts::PreMainMessageLoopRun() #18 0x00000376838d content::BrowserMainLoop::PreMainMessageLoopRun() #19 0x000003a856f7 content::StartupTaskRunner::RunAllTasksNow() #20 0x00000376675d content::BrowserMainLoop::CreateStartupTasks() #21 0x00000376abc1 content::BrowserMainRunnerImpl::Initialize() #22 0x000003763db2 content::BrowserMain() #23 0x0000046abbb1 content::ContentMainRunnerImpl::Run() #24 0x000005f9d89d service_manager::Main() #25 0x0000046aa6f2 content::ContentMain() #26 0x000004b581a5 content::BrowserTestBase::SetUp() #27 0x00000475c6db InProcessBrowserTest::SetUp() #28 0x0000031143ee testing::Test::Run() #29 0x000003114f20 testing::TestInfo::Run() #30 0x000003115407 testing::TestCase::Run() #31 0x00000311b8f7 testing::internal::UnitTestImpl::RunAllTests() #32 0x00000311b583 testing::UnitTest::Run() #33 0x00000476ec58 base::TestSuite::Run() #34 0x0000046b6e7a ChromeTestSuiteRunner::RunTestSuite() #35 0x000004b82d53 content::LaunchTests() #36 0x0000046b723e LaunchChromeTests() #37 0x0000046b6de7 main #38 0x7f9988aa8ec5 __libc_start_main #39 0x0000020dc029 <unknown> 2017/10/10 09:49:21 Deregistered client 43795133 from room some_room [76/76] WebRtcApprtcBrowserTest.MANUAL_FirefoxApprtcInteropTest (TIMED OUT) Original change's description: > Re-enable ff interop test, without adding thread restrictions. > > I suspect the thread restrictions I added in my last patch made the > test hang, so let's try just enabling it. The error prevented by > the thread restrictions is only thrown in debug mode anyway. > > Bug: 751211 > Change-Id: I8be06ce061e4111ea844b54ff52d8c9e79b43915 > Reviewed-on: https://chromium-review.googlesource.com/708795 > Reviewed-by: Henrik Kjellander <kjellander@chromium.org> > Commit-Queue: Patrik Höglund <phoglund@chromium.org> > Cr-Commit-Position: refs/heads/master@{#507651} TBR=kjellander@chromium.org,phoglund@chromium.org Change-Id: Ib74f9efd3274384197b23c0a820260c406995e89 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 751211 Reviewed-on: https://chromium-review.googlesource.com/709794 Reviewed-by: Guido Urdaneta <guidou@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#507701}

On lock screen, click shutdown. Stack: #0 0x56392661eb8c base::debug::StackTrace::StackTrace() #1 0x56392663263c logging::LogMessage::~LogMessage() #2 0x56392521a9ba content::RenderProcessHostImpl::RenderProcessHostImpl() #3 0x56392521a295 content::RenderProcessHostImpl::CreateRenderProcessHost() #4 0x56392521a3a8 content::RenderProcessHostImpl::CreateOrUseSpareRenderProcessHost() #5 0x563925227b71 content::RenderProcessHostImpl::GetProcessHostForSiteInstance() #6 0x5639252dc6d3 content::SiteInstanceImpl::GetProcess() #7 0x5639253098f0 content::WebContentsImpl::Init() #8 0x5639252ff5b8 content::WebContentsImpl::CreateWithOpener() #9 0x5639252ff338 content::WebContents::Create() #10 0x5639289187d6 views::WebView::CreateWebContents() #11 0x56392891870a views::WebView::GetWebContents() #12 0x563925751b3a ChromeVoxPanel::ChromeVoxPanel() #13 0x56392574ed36 chromeos::AccessibilityManager::ReloadChromeVoxPanel() #14 0x563928581f73 session_manager::SessionManager::SetSessionState() #15 0x5639258868ae chromeos::ScreenLocker::~ScreenLocker() #16 0x563925886a7e chromeos::ScreenLocker::~ScreenLocker() #17 0x563925886337 chromeos::ScreenLocker::ScheduleDeletion() #18 0x5639257e27fa chromeos::ChromeBrowserMainPartsChromeos::PostMainMessageLoopRun() #19 0x563924faee88 content::BrowserMainLoop::ShutdownThreadsAndCleanUp() #20 0x563924fb17cf content::BrowserMainRunnerImpl::Shutdown() #21 0x563924faaec8 content::BrowserMain() #22 0x56392635a7a5 content::ContentMainRunnerImpl::Run() #23 0x5639263625f6 service_manager::Main() #24 0x563926359344 content::ContentMain() #25 0x5639247fd386 ChromeMain #26 0x7f2fdc2c9f45 __libc_start_main Bug: Change-Id: I2ff90d96c9bf1254625f098e004d9b3a7d272c10 Reviewed-on: https://chromium-review.googlesource.com/838180 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#525895}

…er." This reverts commit 2453e47. Reason for revert: causing MSAN failures on https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20MSan%20Tests [ RUN ] NavigationControllerTest.PurgeScreenshot ==7007==WARNING: MemorySanitizer: use-of-uninitialized-value #0 0x8a3a26f in round ./../../third_party/skia/src/jumper/SkJumper_stages.cpp:462:41 #1 0x8a3a26f in to_unorm ./../../third_party/skia/src/jumper/SkJumper_stages.cpp:905:0 #2 0x8a3a26f in store_a8_k ./../../third_party/skia/src/jumper/SkJumper_stages.cpp:1584:0 #3 0x8a3a26f in sk_store_a8 ./../../third_party/skia/src/jumper/SkJumper_stages.cpp:1581:0 #4 0x8a234d9 in sk_start_pipeline ./../../third_party/skia/src/jumper/SkJumper_stages.cpp:755:13 #5 0x86a6c88 in operator() ./../../buildtools/third_party/libc++/trunk/include/functional:1916:12 #6 0x86a6c88 in SkRasterPipelineBlitter::blitRect(int, int, int, int) ./../../third_party/skia/src/core/SkRasterPipelineBlitter.cpp:352:0 #7 0x873337f in blitrect ./../../third_party/skia/src/core/SkScan.cpp:25:14 #8 0x873337f in SkScan::FillIRect(SkIRect const&, SkRegion const*, SkBlitter*) ./../../third_party/skia/src/core/SkScan.cpp:36:0 #9 0x873497d in FillRect ./../../third_party/skia/src/core/SkScan.cpp:71:5 #10 0x873497d in SkScan::FillRect(SkRect const&, SkRasterClip const&, SkBlitter*) ./../../third_party/skia/src/core/SkScan.cpp:113:0 #11 0x849775d in SkDraw::drawRect(SkRect const&, SkPaint const&, SkMatrix const*, SkRect const*) const ./../../third_party/skia/src/core/SkDraw.cpp:814:21 #12 0x849ee7b in SkDraw::drawBitmap(SkBitmap const&, SkMatrix const&, SkRect const*, SkPaint const&) const ./../../third_party/skia/src/core/SkDraw.h:0:15 #13 0x836e327 in SkBitmapDevice::drawBitmap(SkBitmap const&, float, float, SkPaint const&) ./../../third_party/skia/src/core/SkBitmapDevice.cpp:233:18 #14 0x83fb1fe in SkCanvas::onDrawBitmap(SkBitmap const&, float, float, SkPaint const*) ./../../third_party/skia/src/core/SkCanvas.cpp:2309:27 #15 0x83ea9fa in SkCanvas::drawBitmap(SkBitmap const&, float, float, SkPaint const*) ./../../third_party/skia/src/core/SkCanvas.cpp:1837:11 #16 0xd832b25 in content::ScreenshotData::EncodeOnWorker(SkBitmap const&) ./../../content/browser/frame_host/navigation_entry_screenshot_manager.cc:60:14 #17 0x1151efaf in Run ./../../base/callback.h:65:12 #18 0x1151efaf in base::(anonymous namespace)::PostTaskAndReplyRelay::RunTaskAndPostReply() ./../../base/threading/post_task_and_reply_impl.cc:45:0 #19 0x1132685a in Run ./../../base/callback.h:65:12 #20 0x1132685a in base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) ./../../base/debug/task_annotator.cc:55:0 #21 0x114ee940 in base::internal::TaskTracker::RunOrSkipTask(base::internal::Task, base::internal::Sequence*, bool) ./../../base/task_scheduler/task_tracker.cc:441:23 #22 0x114f5b30 in base::internal::TaskTrackerPosix::RunOrSkipTask(base::internal::Task, base::internal::Sequence*, bool) ./../../base/task_scheduler/task_tracker_posix.cc:25:16 #23 0xf099880 in base::test::ScopedTaskEnvironment::TestTaskTracker::RunOrSkipTask(base::internal::Task, base::internal::Sequence*, bool) ./../../base/test/scoped_task_environment.cc:280:49 #24 0x114ec1e0 in base::internal::TaskTracker::RunNextTask(scoped_refptr<base::internal::Sequence>, base::internal::CanScheduleSequenceObserver*) ./../../base/task_scheduler/task_tracker.cc:343:3 #25 0x114dece1 in base::internal::SchedulerWorker::Thread::ThreadMain() ./../../base/task_scheduler/scheduler_worker.cc:81:41 #26 0x1151e887 in base::(anonymous namespace)::ThreadFunc(void*) ./../../base/threading/platform_thread_posix.cc:75:13 #27 0x7fe34df7e183 in start_thread /build/eglibc-SvCtMH/eglibc-2.19/nptl/pthread_create.c:312:0 #28 0x7fe346aceffc in clone /build/eglibc-SvCtMH/eglibc-2.19/misc/../sysdeps/unix/sysv/linux/x86_64/clone.S:111:0 Uninitialized value was created by a heap allocation #0 0x16e48ed in __interceptor_malloc /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/msan/msan_interceptors.cc:944:3 #1 0x11448cb9 in base::UncheckedMalloc(unsigned long, void**) ./../../base/process/memory_linux.cc:105:13 #2 0xfeb9235 in malloc_nothrow ./../../skia/ext/SkMemory_new_handler.cpp:76:19 #3 0xfeb9235 in sk_malloc_flags(unsigned long, unsigned int) ./../../skia/ext/SkMemory_new_handler.cpp:115:0 #4 0x853330b in sk_malloc_canfail ./../../third_party/skia/include/private/SkMalloc.h:93:12 #5 0x853330b in MakeUsing ./../../third_party/skia/src/core/SkMallocPixelRef.cpp:76:0 #6 0x853330b in SkMallocPixelRef::MakeAllocate(SkImageInfo const&, unsigned long) ./../../third_party/skia/src/core/SkMallocPixelRef.cpp:86:0 #7 0x835ead5 in SkBitmap::tryAllocPixels(SkImageInfo const&, unsigned long) ./../../third_party/skia/src/core/SkBitmap.cpp:235:28 #8 0xd8328df in tryAllocPixels ./../../third_party/skia/include/core/SkBitmap.h:517:22 #9 0xd8328df in content::ScreenshotData::EncodeOnWorker(SkBitmap const&) ./../../content/browser/frame_host/navigation_entry_screenshot_manager.cc:55:0 #10 0x1151efaf in Run ./../../base/callback.h:65:12 #11 0x1151efaf in base::(anonymous namespace)::PostTaskAndReplyRelay::RunTaskAndPostReply() ./../../base/threading/post_task_and_reply_impl.cc:45:0 #12 0x1132685a in Run ./../../base/callback.h:65:12 #13 0x1132685a in base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) ./../../base/debug/task_annotator.cc:55:0 #14 0x114ee940 in base::internal::TaskTracker::RunOrSkipTask(base::internal::Task, base::internal::Sequence*, bool) ./../../base/task_scheduler/task_tracker.cc:441:23 #15 0x114f5b30 in base::internal::TaskTrackerPosix::RunOrSkipTask(base::internal::Task, base::internal::Sequence*, bool) ./../../base/task_scheduler/task_tracker_posix.cc:25:16 #16 0xf099880 in base::test::ScopedTaskEnvironment::TestTaskTracker::RunOrSkipTask(base::internal::Task, base::internal::Sequence*, bool) ./../../base/test/scoped_task_environment.cc:280:49 #17 0x114ec1e0 in base::internal::TaskTracker::RunNextTask(scoped_refptr<base::internal::Sequence>, base::internal::CanScheduleSequenceObserver*) ./../../base/task_scheduler/task_tracker.cc:343:3 #18 0x114dece1 in base::internal::SchedulerWorker::Thread::ThreadMain() ./../../base/task_scheduler/scheduler_worker.cc:81:41 #19 0x1151e887 in base::(anonymous namespace)::ThreadFunc(void*) ./../../base/threading/platform_thread_posix.cc:75:13 #20 0x7fe34df7e183 in start_thread /build/eglibc-SvCtMH/eglibc-2.19/nptl/pthread_create.c:312:0 Original change's description: > Move grayscale conversion into NavigationEntryScreenshotManager. > > Changes the location of the RGB→Grayscale conversion of the > CopyFromSurface() result SkBitmap to be in > NavigationEntryScreenshotManager, as it is the only use case. This > unblocks a massive clean-up effort for bug 759310. > > For reference, the following was the code that was doing the conversion > before (and is a part of a major chunk of code that we want to delete): > https://cs.chromium.org/chromium/src/content/browser/compositor/surface_utils.cc?rcl=2fe7073e23caa42cbd01575ab206ba8928ccd645&l=146 > > Bug: 759310 > Change-Id: I2687e69b284d5c24ead10b05b49f678cf8375651 > Reviewed-on: https://chromium-review.googlesource.com/919603 > Commit-Queue: Yuri Wiitala <miu@chromium.org> > Reviewed-by: Nick Carter <nick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#536929} TBR=miu@chromium.org,nick@chromium.org Change-Id: I3de0c04ca25b20ed2322f76834d19e7a7fae4737 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 759310 Reviewed-on: https://chromium-review.googlesource.com/921243 Reviewed-by: Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#536990}

This reverts commit 848aaee. Reason for revert: broke OOPBrowserTest.Basic https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20ChromiumOS%20MSan%20Tests #0 0x000000634a81 in __interceptor_backtrace /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/msan/../sanitizer_common/sanitizer_common_interceptors.inc:3955:13 #1 0x00000be3764f in base::debug::StackTrace::StackTrace(unsigned long) ./../../base/debug/stack_trace_posix.cc:808:41 #2 0x00000ab5b871 in content::(anonymous namespace)::DumpStackTraceSignalHandler(int) ./../../content/public/test/browser_test_base.cc:86:5 #3 0x00000065aff9 in SignalHandler(int) /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/msan/msan_interceptors.cc:1049:3 #4 0x7f9e01eaccb0 in killpg ??:? #5 0x7f9e01eaccb0 in ?? ??:0 #6 0x7f9e01f74693 in epoll_wait /build/eglibc-SvCtMH/eglibc-2.19/misc/../sysdeps/unix/syscall-template.S:81:0 #7 0x00000061d970 in __interceptor_epoll_wait /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/msan/msan_interceptors.cc:891:13 #8 0x00000c1936a7 in epoll_dispatch ./../../base/third_party/libevent/epoll.c:198:8 #9 0x00000c186a2c in event_base_loop ./../../base/third_party/libevent/event.c:512:9 #10 0x00000beb8dce in base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) ./../../base/message_loop/message_pump_libevent.cc:257:9 #11 0x00000bf5c000 in base::RunLoop::Run() ./../../base/run_loop.cc:133:14 #12 0x00000abdc529 in RunThisRunLoop ./../../content/public/test/test_utils.cc:124:13 #13 0x00000abdc529 in content::MessageLoopRunner::Run() ./../../content/public/test/test_utils.cc:241:0 #14 0x00000ab26d69 in content::NavigateToURLBlockUntilNavigationsComplete(content::Shell*, GURL const&, int) ./../../content/public/test/content_browser_test_utils.cc:49:21 #15 0x0000017ed89f in content::(anonymous namespace)::OOPBrowserTest_Basic_Test::RunTestOnMainThread() ./../../content/browser/oop_browsertest.cc:67:3 #16 0x00000ab5ad40 in content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() ./../../content/public/test/browser_test_base.cc:353:5 #17 0x00000ad8063f in Run ./../../base/callback.h:124:12 #18 0x00000ad8063f in content::ShellBrowserMainParts::PreMainMessageLoopRun() ./../../content/shell/browser/shell_browser_main_parts.cc:208:0 #19 0x000008847e8c in content::BrowserMainLoop::PreMainMessageLoopRun() ./../../content/browser/browser_main_loop.cc:1105:13 #20 0x000009ce2bd1 in Run ./../../base/callback.h:124:12 #21 0x000009ce2bd1 in content::StartupTaskRunner::RunAllTasksNow() ./../../content/browser/startup_task_runner.cc:45:0 #22 0x00000883f64c in content::BrowserMainLoop::CreateStartupTasks() ./../../content/browser/browser_main_loop.cc:986:25 #23 0x000008855c2b in content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) ./../../content/browser/browser_main_runner.cc:139:17 #24 0x00000acfaaf1 in ShellBrowserMain(content::MainFunctionParams const&, std::__1::unique_ptr<content::BrowserMainRunner, std::__1::default_delete<content::BrowserMainRunner> > const&) ./../../content/shell/browser/shell_browser_main.cc:23:32 #25 0x00000acc3f93 in content::ShellMainDelegate::RunProcess(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, content::MainFunctionParams const&) ./../../content/shell/app/shell_main_delegate.cc:322:16 #26 0x000008382651 in content::RunNamedProcessTypeMain(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, content::MainFunctionParams const&, content::ContentMainDelegate*) ./../../content/app/content_main_runner.cc:410:35 #27 0x0000083852d0 in content::ContentMainRunnerImpl::Run() ./../../content/app/content_main_runner.cc:713:12 #28 0x0000118257b1 in service_manager::Main(service_manager::MainParams const&) ./../../services/service_manager/embedder/main.cc:456:29 #29 0x000004e857a5 in content::ContentMain(content::ContentMainParams const&) ./../../content/app/content_main.cc:19:10 #30 0x00000ab596db in content::BrowserTestBase::SetUp() ./../../content/public/test/browser_test_base.cc:309:3 #31 0x00000ab2527f in content::ContentBrowserTest::SetUp() ./../../content/public/test/content_browser_test.cc:89:20 #32 0x00000271190c in testing::Test::Run() ./../../third_party/googletest/src/googletest/src/gtest-internal-inl.h:0:10 #33 0x0000027158c9 in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2645:11 #34 0x0000027172ea in testing::TestCase::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2763:28 #35 0x00000273ad4f in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:4638:43 #36 0x000002739766 in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #37 0x00000ac499cb in RUN_ALL_TESTS ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:2297:46 #38 0x00000ac499cb in base::TestSuite::Run() ./../../base/test/test_suite.cc:272:0 #39 0x00000ab3c758 in content::ContentTestLauncherDelegate::RunTestSuite(int, char**) ./../../content/test/content_test_launcher.cc:108:48 #40 0x00000abca59a in content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) ./../../content/public/test/test_launcher.cc:631:31 #41 0x00000ab3c5f8 in main ./../../content/test/content_test_launcher.cc:138:10 #42 0x7f9e01e97f45 in __libc_start_main /build/eglibc-SvCtMH/eglibc-2.19/csu/libc-start.c:287:0 #43 0x0000005f84aa in _start ??:0:0 Original change's description: > content: Add basic integration test for OOP raster. > > R=enne@chromium.org > > Bug: 809692 > Change-Id: Ib22f6f452046d9989ec9a1ec98fe09acba24c624 > Reviewed-on: https://chromium-review.googlesource.com/906184 > Commit-Queue: Khushal <khushalsagar@chromium.org> > Reviewed-by: Antoine Labour <piman@chromium.org> > Reviewed-by: enne <enne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#537973} TBR=enne@chromium.org,khushalsagar@chromium.org,piman@chromium.org Change-Id: Iefb06aeb5a6055f34babfd83794cfccf809d7389 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 809692 Reviewed-on: https://chromium-review.googlesource.com/928581 Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#538071}

This reverts commit b78e092. Reason for revert: Causes extreme flakiness on headless_browsertests: https://ci.chromium.org/buildbot/chromium.fyi/Headless%20Linux%20%28dbg%29/?limit=200 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests%20(dbg)(1) Failing test: [ RUN ] HeadlessBrowserTest.UserDataDir [32213:32213:0301/143738.704696:555470268:WARNING:resource_bundle.cc(349)] locale_file_path.empty() for locale [0301/143739.059306:WARNING:resource_bundle.cc(349)] locale_file_path.empty() for locale [32213:32213:0301/143739.079820:555845388:ERROR:gpu_process_transport_factory.cc(1007)] Lost UI shared context. [32213:32230:0301/143739.097953:555863521:WARNING:child_process_launcher_helper_posix.cc(118)] Ignoring invalid file natives_blob.bin [32213:32230:0301/143739.098046:555863609:WARNING:child_process_launcher_helper_posix.cc(118)] Ignoring invalid file snapshot_blob.bin Fontconfig warning: "/etc/fonts/fonts.conf", line 146: blank doesn't take any effect anymore. please remove it from your fonts.conf [32213:32220:0301/143739.424162:556189730:FATAL:lock_impl_posix.cc(76)] Check failed: rv == 0 (22 vs. 0). Invalid argument #0 0x7fcd600bf6ad base::debug::StackTrace::StackTrace() #1 0x7fcd600bdb9c base::debug::StackTrace::StackTrace() #2 0x7fcd60145bca logging::LogMessage::~LogMessage() #3 0x7fcd602858a3 base::internal::LockImpl::Lock() #4 0x7fcd5dfa6f43 base::Lock::Acquire() #5 0x7fcd5dfa55c3 base::AutoLock::AutoLock() #6 0x7fcd5e0ca02b net::NetLog::AddEntry() #7 0x7fcd5e0d38b4 net::NetLogWithSource::AddEntry() #8 0x7fcd5e0d3917 net::NetLogWithSource::AddEvent() #9 0x7fcd5a244bca content::QuotaPolicyCookieStore::Close() #10 0x7fcd5e2226ff net::CookieMonster::~CookieMonster() #11 0x7fcd5e223069 net::CookieMonster::~CookieMonster() #12 0x7fcd5ea1b70b net::URLRequestContextStorage::~URLRequestContextStorage() #13 0x7fcd5ea18271 net::(anonymous namespace)::ContainerURLRequestContext::~ContainerURLRequestContext() #14 0x7fcd5ea182a9 net::(anonymous namespace)::ContainerURLRequestContext::~ContainerURLRequestContext() #15 0x7fcd5f5a050b headless::HeadlessURLRequestContextGetter::NotifyContextShuttingDown() #16 0x7fcd5f547faf _ZN4base8internal13FunctorTraitsIMN8headless31HeadlessURLRequestContextGetterEFvvEvE6InvokeI13scoped_refptrIS3_EJEEEvS5_OT_DpOT0_ #17 0x7fcd5f547ef4 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIMN8headless31HeadlessURLRequestContextGetterEFvvEJ13scoped_refptrIS5_EEEEvOT_DpOT0_ #18 0x7fcd5f547ea0 _ZN4base8internal7InvokerINS0_9BindStateIMN8headless31HeadlessURLRequestContextGetterEFvvEJ13scoped_refptrIS4_EEEEFvvEE7RunImplIS6_NSt3__15tupleIJS8_EEEJLm0EEEEvOT_OT0_NSD_16integer_sequenceImJXspT1_EEEE #19 0x7fcd5f547dc9 _ZN4base8internal7InvokerINS0_9BindStateIMN8headless31HeadlessURLRequestContextGetterEFvvEJ13scoped_refptrIS4_EEEEFvvEE7RunOnceEPNS0_13BindStateBaseE #20 0x7fcd6006e1b1 _ZNO4base12OnceCallbackIFvvEE3RunEv #21 0x7fcd600c35ef base::debug::TaskAnnotator::RunTask() #22 0x7fcd601622e9 base::internal::IncomingTaskQueue::RunTask() #23 0x7fcd6016b6ab base::MessageLoop::RunTask() #24 0x7fcd6016b948 base::MessageLoop::DeferOrRunPendingTask() #25 0x7fcd6016bc58 base::MessageLoop::DoWork() #26 0x7fcd6016fc31 base::MessagePumpLibevent::Run() #27 0x7fcd6016ae6c base::MessageLoop::Run() #28 0x7fcd6022066d base::RunLoop::Run() #29 0x7fcd602de5b8 base::Thread::Run() #30 0x7fcd59a60d86 content::BrowserThreadImpl::IOThreadRun() #31 0x7fcd59a6101f content::BrowserThreadImpl::Run() #32 0x7fcd602df225 base::Thread::ThreadMain() #33 0x7fcd602d526d base::(anonymous namespace)::ThreadFunc() #34 0x7fcd6046b184 start_thread #35 0x7fcd4b76503d clone [0301/143739.572502:WARNING:resource_bundle.cc(349)] locale_file_path.empty() for locale Original change's description: > Add NetLogging to CookieMonster. > > Bug: 801910 > Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs > Change-Id: I96e376a2852410e53005ce51bf5f6485776b26a6 > Reviewed-on: https://chromium-review.googlesource.com/925181 > Commit-Queue: Randy Smith <rdsmith@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Richard Coles <torne@chromium.org> > Reviewed-by: Rohit Rao <rohitrao@chromium.org> > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#540288} TBR=rohitrao@chromium.org,rdsmith@chromium.org,jam@chromium.org,torne@chromium.org,reillyg@chromium.org,mmenke@chromium.org Change-Id: I10a15e59dc26e5c9865282e95f164fed7410298f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 801910 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/946708 Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#540576}

We're seeing a somewhat high-firing renderer crash (Igalia#25 on Chrome 65.0.3325.162 on Linux) coming from DocumentMarkerController::RemoveMarkersFromList(). It appears that we're getting a null pointer to a vector from a map that should never have null pointers as values. It appears that this is happening because garbage collection is removing one or more entries from markers_ in the middle of a call to HashMap::CopyKeysToVector(), causing one or more null pointers to be returned in the resulting vector, which are triggering undefined behavior when we look them up in markers_. The fix is to use GCForbiddenScope in CopyKeysToVector() to prevent garbage collection from occurring. I'm also adding it to CopyValuesToVector(), where the same issue can occur. For CopyValuesToVector(), I'm also including the value copy in the scope, since if the keys are WeakMembers and the values perform heap allocations when copied, this could again cause the HashMap to be modified in the middle of the copy, which might not be safe. Bug: 823612 Change-Id: I28b20e3287fcdba614201c60e49b4d6311c720e0 Reviewed-on: https://chromium-review.googlesource.com/971625 Commit-Queue: Ryan Landay <rlanday@chromium.org> Reviewed-by: Yuta Kitamura <yutak@chromium.org> Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#545237}

This reverts commit c7ab577. Reason for revert: Failing Linux ASan/LSan tests: Indirect leak of 8 byte(s) in 1 object(s) allocated from: #0 0xb77492 in operator new(unsigned long) /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/asan/asan_new_delete.cc:92:3 Igalia#1 0xa3bea84 in __allocate buildtools/third_party/libc++/trunk/include/new:228:10 Igalia#2 0xa3bea84 in allocate buildtools/third_party/libc++/trunk/include/memory:1793 Igalia#3 0xa3bea84 in allocate buildtools/third_party/libc++/trunk/include/memory:1547 Igalia#4 0xa3bea84 in __split_buffer buildtools/third_party/libc++/trunk/include/__split_buffer:311 Igalia#5 0xa3bea84 in void std::__1::vector<PrefStore::Observer*, std::__1::allocator<PrefStore::Observer*> >::__push_back_slow_path<PrefStore::Observer* const&>(PrefStore::Observer* const&&&) buildtools/third_party/libc++/trunk/include/vector:1578 Igalia#6 0xa3b5797 in push_back buildtools/third_party/libc++/trunk/include/vector:1599:9 Igalia#7 0xa3b5797 in base::ObserverList<PrefStore::Observer, true, true>::AddObserver(PrefStore::Observer*) base/observer_list.h:246 Igalia#8 0x162f16a5 in PrefValueStore::PrefStoreKeeper::Initialize(PrefValueStore*, PrefStore*, PrefValueStore::PrefStoreType) components/prefs/pref_value_store.cc:36:18 Igalia#9 0x162f1e2a in InitPrefStore components/prefs/pref_value_store.cc:295:22 Igalia#10 0x162f1e2a in PrefValueStore::PrefValueStore(PrefStore*, PrefStore*, PrefStore*, PrefStore*, PrefStore*, PrefStore*, PrefStore*, PrefNotifier*, std::__1::unique_ptr<PrefValueStore::Delegate, std::__1::default_delete<PrefValueStore::Delegate> >) components/prefs/pref_value_store.cc:61 Igalia#11 0x24a286b6 in make_unique<PrefValueStore, TestingPrefStore *&, nullptr_t, TestingPrefStore *&, nullptr_t, TestingPrefStore *&, TestingPrefStore *&, PrefStore *, PrefNotifierImpl *&> buildtools/third_party/libc++/trunk/include/memory:3079:32 Igalia#12 0x24a286b6 in TestingPrefServiceBase<sync_preferences::PrefServiceSyncable, user_prefs::PrefRegistrySyncable>::TestingPrefServiceBase(TestingPrefStore*, TestingPrefStore*, TestingPrefStore*, TestingPrefStore*, user_prefs::PrefRegistrySyncable*, PrefNotifierImpl*) components/sync_preferences/testing_pref_service_syncable.cc:24 Igalia#13 0x24a28d10 in sync_preferences::TestingPrefServiceSyncable::TestingPrefServiceSyncable() components/sync_preferences/testing_pref_service_syncable.cc:47:7 Igalia#14 0x7195215 in chromeos::(anonymous namespace)::CupsPrintersManagerTest::CupsPrintersManagerTest() chrome/browser/chromeos/printing/cups_printers_manager_unittest.cc:256:27 Igalia#15 0x71ac20e in CupsPrintersManagerTest_GetPrinter_Test chrome/browser/chromeos/printing/cups_printers_manager_unittest.cc:477:1 Igalia#16 0x71ac20e in testing::internal::TestFactoryImpl<chromeos::(anonymous namespace)::CupsPrintersManagerTest_GetPrinter_Test>::CreateTest() third_party/googletest/src/googletest/include/gtest/internal/gtest-internal.h:466 Igalia#17 0x7a50817 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest-internal-inl.h Igalia#18 0x7a51c56 in testing::TestCase::Run() third_party/googletest/src/googletest/src/gtest.cc:2779:28 Igalia#19 0x7a77366 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5036:43 Igalia#20 0x7a765d6 in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc Igalia#21 0x116d296b in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2314:46 Igalia#22 0x116d296b in base::TestSuite::Run() base/test/test_suite.cc:275 Igalia#23 0x116d8c84 in Run base/callback.h:95:12 Igalia#24 0x116d8c84 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) base/test/launcher/unit_test_launcher.cc:225 Igalia#25 0x116d874d in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) base/test/launcher/unit_test_launcher.cc:576:10 Igalia#26 0x116b4b87 in main chrome/test/base/run_all_unittests.cc:30:10 Igalia#27 0x7eff3bb53f44 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287 Original change's description: > Changing CupsPrintersManager to use Enterprise Printing Policy > > Hooked up CupsPrintersManager to receive update callbacks whenever the > value of the UserPrintersAllowed pref is changed. If the pref is set to > false then CupsPrintersManager will disallow any changes made to > non-enterprise printers. > > R=skau@chromium.org > > CQ-DEPEND=CL:972627 > > Bug: 827016 > Change-Id: Id35de08fee33106f0122af07eea572757aae9c5f > Reviewed-on: https://chromium-review.googlesource.com/982273 > Commit-Queue: David Valleau <valleau@chromium.org> > Reviewed-by: Drew Wilson <atwilson@chromium.org> > Reviewed-by: Sean Kau <skau@chromium.org> > Cr-Commit-Position: refs/heads/master@{#547243} TBR=atwilson@chromium.org,skau@chromium.org,valleau@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 827016 Change-Id: I641993fa4ca9e35901a6c95a9312ec802220eef4 Reviewed-on: https://chromium-review.googlesource.com/990313 Reviewed-by: Chris Mumford <cmumford@chromium.org> Reviewed-by: Sean Kau <skau@chromium.org> Commit-Queue: Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#547475}

…anager." This reverts commit 9e82c21. Reason for revert: This change causes target_os="chromeos" to crash on start up: [82494:82494:0411/194350.042525:FATAL:media_transfer_protocol_manager.cc(704)] Check failed: g_media_transfer_protocol_manager. #0 0x7f8751f192ac base::debug::StackTrace::StackTrace() Igalia#1 0x7f8751f402eb logging::LogMessage::~LogMessage() Igalia#2 0x7f87500945b9 device::MediaTransferProtocolManager::GetInstance() Igalia#3 0x7f87500936a5 device::MtpDeviceManager::EnumerateStoragesAndSetClient() Igalia#4 0x7f874efb5c3a device::mojom::MtpManagerStubDispatch::AcceptWithResponder() Igalia#5 0x7f87500941b6 device::mojom::MtpManagerStub<>::AcceptWithResponder() Igalia#6 0x7f87511c5a77 mojo::InterfaceEndpointClient::HandleValidatedMessage() Igalia#7 0x7f87511c53e6 mojo::FilterChain::Accept() Igalia#8 0x7f87511c6dd5 mojo::InterfaceEndpointClient::HandleIncomingMessage() Igalia#9 0x7f87511cd53c mojo::internal::MultiplexRouter::ProcessIncomingMessage() Igalia#10 0x7f87511cc940 mojo::internal::MultiplexRouter::Accept() Igalia#11 0x7f87511c53e6 mojo::FilterChain::Accept() Igalia#12 0x7f87511c05c3 mojo::Connector::ReadSingleMessage() Igalia#13 0x7f87511c0ff1 mojo::Connector::ReadAllAvailableMessages() Igalia#14 0x7f87511c0e99 mojo::Connector::OnHandleReadyInternal() Igalia#15 0x7f87511c1727 mojo::SimpleWatcher::DiscardReadyState() Igalia#16 0x7f8751187e86 mojo::SimpleWatcher::OnHandleReady() Igalia#17 0x7f8751188391 _ZN4base8internal7InvokerINS0_9BindStateIMN4mojo13SimpleWatcherEFvijRKNS3_18HandleSignalsStateEEJN S_7WeakPtrIS4_EEijS5_EEEFvvEE7RunImplIRKS9_RKNSt3__15tupleIJSB_ijS5_EEEJLm0ELm1ELm2ELm3EEEEvOT_OT0_NSI_16integer_sequ enceImJXspT1_EEEE Igalia#18 0x7f8751f19c45 base::debug::TaskAnnotator::RunTask() Igalia#19 0x7f8751f4c559 base::internal::IncomingTaskQueue::RunTask() Igalia#20 0x7f8751f5009b base::MessageLoop::RunTask() Igalia#21 0x7f8751f5042a base::MessageLoop::DeferOrRunPendingTask() Igalia#22 0x7f8751f5068c base::MessageLoop::DoWork() Igalia#23 0x7f8751f52b29 base::MessagePumpLibevent::Run() Igalia#24 0x7f8751f4f9c9 base::MessageLoop::Run() Igalia#25 0x7f8751f86709 base::RunLoop::Run() Igalia#26 0x55ecab42c14a ChromeBrowserMainParts::MainMessageLoopRun() Igalia#27 0x7f874f125a37 content::BrowserMainLoop::RunMainMessageLoopParts() Igalia#28 0x7f874f128b36 content::BrowserMainRunnerImpl::Run() Igalia#29 0x7f874f121cc9 content::BrowserMain() Igalia#30 0x7f874fb09c8d content::ContentMainRunnerImpl::Run() Igalia#31 0x7f875245e292 service_manager::Main() Igalia#32 0x7f874fb08304 content::ContentMain() Igalia#33 0x55ecaa89c263 ChromeMain Igalia#34 0x7f87449822b1 __libc_start_main Igalia#35 0x55ecaa89c0da _start Original change's description: > Add MTP Mojo interfaces for talking to MediaTransferProtocolManager. > > This CL: > 1) Introduces 2 Mojo interfaces: device::mojom::MtpManager and > device::mojom::MtpManagerClient. The current implementation just > forwards MTP device access requests to the existing > MediaTransferProtocolManager.. > 2) Makes Device Service expose the above 2 Mojo interfaces. > 3) Create stubs to connect these 2 interfaces with the main user, > storage_monitor::StorageMonitor. > > More Mojo methods will be added to MtpManager and all users will be > converted to use Mojo interfaces in subsequent CLs. > > BUG=769630 > > Change-Id: Ibfffb2a45d13014ec3984ae9e242f49492e8b16a > Reviewed-on: https://chromium-review.googlesource.com/972668 > Commit-Queue: Donna Wu <donna.wu@intel.com> > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Reviewed-by: Colin Blundell <blundell@chromium.org> > Cr-Commit-Position: refs/heads/master@{#549814} TBR=sky@chromium.org,thestig@chromium.org,blundell@chromium.org,rdevlin.cronin@chromium.org,tsepez@chromium.org,donna.wu@intel.com,leon.han@intel.com,ke.he@intel.com Change-Id: I9417d3d4be8952819faf638007b3efb21c8eb618 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 769630 Reviewed-on: https://chromium-review.googlesource.com/1006774 Reviewed-by: Alan Cutter <alancutter@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#549842}

This reverts commit 62628bf. Reason for revert: Speculative revert due to Linux ChromiumOS MSan Tests failures: https://ci.chromium.org/buildbot/chromium.memory/Linux%20ChromiumOS%20MSan%20Tests/7363 [ RUN ] ExtensionWebRequestApiTest.WebRequestAuthRequired [14149:14149:0529/223016.256914:WARNING:user_session_manager.cc(1091)] Attempting to save user password for non enterprise user. ALSA lib confmisc.c:768:(parse_card) cannot find card '0' ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_card_driver returned error: No such file or directory ALSA lib confmisc.c:392:(snd_func_concat) error evaluating strings ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_concat returned error: No such file or directory ALSA lib confmisc.c:1251:(snd_func_refer) error evaluating name ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory ALSA lib conf.c:4727:(snd_config_expand) Evaluate error: No such file or directory ALSA lib pcm.c:2239:(snd_pcm_open_noupdate) Unknown PCM default [14149:14299:0529/223016.655436:WARNING:alsa_util.cc(24)] PcmOpen: default,No such file or directory ALSA lib confmisc.c:768:(parse_card) cannot find card '0' ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_card_driver returned error: No such file or directory ALSA lib confmisc.c:392:(snd_func_concat) error evaluating strings ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_concat returned error: No such file or directory ALSA lib confmisc.c:1251:(snd_func_refer) error evaluating name ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory ALSA lib conf.c:4727:(snd_config_expand) Evaluate error: No such file or directory ALSA lib pcm.c:2239:(snd_pcm_open_noupdate) Unknown PCM default [14149:14299:0529/223016.656150:WARNING:alsa_util.cc(24)] PcmOpen: plug:default,No such file or directory [14149:14149:0529/223023.245267:ERROR:textfield.cc(1754)] Not implemented reached in virtual bool views::Textfield::ShouldDoLearning() [14149:14372:0529/223023.626405:WARNING:embedded_test_server.cc(229)] Request not handled. Returning 404: /favicon.ico [14149:14149:0529/223024.849020:INFO:CONSOLE(0)] "[SUCCESS] authRequiredNonBlocking", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0) [14149:14149:0529/223027.955574:INFO:CONSOLE(0)] "[SUCCESS] authRequiredSyncNoAction", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0) [14149:14149:0529/223031.378924:INFO:CONSOLE(0)] "[SUCCESS] authRequiredSyncCancelAuth", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0) [14149:14149:0529/223034.498789:INFO:CONSOLE(0)] "[SUCCESS] authRequiredSyncSetAuth", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0) [14149:14149:0529/223216.859287:INFO:CONSOLE(0)] "[SUCCESS] authRequiredAsyncNoAction", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0) BrowserTestBase received signal: Terminated. Backtrace: #0 0x000000a8dfe1 in __interceptor_backtrace /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/msan/../sanitizer_common/sanitizer_common_interceptors.inc:3980:13 #1 0x00001350f30f in base::debug::StackTrace::StackTrace(unsigned long) ./../../base/debug/stack_trace_posix.cc:808:41 #2 0x000014f9f062 in content::(anonymous namespace)::DumpStackTraceSignalHandler(int) ./../../content/public/test/browser_test_base.cc:87:5 #3 0x000000ab5989 in SignalHandler(int) /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/msan/msan_interceptors.cc:995:3 #4 0x7fe3e82dacb0 in killpg ??:? #5 0x7fe3e82dacb0 in ?? ??:0 #6 0x7fe3e83a26d3 in epoll_wait /build/eglibc-ripdx6/eglibc-2.19/misc/../sysdeps/unix/syscall-template.S:81:0 #7 0x000000a770a4 in __interceptor_epoll_wait /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/msan/msan_interceptors.cc:862:13 #8 0x00001704b89b in epoll_dispatch ./../../base/third_party/libevent/epoll.c:198:8 #9 0x00001703ec8b in event_base_loop ./../../base/third_party/libevent/event.c:512:9 #10 0x00001355a138 in base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) ./../../base/message_loop/message_pump_libevent.cc:247:9 #11 0x00001336b330 in base::RunLoop::Run() ./../../base/run_loop.cc:102:14 #12 0x000015058275 in content::RunThisRunLoop(base::RunLoop*) ./../../content/public/test/test_utils.cc:128:13 #13 0x00002b95647d in extensions::ResultCatcher::GetNextResult() ./../../extensions/test/result_catcher.cc:35:5 #14 0x000004dfa6f2 in extensions::ExtensionApiTest::RunExtensionTestImpl(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, char const*, int) ./../../chrome/browser/extensions/extension_apitest.cc:392:16 #15 0x0000049ace7e in extensions::ExtensionWebRequestApiTest_WebRequestAuthRequired_Test::RunTestOnMainThread() ./../../chrome/browser/extensions/api/web_request/web_request_apitest.cc:445:3 #16 0x000014f9e3f2 in content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() ./../../content/public/test/browser_test_base.cc:385:5 #17 0x00001387fbe5 in Run ./../../base/callback.h:125:12 #18 0x00001387fbe5 in ChromeBrowserMainParts::PreMainMessageLoopRunImpl() ./../../chrome/browser/chrome_browser_main.cc:2098:0 #19 0x00001387b5c0 in ChromeBrowserMainParts::PreMainMessageLoopRun() ./../../chrome/browser/chrome_browser_main.cc:1492:18 #20 0x000007604b81 in chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() ./../../chrome/browser/chromeos/chrome_browser_main_chromeos.cc:684:32 #21 0x00000bd8f78b in content::BrowserMainLoop::PreMainMessageLoopRun() ./../../content/browser/browser_main_loop.cc:962:13 #22 0x00000d34ab21 in Run ./../../base/callback.h:125:12 #23 0x00000d34ab21 in content::StartupTaskRunner::RunAllTasksNow() ./../../content/browser/startup_task_runner.cc:44:0 #24 0x00000bd875e8 in content::BrowserMainLoop::CreateStartupTasks() ./../../content/browser/browser_main_loop.cc:873:25 #25 0x00000bd9b176 in content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&, std::__1::unique_ptr<content::BrowserProcessSubThread, std::__1::default_delete<content::BrowserProcessSubThread> >) ./../../content/browser/browser_main_runner_impl.cc:148:15 #26 0x00000bd7c28c in content::BrowserMain(content::MainFunctionParams const&, std::__1::unique_ptr<content::BrowserProcessSubThread, std::__1::default_delete<content::BrowserProcessSubThread> >) ./../../content/browser/browser_main.cc:47:20 #27 0x000012ff6795 in content::RunBrowserProcessMain(content::MainFunctionParams const&, content::ContentMainDelegate*, std::__1::unique_ptr<content::BrowserProcessSubThread, std::__1::default_delete<content::BrowserProcessSubThread> >) ./../../content/app/content_main_runner_impl.cc:620:10 #28 0x000012ffa9aa in content::ContentMainRunnerImpl::Run() ./../../content/app/content_main_runner_impl.cc:964:12 #29 0x00001c607013 in service_manager::Main(service_manager::MainParams const&) ./../../services/service_manager/embedder/main.cc:459:29 #30 0x000012ff0d18 in content::ContentMain(content::ContentMainParams const&) ./../../content/app/content_main.cc:19:10 #31 0x000014f9c8c0 in content::BrowserTestBase::SetUp() ./../../content/public/test/browser_test_base.cc:323:3 #32 0x00001372d0cf in InProcessBrowserTest::SetUp() ./../../chrome/test/base/in_process_browser_test.cc:244:20 #33 0x000008b46826 in testing::Test::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #34 0x000008b4a8bc in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2667:11 #35 0x000008b4c34a in testing::TestCase::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2785:28 #36 0x000008b82a55 in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5047:43 #37 0x000008b81328 in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #38 0x0000137959f1 in RUN_ALL_TESTS ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:2329:46 #39 0x0000137959f1 in base::TestSuite::Run() ./../../base/test/test_suite.cc:275:0 #40 0x0000131f45a4 in ChromeTestSuiteRunner::RunTestSuite(int, char**) ./../../chrome/test/base/chrome_test_launcher.cc:65:38 #41 0x000015048025 in content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) ./../../content/public/test/test_launcher.cc:625:31 #42 0x0000131f5d07 in LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) ./../../chrome/test/base/chrome_test_launcher.cc:170:10 #43 0x0000131f4390 in main ./../../chrome/test/base/browser_tests_main_chromeos.cc:21:10 #44 0x7fe3e82c5f45 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287:0 #45 0x000000a511ba in _start ??:0:0 [ RUN ] ExtensionWebRequestApiTest.WebRequestAuthRequired [9681:9681:0529/225648.292655:WARNING:user_session_manager.cc(1091)] Attempting to save user password for non enterprise user. ALSA lib confmisc.c:768:(parse_card) cannot find card '0' ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_card_driver returned error: No such file or directory ALSA lib confmisc.c:392:(snd_func_concat) error evaluating strings ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_concat returned error: No such file or directory ALSA lib confmisc.c:1251:(snd_func_refer) error evaluating name ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory ALSA lib conf.c:4727:(snd_config_expand) Evaluate error: No such file or directory ALSA lib pcm.c:2239:(snd_pcm_open_noupdate) Unknown PCM default [9681:9709:0529/225648.491081:WARNING:alsa_util.cc(24)] PcmOpen: default,No such file or directory ALSA lib confmisc.c:768:(parse_card) cannot find card '0' ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_card_driver returned error: No such file or directory ALSA lib confmisc.c:392:(snd_func_concat) error evaluating strings ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_concat returned error: No such file or directory ALSA lib confmisc.c:1251:(snd_func_refer) error evaluating name ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory ALSA lib conf.c:4727:(snd_config_expand) Evaluate error: No such file or directory ALSA lib pcm.c:2239:(snd_pcm_open_noupdate) Unknown PCM default [9681:9709:0529/225648.491704:WARNING:alsa_util.cc(24)] PcmOpen: plug:default,No such file or directory [9681:9681:0529/225653.563139:ERROR:textfield.cc(1754)] Not implemented reached in virtual bool views::Textfield::ShouldDoLearning() [9681:9764:0529/225653.719267:WARNING:embedded_test_server.cc(229)] Request not handled. Returning 404: /favicon.ico [9681:9681:0529/225654.670750:INFO:CONSOLE(0)] "[SUCCESS] authRequiredNonBlocking", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0) [9681:9681:0529/225657.293016:INFO:CONSOLE(0)] "[SUCCESS] authRequiredSyncNoAction", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0) [9681:9681:0529/225700.335612:INFO:CONSOLE(0)] "[SUCCESS] authRequiredSyncCancelAuth", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0) [9681:9681:0529/225703.324806:INFO:CONSOLE(0)] "[SUCCESS] authRequiredSyncSetAuth", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0) [9681:9681:0529/225804.664156:INFO:CONSOLE(0)] "[SUCCESS] authRequiredAsyncNoAction", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0) [9681:9681:0529/225928.685288:INFO:CONSOLE(0)] "[SUCCESS] authRequiredAsyncCancelAuth", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0) BrowserTestBase received signal: Terminated. Backtrace: #0 0x000000a8dfe1 in __interceptor_backtrace /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/msan/../sanitizer_common/sanitizer_common_interceptors.inc:3980:13 #1 0x00001350f30f in base::debug::StackTrace::StackTrace(unsigned long) ./../../base/debug/stack_trace_posix.cc:808:41 #2 0x000014f9f062 in content::(anonymous namespace)::DumpStackTraceSignalHandler(int) ./../../content/public/test/browser_test_base.cc:87:5 #3 0x000000ab5989 in SignalHandler(int) /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/msan/msan_interceptors.cc:995:3 #4 0x7f6d3333fcb0 in killpg ??:? #5 0x7f6d3333fcb0 in ?? ??:0 #6 0x7f6d334076d3 in epoll_wait /build/eglibc-ripdx6/eglibc-2.19/misc/../sysdeps/unix/syscall-template.S:81:0 #7 0x000000a770a4 in __interceptor_epoll_wait /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/msan/msan_interceptors.cc:862:13 #8 0x00001704b89b in epoll_dispatch ./../../base/third_party/libevent/epoll.c:198:8 #9 0x00001703ec8b in event_base_loop ./../../base/third_party/libevent/event.c:512:9 #10 0x00001355a138 in base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) ./../../base/message_loop/message_pump_libevent.cc:247:9 #11 0x00001336b330 in base::RunLoop::Run() ./../../base/run_loop.cc:102:14 #12 0x000015058275 in content::RunThisRunLoop(base::RunLoop*) ./../../content/public/test/test_utils.cc:128:13 #13 0x00002b95647d in extensions::ResultCatcher::GetNextResult() ./../../extensions/test/result_catcher.cc:35:5 #14 0x000004dfa6f2 in extensions::ExtensionApiTest::RunExtensionTestImpl(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, char const*, int) ./../../chrome/browser/extensions/extension_apitest.cc:392:16 #15 0x0000049ace7e in extensions::ExtensionWebRequestApiTest_WebRequestAuthRequired_Test::RunTestOnMainThread() ./../../chrome/browser/extensions/api/web_request/web_request_apitest.cc:445:3 #16 0x000014f9e3f2 in content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() ./../../content/public/test/browser_test_base.cc:385:5 #17 0x00001387fbe5 in Run ./../../base/callback.h:125:12 #18 0x00001387fbe5 in ChromeBrowserMainParts::PreMainMessageLoopRunImpl() ./../../chrome/browser/chrome_browser_main.cc:2098:0 #19 0x00001387b5c0 in ChromeBrowserMainParts::PreMainMessageLoopRun() ./../../chrome/browser/chrome_browser_main.cc:1492:18 #20 0x000007604b81 in chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() ./../../chrome/browser/chromeos/chrome_browser_main_chromeos.cc:684:32 #21 0x00000bd8f78b in content::BrowserMainLoop::PreMainMessageLoopRun() ./../../content/browser/browser_main_loop.cc:962:13 #22 0x00000d34ab21 in Run ./../../base/callback.h:125:12 #23 0x00000d34ab21 in content::StartupTaskRunner::RunAllTasksNow() ./../../content/browser/startup_task_runner.cc:44:0 #24 0x00000bd875e8 in content::BrowserMainLoop::CreateStartupTasks() ./../../content/browser/browser_main_loop.cc:873:25 #25 0x00000bd9b176 in content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&, std::__1::unique_ptr<content::BrowserProcessSubThread, std::__1::default_delete<content::BrowserProcessSubThread> >) ./../../content/browser/browser_main_runner_impl.cc:148:15 #26 0x00000bd7c28c in content::BrowserMain(content::MainFunctionParams const&, std::__1::unique_ptr<content::BrowserProcessSubThread, std::__1::default_delete<content::BrowserProcessSubThread> >) ./../../content/browser/browser_main.cc:47:20 #27 0x000012ff6795 in content::RunBrowserProcessMain(content::MainFunctionParams const&, content::ContentMainDelegate*, std::__1::unique_ptr<content::BrowserProcessSubThread, std::__1::default_delete<content::BrowserProcessSubThread> >) ./../../content/app/content_main_runner_impl.cc:620:10 #28 0x000012ffa9aa in content::ContentMainRunnerImpl::Run() ./../../content/app/content_main_runner_impl.cc:964:12 #29 0x00001c607013 in service_manager::Main(service_manager::MainParams const&) ./../../services/service_manager/embedder/main.cc:459:29 #30 0x000012ff0d18 in content::ContentMain(content::ContentMainParams const&) ./../../content/app/content_main.cc:19:10 #31 0x000014f9c8c0 in content::BrowserTestBase::SetUp() ./../../content/public/test/browser_test_base.cc:323:3 #32 0x00001372d0cf in InProcessBrowserTest::SetUp() ./../../chrome/test/base/in_process_browser_test.cc:244:20 #33 0x000008b46826 in testing::Test::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #34 0x000008b4a8bc in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2667:11 #35 0x000008b4c34a in testing::TestCase::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2785:28 #36 0x000008b82a55 in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5047:43 #37 0x000008b81328 in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #38 0x0000137959f1 in RUN_ALL_TESTS ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:2329:46 #39 0x0000137959f1 in base::TestSuite::Run() ./../../base/test/test_suite.cc:275:0 #40 0x0000131f45a4 in ChromeTestSuiteRunner::RunTestSuite(int, char**) ./../../chrome/test/base/chrome_test_launcher.cc:65:38 #41 0x000015048025 in content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) ./../../content/public/test/test_launcher.cc:625:31 #42 0x0000131f5d07 in LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) ./../../chrome/test/base/chrome_test_launcher.cc:170:10 #43 0x0000131f4390 in main ./../../chrome/test/base/browser_tests_main_chromeos.cc:21:10 #44 0x7f6d3332af45 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287:0 #45 0x000000a511ba in _start ??:0:0 [ RUN ] ExtensionWebRequestApiTest.WebRequestAuthRequired [9971:9971:0529/225953.241021:WARNING:user_session_manager.cc(1091)] Attempting to save user password for non enterprise user. ALSA lib confmisc.c:768:(parse_card) cannot find card '0' ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_card_driver returned error: No such file or directory ALSA lib confmisc.c:392:(snd_func_concat) error evaluating strings ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_concat returned error: No such file or directory ALSA lib confmisc.c:1251:(snd_func_refer) error evaluating name ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory ALSA lib conf.c:4727:(snd_config_expand) Evaluate error: No such file or directory ALSA lib pcm.c:2239:(snd_pcm_open_noupdate) Unknown PCM default [9971:9999:0529/225953.449328:WARNING:alsa_util.cc(24)] PcmOpen: default,No such file or directory ALSA lib confmisc.c:768:(parse_card) cannot find card '0' ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_card_driver returned error: No such file or directory ALSA lib confmisc.c:392:(snd_func_concat) error evaluating strings ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_concat returned error: No such file or directory ALSA lib confmisc.c:1251:(snd_func_refer) error evaluating name ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory ALSA lib conf.c:4727:(snd_config_expand) Evaluate error: No such file or directory ALSA lib pcm.c:2239:(snd_pcm_open_noupdate) Unknown PCM default [9971:9999:0529/225953.449892:WARNING:alsa_util.cc(24)] PcmOpen: plug:default,No such file or directory [9971:9971:0529/225958.400556:ERROR:textfield.cc(1754)] Not implemented reached in virtual bool views::Textfield::ShouldDoLearning() [9971:10053:0529/225958.532493:WARNING:embedded_test_server.cc(229)] Request not handled. Returning 404: /favicon.ico [9971:9971:0529/225959.377349:INFO:CONSOLE(0)] "[SUCCESS] authRequiredNonBlocking", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0) [9971:9971:0529/230002.227064:INFO:CONSOLE(0)] "[SUCCESS] authRequiredSyncNoAction", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0) [9971:9971:0529/230005.286414:INFO:CONSOLE(0)] "[SUCCESS] authRequiredSyncCancelAuth", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0) [9971:9971:0529/230008.209328:INFO:CONSOLE(0)] "[SUCCESS] authRequiredSyncSetAuth", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0) [9971:9971:0529/230103.646916:INFO:CONSOLE(0)] "[SUCCESS] authRequiredAsyncNoAction", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0) [9971:9971:0529/230224.632095:INFO:CONSOLE(0)] "[SUCCESS] authRequiredAsyncCancelAuth", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0) BrowserTestBase received signal: Terminated. Backtrace: #0 0x000000a8dfe1 in __interceptor_backtrace /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/msan/../sanitizer_common/sanitizer_common_interceptors.inc:3980:13 #1 0x00001350f30f in base::debug::StackTrace::StackTrace(unsigned long) ./../../base/debug/stack_trace_posix.cc:808:41 #2 0x000014f9f062 in content::(anonymous namespace)::DumpStackTraceSignalHandler(int) ./../../content/public/test/browser_test_base.cc:87:5 #3 0x000000ab5989 in SignalHandler(int) /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/msan/msan_interceptors.cc:995:3 #4 0x7f12d1488cb0 in killpg ??:? #5 0x7f12d1488cb0 in ?? ??:0 #6 0x7f12d15506d3 in epoll_wait /build/eglibc-ripdx6/eglibc-2.19/misc/../sysdeps/unix/syscall-template.S:81:0 #7 0x000000a770a4 in __interceptor_epoll_wait /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/msan/msan_interceptors.cc:862:13 #8 0x00001704b89b in epoll_dispatch ./../../base/third_party/libevent/epoll.c:198:8 #9 0x00001703ec8b in event_base_loop ./../../base/third_party/libevent/event.c:512:9 #10 0x00001355a138 in base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) ./../../base/message_loop/message_pump_libevent.cc:247:9 #11 0x00001336b330 in base::RunLoop::Run() ./../../base/run_loop.cc:102:14 #12 0x000015058275 in content::RunThisRunLoop(base::RunLoop*) ./../../content/public/test/test_utils.cc:128:13 #13 0x00002b95647d in extensions::ResultCatcher::GetNextResult() ./../../extensions/test/result_catcher.cc:35:5 #14 0x000004dfa6f2 in extensions::ExtensionApiTest::RunExtensionTestImpl(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, char const*, int) ./../../chrome/browser/extensions/extension_apitest.cc:392:16 #15 0x0000049ace7e in extensions::ExtensionWebRequestApiTest_WebRequestAuthRequired_Test::RunTestOnMainThread() ./../../chrome/browser/extensions/api/web_request/web_request_apitest.cc:445:3 #16 0x000014f9e3f2 in content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() ./../../content/public/test/browser_test_base.cc:385:5 #17 0x00001387fbe5 in Run ./../../base/callback.h:125:12 #18 0x00001387fbe5 in ChromeBrowserMainParts::PreMainMessageLoopRunImpl() ./../../chrome/browser/chrome_browser_main.cc:2098:0 #19 0x00001387b5c0 in ChromeBrowserMainParts::PreMainMessageLoopRun() ./../../chrome/browser/chrome_browser_main.cc:1492:18 #20 0x000007604b81 in chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() ./../../chrome/browser/chromeos/chrome_browser_main_chromeos.cc:684:32 #21 0x00000bd8f78b in content::BrowserMainLoop::PreMainMessageLoopRun() ./../../content/browser/browser_main_loop.cc:962:13 #22 0x00000d34ab21 in Run ./../../base/callback.h:125:12 #23 0x00000d34ab21 in content::StartupTaskRunner::RunAllTasksNow() ./../../content/browser/startup_task_runner.cc:44:0 #24 0x00000bd875e8 in content::BrowserMainLoop::CreateStartupTasks() ./../../content/browser/browser_main_loop.cc:873:25 #25 0x00000bd9b176 in content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&, std::__1::unique_ptr<content::BrowserProcessSubThread, std::__1::default_delete<content::BrowserProcessSubThread> >) ./../../content/browser/browser_main_runner_impl.cc:148:15 #26 0x00000bd7c28c in content::BrowserMain(content::MainFunctionParams const&, std::__1::unique_ptr<content::BrowserProcessSubThread, std::__1::default_delete<content::BrowserProcessSubThread> >) ./../../content/browser/browser_main.cc:47:20 #27 0x000012ff6795 in content::RunBrowserProcessMain(content::MainFunctionParams const&, content::ContentMainDelegate*, std::__1::unique_ptr<content::BrowserProcessSubThread, std::__1::default_delete<content::BrowserProcessSubThread> >) ./../../content/app/content_main_runner_impl.cc:620:10 #28 0x000012ffa9aa in content::ContentMainRunnerImpl::Run() ./../../content/app/content_main_runner_impl.cc:964:12 #29 0x00001c607013 in service_manager::Main(service_manager::MainParams const&) ./../../services/service_manager/embedder/main.cc:459:29 #30 0x000012ff0d18 in content::ContentMain(content::ContentMainParams const&) ./../../content/app/content_main.cc:19:10 #31 0x000014f9c8c0 in content::BrowserTestBase::SetUp() ./../../content/public/test/browser_test_base.cc:323:3 #32 0x00001372d0cf in InProcessBrowserTest::SetUp() ./../../chrome/test/base/in_process_browser_test.cc:244:20 #33 0x000008b46826 in testing::Test::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #34 0x000008b4a8bc in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2667:11 #35 0x000008b4c34a in testing::TestCase::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2785:28 #36 0x000008b82a55 in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5047:43 #37 0x000008b81328 in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #38 0x0000137959f1 in RUN_ALL_TESTS ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:2329:46 #39 0x0000137959f1 in base::TestSuite::Run() ./../../base/test/test_suite.cc:275:0 #40 0x0000131f45a4 in ChromeTestSuiteRunner::RunTestSuite(int, char**) ./../../chrome/test/base/chrome_test_launcher.cc:65:38 #41 0x000015048025 in content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) ./../../content/public/test/test_launcher.cc:625:31 #42 0x0000131f5d07 in LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) ./../../chrome/test/base/chrome_test_launcher.cc:170:10 #43 0x0000131f4390 in main ./../../chrome/test/base/browser_tests_main_chromeos.cc:21:10 #44 0x7f12d1473f45 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287:0 #45 0x000000a511ba in _start ??:0:0 [ RUN ] ExtensionWebRequestApiTest.WebRequestAuthRequired [10186:10186:0529/230253.379633:WARNING:user_session_manager.cc(1091)] Attempting to save user password for non enterprise user. ALSA lib confmisc.c:768:(parse_card) cannot find card '0' ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_card_driver returned error: No such file or directory ALSA lib confmisc.c:392:(snd_func_concat) error evaluating strings ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_concat returned error: No such file or directory ALSA lib confmisc.c:1251:(snd_func_refer) error evaluating name ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory ALSA lib conf.c:4727:(snd_config_expand) Evaluate error: No such file or directory ALSA lib pcm.c:2239:(snd_pcm_open_noupdate) Unknown PCM default [10186:10214:0529/230253.588059:WARNING:alsa_util.cc(24)] PcmOpen: default,No such file or directory ALSA lib confmisc.c:768:(parse_card) cannot find card '0' ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_card_driver returned error: No such file or directory ALSA lib confmisc.c:392:(snd_func_concat) error evaluating strings ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_concat returned error: No such file or directory ALSA lib confmisc.c:1251:(snd_func_refer) error evaluating name ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory ALSA lib conf.c:4727:(snd_config_expand) Evaluate error: No such file or directory ALSA lib pcm.c:2239:(snd_pcm_open_noupdate) Unknown PCM default [10186:10214:0529/230253.589228:WARNING:alsa_util.cc(24)] PcmOpen: plug:default,No such file or directory [10186:10186:0529/230258.651324:ERROR:textfield.cc(1754)] Not implemented reached in virtual bool views::Textfield::ShouldDoLearning() [10186:10267:0529/230258.790038:WARNING:embedded_test_server.cc(229)] Request not handled. Returning 404: /favicon.ico [10186:10186:0529/230259.634483:INFO:CONSOLE(0)] "[SUCCESS] authRequiredNonBlocking", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0) [10186:10186:0529/230302.223698:INFO:CONSOLE(0)] "[SUCCESS] authRequiredSyncNoAction", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0) [10186:10186:0529/230305.265591:INFO:CONSOLE(0)] "[SUCCESS] authRequiredSyncCancelAuth", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0) [10186:10186:0529/230308.238544:INFO:CONSOLE(0)] "[SUCCESS] authRequiredSyncSetAuth", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0) [10186:10186:0529/230402.646445:INFO:CONSOLE(0)] "[SUCCESS] authRequiredAsyncNoAction", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0) [10186:10186:0529/230525.634213:INFO:CONSOLE(0)] "[SUCCESS] authRequiredAsyncCancelAuth", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0) BrowserTestBase received signal: Terminated. Backtrace: #0 0x000000a8dfe1 in __interceptor_backtrace /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/msan/../sanitizer_common/sanitizer_common_interceptors.inc:3980:13 #1 0x00001350f30f in base::debug::StackTrace::StackTrace(unsigned long) ./../../base/debug/stack_trace_posix.cc:808:41 #2 0x000014f9f062 in content::(anonymous namespace)::DumpStackTraceSignalHandler(int) ./../../content/public/test/browser_test_base.cc:87:5 #3 0x000000ab5989 in SignalHandler(int) /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/msan/msan_interceptors.cc:995:3 #4 0x7f0a55d86cb0 in killpg ??:? #5 0x7f0a55d86cb0 in ?? ??:0 #6 0x000000a6d2d4 in __msan_set_alloca_origin4 /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/msan/msan.cc:558:12 #7 0x00001b72c053 in std::__1::enable_if<(__is_forward_iterator<std::__1::__wrap_iter<cc::DrawImage*> >::value) && (is_constructible<cc::DrawImage, std::__1::iterator_traits<std::__1::__wrap_iter<cc::DrawImage*> >::reference>::value), std::__1::__wrap_iter<cc::DrawImage*> >::type std::__1::vector<cc::DrawImage, std::__1::allocator<cc::DrawImage> >::insert<std::__1::__wrap_iter<cc::DrawImage*> >(std::__1::__wrap_iter<cc::DrawImage const*>, std::__1::__wrap_iter<cc::DrawImage*>, std::__1::__wrap_iter<cc::DrawImage*>) ./../../buildtools/third_party/libc++/trunk/include/vector:1959:0 #8 0x00001b71d05d in cc::TileManager::ScheduleTasks(cc::TileManager::PrioritizedWorkToSchedule) ./../../cc/tiles/tile_manager.cc:1021:21 #9 0x00001b716797 in cc::TileManager::PrepareTiles(cc::GlobalStateThatImpactsTilePriority const&) ./../../cc/tiles/tile_manager.cc:520:3 #10 0x00001b4bb195 in cc::LayerTreeHostImpl::PrepareTiles() ./../../cc/trees/layer_tree_host_impl.cc:607:42 #11 0x00001b7ebfac in cc::SingleThreadProxy::ScheduledActionPrepareTiles() ./../../cc/trees/single_thread_proxy.cc:834:15 #12 0x00001b83107b in cc::Scheduler::ProcessScheduledActions() ./../../cc/scheduler/scheduler.cc:0:20 #13 0x00001b82fe9f in cc::Scheduler::OnBeginImplFrameDeadline() ./../../cc/scheduler/scheduler.cc:642:3 #14 0x00001322a1d2 in Run ./../../base/callback.h:96:12 #15 0x00001322a1d2 in base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) ./../../base/debug/task_annotator.cc:101:0 #16 0x0000132ab7a5 in base::MessageLoop::RunTask(base::PendingTask*) ./../../base/message_loop/message_loop.cc:319:25 #17 0x0000132adb1b in DeferOrRunPendingTask ./../../base/message_loop/message_loop.cc:329:5 #18 0x0000132adb1b in base::MessageLoop::DoDelayedWork(base::TimeTicks*) ./../../base/message_loop/message_loop.cc:413:0 #19 0x000013559d67 in base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) ./../../base/message_loop/message_pump_libevent.cc:220:27 #20 0x00001336b330 in base::RunLoop::Run() ./../../base/run_loop.cc:102:14 #21 0x000015058275 in content::RunThisRunLoop(base::RunLoop*) ./../../content/public/test/test_utils.cc:128:13 #22 0x00002b95647d in extensions::ResultCatcher::GetNextResult() ./../../extensions/test/result_catcher.cc:35:5 #23 0x000004dfa6f2 in extensions::ExtensionApiTest::RunExtensionTestImpl(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, char const*, int) ./../../chrome/browser/extensions/extension_apitest.cc:392:16 #24 0x0000049ace7e in extensions::ExtensionWebRequestApiTest_WebRequestAuthRequired_Test::RunTestOnMainThread() ./../../chrome/browser/extensions/api/web_request/web_request_apitest.cc:445:3 #25 0x000014f9e3f2 in content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() ./../../content/public/test/browser_test_base.cc:385:5 #26 0x00001387fbe5 in Run ./../../base/callback.h:125:12 #27 0x00001387fbe5 in ChromeBrowserMainParts::PreMainMessageLoopRunImpl() ./../../chrome/browser/chrome_browser_main.cc:2098:0 #28 0x00001387b5c0 in ChromeBrowserMainParts::PreMainMessageLoopRun() ./../../chrome/browser/chrome_browser_main.cc:1492:18 #29 0x000007604b81 in chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() ./../../chrome/browser/chromeos/chrome_browser_main_chromeos.cc:684:32 #30 0x00000bd8f78b in content::BrowserMainLoop::PreMainMessageLoopRun() ./../../content/browser/browser_main_loop.cc:962:13 #31 0x00000d34ab21 in Run ./../../base/callback.h:125:12 #32 0x00000d34ab21 in content::StartupTaskRunner::RunAllTasksNow() ./../../content/browser/startup_task_runner.cc:44:0 #33 0x00000bd875e8 in content::BrowserMainLoop::CreateStartupTasks() ./../../content/browser/browser_main_loop.cc:873:25 #34 0x00000bd9b176 in content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&, std::__1::unique_ptr<content::BrowserProcessSubThread, std::__1::default_delete<content::BrowserProcessSubThread> >) ./../../content/browser/browser_main_runner_impl.cc:148:15 #35 0x00000bd7c28c in content::BrowserMain(content::MainFunctionParams const&, std::__1::unique_ptr<content::BrowserProcessSubThread, std::__1::default_delete<content::BrowserProcessSubThread> >) ./../../content/browser/browser_main.cc:47:20 #36 0x000012ff6795 in content::RunBrowserProcessMain(content::MainFunctionParams const&, content::ContentMainDelegate*, std::__1::unique_ptr<content::BrowserProcessSubThread, std::__1::default_delete<content::BrowserProcessSubThread> >) ./../../content/app/content_main_runner_impl.cc:620:10 #37 0x000012ffa9aa in content::ContentMainRunnerImpl::Run() ./../../content/app/content_main_runner_impl.cc:964:12 #38 0x00001c607013 in service_manager::Main(service_manager::MainParams const&) ./../../services/service_manager/embedder/main.cc:459:29 #39 0x000012ff0d18 in content::ContentMain(content::ContentMainParams const&) ./../../content/app/content_main.cc:19:10 #40 0x000014f9c8c0 in content::BrowserTestBase::SetUp() ./../../content/public/test/browser_test_base.cc:323:3 #41 0x00001372d0cf in InProcessBrowserTest::SetUp() ./../../chrome/test/base/in_process_browser_test.cc:244:20 #42 0x000008b46826 in testing::Test::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #43 0x000008b4a8bc in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2667:11 #44 0x000008b4c34a in testing::TestCase::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2785:28 #45 0x000008b82a55 in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5047:43 #46 0x000008b81328 in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #47 0x0000137959f1 in RUN_ALL_TESTS ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:2329:46 #48 0x0000137959f1 in base::TestSuite::Run() ./../../base/test/test_suite.cc:275:0 #49 0x0000131f45a4 in ChromeTestSuiteRunner::RunTestSuite(int, char**) ./../../chrome/test/base/chrome_test_launcher.cc:65:38 #50 0x000015048025 in content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) ./../../content/public/test/test_launcher.cc:625:31 #51 0x0000131f5d07 in LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) ./../../chrome/test/base/chrome_test_launcher.cc:170:10 #52 0x0000131f4390 in main ./../../chrome/test/base/browser_tests_main_chromeos.cc:21:10 #53 0x7f0a55d71f45 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287:0 #54 0x000000a511ba in _start ??:0:0 Original change's description: > shared worker: Add tests for Chrome extensions. > > We didn't have specific test coverage for shared worker from Chrome > extensions, just incidental ones via the ExtensionApiTest.Debugger and > ExtensionApiTestWithSwitch.ExtensionDebugger. > > Shared workers go through a very different loading path than other > resources, so it's useful to have tests for them especially > including interaction with service workers. > > This adds tests that currently fail with NetworkService, a next > patch will have a fix. > > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo > Change-Id: Ifa6bb3dec8bdea34c3fbefbaeab324fadcb5c929 > Bug: 839982 > Reviewed-on: https://chromium-review.googlesource.com/1074848 > Commit-Queue: Matt Falkenhagen <falken@chromium.org> > Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#562700} TBR=falken@chromium.org,lazyboy@chromium.org Change-Id: I880c6e859c9414070ad4783dc9e703f4324ecf29 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 839982 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/1078367 Reviewed-by: Thiemo Nagel <tnagel@chromium.org> Commit-Queue: Thiemo Nagel <tnagel@chromium.org> Cr-Commit-Position: refs/heads/master@{#562766}

This reverts commit 4796a2a. Reason for revert: The test failure is a flake. I should have checked before. :( Original change's description: > Revert "shared worker: Add tests for Chrome extensions." > > This reverts commit 62628bf. > > Reason for revert: Speculative revert due to Linux ChromiumOS MSan Tests failures: > > https://ci.chromium.org/buildbot/chromium.memory/Linux%20ChromiumOS%20MSan%20Tests/7363 > > [ RUN ] ExtensionWebRequestApiTest.WebRequestAuthRequired > [14149:14149:0529/223016.256914:WARNING:user_session_manager.cc(1091)] Attempting to save user password for non enterprise user. > ALSA lib confmisc.c:768:(parse_card) cannot find card '0' > ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_card_driver returned error: No such file or directory > ALSA lib confmisc.c:392:(snd_func_concat) error evaluating strings > ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_concat returned error: No such file or directory > ALSA lib confmisc.c:1251:(snd_func_refer) error evaluating name > ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory > ALSA lib conf.c:4727:(snd_config_expand) Evaluate error: No such file or directory > ALSA lib pcm.c:2239:(snd_pcm_open_noupdate) Unknown PCM default > [14149:14299:0529/223016.655436:WARNING:alsa_util.cc(24)] PcmOpen: default,No such file or directory > ALSA lib confmisc.c:768:(parse_card) cannot find card '0' > ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_card_driver returned error: No such file or directory > ALSA lib confmisc.c:392:(snd_func_concat) error evaluating strings > ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_concat returned error: No such file or directory > ALSA lib confmisc.c:1251:(snd_func_refer) error evaluating name > ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory > ALSA lib conf.c:4727:(snd_config_expand) Evaluate error: No such file or directory > ALSA lib pcm.c:2239:(snd_pcm_open_noupdate) Unknown PCM default > [14149:14299:0529/223016.656150:WARNING:alsa_util.cc(24)] PcmOpen: plug:default,No such file or directory > [14149:14149:0529/223023.245267:ERROR:textfield.cc(1754)] Not implemented reached in virtual bool views::Textfield::ShouldDoLearning() > [14149:14372:0529/223023.626405:WARNING:embedded_test_server.cc(229)] Request not handled. Returning 404: /favicon.ico > [14149:14149:0529/223024.849020:INFO:CONSOLE(0)] "[SUCCESS] authRequiredNonBlocking", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0) > [14149:14149:0529/223027.955574:INFO:CONSOLE(0)] "[SUCCESS] authRequiredSyncNoAction", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0) > [14149:14149:0529/223031.378924:INFO:CONSOLE(0)] "[SUCCESS] authRequiredSyncCancelAuth", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0) > [14149:14149:0529/223034.498789:INFO:CONSOLE(0)] "[SUCCESS] authRequiredSyncSetAuth", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0) > [14149:14149:0529/223216.859287:INFO:CONSOLE(0)] "[SUCCESS] authRequiredAsyncNoAction", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0) > BrowserTestBase received signal: Terminated. Backtrace: > #0 0x000000a8dfe1 in __interceptor_backtrace /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/msan/../sanitizer_common/sanitizer_common_interceptors.inc:3980:13 > #1 0x00001350f30f in base::debug::StackTrace::StackTrace(unsigned long) ./../../base/debug/stack_trace_posix.cc:808:41 > #2 0x000014f9f062 in content::(anonymous namespace)::DumpStackTraceSignalHandler(int) ./../../content/public/test/browser_test_base.cc:87:5 > #3 0x000000ab5989 in SignalHandler(int) /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/msan/msan_interceptors.cc:995:3 > #4 0x7fe3e82dacb0 in killpg ??:? > #5 0x7fe3e82dacb0 in ?? ??:0 > #6 0x7fe3e83a26d3 in epoll_wait /build/eglibc-ripdx6/eglibc-2.19/misc/../sysdeps/unix/syscall-template.S:81:0 > #7 0x000000a770a4 in __interceptor_epoll_wait /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/msan/msan_interceptors.cc:862:13 > #8 0x00001704b89b in epoll_dispatch ./../../base/third_party/libevent/epoll.c:198:8 > #9 0x00001703ec8b in event_base_loop ./../../base/third_party/libevent/event.c:512:9 > #10 0x00001355a138 in base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) ./../../base/message_loop/message_pump_libevent.cc:247:9 > #11 0x00001336b330 in base::RunLoop::Run() ./../../base/run_loop.cc:102:14 > #12 0x000015058275 in content::RunThisRunLoop(base::RunLoop*) ./../../content/public/test/test_utils.cc:128:13 > #13 0x00002b95647d in extensions::ResultCatcher::GetNextResult() ./../../extensions/test/result_catcher.cc:35:5 > #14 0x000004dfa6f2 in extensions::ExtensionApiTest::RunExtensionTestImpl(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, char const*, int) ./../../chrome/browser/extensions/extension_apitest.cc:392:16 > #15 0x0000049ace7e in extensions::ExtensionWebRequestApiTest_WebRequestAuthRequired_Test::RunTestOnMainThread() ./../../chrome/browser/extensions/api/web_request/web_request_apitest.cc:445:3 > #16 0x000014f9e3f2 in content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() ./../../content/public/test/browser_test_base.cc:385:5 > #17 0x00001387fbe5 in Run ./../../base/callback.h:125:12 > #18 0x00001387fbe5 in ChromeBrowserMainParts::PreMainMessageLoopRunImpl() ./../../chrome/browser/chrome_browser_main.cc:2098:0 > #19 0x00001387b5c0 in ChromeBrowserMainParts::PreMainMessageLoopRun() ./../../chrome/browser/chrome_browser_main.cc:1492:18 > #20 0x000007604b81 in chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() ./../../chrome/browser/chromeos/chrome_browser_main_chromeos.cc:684:32 > #21 0x00000bd8f78b in content::BrowserMainLoop::PreMainMessageLoopRun() ./../../content/browser/browser_main_loop.cc:962:13 > #22 0x00000d34ab21 in Run ./../../base/callback.h:125:12 > #23 0x00000d34ab21 in content::StartupTaskRunner::RunAllTasksNow() ./../../content/browser/startup_task_runner.cc:44:0 > #24 0x00000bd875e8 in content::BrowserMainLoop::CreateStartupTasks() ./../../content/browser/browser_main_loop.cc:873:25 > #25 0x00000bd9b176 in content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&, std::__1::unique_ptr<content::BrowserProcessSubThread, std::__1::default_delete<content::BrowserProcessSubThread> >) ./../../content/browser/browser_main_runner_impl.cc:148:15 > #26 0x00000bd7c28c in content::BrowserMain(content::MainFunctionParams const&, std::__1::unique_ptr<content::BrowserProcessSubThread, std::__1::default_delete<content::BrowserProcessSubThread> >) ./../../content/browser/browser_main.cc:47:20 > #27 0x000012ff6795 in content::RunBrowserProcessMain(content::MainFunctionParams const&, content::ContentMainDelegate*, std::__1::unique_ptr<content::BrowserProcessSubThread, std::__1::default_delete<content::BrowserProcessSubThread> >) ./../../content/app/content_main_runner_impl.cc:620:10 > #28 0x000012ffa9aa in content::ContentMainRunnerImpl::Run() ./../../content/app/content_main_runner_impl.cc:964:12 > #29 0x00001c607013 in service_manager::Main(service_manager::MainParams const&) ./../../services/service_manager/embedder/main.cc:459:29 > #30 0x000012ff0d18 in content::ContentMain(content::ContentMainParams const&) ./../../content/app/content_main.cc:19:10 > #31 0x000014f9c8c0 in content::BrowserTestBase::SetUp() ./../../content/public/test/browser_test_base.cc:323:3 > #32 0x00001372d0cf in InProcessBrowserTest::SetUp() ./../../chrome/test/base/in_process_browser_test.cc:244:20 > #33 0x000008b46826 in testing::Test::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 > #34 0x000008b4a8bc in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2667:11 > #35 0x000008b4c34a in testing::TestCase::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2785:28 > #36 0x000008b82a55 in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5047:43 > #37 0x000008b81328 in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 > #38 0x0000137959f1 in RUN_ALL_TESTS ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:2329:46 > #39 0x0000137959f1 in base::TestSuite::Run() ./../../base/test/test_suite.cc:275:0 > #40 0x0000131f45a4 in ChromeTestSuiteRunner::RunTestSuite(int, char**) ./../../chrome/test/base/chrome_test_launcher.cc:65:38 > #41 0x000015048025 in content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) ./../../content/public/test/test_launcher.cc:625:31 > #42 0x0000131f5d07 in LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) ./../../chrome/test/base/chrome_test_launcher.cc:170:10 > #43 0x0000131f4390 in main ./../../chrome/test/base/browser_tests_main_chromeos.cc:21:10 > #44 0x7fe3e82c5f45 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287:0 > #45 0x000000a511ba in _start ??:0:0 > [ RUN ] ExtensionWebRequestApiTest.WebRequestAuthRequired > [9681:9681:0529/225648.292655:WARNING:user_session_manager.cc(1091)] Attempting to save user password for non enterprise user. > ALSA lib confmisc.c:768:(parse_card) cannot find card '0' > ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_card_driver returned error: No such file or directory > ALSA lib confmisc.c:392:(snd_func_concat) error evaluating strings > ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_concat returned error: No such file or directory > ALSA lib confmisc.c:1251:(snd_func_refer) error evaluating name > ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory > ALSA lib conf.c:4727:(snd_config_expand) Evaluate error: No such file or directory > ALSA lib pcm.c:2239:(snd_pcm_open_noupdate) Unknown PCM default > [9681:9709:0529/225648.491081:WARNING:alsa_util.cc(24)] PcmOpen: default,No such file or directory > ALSA lib confmisc.c:768:(parse_card) cannot find card '0' > ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_card_driver returned error: No such file or directory > ALSA lib confmisc.c:392:(snd_func_concat) error evaluating strings > ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_concat returned error: No such file or directory > ALSA lib confmisc.c:1251:(snd_func_refer) error evaluating name > ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory > ALSA lib conf.c:4727:(snd_config_expand) Evaluate error: No such file or directory > ALSA lib pcm.c:2239:(snd_pcm_open_noupdate) Unknown PCM default > [9681:9709:0529/225648.491704:WARNING:alsa_util.cc(24)] PcmOpen: plug:default,No such file or directory > [9681:9681:0529/225653.563139:ERROR:textfield.cc(1754)] Not implemented reached in virtual bool views::Textfield::ShouldDoLearning() > [9681:9764:0529/225653.719267:WARNING:embedded_test_server.cc(229)] Request not handled. Returning 404: /favicon.ico > [9681:9681:0529/225654.670750:INFO:CONSOLE(0)] "[SUCCESS] authRequiredNonBlocking", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0) > [9681:9681:0529/225657.293016:INFO:CONSOLE(0)] "[SUCCESS] authRequiredSyncNoAction", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0) > [9681:9681:0529/225700.335612:INFO:CONSOLE(0)] "[SUCCESS] authRequiredSyncCancelAuth", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0) > [9681:9681:0529/225703.324806:INFO:CONSOLE(0)] "[SUCCESS] authRequiredSyncSetAuth", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0) > [9681:9681:0529/225804.664156:INFO:CONSOLE(0)] "[SUCCESS] authRequiredAsyncNoAction", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0) > [9681:9681:0529/225928.685288:INFO:CONSOLE(0)] "[SUCCESS] authRequiredAsyncCancelAuth", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0) > BrowserTestBase received signal: Terminated. Backtrace: > #0 0x000000a8dfe1 in __interceptor_backtrace /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/msan/../sanitizer_common/sanitizer_common_interceptors.inc:3980:13 > #1 0x00001350f30f in base::debug::StackTrace::StackTrace(unsigned long) ./../../base/debug/stack_trace_posix.cc:808:41 > #2 0x000014f9f062 in content::(anonymous namespace)::DumpStackTraceSignalHandler(int) ./../../content/public/test/browser_test_base.cc:87:5 > #3 0x000000ab5989 in SignalHandler(int) /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/msan/msan_interceptors.cc:995:3 > #4 0x7f6d3333fcb0 in killpg ??:? > #5 0x7f6d3333fcb0 in ?? ??:0 > #6 0x7f6d334076d3 in epoll_wait /build/eglibc-ripdx6/eglibc-2.19/misc/../sysdeps/unix/syscall-template.S:81:0 > #7 0x000000a770a4 in __interceptor_epoll_wait /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/msan/msan_interceptors.cc:862:13 > #8 0x00001704b89b in epoll_dispatch ./../../base/third_party/libevent/epoll.c:198:8 > #9 0x00001703ec8b in event_base_loop ./../../base/third_party/libevent/event.c:512:9 > #10 0x00001355a138 in base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) ./../../base/message_loop/message_pump_libevent.cc:247:9 > #11 0x00001336b330 in base::RunLoop::Run() ./../../base/run_loop.cc:102:14 > #12 0x000015058275 in content::RunThisRunLoop(base::RunLoop*) ./../../content/public/test/test_utils.cc:128:13 > #13 0x00002b95647d in extensions::ResultCatcher::GetNextResult() ./../../extensions/test/result_catcher.cc:35:5 > #14 0x000004dfa6f2 in extensions::ExtensionApiTest::RunExtensionTestImpl(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, char const*, int) ./../../chrome/browser/extensions/extension_apitest.cc:392:16 > #15 0x0000049ace7e in extensions::ExtensionWebRequestApiTest_WebRequestAuthRequired_Test::RunTestOnMainThread() ./../../chrome/browser/extensions/api/web_request/web_request_apitest.cc:445:3 > #16 0x000014f9e3f2 in content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() ./../../content/public/test/browser_test_base.cc:385:5 > #17 0x00001387fbe5 in Run ./../../base/callback.h:125:12 > #18 0x00001387fbe5 in ChromeBrowserMainParts::PreMainMessageLoopRunImpl() ./../../chrome/browser/chrome_browser_main.cc:2098:0 > #19 0x00001387b5c0 in ChromeBrowserMainParts::PreMainMessageLoopRun() ./../../chrome/browser/chrome_browser_main.cc:1492:18 > #20 0x000007604b81 in chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() ./../../chrome/browser/chromeos/chrome_browser_main_chromeos.cc:684:32 > #21 0x00000bd8f78b in content::BrowserMainLoop::PreMainMessageLoopRun() ./../../content/browser/browser_main_loop.cc:962:13 > #22 0x00000d34ab21 in Run ./../../base/callback.h:125:12 > #23 0x00000d34ab21 in content::StartupTaskRunner::RunAllTasksNow() ./../../content/browser/startup_task_runner.cc:44:0 > #24 0x00000bd875e8 in content::BrowserMainLoop::CreateStartupTasks() ./../../content/browser/browser_main_loop.cc:873:25 > #25 0x00000bd9b176 in content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&, std::__1::unique_ptr<content::BrowserProcessSubThread, std::__1::default_delete<content::BrowserProcessSubThread> >) ./../../content/browser/browser_main_runner_impl.cc:148:15 > #26 0x00000bd7c28c in content::BrowserMain(content::MainFunctionParams const&, std::__1::unique_ptr<content::BrowserProcessSubThread, std::__1::default_delete<content::BrowserProcessSubThread> >) ./../../content/browser/browser_main.cc:47:20 > #27 0x000012ff6795 in content::RunBrowserProcessMain(content::MainFunctionParams const&, content::ContentMainDelegate*, std::__1::unique_ptr<content::BrowserProcessSubThread, std::__1::default_delete<content::BrowserProcessSubThread> >) ./../../content/app/content_main_runner_impl.cc:620:10 > #28 0x000012ffa9aa in content::ContentMainRunnerImpl::Run() ./../../content/app/content_main_runner_impl.cc:964:12 > #29 0x00001c607013 in service_manager::Main(service_manager::MainParams const&) ./../../services/service_manager/embedder/main.cc:459:29 > #30 0x000012ff0d18 in content::ContentMain(content::ContentMainParams const&) ./../../content/app/content_main.cc:19:10 > #31 0x000014f9c8c0 in content::BrowserTestBase::SetUp() ./../../content/public/test/browser_test_base.cc:323:3 > #32 0x00001372d0cf in InProcessBrowserTest::SetUp() ./../../chrome/test/base/in_process_browser_test.cc:244:20 > #33 0x000008b46826 in testing::Test::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 > #34 0x000008b4a8bc in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2667:11 > #35 0x000008b4c34a in testing::TestCase::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2785:28 > #36 0x000008b82a55 in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5047:43 > #37 0x000008b81328 in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 > #38 0x0000137959f1 in RUN_ALL_TESTS ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:2329:46 > #39 0x0000137959f1 in base::TestSuite::Run() ./../../base/test/test_suite.cc:275:0 > #40 0x0000131f45a4 in ChromeTestSuiteRunner::RunTestSuite(int, char**) ./../../chrome/test/base/chrome_test_launcher.cc:65:38 > #41 0x000015048025 in content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) ./../../content/public/test/test_launcher.cc:625:31 > #42 0x0000131f5d07 in LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) ./../../chrome/test/base/chrome_test_launcher.cc:170:10 > #43 0x0000131f4390 in main ./../../chrome/test/base/browser_tests_main_chromeos.cc:21:10 > #44 0x7f6d3332af45 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287:0 > #45 0x000000a511ba in _start ??:0:0 > [ RUN ] ExtensionWebRequestApiTest.WebRequestAuthRequired > [9971:9971:0529/225953.241021:WARNING:user_session_manager.cc(1091)] Attempting to save user password for non enterprise user. > ALSA lib confmisc.c:768:(parse_card) cannot find card '0' > ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_card_driver returned error: No such file or directory > ALSA lib confmisc.c:392:(snd_func_concat) error evaluating strings > ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_concat returned error: No such file or directory > ALSA lib confmisc.c:1251:(snd_func_refer) error evaluating name > ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory > ALSA lib conf.c:4727:(snd_config_expand) Evaluate error: No such file or directory > ALSA lib pcm.c:2239:(snd_pcm_open_noupdate) Unknown PCM default > [9971:9999:0529/225953.449328:WARNING:alsa_util.cc(24)] PcmOpen: default,No such file or directory > ALSA lib confmisc.c:768:(parse_card) cannot find card '0' > ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_card_driver returned error: No such file or directory > ALSA lib confmisc.c:392:(snd_func_concat) error evaluating strings > ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_concat returned error: No such file or directory > ALSA lib confmisc.c:1251:(snd_func_refer) error evaluating name > ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory > ALSA lib conf.c:4727:(snd_config_expand) Evaluate error: No such file or directory > ALSA lib pcm.c:2239:(snd_pcm_open_noupdate) Unknown PCM default > [9971:9999:0529/225953.449892:WARNING:alsa_util.cc(24)] PcmOpen: plug:default,No such file or directory > [9971:9971:0529/225958.400556:ERROR:textfield.cc(1754)] Not implemented reached in virtual bool views::Textfield::ShouldDoLearning() > [9971:10053:0529/225958.532493:WARNING:embedded_test_server.cc(229)] Request not handled. Returning 404: /favicon.ico > [9971:9971:0529/225959.377349:INFO:CONSOLE(0)] "[SUCCESS] authRequiredNonBlocking", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0) > [9971:9971:0529/230002.227064:INFO:CONSOLE(0)] "[SUCCESS] authRequiredSyncNoAction", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0) > [9971:9971:0529/230005.286414:INFO:CONSOLE(0)] "[SUCCESS] authRequiredSyncCancelAuth", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0) > [9971:9971:0529/230008.209328:INFO:CONSOLE(0)] "[SUCCESS] authRequiredSyncSetAuth", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0) > [9971:9971:0529/230103.646916:INFO:CONSOLE(0)] "[SUCCESS] authRequiredAsyncNoAction", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0) > [9971:9971:0529/230224.632095:INFO:CONSOLE(0)] "[SUCCESS] authRequiredAsyncCancelAuth", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0) > BrowserTestBase received signal: Terminated. Backtrace: > #0 0x000000a8dfe1 in __interceptor_backtrace /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/msan/../sanitizer_common/sanitizer_common_interceptors.inc:3980:13 > #1 0x00001350f30f in base::debug::StackTrace::StackTrace(unsigned long) ./../../base/debug/stack_trace_posix.cc:808:41 > #2 0x000014f9f062 in content::(anonymous namespace)::DumpStackTraceSignalHandler(int) ./../../content/public/test/browser_test_base.cc:87:5 > #3 0x000000ab5989 in SignalHandler(int) /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/msan/msan_interceptors.cc:995:3 > #4 0x7f12d1488cb0 in killpg ??:? > #5 0x7f12d1488cb0 in ?? ??:0 > #6 0x7f12d15506d3 in epoll_wait /build/eglibc-ripdx6/eglibc-2.19/misc/../sysdeps/unix/syscall-template.S:81:0 > #7 0x000000a770a4 in __interceptor_epoll_wait /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/msan/msan_interceptors.cc:862:13 > #8 0x00001704b89b in epoll_dispatch ./../../base/third_party/libevent/epoll.c:198:8 > #9 0x00001703ec8b in event_base_loop ./../../base/third_party/libevent/event.c:512:9 > #10 0x00001355a138 in base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) ./../../base/message_loop/message_pump_libevent.cc:247:9 > #11 0x00001336b330 in base::RunLoop::Run() ./../../base/run_loop.cc:102:14 > #12 0x000015058275 in content::RunThisRunLoop(base::RunLoop*) ./../../content/public/test/test_utils.cc:128:13 > #13 0x00002b95647d in extensions::ResultCatcher::GetNextResult() ./../../extensions/test/result_catcher.cc:35:5 > #14 0x000004dfa6f2 in extensions::ExtensionApiTest::RunExtensionTestImpl(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, char const*, int) ./../../chrome/browser/extensions/extension_apitest.cc:392:16 > #15 0x0000049ace7e in extensions::ExtensionWebRequestApiTest_WebRequestAuthRequired_Test::RunTestOnMainThread() ./../../chrome/browser/extensions/api/web_request/web_request_apitest.cc:445:3 > #16 0x000014f9e3f2 in content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() ./../../content/public/test/browser_test_base.cc:385:5 > #17 0x00001387fbe5 in Run ./../../base/callback.h:125:12 > #18 0x00001387fbe5 in ChromeBrowserMainParts::PreMainMessageLoopRunImpl() ./../../chrome/browser/chrome_browser_main.cc:2098:0 > #19 0x00001387b5c0 in ChromeBrowserMainParts::PreMainMessageLoopRun() ./../../chrome/browser/chrome_browser_main.cc:1492:18 > #20 0x000007604b81 in chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() ./../../chrome/browser/chromeos/chrome_browser_main_chromeos.cc:684:32 > #21 0x00000bd8f78b in content::BrowserMainLoop::PreMainMessageLoopRun() ./../../content/browser/browser_main_loop.cc:962:13 > #22 0x00000d34ab21 in Run ./../../base/callback.h:125:12 > #23 0x00000d34ab21 in content::StartupTaskRunner::RunAllTasksNow() ./../../content/browser/startup_task_runner.cc:44:0 > #24 0x00000bd875e8 in content::BrowserMainLoop::CreateStartupTasks() ./../../content/browser/browser_main_loop.cc:873:25 > #25 0x00000bd9b176 in content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&, std::__1::unique_ptr<content::BrowserProcessSubThread, std::__1::default_delete<content::BrowserProcessSubThread> >) ./../../content/browser/browser_main_runner_impl.cc:148:15 > #26 0x00000bd7c28c in content::BrowserMain(content::MainFunctionParams const&, std::__1::unique_ptr<content::BrowserProcessSubThread, std::__1::default_delete<content::BrowserProcessSubThread> >) ./../../content/browser/browser_main.cc:47:20 > #27 0x000012ff6795 in content::RunBrowserProcessMain(content::MainFunctionParams const&, content::ContentMainDelegate*, std::__1::unique_ptr<content::BrowserProcessSubThread, std::__1::default_delete<content::BrowserProcessSubThread> >) ./../../content/app/content_main_runner_impl.cc:620:10 > #28 0x000012ffa9aa in content::ContentMainRunnerImpl::Run() ./../../content/app/content_main_runner_impl.cc:964:12 > #29 0x00001c607013 in service_manager::Main(service_manager::MainParams const&) ./../../services/service_manager/embedder/main.cc:459:29 > #30 0x000012ff0d18 in content::ContentMain(content::ContentMainParams const&) ./../../content/app/content_main.cc:19:10 > #31 0x000014f9c8c0 in content::BrowserTestBase::SetUp() ./../../content/public/test/browser_test_base.cc:323:3 > #32 0x00001372d0cf in InProcessBrowserTest::SetUp() ./../../chrome/test/base/in_process_browser_test.cc:244:20 > #33 0x000008b46826 in testing::Test::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 > #34 0x000008b4a8bc in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2667:11 > #35 0x000008b4c34a in testing::TestCase::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2785:28 > #36 0x000008b82a55 in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5047:43 > #37 0x000008b81328 in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 > #38 0x0000137959f1 in RUN_ALL_TESTS ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:2329:46 > #39 0x0000137959f1 in base::TestSuite::Run() ./../../base/test/test_suite.cc:275:0 > #40 0x0000131f45a4 in ChromeTestSuiteRunner::RunTestSuite(int, char**) ./../../chrome/test/base/chrome_test_launcher.cc:65:38 > #41 0x000015048025 in content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) ./../../content/public/test/test_launcher.cc:625:31 > #42 0x0000131f5d07 in LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) ./../../chrome/test/base/chrome_test_launcher.cc:170:10 > #43 0x0000131f4390 in main ./../../chrome/test/base/browser_tests_main_chromeos.cc:21:10 > #44 0x7f12d1473f45 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287:0 > #45 0x000000a511ba in _start ??:0:0 > [ RUN ] ExtensionWebRequestApiTest.WebRequestAuthRequired > [10186:10186:0529/230253.379633:WARNING:user_session_manager.cc(1091)] Attempting to save user password for non enterprise user. > ALSA lib confmisc.c:768:(parse_card) cannot find card '0' > ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_card_driver returned error: No such file or directory > ALSA lib confmisc.c:392:(snd_func_concat) error evaluating strings > ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_concat returned error: No such file or directory > ALSA lib confmisc.c:1251:(snd_func_refer) error evaluating name > ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory > ALSA lib conf.c:4727:(snd_config_expand) Evaluate error: No such file or directory > ALSA lib pcm.c:2239:(snd_pcm_open_noupdate) Unknown PCM default > [10186:10214:0529/230253.588059:WARNING:alsa_util.cc(24)] PcmOpen: default,No such file or directory > ALSA lib confmisc.c:768:(parse_card) cannot find card '0' > ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_card_driver returned error: No such file or directory > ALSA lib confmisc.c:392:(snd_func_concat) error evaluating strings > ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_concat returned error: No such file or directory > ALSA lib confmisc.c:1251:(snd_func_refer) error evaluating name > ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory > ALSA lib conf.c:4727:(snd_config_expand) Evaluate error: No such file or directory > ALSA lib pcm.c:2239:(snd_pcm_open_noupdate) Unknown PCM default > [10186:10214:0529/230253.589228:WARNING:alsa_util.cc(24)] PcmOpen: plug:default,No such file or directory > [10186:10186:0529/230258.651324:ERROR:textfield.cc(1754)] Not implemented reached in virtual bool views::Textfield::ShouldDoLearning() > [10186:10267:0529/230258.790038:WARNING:embedded_test_server.cc(229)] Request not handled. Returning 404: /favicon.ico > [10186:10186:0529/230259.634483:INFO:CONSOLE(0)] "[SUCCESS] authRequiredNonBlocking", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0) > [10186:10186:0529/230302.223698:INFO:CONSOLE(0)] "[SUCCESS] authRequiredSyncNoAction", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0) > [10186:10186:0529/230305.265591:INFO:CONSOLE(0)] "[SUCCESS] authRequiredSyncCancelAuth", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0) > [10186:10186:0529/230308.238544:INFO:CONSOLE(0)] "[SUCCESS] authRequiredSyncSetAuth", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0) > [10186:10186:0529/230402.646445:INFO:CONSOLE(0)] "[SUCCESS] authRequiredAsyncNoAction", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0) > [10186:10186:0529/230525.634213:INFO:CONSOLE(0)] "[SUCCESS] authRequiredAsyncCancelAuth", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0) > BrowserTestBase received signal: Terminated. Backtrace: > #0 0x000000a8dfe1 in __interceptor_backtrace /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/msan/../sanitizer_common/sanitizer_common_interceptors.inc:3980:13 > #1 0x00001350f30f in base::debug::StackTrace::StackTrace(unsigned long) ./../../base/debug/stack_trace_posix.cc:808:41 > #2 0x000014f9f062 in content::(anonymous namespace)::DumpStackTraceSignalHandler(int) ./../../content/public/test/browser_test_base.cc:87:5 > #3 0x000000ab5989 in SignalHandler(int) /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/msan/msan_interceptors.cc:995:3 > #4 0x7f0a55d86cb0 in killpg ??:? > #5 0x7f0a55d86cb0 in ?? ??:0 > #6 0x000000a6d2d4 in __msan_set_alloca_origin4 /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/msan/msan.cc:558:12 > #7 0x00001b72c053 in std::__1::enable_if<(__is_forward_iterator<std::__1::__wrap_iter<cc::DrawImage*> >::value) && (is_constructible<cc::DrawImage, std::__1::iterator_traits<std::__1::__wrap_iter<cc::DrawImage*> >::reference>::value), std::__1::__wrap_iter<cc::DrawImage*> >::type std::__1::vector<cc::DrawImage, std::__1::allocator<cc::DrawImage> >::insert<std::__1::__wrap_iter<cc::DrawImage*> >(std::__1::__wrap_iter<cc::DrawImage const*>, std::__1::__wrap_iter<cc::DrawImage*>, std::__1::__wrap_iter<cc::DrawImage*>) ./../../buildtools/third_party/libc++/trunk/include/vector:1959:0 > #8 0x00001b71d05d in cc::TileManager::ScheduleTasks(cc::TileManager::PrioritizedWorkToSchedule) ./../../cc/tiles/tile_manager.cc:1021:21 > #9 0x00001b716797 in cc::TileManager::PrepareTiles(cc::GlobalStateThatImpactsTilePriority const&) ./../../cc/tiles/tile_manager.cc:520:3 > #10 0x00001b4bb195 in cc::LayerTreeHostImpl::PrepareTiles() ./../../cc/trees/layer_tree_host_impl.cc:607:42 > #11 0x00001b7ebfac in cc::SingleThreadProxy::ScheduledActionPrepareTiles() ./../../cc/trees/single_thread_proxy.cc:834:15 > #12 0x00001b83107b in cc::Scheduler::ProcessScheduledActions() ./../../cc/scheduler/scheduler.cc:0:20 > #13 0x00001b82fe9f in cc::Scheduler::OnBeginImplFrameDeadline() ./../../cc/scheduler/scheduler.cc:642:3 > #14 0x00001322a1d2 in Run ./../../base/callback.h:96:12 > #15 0x00001322a1d2 in base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) ./../../base/debug/task_annotator.cc:101:0 > #16 0x0000132ab7a5 in base::MessageLoop::RunTask(base::PendingTask*) ./../../base/message_loop/message_loop.cc:319:25 > #17 0x0000132adb1b in DeferOrRunPendingTask ./../../base/message_loop/message_loop.cc:329:5 > #18 0x0000132adb1b in base::MessageLoop::DoDelayedWork(base::TimeTicks*) ./../../base/message_loop/message_loop.cc:413:0 > #19 0x000013559d67 in base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) ./../../base/message_loop/message_pump_libevent.cc:220:27 > #20 0x00001336b330 in base::RunLoop::Run() ./../../base/run_loop.cc:102:14 > #21 0x000015058275 in content::RunThisRunLoop(base::RunLoop*) ./../../content/public/test/test_utils.cc:128:13 > #22 0x00002b95647d in extensions::ResultCatcher::GetNextResult() ./../../extensions/test/result_catcher.cc:35:5 > #23 0x000004dfa6f2 in extensions::ExtensionApiTest::RunExtensionTestImpl(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, char const*, int) ./../../chrome/browser/extensions/extension_apitest.cc:392:16 > #24 0x0000049ace7e in extensions::ExtensionWebRequestApiTest_WebRequestAuthRequired_Test::RunTestOnMainThread() ./../../chrome/browser/extensions/api/web_request/web_request_apitest.cc:445:3 > #25 0x000014f9e3f2 in content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() ./../../content/public/test/browser_test_base.cc:385:5 > #26 0x00001387fbe5 in Run ./../../base/callback.h:125:12 > #27 0x00001387fbe5 in ChromeBrowserMainParts::PreMainMessageLoopRunImpl() ./../../chrome/browser/chrome_browser_main.cc:2098:0 > #28 0x00001387b5c0 in ChromeBrowserMainParts::PreMainMessageLoopRun() ./../../chrome/browser/chrome_browser_main.cc:1492:18 > #29 0x000007604b81 in chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() ./../../chrome/browser/chromeos/chrome_browser_main_chromeos.cc:684:32 > #30 0x00000bd8f78b in content::BrowserMainLoop::PreMainMessageLoopRun() ./../../content/browser/browser_main_loop.cc:962:13 > #31 0x00000d34ab21 in Run ./../../base/callback.h:125:12 > #32 0x00000d34ab21 in content::StartupTaskRunner::RunAllTasksNow() ./../../content/browser/startup_task_runner.cc:44:0 > #33 0x00000bd875e8 in content::BrowserMainLoop::CreateStartupTasks() ./../../content/browser/browser_main_loop.cc:873:25 > #34 0x00000bd9b176 in content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&, std::__1::unique_ptr<content::BrowserProcessSubThread, std::__1::default_delete<content::BrowserProcessSubThread> >) ./../../content/browser/browser_main_runner_impl.cc:148:15 > #35 0x00000bd7c28c in content::BrowserMain(content::MainFunctionParams const&, std::__1::unique_ptr<content::BrowserProcessSubThread, std::__1::default_delete<content::BrowserProcessSubThread> >) ./../../content/browser/browser_main.cc:47:20 > #36 0x000012ff6795 in content::RunBrowserProcessMain(content::MainFunctionParams const&, content::ContentMainDelegate*, std::__1::unique_ptr<content::BrowserProcessSubThread, std::__1::default_delete<content::BrowserProcessSubThread> >) ./../../content/app/content_main_runner_impl.cc:620:10 > #37 0x000012ffa9aa in content::ContentMainRunnerImpl::Run() ./../../content/app/content_main_runner_impl.cc:964:12 > #38 0x00001c607013 in service_manager::Main(service_manager::MainParams const&) ./../../services/service_manager/embedder/main.cc:459:29 > #39 0x000012ff0d18 in content::ContentMain(content::ContentMainParams const&) ./../../content/app/content_main.cc:19:10 > #40 0x000014f9c8c0 in content::BrowserTestBase::SetUp() ./../../content/public/test/browser_test_base.cc:323:3 > #41 0x00001372d0cf in InProcessBrowserTest::SetUp() ./../../chrome/test/base/in_process_browser_test.cc:244:20 > #42 0x000008b46826 in testing::Test::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 > #43 0x000008b4a8bc in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2667:11 > #44 0x000008b4c34a in testing::TestCase::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2785:28 > #45 0x000008b82a55 in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5047:43 > #46 0x000008b81328 in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 > #47 0x0000137959f1 in RUN_ALL_TESTS ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:2329:46 > #48 0x0000137959f1 in base::TestSuite::Run() ./../../base/test/test_suite.cc:275:0 > #49 0x0000131f45a4 in ChromeTestSuiteRunner::RunTestSuite(int, char**) ./../../chrome/test/base/chrome_test_launcher.cc:65:38 > #50 0x000015048025 in content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) ./../../content/public/test/test_launcher.cc:625:31 > #51 0x0000131f5d07 in LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) ./../../chrome/test/base/chrome_test_launcher.cc:170:10 > #52 0x0000131f4390 in main ./../../chrome/test/base/browser_tests_main_chromeos.cc:21:10 > #53 0x7f0a55d71f45 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287:0 > #54 0x000000a511ba in _start ??:0:0 > > > Original change's description: > > shared worker: Add tests for Chrome extensions. > > > > We didn't have specific test coverage for shared worker from Chrome > > extensions, just incidental ones via the ExtensionApiTest.Debugger and > > ExtensionApiTestWithSwitch.ExtensionDebugger. > > > > Shared workers go through a very different loading path than other > > resources, so it's useful to have tests for them especially > > including interaction with service workers. > > > > This adds tests that currently fail with NetworkService, a next > > patch will have a fix. > > > > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo > > Change-Id: Ifa6bb3dec8bdea34c3fbefbaeab324fadcb5c929 > > Bug: 839982 > > Reviewed-on: https://chromium-review.googlesource.com/1074848 > > Commit-Queue: Matt Falkenhagen <falken@chromium.org> > > Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#562700} > > TBR=falken@chromium.org,lazyboy@chromium.org > > Change-Id: I880c6e859c9414070ad4783dc9e703f4324ecf29 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 839982 > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo > Reviewed-on: https://chromium-review.googlesource.com/1078367 > Reviewed-by: Thiemo Nagel <tnagel@chromium.org> > Commit-Queue: Thiemo Nagel <tnagel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#562766} TBR=falken@chromium.org,lazyboy@chromium.org,tnagel@chromium.org Change-Id: I991a94e747d633670cf7fa886c177626d553f690 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 839982 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/1078387 Reviewed-by: Thiemo Nagel <tnagel@chromium.org> Commit-Queue: Thiemo Nagel <tnagel@chromium.org> Cr-Commit-Position: refs/heads/master@{#562770}

This reverts commit 74b9888. Reason for revert: Flaking on Linux ChromiumOS MSan Tests https://ci.chromium.org/buildbot/chromium.memory/Linux%20ChromiumOS%20MSan%20Tests/7361 https://ci.chromium.org/buildbot/chromium.memory/Linux%20ChromiumOS%20MSan%20Tests/7363 https://ci.chromium.org/buildbot/chromium.memory/Linux%20ChromiumOS%20MSan%20Tests/7364 [ RUN ] ExtensionWebRequestApiTest.WebRequestAuthRequired [14149:14149:0529/223016.256914:WARNING:user_session_manager.cc(1091)] Attempting to save user password for non enterprise user. ALSA lib confmisc.c:768:(parse_card) cannot find card '0' ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_card_driver returned error: No such file or directory ALSA lib confmisc.c:392:(snd_func_concat) error evaluating strings ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_concat returned error: No such file or directory ALSA lib confmisc.c:1251:(snd_func_refer) error evaluating name ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory ALSA lib conf.c:4727:(snd_config_expand) Evaluate error: No such file or directory ALSA lib pcm.c:2239:(snd_pcm_open_noupdate) Unknown PCM default [14149:14299:0529/223016.655436:WARNING:alsa_util.cc(24)] PcmOpen: default,No such file or directory ALSA lib confmisc.c:768:(parse_card) cannot find card '0' ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_card_driver returned error: No such file or directory ALSA lib confmisc.c:392:(snd_func_concat) error evaluating strings ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_concat returned error: No such file or directory ALSA lib confmisc.c:1251:(snd_func_refer) error evaluating name ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory ALSA lib conf.c:4727:(snd_config_expand) Evaluate error: No such file or directory ALSA lib pcm.c:2239:(snd_pcm_open_noupdate) Unknown PCM default [14149:14299:0529/223016.656150:WARNING:alsa_util.cc(24)] PcmOpen: plug:default,No such file or directory [14149:14149:0529/223023.245267:ERROR:textfield.cc(1754)] Not implemented reached in virtual bool views::Textfield::ShouldDoLearning() [14149:14372:0529/223023.626405:WARNING:embedded_test_server.cc(229)] Request not handled. Returning 404: /favicon.ico [14149:14149:0529/223024.849020:INFO:CONSOLE(0)] "[SUCCESS] authRequiredNonBlocking", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0) [14149:14149:0529/223027.955574:INFO:CONSOLE(0)] "[SUCCESS] authRequiredSyncNoAction", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0) [14149:14149:0529/223031.378924:INFO:CONSOLE(0)] "[SUCCESS] authRequiredSyncCancelAuth", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0) [14149:14149:0529/223034.498789:INFO:CONSOLE(0)] "[SUCCESS] authRequiredSyncSetAuth", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0) [14149:14149:0529/223216.859287:INFO:CONSOLE(0)] "[SUCCESS] authRequiredAsyncNoAction", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0) BrowserTestBase received signal: Terminated. Backtrace: #0 0x000000a8dfe1 in __interceptor_backtrace /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/msan/../sanitizer_common/sanitizer_common_interceptors.inc:3980:13 #1 0x00001350f30f in base::debug::StackTrace::StackTrace(unsigned long) ./../../base/debug/stack_trace_posix.cc:808:41 #2 0x000014f9f062 in content::(anonymous namespace)::DumpStackTraceSignalHandler(int) ./../../content/public/test/browser_test_base.cc:87:5 #3 0x000000ab5989 in SignalHandler(int) /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/msan/msan_interceptors.cc:995:3 #4 0x7fe3e82dacb0 in killpg ??:? #5 0x7fe3e82dacb0 in ?? ??:0 #6 0x7fe3e83a26d3 in epoll_wait /build/eglibc-ripdx6/eglibc-2.19/misc/../sysdeps/unix/syscall-template.S:81:0 #7 0x000000a770a4 in __interceptor_epoll_wait /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/msan/msan_interceptors.cc:862:13 #8 0x00001704b89b in epoll_dispatch ./../../base/third_party/libevent/epoll.c:198:8 #9 0x00001703ec8b in event_base_loop ./../../base/third_party/libevent/event.c:512:9 #10 0x00001355a138 in base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) ./../../base/message_loop/message_pump_libevent.cc:247:9 #11 0x00001336b330 in base::RunLoop::Run() ./../../base/run_loop.cc:102:14 #12 0x000015058275 in content::RunThisRunLoop(base::RunLoop*) ./../../content/public/test/test_utils.cc:128:13 #13 0x00002b95647d in extensions::ResultCatcher::GetNextResult() ./../../extensions/test/result_catcher.cc:35:5 #14 0x000004dfa6f2 in extensions::ExtensionApiTest::RunExtensionTestImpl(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, char const*, int) ./../../chrome/browser/extensions/extension_apitest.cc:392:16 #15 0x0000049ace7e in extensions::ExtensionWebRequestApiTest_WebRequestAuthRequired_Test::RunTestOnMainThread() ./../../chrome/browser/extensions/api/web_request/web_request_apitest.cc:445:3 #16 0x000014f9e3f2 in content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() ./../../content/public/test/browser_test_base.cc:385:5 #17 0x00001387fbe5 in Run ./../../base/callback.h:125:12 #18 0x00001387fbe5 in ChromeBrowserMainParts::PreMainMessageLoopRunImpl() ./../../chrome/browser/chrome_browser_main.cc:2098:0 #19 0x00001387b5c0 in ChromeBrowserMainParts::PreMainMessageLoopRun() ./../../chrome/browser/chrome_browser_main.cc:1492:18 #20 0x000007604b81 in chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() ./../../chrome/browser/chromeos/chrome_browser_main_chromeos.cc:684:32 #21 0x00000bd8f78b in content::BrowserMainLoop::PreMainMessageLoopRun() ./../../content/browser/browser_main_loop.cc:962:13 #22 0x00000d34ab21 in Run ./../../base/callback.h:125:12 #23 0x00000d34ab21 in content::StartupTaskRunner::RunAllTasksNow() ./../../content/browser/startup_task_runner.cc:44:0 #24 0x00000bd875e8 in content::BrowserMainLoop::CreateStartupTasks() ./../../content/browser/browser_main_loop.cc:873:25 #25 0x00000bd9b176 in content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&, std::__1::unique_ptr<content::BrowserProcessSubThread, std::__1::default_delete<content::BrowserProcessSubThread> >) ./../../content/browser/browser_main_runner_impl.cc:148:15 #26 0x00000bd7c28c in content::BrowserMain(content::MainFunctionParams const&, std::__1::unique_ptr<content::BrowserProcessSubThread, std::__1::default_delete<content::BrowserProcessSubThread> >) ./../../content/browser/browser_main.cc:47:20 #27 0x000012ff6795 in content::RunBrowserProcessMain(content::MainFunctionParams const&, content::ContentMainDelegate*, std::__1::unique_ptr<content::BrowserProcessSubThread, std::__1::default_delete<content::BrowserProcessSubThread> >) ./../../content/app/content_main_runner_impl.cc:620:10 #28 0x000012ffa9aa in content::ContentMainRunnerImpl::Run() ./../../content/app/content_main_runner_impl.cc:964:12 #29 0x00001c607013 in service_manager::Main(service_manager::MainParams const&) ./../../services/service_manager/embedder/main.cc:459:29 #30 0x000012ff0d18 in content::ContentMain(content::ContentMainParams const&) ./../../content/app/content_main.cc:19:10 #31 0x000014f9c8c0 in content::BrowserTestBase::SetUp() ./../../content/public/test/browser_test_base.cc:323:3 #32 0x00001372d0cf in InProcessBrowserTest::SetUp() ./../../chrome/test/base/in_process_browser_test.cc:244:20 #33 0x000008b46826 in testing::Test::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #34 0x000008b4a8bc in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2667:11 #35 0x000008b4c34a in testing::TestCase::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2785:28 #36 0x000008b82a55 in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5047:43 #37 0x000008b81328 in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #38 0x0000137959f1 in RUN_ALL_TESTS ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:2329:46 #39 0x0000137959f1 in base::TestSuite::Run() ./../../base/test/test_suite.cc:275:0 #40 0x0000131f45a4 in ChromeTestSuiteRunner::RunTestSuite(int, char**) ./../../chrome/test/base/chrome_test_launcher.cc:65:38 #41 0x000015048025 in content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) ./../../content/public/test/test_launcher.cc:625:31 #42 0x0000131f5d07 in LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) ./../../chrome/test/base/chrome_test_launcher.cc:170:10 #43 0x0000131f4390 in main ./../../chrome/test/base/browser_tests_main_chromeos.cc:21:10 #44 0x7fe3e82c5f45 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287:0 #45 0x000000a511ba in _start ??:0:0 Original change's description: > Re-enable WebRequestAuthRequired test. > > ExtensionWebRequestApiTest.WebRequestAuthRequired has been disabled > forever. It was originally disabled for flakiness, but neither the > flaky crashes nor the code which was crashing appear to exist anymore. > > This CL makes some minor updates to the test expectations and re-enables > the test. > > Bug: 140976,841827 > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo > Change-Id: I97879b51e600cff684defcbef37fcfbae3dfda62 > Reviewed-on: https://chromium-review.googlesource.com/1076683 > Reviewed-by: Karan Bhatia <karandeepb@chromium.org> > Commit-Queue: Ken Rockot <rockot@chromium.org> > Cr-Commit-Position: refs/heads/master@{#562546} TBR=rockot@chromium.org,karandeepb@chromium.org Change-Id: I31e6774d763450d791f05397214a355e77419e44 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 140976, 841827 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/1078487 Reviewed-by: Thiemo Nagel <tnagel@chromium.org> Commit-Queue: Thiemo Nagel <tnagel@chromium.org> Cr-Commit-Position: refs/heads/master@{#562773}

…cr-input" This reverts commit b829c17. Reason for revert: SettingsPasswordSectionBrowserTest.uiTests has been failing consistently since this CL landed. On Linux and CrOS Stacktrace: [28290:28290:0531/210110.220114:ERROR:web_ui_browser_test.cc(478)] JS call assumed failed, because JS console error(s) found. gen/chrome/test/data/webui/settings/settings_passwords_section_browsertest-gen.cc:41: Failure Value of: RunJavascriptTestF( true, "SettingsPasswordSectionBrowserTest", "uiTests") Actual: false Expected: true Stack trace: #0 0x000003df7e60 StackTraceGetter::CurrentStackTrace() #1 0x000003e18927 testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop() #2 0x000003e17d8d testing::internal::AssertHelper::operator=() #3 0x000002f69fe7 SettingsPasswordSectionBrowserTest_uiTests_Test::RunTestOnMainThread() #4 0x0000075a5ece content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #5 0x0000009a452d _ZN4base8internal13FunctorTraitsIM25RenderViewContextMenuBaseFvvEvE6InvokeIS4_P21RenderViewContextMenuJEEEvT_OT0_DpOT1_ #6 0x0000009a4474 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIM25RenderViewContextMenuBaseFvvEJP21RenderViewContextMenuEEEvOT_DpOT0_ #7 0x0000075a7eb5 _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserTestBaseEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE7RunImplIRKS6_RKNSt3__15tupleIJS8_EEEJLm0EEEEvOT_OT0_NSF_16integer_sequenceImJXspT1_EEEE #8 0x0000075a7dfc _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserTestBaseEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE3RunEPNS0_13BindStateBaseE #9 0x0000009966ed _ZNKR4base17RepeatingCallbackIFvvEE3RunEv #10 0x000006519af7 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #11 0x000006517cde ChromeBrowserMainParts::PreMainMessageLoopRun() #12 0x000003290375 chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() #13 0x7fd41048cb4c content::BrowserMainLoop::PreMainMessageLoopRun() #14 0x7fd40f27ea0d _ZN4base8internal13FunctorTraitsIMN7content12ChildProcessEFvvEvE6InvokeIS5_PS3_JEEEvT_OT0_DpOT1_ #15 0x7fd40f27e954 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIMN7content12ChildProcessEFvvEJPS5_EEEvOT_DpOT0_ #16 0x7fd4104928e5 _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserMainLoopEFivEJNS0_17UnretainedWrapperIS4_EEEEEFivEE7RunImplIRKS6_RKNSt3__15tupleIJS8_EEEJLm0EEEEiOT_OT0_NSF_16integer_sequenceImJXspT1_EEEE #17 0x7fd41049282c _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserMainLoopEFivEJNS0_17UnretainedWrapperIS4_EEEEEFivEE3RunEPNS0_13BindStateBaseE #18 0x7fd40f18c70d _ZNKR4base17RepeatingCallbackIFvvEE3RunEv #19 0x7fd4112d797d content::StartupTaskRunner::RunAllTasksNow() #20 0x7fd410488230 content::BrowserMainLoop::CreateStartupTasks() #21 0x7fd410494fc7 content::BrowserMainRunnerImpl::Initialize() #22 0x7fd410480729 content::BrowserMain() #23 0x7fd41254804b content::RunBrowserProcessMain() #24 0x7fd41254a055 content::ContentMainRunnerImpl::Run() #25 0x7fd41253ed55 content::ContentServiceManagerMainDelegate::RunEmbedderProcess() #26 0x7fd40b7add1b service_manager::Main() #27 0x7fd412544ef5 content::ContentMain() #28 0x0000075a5478 content::BrowserTestBase::SetUp() #29 0x00000641cabb InProcessBrowserTest::SetUp() #30 0x00000091fc3e _ZN7testing8internal12InvokeHelperIRKNSt3__16vectorIPN12user_manager4UserENS2_9allocatorIS6_EEEENS2_5tupleIJEEEE12InvokeMethodIN8chromeos15MockUserManagerEMSH_KFSB_vEEESB_PT_T0_RKSD_ Original change's description: > WebUI[MD-refresh]: Add [type="password"] and ["readonly"] to cr-input > > Bug: 832177 > Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation > Change-Id: If05ffdfc80374c79dec5bbb1422ff44a4489818d > Reviewed-on: https://chromium-review.googlesource.com/1070861 > Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> > Commit-Queue: Scott Chen <scottchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#563488} TBR=dpapad@chromium.org,scottchen@chromium.org Change-Id: I48576bfdebf17815a26e48301ae8463452b3e63f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 832177 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/1082453 Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#563605}

This is a reland of a663e7f The original cl causes some flaky tests with stack trace: [16202:16202:0709/211202.910243:FATAL:single_thread_proxy.cc(237)] Check failed: task_runner_provider_->IsMainThread(). #0 0x7f9b36f8672d base::debug::StackTrace::StackTrace() #1 0x7f9b36c9d3fc base::debug::StackTrace::StackTrace() #2 0x7f9b36d06dfd logging::LogMessage::~LogMessage() #3 0x7f9b2b5692e8 cc::SingleThreadProxy::SetNeedsCommit() #4 0x7f9b2b45ecef cc::LayerTreeHost::SetNeedsCommit() #5 0x7f9b2b467426 cc::LayerTreeHost::SetMutatorsNeedCommit() #6 0x7f9b0fd29981 cc::AnimationHost::SetNeedsCommit() #7 0x7f9b0fd1962d cc::Animation::SetNeedsCommit() #8 0x7f9b0fd41151 cc::KeyframeEffect::KeyframeModelAdded() #9 0x7f9b0fd44e6c cc::KeyframeEffect::AddKeyframeModel() #10 0x7f9b0fd17fbc cc::Animation::AddKeyframeModelForKeyframeEffect() #11 0x7f9b0fd71a6d cc::SingleKeyframeEffectAnimation::AddKeyframeModel() #12 0x7f9b28c83a95 ui::LayerAnimator::AddThreadedAnimation() #13 0x7f9b28c7498e ui::(anonymous namespace)::ThreadedLayerAnimationElement::RequestEffectiveStart() #14 0x7f9b28c71113 ui::LayerAnimationElement::Start() #15 0x7f9b28c7cbe3 ui::LayerAnimationSequence::Start() #16 0x7f9b28c84287 ui::LayerAnimator::StartSequenceImmediately() #17 0x7f9b28c81251 ui::LayerAnimator::StartAnimation() #18 0x7f9b28c80eb6 ui::LayerAnimator::SetTransform() #19 0x7f9b28c6122e ui::Layer::SetTransform() #20 0x7f9b28ded831 aura::Window::SetTransform() #21 0x7f9b22b732df ash::ScopedTransformOverviewWindow::SetTransform() #22 0x7f9b22b73f69 ash::ScopedTransformOverviewWindow::OnCompositingStarted() #23 0x7f9b28c4d734 ui::Compositor::DidSubmitCompositorFrame() #24 0x7f9b2b56cd05 cc::SingleThreadProxy::DoComposite() #25 0x7f9b2b56e835 cc::SingleThreadProxy::ScheduledActionDrawIfPossible() #26 0x7f9b2b3736fd cc::Scheduler::DrawIfPossible() #27 0x7f9b2b36dbdc cc::Scheduler::ProcessScheduledActions() #28 0x7f9b2b36d5fd cc::Scheduler::OnBeginImplFrameDeadline() This cl makes that test skip waiting for composit when entering overview, like the tests in ash. Original change's description: > overview: Hide title bars before animating into overview mode. > > The title bars should not visible while animating overview mode. This cl > hides the title bar if needed and waits until the next paint before > animating the windows. This will hide the title bar as expected while > keeping the benefits of DeferPaint. > > Test: manual > Bug: 843851 > Change-Id: I99cf7ca39fd1ae14314ac406abd0fec999e2c024 > Reviewed-on: https://chromium-review.googlesource.com/1112774 > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Reviewed-by: Tao Wu <wutao@chromium.org> > Commit-Queue: Sammie Quon <sammiequon@chromium.org> > Cr-Commit-Position: refs/heads/master@{#573552} TBR=oshima@chromium.org Bug: 843851 Change-Id: I3a538250d5f6d42d6c73e218445080af533b54dc Reviewed-on: https://chromium-review.googlesource.com/1131874 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by: Sammie Quon <sammiequon@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#574209}

…askQueueController"" This reverts commit fa8e920. Reason for revert: Broke https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/6992 [ RUN ] MainThreadSchedulerImplTest.Tracing Received signal 11 <unknown> 000000000000 #0 0x7fb8aa445edd base::debug::StackTrace::StackTrace() Igalia#1 0x7fb8aa15949c base::debug::StackTrace::StackTrace() Igalia#2 0x7fb8aa445968 base::debug::(anonymous namespace)::StackDumpSignalHandler() Igalia#3 0x7fb89dd8a330 <unknown> Igalia#4 0x7fb8aa3eb77e logging::CheckEQImpl<>() Igalia#5 0x7fb8aa3e531c base::trace_event::TracedValue::EndDictionary() Igalia#6 0x7fb8aaf41afe blink::scheduler::MainThreadSchedulerImpl::AsValueLocked() Igalia#7 0x7fb8aaf40792 blink::scheduler::MainThreadSchedulerImpl::AsValue() Igalia#8 0x00000181a3aa blink::scheduler::main_thread_scheduler_impl_unittest::MainThreadSchedulerImplTest_Tracing_Test::TestBody() Igalia#9 0x000000c4452e testing::internal::HandleSehExceptionsInMethodIfSupported<>() Igalia#10 0x000000c38192 testing::internal::HandleExceptionsInMethodIfSupported<>() Igalia#11 0x000000c1bd06 testing::Test::Run() Igalia#12 0x000000c1c6f0 testing::TestInfo::Run() Igalia#13 0x000000c1d19f testing::TestCase::Run() Igalia#14 0x000000c2f348 testing::internal::UnitTestImpl::RunAllTests() Igalia#15 0x000000c445be testing::internal::HandleSehExceptionsInMethodIfSupported<>() Igalia#16 0x000000c39942 testing::internal::HandleExceptionsInMethodIfSupported<>() Igalia#17 0x000000c2efa7 testing::UnitTest::Run() Igalia#18 0x000001a62ac1 RUN_ALL_TESTS() Igalia#19 0x000001a5f48b base::TestSuite::Run() Igalia#20 0x000000bd1d45 (anonymous namespace)::runTestSuite() Igalia#21 0x000000a3e560 _ZN4base8internal13FunctorTraitsIPFvPbEvE6InvokeIRKS4_JRKS2_EEEvOT_DpOT0_ Igalia#22 0x000000a3e51d _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIPFvPbEJS4_EEEvOT_DpOT0_ Igalia#23 0x000000bd1f75 _ZN4base8internal7InvokerINS0_9BindStateIPFiPNS_9TestSuiteEEJNS0_17UnretainedWrapperIS3_EEEEEFivEE7RunImplIS6_NSt3__15tupleIJS8_EEEJLm0EEEEiOT_OT0_NSD_16integer_sequenceImJXspT1_EEEE Igalia#24 0x000000bd1ec9 _ZN4base8internal7InvokerINS0_9BindStateIPFiPNS_9TestSuiteEEJNS0_17UnretainedWrapperIS3_EEEEEFivEE7RunOnceEPNS0_13BindStateBaseE Igalia#25 0x000001a708fe _ZNO4base12OnceCallbackIFivEE3RunEv Igalia#26 0x000001a697d0 base::(anonymous namespace)::LaunchUnitTestsInternal() Igalia#27 0x000001a69645 base::LaunchUnitTests() Igalia#28 0x000000bd1cd6 main Igalia#29 0x7fb89d4c3f45 __libc_start_main Igalia#30 0x000000552d1a _start r8: 0000000000000001 r9: 00007fff6f9d4b30 r10: 0000000000000000 r11: 0000000000000000 r12: 0000000000552cf0 r13: 00007fff6f9d6af0 r14: 0000000000000000 r15: 0000000000000000 di: 00007fb8aa50a878 si: 200031ca83cdc758 bp: 00007fff6f9d4990 bx: 0000000000000000 dx: 00007fff6f9d4ae8 ax: 00007fb8aa50a800 cx: 0000000000000000 sp: 00007fff6f9d4960 ip: 00007fb8aa3eb77e efl: 0000000000010246 cgf: 0000000000000033 erf: 0000000000000000 trp: 000000000000000d msk: 0000000000000000 cr2: 0000000000000000 [end of stack trace] Calling _exit(1). Core file will not be generated. Original change's description: > Reland "[scheduler] Refactor FrameSchedulerImpl to use FrameTaskQueueController" > > This is a reland of e2d8996 > > Original change's description: > > [scheduler] Refactor FrameSchedulerImpl to use FrameTaskQueueController > > > > This CL moves all task queue management and creation to > > FrameTaskQueueController and adds the appropriate interface for > > accessing queues in FrameTaskQueueController. TaskType to QueueTraits > > management is handled by FrameSchedulerImpl since it embeds policy, and > > FrameTaskQueueController exposes an interface to get non-loading task > > queues by QueueTraits, as well as accessing loading and loading > > control task queues. > > > > Bug: 859963 > > Change-Id: I7db5aaaa148d0dc4f3f70e517e088a205e502db8 > > Reviewed-on: https://chromium-review.googlesource.com/1142390 > > Commit-Queue: Scott Haseley <shaseley@google.com> > > Reviewed-by: Alexander Timin <altimin@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#576619} > > Bug: 859963 > Change-Id: Id2c9179b580759b815602d61b98c99d1f3f5253d > Reviewed-on: https://chromium-review.googlesource.com/1144608 > Commit-Queue: Scott Haseley <shaseley@google.com> > Reviewed-by: Alexander Timin <altimin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#578008} TBR=altimin@chromium.org,panicker@chromium.org,shaseley@google.com Change-Id: Ia71d2641655c8100b82a8ce7e4a11009d19b5e9a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 859963 Reviewed-on: https://chromium-review.googlesource.com/1150585 Reviewed-by: Derek Cheng <imcheng@chromium.org> Commit-Queue: Derek Cheng <imcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#578067}

This reverts commit 32cd8fc. Reason for revert: Reverting the revert because this change was proven to not have caused the issue. Original change's description: > Revert "cros: Enable touchable app context menus by default." > > This reverts commit b58ccf6. > > Reason for revert: Possibly introduced a use-after-free bug. > > This is a speculative fix for a use-after-free bug in two ash_unittests: > > 1. OverflowButtonInkDropTest.MouseContextMenu > 2. OverflowButtonActiveInkDropTest.MouseContextMenu > > [ RUN ] OverflowButtonInkDropTest.MouseContextMenu > ================================================================= > ==28149==ERROR: AddressSanitizer: heap-use-after-free on address 0x613000031f68 at pc 0x000008c82106 bp 0x7ffea3cd7190 sp 0x7ffea3cd7188 > READ of size 8 at 0x613000031f68 thread T0 > #0 0x8c82105 in begin buildtools/third_party/libc++/trunk/include/vector:1479:30 > Igalia#1 0x8c82105 in begin<std::__1::vector<aura::WindowObserver *, std::__1::allocator<aura::WindowObserver *> > > buildtools/third_party/libc++/trunk/include/iterator:1670 > Igalia#2 0x8c82105 in ContainsValue<std::__1::vector<aura::WindowObserver *, std::__1::allocator<aura::WindowObserver *> >, const aura::WindowObserver *, 0> base/stl_util.h:168 > Igalia#3 0x8c82105 in HasObserver base/observer_list.h:267 > Igalia#4 0x8c82105 in aura::Window::HasObserver(aura::WindowObserver const*) const ui/aura/window.cc:543 > Igalia#5 0x8c9d363 in aura::WindowObserver::OnUnobservingWindow(aura::Window*) ui/aura/window_observer.cc:25:15 > Igalia#6 0x8c799d7 in aura::Window::RemoveObserver(aura::WindowObserver*) ui/aura/window.cc:538:13 > Igalia#7 0xc2f40e in RemoveAll ui/base/window_tracker_template.h:49:15 > Igalia#8 0xc2f40e in ui::WindowTrackerTemplate<aura::Window, aura::WindowObserver>::~WindowTrackerTemplate() ui/base/window_tracker_template.h:33 > Igalia#9 0x9225f3b in ~CompoundEventFilter ui/wm/core/compound_event_filter.cc:49:1 > Igalia#10 0x9225f3b in wm::CompoundEventFilter::~CompoundEventFilter() ui/wm/core/compound_event_filter.cc:45 > Igalia#11 0x6b0ae30 in operator() buildtools/third_party/libc++/trunk/include/memory:2321:5 > Igalia#12 0x6b0ae30 in reset buildtools/third_party/libc++/trunk/include/memory:2634 > Igalia#13 0x6b0ae30 in ~unique_ptr buildtools/third_party/libc++/trunk/include/memory:2588 > Igalia#14 0x6b0ae30 in ash::Shell::~Shell() ash/shell.cc:969 > Igalia#15 0x6b0c81d in ash::Shell::~Shell() ash/shell.cc:737:17 > Igalia#16 0xc26b344 in ash::AshTestHelper::TearDown() ash/test/ash_test_helper.cc:294:3 > Igalia#17 0xc26444c in ash::AshTestBase::TearDown() ash/test/ash_test_base.cc:192:21 > Igalia#18 0x4724c64 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2682:11 > Igalia#19 0x4726036 in testing::TestCase::Run() third_party/googletest/src/googletest/src/gtest.cc:2800:28 > Igalia#20 0x474b566 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5124:43 > Igalia#21 0x474a7b5 in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc > Igalia#22 0x72b431a in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2331:46 > Igalia#23 0x72b431a in base::TestSuite::Run() base/test/test_suite.cc:277 > Igalia#24 0x72b9892 in Run base/callback.h:99:12 > Igalia#25 0x72b9892 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) base/test/launcher/unit_test_launcher.cc:224 > Igalia#26 0x72b9330 in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) base/test/launcher/unit_test_launcher.cc:575:10 > Igalia#27 0x178df94 in main ash/test/ash_unittests.cc:37:10 > Igalia#28 0x7f78e2b62f44 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287 > > 0x613000031f68 is located 296 bytes inside of 328-byte region [0x613000031e40,0x613000031f88) > freed by thread T0 here: > #0 0x6b9062 in operator delete(void*) /b/swarming/w/ir/kitchen-workdir/src/third_party/llvm/compiler-rt/lib/asan/asan_new_delete.cc:167:3 > Igalia#1 0x6a547a0 in ash::RootWindowController::CloseChildWindows() ash/root_window_controller.cc:498:7 > Igalia#2 0x6b0c5cf in ash::Shell::CloseAllRootWindowChildWindows() ash/shell.cc:1387:19 > Igalia#3 0x6b06637 in ash::Shell::~Shell() ash/shell.cc:837:3 > Igalia#4 0x6b0c81d in ash::Shell::~Shell() ash/shell.cc:737:17 > Igalia#5 0xc26b344 in ash::AshTestHelper::TearDown() ash/test/ash_test_helper.cc:294:3 > Igalia#6 0xc26444c in ash::AshTestBase::TearDown() ash/test/ash_test_base.cc:192:21 > Igalia#7 0x4724c64 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2682:11 > Igalia#8 0x4726036 in testing::TestCase::Run() third_party/googletest/src/googletest/src/gtest.cc:2800:28 > Igalia#9 0x474b566 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5124:43 > Igalia#10 0x474a7b5 in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc > Igalia#11 0x72b431a in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2331:46 > Igalia#12 0x72b431a in base::TestSuite::Run() base/test/test_suite.cc:277 > Igalia#13 0x72b9892 in Run base/callback.h:99:12 > Igalia#14 0x72b9892 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) base/test/launcher/unit_test_launcher.cc:224 > Igalia#15 0x72b9330 in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) base/test/launcher/unit_test_launcher.cc:575:10 > Igalia#16 0x178df94 in main ash/test/ash_unittests.cc:37:10 > Igalia#17 0x7f78e2b62f44 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287 > > previously allocated by thread T0 here: > #0 0x6b8422 in operator new(unsigned long) /b/swarming/w/ir/kitchen-workdir/src/third_party/llvm/compiler-rt/lib/asan/asan_new_delete.cc:106:3 > Igalia#1 0x91cb856 in views::NativeWidgetAura::NativeWidgetAura(views::internal::NativeWidgetDelegate*, bool, aura::Env*) ui/views/widget/native_widget_aura.cc:109:15 > Igalia#2 0x91d615d in views::internal::NativeWidgetPrivate::CreateNativeWidget(views::Widget::InitParams const&, views::internal::NativeWidgetDelegate*) ui/views/widget/native_widget_aura.cc:1113:14 > Igalia#3 0x917dabd in CreateNativeWidget ui/views/widget/widget.cc:73:10 > Igalia#4 0x917dabd in views::Widget::Init(views::Widget::InitParams const&) ui/views/widget/widget.cc:334 > Igalia#5 0x6af249a in ash::ShelfWidget::ShelfWidget(aura::Window*, ash::Shelf*) ash/shelf/shelf_widget.cc:216:3 > Igalia#6 0x6a96eaa in ash::Shelf::CreateShelfWidget(aura::Window*) ash/shelf/shelf.cc:73:27 > Igalia#7 0x6a5847a in ash::RootWindowController::InitLayoutManagers() ash/root_window_controller.cc:699:11 > Igalia#8 0x6a52166 in ash::RootWindowController::Init(ash::RootWindowController::RootWindowType) ash/root_window_controller.cc:663:3 > Igalia#9 0x68ef135 in ash::WindowTreeHostManager::InitHosts() ash/display/window_tree_host_manager.cc:238:3 > Igalia#10 0x6afadce in ash::Shell::Init(ui::ContextFactory*, ui::ContextFactoryPrivate*, std::__1::unique_ptr<base::Value, std::__1::default_delete<base::Value> >, std::__1::unique_ptr<ui::ws2::GpuInterfaceProvider, std::__1::default_delete<ui::ws2::GpuInterfaceProvider> >) ash/shell.cc:1250:30 > Igalia#11 0x6af7163 in ash::Shell::CreateInstance(ash::ShellInitParams) ash/shell.cc:276:14 > Igalia#12 0xc26ac31 in ash::AshTestHelper::CreateShell() ash/test/ash_test_helper.cc:390:3 > Igalia#13 0xc26a2a0 in ash::AshTestHelper::SetUp(bool, bool) ash/test/ash_test_helper.cc:245:3 > Igalia#14 0xc263f8d in ash::AshTestBase::SetUp() ash/test/ash_test_base.cc:159:21 > Igalia#15 0x1322b16 in ash::ShelfViewTest::SetUp() ash/shelf/shelf_view_unittest.cc:262:18 > Igalia#16 0x1326366 in SetUp ash/shelf/shelf_view_unittest.cc:2369:20 > Igalia#17 0x1326366 in ash::OverflowButtonInkDropTest::SetUp() ash/shelf/shelf_view_unittest.cc:2778 > Igalia#18 0x4722b42 in testing::Test::Run() third_party/googletest/src/googletest/src/gtest.cc > Igalia#19 0x4724c64 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2682:11 > Igalia#20 0x4726036 in testing::TestCase::Run() third_party/googletest/src/googletest/src/gtest.cc:2800:28 > Igalia#21 0x474b566 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5124:43 > Igalia#22 0x474a7b5 in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc > Igalia#23 0x72b431a in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2331:46 > Igalia#24 0x72b431a in base::TestSuite::Run() base/test/test_suite.cc:277 > Igalia#25 0x72b9892 in Run base/callback.h:99:12 > Igalia#26 0x72b9892 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) base/test/launcher/unit_test_launcher.cc:224 > Igalia#27 0x72b9330 in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) base/test/launcher/unit_test_launcher.cc:575:10 > Igalia#28 0x178df94 in main ash/test/ash_unittests.cc:37:10 > Igalia#29 0x7f78e2b62f44 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287 > > SUMMARY: AddressSanitizer: heap-use-after-free buildtools/third_party/libc++/trunk/include/vector:1479:30 in begin > Shadow bytes around the buggy address: > 0x0c267fffe390: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 > 0x0c267fffe3a0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 > 0x0c267fffe3b0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 fa > 0x0c267fffe3c0: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd > 0x0c267fffe3d0: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd > =>0x0c267fffe3e0: fd fd fd fd fd fd fd fd fd fd fd fd fd[fd]fd fd > 0x0c267fffe3f0: fd fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa > 0x0c267fffe400: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd > 0x0c267fffe410: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd > 0x0c267fffe420: fd fd fd fd fd fd fd fd fd fd fd fd fa fa fa fa > 0x0c267fffe430: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd > Shadow byte legend (one shadow byte represents 8 application bytes): > Addressable: 00 > Partially addressable: 01 02 03 04 05 06 07 > Heap left redzone: fa > Freed heap region: fd > Stack left redzone: f1 > Stack mid redzone: f2 > Stack right redzone: f3 > Stack after return: f5 > Stack use after scope: f8 > Global redzone: f9 > Global init order: f6 > Poisoned by user: f7 > Container overflow: fc > Array cookie: ac > Intra object redzone: bb > ASan internal: fe > Left alloca redzone: ca > Right alloca redzone: cb > Shadow gap: cc > ==28149==ABORTING > > Original change's description: > > cros: Enable touchable app context menus by default. > > > > This will enable: > > - New context menu UI for: > > - Application icons > > - Shelf context menus > > - Desktop context menus > > > > Note: > > - Removed tests whose functionality were already being tested. > > - MouseContextMenu already tests whether the ink drop is being > > shown, so there is no need for > > ShelfButtonShowsInkDropHighlightOnMenuShow. > > > > Bug: 871843 > > Change-Id: I4c92ae52f75b25bc9edd1dd67778c4785d8f4058 > > Reviewed-on: https://chromium-review.googlesource.com/1170985 > > Reviewed-by: Scott Violet <sky@chromium.org> > > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > > Commit-Queue: Alex Newcomer <newcomer@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#582978} > > TBR=xiyuan@chromium.org,sky@chromium.org,newcomer@chromium.org > > Change-Id: Ib85676861251f41c84f48f956d36c01edb353266 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 871843 > Reviewed-on: https://chromium-review.googlesource.com/1174641 > Reviewed-by: Chris Mumford <cmumford@chromium.org> > Commit-Queue: Chris Mumford <cmumford@chromium.org> > Cr-Commit-Position: refs/heads/master@{#583088} TBR=xiyuan@chromium.org,sky@chromium.org,cmumford@chromium.org,newcomer@chromium.org Change-Id: I4edeef479d40e1e591ac906aa89ede363668b6a3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 871843 Reviewed-on: https://chromium-review.googlesource.com/1174777 Reviewed-by: Alex Newcomer <newcomer@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#583310}

This reverts commit b58ccf6. Reason for revert: Possibly introduced a use-after-free bug. This is a speculative fix for a use-after-free bug in two ash_unittests: 1. OverflowButtonInkDropTest.MouseContextMenu 2. OverflowButtonActiveInkDropTest.MouseContextMenu [ RUN ] OverflowButtonInkDropTest.MouseContextMenu ================================================================= ==28149==ERROR: AddressSanitizer: heap-use-after-free on address 0x613000031f68 at pc 0x000008c82106 bp 0x7ffea3cd7190 sp 0x7ffea3cd7188 READ of size 8 at 0x613000031f68 thread T0 #0 0x8c82105 in begin buildtools/third_party/libc++/trunk/include/vector:1479:30 Igalia#1 0x8c82105 in begin<std::__1::vector<aura::WindowObserver *, std::__1::allocator<aura::WindowObserver *> > > buildtools/third_party/libc++/trunk/include/iterator:1670 Igalia#2 0x8c82105 in ContainsValue<std::__1::vector<aura::WindowObserver *, std::__1::allocator<aura::WindowObserver *> >, const aura::WindowObserver *, 0> base/stl_util.h:168 Igalia#3 0x8c82105 in HasObserver base/observer_list.h:267 Igalia#4 0x8c82105 in aura::Window::HasObserver(aura::WindowObserver const*) const ui/aura/window.cc:543 Igalia#5 0x8c9d363 in aura::WindowObserver::OnUnobservingWindow(aura::Window*) ui/aura/window_observer.cc:25:15 Igalia#6 0x8c799d7 in aura::Window::RemoveObserver(aura::WindowObserver*) ui/aura/window.cc:538:13 Igalia#7 0xc2f40e in RemoveAll ui/base/window_tracker_template.h:49:15 Igalia#8 0xc2f40e in ui::WindowTrackerTemplate<aura::Window, aura::WindowObserver>::~WindowTrackerTemplate() ui/base/window_tracker_template.h:33 Igalia#9 0x9225f3b in ~CompoundEventFilter ui/wm/core/compound_event_filter.cc:49:1 Igalia#10 0x9225f3b in wm::CompoundEventFilter::~CompoundEventFilter() ui/wm/core/compound_event_filter.cc:45 Igalia#11 0x6b0ae30 in operator() buildtools/third_party/libc++/trunk/include/memory:2321:5 Igalia#12 0x6b0ae30 in reset buildtools/third_party/libc++/trunk/include/memory:2634 Igalia#13 0x6b0ae30 in ~unique_ptr buildtools/third_party/libc++/trunk/include/memory:2588 Igalia#14 0x6b0ae30 in ash::Shell::~Shell() ash/shell.cc:969 Igalia#15 0x6b0c81d in ash::Shell::~Shell() ash/shell.cc:737:17 Igalia#16 0xc26b344 in ash::AshTestHelper::TearDown() ash/test/ash_test_helper.cc:294:3 Igalia#17 0xc26444c in ash::AshTestBase::TearDown() ash/test/ash_test_base.cc:192:21 Igalia#18 0x4724c64 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2682:11 Igalia#19 0x4726036 in testing::TestCase::Run() third_party/googletest/src/googletest/src/gtest.cc:2800:28 Igalia#20 0x474b566 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5124:43 Igalia#21 0x474a7b5 in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc Igalia#22 0x72b431a in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2331:46 Igalia#23 0x72b431a in base::TestSuite::Run() base/test/test_suite.cc:277 Igalia#24 0x72b9892 in Run base/callback.h:99:12 Igalia#25 0x72b9892 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) base/test/launcher/unit_test_launcher.cc:224 Igalia#26 0x72b9330 in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) base/test/launcher/unit_test_launcher.cc:575:10 Igalia#27 0x178df94 in main ash/test/ash_unittests.cc:37:10 Igalia#28 0x7f78e2b62f44 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287 0x613000031f68 is located 296 bytes inside of 328-byte region [0x613000031e40,0x613000031f88) freed by thread T0 here: #0 0x6b9062 in operator delete(void*) /b/swarming/w/ir/kitchen-workdir/src/third_party/llvm/compiler-rt/lib/asan/asan_new_delete.cc:167:3 Igalia#1 0x6a547a0 in ash::RootWindowController::CloseChildWindows() ash/root_window_controller.cc:498:7 Igalia#2 0x6b0c5cf in ash::Shell::CloseAllRootWindowChildWindows() ash/shell.cc:1387:19 Igalia#3 0x6b06637 in ash::Shell::~Shell() ash/shell.cc:837:3 Igalia#4 0x6b0c81d in ash::Shell::~Shell() ash/shell.cc:737:17 Igalia#5 0xc26b344 in ash::AshTestHelper::TearDown() ash/test/ash_test_helper.cc:294:3 Igalia#6 0xc26444c in ash::AshTestBase::TearDown() ash/test/ash_test_base.cc:192:21 Igalia#7 0x4724c64 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2682:11 Igalia#8 0x4726036 in testing::TestCase::Run() third_party/googletest/src/googletest/src/gtest.cc:2800:28 Igalia#9 0x474b566 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5124:43 Igalia#10 0x474a7b5 in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc Igalia#11 0x72b431a in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2331:46 Igalia#12 0x72b431a in base::TestSuite::Run() base/test/test_suite.cc:277 Igalia#13 0x72b9892 in Run base/callback.h:99:12 Igalia#14 0x72b9892 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) base/test/launcher/unit_test_launcher.cc:224 Igalia#15 0x72b9330 in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) base/test/launcher/unit_test_launcher.cc:575:10 Igalia#16 0x178df94 in main ash/test/ash_unittests.cc:37:10 Igalia#17 0x7f78e2b62f44 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287 previously allocated by thread T0 here: #0 0x6b8422 in operator new(unsigned long) /b/swarming/w/ir/kitchen-workdir/src/third_party/llvm/compiler-rt/lib/asan/asan_new_delete.cc:106:3 Igalia#1 0x91cb856 in views::NativeWidgetAura::NativeWidgetAura(views::internal::NativeWidgetDelegate*, bool, aura::Env*) ui/views/widget/native_widget_aura.cc:109:15 Igalia#2 0x91d615d in views::internal::NativeWidgetPrivate::CreateNativeWidget(views::Widget::InitParams const&, views::internal::NativeWidgetDelegate*) ui/views/widget/native_widget_aura.cc:1113:14 Igalia#3 0x917dabd in CreateNativeWidget ui/views/widget/widget.cc:73:10 Igalia#4 0x917dabd in views::Widget::Init(views::Widget::InitParams const&) ui/views/widget/widget.cc:334 Igalia#5 0x6af249a in ash::ShelfWidget::ShelfWidget(aura::Window*, ash::Shelf*) ash/shelf/shelf_widget.cc:216:3 Igalia#6 0x6a96eaa in ash::Shelf::CreateShelfWidget(aura::Window*) ash/shelf/shelf.cc:73:27 Igalia#7 0x6a5847a in ash::RootWindowController::InitLayoutManagers() ash/root_window_controller.cc:699:11 Igalia#8 0x6a52166 in ash::RootWindowController::Init(ash::RootWindowController::RootWindowType) ash/root_window_controller.cc:663:3 Igalia#9 0x68ef135 in ash::WindowTreeHostManager::InitHosts() ash/display/window_tree_host_manager.cc:238:3 Igalia#10 0x6afadce in ash::Shell::Init(ui::ContextFactory*, ui::ContextFactoryPrivate*, std::__1::unique_ptr<base::Value, std::__1::default_delete<base::Value> >, std::__1::unique_ptr<ui::ws2::GpuInterfaceProvider, std::__1::default_delete<ui::ws2::GpuInterfaceProvider> >) ash/shell.cc:1250:30 Igalia#11 0x6af7163 in ash::Shell::CreateInstance(ash::ShellInitParams) ash/shell.cc:276:14 Igalia#12 0xc26ac31 in ash::AshTestHelper::CreateShell() ash/test/ash_test_helper.cc:390:3 Igalia#13 0xc26a2a0 in ash::AshTestHelper::SetUp(bool, bool) ash/test/ash_test_helper.cc:245:3 Igalia#14 0xc263f8d in ash::AshTestBase::SetUp() ash/test/ash_test_base.cc:159:21 Igalia#15 0x1322b16 in ash::ShelfViewTest::SetUp() ash/shelf/shelf_view_unittest.cc:262:18 Igalia#16 0x1326366 in SetUp ash/shelf/shelf_view_unittest.cc:2369:20 Igalia#17 0x1326366 in ash::OverflowButtonInkDropTest::SetUp() ash/shelf/shelf_view_unittest.cc:2778 Igalia#18 0x4722b42 in testing::Test::Run() third_party/googletest/src/googletest/src/gtest.cc Igalia#19 0x4724c64 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2682:11 Igalia#20 0x4726036 in testing::TestCase::Run() third_party/googletest/src/googletest/src/gtest.cc:2800:28 Igalia#21 0x474b566 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5124:43 Igalia#22 0x474a7b5 in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc Igalia#23 0x72b431a in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2331:46 Igalia#24 0x72b431a in base::TestSuite::Run() base/test/test_suite.cc:277 Igalia#25 0x72b9892 in Run base/callback.h:99:12 Igalia#26 0x72b9892 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) base/test/launcher/unit_test_launcher.cc:224 Igalia#27 0x72b9330 in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) base/test/launcher/unit_test_launcher.cc:575:10 Igalia#28 0x178df94 in main ash/test/ash_unittests.cc:37:10 Igalia#29 0x7f78e2b62f44 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287 SUMMARY: AddressSanitizer: heap-use-after-free buildtools/third_party/libc++/trunk/include/vector:1479:30 in begin Shadow bytes around the buggy address: 0x0c267fffe390: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x0c267fffe3a0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x0c267fffe3b0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 fa 0x0c267fffe3c0: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd 0x0c267fffe3d0: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd =>0x0c267fffe3e0: fd fd fd fd fd fd fd fd fd fd fd fd fd[fd]fd fd 0x0c267fffe3f0: fd fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa 0x0c267fffe400: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd 0x0c267fffe410: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd 0x0c267fffe420: fd fd fd fd fd fd fd fd fd fd fd fd fa fa fa fa 0x0c267fffe430: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd Shadow byte legend (one shadow byte represents 8 application bytes): Addressable: 00 Partially addressable: 01 02 03 04 05 06 07 Heap left redzone: fa Freed heap region: fd Stack left redzone: f1 Stack mid redzone: f2 Stack right redzone: f3 Stack after return: f5 Stack use after scope: f8 Global redzone: f9 Global init order: f6 Poisoned by user: f7 Container overflow: fc Array cookie: ac Intra object redzone: bb ASan internal: fe Left alloca redzone: ca Right alloca redzone: cb Shadow gap: cc ==28149==ABORTING Original change's description: > cros: Enable touchable app context menus by default. > > This will enable: > - New context menu UI for: > - Application icons > - Shelf context menus > - Desktop context menus > > Note: > - Removed tests whose functionality were already being tested. > - MouseContextMenu already tests whether the ink drop is being > shown, so there is no need for > ShelfButtonShowsInkDropHighlightOnMenuShow. > > Bug: 871843 > Change-Id: I4c92ae52f75b25bc9edd1dd67778c4785d8f4058 > Reviewed-on: https://chromium-review.googlesource.com/1170985 > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Commit-Queue: Alex Newcomer <newcomer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#582978} TBR=xiyuan@chromium.org,sky@chromium.org,newcomer@chromium.org Change-Id: Ib85676861251f41c84f48f956d36c01edb353266 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 871843 Reviewed-on: https://chromium-review.googlesource.com/1174641 Reviewed-by: Chris Mumford <cmumford@chromium.org> Commit-Queue: Chris Mumford <cmumford@chromium.org> Cr-Commit-Position: refs/heads/master@{#583088}

This reverts commit e2c5501. Reason for revert: Causes ash_unittests regressions. This is NOT a speculative revert, as I've bisected to this commit and reproduced it locally. Please do not reland as is. Failing build: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/28629 Original change's description: > Reland "cros: Enable touchable app context menus by default." > > This reverts commit 32cd8fc. > > Reason for revert: Reverting the revert because this change was proven to not have caused the issue. > > Original change's description: > > Revert "cros: Enable touchable app context menus by default." > > > > This reverts commit b58ccf6. > > > > Reason for revert: Possibly introduced a use-after-free bug. > > > > This is a speculative fix for a use-after-free bug in two ash_unittests: > > > > 1. OverflowButtonInkDropTest.MouseContextMenu > > 2. OverflowButtonActiveInkDropTest.MouseContextMenu > > > > [ RUN ] OverflowButtonInkDropTest.MouseContextMenu > > ================================================================= > > ==28149==ERROR: AddressSanitizer: heap-use-after-free on address 0x613000031f68 at pc 0x000008c82106 bp 0x7ffea3cd7190 sp 0x7ffea3cd7188 > > READ of size 8 at 0x613000031f68 thread T0 > > #0 0x8c82105 in begin buildtools/third_party/libc++/trunk/include/vector:1479:30 > > Igalia#1 0x8c82105 in begin<std::__1::vector<aura::WindowObserver *, std::__1::allocator<aura::WindowObserver *> > > buildtools/third_party/libc++/trunk/include/iterator:1670 > > Igalia#2 0x8c82105 in ContainsValue<std::__1::vector<aura::WindowObserver *, std::__1::allocator<aura::WindowObserver *> >, const aura::WindowObserver *, 0> base/stl_util.h:168 > > Igalia#3 0x8c82105 in HasObserver base/observer_list.h:267 > > Igalia#4 0x8c82105 in aura::Window::HasObserver(aura::WindowObserver const*) const ui/aura/window.cc:543 > > Igalia#5 0x8c9d363 in aura::WindowObserver::OnUnobservingWindow(aura::Window*) ui/aura/window_observer.cc:25:15 > > Igalia#6 0x8c799d7 in aura::Window::RemoveObserver(aura::WindowObserver*) ui/aura/window.cc:538:13 > > Igalia#7 0xc2f40e in RemoveAll ui/base/window_tracker_template.h:49:15 > > Igalia#8 0xc2f40e in ui::WindowTrackerTemplate<aura::Window, aura::WindowObserver>::~WindowTrackerTemplate() ui/base/window_tracker_template.h:33 > > Igalia#9 0x9225f3b in ~CompoundEventFilter ui/wm/core/compound_event_filter.cc:49:1 > > Igalia#10 0x9225f3b in wm::CompoundEventFilter::~CompoundEventFilter() ui/wm/core/compound_event_filter.cc:45 > > Igalia#11 0x6b0ae30 in operator() buildtools/third_party/libc++/trunk/include/memory:2321:5 > > Igalia#12 0x6b0ae30 in reset buildtools/third_party/libc++/trunk/include/memory:2634 > > Igalia#13 0x6b0ae30 in ~unique_ptr buildtools/third_party/libc++/trunk/include/memory:2588 > > Igalia#14 0x6b0ae30 in ash::Shell::~Shell() ash/shell.cc:969 > > Igalia#15 0x6b0c81d in ash::Shell::~Shell() ash/shell.cc:737:17 > > Igalia#16 0xc26b344 in ash::AshTestHelper::TearDown() ash/test/ash_test_helper.cc:294:3 > > Igalia#17 0xc26444c in ash::AshTestBase::TearDown() ash/test/ash_test_base.cc:192:21 > > Igalia#18 0x4724c64 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2682:11 > > Igalia#19 0x4726036 in testing::TestCase::Run() third_party/googletest/src/googletest/src/gtest.cc:2800:28 > > Igalia#20 0x474b566 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5124:43 > > Igalia#21 0x474a7b5 in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc > > Igalia#22 0x72b431a in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2331:46 > > Igalia#23 0x72b431a in base::TestSuite::Run() base/test/test_suite.cc:277 > > Igalia#24 0x72b9892 in Run base/callback.h:99:12 > > Igalia#25 0x72b9892 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) base/test/launcher/unit_test_launcher.cc:224 > > Igalia#26 0x72b9330 in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) base/test/launcher/unit_test_launcher.cc:575:10 > > Igalia#27 0x178df94 in main ash/test/ash_unittests.cc:37:10 > > Igalia#28 0x7f78e2b62f44 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287 > > > > 0x613000031f68 is located 296 bytes inside of 328-byte region [0x613000031e40,0x613000031f88) > > freed by thread T0 here: > > #0 0x6b9062 in operator delete(void*) /b/swarming/w/ir/kitchen-workdir/src/third_party/llvm/compiler-rt/lib/asan/asan_new_delete.cc:167:3 > > Igalia#1 0x6a547a0 in ash::RootWindowController::CloseChildWindows() ash/root_window_controller.cc:498:7 > > Igalia#2 0x6b0c5cf in ash::Shell::CloseAllRootWindowChildWindows() ash/shell.cc:1387:19 > > Igalia#3 0x6b06637 in ash::Shell::~Shell() ash/shell.cc:837:3 > > Igalia#4 0x6b0c81d in ash::Shell::~Shell() ash/shell.cc:737:17 > > Igalia#5 0xc26b344 in ash::AshTestHelper::TearDown() ash/test/ash_test_helper.cc:294:3 > > Igalia#6 0xc26444c in ash::AshTestBase::TearDown() ash/test/ash_test_base.cc:192:21 > > Igalia#7 0x4724c64 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2682:11 > > Igalia#8 0x4726036 in testing::TestCase::Run() third_party/googletest/src/googletest/src/gtest.cc:2800:28 > > Igalia#9 0x474b566 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5124:43 > > Igalia#10 0x474a7b5 in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc > > Igalia#11 0x72b431a in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2331:46 > > Igalia#12 0x72b431a in base::TestSuite::Run() base/test/test_suite.cc:277 > > Igalia#13 0x72b9892 in Run base/callback.h:99:12 > > Igalia#14 0x72b9892 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) base/test/launcher/unit_test_launcher.cc:224 > > Igalia#15 0x72b9330 in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) base/test/launcher/unit_test_launcher.cc:575:10 > > Igalia#16 0x178df94 in main ash/test/ash_unittests.cc:37:10 > > Igalia#17 0x7f78e2b62f44 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287 > > > > previously allocated by thread T0 here: > > #0 0x6b8422 in operator new(unsigned long) /b/swarming/w/ir/kitchen-workdir/src/third_party/llvm/compiler-rt/lib/asan/asan_new_delete.cc:106:3 > > Igalia#1 0x91cb856 in views::NativeWidgetAura::NativeWidgetAura(views::internal::NativeWidgetDelegate*, bool, aura::Env*) ui/views/widget/native_widget_aura.cc:109:15 > > Igalia#2 0x91d615d in views::internal::NativeWidgetPrivate::CreateNativeWidget(views::Widget::InitParams const&, views::internal::NativeWidgetDelegate*) ui/views/widget/native_widget_aura.cc:1113:14 > > Igalia#3 0x917dabd in CreateNativeWidget ui/views/widget/widget.cc:73:10 > > Igalia#4 0x917dabd in views::Widget::Init(views::Widget::InitParams const&) ui/views/widget/widget.cc:334 > > Igalia#5 0x6af249a in ash::ShelfWidget::ShelfWidget(aura::Window*, ash::Shelf*) ash/shelf/shelf_widget.cc:216:3 > > Igalia#6 0x6a96eaa in ash::Shelf::CreateShelfWidget(aura::Window*) ash/shelf/shelf.cc:73:27 > > Igalia#7 0x6a5847a in ash::RootWindowController::InitLayoutManagers() ash/root_window_controller.cc:699:11 > > Igalia#8 0x6a52166 in ash::RootWindowController::Init(ash::RootWindowController::RootWindowType) ash/root_window_controller.cc:663:3 > > Igalia#9 0x68ef135 in ash::WindowTreeHostManager::InitHosts() ash/display/window_tree_host_manager.cc:238:3 > > Igalia#10 0x6afadce in ash::Shell::Init(ui::ContextFactory*, ui::ContextFactoryPrivate*, std::__1::unique_ptr<base::Value, std::__1::default_delete<base::Value> >, std::__1::unique_ptr<ui::ws2::GpuInterfaceProvider, std::__1::default_delete<ui::ws2::GpuInterfaceProvider> >) ash/shell.cc:1250:30 > > Igalia#11 0x6af7163 in ash::Shell::CreateInstance(ash::ShellInitParams) ash/shell.cc:276:14 > > Igalia#12 0xc26ac31 in ash::AshTestHelper::CreateShell() ash/test/ash_test_helper.cc:390:3 > > Igalia#13 0xc26a2a0 in ash::AshTestHelper::SetUp(bool, bool) ash/test/ash_test_helper.cc:245:3 > > Igalia#14 0xc263f8d in ash::AshTestBase::SetUp() ash/test/ash_test_base.cc:159:21 > > Igalia#15 0x1322b16 in ash::ShelfViewTest::SetUp() ash/shelf/shelf_view_unittest.cc:262:18 > > Igalia#16 0x1326366 in SetUp ash/shelf/shelf_view_unittest.cc:2369:20 > > Igalia#17 0x1326366 in ash::OverflowButtonInkDropTest::SetUp() ash/shelf/shelf_view_unittest.cc:2778 > > Igalia#18 0x4722b42 in testing::Test::Run() third_party/googletest/src/googletest/src/gtest.cc > > Igalia#19 0x4724c64 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2682:11 > > Igalia#20 0x4726036 in testing::TestCase::Run() third_party/googletest/src/googletest/src/gtest.cc:2800:28 > > Igalia#21 0x474b566 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5124:43 > > Igalia#22 0x474a7b5 in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc > > Igalia#23 0x72b431a in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2331:46 > > Igalia#24 0x72b431a in base::TestSuite::Run() base/test/test_suite.cc:277 > > Igalia#25 0x72b9892 in Run base/callback.h:99:12 > > Igalia#26 0x72b9892 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) base/test/launcher/unit_test_launcher.cc:224 > > Igalia#27 0x72b9330 in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) base/test/launcher/unit_test_launcher.cc:575:10 > > Igalia#28 0x178df94 in main ash/test/ash_unittests.cc:37:10 > > Igalia#29 0x7f78e2b62f44 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287 > > > > SUMMARY: AddressSanitizer: heap-use-after-free buildtools/third_party/libc++/trunk/include/vector:1479:30 in begin > > Shadow bytes around the buggy address: > > 0x0c267fffe390: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 > > 0x0c267fffe3a0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 > > 0x0c267fffe3b0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 fa > > 0x0c267fffe3c0: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd > > 0x0c267fffe3d0: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd > > =>0x0c267fffe3e0: fd fd fd fd fd fd fd fd fd fd fd fd fd[fd]fd fd > > 0x0c267fffe3f0: fd fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa > > 0x0c267fffe400: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd > > 0x0c267fffe410: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd > > 0x0c267fffe420: fd fd fd fd fd fd fd fd fd fd fd fd fa fa fa fa > > 0x0c267fffe430: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd > > Shadow byte legend (one shadow byte represents 8 application bytes): > > Addressable: 00 > > Partially addressable: 01 02 03 04 05 06 07 > > Heap left redzone: fa > > Freed heap region: fd > > Stack left redzone: f1 > > Stack mid redzone: f2 > > Stack right redzone: f3 > > Stack after return: f5 > > Stack use after scope: f8 > > Global redzone: f9 > > Global init order: f6 > > Poisoned by user: f7 > > Container overflow: fc > > Array cookie: ac > > Intra object redzone: bb > > ASan internal: fe > > Left alloca redzone: ca > > Right alloca redzone: cb > > Shadow gap: cc > > ==28149==ABORTING > > > > Original change's description: > > > cros: Enable touchable app context menus by default. > > > > > > This will enable: > > > - New context menu UI for: > > > - Application icons > > > - Shelf context menus > > > - Desktop context menus > > > > > > Note: > > > - Removed tests whose functionality were already being tested. > > > - MouseContextMenu already tests whether the ink drop is being > > > shown, so there is no need for > > > ShelfButtonShowsInkDropHighlightOnMenuShow. > > > > > > Bug: 871843 > > > Change-Id: I4c92ae52f75b25bc9edd1dd67778c4785d8f4058 > > > Reviewed-on: https://chromium-review.googlesource.com/1170985 > > > Reviewed-by: Scott Violet <sky@chromium.org> > > > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > > > Commit-Queue: Alex Newcomer <newcomer@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#582978} > > > > TBR=xiyuan@chromium.org,sky@chromium.org,newcomer@chromium.org > > > > Change-Id: Ib85676861251f41c84f48f956d36c01edb353266 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 871843 > > Reviewed-on: https://chromium-review.googlesource.com/1174641 > > Reviewed-by: Chris Mumford <cmumford@chromium.org> > > Commit-Queue: Chris Mumford <cmumford@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#583088} > > TBR=xiyuan@chromium.org,sky@chromium.org,cmumford@chromium.org,newcomer@chromium.org > > Change-Id: I4edeef479d40e1e591ac906aa89ede363668b6a3 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 871843 > Reviewed-on: https://chromium-review.googlesource.com/1174777 > Reviewed-by: Alex Newcomer <newcomer@chromium.org> > Commit-Queue: Alex Newcomer <newcomer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#583310} TBR=xiyuan@chromium.org,sky@chromium.org,cmumford@chromium.org,newcomer@chromium.org Change-Id: I8398745c9037fb5be605069646b3a655519d023e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 871843 Reviewed-on: https://chromium-review.googlesource.com/1177482 Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#583619}

…enChanged() When running in single threaded mode, calls from OnBeginImplFrameDeadline() can make their way from the main thread to the impl thread, and then (erroneously) directly back to the main thread, causing a crash. See the stack trace below. With this CL, the call from viz::HostFrameSinkManager::OnFrameTokenChanged() is proxied back to the main thread for the call to content::DelegatedFrameHost::OnFrameTokenChanged(). A number of tests also call FrameSinkManagerImpl::SetLocalClient and/or surface_utils::ConnectWithLocalFrameSinkManager, and I did not want to change their existing behavior. So the additional task_runner parameter is defaulted to nullptr, and in that case the old behavior still applies - the call is not PostTasked. Example crash: [243567:243567:1023/120428.757147:FATAL:single_thread_proxy.cc(239)] Check failed: task_runner_provider_->IsMainThread(). #0 0x7f4d3b3bbccd base::debug::StackTrace::StackTrace() #1 0x7f4d3b0b8a2a base::debug::StackTrace::StackTrace() #2 0x7f4d3b12a59b logging::LogMessage::~LogMessage() #3 0x7f4d315b4e9b cc::SingleThreadProxy::SetNeedsCommit() #4 0x7f4d3149b8ef cc::LayerTreeHost::SetNeedsCommit() #5 0x7f4d312b28f1 cc::Layer::SetNeedsCommit() #6 0x7f4d312b8205 cc::Layer::SetBackgroundColor() #7 0x7f4d2cb5fd54 ui::Layer::SetColorFromAnimation() #8 0x7f4d2cb79024 ui::LayerAnimator::SetColor() #9 0x7f4d2cb56a5c ui::Layer::SetColor() #10 0x7f4d37f1b8a1 content::RenderWidgetHostViewAura::UpdateBackgroundColor() #11 0x7f4d37f2851e content::RenderWidgetHostViewBase::SetContentBackgroundColor() #12 0x7f4d37f222cb content::RenderWidgetHostViewAura::OnRenderFrameMetadataChangedAfterActivation() #13 0x7f4d37e81d5c content::RenderFrameMetadataProviderImpl::OnRenderFrameMetadataChangedAfterActivation() #14 0x7f4d37e8391f _ZN4base8internal13FunctorTraitsIMN7content31RenderFrameMetadataProviderImplEFvN2cc19RenderFrameMetadataEEvE6InvokeIS7_NS_7WeakPtrIS3_EEJS5_EEEvT_OT0_DpOT1_ #15 0x7f4d37e83805 _ZN4base8internal12InvokeHelperILb1EvE8MakeItSoIMN7content31RenderFrameMetadataProviderImplEFvN2cc19RenderFrameMetadataEENS_7WeakPtrIS5_EEJS7_EEEvOT_OT0_DpOT1_ #16 0x7f4d37e8377d _ZN4base8internal7InvokerINS0_9BindStateIMN7content31RenderFrameMetadataProviderImplEFvN2cc19RenderFrameMetadataEEJNS_7WeakPtrIS4_EES6_EEEFvvEE7RunImplIS8_NSt3__15tupleIJSA_S6_EEEJLm0ELm1EEEEvOT_OT0_NSF_16integer_sequenceImJXspT1_EEEE #17 0x7f4d37e836f9 _ZN4base8internal7InvokerINS0_9BindStateIMN7content31RenderFrameMetadataProviderImplEFvN2cc19RenderFrameMetadataEEJNS_7WeakPtrIS4_EES6_EEEFvvEE7RunOnceEPNS0_13BindStateBaseE #18 0x7f4d35ecd92e _ZNO4base12OnceCallbackIFvvEE3RunEv #19 0x7f4d37d2d8a3 content::FrameTokenMessageQueue::DidProcessFrame() #20 0x7f4d37ef17cd content::RenderWidgetHostImpl::DidProcessFrame() #21 0x7f4d37f2aeaa content::RenderWidgetHostViewBase::OnFrameTokenChangedForView() #22 0x7f4d3845b99f content::DelegatedFrameHostClientAura::OnFrameTokenChanged() #23 0x7f4d38483f90 content::DelegatedFrameHost::OnFrameTokenChanged() #24 0x7f4d1aaa7e8c viz::HostFrameSinkManager::OnFrameTokenChanged() #25 0x7f4d1b5b41dc viz::FrameSinkManagerImpl::OnFrameTokenChanged() #26 0x7f4d1b59594e viz::CompositorFrameSinkSupport::OnFrameTokenChanged() #27 0x7f4d1b61ab83 viz::Surface::ActivateFrame() #28 0x7f4d1b61920f viz::Surface::ActivatePendingFrame() #29 0x7f4d1b618f2a viz::Surface::OnSurfaceDependencyAdded() #30 0x7f4d1b62e241 viz::SurfaceDependencyTracker::OnSurfaceDependencyAdded() #31 0x7f4d1b6432ac viz::SurfaceManager::SurfaceDependencyAdded() #32 0x7f4d1b619b7f viz::Surface::UpdateActivationDependencies() #33 0x7f4d1b6194f3 viz::Surface::QueueFrame() #34 0x7f4d1b59a155 viz::CompositorFrameSinkSupport::MaybeSubmitCompositorFrameInternal() #35 0x7f4d1b598206 viz::CompositorFrameSinkSupport::MaybeSubmitCompositorFrame() #36 0x7f4d1b59801a viz::CompositorFrameSinkSupport::SubmitCompositorFrame() #37 0x7f4d1b5a4b08 viz::DirectLayerTreeFrameSink::SubmitCompositorFrame() #38 0x7f4d314d8e24 cc::LayerTreeHostImpl::DrawLayers() #39 0x7f4d315b8ee8 cc::SingleThreadProxy::DoComposite() #40 0x7f4d315bb087 cc::SingleThreadProxy::ScheduledActionDrawIfPossible() #41 0x7f4d3139c9b8 cc::Scheduler::DrawIfPossible() #42 0x7f4d31396581 cc::Scheduler::ProcessScheduledActions() #43 0x7f4d3139c7da cc::Scheduler::OnBeginImplFrameDeadline() #44 0x7f4d313a024d _ZN4base8internal13FunctorTraitsIMN2cc9SchedulerEFvvEvE6InvokeIS5_PS3_JEEEvT_OT0_DpOT1_ #45 0x7f4d313a0194 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIMN2cc9SchedulerEFvvEJPS5_EEEvOT_DpOT0_ #46 0x7f4d313a0145 _ZN4base8internal7InvokerINS0_9BindStateIMN2cc9SchedulerEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE7RunImplIS6_NSt3__15tupleIJS8_EEEJLm0EEEEvOT_OT0_NSD_16integer_sequenceImJXspT1_EEEE #47 0x7f4d313a0089 _ZN4base8internal7InvokerINS0_9BindStateIMN2cc9SchedulerEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE7RunOnceEPNS0_13BindStateBaseE #48 0x7f4d313a059e _ZNO4base12OnceCallbackIFvvEE3RunEv #49 0x7f4d313a0544 _ZN4base8internal22CancelableCallbackImplINS_12OnceCallbackIFvvEEEE11ForwardOnceIJEEEvDpT_ #50 0x7f4d3129de9f _ZN4base8internal13FunctorTraitsIMN2cc28ScrollbarAnimationControllerEFvvEvE6InvokeIS5_RKNS_7WeakPtrIS3_EEJEEEvT_OT0_DpOT1_ #51 0x7f4d3129de1a _ZN4base8internal12InvokeHelperILb1EvE8MakeItSoIRKMN2cc28ScrollbarAnimationControllerEFvvERKNS_7WeakPtrIS5_EEJEEEvOT_OT0_DpOT1_ #52 0x7f4d3129ddb0 _ZN4base8internal7InvokerINS0_9BindStateIMN2cc28ScrollbarAnimationControllerEFvvEJNS_7WeakPtrIS4_EEEEEFvvEE7RunImplIRKS6_RKNSt3__15tupleIJS8_EEEJLm0EEEEvOT_OT0_NSF_16integer_sequenceImJXspT1_EEEE #53 0x7f4d3137d0d9 _ZN4base8internal7InvokerINS0_9BindStateIMN2cc12ResourcePoolEFvvEJNS_7WeakPtrIS4_EEEEEFvvEE7RunOnceEPNS0_13BindStateBaseE #54 0x7f4d3b0683ee _ZNO4base12OnceCallbackIFvvEE3RunEv #55 0x7f4d3b0ba072 base::debug::TaskAnnotator::RunTask() #56 0x7f4d3b14f466 base::MessageLoop::RunTask() #57 0x7f4d3b14f7ee base::MessageLoop::DeferOrRunPendingTask() #58 0x7f4d3b14fc79 base::MessageLoop::DoWork() #59 0x7f4d3b1572b6 base::MessagePumpGlib::Run() #60 0x7f4d3b14eb5b base::MessageLoop::Run() #61 0x7f4d3b1fac6d base::RunLoop::Run() #62 0x7f4d372f8dfc content::BrowserMainLoop::MainMessageLoopRun() #63 0x7f4d372f8a52 content::BrowserMainLoop::RunMainMessageLoopParts() #64 0x7f4d37301050 content::BrowserMainRunnerImpl::Run() #65 0x0000018caad1 (anonymous namespace)::RunOneTest() #66 0x0000018ca696 (anonymous namespace)::RunTests() #67 0x0000018ca11d LayoutTestBrowserMain() #68 0x0000018c82c0 content::ShellMainDelegate::RunProcess() #69 0x7f4d39305d5a content::RunBrowserProcessMain() #70 0x7f4d39308bc7 content::ContentMainRunnerImpl::Run() #71 0x7f4d392feabc content::ContentServiceManagerMainDelegate::RunEmbedderProcess() #72 0x7f4d13359c2a service_manager::Main() #73 0x7f4d393034b3 content::ContentMain() #74 0x00000075e165 main #75 0x7f4d13dcd2b1 __libc_start_main #76 0x00000075e02a _start Bug: 667551 Change-Id: Iab72ad842b4672f7c3e37060bd2085b2d8ce0803 Reviewed-on: https://chromium-review.googlesource.com/c/1297477 Reviewed-by: Charlie Reis <creis@chromium.org> Reviewed-by: enne <enne@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#602912}

… file" This reverts commit aa21b3f. Reason for revert: Suspect of introducing consistent failure on Mac ASAN 64 tests. First failed run: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac%20ASan%2064%20Tests%20%281%29/46988 Sample logs: unit_tests Run on OS: 'Mac-10.13' Shard duration: 0:07:56.378119 failures: FileAnalyzerTest.ArchivedArchiveSetForZipNoArchive FileAnalyzerTest.ArchivedExecutableFalseForZipNoExecutable DownloadProtectionServiceTest.CheckClientDownloadZip SandboxedZipAnalyzerTest.ZippedAppWithUnsignedAndSignedExecutable SandboxedZipAnalyzerTest.NoBinaries FileAnalyzerTest.ArchivedBinariesSkipsSafeFiles ==34531==ERROR: AddressSanitizer: stack-buffer-overflow on address 0x700015467c14 at pc 0x00013e99c44d bp 0x700015467950 sp 0x7000154670f8 READ of size 5 at 0x700015467c14 thread T16 #0 0x13e99c44c in __asan_after_dynamic_init ??:0:0 #1 0x10e3ac931 in safe_browsing::UpdateArchiveAnalyzerResultsWithFile(base::FilePath, base::File*, bool, safe_browsing::ArchiveAnalyzerResults*) ??:0:0 #2 0x10e3a6707 in safe_browsing::zip_analyzer::AnalyzeZipFile(base::File, base::File, safe_browsing::ArchiveAnalyzerResults*) ??:0:0 #3 0x115236586 in SafeArchiveAnalyzer::AnalyzeZipFile(base::File, base::File, base::OnceCallback<void (safe_browsing::ArchiveAnalyzerResults const&)>) ??:0:0 #4 0x10bc0b332 in chrome::mojom::SafeArchiveAnalyzerStubDispatch::AcceptWithResponder(chrome::mojom::SafeArchiveAnalyzer*, mojo::Message*, std::__1::unique_ptr<mojo::MessageReceiverWithStatus, std::__1::default_delete<mojo::MessageReceiverWithStatus> >) ??:0:0 #5 0x115234a40 in chrome::mojom::SafeArchiveAnalyzerStub<mojo::RawPtrImplRefTraits<chrome::mojom::SafeArchiveAnalyzer> >::AcceptWithResponder(mojo::Message*, std::__1::unique_ptr<mojo::MessageReceiverWithStatus, std::__1::default_delete<mojo::MessageReceiverWithStatus> >) ??:0:0 #6 0x1165eeb32 in mojo::InterfaceEndpointClient::HandleValidatedMessage(mojo::Message*) ??:0:0 #7 0x1165ed1e0 in mojo::FilterChain::Accept(mojo::Message*) ??:0:0 #8 0x1165f278b in mojo::InterfaceEndpointClient::HandleIncomingMessage(mojo::Message*) ??:0:0 #9 0x116605686 in mojo::internal::MultiplexRouter::ProcessIncomingMessage(mojo::internal::MultiplexRouter::MessageWrapper*, mojo::internal::MultiplexRouter::ClientCallBehavior, base::SequencedTaskRunner*) ??:0:0 #10 0x11660372b in mojo::internal::MultiplexRouter::Accept(mojo::Message*) ??:0:0 #11 0x1165ed1e0 in mojo::FilterChain::Accept(mojo::Message*) ??:0:0 #12 0x1165dcea8 in mojo::Connector::ReadSingleMessage(unsigned int*) ??:0:0 #13 0x1165df32a in mojo::Connector::ReadAllAvailableMessages() ??:0:0 #14 0x1165deda1 in mojo::Connector::OnHandleReadyInternal(unsigned int) ??:0:0 #15 0x10d429d44 in mojo::SimpleWatcher::DiscardReadyState(base::RepeatingCallback<void (unsigned int)> const&, unsigned int, mojo::HandleSignalsState const&) ??:0:0 #16 0x11a802cf5 in mojo::SimpleWatcher::OnHandleReady(int, unsigned int, mojo::HandleSignalsState const&) ??:0:0 #17 0x11a803cbd in void base::internal::Invoker<base::internal::BindState<void (mojo::SimpleWatcher::*)(int, unsigned int, mojo::HandleSignalsState const&), base::WeakPtr<mojo::SimpleWatcher>, int, unsigned int, mojo::HandleSignalsState>, void ()>::RunImpl<void (mojo::SimpleWatcher::* const&)(int, unsigned int, mojo::HandleSignalsState const&), std::__1::tuple<base::WeakPtr<mojo::SimpleWatcher>, int, unsigned int, mojo::HandleSignalsState> const&, 0ul, 1ul, 2ul, 3ul>(void (mojo::SimpleWatcher::* const&)(int, unsigned int, mojo::HandleSignalsState const&), std::__1::tuple<base::WeakPtr<mojo::SimpleWatcher>, int, unsigned int, mojo::HandleSignalsState> const&, std::__1::integer_sequence<unsigned long, 0ul, 1ul, 2ul, 3ul>) ??:0:0 #18 0x11890131c in base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) ??:0:0 #19 0x118995271 in base::MessageLoopImpl::RunTask(base::PendingTask*) ??:0:0 #20 0x11899691f in base::MessageLoopImpl::DoWork() ??:0:0 #21 0x118999eb3 in base::MessagePumpDefault::Run(base::MessagePump::Delegate*) ??:0:0 #22 0x118994259 in base::MessageLoopImpl::Run(bool) ??:0:0 #23 0x118a49a1c in base::RunLoop::Run() ??:0:0 #24 0x118b962e2 in base::Thread::Run(base::RunLoop*) ??:0:0 #25 0x118b96e9d in base::Thread::ThreadMain() ??:0:0 #26 0x118c72a0d in base::(anonymous namespace)::ThreadFunc(void*) ??:0:0 #27 0x7fff74564660 in _pthread_body ??:0:0 #28 0x7fff7456450c in _pthread_start ??:0:0 Original change's description: > Add util method to update ArchiveAnalyzerResults for a single file > > This CL breaks out the code that inspects an individual file within a > ZIP archive. This will be shared between the ZIP and RAR inspection, > when RAR files begin doing content inspection. > > Bug: 909778 > Change-Id: I7acf1cabd472f112f2ed7c31735688cae7a6d122 > Reviewed-on: https://chromium-review.googlesource.com/c/1354103 > Commit-Queue: Daniel Rubery <drubery@chromium.org> > Reviewed-by: Brian White <bcwhite@chromium.org> > Reviewed-by: Jay Civelli <jcivelli@chromium.org> > Reviewed-by: Varun Khaneja <vakh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#612799} TBR=jcivelli@chromium.org,bcwhite@chromium.org,vakh@chromium.org,drubery@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 909778 Change-Id: I92e193707da4a28cee94aa1277a6ca567650760f Reviewed-on: https://chromium-review.googlesource.com/c/1358491 Reviewed-by: Guido Urdaneta <guidou@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#613073}

This reverts commit 3bb44fe. Reason for revert: Suspect of introducing consistent failure on Linux Chromium OS ASan LSan Tests (1) bot. First failure: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/30399 Sample logs: views_mus_unittests Run on OS: 'Ubuntu-14.04' Shard duration: 0:01:41.022687 failures: AXTreeSourceViewsRootTest.Serialize AXTreeSourceViewsRootTest.Focus AXTreeSourceViewsRootTest.Accessors AXTreeSourceViewsRootTest.SerializeWindowSetsClipsChildren AXTreeSourceViewsRootTest.DoDefault ==7985==ERROR: LeakSanitizer: detected memory leaks Direct leak of 56 byte(s) in 1 object(s) allocated from: #0 0x55ec150a7ed2 in operator new(unsigned long) /b/swarming/w/ir/kitchen-workdir/src/third_party/llvm/compiler-rt/lib/asan/asan_new_delete.cc:106:3 #1 0x55ec158f3f9e in ui::AXTreeSerializer<views::AXAuraObjWrapper*, ui::AXNodeData, ui::AXTreeData>::SerializeChangedNodes(views::AXAuraObjWrapper*, ui::AXTreeUpdateBase<ui::AXNodeData, ui::AXTreeData>*) ui/accessibility/ax_tree_serializer.h:598:35 #2 0x55ec158f41c2 in ui::AXTreeSerializer<views::AXAuraObjWrapper*, ui::AXNodeData, ui::AXTreeData>::SerializeChangedNodes(views::AXAuraObjWrapper*, ui::AXTreeUpdateBase<ui::AXNodeData, ui::AXTreeData>*) ui/accessibility/ax_tree_serializer.h:604:12 #3 0x55ec158f41c2 in ui::AXTreeSerializer<views::AXAuraObjWrapper*, ui::AXNodeData, ui::AXTreeData>::SerializeChangedNodes(views::AXAuraObjWrapper*, ui::AXTreeUpdateBase<ui::AXNodeData, ui::AXTreeData>*) ui/accessibility/ax_tree_serializer.h:604:12 #4 0x55ec158f09de in ui::AXTreeSerializer<views::AXAuraObjWrapper*, ui::AXNodeData, ui::AXTreeData>::SerializeChanges(views::AXAuraObjWrapper*, ui::AXTreeUpdateBase<ui::AXNodeData, ui::AXTreeData>*) ui/accessibility/ax_tree_serializer.h:422:8 #5 0x55ec158ee9d9 in views::(anonymous namespace)::AXTreeSourceViewsRootTest_Serialize_Test::TestBody() ui/views/accessibility/ax_tree_source_views_unittest.cc:318:17 #6 0x55ec17bdd342 in HandleExceptionsInMethodIfSupported<testing::Test, void> third_party/googletest/src/googletest/src/gtest.cc #7 0x55ec17bdd342 in testing::Test::Run() third_party/googletest/src/googletest/src/gtest.cc:2522 #8 0x55ec17bdf428 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2703:11 #9 0x55ec17be08e6 in testing::TestCase::Run() third_party/googletest/src/googletest/src/gtest.cc:2825:28 #10 0x55ec17c08f46 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5227:43 #11 0x55ec17c082c5 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> third_party/googletest/src/googletest/src/gtest.cc #12 0x55ec17c082c5 in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc:4835 #13 0x55ec180eb7da in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2369:46 #14 0x55ec180eb7da in base::TestSuite::Run() base/test/test_suite.cc:294 #15 0x55ec180f1a34 in Run base/callback.h:99:12 #16 0x55ec180f1a34 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) base/test/launcher/unit_test_launcher.cc:225 #17 0x55ec180f1500 in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) base/test/launcher/unit_test_launcher.cc:575:10 #18 0x55ec15220e7e in views::ViewsTestSuite::RunTests() ui/views/views_test_suite.cc:33:10 #19 0x55ec150f46a3 in main ui/views/mus/run_all_unittests_mus.cc:8:47 #20 0x7fd6ce976f44 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21f44) Indirect leak of 8 byte(s) in 1 object(s) allocated from: #0 0x55ec150a7ed2 in operator new(unsigned long) /b/swarming/w/ir/kitchen-workdir/src/third_party/llvm/compiler-rt/lib/asan/asan_new_delete.cc:106:3 #1 0x55ec158f6f15 in __libcpp_allocate buildtools/third_party/libc++/trunk/include/new:254:10 #2 0x55ec158f6f15 in allocate buildtools/third_party/libc++/trunk/include/memory:1800 #3 0x55ec158f6f15 in allocate buildtools/third_party/libc++/trunk/include/memory:1549 #4 0x55ec158f6f15 in __split_buffer buildtools/third_party/libc++/trunk/include/__split_buffer:311 #5 0x55ec158f6f15 in std::__1::vector<ui::ClientTreeNode*, std::__1::allocator<ui::ClientTreeNode*> >::reserve(unsigned long) buildtools/third_party/libc++/trunk/include/vector:1576 #6 0x55ec158f3a1b in ui::AXTreeSerializer<views::AXAuraObjWrapper*, ui::AXNodeData, ui::AXTreeData>::SerializeChangedNodes(views::AXAuraObjWrapper*, ui::AXTreeUpdateBase<ui::AXNodeData, ui::AXTreeData>*) ui/accessibility/ax_tree_serializer.h:573:25 #7 0x55ec158f41c2 in ui::AXTreeSerializer<views::AXAuraObjWrapper*, ui::AXNodeData, ui::AXTreeData>::SerializeChangedNodes(views::AXAuraObjWrapper*, ui::AXTreeUpdateBase<ui::AXNodeData, ui::AXTreeData>*) ui/accessibility/ax_tree_serializer.h:604:12 #8 0x55ec158f41c2 in ui::AXTreeSerializer<views::AXAuraObjWrapper*, ui::AXNodeData, ui::AXTreeData>::SerializeChangedNodes(views::AXAuraObjWrapper*, ui::AXTreeUpdateBase<ui::AXNodeData, ui::AXTreeData>*) ui/accessibility/ax_tree_serializer.h:604:12 #9 0x55ec158f41c2 in ui::AXTreeSerializer<views::AXAuraObjWrapper*, ui::AXNodeData, ui::AXTreeData>::SerializeChangedNodes(views::AXAuraObjWrapper*, ui::AXTreeUpdateBase<ui::AXNodeData, ui::AXTreeData>*) ui/accessibility/ax_tree_serializer.h:604:12 #10 0x55ec158f09de in ui::AXTreeSerializer<views::AXAuraObjWrapper*, ui::AXNodeData, ui::AXTreeData>::SerializeChanges(views::AXAuraObjWrapper*, ui::AXTreeUpdateBase<ui::AXNodeData, ui::AXTreeData>*) ui/accessibility/ax_tree_serializer.h:422:8 #11 0x55ec158ee9d9 in views::(anonymous namespace)::AXTreeSourceViewsRootTest_Serialize_Test::TestBody() ui/views/accessibility/ax_tree_source_views_unittest.cc:318:17 #12 0x55ec17bdd342 in HandleExceptionsInMethodIfSupported<testing::Test, void> third_party/googletest/src/googletest/src/gtest.cc #13 0x55ec17bdd342 in testing::Test::Run() third_party/googletest/src/googletest/src/gtest.cc:2522 #14 0x55ec17bdf428 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2703:11 #15 0x55ec17be08e6 in testing::TestCase::Run() third_party/googletest/src/googletest/src/gtest.cc:2825:28 #16 0x55ec17c08f46 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5227:43 #17 0x55ec17c082c5 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> third_party/googletest/src/googletest/src/gtest.cc #18 0x55ec17c082c5 in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc:4835 #19 0x55ec180eb7da in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2369:46 #20 0x55ec180eb7da in base::TestSuite::Run() base/test/test_suite.cc:294 #21 0x55ec180f1a34 in Run base/callback.h:99:12 #22 0x55ec180f1a34 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) base/test/launcher/unit_test_launcher.cc:225 #23 0x55ec180f1500 in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) base/test/launcher/unit_test_launcher.cc:575:10 #24 0x55ec15220e7e in views::ViewsTestSuite::RunTests() ui/views/views_test_suite.cc:33:10 #25 0x55ec150f46a3 in main ui/views/mus/run_all_unittests_mus.cc:8:47 #26 0x7fd6ce976f44 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21f44) Original change's description: > Move AXTreeSourceAura tests into AXTreeSourceViews tests > > AXTreeSourceAura doesn't exist any more. The tests exercise the > integration of AXRootObjWrapper with AXTreeSourceViews, so rename the > tests ot AXTreeSourceViewsRootTest. > > Note that the tests lived in //chrome/browser/ui/ash. If we need an > ash-specific tree source we could introduce an AXTreeSourceAsh either > in //ash (for mash) or //chrome/browser/ui/ash (for SingleProcessMash). > > Bug: 910672 > Test: views_unittests > Change-Id: I79438345e3ad9bd1aa69d74b3c34cc35efe87142 > Reviewed-on: https://chromium-review.googlesource.com/c/1358972 > Reviewed-by: David Tseng <dtseng@chromium.org> > Commit-Queue: James Cook <jamescook@chromium.org> > Cr-Commit-Position: refs/heads/master@{#613308} TBR=jamescook@chromium.org,dtseng@chromium.org Change-Id: If77dfe8f468d8f5e8514e2dbe57c9aff3cbf5a3e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 910672 Reviewed-on: https://chromium-review.googlesource.com/c/1360591 Reviewed-by: Guido Urdaneta <guidou@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#613487}

Data race happens between SetBehindCaptivePortal on BrowserThread::IO and CaptivePortalBrowserTest::OnIntercept line 981 on main thread Change-Id: I58163d96f66f8ca3b2d257d1481b0d12f980c679 ThreadSanitizer Report WARNING: ThreadSanitizer: data race (pid=37545) Read of size 1 at 0x7b44000004d8 by main thread: #0 CaptivePortalBrowserTest::OnIntercept(content::URLLoaderInterceptor::RequestParams*) /src/chrome/browser/captive_portal/captive_portal_browsertest.cc:984:9 (browser_tests+0x4ea3f84) #1 Invoke<bool (CaptivePortalBrowserTest::*)(content::URLLoaderInterceptor::RequestParams *), CaptivePortalBrowserTest *, content::URLLoaderInterceptor::RequestParams *> /src/base/bind_internal.h:507:12 (browser_tests+0x4ed3a2f) #2 MakeItSo<bool (CaptivePortalBrowserTest::*const &)(content::URLLoaderInterceptor::RequestParams *), CaptivePortalBrowserTest *, content::URLLoaderInterceptor::RequestParams *> /src/base/bind_internal.h:607 (browser_tests+0x4ed3a2f) #3 RunImpl<bool (CaptivePortalBrowserTest::*const &)(content::URLLoaderInterceptor::RequestParams *), const std::__1::tuple<base::internal::UnretainedWrapper<CaptivePortalBrowserTest> > &, 0> /src/base/bind_internal.h:680 (browser_tests+0x4ed3a2f) #4 base::internal::Invoker<base::internal::BindState<bool (CaptivePortalBrowserTest::*)(content::URLLoaderInterceptor::RequestParams*), base::internal::UnretainedWrapper<CaptivePortalBrowserTest> >, bool (content::URLLoaderInterceptor::RequestParams*)>::Run(base::internal::BindStateBase*, content::URLLoaderInterceptor::RequestParams*) /src/base/bind_internal.h:662 (browser_tests+0x4ed3a2f) #5 Run /src/base/callback.h:129:12 (browser_tests+0xa8cbbcc) #6 content::URLLoaderInterceptor::Intercept(content::URLLoaderInterceptor::RequestParams*) /src/content/public/test/url_loader_interceptor.cc:377 (browser_tests+0xa8cbbcc) #7 content::URLLoaderInterceptor::Interceptor::CreateLoaderAndStart(mojo::InterfaceRequest<network::mojom::URLLoader>, int, int, unsigned int, network::ResourceRequest const&, mojo::InterfacePtr<network::mojom::URLLoaderClient>, net::MutableNetworkTrafficAnnotationTag const&) /src/content/public/test/url_loader_interceptor.cc:92:18 (browser_tests+0xa8cd294) #8 network::mojom::URLLoaderFactoryProxy_CreateLoaderAndStart_Message::Dispatch(network::mojom::URLLoaderFactory*) /src/out/Default/gen/services/network/public/mojom/url_loader_factory.mojom.cc:145:11 (browser_tests+0x581c781) #9 network::mojom::URLLoaderFactoryStubDispatch::Accept(network::mojom::URLLoaderFactory*, mojo::Message*) /src/out/Default/gen/services/network/public/mojom/url_loader_factory.mojom.cc:353:20 (browser_tests+0x581c626) #10 network::mojom::URLLoaderFactoryStub<mojo::RawPtrImplRefTraits<network::mojom::URLLoaderFactory> >::Accept(mojo::Message*) /src/out/Default/gen/services/network/public/mojom/url_loader_factory.mojom.h:155:12 (browser_tests+0x69ccb3f) #11 mojo::InterfaceEndpointClient::HandleValidatedMessage(mojo::Message*) /src/mojo/public/cpp/bindings/lib/interface_endpoint_client.cc:423:32 (browser_tests+0xb97e563) #12 mojo::InterfaceEndpointClient::HandleIncomingMessageThunk::Accept(mojo::Message*) /src/mojo/public/cpp/bindings/lib/interface_endpoint_client.cc:133:18 (browser_tests+0xb97df6a) #13 mojo::FilterChain::Accept(mojo::Message*) /src/mojo/public/cpp/bindings/lib/filter_chain.cc:40:17 (browser_tests+0xb9823ba) #14 mojo::InterfaceEndpointClient::HandleIncomingMessage(mojo::Message*) /src/mojo/public/cpp/bindings/lib/interface_endpoint_client.cc:306:19 (browser_tests+0xb9801ba) #15 mojo::internal::MultiplexRouter::ProcessIncomingMessage(mojo::internal::MultiplexRouter::MessageWrapper*, mojo::internal::MultiplexRouter::ClientCallBehavior, base::SequencedTaskRunner*) /src/mojo/public/cpp/bindings/lib/multiplex_router.cc:869:42 (browser_tests+0xb98ba4b) #16 mojo::internal::MultiplexRouter::Accept(mojo::Message*) /src/mojo/public/cpp/bindings/lib/multiplex_router.cc:590:38 (browser_tests+0xb98a86a) #17 mojo::FilterChain::Accept(mojo::Message*) /src/mojo/public/cpp/bindings/lib/filter_chain.cc:40:17 (browser_tests+0xb9823ba) #18 mojo::Connector::ReadSingleMessage(unsigned int*) /src/mojo/public/cpp/bindings/lib/connector.cc:457:51 (browser_tests+0xb97a2be) #19 mojo::Connector::ReadAllAvailableMessages() /src/mojo/public/cpp/bindings/lib/connector.cc:486:10 (browser_tests+0xb97b0e7) #20 mojo::Connector::OnHandleReadyInternal(unsigned int) /src/mojo/public/cpp/bindings/lib/connector.cc:387:3 (browser_tests+0xb97ae8e) #21 mojo::Connector::OnWatcherHandleReady(unsigned int) /src/mojo/public/cpp/bindings/lib/connector.cc:364:3 (browser_tests+0xb97ade0) #22 Invoke<void (mojo::Connector::*)(unsigned int), mojo::Connector *, unsigned int> /src/base/bind_internal.h:507:12 (browser_tests+0xb97bbcf) #23 MakeItSo<void (mojo::Connector::*const &)(unsigned int), mojo::Connector *, unsigned int> /src/base/bind_internal.h:607 (browser_tests+0xb97bbcf) #24 RunImpl<void (mojo::Connector::*const &)(unsigned int), const std::__1::tuple<base::internal::UnretainedWrapper<mojo::Connector> > &, 0> /src/base/bind_internal.h:680 (browser_tests+0xb97bbcf) #25 base::internal::Invoker<base::internal::BindState<void (mojo::Connector::*)(unsigned int), base::internal::UnretainedWrapper<mojo::Connector> >, void (unsigned int)>::Run(base::internal::BindStateBase*, unsigned int) /src/base/bind_internal.h:662 (browser_tests+0xb97bbcf) #26 Run /src/base/callback.h:129:12 (browser_tests+0x66996b8) #27 mojo::SimpleWatcher::DiscardReadyState(base::RepeatingCallback<void (unsigned int)> const&, unsigned int, mojo::HandleSignalsState const&) /src/mojo/public/cpp/system/simple_watcher.h:194 (browser_tests+0x66996b8) #28 Invoke<void (*const &)(const base::RepeatingCallback<void (unsigned int)> &, unsigned int, const mojo::HandleSignalsState &), const base::RepeatingCallback<void (unsigned int)> &, unsigned int, const mojo::HandleSignalsState &> /src/base/bind_internal.h:407:12 (browser_tests+0x6699715) #29 MakeItSo<void (*const &)(const base::RepeatingCallback<void (unsigned int)> &, unsigned int, const mojo::HandleSignalsState &), const base::RepeatingCallback<void (unsigned int)> &, unsigned int, const mojo::HandleSignalsState &> /src/base/bind_internal.h:607 (browser_tests+0x6699715) #30 RunImpl<void (*const &)(const base::RepeatingCallback<void (unsigned int)> &, unsigned int, const mojo::HandleSignalsState &), const std::__1::tuple<base::RepeatingCallback<void (unsigned int)> > &, 0> /src/base/bind_internal.h:680 (browser_tests+0x6699715) #31 base::internal::Invoker<base::internal::BindState<void (*)(base::RepeatingCallback<void (unsigned int)> const&, unsigned int, mojo::HandleSignalsState const&), base::RepeatingCallback<void (unsigned int)> >, void (unsigned int, mojo::HandleSignalsState const&)>::Run(base::internal::BindStateBase*, unsigned int, mojo::HandleSignalsState const&) /src/base/bind_internal.h:662 (browser_tests+0x6699715) #32 Run /src/base/callback.h:129:12 (browser_tests+0xa96dece) #33 mojo::SimpleWatcher::OnHandleReady(int, unsigned int, mojo::HandleSignalsState const&) /src/mojo/public/cpp/system/simple_watcher.cc:273 (browser_tests+0xa96dece) #34 Invoke<void (mojo::SimpleWatcher::*)(int, unsigned int, const mojo::HandleSignalsState &), const base::WeakPtr<mojo::SimpleWatcher> &, const int &, const unsigned int &, const mojo::HandleSignalsState &> /src/base/bind_internal.h:507:12 (browser_tests+0xa96e625) #35 MakeItSo<void (mojo::SimpleWatcher::*const &)(int, unsigned int, const mojo::HandleSignalsState &), const base::WeakPtr<mojo::SimpleWatcher> &, const int &, const unsigned int &, const mojo::HandleSignalsState &> /src/base/bind_internal.h:627 (browser_tests+0xa96e625) #36 void base::internal::Invoker<base::internal::BindState<void (mojo::SimpleWatcher::*)(int, unsigned int, mojo::HandleSignalsState const&), base::WeakPtr<mojo::SimpleWatcher>, int, unsigned int, mojo::HandleSignalsState>, void ()>::RunImpl<void (mojo::SimpleWatcher::* const&)(int, unsigned int, mojo::HandleSignalsState const&), std::__1::tuple<base::WeakPtr<mojo::SimpleWatcher>, int, unsigned int, mojo::HandleSignalsState> const&, 0ul, 1ul, 2ul, 3ul>(void (mojo::SimpleWatcher::* const&&&)(int, unsigned int, mojo::HandleSignalsState const&), std::__1::tuple<base::WeakPtr<mojo::SimpleWatcher>, int, unsigned int, mojo::HandleSignalsState> const&&&, std::__1::integer_sequence<unsigned long, 0ul, 1ul, 2ul, 3ul>) /src/base/bind_internal.h:680 (browser_tests+0xa96e625) #37 base::internal::Invoker<base::internal::BindState<void (mojo::SimpleWatcher::*)(int, unsigned int, mojo::HandleSignalsState const&), base::WeakPtr<mojo::SimpleWatcher>, int, unsigned int, mojo::HandleSignalsState>, void ()>::Run(base::internal::BindStateBase*) /src/base/bind_internal.h:662:12 (browser_tests+0xa96e4ce) #38 Run /src/base/callback.h:99:12 (browser_tests+0x9a92ee8) #39 base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) /src/base/debug/task_annotator.cc:101 (browser_tests+0x9a92ee8) #40 base::MessageLoop::RunTask(base::PendingTask*) /src/base/message_loop/message_loop.cc:432:46 (browser_tests+0x55f355a) #41 base::MessageLoop::DeferOrRunPendingTask(base::PendingTask) /src/base/message_loop/message_loop.cc:443:5 (browser_tests+0x55f3e7c) #42 base::MessageLoop::DoWork() /src/base/message_loop/message_loop.cc:487:16 (browser_tests+0x55f41c5) #43 base::MessagePumpGlib::Run(base::MessagePump::Delegate*) /src/base/message_loop/message_pump_glib.cc:309:49 (browser_tests+0x9ad27bb) #44 base::MessageLoop::Run(bool) /src/base/message_loop/message_loop.cc:374:12 (browser_tests+0x55f2c67) #45 non-virtual thunk to base::MessageLoop::Run(bool) /src/base/message_loop/message_loop.cc (browser_tests+0x55f2d54) #46 base::RunLoop::Run() /src/base/run_loop.cc:102:14 (browser_tests+0x55f6adf) #47 RunThisRunLoop /src/content/public/test/test_utils.cc:132:13 (browser_tests+0xa8c5bf8) #48 content::RunMessageLoop() /src/content/public/test/test_utils.cc:127 (browser_tests+0xa8c5bf8) #49 (anonymous namespace)::CaptivePortalObserver::WaitForResults(int) /src/chrome/browser/captive_portal/captive_portal_browsertest.cc:432:5 (browser_tests+0x4ea7325) #50 CaptivePortalBrowserTest_ShowCaptivePortalInterstitialOnCertError_Test::RunTestOnMainThread() /src/chrome/browser/captive_portal/captive_portal_browsertest.cc:1891:25 (browser_tests+0x4eb9cc3) #51 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() /src/content/public/test/browser_test_base.cc:406:5 (browser_tests+0xa863ddd) #52 Invoke<void (content::BrowserTestBase::*)(), content::BrowserTestBase *> /src/base/bind_internal.h:507:12 (browser_tests+0xa864f28) #53 MakeItSo<void (content::BrowserTestBase::*const &)(), content::BrowserTestBase *> /src/base/bind_internal.h:607 (browser_tests+0xa864f28) #54 RunImpl<void (content::BrowserTestBase::*const &)(), const std::__1::tuple<base::internal::UnretainedWrapper<content::BrowserTestBase> > &, 0> /src/base/bind_internal.h:680 (browser_tests+0xa864f28) #55 base::internal::Invoker<base::internal::BindState<void (content::BrowserTestBase::*)(), base::internal::UnretainedWrapper<content::BrowserTestBase> >, void ()>::Run(base::internal::BindStateBase*) /src/base/bind_internal.h:662 (browser_tests+0xa864f28) #56 Run /src/base/callback.h:129:12 (browser_tests+0x9ce722d) #57 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() /src/chrome/browser/chrome_browser_main.cc:3181 (browser_tests+0x9ce722d) #58 ChromeBrowserMainParts::PreMainMessageLoopRun() /src/chrome/browser/chrome_browser_main.cc:2259:18 (browser_tests+0x9ce52eb) #59 content::BrowserMainLoop::PreMainMessageLoopRun() /src/content/browser/browser_main_loop.cc:1021:13 (browser_tests+0x6a854c0) #60 Invoke<int (content::BrowserMainLoop::*)(), content::BrowserMainLoop *> /src/base/bind_internal.h:507:12 (browser_tests+0x6a88df8) #61 MakeItSo<int (content::BrowserMainLoop::*const &)(), content::BrowserMainLoop *> /src/base/bind_internal.h:607 (browser_tests+0x6a88df8) #62 RunImpl<int (content::BrowserMainLoop::*const &)(), const std::__1::tuple<base::internal::UnretainedWrapper<content::BrowserMainLoop> > &, 0> /src/base/bind_internal.h:680 (browser_tests+0x6a88df8) #63 base::internal::Invoker<base::internal::BindState<int (content::BrowserMainLoop::*)(), base::internal::UnretainedWrapper<content::BrowserMainLoop> >, int ()>::Run(base::internal::BindStateBase*) /src/base/bind_internal.h:662 (browser_tests+0x6a88df8) #64 Run /src/base/callback.h:129:12 (browser_tests+0x726d05a) #65 content::StartupTaskRunner::RunAllTasksNow() /src/content/browser/startup_task_runner.cc:43 (browser_tests+0x726d05a) #66 content::BrowserMainLoop::CreateStartupTasks() /src/content/browser/browser_main_loop.cc:932:25 (browser_tests+0x6a8379a) #67 content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) /src/content/browser/browser_main_runner_impl.cc:143:15 (browser_tests+0x6a893ea) #68 content::BrowserMain(content::MainFunctionParams const&) /src/content/browser/browser_main.cc:45:32 (browser_tests+0x6a80539) #69 RunBrowserProcessMain /src/content/app/content_main_runner_impl.cc:613:10 (browser_tests+0x99a6eeb) #70 content::ContentMainRunnerImpl::Run(bool) /src/content/app/content_main_runner_impl.cc:973 (browser_tests+0x99a6eeb) #71 content::ContentServiceManagerMainDelegate::RunEmbedderProcess() /src/content/app/content_service_manager_main_delegate.cc:53:32 (browser_tests+0x99a414f) #72 service_manager::Main(service_manager::MainParams const&) /src/services/service_manager/embedder/main.cc:472:29 (browser_tests+0xd205c76) #73 content::ContentMain(content::ContentMainParams const&) /src/content/app/content_main.cc:19:10 (browser_tests+0x99a494b) #74 content::BrowserTestBase::SetUp() /src/content/public/test/browser_test_base.cc:322:3 (browser_tests+0xa863831) #75 InProcessBrowserTest::SetUp() /src/chrome/test/base/in_process_browser_test.cc:272:20 (browser_tests+0x9c3a89d) #76 testing::Test::Run() /src/googletest (browser_tests+0x562b70b) #77 testing::TestInfo::Run() /src/googletest (browser_tests+0x562c96c) #78 testing::TestCase::Run() /src/googletest (browser_tests+0x562d1f6) #79 testing::internal::UnitTestImpl::RunAllTests() /src/googletest (browser_tests+0x563d796) #80 testing::UnitTest::Run() /src/googletest (browser_tests+0x563d07a) #81 RUN_ALL_TESTS /src/googletest/include/gtest/gtest.h:2329:46 (browser_tests+0x9c5d7f5) #82 base::TestSuite::Run() /src/base/test/test_suite.cc:277 (browser_tests+0x9c5d7f5) #83 ChromeTestSuiteRunner::RunTestSuite(int, char**) /src/chrome/test/base/chrome_test_launcher.cc:65:38 (browser_tests+0x9a490f6) #84 ChromeTestLauncherDelegate::RunTestSuite(int, char**) /src/chrome/test/base/chrome_test_launcher.cc:74:19 (browser_tests+0x9a491ff) #85 content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) /src/content/public/test/test_launcher.cc:650:31 (browser_tests+0xa8c08de) #86 LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) /src/chrome/test/base/chrome_test_launcher.cc:170:10 (browser_tests+0x9a49784) #87 main /src/chrome/test/base/browser_tests_main.cc:36:10 (browser_tests+0x9a48fdc) Previous write of size 1 at 0x7b44000004d8 by thread T2: #0 CaptivePortalBrowserTest::SetBehindCaptivePortal(bool) /src/chrome/browser/captive_portal/captive_portal_browsertest.cc:745:28 (browser_tests+0x4eb12d8) #1 Invoke<void (CaptivePortalBrowserTest::*)(bool), CaptivePortalBrowserTest *, bool> /src/base/bind_internal.h:507:12 (browser_tests+0x4ed0549) #2 MakeItSo<void (CaptivePortalBrowserTest::*)(bool), CaptivePortalBrowserTest *, bool> /src/base/bind_internal.h:607 (browser_tests+0x4ed0549) #3 RunImpl<void (CaptivePortalBrowserTest::*)(bool), std::__1::tuple<base::internal::UnretainedWrapper<CaptivePortalBrowserTest>, bool>, 0, 1> /src/base/bind_internal.h:680 (browser_tests+0x4ed0549) #4 base::internal::Invoker<base::internal::BindState<void (CaptivePortalBrowserTest::*)(bool), base::internal::UnretainedWrapper<CaptivePortalBrowserTest>, bool>, void ()>::RunOnce(base::internal::BindStateBase*) /src/base/bind_internal.h:649 (browser_tests+0x4ed0549) #5 Run /src/base/callback.h:99:12 (browser_tests+0x9a92ee8) #6 base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) /src/base/debug/task_annotator.cc:101 (browser_tests+0x9a92ee8) #7 base::MessageLoop::RunTask(base::PendingTask*) /src/base/message_loop/message_loop.cc:432:46 (browser_tests+0x55f355a) #8 base::MessageLoop::DeferOrRunPendingTask(base::PendingTask) /src/base/message_loop/message_loop.cc:443:5 (browser_tests+0x55f3e7c) #9 base::MessageLoop::DoWork() /src/base/message_loop/message_loop.cc:487:16 (browser_tests+0x55f41c5) #10 base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) /src/base/message_loop/message_pump_libevent.cc:210:31 (browser_tests+0x9bfd9b4) #11 base::MessageLoop::Run(bool) /src/base/message_loop/message_loop.cc:374:12 (browser_tests+0x55f2c67) #12 non-virtual thunk to base::MessageLoop::Run(bool) /src/base/message_loop/message_loop.cc (browser_tests+0x55f2d54) #13 base::RunLoop::Run() /src/base/run_loop.cc:102:14 (browser_tests+0x55f6adf) #14 base::Thread::Run(base::RunLoop*) /src/base/threading/thread.cc:255:13 (browser_tests+0x9b8d22b) #15 content::BrowserProcessSubThread::IOThreadRun(base::RunLoop*) /src/content/browser/browser_process_sub_thread.cc:184:11 (browser_tests+0x6a95a06) #16 content::BrowserProcessSubThread::Run(base::RunLoop*) /src/content/browser/browser_process_sub_thread.cc:134:7 (browser_tests+0x6a95913) #17 base::Thread::ThreadMain() /src/base/threading/thread.cc:337:3 (browser_tests+0x9b8d80b) #18 base::(anonymous namespace)::ThreadFunc(void*) /src/base/threading/platform_thread_posix.cc:76:13 (browser_tests+0x9bf6458) Location is heap block of size 288 at 0x7b44000003c0 allocated by main thread: #0 operator new(unsigned long) /src/third_party/llvm/compiler-rt/lib/tsan/rtl/tsan_new_delete.cc:65:3 (browser_tests+0x330871d) #1 testing::internal::TestFactoryImpl<CaptivePortalBrowserTest_ShowCaptivePortalInterstitialOnCertError_Test>::CreateTest() /src/googletest/include/gtest/internal/gtest-internal.h:466:39 (browser_tests+0x4ed1d69) #2 testing::TestInfo::Run() /src/googletest (browser_tests+0x562c8ae) #3 testing::TestCase::Run() /src/googletest (browser_tests+0x562d1f6) #4 testing::internal::UnitTestImpl::RunAllTests() /src/googletest (browser_tests+0x563d796) #5 testing::UnitTest::Run() /src/googletest (browser_tests+0x563d07a) #6 RUN_ALL_TESTS /src/googletest/include/gtest/gtest.h:2329:46 (browser_tests+0x9c5d7f5) #7 base::TestSuite::Run() /src/base/test/test_suite.cc:277 (browser_tests+0x9c5d7f5) #8 ChromeTestSuiteRunner::RunTestSuite(int, char**) /src/chrome/test/base/chrome_test_launcher.cc:65:38 (browser_tests+0x9a490f6) #9 ChromeTestLauncherDelegate::RunTestSuite(int, char**) /src/chrome/test/base/chrome_test_launcher.cc:74:19 (browser_tests+0x9a491ff) #10 content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) /src/content/public/test/test_launcher.cc:650:31 (browser_tests+0xa8c08de) #11 LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) /src/chrome/test/base/chrome_test_launcher.cc:170:10 (browser_tests+0x9a49784) #12 main /src/chrome/test/base/browser_tests_main.cc:36:10 (browser_tests+0x9a48fdc) Thread T2 'Chrome_IOThread' (tid=37629, running) created by main thread at: #0 pthread_create /src/third_party/llvm/compiler-rt/lib/tsan/rtl/tsan_interceptors.cc:965:3 (browser_tests+0x329e755) #1 base::(anonymous namespace)::CreateThread(unsigned long, bool, base::PlatformThread::Delegate*, base::PlatformThreadHandle*, base::ThreadPriority) /src/base/threading/platform_thread_posix.cc:115:13 (browser_tests+0x9bf5d96) #2 base::PlatformThread::CreateWithPriority(unsigned long, base::PlatformThread::Delegate*, base::PlatformThreadHandle*, base::ThreadPriority) /src/base/threading/platform_thread_posix.cc:200:10 (browser_tests+0x9bf5c55) #3 base::Thread::StartWithOptions(base::Thread::Options const&) /src/base/threading/thread.cc:112:15 (browser_tests+0x9b8c8c5) #4 content::BrowserProcessSubThread::CreateIOThread() /src/content/browser/browser_process_sub_thread.cc:97:19 (browser_tests+0x6a9560e) #5 content::ContentMainRunnerImpl::Run(bool) /src/content/app/content_main_runner_impl.cc:953:29 (browser_tests+0x99a6cc8) #6 content::ContentServiceManagerMainDelegate::RunEmbedderProcess() /src/content/app/content_service_manager_main_delegate.cc:53:32 (browser_tests+0x99a414f) #7 service_manager::Main(service_manager::MainParams const&) /src/services/service_manager/embedder/main.cc:472:29 (browser_tests+0xd205c76) #8 content::ContentMain(content::ContentMainParams const&) /src/content/app/content_main.cc:19:10 (browser_tests+0x99a494b) #9 content::BrowserTestBase::SetUp() /src/content/public/test/browser_test_base.cc:322:3 (browser_tests+0xa863831) #10 InProcessBrowserTest::SetUp() /src/chrome/test/base/in_process_browser_test.cc:272:20 (browser_tests+0x9c3a89d) #11 testing::Test::Run() /src/googletest (browser_tests+0x562b70b) #12 testing::TestInfo::Run() /src/googletest (browser_tests+0x562c96c) #13 testing::TestCase::Run() /src/googletest (browser_tests+0x562d1f6) #14 testing::internal::UnitTestImpl::RunAllTests() /src/googletest (browser_tests+0x563d796) #15 testing::UnitTest::Run() /src/googletest (browser_tests+0x563d07a) #16 RUN_ALL_TESTS /src/googletest/include/gtest/gtest.h:2329:46 (browser_tests+0x9c5d7f5) #17 base::TestSuite::Run() /src/base/test/test_suite.cc:277 (browser_tests+0x9c5d7f5) #18 ChromeTestSuiteRunner::RunTestSuite(int, char**) /src/chrome/test/base/chrome_test_launcher.cc:65:38 (browser_tests+0x9a490f6) #19 ChromeTestLauncherDelegate::RunTestSuite(int, char**) /src/chrome/test/base/chrome_test_launcher.cc:74:19 (browser_tests+0x9a491ff) #20 content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) /src/content/public/test/test_launcher.cc:650:31 (browser_tests+0xa8c08de) #21 LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) /src/chrome/test/base/chrome_test_launcher.cc:170:10 (browser_tests+0x9a49784) #22 main /src/chrome/test/base/browser_tests_main.cc:36:10 (browser_tests+0x9a48fdc) SUMMARY: ThreadSanitizer: data race chrome/browser/captive_portal/captive_portal_browsertest.cc:984:9 in CaptivePortalBrowserTest::OnIntercept(content::URLLoaderInterceptor::RequestParams*) Change-Id: I58163d96f66f8ca3b2d257d1481b0d12f980c679 Reviewed-on: https://chromium-review.googlesource.com/c/1356582 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#613677}

This reverts commit ffea867. Reason for revert: The WebRTC M71 branch has been fixed, so re-pin to it. Tested OK locally syncing deps and building with this revert. Here's the fixed WebRTC M71 branch: https://webrtc.googlesource.com/src/+log/branch-heads/71 Original change's description: > Revert webrtc unpinning. > > Speculative fix that the webrtc m71 branch is out-of-sync with src.git > and the cause of build failures. > > R=govind@google.com, tommi@google.com > > Bug: 895012 > Change-Id: Ibd19f2371b6eda5d915ce4ebf9ba377e507ff0c6 > Reviewed-on: https://chromium-review.googlesource.com/c/1279345 > Reviewed-by: Krishna Govind <govind@chromium.org> > Cr-Commit-Position: refs/branch-heads/3578@{#6} > Cr-Branched-From: 4226ddf-refs/heads/master@{#599034} TBR=tommi@chromium.org,mmoss@chromium.org,govind@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 895012 Change-Id: I4fe1be11eb845e36f752d05687bb7acf7af2b267 Reviewed-on: https://chromium-review.googlesource.com/c/1280666 Reviewed-by: Michael Moss <mmoss@chromium.org> Reviewed-by: Tommi <tommi@chromium.org> Reviewed-by: Krishna Govind <govind@chromium.org> Reviewed-by: Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#25} Cr-Branched-From: 4226ddf-refs/heads/master@{#599034}

Remove consent bump internals. This includes: - API + tests from UnifiedConsentService - Metrics - Feature state and flags (cherry picked from commit 460a586) Bug: 906026 Change-Id: Ibc12bee6ea661061530e321fe9c9e45363792f9d Reviewed-on: https://chromium-review.googlesource.com/c/1355162 Reviewed-by: Jochen Eisinger <jochen@chromium.org> Reviewed-by: Brian White <bcwhite@chromium.org> Reviewed-by: David Roger <droger@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#612621} Reviewed-on: https://chromium-review.googlesource.com/c/1361240 Reviewed-by: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#25} Cr-Branched-From: d897fb1-refs/heads/master@{#612437}

Currently, if a device starts a RemotePlayback session and an external device plays/pauses the video (via the Android cast notification), the WMPI that started the casting session never gets updated. This means that the user will see the video element on their phone as "playing", with no media time update, or they will see the local video as paused when the cast video is clearly playing. This CL addresses the issue by requesting Blink to play/pause the HTMLMediaElement to match the state of the remotely playing video. This is done by bubbling up play state changes from the FlingingRenderer to WMPI via the OnRemotePlayStateChange interface. To detect an external play state change, we save whether the last command from WMPI was a play or a pause, and propagate a change whenever we get a MediaStatus update that is of the opposite play state. The cast device does not care if it receives a "PLAY" command while already playing (or "PAUSE" when paused). Therefore, after calling OnRemotePlayStateChange, FlingingRenderer does not need to treat the commands it receives any differently than a user initiated command. NOTE: This approach works reasonably well, but is not an ironclad guarantee of consistency. We are fine with missing a few changes, because all the user has to do is tap the video element once to return to a consistent state. Being too aggressive in trying to detect play state changes sometimes causes the phone to go in a feedback loop, where it constantly issues commands while the UI wildly switches between playing and pausing. Bug: 790766, 925576 Change-Id: If230c412a6a020c88970e1c9475d8fdc97976c3b Reviewed-on: https://chromium-review.googlesource.com/c/1413398 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by: Xiaohan Wang <xhwang@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#626188}(cherry picked from commit 9f575d2) Reviewed-on: https://chromium-review.googlesource.com/c/1440205 Reviewed-by: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/branch-heads/3683@{#25} Cr-Branched-From: e510299-refs/heads/master@{#625896}

tonikitoo requested a review from fred-wang April 4, 2017 16:06

fred-wang approved these changes Apr 4, 2017

View reviewed changes

tonikitoo merged commit 9f7dbc7 into Igalia:ozone-wayland-chrome Apr 4, 2017

tonikitoo deleted the ozone-wayland-chrome-fixup2 branch April 4, 2017 17:21

fred-wang mentioned this pull request Apr 4, 2017

Fix warning when building with jessie sysroot/clang #15

Closed

tonikitoo mentioned this pull request Apr 10, 2017

SetBounds (downstream) CL crashes chromeos/chrome --mash runs and linux_os/chrome --mus #41

Closed

tonikitoo mentioned this pull request Apr 11, 2017

Crash on gmail #42

Closed

tonikitoo mentioned this pull request Apr 21, 2017

fix missing tab strip on chrome/mus windows #56

Closed

tonikitoo mentioned this pull request Apr 3, 2017

"Handle OnBoundsChange in external mode. (#8)" crashes on me often #14

Closed

This was referenced Jun 7, 2017

Assertion hit: Try to send private message on Twitter #111

Closed

Assertion hit: try to close last tab (control + w) , with at least one another window still opened. #113

Closed

tonikitoo mentioned this pull request Jul 13, 2017

Assert hit: FATAL:session_restore_stats_collector.cc(209)] Check failed: 0u < loading_tab_count_ (0 vs. 0) #152

Closed

This was referenced Jul 28, 2017

medias on twitter do not play #167

Closed

Possible race in creation / parenting of windows #161

Closed

msisov mentioned this pull request Aug 10, 2017

FATAL:latency_tracker.cc(196)] Check failed: gpu_swap_begin_component.last_event_time >= original_component.first_event_time (42321552294 bogo-microseconds vs. 3419125241000 bogo-microseconds) #179

Closed

tonikitoo mentioned this pull request Aug 18, 2017

FATAL:in_flight_change.cc(104)] Check failed: false. #203

Closed

tonikitoo mentioned this pull request Nov 6, 2017

Occasional crash when creating tooltips #295

Closed

jkim-julie mentioned this pull request Jun 21, 2018

Call OnNativeWidgetDestroying for native_widget_delegate_ on closing #457

Merged

jkim-julie mentioned this pull request Aug 9, 2018

Crashed with --ozone-platform=headless or x11 #475

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Warning fix (issue #15) #25

Warning fix (issue #15) #25

tonikitoo commented Apr 4, 2017

fred-wang left a comment

fred-wang commented Apr 5, 2017

Warning fix (issue #15) #25

Warning fix (issue #15) #25

Conversation

tonikitoo commented Apr 4, 2017

fred-wang left a comment

Choose a reason for hiding this comment

fred-wang commented Apr 5, 2017