fixup! c++ / mojo changes for 'external window mode' (#7) #7

msisov · 2017-03-29T11:51:30Z

-- Use DefaultAccessPolicy as long as WindowManagerAccessPolicy
causes InFlightChange to end up with CHECK(false), which goes from WindowTreeClient::OnChangeCompleted -> change->ChangeFailed();

fred-wang · 2017-03-29T11:53:24Z

lgtm

fred-wang · 2017-03-29T11:55:15Z

I would make this a TEMP until we figured out how to handle these policies...

-- Use DefaultAccessPolicy as long as WindowManagerAccessPolicy causes InFlightChange to end up with CHECK(false) Figure out how to handle these policies

msisov · 2017-03-29T12:05:08Z

Done!

tonikitoo

lgtm.

do unittests continue to work?

fred-wang · 2017-03-29T12:48:02Z

No but they are already broken on the ozone-wayland-chrome branch anyway.

…galia#7 id:120001 of https://codereview.chromium.org/2759563004/ ) Reason for revert: Consistent failure: webkit_tests failing on 6 builders 33 since the first detection e.g. https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac10.10 This CL is suspicious because mojo/module-loading.html has been failing. https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.webkit%2FWebKit_Mac10.10%2F31815%2F%2B%2Frecipes%2Fsteps%2Fwebkit_tests%2F0%2Fstdout Regressions: Unexpected text-only failures (1) mojo/module-loading.html [ Failure ] 09:20:53.708 5958 worker/0 virtual/mojo-loading/http/tests/bluetooth/https/requestDevice/cross-origin-iframe.html output stderr lines: 09:20:53.709 5958 [09:20:53.354] vtDecompressionDuctCreate signalled err=-8973 (err) (Could not select and open decoder instance) at /SourceCache/CoreMedia_frameworks/CoreMedia-1562.235/Sources/VideoToolbox/VTDecompressionSession.c line 1181 09:20:53.709 5958 <<<< VTVideoEncoderSelection >>>> VTSelectAndCreateVideoEncoderInstanceInternal: no video encoder found for 'avc1' Original issue's description: > Mojo JS bindings: change module loading solution. > > This change takes place on the mojo/public/js/new_bindings copy so it doesn't > affect existing users. > > - This change gets rid of AMD module loading. Now the bindings API is defined in > the "mojoBindings" namespace. At build time, all bindings files are combined > into a single file "mojo_bindings.js". Users should use <script> tag to include > this file (as well as generated mojom.js files). > > - Generated mojom.js files export their definitions under the same namespace as > the "module" statement in the corresponding mojom files. > > - This change also adds a "use_new_js_bindings" option to the generator. It > duplicates the control message mojom files in order to generate two > different flavors of JS bindings. > > - The new bindings use the Mojo system API defined by Web IDL. > > BUG=699569 > > Review-Url: https://codereview.chromium.org/2759563004 > Cr-Commit-Position: refs/heads/master@{#459654} > Committed: https://chromium.googlesource.com/chromium/src/+/e6a5534bb3fe61b5224f1a22e43ba957190ad5d0 TBR=rockot@chromium.org,dcheng@chromium.org,alokp@chromium.org,yzshen@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=699569 Review-Url: https://codereview.chromium.org/2779533002 Cr-Commit-Position: refs/heads/master@{#459745}

… id:120001 of https://codereview.chromium.org/2769933002/ ) Reason for revert: Typo'ed in final set of review comments :( Original issue's description: > V2 of //tools/binary_size rewrite (diffs). > > Renames: > analyze.py -> map2size.py > symbols.py -> models.py > query.py -> console.py > mapfileparser.py -> linker_map_parser.py > > Main features: > * Removes explain_binary_size_delta.py in favour of console.py. > * Ability to diff two .size results. > * Many improvements to console.py. > * Added some integration tests. > > BUG=681694 > > Review-Url: https://codereview.chromium.org/2769933002 > Cr-Commit-Position: refs/heads/master@{#459878} > Committed: https://chromium.googlesource.com/chromium/src/+/35ed9edd145d324bdec5c10a1f99c5863b93b775 TBR=estevenson@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=681694 Review-Url: https://codereview.chromium.org/2778963003 Cr-Commit-Position: refs/heads/master@{#460083}

…e it under AMD Linux Catalyst driver (patchset Igalia#7 id:120001 of https://codereview.chromium.org/2764833003/ ) Reason for revert: This cl broke the "Builder: Linux Release (AMD R7 240)" bot. See: https://build.chromium.org/p/chromium.gpu.fyi/builders/Linux%20Release%20(AMD%20R7%20240) Original issue's description: > Make gl_clear_broken workaround support core profile and use it under AMD Linux Catalyst driver > > Make ClearFrameBuffer use a VAO and add version to shaders in core > profile. Use gl_clear_broken workaround under Linux AMD Catalyst driver > because it ignores clear if it's the only thing rendered to the target > before the target is read. > > BUG=690122 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > > Review-Url: https://codereview.chromium.org/2764833003 > Cr-Commit-Position: refs/heads/master@{#460282} > Committed: https://chromium.googlesource.com/chromium/src/+/6ca5d0d3ad671604d9a028e71402e9e5ee25f110 TBR=kbr@chromium.org,zmo@chromium.org,xiangze.zhang@intel.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=690122 Review-Url: https://codereview.chromium.org/2786963002 Cr-Commit-Position: refs/heads/master@{#460772}

…alia#7 id:120001 of https://codereview.chromium.org/2780623003/ ) Reason for revert: Findit identified CL at revision 460879 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2E0Njg3MmNhOTZkODYyODE2Zjk5M2MxNmQ2YzI3MGFmMjYyOTAyNDcM Original issue's description: > Enable -Wdeprecated-register (except on CrOS). > > No behavior change. > > BUG=255186,705812 > > Review-Url: https://codereview.chromium.org/2780623003 > Cr-Original-Commit-Position: refs/heads/master@{#459973} > Committed: https://chromium.googlesource.com/chromium/src/+/76ad12fee73e4512dbb9c7a79ffb6cec33fae6f2 > Review-Url: https://codereview.chromium.org/2780623003 > Cr-Commit-Position: refs/heads/master@{#460879} > Committed: https://chromium.googlesource.com/chromium/src/+/a46872ca96d862816f993c16d6c270af26290247 TBR=dcheng@chromium.org,rouslan@chromium.org,kbr@chromium.org,thakis@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=255186,705812 Review-Url: https://codereview.chromium.org/2786273002 Cr-Commit-Position: refs/heads/master@{#460910}

…Igalia#7 id:120001 of https://codereview.chromium.org/2782503002/ ) Reason for revert: New test SystemMetricsTest.LockedBytes failed on Waterfall https://findit-for-me.appspot.com/waterfall/failure?url=https://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Tests%20%281%29/builds/28540 Original issue's description: > Add new wired memory metric to memory-infra dumps. > > On macOS, wired memory cannot be evicted from physical memory [swapped, purged, > compressed]. We are observing a reproducible instance where Chrome appears to be > responsible for massive amounts of wired memory. It's unclear whether this wired > memory is being allocated by the kernel for resources associated with the task, > or by the task itself. This CL will help us distinguish between these cases. > > BUG=700928 > > Review-Url: https://codereview.chromium.org/2782503002 > Cr-Commit-Position: refs/heads/master@{#460924} > Committed: https://chromium.googlesource.com/chromium/src/+/6a44d440a7e5057f2ad1637f26802e522eeb51ab TBR=primiano@chromium.org,mark@chromium.org,thestig@chromium.org,erikchen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=700928 Review-Url: https://codereview.chromium.org/2786313002 Cr-Commit-Position: refs/heads/master@{#460972}

…(patchset Igalia#2 id:40001 of https://codereview.chromium.org/2790443004/ ) Reason for revert: Fails on msan. https://build.chromium.org/p/chromium.memory.full/builders/Linux%20MSan%20Tests/builds/6793 ==25314==WARNING: MemorySanitizer: use-of-uninitialized-value #0 0x173e79ea in vp8_intra4x4_predict third_party/libvpx/source/libvpx/vp8/common/reconintra4x4.c:64:3 Igalia#1 0x17411f49 in vp8_encode_intra4x4block third_party/libvpx/source/libvpx/vp8/encoder/encodeintra.c:55:3 Igalia#2 0x17080455 in pick_intra4x4block third_party/libvpx/source/libvpx/vp8/encoder/pickinter.c:283:3 Igalia#3 0x17080455 in pick_intra4x4mby_modes third_party/libvpx/source/libvpx/vp8/encoder/pickinter.c:313:0 Igalia#4 0x17083a01 in vp8_pick_intra_mode third_party/libvpx/source/libvpx/vp8/encoder/pickinter.c:1425:14 Igalia#5 0x1740e0b4 in vp8cx_encode_intra_macroblock third_party/libvpx/source/libvpx/vp8/encoder/encodeframe.c:1089:5 Igalia#6 0x1740b8f7 in encode_mb_row third_party/libvpx/source/libvpx/vp8/encoder/encodeframe.c:458:21 Igalia#7 0x17406d89 in vp8_encode_frame third_party/libvpx/source/libvpx/vp8/encoder/encodeframe.c:777:9 Igalia#8 0x17063469 in encode_frame_to_data_rate third_party/libvpx/source/libvpx/vp8/encoder/onyx_if.c:3987:5 Igalia#9 0x17063469 in vp8_get_compressed_data third_party/libvpx/source/libvpx/vp8/encoder/onyx_if.c:5098:0 Igalia#10 0x170280a7 in vp8e_encode third_party/libvpx/source/libvpx/vp8/vp8_cx_iface.c:879:25 Igalia#11 0x1704d1cc in vpx_codec_encode third_party/libvpx/source/libvpx/vpx/src/vpx_encoder.c:209:13 Igalia#12 0x16c10f29 in content::(anonymous namespace)::VpxEncoder::DoEncode(vpx_codec_ctx*, gfx::Size const&, unsigned char*, unsigned char*, int, unsigned char*, int, unsigned char*, int, base::TimeDelta const&, bool, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >*, bool*) content/renderer/media_recorder/video_track_recorder.cc:932:7 Igalia#13 0x16c0da73 in content::(anonymous namespace)::VpxEncoder::EncodeOnEncodingTaskRunner(scoped_refptr<media::VideoFrame>, base::TimeTicks) content/renderer/media_recorder/video_track_recorder.cc:871:3 Igalia#14 0x16c12113 in Invoke<const scoped_refptr<content::VideoTrackRecorder::Encoder> &, const scoped_refptr<media::VideoFrame> &, const base::TimeTicks &> base/bind_internal.h:214:12 Igalia#15 0x16c12113 in MakeItSo<void (content::VideoTrackRecorder::Encoder::*const &)(scoped_refptr<media::VideoFrame>, base::TimeTicks), const scoped_refptr<content::VideoTrackRecorder::Encoder> &, const scoped_refptr<media::VideoFrame> &, const base::TimeTicks &> base/bind_internal.h:285:0 Igalia#16 0x16c12113 in RunImpl<void (content::VideoTrackRecorder::Encoder::*const &)(scoped_refptr<media::VideoFrame>, base::TimeTicks), const std::__1::tuple<scoped_refptr<content::VideoTrackRecorder::Encoder>, scoped_refptr<media::VideoFrame>, base::TimeTicks> &, 0, 1, 2> base/bind_internal.h:361:0 Igalia#17 0x16c12113 in base::internal::Invoker<base::internal::BindState<void (content::VideoTrackRecorder::Encoder::*)(scoped_refptr<media::VideoFrame>, base::TimeTicks), scoped_refptr<content::VideoTrackRecorder::Encoder>, scoped_refptr<media::VideoFrame>, base::TimeTicks>, void ()>::Run(base::internal::BindStateBase*) base/bind_internal.h:339:0 Igalia#18 0xe0651e5 in Run base/callback.h:91:12 Igalia#19 0xe0651e5 in base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) base/debug/task_annotator.cc:59:0 Igalia#20 0xde5cbc3 in base::MessageLoop::RunTask(base::PendingTask*) base/message_loop/message_loop.cc:423:19 Igalia#21 0xde5e5b1 in base::MessageLoop::DeferOrRunPendingTask(base::PendingTask) base/message_loop/message_loop.cc:434:5 Igalia#22 0xde6015e in base::MessageLoop::DoWork() base/message_loop/message_loop.cc:527:13 Igalia#23 0xde6d8d0 in base::MessagePumpDefault::Run(base::MessagePump::Delegate*) base/message_loop/message_pump_default.cc:33:31 Igalia#24 0xde5bc46 in base::MessageLoop::RunHandler() base/message_loop/message_loop.cc:387:10 Igalia#25 0xdede3fc in base::RunLoop::Run() base/run_loop.cc:37:10 Igalia#26 0xdf87aef in base::Thread::ThreadMain() base/threading/thread.cc:333:3 Igalia#27 0xdf70fb5 in base::(anonymous namespace)::ThreadFunc(void*) base/threading/platform_thread_posix.cc:71:13 Igalia#28 0x7f49dc121183 in start_thread /build/eglibc-oGUzwX/eglibc-2.19/nptl/pthread_create.c:312:0 Igalia#29 0x7f49dbc3837c in clone /build/eglibc-oGUzwX/eglibc-2.19/misc/../sysdeps/unix/sysv/linux/x86_64/clone.S:111:0 Uninitialized value was stored to memory at #0 0x1707f3e6 in pick_intra4x4block third_party/libvpx/source/libvpx/vp8/encoder/pickinter.c:282:18 Igalia#1 0x1707f3e6 in pick_intra4x4mby_modes third_party/libvpx/source/libvpx/vp8/encoder/pickinter.c:313:0 Igalia#2 0x17083a01 in vp8_pick_intra_mode third_party/libvpx/source/libvpx/vp8/encoder/pickinter.c:1425:14 Igalia#3 0x1740e0b4 in vp8cx_encode_intra_macroblock third_party/libvpx/source/libvpx/vp8/encoder/encodeframe.c:1089:5 Igalia#4 0x1740b8f7 in encode_mb_row third_party/libvpx/source/libvpx/vp8/encoder/encodeframe.c:458:21 Igalia#5 0x17406d89 in vp8_encode_frame third_party/libvpx/source/libvpx/vp8/encoder/encodeframe.c:777:9 Igalia#6 0x17063469 in encode_frame_to_data_rate third_party/libvpx/source/libvpx/vp8/encoder/onyx_if.c:3987:5 Igalia#7 0x17063469 in vp8_get_compressed_data third_party/libvpx/source/libvpx/vp8/encoder/onyx_if.c:5098:0 Igalia#8 0x170280a7 in vp8e_encode third_party/libvpx/source/libvpx/vp8/vp8_cx_iface.c:879:25 Igalia#9 0x1704d1cc in vpx_codec_encode third_party/libvpx/source/libvpx/vpx/src/vpx_encoder.c:209:13 Igalia#10 0x16c10f29 in content::(anonymous namespace)::VpxEncoder::DoEncode(vpx_codec_ctx*, gfx::Size const&, unsigned char*, unsigned char*, int, unsigned char*, int, unsigned char*, int, base::TimeDelta const&, bool, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >*, bool*) content/renderer/media_recorder/video_track_recorder.cc:932:7 Igalia#11 0x16c0da73 in content::(anonymous namespace)::VpxEncoder::EncodeOnEncodingTaskRunner(scoped_refptr<media::VideoFrame>, base::TimeTicks) content/renderer/media_recorder/video_track_recorder.cc:871:3 Igalia#12 0x16c12113 in Invoke<const scoped_refptr<content::VideoTrackRecorder::Encoder> &, const scoped_refptr<media::VideoFrame> &, const base::TimeTicks &> base/bind_internal.h:214:12 Igalia#13 0x16c12113 in MakeItSo<void (content::VideoTrackRecorder::Encoder::*const &)(scoped_refptr<media::VideoFrame>, base::TimeTicks), const scoped_refptr<content::VideoTrackRecorder::Encoder> &, const scoped_refptr<media::VideoFrame> &, const base::TimeTicks &> base/bind_internal.h:285:0 Igalia#14 0x16c12113 in RunImpl<void (content::VideoTrackRecorder::Encoder::*const &)(scoped_refptr<media::VideoFrame>, base::TimeTicks), const std::__1::tuple<scoped_refptr<content::VideoTrackRecorder::Encoder>, scoped_refptr<media::VideoFrame>, base::TimeTicks> &, 0, 1, 2> base/bind_internal.h:361:0 Igalia#15 0x16c12113 in base::internal::Invoker<base::internal::BindState<void (content::VideoTrackRecorder::Encoder::*)(scoped_refptr<media::VideoFrame>, base::TimeTicks), scoped_refptr<content::VideoTrackRecorder::Encoder>, scoped_refptr<media::VideoFrame>, base::TimeTicks>, void ()>::Run(base::internal::BindStateBase*) base/bind_internal.h:339:0 Igalia#16 0xe0651e5 in Run base/callback.h:91:12 Igalia#17 0xe0651e5 in base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) base/debug/task_annotator.cc:59:0 Igalia#18 0xde5cbc3 in base::MessageLoop::RunTask(base::PendingTask*) base/message_loop/message_loop.cc:423:19 Igalia#19 0xde5e5b1 in base::MessageLoop::DeferOrRunPendingTask(base::PendingTask) base/message_loop/message_loop.cc:434:5 Igalia#20 0xde6015e in base::MessageLoop::DoWork() base/message_loop/message_loop.cc:527:13 Igalia#21 0xde6d8d0 in base::MessagePumpDefault::Run(base::MessagePump::Delegate*) base/message_loop/message_pump_default.cc:33:31 Igalia#22 0xde5bc46 in base::MessageLoop::RunHandler() base/message_loop/message_loop.cc:387:10 Igalia#23 0xdede3fc in base::RunLoop::Run() base/run_loop.cc:37:10 Igalia#24 0xdf87aef in base::Thread::ThreadMain() base/threading/thread.cc:333:3 Igalia#25 0xdf70fb5 in base::(anonymous namespace)::ThreadFunc(void*) base/threading/platform_thread_posix.cc:71:13 Uninitialized value was stored to memory at #0 0x6c3fcb in __msan_memcpy ??:0:0 Igalia#1 0x173dba76 in vp8_copy_mem16x16_c third_party/libvpx/source/libvpx/vp8/common/reconinter.c:28:5 Igalia#2 0x1740b0f7 in encode_mb_row third_party/libvpx/source/libvpx/vp8/encoder/encodeframe.c:418:5 Igalia#3 0x17406d89 in vp8_encode_frame third_party/libvpx/source/libvpx/vp8/encoder/encodeframe.c:777:9 Igalia#4 0x17063469 in encode_frame_to_data_rate third_party/libvpx/source/libvpx/vp8/encoder/onyx_if.c:3987:5 Igalia#5 0x17063469 in vp8_get_compressed_data third_party/libvpx/source/libvpx/vp8/encoder/onyx_if.c:5098:0 Igalia#6 0x170280a7 in vp8e_encode third_party/libvpx/source/libvpx/vp8/vp8_cx_iface.c:879:25 Igalia#7 0x1704d1cc in vpx_codec_encode third_party/libvpx/source/libvpx/vpx/src/vpx_encoder.c:209:13 Igalia#8 0x16c10f29 in content::(anonymous namespace)::VpxEncoder::DoEncode(vpx_codec_ctx*, gfx::Size const&, unsigned char*, unsigned char*, int, unsigned char*, int, unsigned char*, int, base::TimeDelta const&, bool, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >*, bool*) content/renderer/media_recorder/video_track_recorder.cc:932:7 Igalia#9 0x16c0da73 in content::(anonymous namespace)::VpxEncoder::EncodeOnEncodingTaskRunner(scoped_refptr<media::VideoFrame>, base::TimeTicks) content/renderer/media_recorder/video_track_recorder.cc:871:3 Igalia#10 0x16c12113 in Invoke<const scoped_refptr<content::VideoTrackRecorder::Encoder> &, const scoped_refptr<media::VideoFrame> &, const base::TimeTicks &> base/bind_internal.h:214:12 Igalia#11 0x16c12113 in MakeItSo<void (content::VideoTrackRecorder::Encoder::*const &)(scoped_refptr<media::VideoFrame>, base::TimeTicks), const scoped_refptr<content::VideoTrackRecorder::Encoder> &, const scoped_refptr<media::VideoFrame> &, const base::TimeTicks &> base/bind_internal.h:285:0 Igalia#12 0x16c12113 in RunImpl<void (content::VideoTrackRecorder::Encoder::*const &)(scoped_refptr<media::VideoFrame>, base::TimeTicks), const std::__1::tuple<scoped_refptr<content::VideoTrackRecorder::Encoder>, scoped_refptr<media::VideoFrame>, base::TimeTicks> &, 0, 1, 2> base/bind_internal.h:361:0 Igalia#13 0x16c12113 in base::internal::Invoker<base::internal::BindState<void (content::VideoTrackRecorder::Encoder::*)(scoped_refptr<media::VideoFrame>, base::TimeTicks), scoped_refptr<content::VideoTrackRecorder::Encoder>, scoped_refptr<media::VideoFrame>, base::TimeTicks>, void ()>::Run(base::internal::BindStateBase*) base/bind_internal.h:339:0 Igalia#14 0xe0651e5 in Run base/callback.h:91:12 Igalia#15 0xe0651e5 in base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) base/debug/task_annotator.cc:59:0 Igalia#16 0xde5cbc3 in base::MessageLoop::RunTask(base::PendingTask*) base/message_loop/message_loop.cc:423:19 Igalia#17 0xde5e5b1 in base::MessageLoop::DeferOrRunPendingTask(base::PendingTask) base/message_loop/message_loop.cc:434:5 Igalia#18 0xde6015e in base::MessageLoop::DoWork() base/message_loop/message_loop.cc:527:13 Igalia#19 0xde6d8d0 in base::MessagePumpDefault::Run(base::MessagePump::Delegate*) base/message_loop/message_pump_default.cc:33:31 Igalia#20 0xde5bc46 in base::MessageLoop::RunHandler() base/message_loop/message_loop.cc:387:10 Igalia#21 0xdede3fc in base::RunLoop::Run() base/run_loop.cc:37:10 Igalia#22 0xdf87aef in base::Thread::ThreadMain() base/threading/thread.cc:333:3 Igalia#23 0xdf70fb5 in base::(anonymous namespace)::ThreadFunc(void*) base/threading/platform_thread_posix.cc:71:13 Igalia#24 0x7f49dc121183 in start_thread /build/eglibc-oGUzwX/eglibc-2.19/nptl/pthread_create.c:312:0 Uninitialized value was stored to memory at #0 0x6c3fcb in __msan_memcpy ??:0:0 Igalia#1 0x176380f4 in copy_and_extend_plane third_party/libvpx/source/libvpx/vp8/common/extend.c:38:5 Igalia#2 0x176380f4 in vp8_copy_and_extend_frame third_party/libvpx/source/libvpx/vp8/common/extend.c:73:0 Igalia#3 0x174262e5 in vp8_lookahead_push third_party/libvpx/source/libvpx/vp8/encoder/lookahead.c:139:5 Igalia#4 0x1705ceba in vp8_receive_raw_frame third_party/libvpx/source/libvpx/vp8/encoder/onyx_if.c:4817:7 Igalia#5 0x1702745a in vp8e_encode third_party/libvpx/source/libvpx/vp8/vp8_cx_iface.c:863:11 Igalia#6 0x1704d1cc in vpx_codec_encode third_party/libvpx/source/libvpx/vpx/src/vpx_encoder.c:209:13 Igalia#7 0x16c10f29 in content::(anonymous namespace)::VpxEncoder::DoEncode(vpx_codec_ctx*, gfx::Size const&, unsigned char*, unsigned char*, int, unsigned char*, int, unsigned char*, int, base::TimeDelta const&, bool, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >*, bool*) content/renderer/media_recorder/video_track_recorder.cc:932:7 Igalia#8 0x16c0da73 in content::(anonymous namespace)::VpxEncoder::EncodeOnEncodingTaskRunner(scoped_refptr<media::VideoFrame>, base::TimeTicks) content/renderer/media_recorder/video_track_recorder.cc:871:3 Igalia#9 0x16c12113 in Invoke<const scoped_refptr<content::VideoTrackRecorder::Encoder> &, const scoped_refptr<media::VideoFrame> &, const base::TimeTicks &> base/bind_internal.h:214:12 Igalia#10 0x16c12113 in MakeItSo<void (content::VideoTrackRecorder::Encoder::*const &)(scoped_refptr<media::VideoFrame>, base::TimeTicks), const scoped_refptr<content::VideoTrackRecorder::Encoder> &, const scoped_refptr<media::VideoFrame> &, const base::TimeTicks &> base/bind_internal.h:285:0 Igalia#11 0x16c12113 in RunImpl<void (content::VideoTrackRecorder::Encoder::*const &)(scoped_refptr<media::VideoFrame>, base::TimeTicks), const std::__1::tuple<scoped_refptr<content::VideoTrackRecorder::Encoder>, scoped_refptr<media::VideoFrame>, base::TimeTicks> &, 0, 1, 2> base/bind_internal.h:361:0 Igalia#12 0x16c12113 in base::internal::Invoker<base::internal::BindState<void (content::VideoTrackRecorder::Encoder::*)(scoped_refptr<media::VideoFrame>, base::TimeTicks), scoped_refptr<content::VideoTrackRecorder::Encoder>, scoped_refptr<media::VideoFrame>, base::TimeTicks>, void ()>::Run(base::internal::BindStateBase*) base/bind_internal.h:339:0 Igalia#13 0xe0651e5 in Run base/callback.h:91:12 Igalia#14 0xe0651e5 in base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) base/debug/task_annotator.cc:59:0 Igalia#15 0xde5cbc3 in base::MessageLoop::RunTask(base::PendingTask*) base/message_loop/message_loop.cc:423:19 Igalia#16 0xde5e5b1 in base::MessageLoop::DeferOrRunPendingTask(base::PendingTask) base/message_loop/message_loop.cc:434:5 Igalia#17 0xde6015e in base::MessageLoop::DoWork() base/message_loop/message_loop.cc:527:13 Igalia#18 0xde6d8d0 in base::MessagePumpDefault::Run(base::MessagePump::Delegate*) base/message_loop/message_pump_default.cc:33:31 Igalia#19 0xde5bc46 in base::MessageLoop::RunHandler() base/message_loop/message_loop.cc:387:10 Igalia#20 0xdede3fc in base::RunLoop::Run() base/run_loop.cc:37:10 Igalia#21 0xdf87aef in base::Thread::ThreadMain() base/threading/thread.cc:333:3 Igalia#22 0xdf70fb5 in base::(anonymous namespace)::ThreadFunc(void*) base/threading/platform_thread_posix.cc:71:13 Igalia#23 0x7f49dc121183 in start_thread /build/eglibc-oGUzwX/eglibc-2.19/nptl/pthread_create.c:312:0 Uninitialized value was created by a heap allocation #0 0x6c4363 in __interceptor_posix_memalign ??:0:0 Igalia#1 0xde417c9 in base::AlignedAlloc(unsigned long, unsigned long) base/memory/aligned_memory.cc:31:7 Igalia#2 0xfb569fd in media::VideoFrame::AllocateYUV(bool) media/base/video_frame.cc:1205:7 Igalia#3 0xfb4a6ef in media::VideoFrame::CreateFrameInternal(media::VideoPixelFormat, gfx::Size const&, gfx::Rect const&, gfx::Size const&, base::TimeDelta, bool) media/base/video_frame.cc:1064:10 Igalia#4 0xfb49db0 in media::VideoFrame::CreateFrame(media::VideoPixelFormat, gfx::Size const&, gfx::Rect const&, gfx::Size const&, base::TimeDelta) media/base/video_frame.cc:180:10 Igalia#5 0x5865ddd in content::VideoTrackRecorderTest_EncodeFrameWithPaddedCodedSize_Test::TestBody() content/renderer/media_recorder/video_track_recorder_unittest.cc:235:49 Igalia#6 0xd7f73cc in HandleExceptionsInMethodIfSupported<testing::Test, void> testing/gtest/src/gtest.cc:2458:12 Igalia#7 0xd7f73cc in testing::Test::Run() testing/gtest/src/gtest.cc:2474:0 Igalia#8 0xd7f9cbb in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2656:11 Igalia#9 0xd7fb259 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2774:28 Igalia#10 0xd81aefd in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4647:43 Igalia#11 0xd819d8e in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2458:12 Igalia#12 0xd819d8e in testing::UnitTest::Run() testing/gtest/src/gtest.cc:4255:0 Igalia#13 0xb826860 in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2237:46 Igalia#14 0xb826860 in base::TestSuite::Run() base/test/test_suite.cc:271:0 Igalia#15 0xb848b7c in Run base/callback.h:80:12 Igalia#16 0xb848b7c in base::(anonymous namespace)::LaunchUnitTestsInternal(base::Callback<int (), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&, int, int, bool, base::Callback<void (), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&) base/test/launcher/unit_test_launcher.cc:211:0 Igalia#17 0xb8483a6 in base::LaunchUnitTests(int, char**, base::Callback<int (), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&) base/test/launcher/unit_test_launcher.cc:453:10 Igalia#18 0x4f826f6 in main content/test/run_all_unittests.cc:20:10 Igalia#19 0x7f49dbb5ff44 in __libc_start_main /build/eglibc-oGUzwX/eglibc-2.19/csu/libc-start.c:287:0 Original issue's description: > Copy based on coded size in VideoTrackRecorder::VEAEncoder > > This Cl addresses the below bug making sure that input frame's > coded size is compared to VEA's requested and frame is copied > when necessary. > > BUG=705273 > TEST=The given bug is fixed and added unittests. > > Review-Url: https://codereview.chromium.org/2790443004 > Cr-Commit-Position: refs/heads/master@{#460897} > Committed: https://chromium.googlesource.com/chromium/src/+/68c20537e9ecd5715ffe280091c37fc6aa0a70f6 TBR=mcasas@chromium.org,emircan@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=705273 Review-Url: https://codereview.chromium.org/2785393002 Cr-Commit-Position: refs/heads/master@{#460975}

…ia#7) -- Use DefaultAccessPolicy as long as WindowManagerAccessPolicy causes InFlightChange to end up with CHECK(false) Figure out how to handle these policies

… (Igalia#7)" This reverts commit 974c39f.

Pre-requisite for https://codereview.chromium.org/2690183002/ Otherwise it causes: [7962:7962:0330/140009.008419:FATAL:task_tracker.cc(394)] Check failed: !shutdown_event_->IsSignaled(). #0 0x000002edc667 base::debug::StackTrace::StackTrace() #1 0x000002ef500b logging::LogMessage::~LogMessage() #2 0x000002f3f8b1 base::internal::TaskTracker::BeforePostTask() #3 0x000002f3f75f base::internal::TaskTracker::WillPostTask() #4 0x000002f93628 base::internal::SchedulerSingleThreadTaskRunnerManager::SchedulerSingleThreadTaskRunner::PostDelayedTask() #5 0x000002f4982b base::SequencedWorkerPool::PoolSequencedTaskRunner::PostNonNestableDelayedTask() #6 0x000002f24e4b base::SequencedTaskRunner::DeleteOrReleaseSoonInternal() #7 0x000004c6dce5 storage::FileSystemContext::DeleteOnCorrectThread() #8 0x000000c7232e MediaFileValidatorTest::~MediaFileValidatorTest() #9 0x000000c722a9 MediaFileValidatorTest_ValidAudio_Test::~MediaFileValidatorTest_ValidAudio_Test() #10 0x000003d7c391 testing::TestInfo::Run() #11 0x000003d7c867 testing::TestCase::Run() #12 0x000003d838a7 testing::internal::UnitTestImpl::RunAllTests() #13 0x000003d83527 testing::UnitTest::Run() #14 0x000002fcbc71 base::TestSuite::Run() #15 0x000002ecef48 ChromeTestSuiteRunner::RunTestSuite() #16 0x0000035e80ec content::LaunchTests() BUG=653916 Review-Url: https://codereview.chromium.org/2789923002 Cr-Commit-Position: refs/heads/master@{#461227}

…plication list model (patchset #7 id:450001 of https://codereview.chromium.org/2724343002/ ) Reason for revert: Suspected cause of ReleaseBlock-Dev top crasher: https://bugs.chromium.org/p/chromium/issues/detail?id=707735#c5 Original issue's description: > Remove deprecated extension notification from background application list model > > Currently we have ExtensionRegistry[Observer] that substitutes old and deprecated > extension notifications. Since BackgroundApplicationListModel still uses them, > use ExtensionRegistryObserver instead. > > BUG=411568, 411566 > TEST=BackgroundApplicationListModelTest.ExtensionLoadAndUnload > > Review-Url: https://codereview.chromium.org/2724343002 > Cr-Commit-Position: refs/heads/master@{#461077} > Committed: https://chromium.googlesource.com/chromium/src/+/1a96e39ce2f4cd1956cba47c4e6413de95d11039 TBR=rdevlin.cronin@chromium.org,atwilson@chromium.org,limasdf@gmail.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=411568, 411566 NOTRY=true Review-Url: https://codereview.chromium.org/2790303002 Cr-Commit-Position: refs/heads/master@{#461596}

…://codereview.chromium.org/2793993003/ ) Reason for revert: Broke blink_platform_unittests on WebKit Linux Trusty (dbg) https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty%20%28dbg%29 failed 20 Run on OS: 'Ubuntu-14.04' failures: GeometryMapperTest.FilterWithClipsAndTransforms GeometryMapperTest.RoundedClip GeometryMapperTest.TwoClipsWithTransformBetween GeometryMapperTest.Root GeometryMapperTest.ClipAfterTransform GeometryMapperTest.TwoClipsTransformAbove GeometryMapperTest.ReflectionWithPaintOffset GeometryMapperTest.SimpleClip GeometryMapperTest.SiblingTransforms GeometryMapperTest.RotationAndScaleTransform GeometryMapperTest.NestedTransformsScaleAndTranslation GeometryMapperTest.TranslationTransform GeometryMapperTest.NestedTransformsIntermediateDestination GeometryMapperTest.SiblingTransformsWithClip GeometryMapperTest.NestedTransformsFlattening GeometryMapperTest.RotationAndScaleTransformWithTransformOrigin GeometryMapperTest.TwoClips GeometryMapperTest.IdentityTransform GeometryMapperTest.NestedTransforms GeometryMapperTest.ClipBeforeTransform Sample stack trace: [ RUN ] GeometryMapperTest.ClipAfterTransform ../../build/linux/debian_jessie_amd64-sysroot/usr/lib/gcc/x86_64-linux-gnu/4.8/../../../../include/c++/4.8/bits/unique_ptr.h:228: std::unique_ptr::pointer std::unique_ptr<blink::GeometryMapper, std::default_delete<blink::GeometryMapper> >::operator->() const [_Tp = blink::GeometryMapper, _Dp = std::default_delete<blink::GeometryMapper>]: Assertion 'get() != pointer()' failed. Received signal 6 #0 0x7fe3a88626bb base::debug::StackTrace::StackTrace() #1 0x7fe3a88613bc base::debug::StackTrace::StackTrace() #2 0x7fe3a88621cf base::debug::(anonymous namespace)::StackDumpSignalHandler() #3 0x7fe3a9d72330 <unknown> #4 0x7fe3a42cbc37 gsignal #5 0x7fe3a42cf028 abort #6 0x000000566ccf std::__replacement_assert() #7 0x0000007706d6 std::unique_ptr<>::operator->() #8 0x00000075a4b0 blink::GeometryMapperTest_ClipAfterTransform_Test::TestBody() #9 0x000000eee60e testing::internal::HandleSehExceptionsInMethodIfSupported<>() #10 0x000000ede742 testing::internal::HandleExceptionsInMethodIfSupported<>() #11 0x000000ed3216 testing::Test::Run() #12 0x000000ed39cd testing::TestInfo::Run() #13 0x000000ed3f6f testing::TestCase::Run() #14 0x000000ed92dc testing::internal::UnitTestImpl::RunAllTests() #15 0x000000ef259e testing::internal::HandleSehExceptionsInMethodIfSupported<>() #16 0x000000edffd2 testing::internal::HandleExceptionsInMethodIfSupported<>() #17 0x000000ed8f7f testing::UnitTest::Run() #18 0x000000e2c431 RUN_ALL_TESTS() #19 0x000000e2b2d2 base::TestSuite::Run() #20 0x000000a36565 (anonymous namespace)::runTestSuite() #21 0x0000005e3a6a _ZN4base8internal13FunctorTraitsIPFvPiEvE6InvokeIJS2_EEEvS4_DpOT_ #22 0x000000a36858 _ZN4base8internal12InvokeHelperILb0EiE8MakeItSoIRKPFiPNS_9TestSuiteEEJS5_EEEiOT_DpOT0_ #23 0x000000a36817 _ZN4base8internal7InvokerINS0_9BindStateIPFiPNS_9TestSuiteEEJNS0_17UnretainedWrapperIS3_EEEEEFivEE7RunImplIRKS6_RKSt5tupleIJS8_EEJLm0EEEEiOT_OT0_NS_13IndexSequenceIJXspT1_EEEE #24 0x000000a3675c _ZN4base8internal7InvokerINS0_9BindStateIPFiPNS_9TestSuiteEEJNS0_17UnretainedWrapperIS3_EEEEEFivEE3RunEPNS0_13BindStateBaseE #25 0x00000082056d _ZNKR4base8CallbackIFvvELNS_8internal8CopyModeE1ELNS2_10RepeatModeE1EE3RunEv #26 0x000000e50a16 base::(anonymous namespace)::LaunchUnitTestsInternal() #27 0x000000e50884 base::LaunchUnitTests() #28 0x000000a364c1 main #29 0x7fe3a42b6f45 __libc_start_main #30 0x00000052eb84 <unknown> r8: 29287265746e696f r9: 696c623c6574656c r10: 0000000000000008 r11: 0000000000000206 r12: 000000000052eb5b r13: 00007ffd79a846a0 r14: 0000000000000000 r15: 0000000000000000 di: 0000000000006c05 si: 0000000000006c05 bp: 00007ffd79a82540 bx: 0000000000000000 dx: 0000000000000006 ax: 0000000000000000 cx: ffffffffffffffff sp: 00007ffd79a823d8 ip: 00007fe3a42cbc37 efl: 0000000000000206 cgf: 0000000000000033 erf: 0000000000000000 trp: 0000000000000000 msk: 0000000000000000 cr2: 0000000000000000 [end of stack trace] Calling _exit(1). Core file will not be generated. Original issue's description: > Make GeometryMapper fully static. > > Now that the cache for GeometryMapper is not stored on that object, > we don't really need to allocate GeometryMapper objects at all. This > change lets us avoid the cost and plumbing complexity of such objects. > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > > Review-Url: https://codereview.chromium.org/2793993003 > Cr-Commit-Position: refs/heads/master@{#461510} > Committed: https://chromium.googlesource.com/chromium/src/+/0be71969c80ff018be92afb6bba2076bf3c1f55f TBR=haraken@chromium.org,pdr@chromium.org,wangxianzhu@chromium.org,keishi@chromium.org,chrishtr@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2798513002 Cr-Commit-Position: refs/heads/master@{#461620}

#7 id:120001 of https://codereview.chromium.org/2642733002/ ) Reason for revert: Appears to make NoStatePrefetchBrowserTest.AppCacheHtmlInitialized and NoStatePrefetchBrowserTest.AppCacheRegistered flaky. Original issue's description: > Prerender: Disable prefetch if there's an appcache. > > Stops the preload scanner if an appcache manifest is detected and the document > is prefetching. > > BUG=632368 > > Review-Url: https://codereview.chromium.org/2642733002 > Cr-Commit-Position: refs/heads/master@{#461081} > Committed: https://chromium.googlesource.com/chromium/src/+/d741ab419a18a996643c568434e0a756eaf7bee6 TBR=droger@chromium.org,csharrison@chromium.org,michaeln@chromium.org,mattcary@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=632368, 707522 Review-Url: https://codereview.chromium.org/2790323003 Cr-Commit-Position: refs/heads/master@{#461662}

Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/ace8d26..4136d39 $ git log ace8d26..4136d39 --date=short --no-merges --format=%ad %ae %s 2017-04-05 nisse@webrtc.org Replace use of system_wrappers/include/logging.h by base/logging.h. 2017-04-05 magjed@webrtc.org Android: Remove VideoCapturerAndroid 2017-04-05 ilnik@webrtc.org Reland of Move video_encoder.h and video_decoder.h to /api and create GN targets for them (patchset #1 id:1 of https://codereview.webrtc.org/2794033002/ ) 2017-04-05 nisse@webrtc.org Move SelectMediaType from RampUpTester to BaseTest. 2017-04-04 asapersson@webrtc.org Add histogram stats for number of cpu/quality adapt changes per minute for sent video streams: 2017-04-04 zstein@webrtc.org Add a minimal RtpTransport class for use by BaseChannel. 2017-04-04 jtteh@webrtc.org [iOS] Changed ptr to const ref for RTCConfiguration initialization 2017-04-04 yujo@chromium.org Trivial data() and mutable_data() implementations 2017-04-04 alessiob@webrtc.org README.md with deps, build, usage, troubleshooting 2017-04-04 guidou@webrtc.org Revert of Deliver video frames on Android, on the decode thread. (patchset #7 id:120001 of https://codereview.webrtc.org/2764573002/ ) 2017-04-04 alessiob@webrtc.org Javascript audio player for the exported HTML file. 2017-04-04 asapersson@webrtc.org Add number of quality adapt changes to VideoSendStream stats. 2017-04-04 tommi@webrtc.org Deliver video frames on Android, on the decode thread. 2017-04-04 alessiob@webrtc.org Evaluation scores export library and CSS file for the exported HTML file 2017-04-04 alessiob@webrtc.org Reland of Export library that generates an HTLM file with the scores organized in tables. (patchset #1 id:1 of https://codereview.webrtc.org/2791293002/ ) 2017-04-04 danilchap@webrtc.org Simplify RTPSender::RegisterRtpHeaderExtension DCHECK instead of run-time check extension type is correct. 2017-04-04 kthelgason@webrtc.org Make sure we observe enough frames before scaling. TBR= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG= Review-Url: https://codereview.chromium.org/2798023002 Cr-Commit-Position: refs/heads/master@{#462351}

…ication list model (patchset #1 id:1 of https://codereview.chromium.org/2790303002/ ) Reason for revert: Original CL is not a true culprit for crbug.com/707735. Original issue's description: > Revert of Remove deprecated extension notification from background application list model (patchset #7 id:450001 of https://codereview.chromium.org/2724343002/ ) > > Reason for revert: > Suspected cause of ReleaseBlock-Dev top crasher: https://bugs.chromium.org/p/chromium/issues/detail?id=707735#c5 > > Original issue's description: > > Remove deprecated extension notification from background application list model > > > > Currently we have ExtensionRegistry[Observer] that substitutes old and deprecated > > extension notifications. Since BackgroundApplicationListModel still uses them, > > use ExtensionRegistryObserver instead. > > > > BUG=411568, 411566 > > TEST=BackgroundApplicationListModelTest.ExtensionLoadAndUnload > > > > Review-Url: https://codereview.chromium.org/2724343002 > > Cr-Commit-Position: refs/heads/master@{#461077} > > Committed: https://chromium.googlesource.com/chromium/src/+/1a96e39ce2f4cd1956cba47c4e6413de95d11039 > > TBR=rdevlin.cronin@chromium.org,atwilson@chromium.org,limasdf@gmail.com > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=411568, 411566 > NOTRY=true > > Review-Url: https://codereview.chromium.org/2790303002 > Cr-Commit-Position: refs/heads/master@{#461596} > Committed: https://chromium.googlesource.com/chromium/src/+/cef092a92ecbef2465ccf990bfc16db49fbe24fb TBR=rdevlin.cronin@chromium.org,atwilson@chromium.org,caseq@chromium.org,japhet@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=411568, 411566 Review-Url: https://codereview.chromium.org/2803713002 Cr-Commit-Position: refs/heads/master@{#462455}

…(patchset #7 id:120001 of https://codereview.chromium.org/2777583002/ ) Reason for revert: The added DCHECK(format_is_set()) is failing in MediaStreamTrack-getSettings.html BUG=709188 Original issue's description: > Move getUserMedia finish to "when audio track configured". > > Previously, getUserMedia() would complete as soon as the sources > were initialized - which did not do all the initialization. > This CL will make getUserMedia() return when the track has been > told of its configuration through OnSetFormat() from upstream. > > This will allow GetSettings() to read the audio configuration from > the track without worrying about whether the configuration is > propagated or not. > > BUG=704918 > > Review-Url: https://codereview.chromium.org/2777583002 > Cr-Commit-Position: refs/heads/master@{#462523} > Committed: https://chromium.googlesource.com/chromium/src/+/a52d69d1877b170684041bed04d28acced85e40d TBR=guidou@chromium.org,hta@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=704918 Review-Url: https://codereview.chromium.org/2803183002 Cr-Commit-Position: refs/heads/master@{#462797}

…tchset Igalia#7 id:410001 of https://codereview.chromium.org/2774783003/ ) Reason for revert: Appears to have broken service_unittests on Nexus 5X. Original issue's description: > [DeviceService] Add service tests for VibrationManager. > > VibrationManagerImpl.java is in //device/vibration while the > VibrationManagerImplTest.java is still in //content, > to be able to hide all //device/vibration impl inside Device Service, > we must eliminate this concrete dependency on //device/vibration from > content layer. > > As VibrationManagerImplTest.java is an integration test based on > content shell test infra, we can't move it outside of //content. > So we consider to use other tests to replace it, while the renderer-side > testing has already been covered by layout tests created at > https://codereview.chromium.org/2731953003/, so we create this CL to > cover the VibrationManager interface impl testing: > - creates an infra for Device Service service tests. > - adds a new service test for VibrationManager interface. > > Then after this CL we'll be able to hide all vibration impl inside > Device Service with a follow-up CL. > > BUG=689379 > TEST=service_unittests > > Review-Url: https://codereview.chromium.org/2774783003 > Cr-Commit-Position: refs/heads/master@{#463612} > Committed: https://chromium.googlesource.com/chromium/src/+/9c17bee62f1e16224fabb7c83bbeaab719015761 TBR=rockot@chromium.org,avi@chromium.org,blundell@chromium.org,jam@chromium.org,timvolodine@chromium.org,leon.han@intel.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=689379 Review-Url: https://codereview.chromium.org/2815623003 Cr-Commit-Position: refs/heads/master@{#463629}

…nibox popup is shown (patchset Igalia#7 id:120001 of https://codereview.chromium.org/2196203002/ ) Reason for revert: Causing sync integ tests to fail, see crbug.com/711791 Original issue's description: > [Mac] The infobar's top arrow should be hidden while the omnibox popup is shown > > Unlike on Windows, the infobar's top arrow still remains on a screen even after > the omnibox popup is displayed over it. This CL fixes this problem based on the > idea (https://codereview.chromium.org/18859004) previously applied to Windows > version. > > BUG=174077 > > Review-Url: https://codereview.chromium.org/2196203002 > Cr-Commit-Position: refs/heads/master@{#464700} > Committed: https://chromium.googlesource.com/chromium/src/+/d1040f6d95719c52a3ec442c76be29d5c0630bf4 TBR=rsesek@chromium.org,pkasting@chromium.org,sungmann.cho@navercorp.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=174077 Review-Url: https://codereview.chromium.org/2823743002 Cr-Commit-Position: refs/heads/master@{#464837}

This reverts commit df84748. Reason for revert: To fix unit_tests (I have to revert this before the earlier patch). Likely suspect for BrowserThemePackTest.HiDpiThemeTest failing on bots. For example, https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel/11230 : [ RUN ] BrowserThemePackTest.HiDpiThemeTest ../../chrome/browser/themes/browser_theme_pack_unittest.cc:204: Failure Expected equality of these values: "" error Which is: "File doesn't exist." Stack trace: #0 0x0000026103ac testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop() Igalia#1 0x00000260fd89 testing::internal::AssertHelper::operator=() Igalia#2 0x000000fc9b98 BrowserThemePackTest::BuildFromUnpackedExtension() Igalia#3 0x000000fd22cc BrowserThemePackTest_HiDpiThemeTest_Test::TestBody() ../../chrome/browser/themes/browser_theme_pack_unittest.cc:205: Failure Value of: valid_value.get() Actual: false Expected: true Stack trace: #0 0x0000026103ac testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop() Igalia#1 0x00000260fd89 testing::internal::AssertHelper::operator=() Igalia#2 0x000000fc9e0b BrowserThemePackTest::BuildFromUnpackedExtension() Igalia#3 0x000000fd22cc BrowserThemePackTest_HiDpiThemeTest_Test::TestBody() Received signal 11 SEGV_MAPERR 000000000028 #0 0x000004d00e1c base::debug::StackTrace::StackTrace() Igalia#1 0x000004d00981 base::debug::(anonymous namespace)::StackDumpSignalHandler() Igalia#2 0x7f26bba79330 <unknown> Igalia#3 0x0000050f3e24 BrowserThemePack::WriteToDisk() Igalia#4 0x000000fd22db BrowserThemePackTest_HiDpiThemeTest_Test::TestBody() Igalia#5 0x0000026161b2 testing::Test::Run() Igalia#6 0x000002616d30 testing::TestInfo::Run() Igalia#7 0x000002617247 testing::TestCase::Run() Igalia#8 0x000002622747 testing::internal::UnitTestImpl::RunAllTests() Igalia#9 0x0000026222bd testing::UnitTest::Run() Igalia#10 0x0000045565d1 base::TestSuite::Run() Igalia#11 0x000004557fca base::(anonymous namespace)::LaunchUnitTestsInternal() Igalia#12 0x000004557e7a base::LaunchUnitTests() Igalia#13 0x00000454e155 main Igalia#14 0x7f26b86c9f45 __libc_start_main Igalia#15 0x0000006fa82a _start r8: 0000000000000000 r9: 54656d6568546970 r10: 747365545f747365 r11: 0000000000000000 r12: 000024a8af0c0d20 r13: 00007fff447924e8 r14: 00007fff44792560 r15: 0000000000000000 di: 0000000000000000 si: 00007fff44792560 bp: 00007fff44792520 bx: 00007fff44792578 dx: 00000000000005e7 ax: 0000000000001fdd cx: 0000000000000023 sp: 00007fff44792490 ip: 00000000050f3e24 efl: 0000000000010206 cgf: 0000000000000033 erf: 0000000000000004 trp: 000000000000000e msk: 0000000000000000 cr2: 0000000000000028 [end of stack trace] Original change's description: > Compute colors for the frame and tabs from provided images. > > If theme authors explicitly provide values here, we'll use them; but if they > don't, but do provide images, set the colors to be the dominant colors of the > images, using an existing K-means algorithm (similar to what we use for > computing representative favicon colors etc.). > > This allows us to rely on those colors later when deciding what color to make > tab text, the new tab button, and similar tabstrip/window frame items. > > This also does a bit of cleanup to the theme pack code, e.g. moving a map used > in only one function into that function to make its provenance clearer. I can > try to split this apart into more CLs if desired. > > Bug: 862664 > Change-Id: I8c3f15893ad491a6fee8aa5f76ae162cecb2c6fd > Reviewed-on: https://chromium-review.googlesource.com/1152517 > Commit-Queue: Peter Kasting <pkasting@chromium.org> > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > Reviewed-by: Evan Stade <estade@chromium.org> > Cr-Commit-Position: refs/heads/master@{#578823} TBR=pkasting@chromium.org,asvitkine@chromium.org,estade@chromium.org Change-Id: I6a5a7f2916136ccf93101f36c34a17a4e5ef5d4f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 862664 Reviewed-on: https://chromium-review.googlesource.com/1153988 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#578856}

This reverts commit 32cd8fc. Reason for revert: Reverting the revert because this change was proven to not have caused the issue. Original change's description: > Revert "cros: Enable touchable app context menus by default." > > This reverts commit b58ccf6. > > Reason for revert: Possibly introduced a use-after-free bug. > > This is a speculative fix for a use-after-free bug in two ash_unittests: > > 1. OverflowButtonInkDropTest.MouseContextMenu > 2. OverflowButtonActiveInkDropTest.MouseContextMenu > > [ RUN ] OverflowButtonInkDropTest.MouseContextMenu > ================================================================= > ==28149==ERROR: AddressSanitizer: heap-use-after-free on address 0x613000031f68 at pc 0x000008c82106 bp 0x7ffea3cd7190 sp 0x7ffea3cd7188 > READ of size 8 at 0x613000031f68 thread T0 > #0 0x8c82105 in begin buildtools/third_party/libc++/trunk/include/vector:1479:30 > Igalia#1 0x8c82105 in begin<std::__1::vector<aura::WindowObserver *, std::__1::allocator<aura::WindowObserver *> > > buildtools/third_party/libc++/trunk/include/iterator:1670 > Igalia#2 0x8c82105 in ContainsValue<std::__1::vector<aura::WindowObserver *, std::__1::allocator<aura::WindowObserver *> >, const aura::WindowObserver *, 0> base/stl_util.h:168 > Igalia#3 0x8c82105 in HasObserver base/observer_list.h:267 > Igalia#4 0x8c82105 in aura::Window::HasObserver(aura::WindowObserver const*) const ui/aura/window.cc:543 > Igalia#5 0x8c9d363 in aura::WindowObserver::OnUnobservingWindow(aura::Window*) ui/aura/window_observer.cc:25:15 > Igalia#6 0x8c799d7 in aura::Window::RemoveObserver(aura::WindowObserver*) ui/aura/window.cc:538:13 > Igalia#7 0xc2f40e in RemoveAll ui/base/window_tracker_template.h:49:15 > Igalia#8 0xc2f40e in ui::WindowTrackerTemplate<aura::Window, aura::WindowObserver>::~WindowTrackerTemplate() ui/base/window_tracker_template.h:33 > Igalia#9 0x9225f3b in ~CompoundEventFilter ui/wm/core/compound_event_filter.cc:49:1 > Igalia#10 0x9225f3b in wm::CompoundEventFilter::~CompoundEventFilter() ui/wm/core/compound_event_filter.cc:45 > Igalia#11 0x6b0ae30 in operator() buildtools/third_party/libc++/trunk/include/memory:2321:5 > Igalia#12 0x6b0ae30 in reset buildtools/third_party/libc++/trunk/include/memory:2634 > Igalia#13 0x6b0ae30 in ~unique_ptr buildtools/third_party/libc++/trunk/include/memory:2588 > Igalia#14 0x6b0ae30 in ash::Shell::~Shell() ash/shell.cc:969 > Igalia#15 0x6b0c81d in ash::Shell::~Shell() ash/shell.cc:737:17 > Igalia#16 0xc26b344 in ash::AshTestHelper::TearDown() ash/test/ash_test_helper.cc:294:3 > Igalia#17 0xc26444c in ash::AshTestBase::TearDown() ash/test/ash_test_base.cc:192:21 > Igalia#18 0x4724c64 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2682:11 > Igalia#19 0x4726036 in testing::TestCase::Run() third_party/googletest/src/googletest/src/gtest.cc:2800:28 > Igalia#20 0x474b566 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5124:43 > Igalia#21 0x474a7b5 in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc > Igalia#22 0x72b431a in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2331:46 > Igalia#23 0x72b431a in base::TestSuite::Run() base/test/test_suite.cc:277 > Igalia#24 0x72b9892 in Run base/callback.h:99:12 > Igalia#25 0x72b9892 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) base/test/launcher/unit_test_launcher.cc:224 > Igalia#26 0x72b9330 in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) base/test/launcher/unit_test_launcher.cc:575:10 > Igalia#27 0x178df94 in main ash/test/ash_unittests.cc:37:10 > Igalia#28 0x7f78e2b62f44 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287 > > 0x613000031f68 is located 296 bytes inside of 328-byte region [0x613000031e40,0x613000031f88) > freed by thread T0 here: > #0 0x6b9062 in operator delete(void*) /b/swarming/w/ir/kitchen-workdir/src/third_party/llvm/compiler-rt/lib/asan/asan_new_delete.cc:167:3 > Igalia#1 0x6a547a0 in ash::RootWindowController::CloseChildWindows() ash/root_window_controller.cc:498:7 > Igalia#2 0x6b0c5cf in ash::Shell::CloseAllRootWindowChildWindows() ash/shell.cc:1387:19 > Igalia#3 0x6b06637 in ash::Shell::~Shell() ash/shell.cc:837:3 > Igalia#4 0x6b0c81d in ash::Shell::~Shell() ash/shell.cc:737:17 > Igalia#5 0xc26b344 in ash::AshTestHelper::TearDown() ash/test/ash_test_helper.cc:294:3 > Igalia#6 0xc26444c in ash::AshTestBase::TearDown() ash/test/ash_test_base.cc:192:21 > Igalia#7 0x4724c64 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2682:11 > Igalia#8 0x4726036 in testing::TestCase::Run() third_party/googletest/src/googletest/src/gtest.cc:2800:28 > Igalia#9 0x474b566 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5124:43 > Igalia#10 0x474a7b5 in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc > Igalia#11 0x72b431a in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2331:46 > Igalia#12 0x72b431a in base::TestSuite::Run() base/test/test_suite.cc:277 > Igalia#13 0x72b9892 in Run base/callback.h:99:12 > Igalia#14 0x72b9892 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) base/test/launcher/unit_test_launcher.cc:224 > Igalia#15 0x72b9330 in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) base/test/launcher/unit_test_launcher.cc:575:10 > Igalia#16 0x178df94 in main ash/test/ash_unittests.cc:37:10 > Igalia#17 0x7f78e2b62f44 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287 > > previously allocated by thread T0 here: > #0 0x6b8422 in operator new(unsigned long) /b/swarming/w/ir/kitchen-workdir/src/third_party/llvm/compiler-rt/lib/asan/asan_new_delete.cc:106:3 > Igalia#1 0x91cb856 in views::NativeWidgetAura::NativeWidgetAura(views::internal::NativeWidgetDelegate*, bool, aura::Env*) ui/views/widget/native_widget_aura.cc:109:15 > Igalia#2 0x91d615d in views::internal::NativeWidgetPrivate::CreateNativeWidget(views::Widget::InitParams const&, views::internal::NativeWidgetDelegate*) ui/views/widget/native_widget_aura.cc:1113:14 > Igalia#3 0x917dabd in CreateNativeWidget ui/views/widget/widget.cc:73:10 > Igalia#4 0x917dabd in views::Widget::Init(views::Widget::InitParams const&) ui/views/widget/widget.cc:334 > Igalia#5 0x6af249a in ash::ShelfWidget::ShelfWidget(aura::Window*, ash::Shelf*) ash/shelf/shelf_widget.cc:216:3 > Igalia#6 0x6a96eaa in ash::Shelf::CreateShelfWidget(aura::Window*) ash/shelf/shelf.cc:73:27 > Igalia#7 0x6a5847a in ash::RootWindowController::InitLayoutManagers() ash/root_window_controller.cc:699:11 > Igalia#8 0x6a52166 in ash::RootWindowController::Init(ash::RootWindowController::RootWindowType) ash/root_window_controller.cc:663:3 > Igalia#9 0x68ef135 in ash::WindowTreeHostManager::InitHosts() ash/display/window_tree_host_manager.cc:238:3 > Igalia#10 0x6afadce in ash::Shell::Init(ui::ContextFactory*, ui::ContextFactoryPrivate*, std::__1::unique_ptr<base::Value, std::__1::default_delete<base::Value> >, std::__1::unique_ptr<ui::ws2::GpuInterfaceProvider, std::__1::default_delete<ui::ws2::GpuInterfaceProvider> >) ash/shell.cc:1250:30 > Igalia#11 0x6af7163 in ash::Shell::CreateInstance(ash::ShellInitParams) ash/shell.cc:276:14 > Igalia#12 0xc26ac31 in ash::AshTestHelper::CreateShell() ash/test/ash_test_helper.cc:390:3 > Igalia#13 0xc26a2a0 in ash::AshTestHelper::SetUp(bool, bool) ash/test/ash_test_helper.cc:245:3 > Igalia#14 0xc263f8d in ash::AshTestBase::SetUp() ash/test/ash_test_base.cc:159:21 > Igalia#15 0x1322b16 in ash::ShelfViewTest::SetUp() ash/shelf/shelf_view_unittest.cc:262:18 > Igalia#16 0x1326366 in SetUp ash/shelf/shelf_view_unittest.cc:2369:20 > Igalia#17 0x1326366 in ash::OverflowButtonInkDropTest::SetUp() ash/shelf/shelf_view_unittest.cc:2778 > Igalia#18 0x4722b42 in testing::Test::Run() third_party/googletest/src/googletest/src/gtest.cc > Igalia#19 0x4724c64 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2682:11 > Igalia#20 0x4726036 in testing::TestCase::Run() third_party/googletest/src/googletest/src/gtest.cc:2800:28 > Igalia#21 0x474b566 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5124:43 > Igalia#22 0x474a7b5 in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc > Igalia#23 0x72b431a in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2331:46 > Igalia#24 0x72b431a in base::TestSuite::Run() base/test/test_suite.cc:277 > Igalia#25 0x72b9892 in Run base/callback.h:99:12 > Igalia#26 0x72b9892 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) base/test/launcher/unit_test_launcher.cc:224 > Igalia#27 0x72b9330 in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) base/test/launcher/unit_test_launcher.cc:575:10 > Igalia#28 0x178df94 in main ash/test/ash_unittests.cc:37:10 > Igalia#29 0x7f78e2b62f44 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287 > > SUMMARY: AddressSanitizer: heap-use-after-free buildtools/third_party/libc++/trunk/include/vector:1479:30 in begin > Shadow bytes around the buggy address: > 0x0c267fffe390: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 > 0x0c267fffe3a0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 > 0x0c267fffe3b0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 fa > 0x0c267fffe3c0: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd > 0x0c267fffe3d0: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd > =>0x0c267fffe3e0: fd fd fd fd fd fd fd fd fd fd fd fd fd[fd]fd fd > 0x0c267fffe3f0: fd fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa > 0x0c267fffe400: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd > 0x0c267fffe410: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd > 0x0c267fffe420: fd fd fd fd fd fd fd fd fd fd fd fd fa fa fa fa > 0x0c267fffe430: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd > Shadow byte legend (one shadow byte represents 8 application bytes): > Addressable: 00 > Partially addressable: 01 02 03 04 05 06 07 > Heap left redzone: fa > Freed heap region: fd > Stack left redzone: f1 > Stack mid redzone: f2 > Stack right redzone: f3 > Stack after return: f5 > Stack use after scope: f8 > Global redzone: f9 > Global init order: f6 > Poisoned by user: f7 > Container overflow: fc > Array cookie: ac > Intra object redzone: bb > ASan internal: fe > Left alloca redzone: ca > Right alloca redzone: cb > Shadow gap: cc > ==28149==ABORTING > > Original change's description: > > cros: Enable touchable app context menus by default. > > > > This will enable: > > - New context menu UI for: > > - Application icons > > - Shelf context menus > > - Desktop context menus > > > > Note: > > - Removed tests whose functionality were already being tested. > > - MouseContextMenu already tests whether the ink drop is being > > shown, so there is no need for > > ShelfButtonShowsInkDropHighlightOnMenuShow. > > > > Bug: 871843 > > Change-Id: I4c92ae52f75b25bc9edd1dd67778c4785d8f4058 > > Reviewed-on: https://chromium-review.googlesource.com/1170985 > > Reviewed-by: Scott Violet <sky@chromium.org> > > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > > Commit-Queue: Alex Newcomer <newcomer@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#582978} > > TBR=xiyuan@chromium.org,sky@chromium.org,newcomer@chromium.org > > Change-Id: Ib85676861251f41c84f48f956d36c01edb353266 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 871843 > Reviewed-on: https://chromium-review.googlesource.com/1174641 > Reviewed-by: Chris Mumford <cmumford@chromium.org> > Commit-Queue: Chris Mumford <cmumford@chromium.org> > Cr-Commit-Position: refs/heads/master@{#583088} TBR=xiyuan@chromium.org,sky@chromium.org,cmumford@chromium.org,newcomer@chromium.org Change-Id: I4edeef479d40e1e591ac906aa89ede363668b6a3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 871843 Reviewed-on: https://chromium-review.googlesource.com/1174777 Reviewed-by: Alex Newcomer <newcomer@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#583310}

This reverts commit b58ccf6. Reason for revert: Possibly introduced a use-after-free bug. This is a speculative fix for a use-after-free bug in two ash_unittests: 1. OverflowButtonInkDropTest.MouseContextMenu 2. OverflowButtonActiveInkDropTest.MouseContextMenu [ RUN ] OverflowButtonInkDropTest.MouseContextMenu ================================================================= ==28149==ERROR: AddressSanitizer: heap-use-after-free on address 0x613000031f68 at pc 0x000008c82106 bp 0x7ffea3cd7190 sp 0x7ffea3cd7188 READ of size 8 at 0x613000031f68 thread T0 #0 0x8c82105 in begin buildtools/third_party/libc++/trunk/include/vector:1479:30 Igalia#1 0x8c82105 in begin<std::__1::vector<aura::WindowObserver *, std::__1::allocator<aura::WindowObserver *> > > buildtools/third_party/libc++/trunk/include/iterator:1670 Igalia#2 0x8c82105 in ContainsValue<std::__1::vector<aura::WindowObserver *, std::__1::allocator<aura::WindowObserver *> >, const aura::WindowObserver *, 0> base/stl_util.h:168 Igalia#3 0x8c82105 in HasObserver base/observer_list.h:267 Igalia#4 0x8c82105 in aura::Window::HasObserver(aura::WindowObserver const*) const ui/aura/window.cc:543 Igalia#5 0x8c9d363 in aura::WindowObserver::OnUnobservingWindow(aura::Window*) ui/aura/window_observer.cc:25:15 Igalia#6 0x8c799d7 in aura::Window::RemoveObserver(aura::WindowObserver*) ui/aura/window.cc:538:13 Igalia#7 0xc2f40e in RemoveAll ui/base/window_tracker_template.h:49:15 Igalia#8 0xc2f40e in ui::WindowTrackerTemplate<aura::Window, aura::WindowObserver>::~WindowTrackerTemplate() ui/base/window_tracker_template.h:33 Igalia#9 0x9225f3b in ~CompoundEventFilter ui/wm/core/compound_event_filter.cc:49:1 Igalia#10 0x9225f3b in wm::CompoundEventFilter::~CompoundEventFilter() ui/wm/core/compound_event_filter.cc:45 Igalia#11 0x6b0ae30 in operator() buildtools/third_party/libc++/trunk/include/memory:2321:5 Igalia#12 0x6b0ae30 in reset buildtools/third_party/libc++/trunk/include/memory:2634 Igalia#13 0x6b0ae30 in ~unique_ptr buildtools/third_party/libc++/trunk/include/memory:2588 Igalia#14 0x6b0ae30 in ash::Shell::~Shell() ash/shell.cc:969 Igalia#15 0x6b0c81d in ash::Shell::~Shell() ash/shell.cc:737:17 Igalia#16 0xc26b344 in ash::AshTestHelper::TearDown() ash/test/ash_test_helper.cc:294:3 Igalia#17 0xc26444c in ash::AshTestBase::TearDown() ash/test/ash_test_base.cc:192:21 Igalia#18 0x4724c64 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2682:11 Igalia#19 0x4726036 in testing::TestCase::Run() third_party/googletest/src/googletest/src/gtest.cc:2800:28 Igalia#20 0x474b566 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5124:43 Igalia#21 0x474a7b5 in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc Igalia#22 0x72b431a in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2331:46 Igalia#23 0x72b431a in base::TestSuite::Run() base/test/test_suite.cc:277 Igalia#24 0x72b9892 in Run base/callback.h:99:12 Igalia#25 0x72b9892 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) base/test/launcher/unit_test_launcher.cc:224 Igalia#26 0x72b9330 in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) base/test/launcher/unit_test_launcher.cc:575:10 Igalia#27 0x178df94 in main ash/test/ash_unittests.cc:37:10 Igalia#28 0x7f78e2b62f44 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287 0x613000031f68 is located 296 bytes inside of 328-byte region [0x613000031e40,0x613000031f88) freed by thread T0 here: #0 0x6b9062 in operator delete(void*) /b/swarming/w/ir/kitchen-workdir/src/third_party/llvm/compiler-rt/lib/asan/asan_new_delete.cc:167:3 Igalia#1 0x6a547a0 in ash::RootWindowController::CloseChildWindows() ash/root_window_controller.cc:498:7 Igalia#2 0x6b0c5cf in ash::Shell::CloseAllRootWindowChildWindows() ash/shell.cc:1387:19 Igalia#3 0x6b06637 in ash::Shell::~Shell() ash/shell.cc:837:3 Igalia#4 0x6b0c81d in ash::Shell::~Shell() ash/shell.cc:737:17 Igalia#5 0xc26b344 in ash::AshTestHelper::TearDown() ash/test/ash_test_helper.cc:294:3 Igalia#6 0xc26444c in ash::AshTestBase::TearDown() ash/test/ash_test_base.cc:192:21 Igalia#7 0x4724c64 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2682:11 Igalia#8 0x4726036 in testing::TestCase::Run() third_party/googletest/src/googletest/src/gtest.cc:2800:28 Igalia#9 0x474b566 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5124:43 Igalia#10 0x474a7b5 in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc Igalia#11 0x72b431a in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2331:46 Igalia#12 0x72b431a in base::TestSuite::Run() base/test/test_suite.cc:277 Igalia#13 0x72b9892 in Run base/callback.h:99:12 Igalia#14 0x72b9892 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) base/test/launcher/unit_test_launcher.cc:224 Igalia#15 0x72b9330 in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) base/test/launcher/unit_test_launcher.cc:575:10 Igalia#16 0x178df94 in main ash/test/ash_unittests.cc:37:10 Igalia#17 0x7f78e2b62f44 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287 previously allocated by thread T0 here: #0 0x6b8422 in operator new(unsigned long) /b/swarming/w/ir/kitchen-workdir/src/third_party/llvm/compiler-rt/lib/asan/asan_new_delete.cc:106:3 Igalia#1 0x91cb856 in views::NativeWidgetAura::NativeWidgetAura(views::internal::NativeWidgetDelegate*, bool, aura::Env*) ui/views/widget/native_widget_aura.cc:109:15 Igalia#2 0x91d615d in views::internal::NativeWidgetPrivate::CreateNativeWidget(views::Widget::InitParams const&, views::internal::NativeWidgetDelegate*) ui/views/widget/native_widget_aura.cc:1113:14 Igalia#3 0x917dabd in CreateNativeWidget ui/views/widget/widget.cc:73:10 Igalia#4 0x917dabd in views::Widget::Init(views::Widget::InitParams const&) ui/views/widget/widget.cc:334 Igalia#5 0x6af249a in ash::ShelfWidget::ShelfWidget(aura::Window*, ash::Shelf*) ash/shelf/shelf_widget.cc:216:3 Igalia#6 0x6a96eaa in ash::Shelf::CreateShelfWidget(aura::Window*) ash/shelf/shelf.cc:73:27 Igalia#7 0x6a5847a in ash::RootWindowController::InitLayoutManagers() ash/root_window_controller.cc:699:11 Igalia#8 0x6a52166 in ash::RootWindowController::Init(ash::RootWindowController::RootWindowType) ash/root_window_controller.cc:663:3 Igalia#9 0x68ef135 in ash::WindowTreeHostManager::InitHosts() ash/display/window_tree_host_manager.cc:238:3 Igalia#10 0x6afadce in ash::Shell::Init(ui::ContextFactory*, ui::ContextFactoryPrivate*, std::__1::unique_ptr<base::Value, std::__1::default_delete<base::Value> >, std::__1::unique_ptr<ui::ws2::GpuInterfaceProvider, std::__1::default_delete<ui::ws2::GpuInterfaceProvider> >) ash/shell.cc:1250:30 Igalia#11 0x6af7163 in ash::Shell::CreateInstance(ash::ShellInitParams) ash/shell.cc:276:14 Igalia#12 0xc26ac31 in ash::AshTestHelper::CreateShell() ash/test/ash_test_helper.cc:390:3 Igalia#13 0xc26a2a0 in ash::AshTestHelper::SetUp(bool, bool) ash/test/ash_test_helper.cc:245:3 Igalia#14 0xc263f8d in ash::AshTestBase::SetUp() ash/test/ash_test_base.cc:159:21 Igalia#15 0x1322b16 in ash::ShelfViewTest::SetUp() ash/shelf/shelf_view_unittest.cc:262:18 Igalia#16 0x1326366 in SetUp ash/shelf/shelf_view_unittest.cc:2369:20 Igalia#17 0x1326366 in ash::OverflowButtonInkDropTest::SetUp() ash/shelf/shelf_view_unittest.cc:2778 Igalia#18 0x4722b42 in testing::Test::Run() third_party/googletest/src/googletest/src/gtest.cc Igalia#19 0x4724c64 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2682:11 Igalia#20 0x4726036 in testing::TestCase::Run() third_party/googletest/src/googletest/src/gtest.cc:2800:28 Igalia#21 0x474b566 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5124:43 Igalia#22 0x474a7b5 in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc Igalia#23 0x72b431a in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2331:46 Igalia#24 0x72b431a in base::TestSuite::Run() base/test/test_suite.cc:277 Igalia#25 0x72b9892 in Run base/callback.h:99:12 Igalia#26 0x72b9892 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) base/test/launcher/unit_test_launcher.cc:224 Igalia#27 0x72b9330 in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) base/test/launcher/unit_test_launcher.cc:575:10 Igalia#28 0x178df94 in main ash/test/ash_unittests.cc:37:10 Igalia#29 0x7f78e2b62f44 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287 SUMMARY: AddressSanitizer: heap-use-after-free buildtools/third_party/libc++/trunk/include/vector:1479:30 in begin Shadow bytes around the buggy address: 0x0c267fffe390: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x0c267fffe3a0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x0c267fffe3b0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 fa 0x0c267fffe3c0: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd 0x0c267fffe3d0: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd =>0x0c267fffe3e0: fd fd fd fd fd fd fd fd fd fd fd fd fd[fd]fd fd 0x0c267fffe3f0: fd fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa 0x0c267fffe400: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd 0x0c267fffe410: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd 0x0c267fffe420: fd fd fd fd fd fd fd fd fd fd fd fd fa fa fa fa 0x0c267fffe430: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd Shadow byte legend (one shadow byte represents 8 application bytes): Addressable: 00 Partially addressable: 01 02 03 04 05 06 07 Heap left redzone: fa Freed heap region: fd Stack left redzone: f1 Stack mid redzone: f2 Stack right redzone: f3 Stack after return: f5 Stack use after scope: f8 Global redzone: f9 Global init order: f6 Poisoned by user: f7 Container overflow: fc Array cookie: ac Intra object redzone: bb ASan internal: fe Left alloca redzone: ca Right alloca redzone: cb Shadow gap: cc ==28149==ABORTING Original change's description: > cros: Enable touchable app context menus by default. > > This will enable: > - New context menu UI for: > - Application icons > - Shelf context menus > - Desktop context menus > > Note: > - Removed tests whose functionality were already being tested. > - MouseContextMenu already tests whether the ink drop is being > shown, so there is no need for > ShelfButtonShowsInkDropHighlightOnMenuShow. > > Bug: 871843 > Change-Id: I4c92ae52f75b25bc9edd1dd67778c4785d8f4058 > Reviewed-on: https://chromium-review.googlesource.com/1170985 > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Commit-Queue: Alex Newcomer <newcomer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#582978} TBR=xiyuan@chromium.org,sky@chromium.org,newcomer@chromium.org Change-Id: Ib85676861251f41c84f48f956d36c01edb353266 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 871843 Reviewed-on: https://chromium-review.googlesource.com/1174641 Reviewed-by: Chris Mumford <cmumford@chromium.org> Commit-Queue: Chris Mumford <cmumford@chromium.org> Cr-Commit-Position: refs/heads/master@{#583088}

This reverts commit e2c5501. Reason for revert: Causes ash_unittests regressions. This is NOT a speculative revert, as I've bisected to this commit and reproduced it locally. Please do not reland as is. Failing build: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/28629 Original change's description: > Reland "cros: Enable touchable app context menus by default." > > This reverts commit 32cd8fc. > > Reason for revert: Reverting the revert because this change was proven to not have caused the issue. > > Original change's description: > > Revert "cros: Enable touchable app context menus by default." > > > > This reverts commit b58ccf6. > > > > Reason for revert: Possibly introduced a use-after-free bug. > > > > This is a speculative fix for a use-after-free bug in two ash_unittests: > > > > 1. OverflowButtonInkDropTest.MouseContextMenu > > 2. OverflowButtonActiveInkDropTest.MouseContextMenu > > > > [ RUN ] OverflowButtonInkDropTest.MouseContextMenu > > ================================================================= > > ==28149==ERROR: AddressSanitizer: heap-use-after-free on address 0x613000031f68 at pc 0x000008c82106 bp 0x7ffea3cd7190 sp 0x7ffea3cd7188 > > READ of size 8 at 0x613000031f68 thread T0 > > #0 0x8c82105 in begin buildtools/third_party/libc++/trunk/include/vector:1479:30 > > Igalia#1 0x8c82105 in begin<std::__1::vector<aura::WindowObserver *, std::__1::allocator<aura::WindowObserver *> > > buildtools/third_party/libc++/trunk/include/iterator:1670 > > Igalia#2 0x8c82105 in ContainsValue<std::__1::vector<aura::WindowObserver *, std::__1::allocator<aura::WindowObserver *> >, const aura::WindowObserver *, 0> base/stl_util.h:168 > > Igalia#3 0x8c82105 in HasObserver base/observer_list.h:267 > > Igalia#4 0x8c82105 in aura::Window::HasObserver(aura::WindowObserver const*) const ui/aura/window.cc:543 > > Igalia#5 0x8c9d363 in aura::WindowObserver::OnUnobservingWindow(aura::Window*) ui/aura/window_observer.cc:25:15 > > Igalia#6 0x8c799d7 in aura::Window::RemoveObserver(aura::WindowObserver*) ui/aura/window.cc:538:13 > > Igalia#7 0xc2f40e in RemoveAll ui/base/window_tracker_template.h:49:15 > > Igalia#8 0xc2f40e in ui::WindowTrackerTemplate<aura::Window, aura::WindowObserver>::~WindowTrackerTemplate() ui/base/window_tracker_template.h:33 > > Igalia#9 0x9225f3b in ~CompoundEventFilter ui/wm/core/compound_event_filter.cc:49:1 > > Igalia#10 0x9225f3b in wm::CompoundEventFilter::~CompoundEventFilter() ui/wm/core/compound_event_filter.cc:45 > > Igalia#11 0x6b0ae30 in operator() buildtools/third_party/libc++/trunk/include/memory:2321:5 > > Igalia#12 0x6b0ae30 in reset buildtools/third_party/libc++/trunk/include/memory:2634 > > Igalia#13 0x6b0ae30 in ~unique_ptr buildtools/third_party/libc++/trunk/include/memory:2588 > > Igalia#14 0x6b0ae30 in ash::Shell::~Shell() ash/shell.cc:969 > > Igalia#15 0x6b0c81d in ash::Shell::~Shell() ash/shell.cc:737:17 > > Igalia#16 0xc26b344 in ash::AshTestHelper::TearDown() ash/test/ash_test_helper.cc:294:3 > > Igalia#17 0xc26444c in ash::AshTestBase::TearDown() ash/test/ash_test_base.cc:192:21 > > Igalia#18 0x4724c64 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2682:11 > > Igalia#19 0x4726036 in testing::TestCase::Run() third_party/googletest/src/googletest/src/gtest.cc:2800:28 > > Igalia#20 0x474b566 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5124:43 > > Igalia#21 0x474a7b5 in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc > > Igalia#22 0x72b431a in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2331:46 > > Igalia#23 0x72b431a in base::TestSuite::Run() base/test/test_suite.cc:277 > > Igalia#24 0x72b9892 in Run base/callback.h:99:12 > > Igalia#25 0x72b9892 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) base/test/launcher/unit_test_launcher.cc:224 > > Igalia#26 0x72b9330 in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) base/test/launcher/unit_test_launcher.cc:575:10 > > Igalia#27 0x178df94 in main ash/test/ash_unittests.cc:37:10 > > Igalia#28 0x7f78e2b62f44 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287 > > > > 0x613000031f68 is located 296 bytes inside of 328-byte region [0x613000031e40,0x613000031f88) > > freed by thread T0 here: > > #0 0x6b9062 in operator delete(void*) /b/swarming/w/ir/kitchen-workdir/src/third_party/llvm/compiler-rt/lib/asan/asan_new_delete.cc:167:3 > > Igalia#1 0x6a547a0 in ash::RootWindowController::CloseChildWindows() ash/root_window_controller.cc:498:7 > > Igalia#2 0x6b0c5cf in ash::Shell::CloseAllRootWindowChildWindows() ash/shell.cc:1387:19 > > Igalia#3 0x6b06637 in ash::Shell::~Shell() ash/shell.cc:837:3 > > Igalia#4 0x6b0c81d in ash::Shell::~Shell() ash/shell.cc:737:17 > > Igalia#5 0xc26b344 in ash::AshTestHelper::TearDown() ash/test/ash_test_helper.cc:294:3 > > Igalia#6 0xc26444c in ash::AshTestBase::TearDown() ash/test/ash_test_base.cc:192:21 > > Igalia#7 0x4724c64 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2682:11 > > Igalia#8 0x4726036 in testing::TestCase::Run() third_party/googletest/src/googletest/src/gtest.cc:2800:28 > > Igalia#9 0x474b566 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5124:43 > > Igalia#10 0x474a7b5 in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc > > Igalia#11 0x72b431a in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2331:46 > > Igalia#12 0x72b431a in base::TestSuite::Run() base/test/test_suite.cc:277 > > Igalia#13 0x72b9892 in Run base/callback.h:99:12 > > Igalia#14 0x72b9892 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) base/test/launcher/unit_test_launcher.cc:224 > > Igalia#15 0x72b9330 in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) base/test/launcher/unit_test_launcher.cc:575:10 > > Igalia#16 0x178df94 in main ash/test/ash_unittests.cc:37:10 > > Igalia#17 0x7f78e2b62f44 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287 > > > > previously allocated by thread T0 here: > > #0 0x6b8422 in operator new(unsigned long) /b/swarming/w/ir/kitchen-workdir/src/third_party/llvm/compiler-rt/lib/asan/asan_new_delete.cc:106:3 > > Igalia#1 0x91cb856 in views::NativeWidgetAura::NativeWidgetAura(views::internal::NativeWidgetDelegate*, bool, aura::Env*) ui/views/widget/native_widget_aura.cc:109:15 > > Igalia#2 0x91d615d in views::internal::NativeWidgetPrivate::CreateNativeWidget(views::Widget::InitParams const&, views::internal::NativeWidgetDelegate*) ui/views/widget/native_widget_aura.cc:1113:14 > > Igalia#3 0x917dabd in CreateNativeWidget ui/views/widget/widget.cc:73:10 > > Igalia#4 0x917dabd in views::Widget::Init(views::Widget::InitParams const&) ui/views/widget/widget.cc:334 > > Igalia#5 0x6af249a in ash::ShelfWidget::ShelfWidget(aura::Window*, ash::Shelf*) ash/shelf/shelf_widget.cc:216:3 > > Igalia#6 0x6a96eaa in ash::Shelf::CreateShelfWidget(aura::Window*) ash/shelf/shelf.cc:73:27 > > Igalia#7 0x6a5847a in ash::RootWindowController::InitLayoutManagers() ash/root_window_controller.cc:699:11 > > Igalia#8 0x6a52166 in ash::RootWindowController::Init(ash::RootWindowController::RootWindowType) ash/root_window_controller.cc:663:3 > > Igalia#9 0x68ef135 in ash::WindowTreeHostManager::InitHosts() ash/display/window_tree_host_manager.cc:238:3 > > Igalia#10 0x6afadce in ash::Shell::Init(ui::ContextFactory*, ui::ContextFactoryPrivate*, std::__1::unique_ptr<base::Value, std::__1::default_delete<base::Value> >, std::__1::unique_ptr<ui::ws2::GpuInterfaceProvider, std::__1::default_delete<ui::ws2::GpuInterfaceProvider> >) ash/shell.cc:1250:30 > > Igalia#11 0x6af7163 in ash::Shell::CreateInstance(ash::ShellInitParams) ash/shell.cc:276:14 > > Igalia#12 0xc26ac31 in ash::AshTestHelper::CreateShell() ash/test/ash_test_helper.cc:390:3 > > Igalia#13 0xc26a2a0 in ash::AshTestHelper::SetUp(bool, bool) ash/test/ash_test_helper.cc:245:3 > > Igalia#14 0xc263f8d in ash::AshTestBase::SetUp() ash/test/ash_test_base.cc:159:21 > > Igalia#15 0x1322b16 in ash::ShelfViewTest::SetUp() ash/shelf/shelf_view_unittest.cc:262:18 > > Igalia#16 0x1326366 in SetUp ash/shelf/shelf_view_unittest.cc:2369:20 > > Igalia#17 0x1326366 in ash::OverflowButtonInkDropTest::SetUp() ash/shelf/shelf_view_unittest.cc:2778 > > Igalia#18 0x4722b42 in testing::Test::Run() third_party/googletest/src/googletest/src/gtest.cc > > Igalia#19 0x4724c64 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2682:11 > > Igalia#20 0x4726036 in testing::TestCase::Run() third_party/googletest/src/googletest/src/gtest.cc:2800:28 > > Igalia#21 0x474b566 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5124:43 > > Igalia#22 0x474a7b5 in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc > > Igalia#23 0x72b431a in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2331:46 > > Igalia#24 0x72b431a in base::TestSuite::Run() base/test/test_suite.cc:277 > > Igalia#25 0x72b9892 in Run base/callback.h:99:12 > > Igalia#26 0x72b9892 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) base/test/launcher/unit_test_launcher.cc:224 > > Igalia#27 0x72b9330 in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) base/test/launcher/unit_test_launcher.cc:575:10 > > Igalia#28 0x178df94 in main ash/test/ash_unittests.cc:37:10 > > Igalia#29 0x7f78e2b62f44 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287 > > > > SUMMARY: AddressSanitizer: heap-use-after-free buildtools/third_party/libc++/trunk/include/vector:1479:30 in begin > > Shadow bytes around the buggy address: > > 0x0c267fffe390: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 > > 0x0c267fffe3a0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 > > 0x0c267fffe3b0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 fa > > 0x0c267fffe3c0: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd > > 0x0c267fffe3d0: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd > > =>0x0c267fffe3e0: fd fd fd fd fd fd fd fd fd fd fd fd fd[fd]fd fd > > 0x0c267fffe3f0: fd fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa > > 0x0c267fffe400: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd > > 0x0c267fffe410: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd > > 0x0c267fffe420: fd fd fd fd fd fd fd fd fd fd fd fd fa fa fa fa > > 0x0c267fffe430: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd > > Shadow byte legend (one shadow byte represents 8 application bytes): > > Addressable: 00 > > Partially addressable: 01 02 03 04 05 06 07 > > Heap left redzone: fa > > Freed heap region: fd > > Stack left redzone: f1 > > Stack mid redzone: f2 > > Stack right redzone: f3 > > Stack after return: f5 > > Stack use after scope: f8 > > Global redzone: f9 > > Global init order: f6 > > Poisoned by user: f7 > > Container overflow: fc > > Array cookie: ac > > Intra object redzone: bb > > ASan internal: fe > > Left alloca redzone: ca > > Right alloca redzone: cb > > Shadow gap: cc > > ==28149==ABORTING > > > > Original change's description: > > > cros: Enable touchable app context menus by default. > > > > > > This will enable: > > > - New context menu UI for: > > > - Application icons > > > - Shelf context menus > > > - Desktop context menus > > > > > > Note: > > > - Removed tests whose functionality were already being tested. > > > - MouseContextMenu already tests whether the ink drop is being > > > shown, so there is no need for > > > ShelfButtonShowsInkDropHighlightOnMenuShow. > > > > > > Bug: 871843 > > > Change-Id: I4c92ae52f75b25bc9edd1dd67778c4785d8f4058 > > > Reviewed-on: https://chromium-review.googlesource.com/1170985 > > > Reviewed-by: Scott Violet <sky@chromium.org> > > > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > > > Commit-Queue: Alex Newcomer <newcomer@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#582978} > > > > TBR=xiyuan@chromium.org,sky@chromium.org,newcomer@chromium.org > > > > Change-Id: Ib85676861251f41c84f48f956d36c01edb353266 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 871843 > > Reviewed-on: https://chromium-review.googlesource.com/1174641 > > Reviewed-by: Chris Mumford <cmumford@chromium.org> > > Commit-Queue: Chris Mumford <cmumford@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#583088} > > TBR=xiyuan@chromium.org,sky@chromium.org,cmumford@chromium.org,newcomer@chromium.org > > Change-Id: I4edeef479d40e1e591ac906aa89ede363668b6a3 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 871843 > Reviewed-on: https://chromium-review.googlesource.com/1174777 > Reviewed-by: Alex Newcomer <newcomer@chromium.org> > Commit-Queue: Alex Newcomer <newcomer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#583310} TBR=xiyuan@chromium.org,sky@chromium.org,cmumford@chromium.org,newcomer@chromium.org Change-Id: I8398745c9037fb5be605069646b3a655519d023e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 871843 Reviewed-on: https://chromium-review.googlesource.com/1177482 Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#583619}

This reverts commit e6df634. Reason for revert: Suspect WebKit Linux Trusty MSAN failures: https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20MSAN/9778 crash log for content_shell (pid 19555): STDOUT: <empty> STDERR: [1:16:0903/135605.516164:ERROR:adm_helpers.cc(73)] Failed to query stereo recording. STDERR: CONSOLE WARNING: line 371: The Web Audio autoplay policy will be re-enabled in Chrome 70 (October 2018). Please check that your website is compatible with it. https://goo.gl/7K7WLu STDERR: ==19555==WARNING: MemorySanitizer: use-of-uninitialized-value STDERR: #0 0x119c0a99 in network::P2PSocketUdp::HandleReadResult(int) ./../../services/network/p2p/socket_udp.cc:231:9 STDERR: #1 0x119bf30b in network::P2PSocketUdp::OnRecv(int) ./../../services/network/p2p/socket_udp.cc:202:3 STDERR: #2 0xc8cd202 in Run ./../../base/callback.h:99:12 STDERR: #3 0xc8cd202 in DoReadCallback ./../../net/socket/udp_socket_posix.cc:690:0 STDERR: #4 0xc8cd202 in net::UDPSocketPosix::DidCompleteRead() ./../../net/socket/udp_socket_posix.cc:711:0 STDERR: #5 0xc8cc98d in net::UDPSocketPosix::ReadWatcher::OnFileCanReadWithoutBlocking(int) ./../../net/socket/udp_socket_posix.cc:676:14 STDERR: #6 0xb3aa2ec in base::MessagePumpLibevent::OnLibeventNotification(int, short, void*) ./../../base/message_loop/message_pump_libevent.cc:0:13 STDERR: #7 0xb3c2bd6 in event_process_active ./../../base/third_party/libevent/event.c:381:4 STDERR: #8 0xb3c2bd6 in event_base_loop ./../../base/third_party/libevent/event.c:521:0 STDERR: #9 0xb3aaf3e in base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) ./../../base/message_loop/message_pump_libevent.cc:214:5 STDERR: #10 0xb12a9ff in base::RunLoop::Run() ./../../base/run_loop.cc:102:14 STDERR: #11 0x8655f3e in content::BrowserProcessSubThread::IOThreadRun(base::RunLoop*) ./../../content/browser/browser_process_sub_thread.cc:175:11 STDERR: #12 0xb26ea58 in base::Thread::ThreadMain() ./../../base/threading/thread.cc:357:3 STDERR: #13 0xb39a887 in base::(anonymous namespace)::ThreadFunc(void*) ./../../base/threading/platform_thread_posix.cc:76:13 STDERR: #14 0x7ffa170eb183 in start_thread /build/eglibc-ripdx6/eglibc-2.19/nptl/pthread_create.c:312:0 STDERR: #15 0x7ffa0fa3703c in clone /build/eglibc-ripdx6/eglibc-2.19/misc/../sysdeps/unix/sysv/linux/x86_64/clone.S:111:0 STDERR: STDERR: Uninitialized value was created by a heap allocation STDERR: #0 0x1ab9a79 in operator new(unsigned long) /b/swarming/w/ir/kitchen-workdir/src/third_party/llvm/compiler-rt/lib/msan/msan_new_delete.cc:46:35 STDERR: #1 0x119a51de in network::P2PSocket::Create(network::P2PSocket::Delegate*, mojo::InterfacePtr<network::mojom::P2PSocketClient>, mojo::InterfaceRequest<network::mojom::P2PSocket>, network::P2PSocketType, net::NetLog*, network::ProxyResolvingClientSocketFactory*, network::P2PMessageThrottler*) ./../../services/network/p2p/socket.cc:173:14 STDERR: #2 0x1198d68c in network::P2PSocketManager::CreateSocket(network::P2PSocketType, net::IPEndPoint const&, network::P2PPortRange const&, network::P2PHostAndIPEndPoint const&, mojo::InterfacePtr<network::mojom::P2PSocketClient>, mojo::InterfaceRequest<network::mojom::P2PSocket>) ./../../services/network/p2p/socket_manager.cc:294:7 STDERR: #3 0x1e6127b in network::mojom::P2PSocketManagerStubDispatch::Accept(network::mojom::P2PSocketManager*, mojo::Message*) ./gen/services/network/public/mojom/p2p.mojom.cc:1105:13 STDERR: #4 0x11991146 in network::mojom::P2PSocketManagerStub<mojo::RawPtrImplRefTraits<network::mojom::P2PSocketManager> >::Accept(mojo::Message*) ./gen/services/network/public/mojom/p2p.mojom.h:446:12 STDERR: #5 0xb407929 in mojo::InterfaceEndpointClient::HandleValidatedMessage(mojo::Message*) ./../../mojo/public/cpp/bindings/lib/interface_endpoint_client.cc:423:32 STDERR: #6 0xb4056da in mojo::FilterChain::Accept(mojo::Message*) ./../../mojo/public/cpp/bindings/lib/filter_chain.cc:40:17 STDERR: #7 0xb421df5 in mojo::internal::MultiplexRouter::ProcessIncomingMessage(mojo::internal::MultiplexRouter::MessageWrapper*, mojo::internal::MultiplexRouter::ClientCallBehavior, base::SequencedTaskRunner*) ./../../mojo/public/cpp/bindings/lib/multiplex_router.cc:869:42 STDERR: #8 0xb41f60d in mojo::internal::MultiplexRouter::Accept(mojo::Message*) ./../../mojo/public/cpp/bindings/lib/multiplex_router.cc:590:38 STDERR: #9 0xb4056da in mojo::FilterChain::Accept(mojo::Message*) ./../../mojo/public/cpp/bindings/lib/filter_chain.cc:40:17 STDERR: #10 0xb3fdbc2 in mojo::Connector::ReadSingleMessage(unsigned int*) ./../../mojo/public/cpp/bindings/lib/connector.cc:457:51 STDERR: #11 0xb400300 in mojo::Connector::ReadAllAvailableMessages() ./../../mojo/public/cpp/bindings/lib/connector.cc:486:10 STDERR: #12 0xb3e106b in Run ./../../base/callback.h:129:12 STDERR: #13 0xb3e106b in mojo::SimpleWatcher::OnHandleReady(int, unsigned int, mojo::HandleSignalsState const&) ./../../mojo/public/cpp/system/simple_watcher.cc:273:0 STDERR: #14 0xb3e1a6c in mojo::SimpleWatcher::Context::Notify(unsigned int, MojoHandleSignalsState, unsigned int) ./../../mojo/public/cpp/system/simple_watcher.cc:105:22 STDERR: #15 0xb3de578 in mojo::SimpleWatcher::Context::CallNotify(MojoTrapEvent const*) ./../../mojo/public/cpp/system/simple_watcher.cc:55:14 STDERR: #16 0x46bbfd7 in mojo::core::WatcherDispatcher::InvokeWatchCallback(unsigned long, unsigned int, mojo::core::HandleSignalsState const&, unsigned int) ./../../mojo/core/watcher_dispatcher.cc:90:3 STDERR: #17 0x46b9935 in mojo::core::Watch::InvokeCallback(unsigned int, mojo::core::HandleSignalsState const&, unsigned int) ./../../mojo/core/watch.cc:78:13 STDERR: #18 0x46a4715 in mojo::core::RequestContext::~RequestContext() ./../../mojo/core/request_context.cc:72:20 STDERR: #19 0x466c618 in mojo::core::NodeChannel::OnChannelMessage(void const*, unsigned long, std::__1::vector<mojo::PlatformHandle, std::__1::allocator<mojo::PlatformHandle> >) ./../../mojo/core/node_channel.cc:695:1 STDERR: #20 0x461c6a4 in mojo::core::Channel::OnReadComplete(unsigned long, unsigned long*) ./../../mojo/core/channel.cc:714:18 STDERR: STDERR: SUMMARY: MemorySanitizer: use-of-uninitialized-value (/b/s/w/ir/out/Release/content_shell+0x119c0a99) STDERR: Exiting STDERR: [19588:19588:0903/135606.482234:WARNING:x11_util.cc(1391)] X error received: serial 170, error_code 3 (BadWindow), request_code 4, minor_code 0 (Unknown) Original change's description: > Cleanup lifetime handling in P2P sockets. > > Several fixes for P2P sockets: > 1. P2PSocketTcpBase no longer posts tasks with base::Unretained(). > 2. Previously P2P sockets were destroyed only in response to Mojo > interfaces errors. They were not destroyed on other error. Fixed > it now. > 3. Simplified TCP server socket protocol. Now the accepted socket is > passed directly in IncomingTcpConnection. > 4. Updated unittests to verify that P2P sockets are destroyed in > response to errors. > 5. Other minor cleanups, particularly moved packet dump logic to > SocketManager and removed some unittests that are not relevant > after migration to mojo. > > Bug: 877515, 877514 > Cq-Include-Trybots: luci.chromium.try:linux_mojo > Change-Id: I55276e372185c558667289a1efdfcf0421c3d7bc > Reviewed-on: https://chromium-review.googlesource.com/1189083 > Reviewed-by: Nasko Oskov <nasko@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#588430} TBR=nasko@chromium.org,jam@chromium.org,mmenke@chromium.org,sergeyu@chromium.org Change-Id: I33bfb1c8127a945df37fd8bf9efda681a739095e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 877515, 877514 Cq-Include-Trybots: luci.chromium.try:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/1203492 Reviewed-by: Takashi Sakamoto <tasak@google.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#588440}

content_browsertests failures: RenderFrameHostImplBrowserTest.BeforeUnloadDialogSuppressedForDiscard RenderFrameHostImplBrowserTest.PendingDialogMakesDiscardUnloadReturnFalse ==3811==WARNING: MemorySanitizer: use-of-uninitialized-value #0 0xbc166ad in content::RenderFrameHostManager::OnBeforeUnloadACK(bool, base::TimeTicks const&) ./../../content/browser/frame_host/render_frame_host_manager.cc:215:7 #1 0xbbdbca8 in operator() ./../../content/browser/frame_host/render_frame_host_impl.cc:2079:54 #2 0xbbdbca8 in Invoke<(lambda at ../../content/browser/frame_host/render_frame_host_impl.cc:2075:9), base::WeakPtr<content::RenderFrameHostImpl>, base::TimeTicks, bool> ./../../base/bind_internal.h:403:0 #3 0xbbdbca8 in MakeItSo<(lambda at ../../content/browser/frame_host/render_frame_host_impl.cc:2075:9), base::WeakPtr<content::RenderFrameHostImpl>, base::TimeTicks, bool> ./../../base/bind_internal.h:616:0 #4 0xbbdbca8 in RunImpl<(lambda at ../../content/browser/frame_host/render_frame_host_impl.cc:2075:9), std::__1::tuple<base::WeakPtr<content::RenderFrameHostImpl>, base::TimeTicks, bool>, 0, 1, 2> ./../../base/bind_internal.h:689:0 #5 0xbbdbca8 in base::internal::Invoker<base::internal::BindState<content::RenderFrameHostImpl::ProcessBeforeUnloadACKFromFrame(bool, bool, content::RenderFrameHostImpl*, bool, base::TimeTicks const&, base::TimeTicks const&)::$_0, base::WeakPtr<content::RenderFrameHostImpl>, base::TimeTicks, bool>, void ()>::RunOnce(base::internal::BindStateBase*) ./../../base/bind_internal.h:658:0 #6 0xbb36c00 in Run ./../../base/callback.h:99:12 #7 0xbb36c00 in content::RenderFrameHostImpl::ProcessBeforeUnloadACKFromFrame(bool, bool, content::RenderFrameHostImpl*, bool, base::TimeTicks const&, base::TimeTicks const&) ./../../content/browser/frame_host/render_frame_host_impl.cc:2087:0 Change-Id: I6ccc7f48accb2595665691ced6d415eb1777ba68 Reviewed-on: https://chromium-review.googlesource.com/1220869 Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#590583}

…enChanged() When running in single threaded mode, calls from OnBeginImplFrameDeadline() can make their way from the main thread to the impl thread, and then (erroneously) directly back to the main thread, causing a crash. See the stack trace below. With this CL, the call from viz::HostFrameSinkManager::OnFrameTokenChanged() is proxied back to the main thread for the call to content::DelegatedFrameHost::OnFrameTokenChanged(). A number of tests also call FrameSinkManagerImpl::SetLocalClient and/or surface_utils::ConnectWithLocalFrameSinkManager, and I did not want to change their existing behavior. So the additional task_runner parameter is defaulted to nullptr, and in that case the old behavior still applies - the call is not PostTasked. Example crash: [243567:243567:1023/120428.757147:FATAL:single_thread_proxy.cc(239)] Check failed: task_runner_provider_->IsMainThread(). #0 0x7f4d3b3bbccd base::debug::StackTrace::StackTrace() #1 0x7f4d3b0b8a2a base::debug::StackTrace::StackTrace() #2 0x7f4d3b12a59b logging::LogMessage::~LogMessage() #3 0x7f4d315b4e9b cc::SingleThreadProxy::SetNeedsCommit() #4 0x7f4d3149b8ef cc::LayerTreeHost::SetNeedsCommit() #5 0x7f4d312b28f1 cc::Layer::SetNeedsCommit() #6 0x7f4d312b8205 cc::Layer::SetBackgroundColor() #7 0x7f4d2cb5fd54 ui::Layer::SetColorFromAnimation() #8 0x7f4d2cb79024 ui::LayerAnimator::SetColor() #9 0x7f4d2cb56a5c ui::Layer::SetColor() #10 0x7f4d37f1b8a1 content::RenderWidgetHostViewAura::UpdateBackgroundColor() #11 0x7f4d37f2851e content::RenderWidgetHostViewBase::SetContentBackgroundColor() #12 0x7f4d37f222cb content::RenderWidgetHostViewAura::OnRenderFrameMetadataChangedAfterActivation() #13 0x7f4d37e81d5c content::RenderFrameMetadataProviderImpl::OnRenderFrameMetadataChangedAfterActivation() #14 0x7f4d37e8391f _ZN4base8internal13FunctorTraitsIMN7content31RenderFrameMetadataProviderImplEFvN2cc19RenderFrameMetadataEEvE6InvokeIS7_NS_7WeakPtrIS3_EEJS5_EEEvT_OT0_DpOT1_ #15 0x7f4d37e83805 _ZN4base8internal12InvokeHelperILb1EvE8MakeItSoIMN7content31RenderFrameMetadataProviderImplEFvN2cc19RenderFrameMetadataEENS_7WeakPtrIS5_EEJS7_EEEvOT_OT0_DpOT1_ #16 0x7f4d37e8377d _ZN4base8internal7InvokerINS0_9BindStateIMN7content31RenderFrameMetadataProviderImplEFvN2cc19RenderFrameMetadataEEJNS_7WeakPtrIS4_EES6_EEEFvvEE7RunImplIS8_NSt3__15tupleIJSA_S6_EEEJLm0ELm1EEEEvOT_OT0_NSF_16integer_sequenceImJXspT1_EEEE #17 0x7f4d37e836f9 _ZN4base8internal7InvokerINS0_9BindStateIMN7content31RenderFrameMetadataProviderImplEFvN2cc19RenderFrameMetadataEEJNS_7WeakPtrIS4_EES6_EEEFvvEE7RunOnceEPNS0_13BindStateBaseE #18 0x7f4d35ecd92e _ZNO4base12OnceCallbackIFvvEE3RunEv #19 0x7f4d37d2d8a3 content::FrameTokenMessageQueue::DidProcessFrame() #20 0x7f4d37ef17cd content::RenderWidgetHostImpl::DidProcessFrame() #21 0x7f4d37f2aeaa content::RenderWidgetHostViewBase::OnFrameTokenChangedForView() #22 0x7f4d3845b99f content::DelegatedFrameHostClientAura::OnFrameTokenChanged() #23 0x7f4d38483f90 content::DelegatedFrameHost::OnFrameTokenChanged() #24 0x7f4d1aaa7e8c viz::HostFrameSinkManager::OnFrameTokenChanged() #25 0x7f4d1b5b41dc viz::FrameSinkManagerImpl::OnFrameTokenChanged() #26 0x7f4d1b59594e viz::CompositorFrameSinkSupport::OnFrameTokenChanged() #27 0x7f4d1b61ab83 viz::Surface::ActivateFrame() #28 0x7f4d1b61920f viz::Surface::ActivatePendingFrame() #29 0x7f4d1b618f2a viz::Surface::OnSurfaceDependencyAdded() #30 0x7f4d1b62e241 viz::SurfaceDependencyTracker::OnSurfaceDependencyAdded() #31 0x7f4d1b6432ac viz::SurfaceManager::SurfaceDependencyAdded() #32 0x7f4d1b619b7f viz::Surface::UpdateActivationDependencies() #33 0x7f4d1b6194f3 viz::Surface::QueueFrame() #34 0x7f4d1b59a155 viz::CompositorFrameSinkSupport::MaybeSubmitCompositorFrameInternal() #35 0x7f4d1b598206 viz::CompositorFrameSinkSupport::MaybeSubmitCompositorFrame() #36 0x7f4d1b59801a viz::CompositorFrameSinkSupport::SubmitCompositorFrame() #37 0x7f4d1b5a4b08 viz::DirectLayerTreeFrameSink::SubmitCompositorFrame() #38 0x7f4d314d8e24 cc::LayerTreeHostImpl::DrawLayers() #39 0x7f4d315b8ee8 cc::SingleThreadProxy::DoComposite() #40 0x7f4d315bb087 cc::SingleThreadProxy::ScheduledActionDrawIfPossible() #41 0x7f4d3139c9b8 cc::Scheduler::DrawIfPossible() #42 0x7f4d31396581 cc::Scheduler::ProcessScheduledActions() #43 0x7f4d3139c7da cc::Scheduler::OnBeginImplFrameDeadline() #44 0x7f4d313a024d _ZN4base8internal13FunctorTraitsIMN2cc9SchedulerEFvvEvE6InvokeIS5_PS3_JEEEvT_OT0_DpOT1_ #45 0x7f4d313a0194 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIMN2cc9SchedulerEFvvEJPS5_EEEvOT_DpOT0_ #46 0x7f4d313a0145 _ZN4base8internal7InvokerINS0_9BindStateIMN2cc9SchedulerEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE7RunImplIS6_NSt3__15tupleIJS8_EEEJLm0EEEEvOT_OT0_NSD_16integer_sequenceImJXspT1_EEEE #47 0x7f4d313a0089 _ZN4base8internal7InvokerINS0_9BindStateIMN2cc9SchedulerEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE7RunOnceEPNS0_13BindStateBaseE #48 0x7f4d313a059e _ZNO4base12OnceCallbackIFvvEE3RunEv #49 0x7f4d313a0544 _ZN4base8internal22CancelableCallbackImplINS_12OnceCallbackIFvvEEEE11ForwardOnceIJEEEvDpT_ #50 0x7f4d3129de9f _ZN4base8internal13FunctorTraitsIMN2cc28ScrollbarAnimationControllerEFvvEvE6InvokeIS5_RKNS_7WeakPtrIS3_EEJEEEvT_OT0_DpOT1_ #51 0x7f4d3129de1a _ZN4base8internal12InvokeHelperILb1EvE8MakeItSoIRKMN2cc28ScrollbarAnimationControllerEFvvERKNS_7WeakPtrIS5_EEJEEEvOT_OT0_DpOT1_ #52 0x7f4d3129ddb0 _ZN4base8internal7InvokerINS0_9BindStateIMN2cc28ScrollbarAnimationControllerEFvvEJNS_7WeakPtrIS4_EEEEEFvvEE7RunImplIRKS6_RKNSt3__15tupleIJS8_EEEJLm0EEEEvOT_OT0_NSF_16integer_sequenceImJXspT1_EEEE #53 0x7f4d3137d0d9 _ZN4base8internal7InvokerINS0_9BindStateIMN2cc12ResourcePoolEFvvEJNS_7WeakPtrIS4_EEEEEFvvEE7RunOnceEPNS0_13BindStateBaseE #54 0x7f4d3b0683ee _ZNO4base12OnceCallbackIFvvEE3RunEv #55 0x7f4d3b0ba072 base::debug::TaskAnnotator::RunTask() #56 0x7f4d3b14f466 base::MessageLoop::RunTask() #57 0x7f4d3b14f7ee base::MessageLoop::DeferOrRunPendingTask() #58 0x7f4d3b14fc79 base::MessageLoop::DoWork() #59 0x7f4d3b1572b6 base::MessagePumpGlib::Run() #60 0x7f4d3b14eb5b base::MessageLoop::Run() #61 0x7f4d3b1fac6d base::RunLoop::Run() #62 0x7f4d372f8dfc content::BrowserMainLoop::MainMessageLoopRun() #63 0x7f4d372f8a52 content::BrowserMainLoop::RunMainMessageLoopParts() #64 0x7f4d37301050 content::BrowserMainRunnerImpl::Run() #65 0x0000018caad1 (anonymous namespace)::RunOneTest() #66 0x0000018ca696 (anonymous namespace)::RunTests() #67 0x0000018ca11d LayoutTestBrowserMain() #68 0x0000018c82c0 content::ShellMainDelegate::RunProcess() #69 0x7f4d39305d5a content::RunBrowserProcessMain() #70 0x7f4d39308bc7 content::ContentMainRunnerImpl::Run() #71 0x7f4d392feabc content::ContentServiceManagerMainDelegate::RunEmbedderProcess() #72 0x7f4d13359c2a service_manager::Main() #73 0x7f4d393034b3 content::ContentMain() #74 0x00000075e165 main #75 0x7f4d13dcd2b1 __libc_start_main #76 0x00000075e02a _start Bug: 667551 Change-Id: Iab72ad842b4672f7c3e37060bd2085b2d8ce0803 Reviewed-on: https://chromium-review.googlesource.com/c/1297477 Reviewed-by: Charlie Reis <creis@chromium.org> Reviewed-by: enne <enne@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#602912}

…st_shield" This reverts commit 0b10763. Reason for revert: Suspect Linux ChromiumOS MSan Tests failures: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20ChromiumOS%20MSan%20Tests/9258 One of error logs: [ RUN ] LockStateControllerTest.LockButtonBasicGuest ==6821==ERROR: AddressSanitizer: heap-use-after-free on address 0x616000005c58 at pc 0x000007937b9c bp 0x7ffdd8818530 sp 0x7ffdd8818528 READ of size 8 at 0x616000005c58 thread T0 #0 0x7937b9b in begin buildtools/third_party/libc++/trunk/include/vector:1506:30 #1 0x7937b9b in base::ObserverList<ash::TabletModeObserver, false, true, base::internal::UncheckedObserverAdapter>::RemoveObserver(ash::TabletModeObserver const*) base/observer_list.h:282 #2 0x73376c6 in RemoveAll base/scoped_observer.h:45:20 #3 0x73376c6 in ScopedObserver<ash::TabletModeController, ash::TabletModeObserver>::~ScopedObserver() base/scoped_observer.h:26 #4 0x7889542 in ~WallpaperView ash/wallpaper/wallpaper_view.cc:150:1 #5 0x7889542 in ash::WallpaperView::~WallpaperView() ash/wallpaper/wallpaper_view.cc:148 #6 0x9a96a66 in views::View::~View() ui/views/view.cc:162:9 #7 0x788c19d in ash::(anonymous namespace)::LayerControlView::~LayerControlView() ash/wallpaper/wallpaper_view.cc:43:7 #8 0x9a9b800 in operator() buildtools/third_party/libc++/trunk/include/memory:2325:5 #9 0x9a9b800 in reset buildtools/third_party/libc++/trunk/include/memory:2638 #10 0x9a9b800 in ~unique_ptr buildtools/third_party/libc++/trunk/include/memory:2592 #11 0x9a9b800 in views::View::DoRemoveChildView(views::View*, bool, bool, bool, views::View*) ui/views/view.cc:2053 #12 0x9a9d418 in views::View::RemoveAllChildViews(bool) ui/views/view.cc:300:5 #13 0x9ac9585 in views::internal::RootView::~RootView() ui/views/widget/root_view.cc:183:5 #14 0x9ac973d in views::internal::RootView::~RootView() ui/views/widget/root_view.cc:179:23 #15 0x9ad351b in operator() buildtools/third_party/libc++/trunk/include/memory:2325:5 #16 0x9ad351b in reset buildtools/third_party/libc++/trunk/include/memory:2638 #17 0x9ad351b in DestroyRootView ui/views/widget/widget.cc:1456 #18 0x9ad351b in views::Widget::~Widget() ui/views/widget/widget.cc:187 #19 0x9ad455d in views::Widget::~Widget() ui/views/widget/widget.cc:186:19 #20 0x9b2bb12 in views::NativeWidgetAura::~NativeWidgetAura() ui/views/widget/native_widget_aura.cc #21 0x9b2bdad in views::NativeWidgetAura::~NativeWidgetAura() ui/views/widget/native_widget_aura.cc:1034:39 #22 0x95945c5 in aura::Window::~Window() ui/aura/window.cc:139:16 #23 0x95960ad in aura::Window::~Window() ui/aura/window.cc:94:19 Original change's description: > Makes wallpaper dim in tablet mode, without relying on app_list_shield > > Bug: 898712 > Change-Id: I96ba08fec3f7df8547d753ff4d31366345be0ac8 > Reviewed-on: https://chromium-review.googlesource.com/c/1298507 > Reviewed-by: Weidong Guo <weidongg@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Commit-Queue: Kevin Strohbehn <ginko@google.com> > Cr-Commit-Position: refs/heads/master@{#602938} TBR=xiyuan@chromium.org,weidongg@chromium.org,ginko@google.com Change-Id: I86dbf4da685e23e5106ac7a778e665729581e0ea No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 898712 Reviewed-on: https://chromium-review.googlesource.com/c/1301035 Reviewed-by: Takashi Sakamoto <tasak@google.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#602991}

This reverts commit 4df3f6e. Reason for revert: This CL causes crash in RasterCommandBufferStub. The raster decoder still uses GL context and GL APIs even with vulkan. Before removing the GL contect for vulkan, we need remove all unnecessary GL context usage and GL calls for raster decoder. #0 0x55d1ec37f6ef base::debug::StackTrace::StackTrace() #1 0x55d1ec37f261 base::debug::(anonymous namespace)::StackDumpSignalHandler() #2 0x7fe55e62d0c0 <unknown> #3 0x55d1ed30103e gpu::RasterCommandBufferStub::Initialize() #4 0x55d1ed25f35c gpu::GpuChannel::OnCreateCommandBuffer() #5 0x55d1ed25ed0a bool IPC::MessageT<GpuChannelMsg_CreateCommandBuffer_Meta, std::__1::tuple<GPUCreateCommandBufferConfig, int, base::UnsafeSharedMemoryRegion>, std::__1::tuple<gpu::ContextResult, gpu::Capabilities> >::Dispatch<gpu::GpuChannel, gpu::GpuChannel, void, void (gpu::GpuChannel::*)(GPUCreateCommandBufferConfig const&, int, base::UnsafeSharedMemoryRegion, gpu::ContextResult*, gpu::Capabilities*)>(IPC::Message const*, gpu::GpuChannel*, gpu::GpuChannel*, void*, void (gpu::GpuChannel::*)(GPUCreateCommandBufferConfig const&, int, base::UnsafeSharedMemoryRegion, gpu::ContextResult*, gpu::Capabilities*)) #6 0x55d1ed25fcc4 gpu::GpuChannel::HandleMessageHelper() #7 0x55d1ec3058f1 base::debug::TaskAnnotator::RunTask() #8 0x55d1ec3050af base::MessageLoop::RunTask() #9 0x55d1ec305432 base::MessageLoop::DoWork() #10 0x55d1ec30743f base::(anonymous namespace)::WorkSourceDispatch() #11 0x7fe55def6fc7 g_main_context_dispatch #12 0x7fe55def7200 <unknown> #13 0x7fe55def728c g_main_context_iteration #14 0x55d1ec3072f2 base::MessagePumpGlib::Run() #15 0x55d1ec31fba5 base::RunLoop::Run() #16 0x55d1eeaedd3c content::GpuMain() #17 0x55d1ebb80562 content::ContentMainRunnerImpl::Run() #18 0x55d1ed68984c service_manager::Main() #19 0x55d1eb1d6081 content::ContentMain() #20 0x55d1ea8e316b main #21 0x7fe559a992b1 __libc_start_main #22 0x55d1ea8e302a _start Original change's description: > Add VulkanContextProvider to RasterDecoderContextState. > > Add VulkanContextProvider to RasterDecoderContextState which is needed > to get VkDevice in shareable image. Refactor RasterDecoderContextState > class to have seperate constructors for Vulkan and GL. > > Bug: 891060 > Change-Id: I0ca7e657d33fdcfa62ab6465f7023a914610b7ce > Reviewed-on: https://chromium-review.googlesource.com/c/1312194 > Commit-Queue: vikas soni <vikassoni@chromium.org> > Reviewed-by: Eric Karl <ericrk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#605146} TBR=ericrk@chromium.org,vikassoni@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 891060 Change-Id: I4ceebc7033b4bd74e643a5f89bbbd6791b3eb6c0 Reviewed-on: https://chromium-review.googlesource.com/c/1318073 Reviewed-by: Peng Huang <penghuang@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#605376}

…mode" This reverts commit dcb55ce. Reason for revert: Appears to cause crashes in LoginCursorTest.CursorHidden. See https://chromium-swarm.appspot.com/task?id=410f91874d359810&refresh=10&show_raw=1: BrowserTestBase received signal: Segmentation fault. Backtrace: #0 0x55c75309100f base::debug::StackTrace::StackTrace() #1 0x55c752aa8075 content::(anonymous namespace)::DumpStackTraceSignalHandler() #2 0x7f17e8b21cb0 <unknown> #3 0x55c751991a1d chromeos::OobeUIDialogDelegate::~OobeUIDialogDelegate() #4 0x55c751991c8e chromeos::OobeUIDialogDelegate::~OobeUIDialogDelegate() #5 0x55c7553a6063 views::WebDialogView::OnDialogClosed() #6 0x55c7553a5d92 views::WebDialogView::WindowClosing() #7 0x55c752f81eb0 views::Widget::OnNativeWidgetDestroying() #8 0x55c7548080ff views::DesktopWindowTreeHostMus::CloseNow() Original change's description: > Fix a crash when switching to tablet mode in Unified Desktop mode > > 1) The Home Launcher used to use the wrong display ID when in > Unified Desktop mode. > 2) If (1) is fixed, we hit https://crbug.com/902601. The captive > portal dialog widget used to be leaked and never destroyed. > 3) If (2) is fixed, we crash on the first attempt to press the > app list button. The reason is tablet mode triggers a switch > to mirror mode. This switch happens asynchronously after the > Home Launcher had already been created. Switching from Unified > to mirror mode destroys the Unified host and the Home Launcher. > That's why we need to ensure that the Home Launcher is > recreated. > > BUG=900956, 902601 > TEST=Added a test that crashes without the fix. > > Change-Id: If6eb9c2255dfa9d442aa115a3274db2d8a4110d7 > Reviewed-on: https://chromium-review.googlesource.com/c/1325389 > Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> > Reviewed-by: Weidong Guo <weidongg@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Jacob Dufault <jdufault@chromium.org> > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Cr-Commit-Position: refs/heads/master@{#606687} TBR=xiyuan@chromium.org,oshima@chromium.org,afakhry@chromium.org,jdufault@chromium.org,weidongg@chromium.org Change-Id: I2e0cacc2c29bbc44e8e8c9dfcb86fd8106c008ff No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 900956, 902601 Reviewed-on: https://chromium-review.googlesource.com/c/1329004 Reviewed-by: Patrik Höglund <phoglund@chromium.org> Commit-Queue: Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#606808}

This reverts commit 2687587. Reason for revert: This triggers a use of initialized value on the msan bots. I believe you forgot to initialize is_removing_imm_entry_ https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8929963931985091872/+/steps/unit_tests/0/logs/ArcInputMethodManagerServiceTest.EnableIme/0 ==14387==WARNING: MemorySanitizer: use-of-uninitialized-value #0 0x5638655272d9 in arc::ArcInputMethodManagerService::ImeMenuListChanged() ./../../chrome/browser/chromeos/arc/input_method_manager/arc_input_method_manager_service.cc:394:7 #1 0x56385b307d20 in arc::ArcInputMethodManagerServiceTest_EnableIme_Test::TestBody() ./../../chrome/browser/chromeos/arc/input_method_manager/arc_input_method_manager_service_unittest.cc:313:14 #2 0x56385dbb3cb2 in HandleExceptionsInMethodIfSupported<testing::Test, void> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #3 0x56385dbb3cb2 in testing::Test::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2522:0 #4 0x56385dbb7a6b in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2698:11 #5 0x56385dbb9559 in testing::TestCase::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2816:28 #6 0x56385dbf2614 in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5182:43 #7 0x56385dbf0ee7 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #8 0x56385dbf0ee7 in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:4791:0 #9 0x56386b81af20 in RUN_ALL_TESTS ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:2333:46 #10 0x56386b81af20 in base::TestSuite::Run() ./../../base/test/test_suite.cc:294:0 #11 0x56386b822e8a in Run ./../../base/callback.h:99:12 #12 0x56386b822e8a in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) ./../../base/test/launcher/unit_test_launcher.cc:225:0 #13 0x56386b822607 in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) ./../../base/test/launcher/unit_test_launcher.cc:575:10 #14 0x56386b7e9154 in main ./../../chrome/test/base/run_all_unittests.cc:30:10 #15 0x7fd6f88f4f44 in __libc_start_main ??:0:0 #16 0x5638521e2b09 in _start ??:0:0 Original change's description: > Disable Android IMEs according to given ImeInfo. > > Android IMEs can be disabled in Android side by using 'ime' command. > This CL ensures that disabled IMEs are also disabled in Chrome OS's > InputMethodManager. > > Bug: b/119274469 > Change-Id: I46c2996a41327221470d69b778da2b7270c73cd2 > Reviewed-on: https://chromium-review.googlesource.com/c/1331294 > Reviewed-by: Yusuke Sato <yusukes@chromium.org> > Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> > Cr-Commit-Position: refs/heads/master@{#607473} TBR=yusukes@chromium.org,yhanada@chromium.org Change-Id: I5fd93607e711cd90edc4eb0ccf656b4c82ad5555 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b/119274469 Reviewed-on: https://chromium-review.googlesource.com/c/1333892 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#607610}

… Chrome OS." This reverts commit 605cb27. Reason for revert: causes a crash immediately on initialization on ChromeOS Linux build: [85464:85464:1113/105356.761188:FATAL:shell.cc(281)] Check failed: instance_. #0 0x7f6445c3668f base::debug::StackTrace::StackTrace() #1 0x7f6445b6624b logging::LogMessage::~LogMessage() #2 0x7f643f32b5c2 ash::Shell::Get() #3 0x561d123191ba ChromeBrowserMainExtraPartsAsh::PreProfileInit() #4 0x561d10f06f2a ChromeBrowserMainParts::PreProfileInit() #5 0x561d10f07c8e ChromeBrowserMainPartsLinux::PreProfileInit() #6 0x561d1089bc26 chromeos::ChromeBrowserMainPartsChromeos::PreProfileInit() #7 0x561d10f05fee ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #8 0x561d10f05925 ChromeBrowserMainParts::PreMainMessageLoopRun() #9 0x561d1089b755 chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() #10 0x7f64434b766a content::BrowserMainLoop::PreMainMessageLoopRun() #11 0x7f64439b1055 content::StartupTaskRunner::RunAllTasksNow() #12 0x7f64434b6191 content::BrowserMainLoop::CreateStartupTasks() #13 0x7f64434b9d30 content::BrowserMainRunnerImpl::Initialize() #14 0x7f64434b3d62 content::BrowserMain() #15 0x7f6443fed756 content::ContentMainRunnerImpl::Run() #16 0x7f6434c3ff46 service_manager::Main() #17 0x7f6443feba44 content::ContentMain() #18 0x561d10094e63 ChromeMain #19 0x7f64352042b1 __libc_start_main #20 0x561d10094cda _start Original change's description: > ui_devtools: Encapsulate views server init; use Shell Env for Chrome OS. > > Use the ash::Shell aura::Env in single-process mash ui_devtools. > Keep a TODO for initializing ui_devtools in Ash for multi-process Mash. > Encapsulate server init, and the switch and port definitions. > > Bug: 896977 > Test: ui_devtools works well on Chrome OS single-process Mash. > Change-Id: I3cc285d5f8ee465d45795a3521e7e4eafa354414 > Reviewed-on: https://chromium-review.googlesource.com/c/1324373 > Commit-Queue: Michael Wasserman <msw@chromium.org> > Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> > Cr-Commit-Position: refs/heads/master@{#607408} TBR=sadrul@chromium.org,msw@chromium.org Change-Id: Iae50c4a7d67de9602596b0522da3fec0f472e092 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 896977 Reviewed-on: https://chromium-review.googlesource.com/c/1334001 Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#607689}

Tests involving TaskScheduler accessed the members of SameThreadTaskSource from different threads without synchronization. This CL fixes the issue by making sure that the initial invocation of TestTask() happens on the same thread as other invocations. TSAN report before this CL: WARNING: ThreadSanitizer: data race (pid=126426) Write of size 4 at 0x7b1400001c0c by thread T4: #0 base::sequence_manager::SameThreadTaskSource::TestTask() base/task/sequence_manager/sequence_manager_perftest.cc:311:25 #1 Invoke<void (base::sequence_manager::SameThreadTaskSource::*)(), base::sequence_manager::SameThreadTaskSource *> base/bind_internal.h:516:12 #2 MakeItSo<void (base::sequence_manager::SameThreadTaskSource::*const &)(), base::sequence_manager::SameThreadTaskSource *> base/bind_internal.h:616 #3 RunImpl<void (base::sequence_manager::SameThreadTaskSource::*const &)(), const std::__1::tuple<base::internal::UnretainedWrapper<base::sequence_manager::SameThreadTaskSource> > &, 0> base/bind_internal.h:689 #4 base::internal::Invoker<base::internal::BindState<void (base::sequence_manager::SameThreadTaskSource::*)(), base::internal::UnretainedWrapper<base::sequence_manager::SameThreadTaskSource> >, void ()>::Run(base::internal::BindStateBase*) base/bind_internal.h:671 #5 Run base/callback.h:99:12 #6 base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) base/debug/task_annotator.cc:99 #7 base::internal::TaskTracker::RunOrSkipTask(base::internal::Task, base::internal::Sequence*, bool) base/task/task_scheduler/task_tracker.cc:641:23 #8 base::internal::TaskTrackerPosix::RunOrSkipTask(base::internal::Task, base::internal::Sequence*, bool) base/task/task_scheduler/task_tracker_posix.cc:23:16 #9 base::internal::TaskTracker::RunAndPopNextTask(scoped_refptr<base::internal::Sequence>, base::internal::CanScheduleSequenceObserver*) base/task/task_scheduler/task_tracker.cc:496:3 #10 base::internal::SchedulerWorker::RunWorker() base/task/task_scheduler/scheduler_worker.cc:333:24 #11 base::internal::SchedulerWorker::RunSharedWorker() base/task/task_scheduler/scheduler_worker.cc:237:3 #12 base::internal::SchedulerWorker::ThreadMain() base/task/task_scheduler/scheduler_worker.cc:207:7 #13 base::(anonymous namespace)::ThreadFunc(void*) base/threading/platform_thread_posix.cc:81:13 Previous write of size 4 at 0x7b1400001c0c by main thread: #0 TestTask base/task/sequence_manager/sequence_manager_perftest.cc:330:27 #1 base::sequence_manager::SameThreadTaskSource::Start() base/task/sequence_manager/sequence_manager_perftest.cc:297 #2 base::sequence_manager::SingleThreadImmediateTestCase::Start() base/task/sequence_manager/sequence_manager_perftest.cc:408:41 #3 base::sequence_manager::SequenceManagerPerfTest::Benchmark(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, base::sequence_manager::TestCase*) base/task/sequence_manager/sequence_manager_perftest.cc:636:15 #4 base::sequence_manager::SequenceManagerPerfTest_PostImmediateTasks_OneQueue_Test::TestBody() base/task/sequence_manager/sequence_manager_perftest.cc:714:3 #5 HandleExceptionsInMethodIfSupported<testing::Test, void> third_party/googletest/src/googletest/src/gtest.cc #6 testing::Test::Run() third_party/googletest/src/googletest/src/gtest.cc:2522 #7 testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2703:11 #8 testing::TestCase::Run() third_party/googletest/src/googletest/src/gtest.cc:2825:28 #9 testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5227:43 #10 HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> third_party/googletest/src/googletest/src/gtest.cc #11 testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc:4835 #12 RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2369:46 #13 base::TestSuite::Run() base/test/test_suite.cc:294 #14 main base/test/run_all_perftests.cc:8:42 TSAN report after this CL: No races found. Change-Id: I03b816a01fe33eed86966f89cb1ad1b9ab34c2e3 Reviewed-on: https://chromium-review.googlesource.com/c/1340534 Reviewed-by: Alex Clarke <alexclarke@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#609276}

… file" This reverts commit aa21b3f. Reason for revert: Suspect of introducing consistent failure on Mac ASAN 64 tests. First failed run: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac%20ASan%2064%20Tests%20%281%29/46988 Sample logs: unit_tests Run on OS: 'Mac-10.13' Shard duration: 0:07:56.378119 failures: FileAnalyzerTest.ArchivedArchiveSetForZipNoArchive FileAnalyzerTest.ArchivedExecutableFalseForZipNoExecutable DownloadProtectionServiceTest.CheckClientDownloadZip SandboxedZipAnalyzerTest.ZippedAppWithUnsignedAndSignedExecutable SandboxedZipAnalyzerTest.NoBinaries FileAnalyzerTest.ArchivedBinariesSkipsSafeFiles ==34531==ERROR: AddressSanitizer: stack-buffer-overflow on address 0x700015467c14 at pc 0x00013e99c44d bp 0x700015467950 sp 0x7000154670f8 READ of size 5 at 0x700015467c14 thread T16 #0 0x13e99c44c in __asan_after_dynamic_init ??:0:0 #1 0x10e3ac931 in safe_browsing::UpdateArchiveAnalyzerResultsWithFile(base::FilePath, base::File*, bool, safe_browsing::ArchiveAnalyzerResults*) ??:0:0 #2 0x10e3a6707 in safe_browsing::zip_analyzer::AnalyzeZipFile(base::File, base::File, safe_browsing::ArchiveAnalyzerResults*) ??:0:0 #3 0x115236586 in SafeArchiveAnalyzer::AnalyzeZipFile(base::File, base::File, base::OnceCallback<void (safe_browsing::ArchiveAnalyzerResults const&)>) ??:0:0 #4 0x10bc0b332 in chrome::mojom::SafeArchiveAnalyzerStubDispatch::AcceptWithResponder(chrome::mojom::SafeArchiveAnalyzer*, mojo::Message*, std::__1::unique_ptr<mojo::MessageReceiverWithStatus, std::__1::default_delete<mojo::MessageReceiverWithStatus> >) ??:0:0 #5 0x115234a40 in chrome::mojom::SafeArchiveAnalyzerStub<mojo::RawPtrImplRefTraits<chrome::mojom::SafeArchiveAnalyzer> >::AcceptWithResponder(mojo::Message*, std::__1::unique_ptr<mojo::MessageReceiverWithStatus, std::__1::default_delete<mojo::MessageReceiverWithStatus> >) ??:0:0 #6 0x1165eeb32 in mojo::InterfaceEndpointClient::HandleValidatedMessage(mojo::Message*) ??:0:0 #7 0x1165ed1e0 in mojo::FilterChain::Accept(mojo::Message*) ??:0:0 #8 0x1165f278b in mojo::InterfaceEndpointClient::HandleIncomingMessage(mojo::Message*) ??:0:0 #9 0x116605686 in mojo::internal::MultiplexRouter::ProcessIncomingMessage(mojo::internal::MultiplexRouter::MessageWrapper*, mojo::internal::MultiplexRouter::ClientCallBehavior, base::SequencedTaskRunner*) ??:0:0 #10 0x11660372b in mojo::internal::MultiplexRouter::Accept(mojo::Message*) ??:0:0 #11 0x1165ed1e0 in mojo::FilterChain::Accept(mojo::Message*) ??:0:0 #12 0x1165dcea8 in mojo::Connector::ReadSingleMessage(unsigned int*) ??:0:0 #13 0x1165df32a in mojo::Connector::ReadAllAvailableMessages() ??:0:0 #14 0x1165deda1 in mojo::Connector::OnHandleReadyInternal(unsigned int) ??:0:0 #15 0x10d429d44 in mojo::SimpleWatcher::DiscardReadyState(base::RepeatingCallback<void (unsigned int)> const&, unsigned int, mojo::HandleSignalsState const&) ??:0:0 #16 0x11a802cf5 in mojo::SimpleWatcher::OnHandleReady(int, unsigned int, mojo::HandleSignalsState const&) ??:0:0 #17 0x11a803cbd in void base::internal::Invoker<base::internal::BindState<void (mojo::SimpleWatcher::*)(int, unsigned int, mojo::HandleSignalsState const&), base::WeakPtr<mojo::SimpleWatcher>, int, unsigned int, mojo::HandleSignalsState>, void ()>::RunImpl<void (mojo::SimpleWatcher::* const&)(int, unsigned int, mojo::HandleSignalsState const&), std::__1::tuple<base::WeakPtr<mojo::SimpleWatcher>, int, unsigned int, mojo::HandleSignalsState> const&, 0ul, 1ul, 2ul, 3ul>(void (mojo::SimpleWatcher::* const&)(int, unsigned int, mojo::HandleSignalsState const&), std::__1::tuple<base::WeakPtr<mojo::SimpleWatcher>, int, unsigned int, mojo::HandleSignalsState> const&, std::__1::integer_sequence<unsigned long, 0ul, 1ul, 2ul, 3ul>) ??:0:0 #18 0x11890131c in base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) ??:0:0 #19 0x118995271 in base::MessageLoopImpl::RunTask(base::PendingTask*) ??:0:0 #20 0x11899691f in base::MessageLoopImpl::DoWork() ??:0:0 #21 0x118999eb3 in base::MessagePumpDefault::Run(base::MessagePump::Delegate*) ??:0:0 #22 0x118994259 in base::MessageLoopImpl::Run(bool) ??:0:0 #23 0x118a49a1c in base::RunLoop::Run() ??:0:0 #24 0x118b962e2 in base::Thread::Run(base::RunLoop*) ??:0:0 #25 0x118b96e9d in base::Thread::ThreadMain() ??:0:0 #26 0x118c72a0d in base::(anonymous namespace)::ThreadFunc(void*) ??:0:0 #27 0x7fff74564660 in _pthread_body ??:0:0 #28 0x7fff7456450c in _pthread_start ??:0:0 Original change's description: > Add util method to update ArchiveAnalyzerResults for a single file > > This CL breaks out the code that inspects an individual file within a > ZIP archive. This will be shared between the ZIP and RAR inspection, > when RAR files begin doing content inspection. > > Bug: 909778 > Change-Id: I7acf1cabd472f112f2ed7c31735688cae7a6d122 > Reviewed-on: https://chromium-review.googlesource.com/c/1354103 > Commit-Queue: Daniel Rubery <drubery@chromium.org> > Reviewed-by: Brian White <bcwhite@chromium.org> > Reviewed-by: Jay Civelli <jcivelli@chromium.org> > Reviewed-by: Varun Khaneja <vakh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#612799} TBR=jcivelli@chromium.org,bcwhite@chromium.org,vakh@chromium.org,drubery@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 909778 Change-Id: I92e193707da4a28cee94aa1277a6ca567650760f Reviewed-on: https://chromium-review.googlesource.com/c/1358491 Reviewed-by: Guido Urdaneta <guidou@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#613073}

…ure" This reverts commit 3f40244. Reason for revert: Caused a data race running components_unittests with ScopedFeatureList. Sample failure: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20TSan%20Tests/30398 WARNING: ThreadSanitizer: data race (pid=9805) Write of size 8 at 0x55b63bfba2b0 by main thread: #0 base::FeatureList::ClearInstanceForTesting() base/feature_list.cc:284:27 (components_unittests+0x85bec63) #1 base::test::ScopedFeatureList::~ScopedFeatureList() base/test/scoped_feature_list.cc:98:3 (components_unittests+0x9a65d52) #2 content::UnitTestTestSuite::~UnitTestTestSuite() content/public/test/unittest_test_suite.cc:61:1 (components_unittests+0xb03cf21) #3 operator() buildtools/third_party/libc++/trunk/include/memory:2325:5 (components_unittests+0x8256779) #4 reset buildtools/third_party/libc++/trunk/include/memory:2638 (components_unittests+0x8256779) #5 ~unique_ptr buildtools/third_party/libc++/trunk/include/memory:2592 (components_unittests+0x8256779) #6 ~__tuple_leaf buildtools/third_party/libc++/trunk/include/tuple:171 (components_unittests+0x8256779) #7 ~tuple buildtools/third_party/libc++/trunk/include/tuple:470 (components_unittests+0x8256779) #8 ~BindState base/bind_internal.h:871 (components_unittests+0x8256779) #9 base::internal::BindState<int (content::UnitTestTestSuite::*)(), std::__1::unique_ptr<content::UnitTestTestSuite, std::__1::default_delete<content::UnitTestTestSuite> > >::Destroy(base::internal::BindStateBase const*) base/bind_internal.h:874 (components_unittests+0x8256779) #10 Destruct base/callback_internal.cc:29:3 (components_unittests+0x85b80c7) #11 Release base/memory/ref_counted.h:403 (components_unittests+0x85b80c7) #12 Release base/memory/scoped_refptr.h:284 (components_unittests+0x85b80c7) #13 ~scoped_refptr base/memory/scoped_refptr.h:208 (components_unittests+0x85b80c7) #14 base::internal::CallbackBase::~CallbackBase() base/callback_internal.cc:84 (components_unittests+0x85b80c7) #15 base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) base/test/launcher/unit_test_launcher.cc:575:3 (components_unittests+0x9a71272) #16 main components/test/run_all_unittests.cc:8:10 (components_unittests+0x4e49ad5) Previous read of size 8 at 0x55b63bfba2b0 by thread T12 (mutexes: write M19294): #0 base::FeatureList::IsEnabled(base::Feature const&) base/feature_list.cc:200:8 (components_unittests+0x85be82d) #1 CanCleanupLockRequired base/task/task_scheduler/scheduler_worker_pool_impl.cc:672:12 (components_unittests+0x866a5e8) #2 base::internal::SchedulerWorkerPoolImpl::SchedulerWorkerDelegateImpl::GetWork(base::internal::SchedulerWorker*) base/task/task_scheduler/scheduler_worker_pool_impl.cc:538 (components_unittests+0x866a5e8) #3 base::internal::SchedulerWorker::RunWorker() base/task/task_scheduler/scheduler_worker.cc:324:51 (components_unittests+0x866f81d) #4 base::internal::SchedulerWorker::RunPooledWorker() base/task/task_scheduler/scheduler_worker.cc:229:3 (components_unittests+0x866f481) #5 base::internal::SchedulerWorker::ThreadMain() base/task/task_scheduler/scheduler_worker.cc:208:7 (components_unittests+0x866f2f1) #6 base::(anonymous namespace)::ThreadFunc(void*) base/threading/platform_thread_posix.cc:81:13 (components_unittests+0x86daf04) Location is global 'base::(anonymous namespace)::g_feature_list_instance' of size 8 at 0x55b63bfba2b0 (components_unittests+0x00000ebe52b0) Original change's description: > [TaskScheduler]: Create no detach below initial capacity feature > > Under this experiment, scheduler workers are only detached if the pool is > above its initial capacity (threads that are created to replace blocked threads). > > 2 options were considered: > Option A: Detach only when over initial capacity. > > Option B: Detach only when over current capacity (includes currently blocked threads in capacity). > This might better handle the following case: At any given time, there is at least 1 blocked thread. > On top of that, some periodic work uses all worker every 30s or so. The current capacity will > encompass for the blocked thread and avoid detaching it periodically. > > Option A was picked because it is more conservative. Initial capacity is smaller or > equal to current capacity, so detaching is closer to current behavior. We want to avoid having > too many threads that aren't used. > > Bug: 847501 > Change-Id: I0b116db54095767768b158d92f5f146249720b45 > Reviewed-on: https://chromium-review.googlesource.com/c/1348863 > Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Cr-Commit-Position: refs/heads/master@{#612698} TBR=fdoray@chromium.org,etiennep@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 847501 Change-Id: I951f5c5701e2d296b2c4edef37648105c4911cf9 Reviewed-on: https://chromium-review.googlesource.com/c/1359127 Reviewed-by: Robert Flack <flackr@chromium.org> Commit-Queue: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#613229}

Reason for revert: the failing test was flaky without this change and has since been disabled (crbug.com/911154) Original change's description: > Revert "cros: Remove WizardInProcessBrowserTest" > > This reverts commit 92925c6. > > Reason for revert: WizardControllerDeviceState*Test timing out on linux-chromeos-dbg > > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/9248 > > rowserTestBase received signal: Terminated. Backtrace: > #0 0x7feb2e8b3fed base::debug::StackTrace::StackTrace() > #1 0x7feb2e5addfa base::debug::StackTrace::StackTrace() > #2 0x563fac6dc0f2 content::(anonymous namespace)::DumpStackTraceSignalHandler() > #3 0x7feafb349cb0 <unknown> > #4 0x7feafb4116d3 epoll_wait > #5 0x7feb2e96353f epoll_dispatch > #6 0x7feb2e956cc5 event_base_loop > #7 0x7feb2e9073c9 base::MessagePumpLibevent::Run() > #8 0x7feb2e63fbe6 base::MessageLoopImpl::Run() > #9 0x7feb2e6eb322 base::RunLoop::Run() > #10 0x563fa6018304 chromeos::WizardControllerDeviceStateTest::WaitForAutoEnrollmentState() > #11 0x563fa5ffeb8f chromeos::WizardControllerDeviceStateExplicitRequirementTest_ControlFlowForcedReEnrollment_Test::RunTestOnMainThread() > > Original change's description: > > cros: Remove WizardInProcessBrowserTest > > > > The base class convoluted the inheritance structure and it is simpler to > > directly derive from InProcessBrowserTest. > > > > Bug: 899777 > > Change-Id: I04b8e4d48d0a28a8d4481891d5379456df32d0d6 > > Reviewed-on: https://chromium-review.googlesource.com/c/1345244 > > Commit-Queue: Jacob Dufault <jdufault@chromium.org> > > Reviewed-by: Maksim Ivanov <emaxx@chromium.org> > > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#612394} > > TBR=xiyuan@chromium.org,emaxx@chromium.org,jdufault@chromium.org > > Change-Id: I06cfea778c8246795a8bb8fdc9878812a1ab5d52 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 899777 > Reviewed-on: https://chromium-review.googlesource.com/c/1356168 > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Cr-Commit-Position: refs/heads/master@{#612523} TBR=xiyuan@chromium.org,emaxx@chromium.org,jdufault@chromium.org,ortuno@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 899777 Change-Id: Id6a54d588736969830db39963f5cc4560d1068b9 Reviewed-on: https://chromium-review.googlesource.com/c/1359135 Reviewed-by: Jacob Dufault <jdufault@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#613244}

This reverts commit 5684820. Reason for revert: WizardControllerDeviceStateTest.ControlFlowDeviceDisabled timing out on linux-chromeos-dbg https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/9330 Original change's description: > Reland "cros: Remove WizardInProcessBrowserTest" > > Reason for revert: the failing test was flaky without this change and has since been disabled (crbug.com/911154) > > Original change's description: > > Revert "cros: Remove WizardInProcessBrowserTest" > > > > This reverts commit 92925c6. > > > > Reason for revert: WizardControllerDeviceState*Test timing out on linux-chromeos-dbg > > > > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/9248 > > > > rowserTestBase received signal: Terminated. Backtrace: > > #0 0x7feb2e8b3fed base::debug::StackTrace::StackTrace() > > #1 0x7feb2e5addfa base::debug::StackTrace::StackTrace() > > #2 0x563fac6dc0f2 content::(anonymous namespace)::DumpStackTraceSignalHandler() > > #3 0x7feafb349cb0 <unknown> > > #4 0x7feafb4116d3 epoll_wait > > #5 0x7feb2e96353f epoll_dispatch > > #6 0x7feb2e956cc5 event_base_loop > > #7 0x7feb2e9073c9 base::MessagePumpLibevent::Run() > > #8 0x7feb2e63fbe6 base::MessageLoopImpl::Run() > > #9 0x7feb2e6eb322 base::RunLoop::Run() > > #10 0x563fa6018304 chromeos::WizardControllerDeviceStateTest::WaitForAutoEnrollmentState() > > #11 0x563fa5ffeb8f chromeos::WizardControllerDeviceStateExplicitRequirementTest_ControlFlowForcedReEnrollment_Test::RunTestOnMainThread() > > > > Original change's description: > > > cros: Remove WizardInProcessBrowserTest > > > > > > The base class convoluted the inheritance structure and it is simpler to > > > directly derive from InProcessBrowserTest. > > > > > > Bug: 899777 > > > Change-Id: I04b8e4d48d0a28a8d4481891d5379456df32d0d6 > > > Reviewed-on: https://chromium-review.googlesource.com/c/1345244 > > > Commit-Queue: Jacob Dufault <jdufault@chromium.org> > > > Reviewed-by: Maksim Ivanov <emaxx@chromium.org> > > > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#612394} > > > > TBR=xiyuan@chromium.org,emaxx@chromium.org,jdufault@chromium.org > > > > Change-Id: I06cfea778c8246795a8bb8fdc9878812a1ab5d52 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 899777 > > Reviewed-on: https://chromium-review.googlesource.com/c/1356168 > > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > > Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#612523} > > TBR=xiyuan@chromium.org,emaxx@chromium.org,jdufault@chromium.org,ortuno@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 899777 > Change-Id: Id6a54d588736969830db39963f5cc4560d1068b9 > Reviewed-on: https://chromium-review.googlesource.com/c/1359135 > Reviewed-by: Jacob Dufault <jdufault@chromium.org> > Commit-Queue: Jacob Dufault <jdufault@chromium.org> > Cr-Commit-Position: refs/heads/master@{#613244} TBR=xiyuan@chromium.org,emaxx@chromium.org,jdufault@chromium.org,ortuno@chromium.org Change-Id: Ifeec16d8f954fd9a9aede38a2fa0bffcc107dab4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 899777 Reviewed-on: https://chromium-review.googlesource.com/c/1359815 Reviewed-by: Ovidio Henriquez <odejesush@chromium.org> Commit-Queue: Ovidio Henriquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#613359}

This reverts commit 3bb44fe. Reason for revert: Suspect of introducing consistent failure on Linux Chromium OS ASan LSan Tests (1) bot. First failure: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/30399 Sample logs: views_mus_unittests Run on OS: 'Ubuntu-14.04' Shard duration: 0:01:41.022687 failures: AXTreeSourceViewsRootTest.Serialize AXTreeSourceViewsRootTest.Focus AXTreeSourceViewsRootTest.Accessors AXTreeSourceViewsRootTest.SerializeWindowSetsClipsChildren AXTreeSourceViewsRootTest.DoDefault ==7985==ERROR: LeakSanitizer: detected memory leaks Direct leak of 56 byte(s) in 1 object(s) allocated from: #0 0x55ec150a7ed2 in operator new(unsigned long) /b/swarming/w/ir/kitchen-workdir/src/third_party/llvm/compiler-rt/lib/asan/asan_new_delete.cc:106:3 #1 0x55ec158f3f9e in ui::AXTreeSerializer<views::AXAuraObjWrapper*, ui::AXNodeData, ui::AXTreeData>::SerializeChangedNodes(views::AXAuraObjWrapper*, ui::AXTreeUpdateBase<ui::AXNodeData, ui::AXTreeData>*) ui/accessibility/ax_tree_serializer.h:598:35 #2 0x55ec158f41c2 in ui::AXTreeSerializer<views::AXAuraObjWrapper*, ui::AXNodeData, ui::AXTreeData>::SerializeChangedNodes(views::AXAuraObjWrapper*, ui::AXTreeUpdateBase<ui::AXNodeData, ui::AXTreeData>*) ui/accessibility/ax_tree_serializer.h:604:12 #3 0x55ec158f41c2 in ui::AXTreeSerializer<views::AXAuraObjWrapper*, ui::AXNodeData, ui::AXTreeData>::SerializeChangedNodes(views::AXAuraObjWrapper*, ui::AXTreeUpdateBase<ui::AXNodeData, ui::AXTreeData>*) ui/accessibility/ax_tree_serializer.h:604:12 #4 0x55ec158f09de in ui::AXTreeSerializer<views::AXAuraObjWrapper*, ui::AXNodeData, ui::AXTreeData>::SerializeChanges(views::AXAuraObjWrapper*, ui::AXTreeUpdateBase<ui::AXNodeData, ui::AXTreeData>*) ui/accessibility/ax_tree_serializer.h:422:8 #5 0x55ec158ee9d9 in views::(anonymous namespace)::AXTreeSourceViewsRootTest_Serialize_Test::TestBody() ui/views/accessibility/ax_tree_source_views_unittest.cc:318:17 #6 0x55ec17bdd342 in HandleExceptionsInMethodIfSupported<testing::Test, void> third_party/googletest/src/googletest/src/gtest.cc #7 0x55ec17bdd342 in testing::Test::Run() third_party/googletest/src/googletest/src/gtest.cc:2522 #8 0x55ec17bdf428 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2703:11 #9 0x55ec17be08e6 in testing::TestCase::Run() third_party/googletest/src/googletest/src/gtest.cc:2825:28 #10 0x55ec17c08f46 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5227:43 #11 0x55ec17c082c5 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> third_party/googletest/src/googletest/src/gtest.cc #12 0x55ec17c082c5 in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc:4835 #13 0x55ec180eb7da in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2369:46 #14 0x55ec180eb7da in base::TestSuite::Run() base/test/test_suite.cc:294 #15 0x55ec180f1a34 in Run base/callback.h:99:12 #16 0x55ec180f1a34 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) base/test/launcher/unit_test_launcher.cc:225 #17 0x55ec180f1500 in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) base/test/launcher/unit_test_launcher.cc:575:10 #18 0x55ec15220e7e in views::ViewsTestSuite::RunTests() ui/views/views_test_suite.cc:33:10 #19 0x55ec150f46a3 in main ui/views/mus/run_all_unittests_mus.cc:8:47 #20 0x7fd6ce976f44 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21f44) Indirect leak of 8 byte(s) in 1 object(s) allocated from: #0 0x55ec150a7ed2 in operator new(unsigned long) /b/swarming/w/ir/kitchen-workdir/src/third_party/llvm/compiler-rt/lib/asan/asan_new_delete.cc:106:3 #1 0x55ec158f6f15 in __libcpp_allocate buildtools/third_party/libc++/trunk/include/new:254:10 #2 0x55ec158f6f15 in allocate buildtools/third_party/libc++/trunk/include/memory:1800 #3 0x55ec158f6f15 in allocate buildtools/third_party/libc++/trunk/include/memory:1549 #4 0x55ec158f6f15 in __split_buffer buildtools/third_party/libc++/trunk/include/__split_buffer:311 #5 0x55ec158f6f15 in std::__1::vector<ui::ClientTreeNode*, std::__1::allocator<ui::ClientTreeNode*> >::reserve(unsigned long) buildtools/third_party/libc++/trunk/include/vector:1576 #6 0x55ec158f3a1b in ui::AXTreeSerializer<views::AXAuraObjWrapper*, ui::AXNodeData, ui::AXTreeData>::SerializeChangedNodes(views::AXAuraObjWrapper*, ui::AXTreeUpdateBase<ui::AXNodeData, ui::AXTreeData>*) ui/accessibility/ax_tree_serializer.h:573:25 #7 0x55ec158f41c2 in ui::AXTreeSerializer<views::AXAuraObjWrapper*, ui::AXNodeData, ui::AXTreeData>::SerializeChangedNodes(views::AXAuraObjWrapper*, ui::AXTreeUpdateBase<ui::AXNodeData, ui::AXTreeData>*) ui/accessibility/ax_tree_serializer.h:604:12 #8 0x55ec158f41c2 in ui::AXTreeSerializer<views::AXAuraObjWrapper*, ui::AXNodeData, ui::AXTreeData>::SerializeChangedNodes(views::AXAuraObjWrapper*, ui::AXTreeUpdateBase<ui::AXNodeData, ui::AXTreeData>*) ui/accessibility/ax_tree_serializer.h:604:12 #9 0x55ec158f41c2 in ui::AXTreeSerializer<views::AXAuraObjWrapper*, ui::AXNodeData, ui::AXTreeData>::SerializeChangedNodes(views::AXAuraObjWrapper*, ui::AXTreeUpdateBase<ui::AXNodeData, ui::AXTreeData>*) ui/accessibility/ax_tree_serializer.h:604:12 #10 0x55ec158f09de in ui::AXTreeSerializer<views::AXAuraObjWrapper*, ui::AXNodeData, ui::AXTreeData>::SerializeChanges(views::AXAuraObjWrapper*, ui::AXTreeUpdateBase<ui::AXNodeData, ui::AXTreeData>*) ui/accessibility/ax_tree_serializer.h:422:8 #11 0x55ec158ee9d9 in views::(anonymous namespace)::AXTreeSourceViewsRootTest_Serialize_Test::TestBody() ui/views/accessibility/ax_tree_source_views_unittest.cc:318:17 #12 0x55ec17bdd342 in HandleExceptionsInMethodIfSupported<testing::Test, void> third_party/googletest/src/googletest/src/gtest.cc #13 0x55ec17bdd342 in testing::Test::Run() third_party/googletest/src/googletest/src/gtest.cc:2522 #14 0x55ec17bdf428 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2703:11 #15 0x55ec17be08e6 in testing::TestCase::Run() third_party/googletest/src/googletest/src/gtest.cc:2825:28 #16 0x55ec17c08f46 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5227:43 #17 0x55ec17c082c5 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> third_party/googletest/src/googletest/src/gtest.cc #18 0x55ec17c082c5 in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc:4835 #19 0x55ec180eb7da in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2369:46 #20 0x55ec180eb7da in base::TestSuite::Run() base/test/test_suite.cc:294 #21 0x55ec180f1a34 in Run base/callback.h:99:12 #22 0x55ec180f1a34 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) base/test/launcher/unit_test_launcher.cc:225 #23 0x55ec180f1500 in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) base/test/launcher/unit_test_launcher.cc:575:10 #24 0x55ec15220e7e in views::ViewsTestSuite::RunTests() ui/views/views_test_suite.cc:33:10 #25 0x55ec150f46a3 in main ui/views/mus/run_all_unittests_mus.cc:8:47 #26 0x7fd6ce976f44 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21f44) Original change's description: > Move AXTreeSourceAura tests into AXTreeSourceViews tests > > AXTreeSourceAura doesn't exist any more. The tests exercise the > integration of AXRootObjWrapper with AXTreeSourceViews, so rename the > tests ot AXTreeSourceViewsRootTest. > > Note that the tests lived in //chrome/browser/ui/ash. If we need an > ash-specific tree source we could introduce an AXTreeSourceAsh either > in //ash (for mash) or //chrome/browser/ui/ash (for SingleProcessMash). > > Bug: 910672 > Test: views_unittests > Change-Id: I79438345e3ad9bd1aa69d74b3c34cc35efe87142 > Reviewed-on: https://chromium-review.googlesource.com/c/1358972 > Reviewed-by: David Tseng <dtseng@chromium.org> > Commit-Queue: James Cook <jamescook@chromium.org> > Cr-Commit-Position: refs/heads/master@{#613308} TBR=jamescook@chromium.org,dtseng@chromium.org Change-Id: If77dfe8f468d8f5e8514e2dbe57c9aff3cbf5a3e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 910672 Reviewed-on: https://chromium-review.googlesource.com/c/1360591 Reviewed-by: Guido Urdaneta <guidou@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#613487}

Data race happens between SetBehindCaptivePortal on BrowserThread::IO and CaptivePortalBrowserTest::OnIntercept line 981 on main thread Change-Id: I58163d96f66f8ca3b2d257d1481b0d12f980c679 ThreadSanitizer Report WARNING: ThreadSanitizer: data race (pid=37545) Read of size 1 at 0x7b44000004d8 by main thread: #0 CaptivePortalBrowserTest::OnIntercept(content::URLLoaderInterceptor::RequestParams*) /src/chrome/browser/captive_portal/captive_portal_browsertest.cc:984:9 (browser_tests+0x4ea3f84) #1 Invoke<bool (CaptivePortalBrowserTest::*)(content::URLLoaderInterceptor::RequestParams *), CaptivePortalBrowserTest *, content::URLLoaderInterceptor::RequestParams *> /src/base/bind_internal.h:507:12 (browser_tests+0x4ed3a2f) #2 MakeItSo<bool (CaptivePortalBrowserTest::*const &)(content::URLLoaderInterceptor::RequestParams *), CaptivePortalBrowserTest *, content::URLLoaderInterceptor::RequestParams *> /src/base/bind_internal.h:607 (browser_tests+0x4ed3a2f) #3 RunImpl<bool (CaptivePortalBrowserTest::*const &)(content::URLLoaderInterceptor::RequestParams *), const std::__1::tuple<base::internal::UnretainedWrapper<CaptivePortalBrowserTest> > &, 0> /src/base/bind_internal.h:680 (browser_tests+0x4ed3a2f) #4 base::internal::Invoker<base::internal::BindState<bool (CaptivePortalBrowserTest::*)(content::URLLoaderInterceptor::RequestParams*), base::internal::UnretainedWrapper<CaptivePortalBrowserTest> >, bool (content::URLLoaderInterceptor::RequestParams*)>::Run(base::internal::BindStateBase*, content::URLLoaderInterceptor::RequestParams*) /src/base/bind_internal.h:662 (browser_tests+0x4ed3a2f) #5 Run /src/base/callback.h:129:12 (browser_tests+0xa8cbbcc) #6 content::URLLoaderInterceptor::Intercept(content::URLLoaderInterceptor::RequestParams*) /src/content/public/test/url_loader_interceptor.cc:377 (browser_tests+0xa8cbbcc) #7 content::URLLoaderInterceptor::Interceptor::CreateLoaderAndStart(mojo::InterfaceRequest<network::mojom::URLLoader>, int, int, unsigned int, network::ResourceRequest const&, mojo::InterfacePtr<network::mojom::URLLoaderClient>, net::MutableNetworkTrafficAnnotationTag const&) /src/content/public/test/url_loader_interceptor.cc:92:18 (browser_tests+0xa8cd294) #8 network::mojom::URLLoaderFactoryProxy_CreateLoaderAndStart_Message::Dispatch(network::mojom::URLLoaderFactory*) /src/out/Default/gen/services/network/public/mojom/url_loader_factory.mojom.cc:145:11 (browser_tests+0x581c781) #9 network::mojom::URLLoaderFactoryStubDispatch::Accept(network::mojom::URLLoaderFactory*, mojo::Message*) /src/out/Default/gen/services/network/public/mojom/url_loader_factory.mojom.cc:353:20 (browser_tests+0x581c626) #10 network::mojom::URLLoaderFactoryStub<mojo::RawPtrImplRefTraits<network::mojom::URLLoaderFactory> >::Accept(mojo::Message*) /src/out/Default/gen/services/network/public/mojom/url_loader_factory.mojom.h:155:12 (browser_tests+0x69ccb3f) #11 mojo::InterfaceEndpointClient::HandleValidatedMessage(mojo::Message*) /src/mojo/public/cpp/bindings/lib/interface_endpoint_client.cc:423:32 (browser_tests+0xb97e563) #12 mojo::InterfaceEndpointClient::HandleIncomingMessageThunk::Accept(mojo::Message*) /src/mojo/public/cpp/bindings/lib/interface_endpoint_client.cc:133:18 (browser_tests+0xb97df6a) #13 mojo::FilterChain::Accept(mojo::Message*) /src/mojo/public/cpp/bindings/lib/filter_chain.cc:40:17 (browser_tests+0xb9823ba) #14 mojo::InterfaceEndpointClient::HandleIncomingMessage(mojo::Message*) /src/mojo/public/cpp/bindings/lib/interface_endpoint_client.cc:306:19 (browser_tests+0xb9801ba) #15 mojo::internal::MultiplexRouter::ProcessIncomingMessage(mojo::internal::MultiplexRouter::MessageWrapper*, mojo::internal::MultiplexRouter::ClientCallBehavior, base::SequencedTaskRunner*) /src/mojo/public/cpp/bindings/lib/multiplex_router.cc:869:42 (browser_tests+0xb98ba4b) #16 mojo::internal::MultiplexRouter::Accept(mojo::Message*) /src/mojo/public/cpp/bindings/lib/multiplex_router.cc:590:38 (browser_tests+0xb98a86a) #17 mojo::FilterChain::Accept(mojo::Message*) /src/mojo/public/cpp/bindings/lib/filter_chain.cc:40:17 (browser_tests+0xb9823ba) #18 mojo::Connector::ReadSingleMessage(unsigned int*) /src/mojo/public/cpp/bindings/lib/connector.cc:457:51 (browser_tests+0xb97a2be) #19 mojo::Connector::ReadAllAvailableMessages() /src/mojo/public/cpp/bindings/lib/connector.cc:486:10 (browser_tests+0xb97b0e7) #20 mojo::Connector::OnHandleReadyInternal(unsigned int) /src/mojo/public/cpp/bindings/lib/connector.cc:387:3 (browser_tests+0xb97ae8e) #21 mojo::Connector::OnWatcherHandleReady(unsigned int) /src/mojo/public/cpp/bindings/lib/connector.cc:364:3 (browser_tests+0xb97ade0) #22 Invoke<void (mojo::Connector::*)(unsigned int), mojo::Connector *, unsigned int> /src/base/bind_internal.h:507:12 (browser_tests+0xb97bbcf) #23 MakeItSo<void (mojo::Connector::*const &)(unsigned int), mojo::Connector *, unsigned int> /src/base/bind_internal.h:607 (browser_tests+0xb97bbcf) #24 RunImpl<void (mojo::Connector::*const &)(unsigned int), const std::__1::tuple<base::internal::UnretainedWrapper<mojo::Connector> > &, 0> /src/base/bind_internal.h:680 (browser_tests+0xb97bbcf) #25 base::internal::Invoker<base::internal::BindState<void (mojo::Connector::*)(unsigned int), base::internal::UnretainedWrapper<mojo::Connector> >, void (unsigned int)>::Run(base::internal::BindStateBase*, unsigned int) /src/base/bind_internal.h:662 (browser_tests+0xb97bbcf) #26 Run /src/base/callback.h:129:12 (browser_tests+0x66996b8) #27 mojo::SimpleWatcher::DiscardReadyState(base::RepeatingCallback<void (unsigned int)> const&, unsigned int, mojo::HandleSignalsState const&) /src/mojo/public/cpp/system/simple_watcher.h:194 (browser_tests+0x66996b8) #28 Invoke<void (*const &)(const base::RepeatingCallback<void (unsigned int)> &, unsigned int, const mojo::HandleSignalsState &), const base::RepeatingCallback<void (unsigned int)> &, unsigned int, const mojo::HandleSignalsState &> /src/base/bind_internal.h:407:12 (browser_tests+0x6699715) #29 MakeItSo<void (*const &)(const base::RepeatingCallback<void (unsigned int)> &, unsigned int, const mojo::HandleSignalsState &), const base::RepeatingCallback<void (unsigned int)> &, unsigned int, const mojo::HandleSignalsState &> /src/base/bind_internal.h:607 (browser_tests+0x6699715) #30 RunImpl<void (*const &)(const base::RepeatingCallback<void (unsigned int)> &, unsigned int, const mojo::HandleSignalsState &), const std::__1::tuple<base::RepeatingCallback<void (unsigned int)> > &, 0> /src/base/bind_internal.h:680 (browser_tests+0x6699715) #31 base::internal::Invoker<base::internal::BindState<void (*)(base::RepeatingCallback<void (unsigned int)> const&, unsigned int, mojo::HandleSignalsState const&), base::RepeatingCallback<void (unsigned int)> >, void (unsigned int, mojo::HandleSignalsState const&)>::Run(base::internal::BindStateBase*, unsigned int, mojo::HandleSignalsState const&) /src/base/bind_internal.h:662 (browser_tests+0x6699715) #32 Run /src/base/callback.h:129:12 (browser_tests+0xa96dece) #33 mojo::SimpleWatcher::OnHandleReady(int, unsigned int, mojo::HandleSignalsState const&) /src/mojo/public/cpp/system/simple_watcher.cc:273 (browser_tests+0xa96dece) #34 Invoke<void (mojo::SimpleWatcher::*)(int, unsigned int, const mojo::HandleSignalsState &), const base::WeakPtr<mojo::SimpleWatcher> &, const int &, const unsigned int &, const mojo::HandleSignalsState &> /src/base/bind_internal.h:507:12 (browser_tests+0xa96e625) #35 MakeItSo<void (mojo::SimpleWatcher::*const &)(int, unsigned int, const mojo::HandleSignalsState &), const base::WeakPtr<mojo::SimpleWatcher> &, const int &, const unsigned int &, const mojo::HandleSignalsState &> /src/base/bind_internal.h:627 (browser_tests+0xa96e625) #36 void base::internal::Invoker<base::internal::BindState<void (mojo::SimpleWatcher::*)(int, unsigned int, mojo::HandleSignalsState const&), base::WeakPtr<mojo::SimpleWatcher>, int, unsigned int, mojo::HandleSignalsState>, void ()>::RunImpl<void (mojo::SimpleWatcher::* const&)(int, unsigned int, mojo::HandleSignalsState const&), std::__1::tuple<base::WeakPtr<mojo::SimpleWatcher>, int, unsigned int, mojo::HandleSignalsState> const&, 0ul, 1ul, 2ul, 3ul>(void (mojo::SimpleWatcher::* const&&&)(int, unsigned int, mojo::HandleSignalsState const&), std::__1::tuple<base::WeakPtr<mojo::SimpleWatcher>, int, unsigned int, mojo::HandleSignalsState> const&&&, std::__1::integer_sequence<unsigned long, 0ul, 1ul, 2ul, 3ul>) /src/base/bind_internal.h:680 (browser_tests+0xa96e625) #37 base::internal::Invoker<base::internal::BindState<void (mojo::SimpleWatcher::*)(int, unsigned int, mojo::HandleSignalsState const&), base::WeakPtr<mojo::SimpleWatcher>, int, unsigned int, mojo::HandleSignalsState>, void ()>::Run(base::internal::BindStateBase*) /src/base/bind_internal.h:662:12 (browser_tests+0xa96e4ce) #38 Run /src/base/callback.h:99:12 (browser_tests+0x9a92ee8) #39 base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) /src/base/debug/task_annotator.cc:101 (browser_tests+0x9a92ee8) #40 base::MessageLoop::RunTask(base::PendingTask*) /src/base/message_loop/message_loop.cc:432:46 (browser_tests+0x55f355a) #41 base::MessageLoop::DeferOrRunPendingTask(base::PendingTask) /src/base/message_loop/message_loop.cc:443:5 (browser_tests+0x55f3e7c) #42 base::MessageLoop::DoWork() /src/base/message_loop/message_loop.cc:487:16 (browser_tests+0x55f41c5) #43 base::MessagePumpGlib::Run(base::MessagePump::Delegate*) /src/base/message_loop/message_pump_glib.cc:309:49 (browser_tests+0x9ad27bb) #44 base::MessageLoop::Run(bool) /src/base/message_loop/message_loop.cc:374:12 (browser_tests+0x55f2c67) #45 non-virtual thunk to base::MessageLoop::Run(bool) /src/base/message_loop/message_loop.cc (browser_tests+0x55f2d54) #46 base::RunLoop::Run() /src/base/run_loop.cc:102:14 (browser_tests+0x55f6adf) #47 RunThisRunLoop /src/content/public/test/test_utils.cc:132:13 (browser_tests+0xa8c5bf8) #48 content::RunMessageLoop() /src/content/public/test/test_utils.cc:127 (browser_tests+0xa8c5bf8) #49 (anonymous namespace)::CaptivePortalObserver::WaitForResults(int) /src/chrome/browser/captive_portal/captive_portal_browsertest.cc:432:5 (browser_tests+0x4ea7325) #50 CaptivePortalBrowserTest_ShowCaptivePortalInterstitialOnCertError_Test::RunTestOnMainThread() /src/chrome/browser/captive_portal/captive_portal_browsertest.cc:1891:25 (browser_tests+0x4eb9cc3) #51 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() /src/content/public/test/browser_test_base.cc:406:5 (browser_tests+0xa863ddd) #52 Invoke<void (content::BrowserTestBase::*)(), content::BrowserTestBase *> /src/base/bind_internal.h:507:12 (browser_tests+0xa864f28) #53 MakeItSo<void (content::BrowserTestBase::*const &)(), content::BrowserTestBase *> /src/base/bind_internal.h:607 (browser_tests+0xa864f28) #54 RunImpl<void (content::BrowserTestBase::*const &)(), const std::__1::tuple<base::internal::UnretainedWrapper<content::BrowserTestBase> > &, 0> /src/base/bind_internal.h:680 (browser_tests+0xa864f28) #55 base::internal::Invoker<base::internal::BindState<void (content::BrowserTestBase::*)(), base::internal::UnretainedWrapper<content::BrowserTestBase> >, void ()>::Run(base::internal::BindStateBase*) /src/base/bind_internal.h:662 (browser_tests+0xa864f28) #56 Run /src/base/callback.h:129:12 (browser_tests+0x9ce722d) #57 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() /src/chrome/browser/chrome_browser_main.cc:3181 (browser_tests+0x9ce722d) #58 ChromeBrowserMainParts::PreMainMessageLoopRun() /src/chrome/browser/chrome_browser_main.cc:2259:18 (browser_tests+0x9ce52eb) #59 content::BrowserMainLoop::PreMainMessageLoopRun() /src/content/browser/browser_main_loop.cc:1021:13 (browser_tests+0x6a854c0) #60 Invoke<int (content::BrowserMainLoop::*)(), content::BrowserMainLoop *> /src/base/bind_internal.h:507:12 (browser_tests+0x6a88df8) #61 MakeItSo<int (content::BrowserMainLoop::*const &)(), content::BrowserMainLoop *> /src/base/bind_internal.h:607 (browser_tests+0x6a88df8) #62 RunImpl<int (content::BrowserMainLoop::*const &)(), const std::__1::tuple<base::internal::UnretainedWrapper<content::BrowserMainLoop> > &, 0> /src/base/bind_internal.h:680 (browser_tests+0x6a88df8) #63 base::internal::Invoker<base::internal::BindState<int (content::BrowserMainLoop::*)(), base::internal::UnretainedWrapper<content::BrowserMainLoop> >, int ()>::Run(base::internal::BindStateBase*) /src/base/bind_internal.h:662 (browser_tests+0x6a88df8) #64 Run /src/base/callback.h:129:12 (browser_tests+0x726d05a) #65 content::StartupTaskRunner::RunAllTasksNow() /src/content/browser/startup_task_runner.cc:43 (browser_tests+0x726d05a) #66 content::BrowserMainLoop::CreateStartupTasks() /src/content/browser/browser_main_loop.cc:932:25 (browser_tests+0x6a8379a) #67 content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) /src/content/browser/browser_main_runner_impl.cc:143:15 (browser_tests+0x6a893ea) #68 content::BrowserMain(content::MainFunctionParams const&) /src/content/browser/browser_main.cc:45:32 (browser_tests+0x6a80539) #69 RunBrowserProcessMain /src/content/app/content_main_runner_impl.cc:613:10 (browser_tests+0x99a6eeb) #70 content::ContentMainRunnerImpl::Run(bool) /src/content/app/content_main_runner_impl.cc:973 (browser_tests+0x99a6eeb) #71 content::ContentServiceManagerMainDelegate::RunEmbedderProcess() /src/content/app/content_service_manager_main_delegate.cc:53:32 (browser_tests+0x99a414f) #72 service_manager::Main(service_manager::MainParams const&) /src/services/service_manager/embedder/main.cc:472:29 (browser_tests+0xd205c76) #73 content::ContentMain(content::ContentMainParams const&) /src/content/app/content_main.cc:19:10 (browser_tests+0x99a494b) #74 content::BrowserTestBase::SetUp() /src/content/public/test/browser_test_base.cc:322:3 (browser_tests+0xa863831) #75 InProcessBrowserTest::SetUp() /src/chrome/test/base/in_process_browser_test.cc:272:20 (browser_tests+0x9c3a89d) #76 testing::Test::Run() /src/googletest (browser_tests+0x562b70b) #77 testing::TestInfo::Run() /src/googletest (browser_tests+0x562c96c) #78 testing::TestCase::Run() /src/googletest (browser_tests+0x562d1f6) #79 testing::internal::UnitTestImpl::RunAllTests() /src/googletest (browser_tests+0x563d796) #80 testing::UnitTest::Run() /src/googletest (browser_tests+0x563d07a) #81 RUN_ALL_TESTS /src/googletest/include/gtest/gtest.h:2329:46 (browser_tests+0x9c5d7f5) #82 base::TestSuite::Run() /src/base/test/test_suite.cc:277 (browser_tests+0x9c5d7f5) #83 ChromeTestSuiteRunner::RunTestSuite(int, char**) /src/chrome/test/base/chrome_test_launcher.cc:65:38 (browser_tests+0x9a490f6) #84 ChromeTestLauncherDelegate::RunTestSuite(int, char**) /src/chrome/test/base/chrome_test_launcher.cc:74:19 (browser_tests+0x9a491ff) #85 content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) /src/content/public/test/test_launcher.cc:650:31 (browser_tests+0xa8c08de) #86 LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) /src/chrome/test/base/chrome_test_launcher.cc:170:10 (browser_tests+0x9a49784) #87 main /src/chrome/test/base/browser_tests_main.cc:36:10 (browser_tests+0x9a48fdc) Previous write of size 1 at 0x7b44000004d8 by thread T2: #0 CaptivePortalBrowserTest::SetBehindCaptivePortal(bool) /src/chrome/browser/captive_portal/captive_portal_browsertest.cc:745:28 (browser_tests+0x4eb12d8) #1 Invoke<void (CaptivePortalBrowserTest::*)(bool), CaptivePortalBrowserTest *, bool> /src/base/bind_internal.h:507:12 (browser_tests+0x4ed0549) #2 MakeItSo<void (CaptivePortalBrowserTest::*)(bool), CaptivePortalBrowserTest *, bool> /src/base/bind_internal.h:607 (browser_tests+0x4ed0549) #3 RunImpl<void (CaptivePortalBrowserTest::*)(bool), std::__1::tuple<base::internal::UnretainedWrapper<CaptivePortalBrowserTest>, bool>, 0, 1> /src/base/bind_internal.h:680 (browser_tests+0x4ed0549) #4 base::internal::Invoker<base::internal::BindState<void (CaptivePortalBrowserTest::*)(bool), base::internal::UnretainedWrapper<CaptivePortalBrowserTest>, bool>, void ()>::RunOnce(base::internal::BindStateBase*) /src/base/bind_internal.h:649 (browser_tests+0x4ed0549) #5 Run /src/base/callback.h:99:12 (browser_tests+0x9a92ee8) #6 base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) /src/base/debug/task_annotator.cc:101 (browser_tests+0x9a92ee8) #7 base::MessageLoop::RunTask(base::PendingTask*) /src/base/message_loop/message_loop.cc:432:46 (browser_tests+0x55f355a) #8 base::MessageLoop::DeferOrRunPendingTask(base::PendingTask) /src/base/message_loop/message_loop.cc:443:5 (browser_tests+0x55f3e7c) #9 base::MessageLoop::DoWork() /src/base/message_loop/message_loop.cc:487:16 (browser_tests+0x55f41c5) #10 base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) /src/base/message_loop/message_pump_libevent.cc:210:31 (browser_tests+0x9bfd9b4) #11 base::MessageLoop::Run(bool) /src/base/message_loop/message_loop.cc:374:12 (browser_tests+0x55f2c67) #12 non-virtual thunk to base::MessageLoop::Run(bool) /src/base/message_loop/message_loop.cc (browser_tests+0x55f2d54) #13 base::RunLoop::Run() /src/base/run_loop.cc:102:14 (browser_tests+0x55f6adf) #14 base::Thread::Run(base::RunLoop*) /src/base/threading/thread.cc:255:13 (browser_tests+0x9b8d22b) #15 content::BrowserProcessSubThread::IOThreadRun(base::RunLoop*) /src/content/browser/browser_process_sub_thread.cc:184:11 (browser_tests+0x6a95a06) #16 content::BrowserProcessSubThread::Run(base::RunLoop*) /src/content/browser/browser_process_sub_thread.cc:134:7 (browser_tests+0x6a95913) #17 base::Thread::ThreadMain() /src/base/threading/thread.cc:337:3 (browser_tests+0x9b8d80b) #18 base::(anonymous namespace)::ThreadFunc(void*) /src/base/threading/platform_thread_posix.cc:76:13 (browser_tests+0x9bf6458) Location is heap block of size 288 at 0x7b44000003c0 allocated by main thread: #0 operator new(unsigned long) /src/third_party/llvm/compiler-rt/lib/tsan/rtl/tsan_new_delete.cc:65:3 (browser_tests+0x330871d) #1 testing::internal::TestFactoryImpl<CaptivePortalBrowserTest_ShowCaptivePortalInterstitialOnCertError_Test>::CreateTest() /src/googletest/include/gtest/internal/gtest-internal.h:466:39 (browser_tests+0x4ed1d69) #2 testing::TestInfo::Run() /src/googletest (browser_tests+0x562c8ae) #3 testing::TestCase::Run() /src/googletest (browser_tests+0x562d1f6) #4 testing::internal::UnitTestImpl::RunAllTests() /src/googletest (browser_tests+0x563d796) #5 testing::UnitTest::Run() /src/googletest (browser_tests+0x563d07a) #6 RUN_ALL_TESTS /src/googletest/include/gtest/gtest.h:2329:46 (browser_tests+0x9c5d7f5) #7 base::TestSuite::Run() /src/base/test/test_suite.cc:277 (browser_tests+0x9c5d7f5) #8 ChromeTestSuiteRunner::RunTestSuite(int, char**) /src/chrome/test/base/chrome_test_launcher.cc:65:38 (browser_tests+0x9a490f6) #9 ChromeTestLauncherDelegate::RunTestSuite(int, char**) /src/chrome/test/base/chrome_test_launcher.cc:74:19 (browser_tests+0x9a491ff) #10 content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) /src/content/public/test/test_launcher.cc:650:31 (browser_tests+0xa8c08de) #11 LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) /src/chrome/test/base/chrome_test_launcher.cc:170:10 (browser_tests+0x9a49784) #12 main /src/chrome/test/base/browser_tests_main.cc:36:10 (browser_tests+0x9a48fdc) Thread T2 'Chrome_IOThread' (tid=37629, running) created by main thread at: #0 pthread_create /src/third_party/llvm/compiler-rt/lib/tsan/rtl/tsan_interceptors.cc:965:3 (browser_tests+0x329e755) #1 base::(anonymous namespace)::CreateThread(unsigned long, bool, base::PlatformThread::Delegate*, base::PlatformThreadHandle*, base::ThreadPriority) /src/base/threading/platform_thread_posix.cc:115:13 (browser_tests+0x9bf5d96) #2 base::PlatformThread::CreateWithPriority(unsigned long, base::PlatformThread::Delegate*, base::PlatformThreadHandle*, base::ThreadPriority) /src/base/threading/platform_thread_posix.cc:200:10 (browser_tests+0x9bf5c55) #3 base::Thread::StartWithOptions(base::Thread::Options const&) /src/base/threading/thread.cc:112:15 (browser_tests+0x9b8c8c5) #4 content::BrowserProcessSubThread::CreateIOThread() /src/content/browser/browser_process_sub_thread.cc:97:19 (browser_tests+0x6a9560e) #5 content::ContentMainRunnerImpl::Run(bool) /src/content/app/content_main_runner_impl.cc:953:29 (browser_tests+0x99a6cc8) #6 content::ContentServiceManagerMainDelegate::RunEmbedderProcess() /src/content/app/content_service_manager_main_delegate.cc:53:32 (browser_tests+0x99a414f) #7 service_manager::Main(service_manager::MainParams const&) /src/services/service_manager/embedder/main.cc:472:29 (browser_tests+0xd205c76) #8 content::ContentMain(content::ContentMainParams const&) /src/content/app/content_main.cc:19:10 (browser_tests+0x99a494b) #9 content::BrowserTestBase::SetUp() /src/content/public/test/browser_test_base.cc:322:3 (browser_tests+0xa863831) #10 InProcessBrowserTest::SetUp() /src/chrome/test/base/in_process_browser_test.cc:272:20 (browser_tests+0x9c3a89d) #11 testing::Test::Run() /src/googletest (browser_tests+0x562b70b) #12 testing::TestInfo::Run() /src/googletest (browser_tests+0x562c96c) #13 testing::TestCase::Run() /src/googletest (browser_tests+0x562d1f6) #14 testing::internal::UnitTestImpl::RunAllTests() /src/googletest (browser_tests+0x563d796) #15 testing::UnitTest::Run() /src/googletest (browser_tests+0x563d07a) #16 RUN_ALL_TESTS /src/googletest/include/gtest/gtest.h:2329:46 (browser_tests+0x9c5d7f5) #17 base::TestSuite::Run() /src/base/test/test_suite.cc:277 (browser_tests+0x9c5d7f5) #18 ChromeTestSuiteRunner::RunTestSuite(int, char**) /src/chrome/test/base/chrome_test_launcher.cc:65:38 (browser_tests+0x9a490f6) #19 ChromeTestLauncherDelegate::RunTestSuite(int, char**) /src/chrome/test/base/chrome_test_launcher.cc:74:19 (browser_tests+0x9a491ff) #20 content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) /src/content/public/test/test_launcher.cc:650:31 (browser_tests+0xa8c08de) #21 LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) /src/chrome/test/base/chrome_test_launcher.cc:170:10 (browser_tests+0x9a49784) #22 main /src/chrome/test/base/browser_tests_main.cc:36:10 (browser_tests+0x9a48fdc) SUMMARY: ThreadSanitizer: data race chrome/browser/captive_portal/captive_portal_browsertest.cc:984:9 in CaptivePortalBrowserTest::OnIntercept(content::URLLoaderInterceptor::RequestParams*) Change-Id: I58163d96f66f8ca3b2d257d1481b0d12f980c679 Reviewed-on: https://chromium-review.googlesource.com/c/1356582 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#613677}

This CL is putting back the |AbortScenario| code to the previous state. Landed here: https://chromium-review.googlesource.com/c/chromium/src/+/1289672 The "if (is_tracing_)" is required to avoid calling the tracing controller when it's not instantiated. This is only happening in the unittest. [ RUN ] BackgroundTracingTest.SetupBackgroundTracingFieldTrial [184899:184899:1204/184233.049256:3597383076062:FATAL:tracing_controller_impl.cc(283)] Check failed: g_tracing_controller. #0 0x7fefd86edf5d base::debug::StackTrace::StackTrace() #1 0x7fefd83ded3a base::debug::StackTrace::StackTrace() #2 0x7fefd8450a4b logging::LogMessage::~LogMessage() #3 0x7fefd461c1e1 content::TracingControllerImpl::GetInstance() #4 0x7fefd460e198 content::BackgroundTracingManagerImpl::AbortScenario() #5 0x55ec45d76fa2 BackgroundTracingTest::TearDown() #6 0x55ec473ff12e _ZN7testing8internal12InvokeHelperIvNSt3__15tupleIJEEEE12InvokeMethodIN10extensions27ExtensionDownloaderDelegateEMS8_FvvEEEvPT_T0_RKS4_ #7 0x55ec4846fc42 testing::internal::HandleExceptionsInMethodIfSupported<>() #8 0x55ec4844f2f8 testing::Test::Run() #9 0x55ec4844ff52 testing::TestInfo::Run() #10 0x55ec48450e5f testing::TestCase::Run() #11 0x55ec48464fcb testing::internal::UnitTestImpl::RunAllTests() #12 0x55ec4847946e testing::internal::HandleSehExceptionsInMethodIfSupported<>() #13 0x55ec48471472 testing::internal::HandleExceptionsInMethodIfSupported<>() #14 0x55ec48464c07 testing::UnitTest::Run() #15 0x55ec4aaa2bc1 RUN_ALL_TESTS() R=oysteine@chromium.org Change-Id: I9198c6db87a03daba5f75ece529f104ecbfe8609 Reviewed-on: https://chromium-review.googlesource.com/c/1361830 Reviewed-by: oysteine <oysteine@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#614056}

This reverts commit a612879. Reason for revert: Suspect Failure single_process_mash_ash_unittests Failure ash_unittests: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel/16943 https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8927839167159249024/+/steps/single_process_mash_ash_unittests/0/logs/LoginExpandedPublicAccountViewTest.ChangeMenuSelection/0 --- [ RUN ] LoginExpandedPublicAccountViewTest.ChangeMenuSelection Received signal 11 SEGV_MAPERR ffffe03f000008fe #0 0x5631a3caedbf base::debug::StackTrace::StackTrace() #1 0x5631a3cae941 base::debug::(anonymous namespace)::StackDumpSignalHandler() #2 0x7faa9920f330 <unknown> #3 0x5631a3aafbbf ash::LoginBubble::~LoginBubble() #4 0x5631a3ab806c ash::RightPaneView::~RightPaneView() #5 0x5631a3ab810e ash::RightPaneView::~RightPaneView() #6 0x5631a40385d4 views::View::~View() #7 0x5631a3ab6df9 ash::LoginExpandedPublicAccountView::~LoginExpandedPublicAccountView() #8 0x5631a40385d4 views::View::~View() #9 0x5631a300afce ash::(anonymous namespace)::DragTestView::~DragTestView() #10 0x5631a4039b42 views::View::DoRemoveChildView() #11 0x5631a403a175 views::View::RemoveAllChildViews() #12 0x5631a4043b81 views::internal::RootView::~RootView() #13 0x5631a400ef0e views::MenuHostRootView::~MenuHostRootView() #14 0x5631a404615f views::Widget::~Widget() #15 0x5631a34d645e exo::(anonymous namespace)::ShellSurfaceWidget::~ShellSurfaceWidget() #16 0x5631a30c36f0 ash::LoginTestBase::TearDown() Original change's description: > cros: Move most event/widget handling logic out of LoginBubble > > Changes made: > - Move the (keyboard/click/tap) event handling logic into a > LoginBubbleHandler class. > - Move the widget handling into LoginBaseBubbleView itself > > Bug: 912658 > Change-Id: Ia1a9bf4b8d847ef74ef1716e73dfe1b16b8d19b2 > Reviewed-on: https://chromium-review.googlesource.com/c/1366516 > Commit-Queue: Quan Nguyen <qnnguyen@chromium.org> > Reviewed-by: Jacob Dufault <jdufault@chromium.org> > Cr-Commit-Position: refs/heads/master@{#614544} TBR=jdufault@chromium.org,qnnguyen@chromium.org Change-Id: Ia9b9059f24f6aa6a8551c5c6bc5c76caafe592df No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 912658 Reviewed-on: https://chromium-review.googlesource.com/c/1367070 Reviewed-by: Takashi Sakamoto <tasak@google.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#614579}

TBR=mmoss@chromium.org Change-Id: Iea1c8832f88e0db26686faff8b2dbeecc3ba9e98 Reviewed-on: https://chromium-review.googlesource.com/c/1279365 Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#7} Cr-Branched-From: 4226ddf-refs/heads/master@{#599034}

TableViewTextItem.textColor. The Canary crashes when a TableViewTextItem configures its cell and checks its "textColor" property, which is "assign" and might get released after assigned. This CL fixes it by changing the property's "assign" attribute to "strong" so that the UIColor object will be retained. Bug: 910542 Change-Id: I44b6a60c52c5a470e69a44ca6670720446ef084b Reviewed-on: https://chromium-review.googlesource.com/c/1356585 Reviewed-by: Sergio Collazos <sczs@chromium.org> Reviewed-by: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#612716}(cherry picked from commit 17c608f) Reviewed-on: https://chromium-review.googlesource.com/c/1356809 Reviewed-by: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#7} Cr-Branched-From: d897fb1-refs/heads/master@{#612437}

This reverts commit 9b90992. Reason for revert: Suspect: causes extensions_unittests failures on LinuxTests(dbg)(1). https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests%20%28dbg%29%281%29/78307 https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8921108554761775344/+/steps/extensions_unittests/0/logs/GinPortTest.TestJSDisconnect__status_CRASH_/0 --- [ RUN ] GinPortTest.TestJSDisconnect # Fatal error in ../../v8/src/base/atomic-utils.h, line 181 # Debug check failed: old >= amount (12874 vs. 13036). # # # #FailureMessage Object: 0x7ffe772cb570#0 0x7fcc15c67441 base::debug::CollectStackTrace() #4 0x7fcbf34d4a98 V8_Fatal() #5 0x7fcbf34d4805 v8::base::(anonymous namespace)::DefaultDcheckHandler() #6 0x7fcc05ae9b34 v8::internal::Heap::FinalizeExternalString() #7 0x7fcc05af3c0e v8::internal::Heap::ExternalStringTable::TearDown() #8 0x7fcc05af37ed v8::internal::Heap::TearDown() #9 0x7fcc05c1e90b v8::internal::Isolate::Deinit() #10 0x7fcc05c1e595 v8::internal::Isolate::Delete() #11 0x7fcc05184d38 gin::IsolateHolder::~IsolateHolder() #12 0x5635a0f5381b std::__Cr::default_delete<>::operator()() #13 0x5635a0f5375f std::__Cr::unique_ptr<>::reset() #14 0x5635a193afd5 extensions::APIBindingTest::TearDown() #15 0x56359fcf3ddf extensions::(anonymous namespace)::GinPortTest::TearDown() #16 0x56359fd693ee testing::internal::HandleSehExceptionsInMethodIfSupported<>() --- Original change's description: > Update V8 to version 7.4.196. > > Summary of changes available at: > https://chromium.googlesource.com/v8/v8/+log/fee9be7a..9f489e34 > > Please follow these instructions for assigning/CC'ing issues: > https://github.com/v8/v8/wiki/Triaging%20issues > > Please close rolling in case of a roll revert: > https://v8-roll.appspot.com/ > This only works with a Google account. > > CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel > > TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com > > Change-Id: I2422c4d7e92bb63dba87b15567bde4a108536222 > Reviewed-on: https://chromium-review.googlesource.com/c/1477512 > Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#633211} TBR=hablich@chromium.org,v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I23bea79ec5187e545b0604b1f4706152e2aa037a No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/c/1477147 Reviewed-by: Takashi Sakamoto <tasak@google.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#633217}

TBR=govind@chromium.org Change-Id: Id9a3f237122ff52b85a76758edf9d1f41ba89d58 Reviewed-on: https://chromium-review.googlesource.com/c/1437835 Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/branch-heads/3683@{#7} Cr-Branched-From: e510299-refs/heads/master@{#625896}

[TEMP] fixup! c++ / mojo changes for 'external window mode' (Igalia#7)

8334db3

-- Use DefaultAccessPolicy as long as WindowManagerAccessPolicy causes InFlightChange to end up with CHECK(false) Figure out how to handle these policies

msisov force-pushed the ozone-wayland-chrome branch from 9a36d33 to 8334db3 Compare March 29, 2017 12:04

fred-wang merged commit f56c872 into Igalia:ozone-wayland-chrome Mar 29, 2017

tonikitoo reviewed Mar 29, 2017

View reviewed changes

tonikitoo mentioned this pull request Apr 3, 2017

"Handle OnBoundsChange in external mode. (#8)" crashes on me often #14

Closed

tonikitoo pushed a commit to tonikitoo/chromium that referenced this pull request Apr 5, 2017

Revert "fixup! c++ / mojo changes for 'external window mode' (Igalia#7)…

372fdad

… (Igalia#7)" This reverts commit 974c39f.

tonikitoo mentioned this pull request Apr 10, 2017

SetBounds (downstream) CL crashes chromeos/chrome --mash runs and linux_os/chrome --mus #41

Closed

tonikitoo mentioned this pull request Apr 11, 2017

Crash on gmail #42

Closed

tonikitoo mentioned this pull request Apr 21, 2017

fix missing tab strip on chrome/mus windows #56

Closed

jkim-julie mentioned this pull request Aug 9, 2018

Crashed with --ozone-platform=headless or x11 #475

Closed

jkim-julie mentioned this pull request Aug 16, 2018

fixed crash on content_browsertests. #478

Merged

jkim-julie mentioned this pull request Aug 22, 2018

fixup! [ozone/x11/headless] Use FakeInputMethodContextFactory to avoi… #480

Merged

newperson1746 mentioned this pull request Oct 11, 2018

Crash on startup on Ubuntu 18.04 #492

Closed

etna mentioned this pull request Feb 10, 2019

Crash on startup with signal 11 SEGV_MAPPER 000000000000 #530

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fixup! c++ / mojo changes for 'external window mode' (#7) #7

fixup! c++ / mojo changes for 'external window mode' (#7) #7

msisov commented Mar 29, 2017

fred-wang commented Mar 29, 2017

fred-wang commented Mar 29, 2017

msisov commented Mar 29, 2017

tonikitoo left a comment

fred-wang commented Mar 29, 2017

fixup! c++ / mojo changes for 'external window mode' (#7) #7

fixup! c++ / mojo changes for 'external window mode' (#7) #7

Conversation

msisov commented Mar 29, 2017

fred-wang commented Mar 29, 2017

fred-wang commented Mar 29, 2017

msisov commented Mar 29, 2017

tonikitoo left a comment

Choose a reason for hiding this comment

fred-wang commented Mar 29, 2017