Add a CogFallbackPlatform implementation #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is something I had in a local branch with improvements to the ease of use of the public API, and could be easile extracted into its own patch set. Tested with WPEBackend-rdk built with its Wayland-EGL support, but I expect all other build modes should work, as well as other WPE backends which support this mode of operation 😉 |
zdobersek
approved these changes
May 17, 2023
This adds a new CogFallbackPlatform implementation, which gets built into the core library. Instead of requiring applications to implement themselves the needed code to use plain WPE backends (like WPEBackend-rdk), they can rely on a CogPlatform instance being always instantiated and available. The implementation is registered to the GIO extension point automatically and always available. This new platform has the lowest possible priority and needs to be manually selected: while it is debatable that it should have more priority than the headless platform, keeping it this aligns better with existing behaviour.
Remove the code from the launcher that handled plain WPE backends (like WPEBackend-rdk); which the new CogFallbackPlatform can take care of.
aperezdc
force-pushed
the
aperezdc/fallback-platform
branch
from
2c0b5fe
to
49c7df7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes two commits:
CogFallbackPlatformimplementation, which can handle plain WPE backends (like WPEBackend-rdk). This gets built into the core library and thus is always available, instead of building it as a plug-in.CogFallbackPlatform.