HiDPI support

[tokyovigilante]

Enables Wayland HiDPI support. Also scale pointer
events by scale factor to match display. Closes #16.
Requires libwpe 1.3.0 and WebKit built with this patch -
https://bugs.webkit.org/attachment.cgi?id=369667&action=diff

[aperezdc]

Thanks a lot for this patch! The logic in the code works like a charm (I did test it, even!) and my comments are mainly about coding style changes. Please take a look, and I hope you can find some time to update the PR—next time it will be reviewed much faster, I promise 🤝

[aperezdc]

I think this PR is looking good, so I'll wait until Monday for merging—just in case anyone else wants to check it out and give feedback before that. Thanks a lot again, @tokyovigilante!

[tokyovigilante]

No problem! Was easy enough to get the code into Cog once all the WPE plumbing was done. Is there any chance an upcoming WPE release will have the relevant HiDPI changes included?

[aperezdc]

@tokyovigilante The 2.26.x stable series, and the 2.25.x development ones, will include all the changes, and we will be releasing 2.26.0 sometime in between the end of October and beginning of November. If you would really, really like to have the HiDPI support in stable releases before that, luckily the changes are all backwards-compatible, so we could look into backporting the feature to be in WPE WebKit 2.24.3 and Cog 0.3.1

[zdobersek]

Do we also need to apply wl_data.current_output.scale to coordinates for the touch events?

[tokyovigilante]

The 2.26.x stable series, and the 2.25.x development ones, will include all the changes, and we will be releasing 2.26.0 sometime in between the end of October and beginning of November.

Cool, I'm not fussed personally as I'm just manually applying the patch to the 2.24 series, but it would be nice to have them filter downstream sooner rather than later as I'm eventually hoping to distribute an app based on WPE.

@zdobersek Almost certainly yes, good catch! I haven't implemented touch in my own app yet so missed that. Will update those events and re-push.

[tokyovigilante]

Fixed and tested touch events, thanks!

[aperezdc]

Thanks to @zdobersek for the extra review, and to @tokyovigilante for adding the needed changes so quickly. I consider that this is now good for merging 💪

[tokyovigilante]

Thanks!

…

On Tue, 4 Jun 2019, at 1:17 AM, Adrian Perez wrote: Merged #94 <#94> into master. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#94?email_source=notifications&email_token=AAADFKZBIJ23W7MDWMLUGILPYUYY3A5CNFSM4HMJXMK2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGORYWF44Y#event-2385272435>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAADFK2XFLWDFS2OLFPTSU3PYUYY3ANCNFSM4HMJXMKQ>.