fix(igxGrid): When autosizing something with template that may need t… #13950
Conversation
…ime post injection in DOM to fully initialize, skip initial renders when the cell is still with no content.
IMinchev64
added
💥 status: in-test
| emptyCellWithPaddingOnly = parseFloat(cellStyle.paddingLeft) + parseFloat(cellStyle.paddingRight); | ||
| } | ||
|
|
||
| if (max === 0 || max <= emptyCellWithPaddingOnly) { |
There was a problem hiding this comment.
Um, is it me or does this have the potential for looping hard and also possibly affecting the Angular product as well? Assuming there is a template that literally renders nothing on purpose for whatever reason (for example conditionally shown button), would this not get stuck trying to measure that empty column until something is rendered?
There was a problem hiding this comment.
Outside of my previous comment about the possibility of the column remaining in content-fit mode if the template is intentionally empty which is pretty unlikely, I think we can accept that fix initially.
Still think we can improve, since it's a targeted scenario and we can only re-test the column one more time after the DOM is ready, though that might require some more digging to figure out the exact order of events
…ime post injection in DOM to fully initialize, skip initial renders when the cell is still with no content.
For IgniteUI/igniteui-webcomponents#1046
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)