fix(igxGrid): Add a more targeted fix to skip only the first initial … #14003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…render when autosizing an initially empty cell.
…rs once on init, add flag for first auto size, add dedicated check for late rendered template scenario.
damyanpetev
reviewed
May 16, 2024
| @@ -6757,7 +6769,7 @@ export abstract class IgxGridBaseDirective extends DisplayDensityBase implements | |||
| if (this.hasColumnsToAutosize) { | |||
| this.cdr.detectChanges(); | |||
| this.zone.onStable.pipe(first()).subscribe(() => { | |||
| this.autoSizeColumnsInView(); | |||
| this._autoSizeColumnsNotify.next(); | |||
There was a problem hiding this comment.
Just this.zone.onStable.pipe(first()).subscribe(this._autoSizeColumnsNotify); should do too
There was a problem hiding this comment.
It doesn't seem to trigger correctly like that:
tishko0
added
✅ status: verified
damyanpetev
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…render when autosizing an initially empty cell.
Closes IgniteUI/igniteui-webcomponents#1046
Related to:#13950 (review)
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)