Skip to content

Conversation

Lipata
Copy link
Member

@Lipata Lipata commented Aug 19, 2025

Seems like a regression in node 22.18.0: nodejs/node#59364

Having a specific 22.17.1 version is a reasonable solution for the moment, because it is expected the issue above to be fixed. Some of the workarounds suggested weren't working (e.g. 76bb3dc). The other solution could be to set the following: https://github.com/balena-io/balena-sdk/pull/1564/files.

Additional information (check all that apply):

  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR

Copilot

This comment was marked as outdated.

@Lipata Lipata requested a review from Copilot August 20, 2025 08:26
Copilot

This comment was marked as outdated.

@Lipata Lipata requested a review from Copilot August 20, 2025 08:51
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses a Node.js regression issue in version 22.18.0 that affects ts-node functionality by adding a specific NODE_OPTIONS flag to disable experimental strip-types feature for the schematics test.

  • Adds NODE_OPTIONS="--no-experimental-strip-types" specifically for the schematics test command
  • Works around a known Node.js 22.18.0 regression that breaks ts-node execution

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

NODE_OPTIONS="--no-experimental-strip-types" npm run test:schematics
npm run test:i18n
env:
NODE_OPTIONS: --max_old_space_size=4096
Copy link
Preview

Copilot AI Aug 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The NODE_OPTIONS environment variable is being set both inline for the schematics test and globally in the env section. This creates inconsistent configuration and potential conflicts. Consider either moving the --no-experimental-strip-types flag to the global NODE_OPTIONS or ensuring the inline setting properly overrides the global one.

Suggested change
NODE_OPTIONS: --max_old_space_size=4096
npm run test:schematics
npm run test:i18n
env:
NODE_OPTIONS: --max_old_space_size=4096 --no-experimental-strip-types

Copilot uses AI. Check for mistakes.

@Lipata Lipata merged commit 8a63bac into master Aug 21, 2025
5 checks passed
@Lipata Lipata deleted the nalipiev/node-22 branch August 21, 2025 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant