feat: Deprecate ApiResponse.translatedError #340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LunarX
force-pushed
the
deprecate-translatedError-upgrade-translateError
branch
from
e7ced6d to
99cb30c
Compare
sirambd
requested changes
May 1, 2025
Legacy/src/main/java/com/infomaniak/lib/core/api/ApiController.kt
Outdated
Show resolved
Hide resolved
Legacy/src/main/java/com/infomaniak/lib/core/utils/ApiErrorCode.kt
Outdated
Show resolved
Hide resolved
LunarX
force-pushed
the
deprecate-translatedError-upgrade-translateError
branch
from
fe02259 to
79ccbed
Compare
LunarX
force-pushed
the
deprecate-translatedError-upgrade-translateError
branch
from
79ccbed to
1249b8c
Compare
sirambd
approved these changes
May 2, 2025
… a core error for mail
…ly expose toApiError()
LunarX
force-pushed
the
deprecate-translatedError-upgrade-translateError
branch
from
3f8ae06 to
14ea13a
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This required to handle error messages that were translated through
ApiResponse.translatedErrorand also translate them through the new alternativetranslateError().At the same time, we took this opportunity to replace the ServerError message that was displayed to the user when receiving a 500 with the generic "an error has occurred" to not give useless info to the user and be iso with iOS.