Skip to content

Fix uploader #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 21, 2022
Merged

Fix uploader #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a7caa91
fix: fix typo
klyse Apr 21, 2022
eaed19d
fix: get_authorization_header call
klyse Apr 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion portal_client/client_application_uploader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ def set_version_as_current(self, slug, version):
return requests.patch(
urljoin(self.base_url, f"{slug}/"),
data={"current_version": version},
headers={"Authorization": self.get_authorization_header()},
headers={"Authorization": get_authorization_header()},
)


Expand Down
8 changes: 4 additions & 4 deletions portal_client/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,20 +6,20 @@ def get_authorization_header():
if os.getenv("PORTAL_BACKEND_ACCESS_TOKEN"):
return "Bearer %s" % os.getenv("PORTAL_BACKEND_ACCESS_TOKEN")

if os.getenv("POTAL_BACKEND_USERNAME") and os.getenv("POTAL_BACKEND_PASSWORD"):
if os.getenv("PORTAL_BACKEND_USERNAME") and os.getenv("PORTAL_BACKEND_PASSWORD"):
return "Basic {}".format(
b64encode(
bytes(
"%s:%s"
% (
os.getenv("POTAL_BACKEND_USERNAME"),
os.getenv("POTAL_BACKEND_PASSWORD"),
os.getenv("PORTAL_BACKEND_USERNAME"),
os.getenv("PORTAL_BACKEND_PASSWORD"),
),
"utf-8",
)
).decode("ascii")
)

raise Exception(
"Missing authentication! Please specify either PORTAL_BACKEND_ACCESS_TOKEN or POTAL_BACKEND_USERNAME and POTAL_BACKEND_PASSWORD"
"Missing authentication! Please specify either PORTAL_BACKEND_ACCESS_TOKEN or PORTAL_BACKEND_USERNAME and PORTAL_BACKEND_PASSWORD"
)