COMP: Remove LEGACY off mode in backport

The backported AnatomicalOrientation is explicitly available
for the purpose of providing an easy long-term conversion
to the new paradigm.

Have conditional support for deprecating features of future
support makes the backport unnecessarily complicated.

Using a separate commit to remove the backported future
deprecation elements to minimize the changes from the original
files.

Author: hjmjohnson

Modules/Core/Common/include/itkAnatomicalOrientation.h

@@ -20,9 +20,7 @@
 
 #include "ITKCommonExport.h"
 #include "itkImageBase.h"
-#ifndef ITK_FUTURE_LEGACY_REMOVE
-#  include "itkSpatialOrientation.h"
-#endif
+#include "itkSpatialOrientation.h"
 #include <map>
 #include <string>
 
@@ -57,9 +55,7 @@ class ITKCommon_EXPORT AnatomicalOrientation
   using DirectionType = typename ImageBase<Dimension>::DirectionType;
   static constexpr unsigned int ImageDimension = Dimension;
 
-#ifndef ITK_FUTURE_LEGACY_REMOVE
   using LegacyOrientationType = SpatialOrientationEnums::ValidCoordinateOrientations;
-#endif
 
   // Anatomical names for an axis.
   //
@@ -433,16 +429,11 @@ class ITKCommon_EXPORT AnatomicalOrientation
     : m_Value(PositiveEnum(static_cast<uint32_t>(fromOrientation)))
   {}
 
-#ifndef ITK_FUTURE_LEGACY_REMOVE
   /** \brief Conversion from Legacy SpatialOrientation
    *
    * @param legacyOrientation
    */
-#  if defined(ITK_LEGACY_REMOVE) && !defined(ITK_LEGACY_SILENT) && !defined(ITK_WRAPPING)
-  [[deprecated("Use the AnatomicalOrientation::FromEnum type instead.")]]
-#  endif
   AnatomicalOrientation(LegacyOrientationType legacyOrientation);
-#endif
 
   /** Conversion for a Direction Cosine Matrix to the closest anatomical orientation. Any partial axis rotations are
    *  rounded to the nearest axis, and lost in this conversion.

Modules/Core/Common/src/itkAnatomicalOrientation.cxx

@@ -16,21 +16,17 @@
  *
  *=========================================================================*/
 #include "itkAnatomicalOrientation.h"
-#ifndef ITK_FUTURE_LEGACY_REMOVE
-#  include "itkSpatialOrientationAdapter.h"
-#endif
+#include "itkSpatialOrientationAdapter.h"
 
 namespace itk
 {
 
 
-#ifndef ITK_FUTURE_LEGACY_REMOVE
 AnatomicalOrientation::AnatomicalOrientation(LegacyOrientationType legacyOrientation)
   : AnatomicalOrientation(SpatialOrientationAdapter().ToDirectionCosines(legacyOrientation))
 {
   assert(uint32_t(legacyOrientation) == uint32_t(m_Value));
 }
-#endif
 
 
 std::string

Modules/Core/Common/test/itkAnatomicalOrientationGTest.cxx

@@ -19,9 +19,7 @@
 #include <gtest/gtest.h>
 
 #include "itkGTest.h"
-#ifndef ITK_FUTURE_LEGACY_REMOVE
-#  define ITK_LEGACY_SILENT
-#endif
+#define ITK_LEGACY_SILENT
 #include "itkAnatomicalOrientation.h"
 #include "itkImage.h"
 #include <sstream>
@@ -247,8 +245,7 @@ TEST(AntomicalOrientation, ToFromEnumInteroperability)
   EXPECT_EQ(itk_rai.GetTerms(), expected_terms);
 }
 
-#ifndef ITK_FUTURE_LEGACY_REMOVE
-#  include "itkSpatialOrientation.h"
+#include "itkSpatialOrientation.h"
 TEST(AnatomicalOrientation, LegacyInteroperability)
 {
 
@@ -266,4 +263,3 @@ TEST(AnatomicalOrientation, LegacyInteroperability)
   EXPECT_EQ(itk_rai.GetAsPositiveOrientation(), OE::LPS);
   EXPECT_EQ(itk_rai.GetAsPositiveStringEncoding(), "LPS");
 }
-#endif