Add viewer features #449
Merged
Add viewer features #449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
bnmajor
commented
Jun 14, 2022
bnmajor
commented
- Make the viewer fullscreen in Colab notebooks
- Add wrappers for the ImJoy Plugin setter endpoints
- Support setting point sets
bnmajor
force-pushed
the
add-viewer-features
branch
from
abb1dac to
9bb5956
Compare
thewtex
reviewed
Jun 14, 2022
| self._init_viewer_kwargs.update(**add_data_kwargs) | ||
|
|
||
| def _get_input_data(self): | ||
| input_options = ['data', 'image', 'point_sets'] |
There was a problem hiding this comment.
For simplicity, let's support initialization with a single point_set and geometry going forward.
bnmajor
force-pushed
the
add-viewer-features
branch
2 times, most recently
from
c1951ca to
dd79142
Compare
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
bnmajor
force-pushed
the
add-viewer-features
branch
from
dd79142 to
c715de6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.