BUG: Fix display in Jupyter Notebook #457
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving the viewer initialization into the
run
function prevents the viewer from being displayed as a dialog in the Jupyter Notebook and instead displays it inline as expected. This also prevents the multiple window creation that was happening in Colab. From the ImJoy docs:I am not entirely sure why this change would affect the way that the output is displayed but this change better matches the examples that ImJoy provides (computation plugin, itk-vtk-viewer, image viewer)