Skip to content

Label fixes #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 2, 2022
Merged

Label fixes #488

merged 4 commits into from
Aug 2, 2022

Conversation

bnmajor
Copy link
Collaborator

@bnmajor bnmajor commented Aug 1, 2022 •
edited
Loading

  • Fixes another bug that was introduced by the incorrectly resolved merge conflicts. Support for the label_image input was lost, added back in now.
  • Adds the label_image info to the doc string
  • Updates the MONAI example notebook to use label_image

Relies on the changes in Kitware/itk-vtk-viewer#538

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@bnmajor bnmajor requested a review from thewtex August 1, 2022 18:11
@bnmajor bnmajor requested a review from labdala August 1, 2022 20:22
labdala
labdala approved these changes Aug 2, 2022
View reviewed changes
Copy link
Collaborator

@labdala labdala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@bnmajor bnmajor merged commit 82a29ab into InsightSoftwareConsortium:main Aug 2, 2022
@bnmajor bnmajor deleted the label-fixes branch August 2, 2022 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@labdala labdala labdala approved these changes

@thewtex thewtex Awaiting requested review from thewtex

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bnmajor @labdala