Skip to content

BUG: ImJoy extension options were flipped #501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 9, 2022
Merged

BUG: ImJoy extension options were flipped #501

merged 1 commit into from
Aug 9, 2022

Conversation

bnmajor
Copy link
Collaborator

@bnmajor bnmajor commented Aug 9, 2022

Flip

lab = [ "imjoy-jupyter-extension >=0.3.0", "imjoy-elfinder[jupyter]" ]
notebook = [ "imjoy-jupyterlab-extension >=0.1.13", "imjoy-elfinder[jupyter]" ]

to be

lab = [ "imjoy-jupyterlab-extension >=0.1.13", "imjoy-elfinder[jupyter]" ]
notebook = [ "imjoy-jupyter-extension >=0.3.0", "imjoy-elfinder[jupyter]" ]

@bnmajor bnmajor requested a review from thewtex August 9, 2022 17:17
thewtex
thewtex approved these changes Aug 9, 2022
View reviewed changes
Copy link
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find!

@thewtex thewtex merged commit 9fd54d9 into InsightSoftwareConsortium:main Aug 9, 2022
@bnmajor bnmajor deleted the fix-options branch November 22, 2022 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thewtex thewtex thewtex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bnmajor @thewtex