BUG: Fix aiohttp dep for Python 3.11 #681
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The imjoy-elfinder dependency brings in aiohttp but <= 3.8.2 does not build for Python 3.11. For 3.11 make sure we use aiohttp>=3.8.2. aio-libs/aiohttp#6600
thewtex
approved these changes
Sep 28, 2023
|
When I tried to install the released version of itkwidgets on Python 3.11, I ran into build issues on Linux, too, even with this patch. This is intended to address: imjoy-team/imjoy-elfinder#607 |
|
@thewtex Thanks! I have merged the PR and released |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported by @aylward: Trying to pip install --pre itkwidgets[all] produces an error when trying to compile aiohttp
The imjoy-elfinder dependency brings in aiohttp but <= 3.8.2 does not build for Python 3.11. For 3.11 make sure we use aiohttp>=3.8.2.
Stack Overflow discussion with links to relevant issues.