Skip to content

Conversation

bnmajor
Copy link
Collaborator

@bnmajor bnmajor commented Dec 8, 2023

No description provided.

@bnmajor bnmajor requested review from thewtex and PaulHax December 8, 2023 19:48
to_ngff_zarr(store, image, chunk_store=chunk_store)
return store

if isinstance(image, zarr.storage.Store):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To support more cases, can we use zarr.storage.BaseStore?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yes! 👍

Copy link
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎇

@bnmajor bnmajor merged commit b902da2 into InsightSoftwareConsortium:main Dec 11, 2023
@bnmajor bnmajor deleted the pass-store-to-viewer branch December 11, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants