Skip to content

Conversation

AliAbdelfattah
Copy link
Contributor

@AliAbdelfattah AliAbdelfattah commented Jun 13, 2022

Description of the change

  • Fixes an issue with network responses of type JSON not getting logged
  • Fixes an issue that may cause the android build to fail
  • Fixes an issue with iOS autolinking that causes the user local path to be referenced in xcode

Type of change

  • Bug fix (non-breaking change that fixes an issue)

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

Ali Abdelfattah and others added 5 commits June 12, 2022 20:20
…d resources (#720)

* Add CI job to validate shell files

* Fix Android shell script error

Remove extra fi operator

* Increase e2e_android job resources
@codecov
Copy link

codecov bot commented Jun 13, 2022

Codecov Report

Merging #724 (db1fa09) into master (234be08) will increase coverage by 1.19%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #724      +/-   ##
==========================================
+ Coverage   88.62%   89.81%   +1.19%     
==========================================
  Files          22       22              
  Lines         457      599     +142     
  Branches       90       93       +3     
==========================================
+ Hits          405      538     +133     
- Misses         44       53       +9     
  Partials        8        8              
Impacted Files Coverage Δ
utils/XhrNetworkInterceptor.js 88.78% <100.00%> (-1.12%) ⬇️
models/Trace.js 10.00% <0.00%> (-4.29%) ⬇️
modules/NetworkLogger.js 93.02% <0.00%> (-1.58%) ⬇️
models/Report.js 100.00% <0.00%> (ø)
modules/Replies.js 100.00% <0.00%> (ø)
modules/Surveys.js 100.00% <0.00%> (ø)
utils/IBGEventEmitter.js 100.00% <0.00%> (ø)
modules/CrashReporting.js 100.00% <0.00%> (ø)
jest/fakeNetworkRequest.js 100.00% <0.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ade4d7c...db1fa09. Read the comment docs.

DavidMina96
DavidMina96 previously approved these changes Jun 13, 2022
Ali Abdelfattah and others added 3 commits June 13, 2022 15:33
* Update package.json

* Update config.yml
…ute (#726)

* Fix iOS Autolinking Script Path

* Update CHANGELOG.md

Co-authored-by: Ali Abdelfattah <ali.abdelfattah.xa@gmail.com>
@AliAbdelfattah AliAbdelfattah marked this pull request as ready for review June 13, 2022 15:02
@DavidMina96 DavidMina96 self-requested a review June 13, 2022 15:23
@ymabdallah ymabdallah merged commit cacec43 into master Jun 13, 2022
@ymabdallah ymabdallah deleted the release/11.0.1 branch June 13, 2022 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants