[MOB-8895] Improve iOS Autolinking through leveraging the path attribute #726
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AliAbdelfattah
force-pushed
the
fix/ios-autolinking-path
branch
from
3b734c6 to
3613934
Compare
AliAbdelfattah
changed the title
AliAbdelfattah
approved these changes
Jun 13, 2022
AliAbdelfattah
changed the title
ymabdallah
pushed a commit
that referenced
this pull request
Jun 13, 2022
* Bump version to 11.0.1 * fix(android): remove unmatched 'fi' token in android upload_sourcemap.sh (#722) * [MOB-8883] Add CI job to validate shell files and increase e2e_android resources (#720) * Add CI job to validate shell files * Fix Android shell script error Remove extra fi operator * Increase e2e_android job resources * Fix Network-related Tests (#723) * Update CHANGELOG.md * Run Dependabot in Root Only (#721) * [MOB-8892] Update codecov version (#725) * Update package.json * Update config.yml * Increase CI emulator memory (#727) * [MOB-8895] Improve iOS Autolinking through leveraging the path attribute (#726) * Fix iOS Autolinking Script Path * Update CHANGELOG.md Co-authored-by: Ali Abdelfattah <ali.abdelfattah.xa@gmail.com> Co-authored-by: Matthew Koevort <35453138+matt-koevort@users.noreply.github.com> Co-authored-by: Youssef Raafat <99807625+TheBuggedYRN@users.noreply.github.com>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Problem:
The absolute user path for the sourcemap script is included in Xcode build phases with pod installs.
Solution
Rely on Autolinking's path attribute to copy the sourcemap script into Xcode build phases, so that the build phase would execute the script directly and not rely on executing a script at a given path.
Type of change
Related issues
Checklists
Development
Code review