Skip to content

Relax activesupport dependency for rails 5 #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

OAbubakr
Copy link

Problem:

Gem was not compatible with rails 5.4

Solution:

Relaxing gem version dependency

Notes:

Check usage of gem with rails 5.4 and it works fine.

QC Notes:

TODO: What parts/flows of the app are affected by this change?

Release steps:

TODO: steps needed for the release. If no special handling needed, please write 'Normal Release'

Security:

TODO: Are the changes exposed publicly or internally?

TODO: Do all new endpoints impose proper access to authorized users only?

Network:

TODO: Link to Ops PR if any. Type N/A if none.

TODO: List new internal/external services communications that were introduced in this PR. Type N/A if none.

Author checklist:

  • Backward compatibility checked
  • Release steps added
  • Unit tests added (if code logic is touched)
  • JIRA ticket moved to Reviewing
  • Rebased to latest master
  • Commits are clean

Reviewer checklist:

  • Backward compatibility checked
  • Code quality is acceptable
  • Specs logic coverage
  • Commits are clean

@ahmedakef
Copy link

@ahmedakef ahmedakef closed this Feb 21, 2022
@ahmedakef ahmedakef deleted the relax-activesupport-dependency-version branch February 21, 2022 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants