Skip to content
This repository was archived by the owner on Feb 2, 2024. It is now read-only.

Conversation

Hardcode84
Copy link
Contributor

Overloads inlining is available but not enabled yet.

Had to remove *args param from Series idxmin, idxmax and and cumsum due to numba regaression (will report to numba).

@pep8speaks
Copy link

pep8speaks commented Dec 11, 2019

Hello @Hardcode84! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 362:30: E261 at least two spaces before inline comment

Line 43:40: E127 continuation line over-indented for visual indent
Line 44:40: E127 continuation line over-indented for visual indent

Line 41:36: E127 continuation line over-indented for visual indent

Line 39:36: E127 continuation line over-indented for visual indent

Line 37:36: E127 continuation line over-indented for visual indent

Comment last updated at 2019-12-12 14:59:00 UTC

Vyacheslav-Smirnov and others added 4 commits December 12, 2019 14:19
 - Add llvm-openmp and intel-openmp to host section in meta.yaml
 - test_df_apply
 - test_df_apply_branch
 - test_ts_map_date2
 - test_agg_multikey_parallel
 - test_agg_parallel
 - test_agg_parallel_std
 - test_agg_parallel_var
 - test_agg_seq
 - test_agg_seq_std
 - test_agg_seq_str
 - test_agg_seq_var
 - test_muti_hiframes_node_filter_agg
@Vyacheslav-Smirnov Vyacheslav-Smirnov changed the title WIP: Merge numba-master and update numba to recent version with overloads inlining Merge numba-master and update numba to recent version with overloads inlining Dec 12, 2019
@Vyacheslav-Smirnov Vyacheslav-Smirnov merged commit 1b1f627 into IntelPython:master Dec 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants