Skip tests for CI with SDC_CONFIG_PIPELINE_SDC=False #340

PokhodenkoSA · 2019-11-26T22:33:50Z

This PR is based on PR from @Vyacheslav-Smirnov #301 which configures CI for running with SDC_CONFIG_PIPELINE_SDC=False.

This PR introduces convenient decorators skip_numba_jit and skip_sdc_jit for skipping tests and easy search it in code.
Inside this decorators implementations you can see in code how to switch them off (for unskip tests during development) by uncommenting one line.

I have based on the commit which is before #338 merged. From discussion I understand that it is not ready yet to be merged. If it is ok with this merge then my PR should be rebased.

This PR removes TestSeriesNumba because I understand that running numba.jit with SDC_CONFIG_PIPELINE_SDC=True has no sense. So number of tests for series is not doubled again.

In conclusion, my and @Vyacheslav-Smirnov modifications both enable CI with SDC_CONFIG_PIPELINE_SDC=False and skips tests for making it green. I hope so.

Merge changes from origin repo

Merge changes from sdc master

- Expected that ~35% overall tests are failed

…sts now

Added by mistake

Merge changes from SDC master

…hout MPI

pep8speaks · 2019-11-26T22:34:01Z

Hello @PokhodenkoSA! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file sdc/tests/test_basic.py:

Line 40:36: E127 continuation line over-indented for visual indent
Line 41:36: E127 continuation line over-indented for visual indent

In the file sdc/tests/test_d4p.py:

Line 42:40: E127 continuation line over-indented for visual indent
Line 43:40: E127 continuation line over-indented for visual indent

In the file sdc/tests/test_dataframe.py:

Line 39:36: E127 continuation line over-indented for visual indent
Line 40:36: E127 continuation line over-indented for visual indent

In the file sdc/tests/test_date.py:

Line 37:36: E127 continuation line over-indented for visual indent
Line 38:36: E127 continuation line over-indented for visual indent

In the file sdc/tests/test_groupby.py:

Line 36:36: E127 continuation line over-indented for visual indent
Line 37:36: E127 continuation line over-indented for visual indent

In the file sdc/tests/test_hiframes.py:

Line 45:36: E127 continuation line over-indented for visual indent
Line 46:36: E127 continuation line over-indented for visual indent

In the file sdc/tests/test_io.py:

Line 38:36: E127 continuation line over-indented for visual indent
Line 39:36: E127 continuation line over-indented for visual indent

In the file sdc/tests/test_join.py:

Line 41:36: E127 continuation line over-indented for visual indent
Line 42:36: E127 continuation line over-indented for visual indent

In the file sdc/tests/test_ml.py:

Line 37:36: E127 continuation line over-indented for visual indent
Line 38:36: E127 continuation line over-indented for visual indent

In the file sdc/tests/test_rolling.py:

Line 37:36: E127 continuation line over-indented for visual indent
Line 38:36: E127 continuation line over-indented for visual indent

In the file sdc/tests/test_series.py:

Line 4143:5: E303 too many blank lines (2)

In the file sdc/tests/test_strings.py:

Line 44:1: E302 expected 2 blank lines, found 1

Comment last updated at 2019-11-27 10:30:57 UTC

sdc/tests/test_utils.py

shssf · 2019-11-26T23:15:02Z

From discussion I understand that it is not ready yet to be merged

I know nothing about it. Please ask to merge this PR for people with whom you discussed it

PokhodenkoSA · 2019-11-27T05:48:07Z

From discussion I understand that it is not ready yet to be merged

I know nothing about it. Please ask to merge this PR for people with whom you discussed it

I mean PR #338 - it is PR from @Hardcode84 with porting to Numba master. Yesterday @Hardcode84 said that this PR was not ready to be merged into master yet but it is in master now. As I understand it is better to revert this PR merge. @Hardcode84, is it correct?

So I think the merge of PR #338 to master will be reverted. So for my current PR #340 I take a commit placed in history before the commit where PR #338 was merged to master.

I was afraid that merging #338 to master breaks master and it influence on tests.
My current PR skips tests. So with #338 merged the test results could be different and I will have to redo my job performed in current PR.

…ing config_pipeline_hpat_default.

…(), sdc_jit() and jit(). Tests should use self.jit() instead of sdc.jit().

…skip-test-new-style-master

PokhodenkoSA · 2019-11-27T12:34:01Z

Now #338 is reverted by #342. I have rebased on master and merged #301 for activating new pipeline.

- Move changes from IntelPython#340 here

@overload

…inlining (#407) * remove boost.regex dependency * adapt for get_parfor_reductions interface changes * disable tests due dead code_parfor regression * lambda type_infer quickfix * quick fix * fix define sig * old style: fixes for lambda inlining * fix series combine * some work on df.apply * fix rolling * remove commented code * expected failures * style * changed parfor interface * Set tag numba to ceab10620764d; update llvmlite to 0.31 * Use numpy 1.17; remove builds for numba master * Remove llvmlite version specification for run section in numba recipe * Skip failing tests in new pipeline - Move changes from #340 here * Update numba master commit (#399) * fix functions signatures * update numba master commit * idxmin, idxmax, cumsum workarounds * @overload options * Use numba master for builds in public CI * Fix build of Numba on macOS - Add llvm-openmp and intel-openmp to host section in meta.yaml * Skip 12 failing tests for SDC pipeline - test_df_apply - test_df_apply_branch - test_ts_map_date2 - test_agg_multikey_parallel - test_agg_parallel - test_agg_parallel_std - test_agg_parallel_var - test_agg_seq - test_agg_seq_std - test_agg_seq_str - test_agg_seq_var - test_muti_hiframes_node_filter_agg

Vyacheslav-Smirnov and others added 16 commits October 23, 2019 15:58

Merge pull request IntelPython#17 from IntelPython/master

1ecae07

Merge changes from origin repo

Merge pull request IntelPython#18 from IntelPython/master

f298633

Merge changes from origin repo

Merge pull request IntelPython#20 from IntelPython/master

0ad2636

Merge changes from origin repo

Merge pull request IntelPython#22 from IntelPython/master

6a3b69d

Merge changes from origin repo

Merge pull request IntelPython#23 from IntelPython/master

71f2656

Merge changes from origin repo

Merge pull request IntelPython#26 from IntelPython/master

b3c7719

Merge changes from origin repo

Merge pull request IntelPython#27 from IntelPython/master

fcd587b

Merge changes from origin repo

Merge pull request IntelPython#28 from IntelPython/master

966b2bf

Merge changes from origin repo

Merge pull request IntelPython#29 from IntelPython/master

9c6932b

Merge changes from sdc master

Switch tests to new pipeline

db7d28a

- Expected that ~35% overall tests are failed

Add --skip-smoke-tests option to build with Numba 0.46 to focus on te…

186f75c

…sts now

Remove --skip-smoke-tests from test.py script launch

75ef4d6

Added by mistake

Merge branch 'master' into switch_tests_to_new_pipeline

506b6c3

Merge pull request IntelPython#34 from IntelPython/master

b66eb83

Merge changes from SDC master

Use SDC_CONFIG_PIPELINE_SDC=1 for Travis; Add Linux configuration wit…

384fbb5

…hout MPI

Add empty line in Azure config

f2d2918

PokhodenkoSA commented Nov 26, 2019

View reviewed changes

sdc/tests/test_utils.py Show resolved Hide resolved

PokhodenkoSA added 10 commits November 27, 2019 13:54

Add decorators skip_numba_jit and skip_sdc_jit

33cf163

Add methods numba_jit() and sdc_jit(). Use one in method jit() accord…

9148b8e

…ing config_pipeline_hpat_default.

Remove TestSeriesNumba

da5cf25

Skip tests using @skip_numba_jit

fd1b8e6

Skip test_series_attr4 using @skip_numba_jit

5af18ca

Skip tests using @skip_sdc_jit

c461799

Move skip_numba_jit() and skip_sdc_jit() to test_utils.py

7d39561

Create base class TestCase for all tests. Class has methods numba_jit…

01fd00d

…(), sdc_jit() and jit(). Tests should use self.jit() instead of sdc.jit().

Move TestCase to test_utils.py

e9729b2

Make test_utils.TestCase as base class for all tests

cbefb4c

PokhodenkoSA added 11 commits November 27, 2019 13:54

Skip tests in test_basic using @skip_numba_jit

0a7cdec

Skip tests in test_dataframe using @skip_numba_jit

9a029b3

Skip tests in test_date using @skip_numba_jit

c44c371

Skip tests in test_groupby using @skip_numba_jit

cb87139

Skip tests in test_hiframes using @skip_numba_jit

2066218

Skip tests in test_hpat_jit using @skip_numba_jit

7403c65

Skip tests in test_io using @skip_numba_jit

084643e

Skip tests in test_join using @skip_numba_jit

a836a1f

Skip tests in test_ml using @skip_numba_jit

a983e60

Skip tests in test_rolling using @skip_numba_jit

b60774d

Skip tests in test_strings using @skip_numba_jit

c5004bc

PokhodenkoSA mentioned this pull request Nov 27, 2019

Skip test new style master #343

Closed

Merge remote-tracking branch 'vsm/switch_tests_to_new_pipeline' into …

e7851df

…skip-test-new-style-master

Vyacheslav-Smirnov approved these changes Nov 27, 2019

View reviewed changes

Vyacheslav-Smirnov merged commit 6401f3d into IntelPython:master Nov 27, 2019

Vyacheslav-Smirnov added a commit to Hardcode84/hpat that referenced this pull request Dec 3, 2019

Skip failing tests in new pipeline

8a1a008

- Move changes from IntelPython#340 here

PokhodenkoSA mentioned this pull request Dec 5, 2019

Add support for Series.operator.add in a new-style #305

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Skip tests for CI with SDC_CONFIG_PIPELINE_SDC=False #340

Skip tests for CI with SDC_CONFIG_PIPELINE_SDC=False #340

Uh oh!

PokhodenkoSA commented Nov 26, 2019 •

edited

Loading

Uh oh!

pep8speaks commented Nov 26, 2019 •

edited

Loading

Uh oh!

Uh oh!

shssf commented Nov 26, 2019

Uh oh!

PokhodenkoSA commented Nov 27, 2019 •

edited

Loading

Uh oh!

PokhodenkoSA commented Nov 27, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Skip tests for CI with SDC_CONFIG_PIPELINE_SDC=False #340

Skip tests for CI with SDC_CONFIG_PIPELINE_SDC=False #340

Uh oh!

Conversation

PokhodenkoSA commented Nov 26, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pep8speaks commented Nov 26, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Comment last updated at 2019-11-27 10:30:57 UTC

Uh oh!

Uh oh!

shssf commented Nov 26, 2019

Uh oh!

PokhodenkoSA commented Nov 27, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

PokhodenkoSA commented Nov 27, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

PokhodenkoSA commented Nov 26, 2019 •

edited

Loading

pep8speaks commented Nov 26, 2019 •

edited

Loading

PokhodenkoSA commented Nov 27, 2019 •

edited

Loading