Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FAWE using exclusive build height from PlotSquared #2123

Merged
merged 1 commit into from
Mar 1, 2023

Conversation

SirYwell
Copy link
Member

Overview

Fixes #2120

Description

(FastAsync)WorldEdit uses inclusive heights maximums whereas PlotSquared uses exclusive values. Using the values provided by PlotSquared therefore requires a subtraction by one.

Submitter Checklist

  • Make sure you are opening from a topic branch (/feature/fix/docs/ branch (right side)) and not your main branch.
  • Ensure that the pull request title represents the desired changelog entry.
  • New public fields and methods are annotated with @since TODO.
  • I read and followed the contribution guidelines.

@SirYwell SirYwell requested a review from a team as a code owner February 28, 2023 12:51
@github-actions github-actions bot added the Bugfix This PR fixes a bug label Feb 28, 2023
@NotMyFault NotMyFault merged commit 526e190 into main Mar 1, 2023
@NotMyFault NotMyFault deleted the fix/mixed-inclusive-exclusive-maximums branch March 1, 2023 23:47
@Bobcat00
Copy link

Bobcat00 commented Mar 2, 2023

Looks good. Thanks, guys!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugfix This PR fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FAWE doesn't respect P2 build heights
3 participants