Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#739 homepage styling refactor #58

Merged
merged 19 commits into from
Mar 15, 2023
Merged

Conversation

kelseymcmahon
Copy link
Contributor

@kelseymcmahon kelseymcmahon commented Mar 14, 2023

Description

Updated styles for the home page and added a new page for announcements/features.
Cleaned up the styles sheet and utilized some of the bootstrap classes.
Cleaned up other pages with some padding/margins

Fixes #739 (https://github.com/IntelliTect/EssentialCSharpManuscript/issues/739)

Ensure that your pull request has followed all the steps below:

  • Code compilation
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary

@kelseymcmahon kelseymcmahon self-assigned this Mar 14, 2023
@kelseymcmahon kelseymcmahon marked this pull request as ready for review March 14, 2023 20:10
Copy link
Member

@BenjaminMichaelis BenjaminMichaelis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big fan overall of the changes! Nice job!!

EssentialCSharp.Web/Views/Home/Home.cshtml Outdated Show resolved Hide resolved
EssentialCSharp.Web/wwwroot/sitemap.xml Outdated Show resolved Hide resolved
EssentialCSharp.Web/Views/Shared/_Layout.cshtml Outdated Show resolved Hide resolved
@twofingerrightclick
Copy link
Contributor

@kelseymcmahon perhaps add back padding to the bottom of the content so that the buttons don't go over in the footer?
image

kelseymcmahon and others added 6 commits March 15, 2023 08:36
Co-authored-by: Benjamin Michaelis <benjamin@michaelis.net>
Co-authored-by: Austen Frostad <austen.frostad@intellitect.com>
Co-authored-by: Austen Frostad <austen.frostad@intellitect.com>
@kelseymcmahon kelseymcmahon merged commit ce62bec into main Mar 15, 2023
@kelseymcmahon kelseymcmahon deleted the #739-Homepage-Styling-Refactor branch March 15, 2023 20:48
BenjaminMichaelis added a commit that referenced this pull request Mar 15, 2023
* removing home mindmap and adding new colors

* wip

* adding homepage styles

* adding edits

* cleaning

* adding anoucements page

* edits

* adding small edits

* fixing annoucements

* cleaning font sizes

* Update EssentialCSharp.Web/Views/Home/Home.cshtml

Co-authored-by: Benjamin Michaelis <benjamin@michaelis.net>

* Update EssentialCSharp.Web/wwwroot/css/styles.css

Co-authored-by: Austen Frostad <austen.frostad@intellitect.com>

* Update EssentialCSharp.Web/wwwroot/css/styles.css

Co-authored-by: Austen Frostad <austen.frostad@intellitect.com>

* editing page tooltips

* removing generated sitemap

---------

Co-authored-by: KelseyMcMahon <kelsey.mcmahon@intellitect.com>
Co-authored-by: Benjamin Michaelis <benjamin@michaelis.net>
Co-authored-by: Austen Frostad <austen.frostad@intellitect.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants