-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#739 homepage styling refactor #58
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kelseymcmahon
requested review from
Keboo,
twofingerrightclick and
BenjaminMichaelis
March 14, 2023 20:02
BenjaminMichaelis
approved these changes
Mar 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Big fan overall of the changes! Nice job!!
@kelseymcmahon perhaps add back padding to the bottom of the content so that the buttons don't go over in the footer? |
Co-authored-by: Benjamin Michaelis <benjamin@michaelis.net>
Co-authored-by: Austen Frostad <austen.frostad@intellitect.com>
Co-authored-by: Austen Frostad <austen.frostad@intellitect.com>
BenjaminMichaelis
added a commit
that referenced
this pull request
Mar 15, 2023
* removing home mindmap and adding new colors * wip * adding homepage styles * adding edits * cleaning * adding anoucements page * edits * adding small edits * fixing annoucements * cleaning font sizes * Update EssentialCSharp.Web/Views/Home/Home.cshtml Co-authored-by: Benjamin Michaelis <benjamin@michaelis.net> * Update EssentialCSharp.Web/wwwroot/css/styles.css Co-authored-by: Austen Frostad <austen.frostad@intellitect.com> * Update EssentialCSharp.Web/wwwroot/css/styles.css Co-authored-by: Austen Frostad <austen.frostad@intellitect.com> * editing page tooltips * removing generated sitemap --------- Co-authored-by: KelseyMcMahon <kelsey.mcmahon@intellitect.com> Co-authored-by: Benjamin Michaelis <benjamin@michaelis.net> Co-authored-by: Austen Frostad <austen.frostad@intellitect.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated styles for the home page and added a new page for announcements/features.
Cleaned up the styles sheet and utilized some of the bootstrap classes.
Cleaned up other pages with some padding/margins
Fixes #739 (https://github.com/IntelliTect/EssentialCSharpManuscript/issues/739)
Ensure that your pull request has followed all the steps below: