-
-
Notifications
You must be signed in to change notification settings - Fork 27
Fix issue #1749 - type-of NIL doesn't match CLtL2 #1753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The commented hunk is correct and complete. All other changes in this PR are whitespace or editor/files package artifacts. If project policy is to allow committing arbitrary formatting and metadata changes with code, I believe this change can be applied as-is and will resolve #1749. If project policy discourages this, the size of this PR diff should be reduced appropriately.
man GITFNS
should show you the documentation. You should be able to get it by (LOAD 'GITFNS.LCOM).
The command you want is prc (pull-request-compare).
… On Jun 8, 2024, at 4:54 PM, Ethan Blanton ***@***.***> wrote:
@eblanton commented on this pull request.
In sources/CMLTYPES <#1753 (comment)>:
> -(DEFUN SYMBOL-TYPE (SYMBOL)
- (IF (KEYWORDP SYMBOL)
- 'KEYWORD
- 'SYMBOL))
+(DEFUN SYMBOL-TYPE (SYMBOL) (IL:* IL:\; "Edited 4-Jun-2024 23:23 by mth")
+ (COND
+ ((NULL SYMBOL)
+ 'NULL)
+ ((KEYWORDP SYMBOL)
+ 'KEYWORD)
+ (T 'SYMBOL)))
I'd be interested to know about that tool, it was a lot of scrolling through that diff to find the real change! Is there a process guide here somewhere?
—
Reply to this email directly, view it on GitHub <#1753 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AQSTUJMTRYBR446BDAYWN3DZGOKUVAVCNFSM6AAAAABI53VKNWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCMBWGAYDCMRQGE>.
You are receiving this because you are subscribed to this thread.
|
Decided that we need to find and verify that nothing depends on the old behavior before merging. |
@masinter While checking for possible changes in behavior due to the change in |
I run with SYSEDIT which currently sets COPYRIGHTFLG to NEVER. I should do more research into what other similar projects do. Or we could ask the SPN "Law and Policy" working group for a consultation? In the meanwhile, I recomend setting COPYRIGHTFLG to NEVER and MAKEFILE away. |
Adds a "special case" to
CL::SYMBOL-TYPE
so(type-of NIL)
behaves according to CLtL2.Reported in Issue #1749