Skip to content

FONTSAMPLER - Enable option to use HEX vs OCTAL on page info #2018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 22, 2025
Merged

FONTSAMPLER - Enable option to use HEX vs OCTAL on page info #2018

merged 2 commits into from
Feb 22, 2025

Conversation

MattHeffron
Copy link
Contributor

Enable option to use HEX vs OCTAL for charset number (in page title) and grid row/column titles.
Updated doc file.

@MattHeffron MattHeffron added the enhancement New feature or request label Feb 6, 2025
@MattHeffron MattHeffron self-assigned this Feb 6, 2025
@MattHeffron MattHeffron mentioned this pull request Feb 6, 2025
Merged
pamoroso
pamoroso previously approved these changes Feb 9, 2025
View reviewed changes
Copy link
Contributor

@pamoroso pamoroso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this PR and it works as described. In the sentence "If Hexadecimal is non-NIL, [...]" of the TEdit documentation the function parameter Hexadecimal is not in italics, whereas other parameters in the same document are in italics.

@MattHeffron
Copy link
Contributor Author

In the sentence "If Hexadecimal is non-NIL, [...]" of the TEdit documentation the function parameter Hexadecimal is not in italics, whereas other parameters in the same document are in italics.

Addressed in latest commit: 427fe60. No code changes.

@MattHeffron MattHeffron requested a review from pamoroso February 20, 2025 04:38
pamoroso
pamoroso approved these changes Feb 20, 2025
View reviewed changes
Copy link
Contributor

@pamoroso pamoroso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It still works fine.

@masinter masinter merged commit 736ac51 into master Feb 22, 2025
@MattHeffron MattHeffron deleted the mth37--FONTSAMPLER-allow-hex-vs-octal branch July 27, 2025 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pamoroso pamoroso pamoroso approved these changes

@hjellinek hjellinek Awaiting requested review from hjellinek

@nbriggs nbriggs Awaiting requested review from nbriggs

@rmkaplan rmkaplan Awaiting requested review from rmkaplan

Assignees

@MattHeffron MattHeffron

Labels
enhancement New feature or request
Projects
fonts/unicode
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MattHeffron @pamoroso @masinter