Skip to content

Conversation

rmkaplan
Copy link
Contributor

@rmkaplan rmkaplan commented Apr 1, 2025

Pretty much just an internal cleanup to make the distinction between public and private versions of the NTHCHAR functions. The public versions do more argument coercion, the private versions do the work, and they are gradually being used more often in internal code.

This also fixes a bug in the screen update when the caret is positioned to the left of the first character of the top line of a window, and that character is deleted. That presumably deletes the space at the end of the unseen line above, but the last unseen word was not being moved down to the beginning of the top-line.

@pamoroso
Copy link
Contributor

pamoroso commented Apr 1, 2025

I tested this change on Linux Mint 22 Cinnamon and couldn't reproduce the bug.

@pamoroso
Copy link
Contributor

pamoroso commented Apr 1, 2025

I can't reproduce the bug on master either, so I'm likely testing it wrong. Here's what I do:

  1. open TEdit
  2. type a
  3. press the left arrow key to move the caret at the beginning of the line with a
  4. press Ctrl and middle-select a to delete it

At this point I don't notice any rendering issues on main.

@rmkaplan
Copy link
Contributor Author

rmkaplan commented Apr 1, 2025 via email

@pamoroso
Copy link
Contributor

pamoroso commented Apr 1, 2025

Here is a quick test I did on master. I typed a short paragraph in TEdit:

tedit-bug1

Next, after scrolling the window to have a top line in the window and a hidden preceeding line, I placed the caret at the beginning of the top line:

tedit-bug2

Finally, I typed Backspace:

tedit-bug3

Does this exhibit the issue?

Copy link
Member

@masinter masinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

discussed 4/7/25 meeting

@rmkaplan rmkaplan merged commit cd38898 into master Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants