Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it build with ghc-9.8 #3877

Merged
merged 2 commits into from
Jan 5, 2024
Merged

Make it build with ghc-9.8 #3877

merged 2 commits into from
Jan 5, 2024

Conversation

erikd
Copy link
Contributor

@erikd erikd commented Nov 17, 2023

Description

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@erikd erikd marked this pull request as draft November 17, 2023 03:13
@erikd erikd force-pushed the erikd/ghc-9.8 branch 6 times, most recently from 4fab483 to 5e0cca7 Compare November 26, 2023 23:17
@erikd erikd force-pushed the erikd/ghc-9.8 branch 2 times, most recently from 55bde13 to 843d9cd Compare November 28, 2023 22:25
@erikd erikd marked this pull request as ready for review November 28, 2023 22:25
@erikd erikd requested review from a team as code owners November 28, 2023 22:25
cabal.project Outdated Show resolved Hide resolved
@erikd erikd force-pushed the erikd/ghc-9.8 branch 2 times, most recently from dd59a87 to 459c1ff Compare November 29, 2023 05:03
cabal.project Outdated Show resolved Hide resolved
Copy link
Contributor

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As always, thank you for doing this compatibility work! We greatly appreciate it!

.github/workflows/haskell.yml Outdated Show resolved Hide resolved
cabal.project Outdated Show resolved Hide resolved
libs/ledger-state/src/Cardano/Ledger/State/UTxO.hs Outdated Show resolved Hide resolved
libs/ledger-state/src/Cardano/Ledger/State/UTxO.hs Outdated Show resolved Hide resolved
cabal.project Outdated Show resolved Hide resolved
@erikd
Copy link
Contributor Author

erikd commented Nov 29, 2023

Didn't you take care of the head and tail functions in this PR, or there are still some left over uses of those?

@lehins I did not touch these functions because I thought I would leave it to the ledger maintainers to sort it out how they see fit.

@michaelpj
Copy link
Contributor

Yeah, I doubt this needs to be merged soon, and in a week or so there will be a plutus release with some initial 9.8 support (still needing some allow-newers).

@erikd erikd force-pushed the erikd/ghc-9.8 branch 5 times, most recently from b92adac to 44aab00 Compare December 7, 2023 00:17
@erikd erikd force-pushed the erikd/ghc-9.8 branch 2 times, most recently from f8a0c9d to a6ef520 Compare December 12, 2023 01:44
@erikd erikd force-pushed the erikd/ghc-9.8 branch 3 times, most recently from 9bd0c1f to 10b2d09 Compare December 12, 2023 02:24
@erikd
Copy link
Contributor Author

erikd commented Dec 12, 2023

This PR no longer uses any SRPs other than cardano-ledger-executable-spec, so IMO is ready to be merged.

Copy link
Contributor

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the changes are unnecessary and there are bunch of version bumps missing. I know that dealing with compatibility is not the most exciting part of writing programs, so thank you for doing this work!

cabal.project Outdated Show resolved Hide resolved
eras/shelley/impl/src/Cardano/Ledger/Shelley/Rules/Upec.hs Outdated Show resolved Hide resolved
libs/cardano-ledger-test/cardano-ledger-test.cabal Outdated Show resolved Hide resolved
eras/conway/impl/cardano-ledger-conway.cabal Outdated Show resolved Hide resolved
libs/non-integral/non-integral.cabal Show resolved Hide resolved
libs/set-algebra/set-algebra.cabal Show resolved Hide resolved
libs/small-steps-test/small-steps-test.cabal Show resolved Hide resolved
Copy link
Contributor

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful. Thank you!

@lehins lehins merged commit 79f29a3 into master Jan 5, 2024
13 of 30 checks passed
@neilmayhew neilmayhew deleted the erikd/ghc-9.8 branch March 8, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants