-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make it build with ghc-9.8 #3877
Conversation
eras/shelley-ma/test-suite/cardano-ledger-shelley-ma-test.cabal
Outdated
Show resolved
Hide resolved
4fab483
to
5e0cca7
Compare
55bde13
to
843d9cd
Compare
dd59a87
to
459c1ff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As always, thank you for doing this compatibility work! We greatly appreciate it!
libs/cardano-ledger-test/src/Test/Cardano/Ledger/Generic/TxGen.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-test/src/Test/Cardano/Ledger/Generic/TxGen.hs
Outdated
Show resolved
Hide resolved
@lehins I did not touch these functions because I thought I would leave it to the |
Yeah, I doubt this needs to be merged soon, and in a week or so there will be a plutus release with some initial 9.8 support (still needing some allow-newers). |
b92adac
to
44aab00
Compare
f8a0c9d
to
a6ef520
Compare
9bd0c1f
to
10b2d09
Compare
This PR no longer uses any SRPs other than |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of the changes are unnecessary and there are bunch of version bumps missing. I know that dealing with compatibility is not the most exciting part of writing programs, so thank you for doing this work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful. Thank you!
Description
Checklist
.cabal
andCHANGELOG.md
files according to theversioning process.
.cabal
files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.md
for the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu
(usescripts/fourmolize.sh
)scripts/cabal-format.sh
)hie.yaml
has been updated (usescripts/gen-hie.sh
)