Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate DRep expiry test from ConwayFeatures to Imp GovSpec #3892

Merged
merged 4 commits into from
Dec 8, 2023

Conversation

teodanciu
Copy link
Contributor

Description

Closes #3805

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@teodanciu teodanciu force-pushed the td/replace-conwayfeatures-with-imp branch from 19868d3 to 05123d9 Compare December 5, 2023 14:38
@teodanciu teodanciu force-pushed the td/replace-conwayfeatures-with-imp branch 2 times, most recently from c791d50 to af3b3da Compare December 6, 2023 16:00
@teodanciu teodanciu marked this pull request as ready for review December 6, 2023 16:01
@teodanciu teodanciu force-pushed the td/replace-conwayfeatures-with-imp branch 2 times, most recently from e715a79 to cf914ae Compare December 6, 2023 17:02
@teodanciu teodanciu requested a review from lehins December 6, 2023 18:11
@teodanciu teodanciu force-pushed the td/replace-conwayfeatures-with-imp branch 4 times, most recently from ec9b8a0 to f6eedc6 Compare December 7, 2023 18:34
@teodanciu teodanciu force-pushed the td/replace-conwayfeatures-with-imp branch from f6eedc6 to 56c60d3 Compare December 7, 2023 21:48
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@teodanciu teodanciu enabled auto-merge December 7, 2023 22:02
@teodanciu teodanciu merged commit bcf6051 into master Dec 8, 2023
10 of 24 checks passed
@iohk-bors iohk-bors bot deleted the td/replace-conwayfeatures-with-imp branch December 8, 2023 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Translate ConwayFeatures to ImpTest
2 participants