Change type of mintedTxBodyL to PolicyID
#3930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lehins
force-pushed
the
lehins/minted-to-policyId
branch
2 times, most recently
from
71b9696 to
f0e0874
Compare
Soupstraw
reviewed
Dec 14, 2023
Soupstraw
reviewed
Dec 14, 2023
* `decodeListLikeT` and `decodeListLike` are useful for any list like type that cannot use Coders. * Change the first argument of `decodeRecordSum` to `Text` for consistency with `decodeRecordNamed` and the `Plain.decodeRecordSum * Also change argument of `Summonds` from `String` to `Text` for consistency and because it uses `decodeRecordSum`
lehins
force-pushed
the
lehins/minted-to-policyId
branch
from
f0e0874 to
354589a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Besides changing type of
mintedTxBodyLtoPolicyIDthis PR also:decodeListLikeTanddecodeListLikedecodeRecordSumandSummondsfromStringtoTextfor consistency.Cardano.Ledger.Babbage.TxBodyChecklist
.cabalandCHANGELOG.mdfiles according to theversioning process.
.cabalfiles for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.mdfor the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu(usescripts/fourmolize.sh)scripts/cabal-format.sh)hie.yamlhas been updated (usescripts/gen-hie.sh)