Change the type of some pparam fields to align with how they are represented in Consensus #3947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimSheard
changed the title
TimSheard
force-pushed
the
ts-pparam-type-changes
branch
4 times, most recently
from
99dfa37 to
d943495
Compare
lehins
reviewed
Dec 27, 2023
eras/shelley/test-suite/src/Test/Cardano/Ledger/Shelley/Generator/Update.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-test/src/Test/Cardano/Ledger/Constrained/Preds/PParams.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-test/src/Test/Cardano/Ledger/Constrained/Vars.hs
Outdated
Show resolved
Hide resolved
libs/cardano-protocol-tpraos/src/Cardano/Protocol/TPraos/BHeader.hs
Outdated
Show resolved
Hide resolved
TimSheard
force-pushed
the
ts-pparam-type-changes
branch
3 times, most recently
from
7e970d7 to
290ff71
Compare
lehins
requested changes
Dec 28, 2023
TimSheard
force-pushed
the
ts-pparam-type-changes
branch
from
e802c4e to
8e27913
Compare
lehins
reviewed
Dec 29, 2023
lehins
reviewed
Dec 29, 2023
lehins
reviewed
Dec 29, 2023
eras/shelley/test-suite/src/Test/Cardano/Ledger/Shelley/Generator/Update.hs
Outdated
Show resolved
Hide resolved
lehins
reviewed
Dec 29, 2023
eras/shelley/test-suite/src/Test/Cardano/Ledger/Shelley/Generator/Update.hs
Outdated
Show resolved
Hide resolved
lehins
reviewed
Dec 29, 2023
eras/shelley/test-suite/src/Test/Cardano/Ledger/Shelley/Generator/Update.hs
Outdated
Show resolved
Hide resolved
…d related fields and Lenses) from EpochNo to EpochInterval
Adjust random generation of Tests, to meet reduced scope (Word16) of MaxBHSize. Apply suggestions from code review Co-authored-by: Alexey Kuleshevich <alexey.kuleshevich@iohk.io> Added function fromIntegralBounded.
TimSheard
force-pushed
the
ts-pparam-type-changes
branch
from
8e27913 to
2e6ca95
Compare
This was referenced Dec 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #3942, issue #3905, and issue #3906
Changes a few PParam fields to Word32 and Word16 to align with how they are represents in Consensus.
Also changed 2 fields in the type BHeaderView, to align with the PParams changes
Checklist
.cabalandCHANGELOG.mdfiles according to theversioning process.
.cabalfiles for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.mdfor the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu(usescripts/fourmolize.sh)scripts/cabal-format.sh)hie.yamlhas been updated (usescripts/gen-hie.sh)