-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conway genesis DRep injection #3951
Conversation
378160d
to
9954538
Compare
3a781ec
to
a4e56b4
Compare
a4e56b4
to
bff8a79
Compare
bff8a79
to
0f76765
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addition of new fields looks good for the most part. Injection is totally wrong. Please, let me know if you get stuck or if my comments are not clear enough.
14a3699
to
dbc2d52
Compare
dbc2d52
to
3bcab92
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Thank you!
6156135
to
2de88a4
Compare
2de88a4
to
4ad6847
Compare
Description
This PR adds
cgDRepDelegs
andcgInitialDReps
fields toConwayGenesis
so the benchmark team can inject DReps and DRep delegations into the state.The actual injection is done via
registerDRepDelegs
andregisterInitialDReps
, which are exported in the API.Checklist
.cabal
andCHANGELOG.md
files according to theversioning process.
.cabal
files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.md
for the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu
(usescripts/fourmolize.sh
)scripts/cabal-format.sh
)hie.yaml
has been updated (usescripts/gen-hie.sh
)